[OpenJDK 2D-Dev] [PATCH] SurfaceManagerFactory

Roman Kennke roman.kennke at aicas.com
Tue Feb 26 19:08:34 UTC 2008

Hi Dmitri,

>    the change looks mostly fine to me.


>    One thing - have you tested your change with the
>    headless toolkit?

I haven't tested it, but it appears that in the headless case the
factory is never used anyway (from SunVolatileImage):

    protected VolatileSurfaceManager createSurfaceManager(Object
context, ImageCapabilities caps)
        if (graphicsConfig instanceof BufferedImageGraphicsConfig ||
            graphicsConfig instanceof sun.print.PrinterGraphicsConfig ||
            (caps != null && !caps.isAccelerated()))
            return new BufImgVolatileSurfaceManager(this, context);
        SurfaceManagerFactory smf =
        return smf.createVolatileManager(this, context);

This makes sense, because BufImgVolatileSurfaceManager is required for
all targets.

Cheers, Roman

Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-0
USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe
Geschäftsführer: Dr. James J. Hunt

More information about the 2d-dev mailing list