From jeremymanson at google.com  Thu Oct  1 12:11:02 2009
From: jeremymanson at google.com (Jeremy Manson)
Date: Thu, 1 Oct 2009 12:11:02 -0700
Subject: [OpenJDK 2D-Dev] Deadlock in SunGraphicsEnvironment /
	FontManager?
In-Reply-To: <bf03e3fa0909231716u3064ab33vc0a4ac19c3035182@mail.gmail.com>
References: <bf03e3fa0909231716u3064ab33vc0a4ac19c3035182@mail.gmail.com>
Message-ID: <bf03e3fa0910011211l43b06321r757df83d76365810@mail.gmail.com>

Does anyone have any thoughts about this?  If we were to make up a
patch, would you take it?

I did get an email about how this should all be single threaded on an
event dispatcher thread, to which I would reply:

1) If it is all supposed to be single threaded, then there shouldn't
be any locks in it to cause a deadlock, and

2) This is in the font code, and you can use fonts for things other
than drawing to the screen (in this case, they are trying to render a
PDF).

Jeremy

On Wed, Sep 23, 2009 at 5:16 PM, Jeremy Manson <jeremymanson at google.com> wrote:
> Hi 2d folks,
>
> We have an application running on OpenJDK6 that seems to be
> deadlocking in SunGraphicsEnvironment. ?I found it rather difficult to
> write a cut-down reproduction, but the errant lock acquisition is on
> line 482 of SunGraphicsEnvironment.java.:
>
> http://hg.openjdk.java.net/jdk6/jdk6-gate/jdk/file/f9fa5c538031/src/share/classes/sun/java2d/SunGraphicsEnvironment.java
>
> After the lock is acquired, it goes on to call
> FontManager.initialiseDeferredFonts() on line 467, which acquires the
> other lock. ?It looks as if you might be able to move the lock
> acquisition from line 462 to 468, which would eliminate the deadlock.
> The code looks pretty similar in recent OpenJDK7 builds (although the
> line numbers are changed).
>
> The relevant stacks follow. ?It seems like a pretty easy fix for a
> pretty nasty problem. ?Any chance someone could take a look? ?Thanks!
>
> Thread 1:
> ?sun.font.FontManager.initialiseDeferredFonts(FontManager.java:791)
> ?sun.java2d.SunGraphicsEnvironment.loadFonts(SunGraphicsEnvironment.java:467)
> ?sun.awt.X11GraphicsEnvironment.loadFonts(X11GraphicsEnvironment.java:885)
> ?sun.font.FontManager.findFont2D(FontManager.java:1995)
> ?java.awt.Font.getFont2D(Font.java:473)
> ?java.awt.Font.getFontName(Font.java:1221)
> ?java.awt.Font.getFontName(Font.java:1203)
>
> Thread 2:
> ?sun.java2d.SunGraphicsEnvironment.loadFonts(SunGraphicsEnvironment.java:463)
> ?sun.awt.X11GraphicsEnvironment.loadFonts(X11GraphicsEnvironment.java:885)
> ?sun.font.FontManager.findFont2D(FontManager.java:1995)
> ?sun.font.FontManager.getDefaultPhysicalFont(FontManager.java:1071)
> ?sun.font.FontManager.initialiseDeferredFont(FontManager.java:960)
> ?sun.font.FontManager.findJREDeferredFont(FontManager.java:875)
> ?sun.font.FontManager.findDeferredFont(FontManager.java:912)
> ?<snip lots of recursion>
> ?sun.font.FontManager.findFont2D(FontManager.java:1904)
> ?sun.font.FontManager.findFont2D(FontManager.java:1865)
> ?java.awt.Font.getFont2D(Font.java:473)
> ?java.awt.Font.getFontName(Font.java:1221)
> ?java.awt.Font.getFontName(Font.java:1203)
>


From Roman.Kennke at Sun.COM  Thu Oct  1 13:33:11 2009
From: Roman.Kennke at Sun.COM (Roman Kennke)
Date: Thu, 01 Oct 2009 22:33:11 +0200
Subject: [OpenJDK 2D-Dev] Review request for bug 100053
Message-ID: <1254429191.12387.33.camel@moonlight>

Hi guys,

This patch here fixes the NPE in Pisces renderer as reported in:

https://bugs.openjdk.java.net/show_bug.cgi?id=100053

The webrev is here:

http://cr.openjdk.java.net/~rkennke/100053/webrev.00/

It basically adds nullchecks in the offending code. As far as I can see
this should be sufficient because these arrays are only accessed in the
scope of endRendering(). A testcase is also included.

Thanks, Roman




From Dmitri.Trembovetski at Sun.COM  Thu Oct  1 13:49:54 2009
From: Dmitri.Trembovetski at Sun.COM (Dmitri Trembovetski)
Date: Thu, 01 Oct 2009 13:49:54 -0700
Subject: [OpenJDK 2D-Dev] Review request for bug 100053
In-Reply-To: <1254429191.12387.33.camel@moonlight>
References: <1254429191.12387.33.camel@moonlight>
Message-ID: <4AC515F2.7000304@Sun.COM>


   Hi Roman,

   a comment about the test: would the bug reproduce if you just rendered into a 
BufferedImage? If so, no need for creating a frame and such.

   Regarding the fix, it looks ok - but there are other places in the code where 
the 'crossings' is accessed - are those safe from an NPE?

   Thanks,
     Dmitri


Roman Kennke wrote:
> Hi guys,
> 
> This patch here fixes the NPE in Pisces renderer as reported in:
> 
> https://bugs.openjdk.java.net/show_bug.cgi?id=100053
> 
> The webrev is here:
> 
> http://cr.openjdk.java.net/~rkennke/100053/webrev.00/
> 
> It basically adds nullchecks in the offending code. As far as I can see
> this should be sufficient because these arrays are only accessed in the
> scope of endRendering(). A testcase is also included.
> 
> Thanks, Roman
> 
> 


From Roman.Kennke at Sun.COM  Thu Oct  1 14:13:26 2009
From: Roman.Kennke at Sun.COM (Roman Kennke)
Date: Thu, 01 Oct 2009 23:13:26 +0200
Subject: [OpenJDK 2D-Dev] Review request for bug 100053
In-Reply-To: <4AC515F2.7000304@Sun.COM>
References: <1254429191.12387.33.camel@moonlight> <4AC515F2.7000304@Sun.COM>
Message-ID: <1254431606.24774.4.camel@moonlight>

Hi Dmitri,

>    a comment about the test: would the bug reproduce if you just rendered into a 
> BufferedImage? If so, no need for creating a frame and such.

Oh yes. Stupid me :-)

>    Regarding the fix, it looks ok - but there are other places in the code where 
> the 'crossings' is accessed - are those safe from an NPE?

I followed all usages of crossings and crossingsIndices and they all end
up in endRendering(). There is a loop at the beginning of which the
arrays get initialized using setCrossingsExtends(). The problem occured
when this loop was never entered, in that case we hit
crossingListFinished() with (possibly) null arrays. There I added the
null checks and it should cover all potential NPEs on these arrays.

The updated webrev is:

http://cr.openjdk.java.net/~rkennke/100053/webrev.01/

Ok now?

Thanks, Roman




From Dmitri.Trembovetski at Sun.COM  Thu Oct  1 14:47:01 2009
From: Dmitri.Trembovetski at Sun.COM (Dmitri Trembovetski)
Date: Thu, 01 Oct 2009 14:47:01 -0700
Subject: [OpenJDK 2D-Dev] Review request for bug 100053
In-Reply-To: <1254431606.24774.4.camel@moonlight>
References: <1254429191.12387.33.camel@moonlight> <4AC515F2.7000304@Sun.COM>
	<1254431606.24774.4.camel@moonlight>
Message-ID: <4AC52355.2030307@Sun.COM>


   Hi Roman,

Roman Kennke wrote:
> Hi Dmitri,
> 
>>    a comment about the test: would the bug reproduce if you just rendered into a 
>> BufferedImage? If so, no need for creating a frame and such.
> 
> Oh yes. Stupid me :-)
> 
>>    Regarding the fix, it looks ok - but there are other places in the code where 
>> the 'crossings' is accessed - are those safe from an NPE?
> 
> I followed all usages of crossings and crossingsIndices and they all end
> up in endRendering(). There is a loop at the beginning of which the
> arrays get initialized using setCrossingsExtends(). The problem occured
> when this loop was never entered, in that case we hit
> crossingListFinished() with (possibly) null arrays. There I added the
> null checks and it should cover all potential NPEs on these arrays.
> 
> The updated webrev is:
> 
> http://cr.openjdk.java.net/~rkennke/100053/webrev.01/
> 
> Ok now?

   Yes, looks fine.

   Thanks,
     Dmitri


> 
> Thanks, Roman
> 
> 


From Phil.Race at Sun.COM  Thu Oct  1 15:18:24 2009
From: Phil.Race at Sun.COM (Phil Race)
Date: Thu, 01 Oct 2009 15:18:24 -0700
Subject: [OpenJDK 2D-Dev] Deadlock in SunGraphicsEnvironment
	/	FontManager?
In-Reply-To: <bf03e3fa0910011211l43b06321r757df83d76365810@mail.gmail.com>
References: <bf03e3fa0909231716u3064ab33vc0a4ac19c3035182@mail.gmail.com>
	<bf03e3fa0910011211l43b06321r757df83d76365810@mail.gmail.com>
Message-ID: <4AC52AB0.3000909@sun.com>



Jeremy Manson wrote:
> Does anyone have any thoughts about this?  If we were to make up a
> patch, would you take it?

In summary the situation looks like this, (although your dumps
aren't showing the locks, which I'd expected to see) :

Thread 1 -> SunGraphicsEnvironment.loadFonts()
               [locked on SunGraphicsEnvironment.lucidaFontName]
Thread 2 -> FontManager.initialiseDeferredFonts()
               [ locked on FontManager.class]
Thread 1 -> FontManager.initialiseDeferredFonts()
               [ .. waiting for lock on FontManager.class]
Thread 1 -> SunGraphicsEnvironment.loadFonts()
               [ .. waiting for lock on SunGraphicsEnvironment.lucidaFontName ]


I'm not sure that the fix you suggest of moving the lock acquistion after
       467             FontManager.initialiseDeferredFonts();
is guaranteed to be sufficient. This next line (and perhaps others) :
       473                         fontPath = getPlatformFontPath(noType1Font);

will also also acquire the lock. Another option is to simplify this down
to one lock : the FontManager.class one, using it instead of the
SunGraphicsEnvironment.lucidaFontName lock which I think was used
in preference to the normal FontManager lock to make sure that
this lengthy loadfonts operation didn't freeze the rest of the font system
until it completed.
That should still be a concern, albeit less of a one than a deadlock.
Another approach might be to eliminate the lock here and rely on
checks in the registration methods by font file name to skip
over much of the duplicate work that might ensue from letting
two threads have at this at the same time. But that would need
even more careful testing than the other approach. I think either
approach should to be tested on Windows as well.

> 
> I did get an email about how this should all be single threaded on an
> event dispatcher thread, to which I would reply:
> 
> 1) If it is all supposed to be single threaded, then there shouldn't
> be any locks in it to cause a deadlock, and
> 
> 2) This is in the font code, and you can use fonts for things other
> than drawing to the screen (in this case, they are trying to render a
> PDF).

You are correct on this.
Its interesting that its taken this long to show up. I suspect that
you are running on a Linux system with a lot of fonts and its the
amount of time you end spending in loadFonts() that contributes
to another thread showing up in the middle of it.

You could
(a) trigger a load fonts (GraphicsEnvironment.getAllFonts()) at some
known safe point in your app, or
(b) try to avoid it. This might be tricky as if your app needs to
go hunt down fonts at some point you'll hit loadfonts().



-phil.

> 
> Jeremy
> 
> On Wed, Sep 23, 2009 at 5:16 PM, Jeremy Manson <jeremymanson at google.com> wrote:
>> Hi 2d folks,
>>
>> We have an application running on OpenJDK6 that seems to be
>> deadlocking in SunGraphicsEnvironment.  I found it rather difficult to
>> write a cut-down reproduction, but the errant lock acquisition is on
>> line 482 of SunGraphicsEnvironment.java.:
>>
>> http://hg.openjdk.java.net/jdk6/jdk6-gate/jdk/file/f9fa5c538031/src/share/classes/sun/java2d/SunGraphicsEnvironment.java
>>
>> After the lock is acquired, it goes on to call
>> FontManager.initialiseDeferredFonts() on line 467, which acquires the
>> other lock.  It looks as if you might be able to move the lock
>> acquisition from line 462 to 468, which would eliminate the deadlock.
>> The code looks pretty similar in recent OpenJDK7 builds (although the
>> line numbers are changed).
>>
>> The relevant stacks follow.  It seems like a pretty easy fix for a
>> pretty nasty problem.  Any chance someone could take a look?  Thanks!
>>
>> Thread 1:
>>  sun.font.FontManager.initialiseDeferredFonts(FontManager.java:791)
>>  sun.java2d.SunGraphicsEnvironment.loadFonts(SunGraphicsEnvironment.java:467)
>>  sun.awt.X11GraphicsEnvironment.loadFonts(X11GraphicsEnvironment.java:885)
>>  sun.font.FontManager.findFont2D(FontManager.java:1995)
>>  java.awt.Font.getFont2D(Font.java:473)
>>  java.awt.Font.getFontName(Font.java:1221)
>>  java.awt.Font.getFontName(Font.java:1203)
>>
>> Thread 2:
>>  sun.java2d.SunGraphicsEnvironment.loadFonts(SunGraphicsEnvironment.java:463)
>>  sun.awt.X11GraphicsEnvironment.loadFonts(X11GraphicsEnvironment.java:885)
>>  sun.font.FontManager.findFont2D(FontManager.java:1995)
>>  sun.font.FontManager.getDefaultPhysicalFont(FontManager.java:1071)
>>  sun.font.FontManager.initialiseDeferredFont(FontManager.java:960)
>>  sun.font.FontManager.findJREDeferredFont(FontManager.java:875)
>>  sun.font.FontManager.findDeferredFont(FontManager.java:912)
>>  <snip lots of recursion>
>>  sun.font.FontManager.findFont2D(FontManager.java:1904)
>>  sun.font.FontManager.findFont2D(FontManager.java:1865)
>>  java.awt.Font.getFont2D(Font.java:473)
>>  java.awt.Font.getFontName(Font.java:1221)
>>  java.awt.Font.getFontName(Font.java:1203)
>>


From Jim.A.Graham at Sun.COM  Thu Oct  1 16:07:06 2009
From: Jim.A.Graham at Sun.COM (Jim Graham)
Date: Thu, 01 Oct 2009 16:07:06 -0700
Subject: [OpenJDK 2D-Dev] Review request for bug 100053
In-Reply-To: <4AC52355.2030307@Sun.COM>
References: <1254429191.12387.33.camel@moonlight> <4AC515F2.7000304@Sun.COM>
	<1254431606.24774.4.camel@moonlight> <4AC52355.2030307@Sun.COM>
Message-ID: <0KQU0050JYVUAF40@fe-sfbay-09.sun.com>

I could go too ways on this.

It looks like the code is looking to drop arrays that have grown so that 
it doesn't waste memory.  Do we reuse these objects?  If not, then the 
code can be deleted.

If we do reuse them, then why not just set them to null and let them get 
recreated the next time rather than allocate something which may not get 
used for a while?

In either case, if the array was null, is there a need to allocate one? 
  Shouldn't it be "if (array != null && array.length > DEFAULT)"?

			...jim

Dmitri Trembovetski wrote:
> 
>   Hi Roman,
> 
> Roman Kennke wrote:
>> Hi Dmitri,
>>
>>>    a comment about the test: would the bug reproduce if you just 
>>> rendered into a BufferedImage? If so, no need for creating a frame 
>>> and such.
>>
>> Oh yes. Stupid me :-)
>>
>>>    Regarding the fix, it looks ok - but there are other places in the 
>>> code where the 'crossings' is accessed - are those safe from an NPE?
>>
>> I followed all usages of crossings and crossingsIndices and they all end
>> up in endRendering(). There is a loop at the beginning of which the
>> arrays get initialized using setCrossingsExtends(). The problem occured
>> when this loop was never entered, in that case we hit
>> crossingListFinished() with (possibly) null arrays. There I added the
>> null checks and it should cover all potential NPEs on these arrays.
>>
>> The updated webrev is:
>>
>> http://cr.openjdk.java.net/~rkennke/100053/webrev.01/
>>
>> Ok now?
> 
>   Yes, looks fine.
> 
>   Thanks,
>     Dmitri
> 
> 
>>
>> Thanks, Roman
>>
>>


From Roman.Kennke at Sun.COM  Fri Oct  2 06:49:15 2009
From: Roman.Kennke at Sun.COM (Roman Kennke)
Date: Fri, 02 Oct 2009 15:49:15 +0200
Subject: [OpenJDK 2D-Dev] Review request for bug 100053
In-Reply-To: <0KQU0050JYVUAF40@fe-sfbay-09.sun.com>
References: <1254429191.12387.33.camel@moonlight> <4AC515F2.7000304@Sun.COM>
	<1254431606.24774.4.camel@moonlight> <4AC52355.2030307@Sun.COM>
	<0KQU0050JYVUAF40@fe-sfbay-09.sun.com>
Message-ID: <1254491355.4307.3.camel@moonlight>

Hi Jim,

I think you are right. I think the idea is to keep the array around to
avoid massive load on the GC. And if the array needs to be grown (i.e.
very rarely), it gets shrinked back to default size. So I would go with:

>   Shouldn't it be "if (array != null && array.length > DEFAULT)"?

The updated webrev is here:

http://cr.openjdk.java.net/~rkennke/100053/webrev.02/

I tested this with the testcase and Java2Demo and had no problems with
this.

Ok now?

Thanks, Roman




From jeremymanson at google.com  Fri Oct  2 09:16:07 2009
From: jeremymanson at google.com (Jeremy Manson)
Date: Fri, 2 Oct 2009 09:16:07 -0700
Subject: [OpenJDK 2D-Dev] Deadlock in SunGraphicsEnvironment /
	FontManager?
In-Reply-To: <4AC52AB0.3000909@sun.com>
References: <bf03e3fa0909231716u3064ab33vc0a4ac19c3035182@mail.gmail.com>
	<bf03e3fa0910011211l43b06321r757df83d76365810@mail.gmail.com>
	<4AC52AB0.3000909@sun.com>
Message-ID: <bf03e3fa0910020916u7c09ceb1i344ede7eb269385f@mail.gmail.com>

Phil,

Thanks for responding.  I'm sorry about the lack of detail in the
stack traces: I wanted to take out the bits that were specific to our
application.  Given the line numbers, I thought it would be relatively
easy to determine what the locks were.

The reason I didn't want to fix it is because I would need to take a
detailed look at the code before I really understood what a fix should
look like.  As you pointed out, my first instinct about a fix was
wrong.  Any chance that this is now on someone else's radar?  For
example, the code's author?

Are the locks grabbed just to check to see if initialization was done?
That would imply that even if I did load the fonts at a safe point, I
could still potentially run into this problem later when the code
checks to see if the fonts are initialized.

Avoiding it is, unfortunately, not really an option.  We need fonts.  :)

Jeremy

On Thu, Oct 1, 2009 at 3:18 PM, Phil Race <Phil.Race at sun.com> wrote:
>
>
> Jeremy Manson wrote:
>>
>> Does anyone have any thoughts about this? ?If we were to make up a
>> patch, would you take it?
>
> In summary the situation looks like this, (although your dumps
> aren't showing the locks, which I'd expected to see) :
>
> Thread 1 -> SunGraphicsEnvironment.loadFonts()
> ? ? ? ? ? ? ?[locked on SunGraphicsEnvironment.lucidaFontName]
> Thread 2 -> FontManager.initialiseDeferredFonts()
> ? ? ? ? ? ? ?[ locked on FontManager.class]
> Thread 1 -> FontManager.initialiseDeferredFonts()
> ? ? ? ? ? ? ?[ .. waiting for lock on FontManager.class]
> Thread 1 -> SunGraphicsEnvironment.loadFonts()
> ? ? ? ? ? ? ?[ .. waiting for lock on SunGraphicsEnvironment.lucidaFontName
> ]
>
>
> I'm not sure that the fix you suggest of moving the lock acquistion after
> ? ? ?467 ? ? ? ? ? ? FontManager.initialiseDeferredFonts();
> is guaranteed to be sufficient. This next line (and perhaps others) :
> ? ? ?473 ? ? ? ? ? ? ? ? ? ? ? ? fontPath =
> getPlatformFontPath(noType1Font);
>
> will also also acquire the lock. Another option is to simplify this down
> to one lock : the FontManager.class one, using it instead of the
> SunGraphicsEnvironment.lucidaFontName lock which I think was used
> in preference to the normal FontManager lock to make sure that
> this lengthy loadfonts operation didn't freeze the rest of the font system
> until it completed.
> That should still be a concern, albeit less of a one than a deadlock.
> Another approach might be to eliminate the lock here and rely on
> checks in the registration methods by font file name to skip
> over much of the duplicate work that might ensue from letting
> two threads have at this at the same time. But that would need
> even more careful testing than the other approach. I think either
> approach should to be tested on Windows as well.
>
>>
>> I did get an email about how this should all be single threaded on an
>> event dispatcher thread, to which I would reply:
>>
>> 1) If it is all supposed to be single threaded, then there shouldn't
>> be any locks in it to cause a deadlock, and
>>
>> 2) This is in the font code, and you can use fonts for things other
>> than drawing to the screen (in this case, they are trying to render a
>> PDF).
>
> You are correct on this.
> Its interesting that its taken this long to show up. I suspect that
> you are running on a Linux system with a lot of fonts and its the
> amount of time you end spending in loadFonts() that contributes
> to another thread showing up in the middle of it.
>
> You could
> (a) trigger a load fonts (GraphicsEnvironment.getAllFonts()) at some
> known safe point in your app, or
> (b) try to avoid it. This might be tricky as if your app needs to
> go hunt down fonts at some point you'll hit loadfonts().
>
>
>
> -phil.
>
>>
>> Jeremy
>>
>> On Wed, Sep 23, 2009 at 5:16 PM, Jeremy Manson <jeremymanson at google.com>
>> wrote:
>>>
>>> Hi 2d folks,
>>>
>>> We have an application running on OpenJDK6 that seems to be
>>> deadlocking in SunGraphicsEnvironment. ?I found it rather difficult to
>>> write a cut-down reproduction, but the errant lock acquisition is on
>>> line 482 of SunGraphicsEnvironment.java.:
>>>
>>>
>>> http://hg.openjdk.java.net/jdk6/jdk6-gate/jdk/file/f9fa5c538031/src/share/classes/sun/java2d/SunGraphicsEnvironment.java
>>>
>>> After the lock is acquired, it goes on to call
>>> FontManager.initialiseDeferredFonts() on line 467, which acquires the
>>> other lock. ?It looks as if you might be able to move the lock
>>> acquisition from line 462 to 468, which would eliminate the deadlock.
>>> The code looks pretty similar in recent OpenJDK7 builds (although the
>>> line numbers are changed).
>>>
>>> The relevant stacks follow. ?It seems like a pretty easy fix for a
>>> pretty nasty problem. ?Any chance someone could take a look? ?Thanks!
>>>
>>> Thread 1:
>>> ?sun.font.FontManager.initialiseDeferredFonts(FontManager.java:791)
>>>
>>> ?sun.java2d.SunGraphicsEnvironment.loadFonts(SunGraphicsEnvironment.java:467)
>>>
>>> ?sun.awt.X11GraphicsEnvironment.loadFonts(X11GraphicsEnvironment.java:885)
>>> ?sun.font.FontManager.findFont2D(FontManager.java:1995)
>>> ?java.awt.Font.getFont2D(Font.java:473)
>>> ?java.awt.Font.getFontName(Font.java:1221)
>>> ?java.awt.Font.getFontName(Font.java:1203)
>>>
>>> Thread 2:
>>>
>>> ?sun.java2d.SunGraphicsEnvironment.loadFonts(SunGraphicsEnvironment.java:463)
>>>
>>> ?sun.awt.X11GraphicsEnvironment.loadFonts(X11GraphicsEnvironment.java:885)
>>> ?sun.font.FontManager.findFont2D(FontManager.java:1995)
>>> ?sun.font.FontManager.getDefaultPhysicalFont(FontManager.java:1071)
>>> ?sun.font.FontManager.initialiseDeferredFont(FontManager.java:960)
>>> ?sun.font.FontManager.findJREDeferredFont(FontManager.java:875)
>>> ?sun.font.FontManager.findDeferredFont(FontManager.java:912)
>>> ?<snip lots of recursion>
>>> ?sun.font.FontManager.findFont2D(FontManager.java:1904)
>>> ?sun.font.FontManager.findFont2D(FontManager.java:1865)
>>> ?java.awt.Font.getFont2D(Font.java:473)
>>> ?java.awt.Font.getFontName(Font.java:1221)
>>> ?java.awt.Font.getFontName(Font.java:1203)
>>>
>


From igor.nekrestyanov at sun.com  Fri Oct  2 10:31:01 2009
From: igor.nekrestyanov at sun.com (igor.nekrestyanov at sun.com)
Date: Fri, 02 Oct 2009 17:31:01 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6887292: memory leak in
	freetypeScaler.c
Message-ID: <20091002173220.E521D418F8@hg.openjdk.java.net>

Changeset: 31e68419715e
Author:    igor
Date:      2009-10-02 10:15 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/31e68419715e

6887292: memory leak in freetypeScaler.c
Reviewed-by: bae, prr

! src/share/native/sun/font/freetypeScaler.c



From Jim.A.Graham at Sun.COM  Fri Oct  2 14:26:01 2009
From: Jim.A.Graham at Sun.COM (Jim Graham)
Date: Fri, 02 Oct 2009 14:26:01 -0700
Subject: [OpenJDK 2D-Dev] Review request for bug 100053
In-Reply-To: <1254491355.4307.3.camel@moonlight>
References: <1254429191.12387.33.camel@moonlight> <4AC515F2.7000304@Sun.COM>
	<1254431606.24774.4.camel@moonlight> <4AC52355.2030307@Sun.COM>
	<0KQU0050JYVUAF40@fe-sfbay-09.sun.com>
	<1254491355.4307.3.camel@moonlight>
Message-ID: <0KQW002ILOVDWS70@fe-sfbay-10.sun.com>

That looks fine.

A note on code style, though.  The following form would better match the 
indentation/continuation style used in the rest of this file and the 2D 
code:

  781         if (crossingIndices != null &&
  782             crossingIndices.length > DEFAULT_INDICES_SIZE)
  783         {

			...jim

Roman Kennke wrote:
> Hi Jim,
> 
> I think you are right. I think the idea is to keep the array around to
> avoid massive load on the GC. And if the array needs to be grown (i.e.
> very rarely), it gets shrinked back to default size. So I would go with:
> 
>>   Shouldn't it be "if (array != null && array.length > DEFAULT)"?
> 
> The updated webrev is here:
> 
> http://cr.openjdk.java.net/~rkennke/100053/webrev.02/
> 
> I tested this with the testcase and Java2Demo and had no problems with
> this.
> 
> Ok now?
> 
> Thanks, Roman
> 
> 


From roman.kennke at sun.com  Mon Oct  5 14:13:37 2009
From: roman.kennke at sun.com (roman.kennke at sun.com)
Date: Mon, 05 Oct 2009 21:13:37 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6887494: NPE in pisces Renderer
Message-ID: <20091005211429.2AC4541DDF@hg.openjdk.java.net>

Changeset: ccc36189f2a7
Author:    rkennke
Date:      2009-10-05 23:12 +0200
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/ccc36189f2a7

6887494: NPE in pisces Renderer
Summary: Only recreate crossings array, if there actually exists one before.
Reviewed-by: flar, tdv

! src/share/classes/sun/java2d/pisces/Renderer.java
+ test/sun/java2d/pisces/Renderer/TestNPE.java



From christoph.gille at charite.de  Tue Oct  6 03:31:54 2009
From: christoph.gille at charite.de (Dr. Christoph Gille)
Date: Tue, 6 Oct 2009 12:31:54 +0200
Subject: [OpenJDK 2D-Dev] Displacement by one pixel if using setStroke
Message-ID: <cb4d9174515ce9b8a27cf6b30d4c1f26.squirrel@webmail.charite.de>

When using setStroke, the pixel is displaced by one position
I guess that it is a numeric rounding error in 2d.
The following program demonstrates the error and shows my workaround:
g.translate(0.001,0.001);




import java.awt.*;
import javax.swing.*;

/**
   You should see a dashed black-red rectangle.

   Without calling translate however, the dashed rectangle is displaced by one
   pixel.

   Starting
   java test.Topenjdk

   java -version
   java version "1.6.0_0"
   OpenJDK  Runtime Environment (build 1.6.0_0-b11)
   OpenJDK Client VM (build 1.6.0_0-b11, mixed mode, sharing)
*/
public final class Topenjdk extends JComponent {
    boolean bugfixed;
    public static void main(String argv[]) throws Exception {
        for(boolean withWorkaround : new boolean[]{true,false}) {
            final JFrame f=new JFrame(withWorkaround ? "With workaround" : "Bug: rectangles do not coincide ");
            final Topenjdk component=new Topenjdk();
            component.bugfixed=withWorkaround;
            f.getContentPane().add(component);
            f.setLocation(withWorkaround ? 20:0, withWorkaround ? 20:0);
            f.setSize(300,300);
            f.show();
        }
    }
    public void paintComponent(Graphics graphics) {
        final Graphics2D g=(Graphics2D)graphics;
        if (bugfixed) g.translate(0.001,0.001);
        g.setColor(Color.WHITE);
        g.fillRect(0,0,999,999);
        g.setColor(Color.BLACK);
        g.drawRect(10,10,100,100);
        g.setStroke(new BasicStroke(1f,BasicStroke.CAP_ROUND,BasicStroke.JOIN_ROUND,1f,new float[]{12/3f, 12-12/3f},3));
        g.setColor(Color.RED);
        g.drawRect(10,10,100,100);
        if (bugfixed)  g.translate(-0.001,-0.001);
    }
}




From Roman.Kennke at Sun.COM  Tue Oct  6 11:45:41 2009
From: Roman.Kennke at Sun.COM (Roman Kennke)
Date: Tue, 06 Oct 2009 20:45:41 +0200
Subject: [OpenJDK 2D-Dev] Displacement by one pixel if using setStroke
In-Reply-To: <cb4d9174515ce9b8a27cf6b30d4c1f26.squirrel@webmail.charite.de>
References: <cb4d9174515ce9b8a27cf6b30d4c1f26.squirrel@webmail.charite.de>
Message-ID: <1254854741.29714.7.camel@moonlight>

Hi Christoph,

> When using setStroke, the pixel is displaced by one position
> I guess that it is a numeric rounding error in 2d.

Do you see that problem in OpenJDK6 or7 or both?

I will file a bug report ASAP and work on fixing the problem.

Thanks, Roman





From mario.torre at aicas.com  Wed Oct  7 08:19:44 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Wed, 07 Oct 2009 17:19:44 +0200
Subject: [OpenJDK 2D-Dev] OGLGraphicsConfig
Message-ID: <4ACCB190.9020300@aicas.com>

Hi all!

Is there any reason why sun.java2d.OGLGraphicsConfig is not public?

I would like to make it public so that I can have some more ways to 
reuse the code in the OpenGL pipeline, for example by having an EGL 
based implementation that doesn't depend on X11 at all.

Of course, I could use a sun.java2d package name but I guess it would be 
nicer/more legal to have this interface public in the first place.

The sun.java2d package is internal anyway, so compatibilty/public API 
preservation should not matter here. Should I propose the patch or just 
fix my package naming conventions to use sun.java2d?

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From Roman.Kennke at Sun.COM  Wed Oct  7 08:33:39 2009
From: Roman.Kennke at Sun.COM (Roman Kennke)
Date: Wed, 07 Oct 2009 17:33:39 +0200
Subject: [OpenJDK 2D-Dev] Displacement by one pixel if using setStroke
In-Reply-To: <cb4d9174515ce9b8a27cf6b30d4c1f26.squirrel@webmail.charite.de>
References: <cb4d9174515ce9b8a27cf6b30d4c1f26.squirrel@webmail.charite.de>
Message-ID: <1254929619.7270.19.camel@moonlight>

Hi Christoph,

I have filed bug #6889147, it should appear shortly on bugs.sun.com.
This seems to be another problem in the Pisces renderer. It seems to be
valid both for OpenJDK6 and 7. I try to have a look as soon as I find
time.

Thanks, Roman



Am Dienstag, den 06.10.2009, 12:31 +0200 schrieb Dr. Christoph Gille:
> When using setStroke, the pixel is displaced by one position
> I guess that it is a numeric rounding error in 2d.
> The following program demonstrates the error and shows my workaround:
> g.translate(0.001,0.001);
> 
> 
> 
> 
> import java.awt.*;
> import javax.swing.*;
> 
> /**
>    You should see a dashed black-red rectangle.
> 
>    Without calling translate however, the dashed rectangle is displaced by one
>    pixel.
> 
>    Starting
>    java test.Topenjdk
> 
>    java -version
>    java version "1.6.0_0"
>    OpenJDK  Runtime Environment (build 1.6.0_0-b11)
>    OpenJDK Client VM (build 1.6.0_0-b11, mixed mode, sharing)
> */
> public final class Topenjdk extends JComponent {
>     boolean bugfixed;
>     public static void main(String argv[]) throws Exception {
>         for(boolean withWorkaround : new boolean[]{true,false}) {
>             final JFrame f=new JFrame(withWorkaround ? "With workaround" : "Bug: rectangles do not coincide ");
>             final Topenjdk component=new Topenjdk();
>             component.bugfixed=withWorkaround;
>             f.getContentPane().add(component);
>             f.setLocation(withWorkaround ? 20:0, withWorkaround ? 20:0);
>             f.setSize(300,300);
>             f.show();
>         }
>     }
>     public void paintComponent(Graphics graphics) {
>         final Graphics2D g=(Graphics2D)graphics;
>         if (bugfixed) g.translate(0.001,0.001);
>         g.setColor(Color.WHITE);
>         g.fillRect(0,0,999,999);
>         g.setColor(Color.BLACK);
>         g.drawRect(10,10,100,100);
>         g.setStroke(new BasicStroke(1f,BasicStroke.CAP_ROUND,BasicStroke.JOIN_ROUND,1f,new float[]{12/3f, 12-12/3f},3));
>         g.setColor(Color.RED);
>         g.drawRect(10,10,100,100);
>         if (bugfixed)  g.translate(-0.001,-0.001);
>     }
> }
> 
> 



From Christopher.Campbell at Sun.COM  Wed Oct  7 10:07:52 2009
From: Christopher.Campbell at Sun.COM (Chris Campbell)
Date: Wed, 07 Oct 2009 10:07:52 -0700
Subject: [OpenJDK 2D-Dev] OGLGraphicsConfig
In-Reply-To: <4ACCB190.9020300@aicas.com>
References: <4ACCB190.9020300@aicas.com>
Message-ID: <EF9BEBE3-E58D-4D0E-9DD8-B419F4C1EFD3@sun.com>

It's package-private because it's only accessed within the  
sun.java2d.opengl package, and in general we strive to reduce the  
visibility of classes/interfaces.  The concrete GLX/WGL  
implementations also live in that package, so there was no reason to  
make it public.

There's probably no harm in making that interface public.  If you want  
to submit a patch, feel free.

Thanks,
Chris


On Oct 7, 2009, at 8:19 AM, Mario Torre wrote:
> Hi all!
>
> Is there any reason why sun.java2d.OGLGraphicsConfig is not public?
>
> I would like to make it public so that I can have some more ways to  
> reuse the code in the OpenGL pipeline, for example by having an EGL  
> based implementation that doesn't depend on X11 at all.
>
> Of course, I could use a sun.java2d package name but I guess it  
> would be nicer/more legal to have this interface public in the first  
> place.
>
> The sun.java2d package is internal anyway, so compatibilty/public  
> API preservation should not matter here. Should I propose the patch  
> or just fix my package naming conventions to use sun.java2d?
>
> Cheers,
> Mario
> -- 
> Mario Torre, Software Developer, http://www.jroller.com/neugens/
> aicas Allerton Interworks Computer Automated Systems GmbH
> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
> http://www.aicas.com   * Tel: +49-721-663 968-44
> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
> Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF
>
> USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
> Gesch?ftsf?hrer: Dr. James J. Hunt
>
> Please, support open standards:
> http://endsoftpatents.org/
>



From aph at redhat.com  Fri Oct  9 09:50:35 2009
From: aph at redhat.com (Andrew Haley)
Date: Fri, 09 Oct 2009 17:50:35 +0100
Subject: [OpenJDK 2D-Dev] JTreg colour management tests, etc
Message-ID: <4ACF69DB.8050808@redhat.com>

This is a heads up.

I've been looking at the failing CMM jtreg tests, and I think I have a
solution.

The problems are:

1.  Some incorrect "golden" images: these have errors, presumably
caused by bugs in whatever CMM was used to create them.

2.  In the case of PYCC, some of the entries in the golden image
correspond to colours that are impossible.  I don't mean just out of
gamut, I mean colours that correspond to no possible stimulus.  This
leads to somewhat unpredictable results with any CMS, since these
non-colours are not representable in the profile connection space.

I've created a GoldenImageFactory class that generates golden images
for testing by using high accuracy floating-point arithmetic.  This
means that the tests are independent of the CMM being used.

With regard to the PYCC tests, I think it doesn't make any sense for
large parts of the test image to contain colours that could never
occur in any PYCC file, so I have adjusted the tests only to contain
possible colours.

I've also noticed that the PYCC profile I provided causes clipping in
highlights when converting PYCC images made by the profile in the
proprietary JDK 6.  I've solved this by creating a new PYCC profile
with a lower L value for PYCC's 100% white and a soft knee in the
gamma curve, as recommended in Kodak PCD 042, retrieved from
http://www.kodak.com/global/en/professional/products/storage/pcd/techInfo/pcd-042.jhtml.  This gives good visual results for conversions.

A related problem with the PYCC profile I provided is that it was
limited to the sRGB colour space.  This new profile uses Lab as its
profile connection space, and is well-defined over that whole space.

I'll submit a webrev when I'm done.

Andrew.


From jennifer.godinez at sun.com  Wed Oct 14 11:04:51 2009
From: jennifer.godinez at sun.com (jennifer.godinez at sun.com)
Date: Wed, 14 Oct 2009 18:04:51 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6890945: Typo in sentence about
	thread safety
Message-ID: <20091014180514.36465415D1@hg.openjdk.java.net>

Changeset: c58000722db0
Author:    jgodinez
Date:      2009-10-14 10:44 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c58000722db0

6890945: Typo in sentence about thread safety
Reviewed-by: prr

! src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java



From Roman.Kennke at Sun.COM  Thu Oct 15 06:22:23 2009
From: Roman.Kennke at Sun.COM (Roman Kennke)
Date: Thu, 15 Oct 2009 15:22:23 +0200
Subject: [OpenJDK 2D-Dev] Request for review: 6888734,
 regression test fails when java.security.manager is enabled
Message-ID: <1255612943.10319.3.camel@moonlight>

Hi there,

Here's a fix for Bug#6888734. One regression test was failing with an
AccessControlException in new FontManager code. We need to move
Class.forName() and newInstance() call into the privileged block. Webrev
here:

http://cr.openjdk.java.net/~rkennke/6888734/webrev.00/

Good? Comments?

/Roman




From jennifer.godinez at sun.com  Fri Oct 16 09:48:08 2009
From: jennifer.godinez at sun.com (jennifer.godinez at sun.com)
Date: Fri, 16 Oct 2009 16:48:08 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6680634: Printing: "Collate" is
	ignored under	Windows Vista x64
Message-ID: <20091016164833.70A414191C@hg.openjdk.java.net>

Changeset: fa2b3627e59c
Author:    jgodinez
Date:      2009-10-16 09:32 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/fa2b3627e59c

6680634: Printing: "Collate" is ignored under Windows Vista x64
Reviewed-by: campbell, prr

! src/windows/native/sun/windows/awt_PrintControl.cpp



From mario.torre at aicas.com  Mon Oct 19 06:10:44 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Mon, 19 Oct 2009 15:10:44 +0200
Subject: [OpenJDK 2D-Dev] OGLGraphicsConfig
In-Reply-To: <EF9BEBE3-E58D-4D0E-9DD8-B419F4C1EFD3@sun.com>
References: <4ACCB190.9020300@aicas.com>
	<EF9BEBE3-E58D-4D0E-9DD8-B419F4C1EFD3@sun.com>
Message-ID: <4ADC6554.5080404@aicas.com>

Il 07/10/2009 19:07, Chris Campbell ha scritto:
> It's package-private because it's only accessed within the
> sun.java2d.opengl package, and in general we strive to reduce the
> visibility of classes/interfaces. The concrete GLX/WGL implementations
> also live in that package, so there was no reason to make it public.
>
> There's probably no harm in making that interface public. If you want to
> submit a patch, feel free.
>
> Thanks,
> Chris

Hi Chris,

Very simple one:

http://cr.openjdk.java.net/~neugens/oglpipeline/webrev.00/

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From mario.torre at aicas.com  Mon Oct 19 06:15:59 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Mon, 19 Oct 2009 15:15:59 +0200
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <0KQJ00LG8NLX0910@fe-sfbay-09.sun.com>
References: <1244588287.3580.53.camel@localhost.localdomain>	<4A3946F6.2040902@sun.com>	<0KLE000ZNIRPDR90@fe-sfbay-09.sun.com>	<1245278053.3658.80.camel@localhost.localdomain>	<1245328755.3609.26.camel@localhost.localdomain>	<0KLG008439VVTV60@fe-sfbay-10.sun.com>
	<4A3FE35B.3030701@aicas.com>	<0KLN0010AZEI8L30@fe-sfbay-10.sun.com>
	<4A423049.8080903@aicas.com>	<4A4CCD39.4050003@sun.com>
	<4A5488EE.3080808@aicas.com>	<0KMH008HKOJW5M70@fe-sfbay-09.sun.com>
	<4A5593C6.1010700@aicas.com>	<0KMJ00IXG7AYMA10@fe-sfbay-10.sun.com>
	<4A5C7EA6.6070404@aicas.com>	<0KMS003N4D4KVK70@fe-sfbay-10.sun.com>
	<4A5DEAEF.1080101@aicas.com>	<0KMU00GD5EWNFFH0@fe-sfbay-10.sun.com>
	<4A65F6A8.20502@aicas.com>	<0KN5008UCPV3Y720@fe-sfbay-10.sun.com>
	<4A789BDA.5030309@aicas.com>	<1249420092.13246.19.camel@moonlight>	<0KNV007YIGORMT80@fe-sfbay-10.sun.com>	<4A7944B5.8010106@aicas.com>
	<4AB23810.8050308@aicas.com>	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com>
	<4AB3745E.3070208@aicas.com> <0KQJ00LG8NLX0910@fe-sfbay-09.su
	n.com>
Message-ID: <4ADC668F.3040405@aicas.com>

Il 25/09/2009 22:29, Jim Graham ha scritto:

Hi Jim,

> I think we could add a quick "if (loops == null) {...}" in those 2
> classes and maybe add a comment "// assert(some pipe will always be a
> LoopBasedPipe)" to indicate that we aren't checking the types of the
> pipes because we think it is always true in case that assumption changes
> in the future. Does that make sense?

Not sure if this is what you mean:

http://cr.openjdk.java.net/~neugens/100068/webrev.09

Looks like it doesn't break stuff, I did the usual test with Java2D demo.

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From Jim.A.Graham at Sun.COM  Mon Oct 19 13:04:14 2009
From: Jim.A.Graham at Sun.COM (Jim Graham)
Date: Mon, 19 Oct 2009 13:04:14 -0700
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4ADC668F.3040405@aicas.com>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<4A3946F6.2040902@sun.com> <0KLE000ZNIRPDR90@fe-sfbay-09.sun.com>
	<1245278053.3658.80.camel@localhost.localdomain>
	<1245328755.3609.26.camel@localhost.localdomain>
	<0KLG008439VVTV60@fe-sfbay-10.sun.com> <4A3FE35B.3030701@aicas.com>
	<0KLN0010AZEI8L30@fe-sfbay-10.sun.com> <4A423049.8080903@aicas.com>
	<4A4CCD39.4050003@sun.com> <4A5488EE.3080808@aicas.com>
	<0KMH008HKOJW5M70@fe-sfbay-09.sun.com> <4A5593C6.1010700@aicas.com>
	<0KMJ00IXG7AYMA10@fe-sfbay-10.sun.com> <4A5C7EA6.6070404@aicas.com>
	<0KMS003N4D4KVK70@fe-sfbay-10.sun.com> <4A5DEAEF.1080101@aicas.com>
	<0KMU00GD5EWNFFH0@fe-sfbay-10.sun.com> <4A65F6A8.20502@aicas.com>
	<0KN5008UCPV3Y720@fe-sfbay-10.sun.com> <4A789BDA.5030309@aicas.com>
	<1249420092.13246.19.camel@moonlight>
	<0KNV007YIGORMT80@fe-sfbay-10.sun.com>
	<4A7944B5.8010106@aicas.com> <4AB23810.8050308@aicas.com>
	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com> <4AB3745E.3070208@aicas.com>
	<4ADC668F.3040405@aicas.com>
Message-ID: <0KRS0013M2EYCC60@fe-sfbay-10.sun.com>

Hi Mario,

That's just what I was trying to describe, thanks!  Looks good to go...

		...jim

Mario Torre wrote:
> Il 25/09/2009 22:29, Jim Graham ha scritto:
> 
> Hi Jim,
> 
>> I think we could add a quick "if (loops == null) {...}" in those 2
>> classes and maybe add a comment "// assert(some pipe will always be a
>> LoopBasedPipe)" to indicate that we aren't checking the types of the
>> pipes because we think it is always true in case that assumption changes
>> in the future. Does that make sense?
> 
> Not sure if this is what you mean:
> 
> http://cr.openjdk.java.net/~neugens/100068/webrev.09
> 
> Looks like it doesn't break stuff, I did the usual test with Java2D demo.
> 
> Cheers,
> Mario


From mario.torre at aicas.com  Tue Oct 20 00:52:49 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Tue, 20 Oct 2009 09:52:49 +0200
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <0KRS0013M2EYCC60@fe-sfbay-10.sun.com>
References: <1244588287.3580.53.camel@localhost.localdomain>	<1245278053.3658.80.camel@localhost.localdomain>	<1245328755.3609.26.camel@localhost.localdomain>	<0KLG008439VVTV60@fe-sfbay-10.sun.com>
	<4A3FE35B.3030701@aicas.com>	<0KLN0010AZEI8L30@fe-sfbay-10.sun.com>
	<4A423049.8080903@aicas.com>	<4A4CCD39.4050003@sun.com>
	<4A5488EE.3080808@aicas.com>	<0KMH008HKOJW5M70@fe-sfbay-09.sun.com>
	<4A5593C6.1010700@aicas.com>	<0KMJ00IXG7AYMA10@fe-sfbay-10.sun.com>
	<4A5C7EA6.6070404@aicas.com>	<0KMS003N4D4KVK70@fe-sfbay-10.sun.com>
	<4A5DEAEF.1080101@aicas.com>	<0KMU00GD5EWNFFH0@fe-sfbay-10.sun.com>
	<4A65F6A8.20502@aicas.com>	<0KN5008UCPV3Y720@fe-sfbay-10.sun.com>
	<4A789BDA.5030309@aicas.com>	<1249420092.13246.19.camel@moonlight>	<0KNV007YIGORMT80@fe-sfbay-10.sun.com>	<4A7944B5.8010106@aicas.com>
	<4AB23810.8050308@aicas.com>	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com>
	<4AB3745E.3070208@aicas.com>	<4ADC668F.3040405@aicas.com>
	<0KRS0013M2EYCC60@fe-sfbay-10.sun.com>
Message-ID: <4ADD6C51.6090600@aicas.com>

Il 19/10/2009 22:04, Jim Graham ha scritto:
> Hi Mario,
>
> That's just what I was trying to describe, thanks! Looks good to go...
>
> ...jim

Hi Jim!

Super cool! What's the next step now? :)

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From Roman.Kennke at Sun.COM  Tue Oct 20 01:24:41 2009
From: Roman.Kennke at Sun.COM (Roman Kennke)
Date: Tue, 20 Oct 2009 10:24:41 +0200
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4ADC668F.3040405@aicas.com>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<4A3946F6.2040902@sun.com> <0KLE000ZNIRPDR90@fe-sfbay-09.sun.com>
	<1245278053.3658.80.camel@localhost.localdomain>
	<1245328755.3609.26.camel@localhost.localdomain>
	<0KLG008439VVTV60@fe-sfbay-10.sun.com> <4A3FE35B.3030701@aicas.com>
	<0KLN0010AZEI8L30@fe-sfbay-10.sun.com> <4A423049.8080903@aicas.com>
	<4A4CCD39.4050003@sun.com> <4A5488EE.3080808@aicas.com>
	<0KMH008HKOJW5M70@fe-sfbay-09.sun.com> <4A5593C6.1010700@aicas.com>
	<0KMJ00IXG7AYMA10@fe-sfbay-10.sun.com> <4A5C7EA6.6070404@aicas.com>
	<0KMS003N4D4KVK70@fe-sfbay-10.sun.com> <4A5DEAEF.1080101@aicas.com>
	<0KMU00GD5EWNFFH0@fe-sfbay-10.sun.com> <4A65F6A8.20502@aicas.com>
	<0KN5008UCPV3Y720@fe-sfbay-10.sun.com> <4A789BDA.5030309@aicas.com>
	<1249420092.13246.19.camel@moonlight>
	<0KNV007YIGORMT80@fe-sfbay-10.sun.com>
	<4A7944B5.8010106@aicas.com> <4AB23810.8050308@aicas.com>
	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com> <4AB3745E.3070208@aicas.com>
	<4ADC668F.3040405@aicas.com>
Message-ID: <1256027081.3934.4.camel@moonlight>

Looks ok to me too, but I don't think I have a say.. ;-)

/Roman





From Jennifer.Godinez at Sun.COM  Wed Oct 21 14:23:28 2009
From: Jennifer.Godinez at Sun.COM (Jennifer Godinez)
Date: Wed, 21 Oct 2009 14:23:28 -0700
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4ADD6C51.6090600@aicas.com>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<1245278053.3658.80.camel@localhost.localdomain>
	<1245328755.3609.26.camel@localhost.localdomain>
	<0KLG008439VVTV60@fe-sfbay-10.sun.com> <4A3FE35B.3030701@aicas.com>
	<0KLN0010AZEI8L30@fe-sfbay-10.sun.com> <4A423049.8080903@aicas.com>
	<4A4CCD39.4050003@sun.com> <4A5488EE.3080808@aicas.com>
	<0KMH008HKOJW5M70@fe-sfbay-09.sun.com> <4A5593C6.1010700@aicas.com>
	<0KMJ00IXG7AYMA10@fe-sfbay-10.sun.com> <4A5C7EA6.6070404@aicas.com>
	<0KMS003N4D4KVK70@fe-sfbay-10.sun.com> <4A5DEAEF.1080101@aicas.com>
	<0KMU00GD5EWNFFH0@fe-sfbay-10.sun.com> <4A65F6A8.20502@aicas.com>
	<0KN5008UCPV3Y720@fe-sfbay-10.sun.com> <4A789BDA.5030309@aicas.com>
	<1249420092.13246.19.camel@moonlight>
	<0KNV007YIGORMT80@fe-sfbay-10.sun.com>
	<4A7944B5.8010106@aicas.com> <4AB23810.8050308@aicas.com>
	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com> <4AB3745E.3070208@aicas.com>
	<4ADC668F.3040405@aicas.com> <0KRS0013M2EYCC60@fe-sfbay-10.sun.com>
	<4ADD6C51.6090600@aicas.com>
Message-ID: <4ADF7BD0.50202@sun.com>

Hi Mario,

You can submit the patch using the steps in
http://openjdk.java.net/contribute/

Let me know if you have any questions.

Jennifer

Mario Torre wrote:
> Il 19/10/2009 22:04, Jim Graham ha scritto:
>> Hi Mario,
>>
>> That's just what I was trying to describe, thanks! Looks good to go...
>>
>> ...jim
> 
> Hi Jim!
> 
> Super cool! What's the next step now? :)
> 
> Cheers,
> Mario


From lana.steuck at sun.com  Thu Oct 22 13:49:43 2009
From: lana.steuck at sun.com (lana.steuck at sun.com)
Date: Thu, 22 Oct 2009 20:49:43 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d: 2 new changesets
Message-ID: <20091022204943.C107E41614@hg.openjdk.java.net>

Changeset: 2c88089b6e1c
Author:    xdono
Date:      2009-10-02 11:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/rev/2c88089b6e1c

Added tag jdk7-b73 for changeset 3ac6dcf78232

! .hgtags

Changeset: d1516b9f2395
Author:    xdono
Date:      2009-10-15 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/rev/d1516b9f2395

Added tag jdk7-b74 for changeset 2c88089b6e1c

! .hgtags



From lana.steuck at sun.com  Thu Oct 22 13:49:54 2009
From: lana.steuck at sun.com (lana.steuck at sun.com)
Date: Thu, 22 Oct 2009 20:49:54 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/corba: 2 new changesets
Message-ID: <20091022204957.B2B1241615@hg.openjdk.java.net>

Changeset: 5d0cf59a3203
Author:    xdono
Date:      2009-10-02 11:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/corba/rev/5d0cf59a3203

Added tag jdk7-b73 for changeset b751c528c555

! .hgtags

Changeset: 0fb137085952
Author:    xdono
Date:      2009-10-15 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/corba/rev/0fb137085952

Added tag jdk7-b74 for changeset 5d0cf59a3203

! .hgtags



From lana.steuck at sun.com  Thu Oct 22 13:54:19 2009
From: lana.steuck at sun.com (lana.steuck at sun.com)
Date: Thu, 22 Oct 2009 20:54:19 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/hotspot: 54 new changesets
Message-ID: <20091022205712.46FE641618@hg.openjdk.java.net>

Changeset: 489a4f8dcd0f
Author:    twisti
Date:      2009-08-27 06:17 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/489a4f8dcd0f

6865583: Verbose CIPrintMethodCodes asserts when ldc an empty String
Summary: ldc seems to load an empty String and that leads to an assert on offset < length, which are both zero.
Reviewed-by: kvn, never

! src/share/vm/classfile/javaClasses.cpp

Changeset: 8fe1963e3964
Author:    kvn
Date:      2009-08-28 11:19 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/8fe1963e3964

6875577: CTW fails with /hotspot/src/share/vm/opto/memnode.cpp
Summary: Fix do_null_check to check for unloaded klass for all oop pointers.
Reviewed-by: never, cfang

! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/library_call.cpp

Changeset: 1fbd5d696bf4
Author:    twisti
Date:      2009-08-31 02:24 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/1fbd5d696bf4

6875967: CTW fails with./generated/adfiles/ad_sparc.cpp:6711
Reviewed-by: cfang, never

! src/cpu/sparc/vm/sparc.ad

Changeset: ace8397c8563
Author:    cfang
Date:      2009-08-31 08:31 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/ace8397c8563

6876276: assert(!is_visited,"visit only once")
Summary: schedule the superword loads based on dependence constraints
Reviewed-by: kvn, never

! src/share/vm/opto/superword.cpp
! test/compiler/6636138/Test1.java
! test/compiler/6636138/Test2.java

Changeset: ff1a29907b6c
Author:    never
Date:      2009-08-31 17:07 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/ff1a29907b6c

6855215: Calculation error (NaN) after about 1500 calculations
Reviewed-by: kvn

! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp
! src/cpu/x86/vm/c1_LinearScan_x86.cpp
! src/share/vm/c1/c1_LIR.cpp
! src/share/vm/c1/c1_LIR.hpp
+ test/compiler/6855215/Test6855215.java

Changeset: 0f1c19b7a52d
Author:    kvn
Date:      2009-09-08 10:42 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0f1c19b7a52d

6875619: CTW fails with /hotspot/src/share/vm/opto/type.hpp
Summary: In load_array_length() cast array's type to TypeOopPtr when calling make_ideal_length() method.
Reviewed-by: never

! src/share/vm/opto/graphKit.cpp

Changeset: 26fbe81d30cf
Author:    kvn
Date:      2009-09-08 16:56 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/26fbe81d30cf

6880052: SIGSEGV in GraphKit::null_check_common()
Summary: Check that a klass is not NULL before the is_loaded() call.
Reviewed-by: never

! src/share/vm/opto/graphKit.cpp

Changeset: 9a4e87ba1a90
Author:    kvn
Date:      2009-09-09 16:28 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/9a4e87ba1a90

6880533: test/compiler/6865031/Test.java miss -XX:+IgnoreUnrecognizedVMOptions
Summary: Add missing test option -XX:+IgnoreUnrecognizedVMOptions.
Reviewed-by: never

! test/compiler/6865031/Test.java

Changeset: 159d56b94894
Author:    kvn
Date:      2009-09-10 10:36 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/159d56b94894

6880574: C2 assert in escape.cpp:445 on linux-amd64
Summary: Look through chained AddP nodes in get_addp_base().
Reviewed-by: jrose

! src/share/vm/opto/escape.cpp

Changeset: c7e94e8fff43
Author:    kvn
Date:      2009-09-10 18:18 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c7e94e8fff43

6880053: assert(alloc_obj->as_CheckCastPP()->type() != TypeInstPtr::NOTNULL)
Summary: Removed second CheckCastPP and use MembarCPUOrder after arraycopy to cloned object.
Reviewed-by: never

! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/type.cpp
! src/share/vm/opto/type.hpp

Changeset: a6f533fc33e0
Author:    kvn
Date:      2009-09-14 11:45 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/a6f533fc33e0

Merge


Changeset: eb058abd0562
Author:    ysr
Date:      2009-09-15 16:50 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/eb058abd0562

6861557: G1: assert(top() == bottom() || zfs == Allocated,"Region must be empty, or ...")
Summary: Druing heap shrinking, check for emptiness of a region before modifying its ZF status.
Reviewed-by: tonyp

! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp

Changeset: d7c9544cc141
Author:    apetrusenko
Date:      2009-09-18 06:02 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/d7c9544cc141

Merge


Changeset: aafa4232dfd7
Author:    asaha
Date:      2009-08-28 08:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/aafa4232dfd7

6821003: Update hotspot windows os_win32 for windows 7
Reviewed-by: xlu

! src/os/windows/vm/os_windows.cpp

Changeset: 9601152ccfc1
Author:    dcubed
Date:      2009-08-28 12:25 -0600
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/9601152ccfc1

6875393: 2/3 JNI itable index cache is broken
Summary: Add missing initialization of cache size.
Reviewed-by: tbell

! src/share/vm/oops/instanceKlass.cpp

Changeset: 75e30968ebe1
Author:    dcubed
Date:      2009-08-28 12:32 -0600
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/75e30968ebe1

Merge

! src/share/vm/oops/instanceKlass.cpp

Changeset: df97b1cf46d8
Author:    dcubed
Date:      2009-08-28 15:03 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/df97b1cf46d8

Merge


Changeset: bb287c042e99
Author:    apangin
Date:      2009-08-30 15:33 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/bb287c042e99

Merge


Changeset: 6918603297f7
Author:    poonam
Date:      2009-09-01 23:34 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/6918603297f7

6858208: jvm crash when specifying TypeProfileWidth=0 on jdk 6.0
Summary: Add an explicit check for TypeProfileWidth == 0 in record_klass_in_profile_helper() functions.
Reviewed-by: never, coleenp

! src/cpu/sparc/vm/interp_masm_sparc.cpp
! src/cpu/x86/vm/interp_masm_x86_32.cpp
! src/cpu/x86/vm/interp_masm_x86_64.cpp

Changeset: 5fdbe2cdf565
Author:    andrew
Date:      2009-09-08 09:01 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/5fdbe2cdf565

6879689: Fix warning about ignored return value when compiling with -O2
Summary: Store the return value of fwrite and check it matches the size of the array.
Reviewed-by: twisti, dholmes

! src/share/vm/adlc/archDesc.cpp

Changeset: 0804a88ed4f5
Author:    andrew
Date:      2009-09-08 09:02 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0804a88ed4f5

Merge


Changeset: 682194ca1d8d
Author:    acorn
Date:      2009-09-10 09:04 -0400
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/682194ca1d8d

Merge

- src/share/vm/gc_implementation/shared/coTracker.cpp
- src/share/vm/gc_implementation/shared/coTracker.hpp
- src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp
- src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp
! src/share/vm/oops/instanceKlass.cpp

Changeset: 0fc81f0a8ca8
Author:    andrew
Date:      2009-09-12 12:50 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0fc81f0a8ca8

6873059: Explicitly use -source 6 -target 6 when compiling with the boot jdk
Summary: The build fails if the bootstrap JDK defaults to <1.5
Reviewed-by: jcoomes

! make/linux/makefiles/jvmti.make
! make/linux/makefiles/rules.make
! make/linux/makefiles/sa.make
! make/linux/makefiles/top.make
! make/solaris/makefiles/jvmti.make
! make/solaris/makefiles/rules.make
! make/solaris/makefiles/sa.make
! make/solaris/makefiles/top.make
! make/windows/makefiles/generated.make
! make/windows/makefiles/jvmti.make
! make/windows/makefiles/rules.make
! make/windows/makefiles/sa.make
! make/windows/projectfiles/common/Makefile

Changeset: e5b31fd85b72
Author:    acorn
Date:      2009-09-15 16:28 -0400
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/e5b31fd85b72

Merge


Changeset: ad6585fd4087
Author:    acorn
Date:      2009-09-04 12:53 -0400
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/ad6585fd4087

6830542: Performance: JVM_DefineClass already verified.
Reviewed-by: kamg, phh

! make/linux/makefiles/mapfile-vers-debug
! make/linux/makefiles/mapfile-vers-product
! make/solaris/makefiles/mapfile-vers
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/classFileParser.hpp
! src/share/vm/classfile/classLoader.cpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/classfile/verifier.cpp
! src/share/vm/classfile/verifier.hpp
! src/share/vm/code/dependencies.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/instanceKlassKlass.cpp
! src/share/vm/prims/jni.cpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/jvm.h
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 26b774d693aa
Author:    acorn
Date:      2009-09-16 09:10 -0400
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/26b774d693aa

Merge

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/classFileParser.hpp
- src/share/vm/gc_implementation/shared/coTracker.cpp
- src/share/vm/gc_implementation/shared/coTracker.hpp
- src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp
- src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/instanceKlassKlass.cpp

Changeset: 83c29a26f67c
Author:    acorn
Date:      2009-09-16 15:42 -0400
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/83c29a26f67c

6879572: SA fails _is_marked_dependent not found
Reviewed-by: kamg, dcubed

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/code/dependencies.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/instanceKlassKlass.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 723131383de6
Author:    acorn
Date:      2009-09-18 15:14 -0400
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/723131383de6

Merge


Changeset: 74a5db69c1fe
Author:    dcubed
Date:      2009-09-21 09:30 -0600
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/74a5db69c1fe

6419370: 4/4 new jmethodID code has tiny holes in synchronization
Summary: Fix races in jmethodID cache and JNI itable index cache.
Reviewed-by: ikrylov, acorn

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/methodOop.hpp

Changeset: d72ba3205918
Author:    acorn
Date:      2009-09-21 18:10 -0400
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/d72ba3205918

Merge


Changeset: 87770dcf831b
Author:    dcubed
Date:      2009-09-22 21:12 -0600
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/87770dcf831b

6876794: 4/4 sp07t002 hangs very intermittently
Summary: remove over locking by VMThread on "is thread suspended?" check
Reviewed-by: dholmes, acorn, andrew

! src/share/vm/runtime/safepoint.cpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/thread.hpp

Changeset: c3c4a1d3801a
Author:    andrew
Date:      2009-09-23 11:36 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c3c4a1d3801a

6884552: remove some unnecessary #ifdef's introduced in the fix for 4957990
Summary: Removed the unnecessary #ifdef's which were interfering with the build of the Zero-assembler port
Reviewed-by: ysr, jcoomes

! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp

Changeset: 1af62b6ca0f9
Author:    apetrusenko
Date:      2009-09-25 04:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/1af62b6ca0f9

Merge


Changeset: 7a102acc9f17
Author:    trims
Date:      2009-09-25 12:17 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/7a102acc9f17

Merge

! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/prims/jvm.h

Changeset: faf94d94786b
Author:    trims
Date:      2009-09-25 12:19 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/faf94d94786b

6885900: Bump the HS17 build number to 02
Summary: Update the HS17 build number to 02
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 6ddec5389232
Author:    xdono
Date:      2009-10-02 11:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/6ddec5389232

Added tag jdk7-b73 for changeset faf94d94786b

! .hgtags

Changeset: 685e959d09ea
Author:    cfang
Date:      2009-09-14 09:49 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/685e959d09ea

6877254: Server vm crashes with no branches off of store slice" when run with CMS and UseSuperWord(default)
Summary: design StoreCMNode::Ideal to promote its oopStore input if the input is a MergeMem node
Reviewed-by: kvn, never

! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/graphKit.hpp
! src/share/vm/opto/idealKit.cpp
! src/share/vm/opto/idealKit.hpp
! src/share/vm/opto/memnode.cpp
! src/share/vm/opto/memnode.hpp
! src/share/vm/opto/superword.cpp
+ test/compiler/6877254/Test.java

Changeset: 62001a362ce9
Author:    kvn
Date:      2009-09-14 12:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/62001a362ce9

6827605: new String intrinsics may prevent EA scalar replacement
6875866: Intrinsic for String.indexOf() is broken on x86 with SSE4.2
Summary: Modify String intrinsic methods to pass char[] pointers instead of string oops.
Reviewed-by: never

! src/cpu/sparc/vm/assembler_sparc.cpp
! src/cpu/sparc/vm/assembler_sparc.hpp
! src/cpu/sparc/vm/sparc.ad
! src/cpu/x86/vm/assembler_x86.cpp
! src/cpu/x86/vm/assembler_x86.hpp
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/share/vm/adlc/formssel.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/matcher.cpp
! src/share/vm/opto/memnode.cpp
! src/share/vm/opto/memnode.hpp
+ test/compiler/6875866/Test.java

Changeset: 00977607da34
Author:    cfang
Date:      2009-09-15 11:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/00977607da34

6879921: CTW failure jdk6_18/hotspot/src/share/vm/utilities/globalDefinitions.cpp:268
Summary: filter out non-primitives before deciding whether two ops can be packed
Reviewed-by: kvn, never

! src/share/vm/opto/superword.cpp

Changeset: 7e309ecb83ce
Author:    kvn
Date:      2009-09-15 19:03 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/7e309ecb83ce

6879362: assert(!klass_is_exact(),"only non-exact klass")
Summary: Do nothing for AddP node which has type not related to the type of allocated object.
Reviewed-by: never

! src/share/vm/opto/escape.cpp

Changeset: 148e5441d916
Author:    jrose
Date:      2009-09-15 21:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/148e5441d916

6863023: need non-perm oops in code cache for JSR 292
Summary: Make a special root-list for those few nmethods which might contain non-perm oops.
Reviewed-by: twisti, kvn, never, jmasa, ysr

! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java
! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java
! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp
! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp
! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp
! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/share/vm/c1/c1_GraphBuilder.cpp
! src/share/vm/c1/c1_InstructionPrinter.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/c1/c1_ValueType.cpp
! src/share/vm/ci/ciEnv.cpp
! src/share/vm/ci/ciEnv.hpp
! src/share/vm/ci/ciObject.cpp
! src/share/vm/ci/ciObject.hpp
! src/share/vm/ci/ciObjectFactory.cpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/code/codeBlob.hpp
! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/code/debugInfoRec.cpp
! src/share/vm/code/dependencies.cpp
! src/share/vm/code/nmethod.cpp
! src/share/vm/code/nmethod.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge
! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/pcTasks.hpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/gc_interface/collectedHeap.hpp
! src/share/vm/memory/defNewGeneration.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genCollectedHeap.hpp
! src/share/vm/memory/genMarkSweep.cpp
! src/share/vm/memory/iterator.cpp
! src/share/vm/memory/iterator.hpp
! src/share/vm/memory/sharedHeap.cpp
! src/share/vm/memory/sharedHeap.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/oop.hpp
! src/share/vm/oops/oop.inline2.hpp
! src/share/vm/opto/output.cpp
! src/share/vm/opto/parse.hpp
! src/share/vm/opto/parse2.cpp
! src/share/vm/opto/parse3.cpp
! src/share/vm/opto/type.cpp
! src/share/vm/opto/type.hpp
! src/share/vm/prims/jvmtiTagMap.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/frame.cpp
! src/share/vm/runtime/frame.hpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/sweeper.cpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/thread.hpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/runtime/vmThread.cpp
! src/share/vm/runtime/vmThread.hpp
! src/share/vm/utilities/debug.cpp

Changeset: be094e0c089a
Author:    jrose
Date:      2009-09-15 22:50 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/be094e0c089a

Merge


Changeset: 3a2aa26bdc58
Author:    never
Date:      2009-09-16 11:06 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3a2aa26bdc58

6854812: 6.0_14-b08 crashes with a SIGSEGV
Reviewed-by: kvn, twisti

! src/share/vm/ci/ciMethod.cpp
! src/share/vm/ci/ciMethod.hpp
! src/share/vm/ci/ciTypeFlow.cpp
! src/share/vm/opto/parse1.cpp

Changeset: 6a8ccac44f41
Author:    kvn
Date:      2009-09-18 09:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/6a8ccac44f41

6820514: meet not symmetric failure in ctw
Summary: Add missing instance_id meet.
Reviewed-by: never

! src/share/vm/opto/type.cpp
! src/share/vm/opto/type.hpp

Changeset: 54b3b351d6f9
Author:    jrose
Date:      2009-09-23 23:56 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/54b3b351d6f9

Merge

! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/code/dependencies.cpp
! src/share/vm/code/nmethod.cpp
! src/share/vm/code/nmethod.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge
! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
- src/share/vm/gc_implementation/shared/coTracker.cpp
- src/share/vm/gc_implementation/shared/coTracker.hpp
- src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp
- src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/gc_interface/collectedHeap.hpp
! src/share/vm/memory/genMarkSweep.cpp
! src/share/vm/memory/iterator.cpp
! src/share/vm/memory/iterator.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/sweeper.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 753cf9794df9
Author:    jrose
Date:      2009-09-23 23:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/753cf9794df9

6885169: merge of 4957990 and 6863023 causes conflict on do_nmethods
Summary: After mechanically merging changes, some by-hand adjustments are needed.
Reviewed-by: ysr

! src/share/vm/code/nmethod.cpp
! src/share/vm/code/nmethod.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/memory/iterator.cpp
! src/share/vm/memory/iterator.hpp

Changeset: ddd6f1182ae3
Author:    kvn
Date:      2009-09-25 13:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/ddd6f1182ae3

6883468: C2 compiler enters infinite loop in PhaseIterGVN::transform
Summary: Avoid ideal transformation ping-pong between AddPNode::Ideal() and CastX2PNode::Ideal().
Reviewed-by: cfang

! src/share/vm/opto/connode.cpp

Changeset: d6b9fd78f389
Author:    cfang
Date:      2009-09-28 17:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/d6b9fd78f389

6886353: For DeoptimizeALot, JTreg tests should "IgnoreUnrecognizedVMOptions on a product build
Summary: Add IgnoreUnrecognizedVMOptions for JTreg tests (on a product build) to pass with DeoptimizeALot
Reviewed-by: kvn

! test/compiler/6823453/Test.java
! test/compiler/6833129/Test.java

Changeset: 46b819ba120b
Author:    jrose
Date:      2009-09-30 13:25 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/46b819ba120b

Merge

! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/thread.hpp

Changeset: a0107ba3bc53
Author:    johnc
Date:      2009-10-01 15:56 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/a0107ba3bc53

6887186: G1: Incorrect code generated for G1 pre-barrier by C1 on SPARC
Summary: Modify operand passed to C1 pre-barrier to be the operand representing the address of the object field that is being stored.
Reviewed-by: never

! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp

Changeset: 708275a44e4a
Author:    tonyp
Date:      2009-10-03 10:53 -0400
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/708275a44e4a

Merge

! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp

Changeset: a1423fe86a18
Author:    trims
Date:      2009-10-09 15:18 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/a1423fe86a18

Merge

! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp
! src/share/vm/ci/ciObjectFactory.cpp
! src/share/vm/code/nmethod.hpp
! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/memory/genMarkSweep.cpp
! src/share/vm/memory/iterator.cpp
! src/share/vm/memory/iterator.hpp
! src/share/vm/opto/idealKit.cpp
! src/share/vm/opto/idealKit.hpp
! src/share/vm/runtime/sweeper.cpp

Changeset: f4b900403d6e
Author:    trims
Date:      2009-10-09 15:21 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f4b900403d6e

6890293: Bump the HS17 build number to 03
Summary: Update the HS17 build number to 03
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 411c9c4ca96a
Author:    xdono
Date:      2009-10-15 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/411c9c4ca96a

Added tag jdk7-b74 for changeset f4b900403d6e

! .hgtags



From lana.steuck at sun.com  Thu Oct 22 13:59:46 2009
From: lana.steuck at sun.com (lana.steuck at sun.com)
Date: Thu, 22 Oct 2009 20:59:46 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxp: 3 new changesets
Message-ID: <20091022205953.B265141619@hg.openjdk.java.net>

Changeset: feb05980f9f2
Author:    ohair
Date:      2009-09-28 19:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/feb05980f9f2

6886359: Missing jaxws property files and missing changes in jaxp/jaxws drop bundles
Reviewed-by: jjg, tbell

! build-defs.xml
! jaxp.properties

Changeset: ea7b88c676dd
Author:    xdono
Date:      2009-10-02 11:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/ea7b88c676dd

Added tag jdk7-b73 for changeset feb05980f9f2

! .hgtags

Changeset: 555fb78ee4ce
Author:    xdono
Date:      2009-10-15 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/555fb78ee4ce

Added tag jdk7-b74 for changeset ea7b88c676dd

! .hgtags



From lana.steuck at sun.com  Thu Oct 22 14:00:01 2009
From: lana.steuck at sun.com (lana.steuck at sun.com)
Date: Thu, 22 Oct 2009 21:00:01 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxws: 3 new changesets
Message-ID: <20091022210008.4CBCD4161A@hg.openjdk.java.net>

Changeset: 558985e26fe1
Author:    ohair
Date:      2009-09-28 19:38 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/558985e26fe1

6886359: Missing jaxws property files and missing changes in jaxp/jaxws drop bundles
Reviewed-by: jjg, tbell

! build-defs.xml
! jaxws.properties

Changeset: f4466e1b6080
Author:    xdono
Date:      2009-10-02 11:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/f4466e1b6080

Added tag jdk7-b73 for changeset 558985e26fe1

! .hgtags

Changeset: fcf2b8b5d606
Author:    xdono
Date:      2009-10-15 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/fcf2b8b5d606

Added tag jdk7-b74 for changeset f4466e1b6080

! .hgtags



From lana.steuck at sun.com  Thu Oct 22 14:02:49 2009
From: lana.steuck at sun.com (lana.steuck at sun.com)
Date: Thu, 22 Oct 2009 21:02:49 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 49 new changesets
Message-ID: <20091022211916.5667841621@hg.openjdk.java.net>

Changeset: 59b45d636384
Author:    xdono
Date:      2009-10-02 11:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/59b45d636384

Added tag jdk7-b73 for changeset f708138c9aca

! .hgtags

Changeset: 633806cdab51
Author:    jgodinez
Date:      2009-10-05 18:22 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/633806cdab51

Merge


Changeset: c715b68cdcaf
Author:    darcy
Date:      2009-09-22 16:11 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c715b68cdcaf

6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes.
Reviewed-by: alanb

! src/share/classes/java/lang/reflect/Constructor.java
! src/share/classes/java/lang/reflect/Method.java

Changeset: bbb543254c63
Author:    martin
Date:      2009-09-22 18:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/bbb543254c63

4245470: algorithm of java.lang.Byte.hashCode() is not specified
Summary: Specify some hashCode methods are equivalent to intValue
Reviewed-by: darcy

! src/share/classes/java/lang/Byte.java
! src/share/classes/java/lang/Character.java
! src/share/classes/java/lang/Short.java
+ test/java/lang/HashCode.java

Changeset: eb92c939b8a7
Author:    martin
Date:      2009-09-22 18:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/eb92c939b8a7

6582946: Add suite of compare(T, T) methods for ints, longs etc
Reviewed-by: darcy
Contributed-by: kevinb at google.com

! src/share/classes/java/lang/Boolean.java
! src/share/classes/java/lang/Byte.java
! src/share/classes/java/lang/Character.java
! src/share/classes/java/lang/Integer.java
! src/share/classes/java/lang/Long.java
! src/share/classes/java/lang/Short.java
+ test/java/lang/Compare.java

Changeset: bd928aefe692
Author:    weijun
Date:      2009-09-24 21:35 +0800
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/bd928aefe692

6885166: regression test for 6877357 (IPv6 address does not work) error (timed out)
Reviewed-by: xuelei

! test/sun/security/krb5/IPv6.java

Changeset: 5b1aaf2d7504
Author:    ptisnovs
Date:      2009-09-30 11:49 +0200
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5b1aaf2d7504

6884837: JTReg test SetOutgoingIf is not correct
Summary: Added check of network interfaces status
Reviewed-by: alanb, chegar

! test/java/net/MulticastSocket/SetOutgoingIf.java

Changeset: dd724911c90a
Author:    michaelm
Date:      2009-09-29 10:00 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/dd724911c90a

6886108: Test case B4933582 binding to fixed port number
Reviewed-by: chegar

! test/java/net/Authenticator/B4933582.java
! test/sun/net/www/httptest/HttpTransaction.java
! test/sun/security/ssl/sun/net/www/httpstest/HttpTransaction.java

Changeset: 896cbd9c91f4
Author:    michaelm
Date:      2009-10-01 11:25 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/896cbd9c91f4

Merge


Changeset: 527ad9cbc9cf
Author:    weijun
Date:      2009-10-02 18:44 +0800
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/527ad9cbc9cf

6324292: keytool -help is unhelpful
Reviewed-by: xuelei, mullan

! src/share/classes/sun/security/tools/KeyTool.java
! src/share/classes/sun/security/util/Resources.java
+ test/sun/security/tools/keytool/newhelp.sh

Changeset: 56bad48e2810
Author:    weijun
Date:      2009-10-02 18:47 +0800
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/56bad48e2810

6862679: ESC: AD Authentication with user with umlauts fails
Reviewed-by: valeriep, mullan

! src/share/classes/sun/security/krb5/Credentials.java
! src/share/classes/sun/security/krb5/KrbAsReq.java
! src/share/classes/sun/security/krb5/PrincipalName.java
! src/share/classes/sun/security/krb5/Realm.java
! src/share/classes/sun/security/krb5/internal/ETypeInfo.java
! src/share/classes/sun/security/krb5/internal/ETypeInfo2.java
! src/share/classes/sun/security/krb5/internal/KRBError.java
! src/share/classes/sun/security/krb5/internal/crypto/Des.java
+ src/share/classes/sun/security/krb5/internal/util/KerberosString.java
! src/windows/classes/sun/security/krb5/internal/tools/Kinit.java
+ test/sun/security/krb5/RFC396xTest.java

Changeset: a2d24418be6c
Author:    weijun
Date:      2009-10-02 18:49 +0800
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a2d24418be6c

6874472: display address lists for tickets in klist tool
Reviewed-by: valeriep

! src/windows/classes/sun/security/krb5/internal/tools/Klist.java

Changeset: a6046f6e720e
Author:    weijun
Date:      2009-10-02 18:49 +0800
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a6046f6e720e

6868579: RFE: jarsigner to support reading password from environment variable
Reviewed-by: xuelei, wetmore

! src/share/classes/sun/security/tools/JarSigner.java
! src/share/classes/sun/security/tools/KeyTool.java
! src/share/classes/sun/security/util/Resources.java
+ test/sun/security/tools/jarsigner/passtype.sh

Changeset: f0fdc4dd97d5
Author:    michaelm
Date:      2009-10-02 13:57 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f0fdc4dd97d5

6870935: DIGEST proxy authentication fails to connect to URLs with no trailing slash
Reviewed-by: chegar

! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java
! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java
! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java
! src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java
! src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java
+ test/java/net/Authenticator/B6870935.java

Changeset: e782a9564eae
Author:    michaelm
Date:      2009-10-02 13:59 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e782a9564eae

Merge


Changeset: 9fcca0aae3da
Author:    tbell
Date:      2009-10-02 08:49 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9fcca0aae3da

6787605: OpenSolaris doesn't have /usr/ucb/ps so ShellScaffold fails
Reviewed-by: dcubed

! test/com/sun/jdi/ShellScaffold.sh

Changeset: 97f17e6d0560
Author:    alanb
Date:      2009-10-04 15:42 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/97f17e6d0560

6884800: (file) Path.newInputStream does not usefully implement available()
Reviewed-by: martin, chegar

! src/share/classes/sun/nio/ch/ChannelInputStream.java
! test/java/nio/channels/Channels/Basic.java

Changeset: a4f31836660a
Author:    alanb
Date:      2009-10-05 16:45 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a4f31836660a

6854954: Eliminate static dependency on java.awt.AWTPermission
Reviewed-by: mullan, mchung, anthony

! src/share/classes/java/awt/Dialog.java
! src/share/classes/java/awt/MouseInfo.java
! src/share/classes/java/awt/Robot.java
! src/share/classes/java/awt/SystemTray.java
! src/share/classes/java/awt/Toolkit.java
! src/share/classes/java/awt/Window.java
! src/share/classes/java/lang/SecurityManager.java
! src/share/classes/javax/swing/JPopupMenu.java
+ src/share/classes/sun/awt/AWTPermissionFactory.java
! src/share/classes/sun/security/provider/PolicyFile.java
+ src/share/classes/sun/security/util/PermissionFactory.java
! src/share/classes/sun/security/util/SecurityConstants.java

Changeset: 54118c8e0ebe
Author:    vinnie
Date:      2009-10-05 23:42 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/54118c8e0ebe

6885204: JSSE should not require Kerberos to be present
Reviewed-by: wetmore, alanb

! src/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java
! src/share/classes/sun/net/www/protocol/https/HttpsClient.java
! src/share/classes/sun/security/ssl/CipherSuite.java
! src/share/classes/sun/security/ssl/JsseJce.java

Changeset: c499401bc138
Author:    mchung
Date:      2009-10-05 18:15 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c499401bc138

6612680: Remove classloader dependency on jkernel
Summary: Add a new sun.misc.BootClassLoaderHook that DownloadManager will implement
Reviewed-by: alanb, forax, igor

! make/sun/jkernel/Makefile
! src/share/classes/java/awt/color/ICC_Profile.java
! src/share/classes/java/lang/ClassLoader.java
! src/share/classes/java/util/zip/ZipEntry.java
! src/share/classes/sun/jkernel/DownloadManager.java
+ src/share/classes/sun/misc/BootClassLoaderHook.java
! src/share/classes/sun/misc/Launcher.java
! src/share/classes/sun/misc/VM.java
! src/share/native/sun/misc/VM.c

Changeset: 572791538be5
Author:    darcy
Date:      2009-10-06 13:31 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/572791538be5

5062288: (reflect) Core reflection uses raw types when it could be using wildcards
Reviewed-by: alanb

! src/share/classes/java/lang/Class.java
! src/share/classes/java/lang/Package.java
! src/share/classes/java/lang/reflect/AccessibleObject.java
! src/share/classes/java/lang/reflect/Constructor.java
! src/share/classes/java/lang/reflect/Field.java
! src/share/classes/java/lang/reflect/Method.java
! src/share/classes/java/lang/reflect/Proxy.java
! src/share/classes/java/lang/reflect/ReflectAccess.java
! src/share/classes/sun/reflect/LangReflectAccess.java
! src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java
! src/share/classes/sun/reflect/annotation/AnnotationParser.java
! src/share/classes/sun/reflect/annotation/AnnotationType.java

Changeset: 1b81fc851b20
Author:    mchung
Date:      2009-10-06 15:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/1b81fc851b20

6888802: sun.misc.BootClassLoaderHook.getBootstrapPaths stack overflow
Summary: Fixed sun.misc.BootClassLoaderHook.getBootstrapPaths calls hook.getAdditionalBootstrapPaths
Reviewed-by: alanb, tbell

! src/share/classes/sun/misc/BootClassLoaderHook.java
+ test/sun/misc/BootClassLoaderHook/TestHook.java

Changeset: f69b40e43bff
Author:    kamg
Date:      2009-10-06 22:01 -0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f69b40e43bff

6885916: Memory leak in inferencing verifier (libverify.so)
Summary: Use the memory management already present to track allocated memory
Reviewed-by: coleenp, acorn

! src/share/native/common/check_code.c

Changeset: f864c15f6779
Author:    chegar
Date:      2009-10-07 17:23 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f864c15f6779

6887364: SetOutgoingIf.java fails if run on multihomed machine without PIv6 on all interfaces
Reviewed-by: alanb

! test/java/net/MulticastSocket/SetOutgoingIf.java

Changeset: 777714bd992a
Author:    tbell
Date:      2009-10-07 13:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/777714bd992a

6888888: new javah throws NullPointerException when building in jdk/make/java/nio
Summary: Use the bootstrap javah during the build until bug-ID 6889255 is fixed
Reviewed-by: jjg

! make/common/shared/Defs-java.gmk

Changeset: e7ad502130ba
Author:    darcy
Date:      2009-10-07 14:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e7ad502130ba

6480728: Byte.valueOf(byte) returns a cached value but Byte.valueOf(String)
6655735: Integer.toString() and String.valueOf(int) contain slow delegations
Reviewed-by: lancea

! src/share/classes/java/lang/Byte.java
! src/share/classes/java/lang/Double.java
! src/share/classes/java/lang/Float.java
! src/share/classes/java/lang/Integer.java
! src/share/classes/java/lang/Long.java
! src/share/classes/java/lang/Short.java
! src/share/classes/java/lang/String.java

Changeset: 405fd587f13f
Author:    tbell
Date:      2009-10-07 14:15 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/405fd587f13f

Merge

! src/share/classes/java/awt/Toolkit.java
! src/share/classes/java/awt/Window.java

Changeset: 317ac0bf2285
Author:    anthony
Date:      2009-09-15 16:15 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/317ac0bf2285

6868255: Requirements for correct operating of the HW/LW Mixing feature need to be specified
Summary: The specification is updated
Reviewed-by: art, dcherepanov

! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Container.java

Changeset: 986ec552383f
Author:    yan
Date:      2009-09-22 01:20 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/986ec552383f

Merge

- make/javax/swing/plaf/nimbus/Makefile
- make/tools/swing-nimbus/Makefile
- make/tools/swing-nimbus/classes/org/jdesktop/beans/AbstractBean.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BezierControlPoint.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BlendingMode.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Canvas.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/ControlPoint.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Designer.jibx.xml
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/DoubleBean.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/EllipseShape.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/GraphicsHelper.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Layer.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/LayerContainer.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PaintedShape.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PathShape.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/RectangleShape.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/SimpleShape.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/TemplateLayer.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/DropShadowEffect.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/Effect.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtils.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtilsTemp.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerGlowEffect.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerShadowEffect.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/OuterGlowEffect.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/ShadowEffect.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/font/Typeface.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/CanvasMapper.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/ColorMapper.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/DimensionMapper.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/InsetsMapper.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/AbstractGradient.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Gradient.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/GradientStop.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Matte.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/PaintModel.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/RadialGradient.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Texture.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasPath.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasResources.java
- make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasUIDefaults.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/Generator.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/GeneratorUtils.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/ObjectCodeConvertors.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/PainterGenerator.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/TemplateWriter.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/CustomUIDefault.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/HasUIStyle.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/PainterBorder.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.jibx.xml
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIBorder.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIColor.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIComponent.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDefault.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDimension.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIFont.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIcon.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIconRegion.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIInsets.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIPaint.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIProperty.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIRegion.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIState.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStateType.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStyle.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/BorderMapper.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassConverter.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassMapper.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/FontMapper.java
- make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/UIPropertyMapper.java
- src/share/classes/sun/nio/ch/AbstractFuture.java
- src/share/native/java/util/zip/zlib-1.1.3/ChangeLog
- src/share/native/java/util/zip/zlib-1.1.3/README
- src/share/native/java/util/zip/zlib-1.1.3/compress.c
- src/share/native/java/util/zip/zlib-1.1.3/deflate.c
- src/share/native/java/util/zip/zlib-1.1.3/deflate.h
- src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc
- src/share/native/java/util/zip/zlib-1.1.3/example.c
- src/share/native/java/util/zip/zlib-1.1.3/gzio.c
- src/share/native/java/util/zip/zlib-1.1.3/infblock.c
- src/share/native/java/util/zip/zlib-1.1.3/infblock.h
- src/share/native/java/util/zip/zlib-1.1.3/infcodes.c
- src/share/native/java/util/zip/zlib-1.1.3/infcodes.h
- src/share/native/java/util/zip/zlib-1.1.3/inffast.c
- src/share/native/java/util/zip/zlib-1.1.3/inffast.h
- src/share/native/java/util/zip/zlib-1.1.3/inffixed.h
- src/share/native/java/util/zip/zlib-1.1.3/inflate.c
- src/share/native/java/util/zip/zlib-1.1.3/inftrees.c
- src/share/native/java/util/zip/zlib-1.1.3/inftrees.h
- src/share/native/java/util/zip/zlib-1.1.3/infutil.c
- src/share/native/java/util/zip/zlib-1.1.3/infutil.h
- src/share/native/java/util/zip/zlib-1.1.3/minigzip.c
- src/share/native/java/util/zip/zlib-1.1.3/trees.c
- src/share/native/java/util/zip/zlib-1.1.3/trees.h
- src/share/native/java/util/zip/zlib-1.1.3/uncompr.c
- src/share/native/java/util/zip/zlib-1.1.3/zadler32.c
- src/share/native/java/util/zip/zlib-1.1.3/zconf.h
- src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c
- src/share/native/java/util/zip/zlib-1.1.3/zlib.h
- src/share/native/java/util/zip/zlib-1.1.3/zutil.c
- src/share/native/java/util/zip/zlib-1.1.3/zutil.h
- test/java/util/concurrent/LinkedBlockingQueue/LastElement.java
- test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java

Changeset: b6980b0d8440
Author:    dcherepanov
Date:      2009-09-30 13:21 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b6980b0d8440

6853592: VM test nsk.regression.b4261880  fails with "X Error of failed request:  BadWindow" inconsistently.
Reviewed-by: art, anthony

! src/solaris/classes/sun/awt/X11/XToolkit.java

Changeset: a21d00087df9
Author:    dcherepanov
Date:      2009-09-30 15:48 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a21d00087df9

6878284: Sometimes test/javax/swing/system/6799345/TestShutdown.java "hangs"
Reviewed-by: art, ant

! src/share/classes/java/awt/EventQueue.java
! src/share/classes/sun/awt/AWTAutoShutdown.java

Changeset: cf3f9c09ba1d
Author:    anthony
Date:      2009-10-01 14:48 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/cf3f9c09ba1d

6886868: giflib has a memory leak in the MakeMapObject() function
Summary: free() the object before returning NULL
Reviewed-by: art, dcherepanov

! src/share/native/sun/awt/giflib/gifalloc.c

Changeset: 80db944866a9
Author:    anthony
Date:      2009-10-01 15:06 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/80db944866a9

6862611: Reg testcase closed/java/awt/Component/NativeInLightShow/NativeInLightShow.html fails
Summary: The recursiveShowHeavyweightChildren() must be invoked unconditionally in mixOnShowing()
Reviewed-by: art, dcherepanov

! src/share/classes/java/awt/Container.java

Changeset: 4358934555bc
Author:    yan
Date:      2009-10-06 23:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/4358934555bc

Merge

! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Container.java
! src/share/classes/java/awt/EventQueue.java
! src/share/classes/sun/awt/AWTAutoShutdown.java
! src/solaris/classes/sun/awt/X11/XToolkit.java

Changeset: 6216604c05e2
Author:    alexp
Date:      2009-09-09 17:32 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/6216604c05e2

6878792: Sample provided in javax.swing.JLayer class description is not usable
Reviewed-by: rupashka

! src/share/classes/javax/swing/JLayer.java

Changeset: afd85f72784b
Author:    peterz
Date:      2009-09-10 12:30 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/afd85f72784b

6827786: Mnemonic cycling for multiple equal mnemonic armed menu items stops when encountering a submenu
Reviewed-by: alexp

! src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java
! src/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java

Changeset: 51ccbb892a1f
Author:    alexp
Date:      2009-09-15 16:26 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/51ccbb892a1f

6875716: JLayer.remove((Component)null) should behave consistently in (not) throwing NPE
Reviewed-by: rupashka

! src/share/classes/javax/swing/JLayer.java
+ test/javax/swing/JLayer/6875716/bug6875716.java

Changeset: a64dbe61a984
Author:    gsm
Date:      2009-09-16 16:15 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a64dbe61a984

4337267: Arabic Numeral Shaping
Reviewed-by: peterz

! src/share/classes/javax/swing/text/TextLayoutStrategy.java
! src/share/classes/sun/swing/SwingUtilities2.java
+ test/javax/swing/JComponent/4337267/bug4337267.java

Changeset: 481c01572c62
Author:    alexp
Date:      2009-09-17 19:08 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/481c01572c62

4833524: BasicTreeUI.isToggleSelectionEvent() does not properly handle popup triggers
Reviewed-by: rupashka

! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java
! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java
! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
! src/share/classes/javax/swing/plaf/basic/BasicGraphicsUtils.java
! src/share/classes/javax/swing/plaf/basic/BasicListUI.java
! src/share/classes/javax/swing/plaf/basic/BasicTableUI.java
! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java
! src/share/classes/javax/swing/text/DefaultCaret.java

Changeset: 1c7abc800502
Author:    rupashka
Date:      2009-09-18 15:11 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/1c7abc800502

6840086: JFileChooser lacks icons on top right when running on Windows 7
Reviewed-by: peterz, uta

! src/share/classes/sun/awt/shell/ShellFolderManager.java
! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java
! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java
! src/windows/native/sun/windows/ShellFolder2.cpp
+ test/javax/swing/JFileChooser/6840086/bug6840086.java

Changeset: fa71ca7a3655
Author:    yan
Date:      2009-09-21 01:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/fa71ca7a3655

Merge

- src/share/classes/sun/nio/ch/AbstractFuture.java
- src/share/native/java/util/zip/zlib-1.1.3/ChangeLog
- src/share/native/java/util/zip/zlib-1.1.3/README
- src/share/native/java/util/zip/zlib-1.1.3/compress.c
- src/share/native/java/util/zip/zlib-1.1.3/deflate.c
- src/share/native/java/util/zip/zlib-1.1.3/deflate.h
- src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc
- src/share/native/java/util/zip/zlib-1.1.3/example.c
- src/share/native/java/util/zip/zlib-1.1.3/gzio.c
- src/share/native/java/util/zip/zlib-1.1.3/infblock.c
- src/share/native/java/util/zip/zlib-1.1.3/infblock.h
- src/share/native/java/util/zip/zlib-1.1.3/infcodes.c
- src/share/native/java/util/zip/zlib-1.1.3/infcodes.h
- src/share/native/java/util/zip/zlib-1.1.3/inffast.c
- src/share/native/java/util/zip/zlib-1.1.3/inffast.h
- src/share/native/java/util/zip/zlib-1.1.3/inffixed.h
- src/share/native/java/util/zip/zlib-1.1.3/inflate.c
- src/share/native/java/util/zip/zlib-1.1.3/inftrees.c
- src/share/native/java/util/zip/zlib-1.1.3/inftrees.h
- src/share/native/java/util/zip/zlib-1.1.3/infutil.c
- src/share/native/java/util/zip/zlib-1.1.3/infutil.h
- src/share/native/java/util/zip/zlib-1.1.3/minigzip.c
- src/share/native/java/util/zip/zlib-1.1.3/trees.c
- src/share/native/java/util/zip/zlib-1.1.3/trees.h
- src/share/native/java/util/zip/zlib-1.1.3/uncompr.c
- src/share/native/java/util/zip/zlib-1.1.3/zadler32.c
- src/share/native/java/util/zip/zlib-1.1.3/zconf.h
- src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c
- src/share/native/java/util/zip/zlib-1.1.3/zlib.h
- src/share/native/java/util/zip/zlib-1.1.3/zutil.c
- src/share/native/java/util/zip/zlib-1.1.3/zutil.h
- test/java/util/concurrent/LinkedBlockingQueue/LastElement.java
- test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java

Changeset: 9d78c3d9def2
Author:    alexp
Date:      2009-09-21 17:58 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9d78c3d9def2

6883341: SWAT: jdk7-b72 swat build(2009-09-17) threw exceptions when running Java2D demo by clicking Paint ta
Reviewed-by: peterz

! src/share/classes/sun/swing/SwingUtilities2.java
+ test/javax/swing/JMenuItem/6883341/bug6883341.java

Changeset: 6115613a3386
Author:    peterz
Date:      2009-09-23 21:14 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/6115613a3386

6857888: closed/javax/swing/JMenuItem/6458123/bug6458123.java fails with InvocationTargetException.
Reviewed-by: alexp

! src/share/classes/javax/swing/plaf/nimbus/skin.laf
! src/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java

Changeset: d5045dd60c29
Author:    rupashka
Date:      2009-10-06 17:01 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d5045dd60c29

6489130: FileChooserDemo hung by keeping pressing Enter key
Reviewed-by: alexp

! src/share/classes/javax/swing/JFileChooser.java
+ test/javax/swing/JFileChooser/6489130/bug6489130.java

Changeset: dca0ab1a1ac3
Author:    yan
Date:      2009-10-06 23:44 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/dca0ab1a1ac3

Merge

! src/share/classes/sun/swing/SwingUtilities2.java

Changeset: 77f213891ce3
Author:    lana
Date:      2009-10-13 15:25 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/77f213891ce3

Merge


Changeset: eacb36e30327
Author:    vinnie
Date:      2009-10-14 23:41 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/eacb36e30327

6891632: Remove duplicate ECC source files
Reviewed-by: wetmore

- src/share/native/sun/security/ec/ec.h
- src/share/native/sun/security/ec/ec2.h
- src/share/native/sun/security/ec/ec2_163.c
- src/share/native/sun/security/ec/ec2_193.c
- src/share/native/sun/security/ec/ec2_233.c
- src/share/native/sun/security/ec/ec2_aff.c
- src/share/native/sun/security/ec/ec2_mont.c
- src/share/native/sun/security/ec/ec_naf.c
- src/share/native/sun/security/ec/ecc_impl.h
- src/share/native/sun/security/ec/ecdecode.c
- src/share/native/sun/security/ec/ecl-curve.h
- src/share/native/sun/security/ec/ecl-exp.h
- src/share/native/sun/security/ec/ecl-priv.h
- src/share/native/sun/security/ec/ecl.c
- src/share/native/sun/security/ec/ecl.h
- src/share/native/sun/security/ec/ecl_curve.c
- src/share/native/sun/security/ec/ecl_gf.c
- src/share/native/sun/security/ec/ecl_mult.c
- src/share/native/sun/security/ec/ecp.h
- src/share/native/sun/security/ec/ecp_192.c
- src/share/native/sun/security/ec/ecp_224.c
- src/share/native/sun/security/ec/ecp_256.c
- src/share/native/sun/security/ec/ecp_384.c
- src/share/native/sun/security/ec/ecp_521.c
- src/share/native/sun/security/ec/ecp_aff.c
- src/share/native/sun/security/ec/ecp_jac.c
- src/share/native/sun/security/ec/ecp_jm.c
- src/share/native/sun/security/ec/ecp_mont.c
- src/share/native/sun/security/ec/logtab.h
- src/share/native/sun/security/ec/mp_gf2m-priv.h
- src/share/native/sun/security/ec/mp_gf2m.c
- src/share/native/sun/security/ec/mp_gf2m.h
- src/share/native/sun/security/ec/mpi-config.h
- src/share/native/sun/security/ec/mpi-priv.h
- src/share/native/sun/security/ec/mpi.c
- src/share/native/sun/security/ec/mpi.h
- src/share/native/sun/security/ec/mplogic.c
- src/share/native/sun/security/ec/mplogic.h
- src/share/native/sun/security/ec/mpmontg.c
- src/share/native/sun/security/ec/mpprime.h
- src/share/native/sun/security/ec/oid.c
- src/share/native/sun/security/ec/secitem.c
- src/share/native/sun/security/ec/secoidt.h

Changeset: 99dfeece98e2
Author:    xdono
Date:      2009-10-15 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/99dfeece98e2

Added tag jdk7-b74 for changeset eacb36e30327

! .hgtags

Changeset: c579f8307707
Author:    lana
Date:      2009-10-16 18:02 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c579f8307707

Merge

- src/share/native/sun/security/ec/ec.h
- src/share/native/sun/security/ec/ec2.h
- src/share/native/sun/security/ec/ec2_163.c
- src/share/native/sun/security/ec/ec2_193.c
- src/share/native/sun/security/ec/ec2_233.c
- src/share/native/sun/security/ec/ec2_aff.c
- src/share/native/sun/security/ec/ec2_mont.c
- src/share/native/sun/security/ec/ec_naf.c
- src/share/native/sun/security/ec/ecc_impl.h
- src/share/native/sun/security/ec/ecdecode.c
- src/share/native/sun/security/ec/ecl-curve.h
- src/share/native/sun/security/ec/ecl-exp.h
- src/share/native/sun/security/ec/ecl-priv.h
- src/share/native/sun/security/ec/ecl.c
- src/share/native/sun/security/ec/ecl.h
- src/share/native/sun/security/ec/ecl_curve.c
- src/share/native/sun/security/ec/ecl_gf.c
- src/share/native/sun/security/ec/ecl_mult.c
- src/share/native/sun/security/ec/ecp.h
- src/share/native/sun/security/ec/ecp_192.c
- src/share/native/sun/security/ec/ecp_224.c
- src/share/native/sun/security/ec/ecp_256.c
- src/share/native/sun/security/ec/ecp_384.c
- src/share/native/sun/security/ec/ecp_521.c
- src/share/native/sun/security/ec/ecp_aff.c
- src/share/native/sun/security/ec/ecp_jac.c
- src/share/native/sun/security/ec/ecp_jm.c
- src/share/native/sun/security/ec/ecp_mont.c
- src/share/native/sun/security/ec/logtab.h
- src/share/native/sun/security/ec/mp_gf2m-priv.h
- src/share/native/sun/security/ec/mp_gf2m.c
- src/share/native/sun/security/ec/mp_gf2m.h
- src/share/native/sun/security/ec/mpi-config.h
- src/share/native/sun/security/ec/mpi-priv.h
- src/share/native/sun/security/ec/mpi.c
- src/share/native/sun/security/ec/mpi.h
- src/share/native/sun/security/ec/mplogic.c
- src/share/native/sun/security/ec/mplogic.h
- src/share/native/sun/security/ec/mpmontg.c
- src/share/native/sun/security/ec/mpprime.h
- src/share/native/sun/security/ec/oid.c
- src/share/native/sun/security/ec/secitem.c
- src/share/native/sun/security/ec/secoidt.h



From lana.steuck at sun.com  Thu Oct 22 14:26:09 2009
From: lana.steuck at sun.com (lana.steuck at sun.com)
Date: Thu, 22 Oct 2009 21:26:09 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/langtools: 9 new changesets
Message-ID: <20091022212634.F0A8C41624@hg.openjdk.java.net>

Changeset: d498d6ef9c6c
Author:    xdono
Date:      2009-10-02 11:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/langtools/rev/d498d6ef9c6c

Added tag jdk7-b73 for changeset 9596dff46093

! .hgtags

Changeset: e992e602788e
Author:    darcy
Date:      2009-09-23 18:29 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/langtools/rev/e992e602788e

6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception
6517907: javax.lang.model.util.Elements.getConstantExpression() with negative byte value fails
Summary: Fix various problems with Elements.getConstantExpression()
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/Constants.java
! src/share/classes/com/sun/tools/javac/util/Convert.java
+ test/tools/javac/processing/model/util/elements/Foo.java
+ test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java

Changeset: 49359d0e6a9c
Author:    jjg
Date:      2009-09-23 18:48 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/langtools/rev/49359d0e6a9c

6410637: Make decision on deprecated methods in DefaultFileManager and BaseFileObject.
6747645: ZipFileObject.getName is incorrectly deprecated
6885123: JavaFileObject getName issues
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/apt/mirror/util/SourcePositionImpl.java
! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java
! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java
- src/share/classes/com/sun/tools/javac/file/Old199.java
! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java
! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java
! src/share/classes/com/sun/tools/javac/file/ZipArchive.java
! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java
! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java
! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java
! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java
! src/share/classes/com/sun/tools/javac/util/Log.java
! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java
! src/share/classes/com/sun/tools/javadoc/SourcePositionImpl.java
! src/share/classes/javax/tools/SimpleJavaFileObject.java
+ test/tools/javac/4241573/T4241573.java
! test/tools/javac/6589361/T6589361.java
! test/tools/javac/Diagnostics/6769027/T6769027.java
! test/tools/javac/T6705935.java
! test/tools/javac/api/6411310/T6411310.java
+ test/tools/javac/api/6411310/Test.java
! test/tools/javac/api/6733837/T6733837.java

Changeset: c287d51c57da
Author:    jjg
Date:      2009-09-23 19:15 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/langtools/rev/c287d51c57da

6572945: javah should be written as an annotation processor, not a doclet
Reviewed-by: darcy

! make/build.xml
! src/share/classes/com/sun/tools/javah/Gen.java
+ src/share/classes/com/sun/tools/javah/InternalError.java
! src/share/classes/com/sun/tools/javah/JNI.java
+ src/share/classes/com/sun/tools/javah/JavahFileManager.java
+ src/share/classes/com/sun/tools/javah/JavahTask.java
+ src/share/classes/com/sun/tools/javah/JavahTool.java
! src/share/classes/com/sun/tools/javah/LLNI.java
! src/share/classes/com/sun/tools/javah/Main.java
- src/share/classes/com/sun/tools/javah/MainDoclet.java
! src/share/classes/com/sun/tools/javah/Mangle.java
+ src/share/classes/com/sun/tools/javah/NativeHeaderTool.java
! src/share/classes/com/sun/tools/javah/TypeSignature.java
! src/share/classes/com/sun/tools/javah/Util.java
- src/share/classes/com/sun/tools/javah/resources/Linux_ppc.properties
- src/share/classes/com/sun/tools/javah/resources/Linux_sparc.properties
- src/share/classes/com/sun/tools/javah/resources/SunOS_sparc.properties
- src/share/classes/com/sun/tools/javah/resources/SunOS_sparcv9.properties
! src/share/classes/com/sun/tools/javah/resources/l10n.properties
- src/share/classes/com/sun/tools/javah/resources/win32_x86.properties
! src/share/classes/com/sun/tools/javap/DisassemblerTool.java
+ test/tools/javah/6572945/T6572945.java
+ test/tools/javah/6572945/TestClass1.java
+ test/tools/javah/6572945/TestClass2.java
+ test/tools/javah/6572945/TestClass3.java
+ test/tools/javah/6572945/gold/jni.dir.1/TestClass1.h
+ test/tools/javah/6572945/gold/jni.dir.1/TestClass1_Inner1.h
+ test/tools/javah/6572945/gold/jni.dir.1/TestClass1_Inner2.h
+ test/tools/javah/6572945/gold/jni.dir.1/TestClass2.h
+ test/tools/javah/6572945/gold/jni.file.1
+ test/tools/javah/6572945/gold/jni.file.2
+ test/tools/javah/6572945/gold/jni.file.3
! test/tools/javah/MissingParamClassTest.sh
+ test/tools/javah/compareTest/CompareTest.java
+ test/tools/javah/compareTest/CompareTest.sh
+ test/tools/javah/compareTest/FindNativeFiles.java
+ test/tools/javah/compareTest/README

Changeset: d0f541480556
Author:    darcy
Date:      2009-09-24 16:00 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/langtools/rev/d0f541480556

6337964: should ignore last comma in annotation array
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
+ test/tools/javac/annotations/pos/TrailingComma.java

Changeset: 4776a869fdfa
Author:    tbell
Date:      2009-09-25 22:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/langtools/rev/4776a869fdfa

Merge

! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java
! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java
- src/share/classes/com/sun/tools/javac/file/Old199.java
! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java
! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java
! src/share/classes/com/sun/tools/javac/file/ZipArchive.java
! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java
! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
- src/share/classes/com/sun/tools/javah/MainDoclet.java
- src/share/classes/com/sun/tools/javah/resources/Linux_ppc.properties
- src/share/classes/com/sun/tools/javah/resources/Linux_sparc.properties
- src/share/classes/com/sun/tools/javah/resources/SunOS_sparc.properties
- src/share/classes/com/sun/tools/javah/resources/SunOS_sparcv9.properties
- src/share/classes/com/sun/tools/javah/resources/win32_x86.properties
! test/tools/javah/MissingParamClassTest.sh

Changeset: c6d0c55b1aba
Author:    jjg
Date:      2009-09-28 16:48 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/langtools/rev/c6d0c55b1aba

6886348: apt incorrectly uses Scope.table
Reviewed-by: darcy

! src/share/classes/com/sun/tools/apt/comp/Apt.java

Changeset: 1a66b08deed0
Author:    tbell
Date:      2009-10-07 14:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/langtools/rev/1a66b08deed0

Merge

- src/share/classes/com/sun/tools/javac/file/Old199.java
- src/share/classes/com/sun/tools/javah/MainDoclet.java
- src/share/classes/com/sun/tools/javah/resources/Linux_ppc.properties
- src/share/classes/com/sun/tools/javah/resources/Linux_sparc.properties
- src/share/classes/com/sun/tools/javah/resources/SunOS_sparc.properties
- src/share/classes/com/sun/tools/javah/resources/SunOS_sparcv9.properties
- src/share/classes/com/sun/tools/javah/resources/win32_x86.properties

Changeset: 79c13af9217e
Author:    xdono
Date:      2009-10-15 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/2d/langtools/rev/79c13af9217e

Added tag jdk7-b74 for changeset 1a66b08deed0

! .hgtags



From andrew.brygin at sun.com  Fri Oct 23 05:26:44 2009
From: andrew.brygin at sun.com (andrew.brygin at sun.com)
Date: Fri, 23 Oct 2009 12:26:44 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6888215: memory leak in jpeg
	plugin
Message-ID: <20091023122721.AC60941718@hg.openjdk.java.net>

Changeset: 5fc5d3243a5c
Author:    bae
Date:      2009-10-23 15:59 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5fc5d3243a5c

6888215: memory leak in jpeg plugin
Reviewed-by: igor, prr

! src/share/native/sun/awt/image/jpeg/imageioJPEG.c



From andrew.brygin at sun.com  Fri Oct 23 05:41:35 2009
From: andrew.brygin at sun.com (andrew.brygin at sun.com)
Date: Fri, 23 Oct 2009 12:41:35 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6888167: memory leaks in the
	medialib glue code
Message-ID: <20091023124154.B2D9D4171C@hg.openjdk.java.net>

Changeset: 1f2ef3a7d7c0
Author:    bae
Date:      2009-10-23 16:21 +0400
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/1f2ef3a7d7c0

6888167: memory leaks in the medialib glue code
Reviewed-by: igor, prr

! src/share/native/sun/awt/medialib/awt_ImagingLib.c



From gnu_andrew at member.fsf.org  Mon Oct 26 08:52:08 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Mon, 26 Oct 2009 15:52:08 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <20090807164100.86FDEE879@hg.openjdk.java.net>
References: <20090807164100.86FDEE879@hg.openjdk.java.net>
Message-ID: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>

2009/8/7  <roman at kennke.org>:
> Changeset: 64b0c953635d
> Author: ? ?rkennke
> Date: ? ? ?2009-08-07 18:31 +0200
> URL: ? ? ? http://hg.openjdk.java.net/jdk7/2d/jdk/rev/64b0c953635d
>
> 6795908: Refactor FontManager
> Reviewed-by: prr, igor
>
> ! make/sun/awt/FILES_export_windows.gmk
> ! make/sun/awt/make.depend
> ! make/sun/awt/mapfile-mawt-vers
> ! make/sun/awt/mapfile-vers-linux
> ! make/sun/font/mapfile-vers
> ! make/sun/font/mapfile-vers.openjdk
> ! make/sun/headless/mapfile-vers
> ! make/sun/xawt/mapfile-vers
> ! src/share/classes/com/sun/java/swing/plaf/gtk/PangoFonts.java
> ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java
> ! src/share/classes/java/awt/Component.java
> ! src/share/classes/java/awt/Font.java
> ! src/share/classes/java/awt/GraphicsEnvironment.java
> ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template
> ! src/share/classes/javax/swing/text/StyleContext.java
> ! src/share/classes/sun/awt/FontConfiguration.java
> ! src/share/classes/sun/font/CMap.java
> ! src/share/classes/sun/font/CompositeFont.java
> ! src/share/classes/sun/font/CompositeGlyphMapper.java
> ! src/share/classes/sun/font/FileFont.java
> ! src/share/classes/sun/font/FileFontStrike.java
> ! src/share/classes/sun/font/FontDesignMetrics.java
> ! src/share/classes/sun/font/FontFamily.java
> ! src/share/classes/sun/font/FontManager.java
> ! src/share/classes/sun/font/FontManagerNativeLibrary.java
> ! src/share/classes/sun/font/FontResolver.java
> ! src/share/classes/sun/font/FontScaler.java
> ! src/share/classes/sun/font/FreetypeFontScaler.java
> ! src/share/classes/sun/font/GlyphLayout.java
> ! src/share/classes/sun/font/PhysicalStrike.java
> ! src/share/classes/sun/font/StandardGlyphVector.java
> ! src/share/classes/sun/font/StrikeCache.java
> ! src/share/classes/sun/font/TrueTypeFont.java
> ! src/share/classes/sun/font/TrueTypeGlyphMapper.java
> ! src/share/classes/sun/font/Type1Font.java
> ! src/share/classes/sun/font/Type1GlyphMapper.java
> ! src/share/classes/sun/java2d/SunGraphics2D.java
> ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java
> ! src/share/classes/sun/print/PSPrinterJob.java
> ! src/share/classes/sun/print/PathGraphics.java
> ! src/share/classes/sun/swing/SwingUtilities2.java
> ! src/share/native/sun/font/sunFont.c
> ! src/share/native/sun/font/sunfontids.h
> ! src/solaris/classes/sun/awt/X11/XToolkit.java
> ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java
> ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java
> ! src/solaris/classes/sun/awt/motif/MToolkit.java
> ! src/solaris/classes/sun/font/FcFontConfiguration.java
> ! src/solaris/classes/sun/font/NativeFont.java
> ! src/solaris/classes/sun/font/NativeStrike.java
> ! src/solaris/native/sun/awt/fontpath.c
> ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java
> ! src/windows/classes/sun/awt/windows/WFontConfiguration.java
> ! src/windows/classes/sun/awt/windows/WPathGraphics.java
> ! src/windows/classes/sun/awt/windows/WPrinterJob.java
> ! src/windows/classes/sun/awt/windows/WToolkit.java
> ! src/windows/native/sun/font/fontpath.c
> ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp
>
>

This change breaks bootstrapping:

/mnt/builder/icedtea7/bootstrap/jdk1.6.0/bin/javac
-J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions
-J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx896m
-J-Xms128m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -encoding ascii
-source 6 -target 6 -XDignore.symbol.file=true -d
/mnt/builder/icedtea7/openjdk-boot/build/linux-amd64/btclasses \
	    -sourcepath ../../tools/src -classpath
/mnt/builder/icedtea7/bootstrap/jdk1.7.0/jre/lib/rt-closed.jar \
	    ../../tools/src/build/tools/fontchecker/FontChecker.java
Annotation processing got disabled, since it requires a 1.6 compliant JVM
----------
1. ERROR in ../../tools/src/build/tools/fontchecker/FontChecker.java
(at line 339)
	String fontPath = FontManager.getFontPath(true);
	                              ^^^^^^^^^^^
The method getFontPath(boolean) is undefined for the type FontManager

With the change to FontManager, getFontPath(boolean) is now in
SunFontManager on JDK7 making it impossible to bootstrap with OpenJDK7
itself (SunFontManager.getFontPath(boolean))  and OpenJDK6
(FontManager.getFontPath(boolean)).

Can we please either move getFontPath back into FontManager or change
the fontchecker tool?

Thanks,
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Phil.Race at Sun.COM  Mon Oct 26 09:14:57 2009
From: Phil.Race at Sun.COM (Phil Race)
Date: Mon, 26 Oct 2009 09:14:57 -0700
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
References: <20090807164100.86FDEE879@hg.openjdk.java.net>
	<17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
Message-ID: <4AE5CB01.3020000@sun.com>

Or we could stop building fontchecker and discard it.

It was introduced in the 1.4.2 when we had native code that
sometimes crashed the JRE on seeing a bad font file.

The windows jre installer used it in 1.4.2 and 1.5.

The installer stopped using it in 1.6 (6239557) but we continued
to build it.

Looks like in JDK7 build 20 Kelly moved some things around in prep.
for openjdk and we probably lost track it still existed, much less
is being built.

There's also a version in the closed/src/test directory that
was intended as a standalone manual test tool, but can't have been
buildable since 1.4.x days!

-phil.

Andrew John Hughes wrote:
> 2009/8/7  <roman at kennke.org>:
>> Changeset: 64b0c953635d
>> Author:    rkennke
>> Date:      2009-08-07 18:31 +0200
>> URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/64b0c953635d
>>
>> 6795908: Refactor FontManager
>> Reviewed-by: prr, igor
>>
>> ! make/sun/awt/FILES_export_windows.gmk
>> ! make/sun/awt/make.depend
>> ! make/sun/awt/mapfile-mawt-vers
>> ! make/sun/awt/mapfile-vers-linux
>> ! make/sun/font/mapfile-vers
>> ! make/sun/font/mapfile-vers.openjdk
>> ! make/sun/headless/mapfile-vers
>> ! make/sun/xawt/mapfile-vers
>> ! src/share/classes/com/sun/java/swing/plaf/gtk/PangoFonts.java
>> ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java
>> ! src/share/classes/java/awt/Component.java
>> ! src/share/classes/java/awt/Font.java
>> ! src/share/classes/java/awt/GraphicsEnvironment.java
>> ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template
>> ! src/share/classes/javax/swing/text/StyleContext.java
>> ! src/share/classes/sun/awt/FontConfiguration.java
>> ! src/share/classes/sun/font/CMap.java
>> ! src/share/classes/sun/font/CompositeFont.java
>> ! src/share/classes/sun/font/CompositeGlyphMapper.java
>> ! src/share/classes/sun/font/FileFont.java
>> ! src/share/classes/sun/font/FileFontStrike.java
>> ! src/share/classes/sun/font/FontDesignMetrics.java
>> ! src/share/classes/sun/font/FontFamily.java
>> ! src/share/classes/sun/font/FontManager.java
>> ! src/share/classes/sun/font/FontManagerNativeLibrary.java
>> ! src/share/classes/sun/font/FontResolver.java
>> ! src/share/classes/sun/font/FontScaler.java
>> ! src/share/classes/sun/font/FreetypeFontScaler.java
>> ! src/share/classes/sun/font/GlyphLayout.java
>> ! src/share/classes/sun/font/PhysicalStrike.java
>> ! src/share/classes/sun/font/StandardGlyphVector.java
>> ! src/share/classes/sun/font/StrikeCache.java
>> ! src/share/classes/sun/font/TrueTypeFont.java
>> ! src/share/classes/sun/font/TrueTypeGlyphMapper.java
>> ! src/share/classes/sun/font/Type1Font.java
>> ! src/share/classes/sun/font/Type1GlyphMapper.java
>> ! src/share/classes/sun/java2d/SunGraphics2D.java
>> ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java
>> ! src/share/classes/sun/print/PSPrinterJob.java
>> ! src/share/classes/sun/print/PathGraphics.java
>> ! src/share/classes/sun/swing/SwingUtilities2.java
>> ! src/share/native/sun/font/sunFont.c
>> ! src/share/native/sun/font/sunfontids.h
>> ! src/solaris/classes/sun/awt/X11/XToolkit.java
>> ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java
>> ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java
>> ! src/solaris/classes/sun/awt/motif/MToolkit.java
>> ! src/solaris/classes/sun/font/FcFontConfiguration.java
>> ! src/solaris/classes/sun/font/NativeFont.java
>> ! src/solaris/classes/sun/font/NativeStrike.java
>> ! src/solaris/native/sun/awt/fontpath.c
>> ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java
>> ! src/windows/classes/sun/awt/windows/WFontConfiguration.java
>> ! src/windows/classes/sun/awt/windows/WPathGraphics.java
>> ! src/windows/classes/sun/awt/windows/WPrinterJob.java
>> ! src/windows/classes/sun/awt/windows/WToolkit.java
>> ! src/windows/native/sun/font/fontpath.c
>> ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp
>>
>>
> 
> This change breaks bootstrapping:
> 
> /mnt/builder/icedtea7/bootstrap/jdk1.6.0/bin/javac
> -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions
> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx896m
> -J-Xms128m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -encoding ascii
> -source 6 -target 6 -XDignore.symbol.file=true -d
> /mnt/builder/icedtea7/openjdk-boot/build/linux-amd64/btclasses \
> 	    -sourcepath ../../tools/src -classpath
> /mnt/builder/icedtea7/bootstrap/jdk1.7.0/jre/lib/rt-closed.jar \
> 	    ../../tools/src/build/tools/fontchecker/FontChecker.java
> Annotation processing got disabled, since it requires a 1.6 compliant JVM
> ----------
> 1. ERROR in ../../tools/src/build/tools/fontchecker/FontChecker.java
> (at line 339)
> 	String fontPath = FontManager.getFontPath(true);
> 	                              ^^^^^^^^^^^
> The method getFontPath(boolean) is undefined for the type FontManager
> 
> With the change to FontManager, getFontPath(boolean) is now in
> SunFontManager on JDK7 making it impossible to bootstrap with OpenJDK7
> itself (SunFontManager.getFontPath(boolean))  and OpenJDK6
> (FontManager.getFontPath(boolean)).
> 
> Can we please either move getFontPath back into FontManager or change
> the fontchecker tool?
> 
> Thanks,


From Kelly.Ohair at Sun.COM  Mon Oct 26 11:10:21 2009
From: Kelly.Ohair at Sun.COM (Kelly O'Hair)
Date: Mon, 26 Oct 2009 11:10:21 -0700
Subject: [OpenJDK 2D-Dev]  hg: jdk7/2d/jdk: 6795908: Refactor FontManager
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
Message-ID: <4AE5E60D.3070108@sun.com>


Is someone fixing this bootstrap build problem with
FontManager.getFontPath(true) and the fontchecker?

Not sure I care much how it gets fixed, I just need it fixed.

-kto



From gnu_andrew at member.fsf.org  Mon Oct 26 11:19:24 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Mon, 26 Oct 2009 18:19:24 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <4AE5E60D.3070108@sun.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
Message-ID: <17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>

2009/10/26 Kelly O'Hair <Kelly.Ohair at sun.com>:
>
> Is someone fixing this bootstrap build problem with
> FontManager.getFontPath(true) and the fontchecker?
>
> Not sure I care much how it gets fixed, I just need it fixed.
>
> -kto
>
>

You and me both!  I'll look at removing fontchecker.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Igor.Nekrestyanov at Sun.COM  Mon Oct 26 11:47:13 2009
From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov)
Date: Mon, 26 Oct 2009 11:47:13 -0700
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
	<17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
Message-ID: <4AE5EEB1.2010508@sun.com>

Andrew,

i've filed 6895287 for this and plan to fix it soon.
(this will likely a bit faster in terms of "time to get fix into master").

-igor

On 10/26/09 11:19 AM, Andrew John Hughes wrote:
> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>    
>> Is someone fixing this bootstrap build problem with
>> FontManager.getFontPath(true) and the fontchecker?
>>
>> Not sure I care much how it gets fixed, I just need it fixed.
>>
>> -kto
>>
>>
>>      
> You and me both!  I'll look at removing fontchecker.
>    



From gnu_andrew at member.fsf.org  Mon Oct 26 13:10:24 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Mon, 26 Oct 2009 20:10:24 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <4AE5EEB1.2010508@sun.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
	<17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
	<4AE5EEB1.2010508@sun.com>
Message-ID: <17c6771e0910261310t13db6269ja839eab43b9cb594@mail.gmail.com>

2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov at sun.com>:
> Andrew,
>
> i've filed 6895287 for this and plan to fix it soon.
> (this will likely a bit faster in terms of "time to get fix into master").
>
> -igor
>

Thanks for filing a bug ID for this.  I'm already working on a webrev
for this, so let's not duplicate the work.  I'll post it as soon as it
builds.

> On 10/26/09 11:19 AM, Andrew John Hughes wrote:
>>
>> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>>
>>>
>>> Is someone fixing this bootstrap build problem with
>>> FontManager.getFontPath(true) and the fontchecker?
>>>
>>> Not sure I care much how it gets fixed, I just need it fixed.
>>>
>>> -kto
>>>
>>>
>>>
>>
>> You and me both! ?I'll look at removing fontchecker.
>>
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Phil.Race at Sun.COM  Mon Oct 26 13:16:59 2009
From: Phil.Race at Sun.COM (Phil Race)
Date: Mon, 26 Oct 2009 13:16:59 -0700
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <17c6771e0910261310t13db6269ja839eab43b9cb594@mail.gmail.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
	<17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
	<4AE5EEB1.2010508@sun.com>
	<17c6771e0910261310t13db6269ja839eab43b9cb594@mail.gmail.com>
Message-ID: <4AE603BB.3040000@sun.com>

Igor is also fixing the closed src ..

-phil.

Andrew John Hughes wrote:
> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov at sun.com>:
>   
>> Andrew,
>>
>> i've filed 6895287 for this and plan to fix it soon.
>> (this will likely a bit faster in terms of "time to get fix into master").
>>
>> -igor
>>
>>     
>
> Thanks for filing a bug ID for this.  I'm already working on a webrev
> for this, so let's not duplicate the work.  I'll post it as soon as it
> builds.
>
>   
>> On 10/26/09 11:19 AM, Andrew John Hughes wrote:
>>     
>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>>>
>>>       
>>>> Is someone fixing this bootstrap build problem with
>>>> FontManager.getFontPath(true) and the fontchecker?
>>>>
>>>> Not sure I care much how it gets fixed, I just need it fixed.
>>>>
>>>> -kto
>>>>
>>>>
>>>>
>>>>         
>>> You and me both!  I'll look at removing fontchecker.
>>>
>>>       
>>     
>
>
>
>   



From Igor.Nekrestyanov at Sun.COM  Mon Oct 26 13:17:54 2009
From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov)
Date: Mon, 26 Oct 2009 13:17:54 -0700
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <4AE603BB.3040000@sun.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
	<17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
	<4AE5EEB1.2010508@sun.com>
	<17c6771e0910261310t13db6269ja839eab43b9cb594@mail.gmail.com>
	<4AE603BB.3040000@sun.com>
Message-ID: <4AE603F2.40904@sun.com>

I think that's ok.
I can take Andrew's webrev and apply my changes and then putback to both 
workspaces.

-igor

On 10/26/09 1:16 PM, Phil Race wrote:
> Igor is also fixing the closed src ..
>
> -phil.
>
> Andrew John Hughes wrote:
>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov at sun.com>:
>>> Andrew,
>>>
>>> i've filed 6895287 for this and plan to fix it soon.
>>> (this will likely a bit faster in terms of "time to get fix into 
>>> master").
>>>
>>> -igor
>>>
>>
>> Thanks for filing a bug ID for this.  I'm already working on a webrev
>> for this, so let's not duplicate the work.  I'll post it as soon as it
>> builds.
>>
>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote:
>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>>>>
>>>>> Is someone fixing this bootstrap build problem with
>>>>> FontManager.getFontPath(true) and the fontchecker?
>>>>>
>>>>> Not sure I care much how it gets fixed, I just need it fixed.
>>>>>
>>>>> -kto
>>>>>
>>>>>
>>>>>
>>>> You and me both!  I'll look at removing fontchecker.
>>>>
>>
>>
>>
>



From gnu_andrew at member.fsf.org  Mon Oct 26 14:04:30 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Mon, 26 Oct 2009 21:04:30 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <4AE603BB.3040000@sun.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
	<17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
	<4AE5EEB1.2010508@sun.com>
	<17c6771e0910261310t13db6269ja839eab43b9cb594@mail.gmail.com>
	<4AE603BB.3040000@sun.com>
Message-ID: <17c6771e0910261404l1122491cx39ee8faf03690cf0@mail.gmail.com>

2009/10/26 Phil Race <Phil.Race at sun.com>:
> Igor is also fixing the closed src ..
>
> -phil.
>

Right, well obviously I can't fix the proprietary source code base by
definition.  I don't think that's an acceptable reason for refusing
external contributions.  If you want to continue to maintain a
proprietary version as well, then you need to be prepared to integrate
community contributions into it.

I've applied the following webrev to the AWT tree:

http://cr.openjdk.java.net/~andrew/6895287/webrev.01/

and it builds.  It also works when applied to the IcedTea forest,
removing the original error I posted.

Just give the nod and I can push this.

> Andrew John Hughes wrote:
>>
>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov at sun.com>:
>>
>>>
>>> Andrew,
>>>
>>> i've filed 6895287 for this and plan to fix it soon.
>>> (this will likely a bit faster in terms of "time to get fix into
>>> master").
>>>
>>> -igor
>>>
>>>
>>
>> Thanks for filing a bug ID for this. ?I'm already working on a webrev
>> for this, so let's not duplicate the work. ?I'll post it as soon as it
>> builds.
>>
>>
>>>
>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote:
>>>
>>>>
>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>>>>
>>>>
>>>>>
>>>>> Is someone fixing this bootstrap build problem with
>>>>> FontManager.getFontPath(true) and the fontchecker?
>>>>>
>>>>> Not sure I care much how it gets fixed, I just need it fixed.
>>>>>
>>>>> -kto
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> You and me both! ?I'll look at removing fontchecker.
>>>>
>>>>
>>>
>>>
>>
>>
>>
>>
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Phil.Race at Sun.COM  Mon Oct 26 14:20:01 2009
From: Phil.Race at Sun.COM (Phil Race)
Date: Mon, 26 Oct 2009 14:20:01 -0700
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <17c6771e0910261404l1122491cx39ee8faf03690cf0@mail.gmail.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
	<17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
	<4AE5EEB1.2010508@sun.com>
	<17c6771e0910261310t13db6269ja839eab43b9cb594@mail.gmail.com>
	<4AE603BB.3040000@sun.com>
	<17c6771e0910261404l1122491cx39ee8faf03690cf0@mail.gmail.com>
Message-ID: <4AE61281.8090401@sun.com>

The fix looks fine. I think it should go via the build forest, in the 
expectation
that build is likely to integrate to master before AWT or 2D (which
would have been the second choice).

And its not a proprietary vs open thing, rather it seemed more efficient
to me to do both at once.

-phil.

Andrew John Hughes wrote:
> 2009/10/26 Phil Race <Phil.Race at sun.com>:
>   
>> Igor is also fixing the closed src ..
>>
>> -phil.
>>
>>     
>
> Right, well obviously I can't fix the proprietary source code base by
> definition.  I don't think that's an acceptable reason for refusing
> external contributions.  If you want to continue to maintain a
> proprietary version as well, then you need to be prepared to integrate
> community contributions into it.
>
> I've applied the following webrev to the AWT tree:
>
> http://cr.openjdk.java.net/~andrew/6895287/webrev.01/
>
> and it builds.  It also works when applied to the IcedTea forest,
> removing the original error I posted.
>
> Just give the nod and I can push this.
>
>   
>> Andrew John Hughes wrote:
>>     
>>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov at sun.com>:
>>>
>>>       
>>>> Andrew,
>>>>
>>>> i've filed 6895287 for this and plan to fix it soon.
>>>> (this will likely a bit faster in terms of "time to get fix into
>>>> master").
>>>>
>>>> -igor
>>>>
>>>>
>>>>         
>>> Thanks for filing a bug ID for this.  I'm already working on a webrev
>>> for this, so let's not duplicate the work.  I'll post it as soon as it
>>> builds.
>>>
>>>
>>>       
>>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote:
>>>>
>>>>         
>>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>>>>>
>>>>>
>>>>>           
>>>>>> Is someone fixing this bootstrap build problem with
>>>>>> FontManager.getFontPath(true) and the fontchecker?
>>>>>>
>>>>>> Not sure I care much how it gets fixed, I just need it fixed.
>>>>>>
>>>>>> -kto
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>             
>>>>> You and me both!  I'll look at removing fontchecker.
>>>>>
>>>>>
>>>>>           
>>>>         
>>>
>>>
>>>       
>>     
>
>
>
>   



From gnu_andrew at member.fsf.org  Mon Oct 26 14:31:12 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Mon, 26 Oct 2009 21:31:12 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <4AE61281.8090401@sun.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
	<17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
	<4AE5EEB1.2010508@sun.com>
	<17c6771e0910261310t13db6269ja839eab43b9cb594@mail.gmail.com>
	<4AE603BB.3040000@sun.com>
	<17c6771e0910261404l1122491cx39ee8faf03690cf0@mail.gmail.com>
	<4AE61281.8090401@sun.com>
Message-ID: <17c6771e0910261431x512126j3e1666e5ed7a0f89@mail.gmail.com>

2009/10/26 Phil Race <Phil.Race at sun.com>:
> The fix looks fine. I think it should go via the build forest, in the
> expectation
> that build is likely to integrate to master before AWT or 2D (which
> would have been the second choice).
>

Ok, I can push this now or do you still want to?

> And its not a proprietary vs open thing, rather it seemed more efficient
> to me to do both at once.
>

Yes, I agree that's (slightly) more efficient but my point was that
only Sun developers can patch the proprietary tree - I don't have the
option of doing 'both at once'.  So, by taking such a stance you're
effectively ruling out direct external contribution.

> -phil.
>
> Andrew John Hughes wrote:
>>
>> 2009/10/26 Phil Race <Phil.Race at sun.com>:
>>
>>>
>>> Igor is also fixing the closed src ..
>>>
>>> -phil.
>>>
>>>
>>
>> Right, well obviously I can't fix the proprietary source code base by
>> definition. ?I don't think that's an acceptable reason for refusing
>> external contributions. ?If you want to continue to maintain a
>> proprietary version as well, then you need to be prepared to integrate
>> community contributions into it.
>>
>> I've applied the following webrev to the AWT tree:
>>
>> http://cr.openjdk.java.net/~andrew/6895287/webrev.01/
>>
>> and it builds. ?It also works when applied to the IcedTea forest,
>> removing the original error I posted.
>>
>> Just give the nod and I can push this.
>>
>>
>>>
>>> Andrew John Hughes wrote:
>>>
>>>>
>>>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov at sun.com>:
>>>>
>>>>
>>>>>
>>>>> Andrew,
>>>>>
>>>>> i've filed 6895287 for this and plan to fix it soon.
>>>>> (this will likely a bit faster in terms of "time to get fix into
>>>>> master").
>>>>>
>>>>> -igor
>>>>>
>>>>>
>>>>>
>>>>
>>>> Thanks for filing a bug ID for this. ?I'm already working on a webrev
>>>> for this, so let's not duplicate the work. ?I'll post it as soon as it
>>>> builds.
>>>>
>>>>
>>>>
>>>>>
>>>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote:
>>>>>
>>>>>
>>>>>>
>>>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> Is someone fixing this bootstrap build problem with
>>>>>>> FontManager.getFontPath(true) and the fontchecker?
>>>>>>>
>>>>>>> Not sure I care much how it gets fixed, I just need it fixed.
>>>>>>>
>>>>>>> -kto
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> You and me both! ?I'll look at removing fontchecker.
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>>
>>
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Phil.Race at Sun.COM  Mon Oct 26 14:47:06 2009
From: Phil.Race at Sun.COM (Phil Race)
Date: Mon, 26 Oct 2009 14:47:06 -0700
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <17c6771e0910261431x512126j3e1666e5ed7a0f89@mail.gmail.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
	<17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
	<4AE5EEB1.2010508@sun.com>
	<17c6771e0910261310t13db6269ja839eab43b9cb594@mail.gmail.com>
	<4AE603BB.3040000@sun.com>
	<17c6771e0910261404l1122491cx39ee8faf03690cf0@mail.gmail.com>
	<4AE61281.8090401@sun.com>
	<17c6771e0910261431x512126j3e1666e5ed7a0f89@mail.gmail.com>
Message-ID: <4AE618DA.5030203@sun.com>

Andrew John Hughes wrote:
> 2009/10/26 Phil Race <Phil.Race at sun.com>:
>   
>> The fix looks fine. I think it should go via the build forest, in the
>> expectation
>> that build is likely to integrate to master before AWT or 2D (which
>> would have been the second choice).
>>
>>     
>
> Ok, I can push this now or do you still want to?
>   

You can go ahead but I think it would be better to push it to build-dev.

Acc. to http://openjdk.java.net/projects/jdk7/builds/   AWT/Swing integrate
right before build, but I'm not sure AWT are integrating this time and if
they I think a PIT build repo has already been spun off since its now so 
close
to the integration slot.

-phil.




>   
>> And its not a proprietary vs open thing, rather it seemed more efficient
>> to me to do both at once.
>>
>>     
>
> Yes, I agree that's (slightly) more efficient but my point was that
> only Sun developers can patch the proprietary tree - I don't have the
> option of doing 'both at once'.  So, by taking such a stance you're
> effectively ruling out direct external contribution.
>
>   
>> -phil.
>>
>> Andrew John Hughes wrote:
>>     
>>> 2009/10/26 Phil Race <Phil.Race at sun.com>:
>>>
>>>       
>>>> Igor is also fixing the closed src ..
>>>>
>>>> -phil.
>>>>
>>>>
>>>>         
>>> Right, well obviously I can't fix the proprietary source code base by
>>> definition.  I don't think that's an acceptable reason for refusing
>>> external contributions.  If you want to continue to maintain a
>>> proprietary version as well, then you need to be prepared to integrate
>>> community contributions into it.
>>>
>>> I've applied the following webrev to the AWT tree:
>>>
>>> http://cr.openjdk.java.net/~andrew/6895287/webrev.01/
>>>
>>> and it builds.  It also works when applied to the IcedTea forest,
>>> removing the original error I posted.
>>>
>>> Just give the nod and I can push this.
>>>
>>>
>>>       
>>>> Andrew John Hughes wrote:
>>>>
>>>>         
>>>>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov at sun.com>:
>>>>>
>>>>>
>>>>>           
>>>>>> Andrew,
>>>>>>
>>>>>> i've filed 6895287 for this and plan to fix it soon.
>>>>>> (this will likely a bit faster in terms of "time to get fix into
>>>>>> master").
>>>>>>
>>>>>> -igor
>>>>>>
>>>>>>
>>>>>>
>>>>>>             
>>>>> Thanks for filing a bug ID for this.  I'm already working on a webrev
>>>>> for this, so let's not duplicate the work.  I'll post it as soon as it
>>>>> builds.
>>>>>
>>>>>
>>>>>
>>>>>           
>>>>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote:
>>>>>>
>>>>>>
>>>>>>             
>>>>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>>>> Is someone fixing this bootstrap build problem with
>>>>>>>> FontManager.getFontPath(true) and the fontchecker?
>>>>>>>>
>>>>>>>> Not sure I care much how it gets fixed, I just need it fixed.
>>>>>>>>
>>>>>>>> -kto
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>                 
>>>>>>> You and me both!  I'll look at removing fontchecker.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>>             
>>>>>
>>>>>           
>>>>         
>>>
>>>
>>>       
>>     
>
>
>
>   



From gnu_andrew at member.fsf.org  Mon Oct 26 14:54:03 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Mon, 26 Oct 2009 21:54:03 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager
In-Reply-To: <4AE618DA.5030203@sun.com>
References: <17c6771e0910260852j27c4d297pbff86cd4b50d64d8@mail.gmail.com>
	<4AE5E60D.3070108@sun.com>
	<17c6771e0910261119t27774457s50fb900a3974447d@mail.gmail.com>
	<4AE5EEB1.2010508@sun.com>
	<17c6771e0910261310t13db6269ja839eab43b9cb594@mail.gmail.com>
	<4AE603BB.3040000@sun.com>
	<17c6771e0910261404l1122491cx39ee8faf03690cf0@mail.gmail.com>
	<4AE61281.8090401@sun.com>
	<17c6771e0910261431x512126j3e1666e5ed7a0f89@mail.gmail.com>
	<4AE618DA.5030203@sun.com>
Message-ID: <17c6771e0910261454o43b91416l676d73fec7176d62@mail.gmail.com>

2009/10/26 Phil Race <Phil.Race at sun.com>:
> Andrew John Hughes wrote:
>>
>> 2009/10/26 Phil Race <Phil.Race at sun.com>:
>>
>>>
>>> The fix looks fine. I think it should go via the build forest, in the
>>> expectation
>>> that build is likely to integrate to master before AWT or 2D (which
>>> would have been the second choice).
>>>
>>>
>>
>> Ok, I can push this now or do you still want to?
>>
>
> You can go ahead but I think it would be better to push it to build-dev.
>
> Acc. to http://openjdk.java.net/projects/jdk7/builds/ ? AWT/Swing integrate
> right before build, but I'm not sure AWT are integrating this time and if
> they I think a PIT build repo has already been spun off since its now so
> close
> to the integration slot.

Sorry, should have been clearer.  I agree with your logic on this, and
so intended to (and did) push to build-dev:

http://hg.openjdk.java.net/jdk7/build/jdk/rev/9bc5338675e0

>
> -phil.
>
>
>
>
>>
>>>
>>> And its not a proprietary vs open thing, rather it seemed more efficient
>>> to me to do both at once.
>>>
>>>
>>
>> Yes, I agree that's (slightly) more efficient but my point was that
>> only Sun developers can patch the proprietary tree - I don't have the
>> option of doing 'both at once'. ?So, by taking such a stance you're
>> effectively ruling out direct external contribution.
>>
>>
>>>
>>> -phil.
>>>
>>> Andrew John Hughes wrote:
>>>
>>>>
>>>> 2009/10/26 Phil Race <Phil.Race at sun.com>:
>>>>
>>>>
>>>>>
>>>>> Igor is also fixing the closed src ..
>>>>>
>>>>> -phil.
>>>>>
>>>>>
>>>>>
>>>>
>>>> Right, well obviously I can't fix the proprietary source code base by
>>>> definition. ?I don't think that's an acceptable reason for refusing
>>>> external contributions. ?If you want to continue to maintain a
>>>> proprietary version as well, then you need to be prepared to integrate
>>>> community contributions into it.
>>>>
>>>> I've applied the following webrev to the AWT tree:
>>>>
>>>> http://cr.openjdk.java.net/~andrew/6895287/webrev.01/
>>>>
>>>> and it builds. ?It also works when applied to the IcedTea forest,
>>>> removing the original error I posted.
>>>>
>>>> Just give the nod and I can push this.
>>>>
>>>>
>>>>
>>>>>
>>>>> Andrew John Hughes wrote:
>>>>>
>>>>>
>>>>>>
>>>>>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov at sun.com>:
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> Andrew,
>>>>>>>
>>>>>>> i've filed 6895287 for this and plan to fix it soon.
>>>>>>> (this will likely a bit faster in terms of "time to get fix into
>>>>>>> master").
>>>>>>>
>>>>>>> -igor
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> Thanks for filing a bug ID for this. ?I'm already working on a webrev
>>>>>> for this, so let's not duplicate the work. ?I'll post it as soon as it
>>>>>> builds.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Is someone fixing this bootstrap build problem with
>>>>>>>>> FontManager.getFontPath(true) and the fontchecker?
>>>>>>>>>
>>>>>>>>> Not sure I care much how it gets fixed, I just need it fixed.
>>>>>>>>>
>>>>>>>>> -kto
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> You and me both! ?I'll look at removing fontchecker.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>>
>>
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From linuxhippy at gmail.com  Tue Oct 27 14:11:51 2009
From: linuxhippy at gmail.com (Clemens Eisserer)
Date: Tue, 27 Oct 2009 17:11:51 -0400
Subject: [OpenJDK 2D-Dev] Integration of the xrender pipeline rewite
Message-ID: <194f62550910271411mf9c7450w9221ac0ed8a3c775@mail.gmail.com>

Hello again,

I am sorry, but currently I can't spend a lot of time working on the
integration of the xrender pipeline.
I am well aware the code isn't production ready, and sometimes just
plain ugly ;)

There are some global changes, most touching glyph handling, because
the xrender glyph cache logic is written in plain java, and e.g. it
wasn't possible to get notifications of glyph disposal on pure java
code as far as I have seen.
It would be cool to get comments on that stuff first, the other things
could follow piece by piece later.
I did some changes in the OGL pipeline, but I don't have windows, so
D3D changes are missing, as well as the proprietary scaler
modifications.

The webrev is located at: http://93.83.133.214/glyph_changes_001.zip

The changes are in:
> StrikeCache.java
> fontscalerdefs.h
> freetypeScaler.c
> sunFont.c
> OGLTextRenderer.c
> GlyphDisposedListener.java

The only overhead I can see if the additional locking in freeXMemory,
the structure itself should remain at the same size (using otherwise
unused padding).

Any idea wether this requirement could be solved more elegant / efficient?

Thank you in advance, Clemens


From Phil.Race at Sun.COM  Tue Oct 27 16:22:10 2009
From: Phil.Race at Sun.COM (Phil Race)
Date: Tue, 27 Oct 2009 16:22:10 -0700
Subject: [OpenJDK 2D-Dev] Integration of the xrender pipeline rewite
In-Reply-To: <194f62550910271411mf9c7450w9221ac0ed8a3c775@mail.gmail.com>
References: <194f62550910271411mf9c7450w9221ac0ed8a3c775@mail.gmail.com>
Message-ID: <4AE780A2.5040009@sun.com>

I think the main barrier to pushing this is not so much the pipeline code itself,
and whether it works 100% (since it would be off by default) but
making sure it is architecturally sound and doesn't break anything that exists.

I have a very few superficial comments from my quick look at a few files
that are *changed*.
X11SurfaceData and the glyph caching changes need a slightly longer
look. I do note we'd need to make some closed source changes to
match some of it.

1) src/share/classes/sun/font/FontManager.java
   shows that this isn't synced with Roman's refactoring.
   Shouldn't be a big deal though as you only change
one line and I don't think even that line should be changed
where you changed an array size from 20 to 50 :
 >private static CompositeFont [] compFonts = new CompositeFont[50];

I can't guess how x render defines new logical fonts.

2) src/share/classes/sun/java2d/pipe/AAShapePipe.java
imports sun.java2d.pisces.*
but doesn't (and shouldn't) do this directly, and
also has new CairoRenderingEngine(); //.getInstance();

I'm not sure what's intended here. Obviously it
shouldn't directly instantiate that here, but also
I don't even see this class in the webrev.

3)  src/share/classes/sun/java2d/pipe/RenderQueue.java
the size change from 32000 to 12000 probably should be explained :
   75     private static final int BUFFER_SIZE = 12000;

4) src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java
This is just adding white space ..

5) The makefiles introduce a compile time dependency on libxrender.so
   which I believe should be fine for any *nix platform we'd consider
   supporting in JDK 7+ and should also be OK on our build platforms.

6) src/solaris/native/sun/awt/awt_GraphicsEnv.c

What was wrong with using the #define here ?

  969     if (xerr->minor_code == X_ShmAttach) {
->
  969     if (xerr->minor_code == 1) {

-phil.

Clemens Eisserer wrote:
> Hello again,
> 
> I am sorry, but currently I can't spend a lot of time working on the
> integration of the xrender pipeline.
> I am well aware the code isn't production ready, and sometimes just
> plain ugly ;)
> 
> There are some global changes, most touching glyph handling, because
> the xrender glyph cache logic is written in plain java, and e.g. it
> wasn't possible to get notifications of glyph disposal on pure java
> code as far as I have seen.
> It would be cool to get comments on that stuff first, the other things
> could follow piece by piece later.
> I did some changes in the OGL pipeline, but I don't have windows, so
> D3D changes are missing, as well as the proprietary scaler
> modifications.
> 
> The webrev is located at: http://93.83.133.214/glyph_changes_001.zip
> 
> The changes are in:
>> StrikeCache.java
>> fontscalerdefs.h
>> freetypeScaler.c
>> sunFont.c
>> OGLTextRenderer.c
>> GlyphDisposedListener.java
> 
> The only overhead I can see if the additional locking in freeXMemory,
> the structure itself should remain at the same size (using otherwise
> unused padding).
> 
> Any idea wether this requirement could be solved more elegant / efficient?
> 
> Thank you in advance, Clemens


From linuxhippy at gmail.com  Wed Oct 28 02:23:17 2009
From: linuxhippy at gmail.com (Clemens Eisserer)
Date: Wed, 28 Oct 2009 05:23:17 -0400
Subject: [OpenJDK 2D-Dev] Integration of the xrender pipeline rewite
In-Reply-To: <4AE780A2.5040009@sun.com>
References: <194f62550910271411mf9c7450w9221ac0ed8a3c775@mail.gmail.com>
	<4AE780A2.5040009@sun.com>
Message-ID: <194f62550910280223q1e5fc2a1y40790910544f90ee@mail.gmail.com>

Hi Phil,

Thanks for taking a quick look.
Seems the webrev  is in a rather chaotic state, I'll try to clean it
up a bit to make review easier.

> I have a very few superficial comments from my quick look at a few files
> that are *changed*.
> X11SurfaceData and the glyph caching changes need a slightly longer
> look. I do note we'd need to make some closed source changes to
> match some of it.
Yes, the glyph caching changes and the modifications to X11SurfaceData
are basically the modifications I think would be
best included first.

Most of the other stuff hasn't even been reviewed by myself.

> 1) src/share/classes/sun/font/FontManager.java
> ?shows that this isn't synced with Roman's refactoring.
> ?Shouldn't be a big deal though as you only change
> one line and I don't think even that line should be changed
> where you changed an array size from 20 to 50 :
>>private static CompositeFont [] compFonts = new CompositeFont[50];
>
> I can't guess how x render defines new logical fonts.
Argh, I thought I did a sync with the 2d-repo. I really don't like Mercurial ;)
I remember I did that change, because without it I gout
ArrayIndexOutOfBoundsExceptions on my system,
independent from my changes. I just tried to resize the Array without
looking a lot why or what, and it worked.

Sorry, I forgot about that change, its not ment to go upstream.


> 2) src/share/classes/sun/java2d/pipe/AAShapePipe.java
> imports sun.java2d.pisces.*
> but doesn't (and shouldn't) do this directly, and
> also has new CairoRenderingEngine(); //.getInstance();
>
> I'm not sure what's intended here. Obviously it
> shouldn't directly instantiate that here, but also
> I don't even see this class in the webrev.
Sorry, this is from my experiments replacing Pisces with Cairo:
http://linuxhippy.blogspot.com/2009/09/ductus-vs-cairo-vs-pisces.html

Because it requires a slightly modified version of cairo, which I
guess would cause build-system troubles, I don't think its ready for
upstream too.

> 3) ?src/share/classes/sun/java2d/pipe/RenderQueue.java
> the size change from 32000 to 12000 probably should be explained :
> ?75 ? ? private static final int BUFFER_SIZE = 12000;
Accidential.

> 4) src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java
> This is just adding white space ..
Sorry.

> 6) src/solaris/native/sun/awt/awt_GraphicsEnv.c
>
> What was wrong with using the #define here ?
>
> ?969 ? ? if (xerr->minor_code == X_ShmAttach) {
> ->
> ?969 ? ? if (xerr->minor_code == 1) {

Gave me a compile-time problem on Rawhide, the IcedTea guys said hard
to fix, so I worked arround it.

- Clemens


From mario.torre at aicas.com  Wed Oct 28 06:05:05 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Wed, 28 Oct 2009 14:05:05 +0100
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4ADF7BD0.50202@sun.com>
References: <1244588287.3580.53.camel@localhost.localdomain>	<1245328755.3609.26.camel@localhost.localdomain>	<0KLG008439VVTV60@fe-sfbay-10.sun.com>
	<4A3FE35B.3030701@aicas.com>	<0KLN0010AZEI8L30@fe-sfbay-10.sun.com>
	<4A423049.8080903@aicas.com>	<4A4CCD39.4050003@sun.com>
	<4A5488EE.3080808@aicas.com>	<0KMH008HKOJW5M70@fe-sfbay-09.sun.com>
	<4A5593C6.1010700@aicas.com>	<0KMJ00IXG7AYMA10@fe-sfbay-10.sun.com>
	<4A5C7EA6.6070404@aicas.com>	<0KMS003N4D4KVK70@fe-sfbay-10.sun.com>
	<4A5DEAEF.1080101@aicas.com>	<0KMU00GD5EWNFFH0@fe-sfbay-10.sun.com>
	<4A65F6A8.20502@aicas.com>	<0KN5008UCPV3Y720@fe-sfbay-10.sun.com>
	<4A789BDA.5030309@aicas.com>	<1249420092.13246.19.camel@moonlight>	<0KNV007YIGORMT80@fe-sfbay-10.sun.com>	<4A7944B5.8010106@aicas.com>
	<4AB23810.8050308@aicas.com>	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com>
	<4AB3745E.3070208@aicas.com>	<4ADC668F.3040405@aicas.com>
	<0KRS0013M2EYCC60@fe-sfbay-10.sun.com>	<4ADD6C51.6090600@aicas.com>
	<4ADF7BD0.50202@sun.com>
Message-ID: <4AE84181.1070602@aicas.com>

Il 21/10/2009 23:23, Jennifer Godinez ha scritto:
> Hi Mario,
>
> You can submit the patch using the steps in
> http://openjdk.java.net/contribute/
>
> Let me know if you have any questions.
>
> Jennifer

Hi Jennifer,

As far as I understand I need two sponsors, I guess one is Jim, but I'm 
not sure if I can count Roman as valid for the other (actually, I don't 
know the rules to chose the sponsors).

If I understand correctly the "Looks good to go..." means either "push" 
or "we'll push for you", unless there is something else I have to do?

Thanks,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From gnu_andrew at member.fsf.org  Wed Oct 28 08:18:44 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Wed, 28 Oct 2009 15:18:44 +0000
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
	exposes a reference to itself while non fully initialised
In-Reply-To: <4AE84181.1070602@aicas.com>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<4A7944B5.8010106@aicas.com> <4AB23810.8050308@aicas.com>
	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com> <4AB3745E.3070208@aicas.com>
	<4ADC668F.3040405@aicas.com> <0KRS0013M2EYCC60@fe-sfbay-10.sun.com>
	<4ADD6C51.6090600@aicas.com> <4ADF7BD0.50202@sun.com>
	<4AE84181.1070602@aicas.com>
Message-ID: <17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>

2009/10/28 Mario Torre <mario.torre at aicas.com>:
> Il 21/10/2009 23:23, Jennifer Godinez ha scritto:
>>
>> Hi Mario,
>>
>> You can submit the patch using the steps in
>> http://openjdk.java.net/contribute/
>>
>> Let me know if you have any questions.
>>
>> Jennifer
>
> Hi Jennifer,
>
> As far as I understand I need two sponsors, I guess one is Jim, but I'm not
> sure if I can count Roman as valid for the other (actually, I don't know the
> rules to chose the sponsors).
>
> If I understand correctly the "Looks good to go..." means either "push" or
> "we'll push for you", unless there is something else I have to do?
>
> Thanks,
> Mario
> --
> Mario Torre, Software Developer, http://www.jroller.com/neugens/
> aicas Allerton Interworks Computer Automated Systems GmbH
> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
> http://www.aicas.com ? * Tel: +49-721-663 968-44
> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
> Fingerprint: BA39 9666 94EC 8B73 27FA ?FC7C 4086 63E3 80F2 40CF
>
> USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
> Gesch?ftsf?hrer: Dr. James J. Hunt
>
> Please, support open standards:
> http://endsoftpatents.org/
>
>

Mario,

Sounds to me like you can go ahead and push the patch to the 2d
forest, with a Reviewed-by: flar, rkennke.  You presumably have an
OpenJDK account from your cacio work.
Hop on IRC if you need a hand with the practicalities.

Cheers,
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Jennifer.Godinez at Sun.COM  Wed Oct 28 10:20:58 2009
From: Jennifer.Godinez at Sun.COM (Jennifer Godinez)
Date: Wed, 28 Oct 2009 10:20:58 -0700
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<4A7944B5.8010106@aicas.com> <4AB23810.8050308@aicas.com>
	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com> <4AB3745E.3070208@aicas.com>
	<4ADC668F.3040405@aicas.com> <0KRS0013M2EYCC60@fe-sfbay-10.sun.com>
	<4ADD6C51.6090600@aicas.com> <4ADF7BD0.50202@sun.com>
	<4AE84181.1070602@aicas.com>
	<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>
Message-ID: <4AE87D7A.2040103@Sun.COM>

Hi Mario,

http://bugs.openjdk.java.net/show_bug.cgi?id=100068

First, please update the above bugzilla report with the latest approved webrev.

If you have signed the SCA, then go ahead and push your change.

Jennifer


Andrew John Hughes wrote:
> 2009/10/28 Mario Torre <mario.torre at aicas.com>:
>> Il 21/10/2009 23:23, Jennifer Godinez ha scritto:
>>> Hi Mario,
>>>
>>> You can submit the patch using the steps in
>>> http://openjdk.java.net/contribute/
>>>
>>> Let me know if you have any questions.
>>>
>>> Jennifer
>> Hi Jennifer,
>>
>> As far as I understand I need two sponsors, I guess one is Jim, but I'm not
>> sure if I can count Roman as valid for the other (actually, I don't know the
>> rules to chose the sponsors).
>>
>> If I understand correctly the "Looks good to go..." means either "push" or
>> "we'll push for you", unless there is something else I have to do?
>>
>> Thanks,
>> Mario
>> --
>> Mario Torre, Software Developer, http://www.jroller.com/neugens/
>> aicas Allerton Interworks Computer Automated Systems GmbH
>> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
>> http://www.aicas.com   * Tel: +49-721-663 968-44
>> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
>> Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF
>>
>> USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
>> Gesch?ftsf?hrer: Dr. James J. Hunt
>>
>> Please, support open standards:
>> http://endsoftpatents.org/
>>
>>
> 
> Mario,
> 
> Sounds to me like you can go ahead and push the patch to the 2d
> forest, with a Reviewed-by: flar, rkennke.  You presumably have an
> OpenJDK account from your cacio work.
> Hop on IRC if you need a hand with the practicalities.
> 
> Cheers,


From Phil.Race at Sun.COM  Wed Oct 28 11:24:48 2009
From: Phil.Race at Sun.COM (Phil Race)
Date: Wed, 28 Oct 2009 11:24:48 -0700
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4AE87D7A.2040103@Sun.COM>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<4A7944B5.8010106@aicas.com> <4AB23810.8050308@aicas.com>
	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com> <4AB3745E.3070208@aicas.com>
	<4ADC668F.3040405@aicas.com> <0KRS0013M2EYCC60@fe-sfbay-10.sun.com>
	<4ADD6C51.6090600@aicas.com> <4ADF7BD0.50202@sun.com>
	<4AE84181.1070602@aicas.com>
	<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>
	<4AE87D7A.2040103@Sun.COM>
Message-ID: <4AE88C70.7000207@sun.com>

Mario,
PS .. sponsor and reviewer are different roles although
quite commonly a sponsor will also be a reviewer.
The sponsor is basically there to help you through the
bureaucracy and the reviewer checks the actual code

In this case since you have a userid you can push and I'm
not sure you need a sponsor for that but Jennifer is
the sponsor who will get the sun bug ID to push under.

You normally need two reviewers and reviewers are supposed
to be group members. At this point this fix has been reviewed
well enough that I think one of the reviewers being a group
member is more than good enough. In the case that its not
free free to cite me ..

-phil.

Jennifer Godinez wrote:
> Hi Mario,
> 
> http://bugs.openjdk.java.net/show_bug.cgi?id=100068
> 
> First, please update the above bugzilla report with the latest approved 
> webrev.
> 
> If you have signed the SCA, then go ahead and push your change.
> 
> Jennifer
> 
> 
> Andrew John Hughes wrote:
>> 2009/10/28 Mario Torre <mario.torre at aicas.com>:
>>> Il 21/10/2009 23:23, Jennifer Godinez ha scritto:
>>>> Hi Mario,
>>>>
>>>> You can submit the patch using the steps in
>>>> http://openjdk.java.net/contribute/
>>>>
>>>> Let me know if you have any questions.
>>>>
>>>> Jennifer
>>> Hi Jennifer,
>>>
>>> As far as I understand I need two sponsors, I guess one is Jim, but 
>>> I'm not
>>> sure if I can count Roman as valid for the other (actually, I don't 
>>> know the
>>> rules to chose the sponsors).
>>>
>>> If I understand correctly the "Looks good to go..." means either 
>>> "push" or
>>> "we'll push for you", unless there is something else I have to do?
>>>
>>> Thanks,
>>> Mario
>>> -- 
>>> Mario Torre, Software Developer, http://www.jroller.com/neugens/
>>> aicas Allerton Interworks Computer Automated Systems GmbH
>>> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
>>> http://www.aicas.com   * Tel: +49-721-663 968-44
>>> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
>>> Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF
>>>
>>> USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
>>> Gesch?ftsf?hrer: Dr. James J. Hunt
>>>
>>> Please, support open standards:
>>> http://endsoftpatents.org/
>>>
>>>
>>
>> Mario,
>>
>> Sounds to me like you can go ahead and push the patch to the 2d
>> forest, with a Reviewed-by: flar, rkennke.  You presumably have an
>> OpenJDK account from your cacio work.
>> Hop on IRC if you need a hand with the practicalities.
>>
>> Cheers,


From Jennifer.Godinez at Sun.COM  Wed Oct 28 11:43:13 2009
From: Jennifer.Godinez at Sun.COM (Jennifer Godinez)
Date: Wed, 28 Oct 2009 11:43:13 -0700
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4AE88C70.7000207@sun.com>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<4A7944B5.8010106@aicas.com> <4AB23810.8050308@aicas.com>
	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com> <4AB3745E.3070208@aicas.com>
	<4ADC668F.3040405@aicas.com> <0KRS0013M2EYCC60@fe-sfbay-10.sun.com>
	<4ADD6C51.6090600@aicas.com> <4ADF7BD0.50202@sun.com>
	<4AE84181.1070602@aicas.com>
	<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>
	<4AE87D7A.2040103@Sun.COM> <4AE88C70.7000207@sun.com>
Message-ID: <4AE890C1.70305@Sun.COM>

Hi Mario,

Please use the sun bug ID 6896068 when pushing the change. Make sure that you push it in 2D 
repository.  If you need help, let me know.

Thank you.

Jennifer

Phil Race wrote:
> Mario,
> PS .. sponsor and reviewer are different roles although
> quite commonly a sponsor will also be a reviewer.
> The sponsor is basically there to help you through the
> bureaucracy and the reviewer checks the actual code
> 
> In this case since you have a userid you can push and I'm
> not sure you need a sponsor for that but Jennifer is
> the sponsor who will get the sun bug ID to push under.
> 
> You normally need two reviewers and reviewers are supposed
> to be group members. At this point this fix has been reviewed
> well enough that I think one of the reviewers being a group
> member is more than good enough. In the case that its not
> free free to cite me ..
> 
> -phil.
> 
> Jennifer Godinez wrote:
>> Hi Mario,
>>
>> http://bugs.openjdk.java.net/show_bug.cgi?id=100068
>>
>> First, please update the above bugzilla report with the latest 
>> approved webrev.
>>
>> If you have signed the SCA, then go ahead and push your change.
>>
>> Jennifer
>>
>>
>> Andrew John Hughes wrote:
>>> 2009/10/28 Mario Torre <mario.torre at aicas.com>:
>>>> Il 21/10/2009 23:23, Jennifer Godinez ha scritto:
>>>>> Hi Mario,
>>>>>
>>>>> You can submit the patch using the steps in
>>>>> http://openjdk.java.net/contribute/
>>>>>
>>>>> Let me know if you have any questions.
>>>>>
>>>>> Jennifer
>>>> Hi Jennifer,
>>>>
>>>> As far as I understand I need two sponsors, I guess one is Jim, but 
>>>> I'm not
>>>> sure if I can count Roman as valid for the other (actually, I don't 
>>>> know the
>>>> rules to chose the sponsors).
>>>>
>>>> If I understand correctly the "Looks good to go..." means either 
>>>> "push" or
>>>> "we'll push for you", unless there is something else I have to do?
>>>>
>>>> Thanks,
>>>> Mario
>>>> -- 
>>>> Mario Torre, Software Developer, http://www.jroller.com/neugens/
>>>> aicas Allerton Interworks Computer Automated Systems GmbH
>>>> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
>>>> http://www.aicas.com   * Tel: +49-721-663 968-44
>>>> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
>>>> Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF
>>>>
>>>> USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
>>>> Gesch?ftsf?hrer: Dr. James J. Hunt
>>>>
>>>> Please, support open standards:
>>>> http://endsoftpatents.org/
>>>>
>>>>
>>>
>>> Mario,
>>>
>>> Sounds to me like you can go ahead and push the patch to the 2d
>>> forest, with a Reviewed-by: flar, rkennke.  You presumably have an
>>> OpenJDK account from your cacio work.
>>> Hop on IRC if you need a hand with the practicalities.
>>>
>>> Cheers,


From mario.torre at aicas.com  Thu Oct 29 05:58:50 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Thu, 29 Oct 2009 13:58:50 +0100
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4AE890C1.70305@Sun.COM>
References: <1244588287.3580.53.camel@localhost.localdomain>	<4A7944B5.8010106@aicas.com>
	<4AB23810.8050308@aicas.com>	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com>
	<4AB3745E.3070208@aicas.com>	<4ADC668F.3040405@aicas.com>
	<0KRS0013M2EYCC60@fe-sfbay-10.sun.com>	<4ADD6C51.6090600@aicas.com>
	<4ADF7BD0.50202@sun.com>	<4AE84181.1070602@aicas.com>	<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>	<4AE87D7A.2040103@Sun.COM>
	<4AE88C70.7000207@sun.com> <4AE890C1.70305@Sun.COM>
Message-ID: <4AE9918A.7050208@aicas.com>

Il 28/10/2009 19:43, Jennifer Godinez ha scritto:
> Hi Mario,
>
> Please use the sun bug ID 6896068 when pushing the change. Make sure
> that you push it in 2D repository. If you need help, let me know.
>
> Thank you.
>
> Jennifer

Hi Jennifer!

I'll try to do everything today, thanks a lot for the help and support 
everybody!

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From mario.torre at aicas.com  Fri Oct 30 07:40:51 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Fri, 30 Oct 2009 15:40:51 +0100
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4AE9918A.7050208@aicas.com>
References: <1244588287.3580.53.camel@localhost.localdomain>	<4A7944B5.8010106@aicas.com>	<4AB23810.8050308@aicas.com>	<0KQ400GAWU5TERA0@fe-sfbay-09.sun.com>	<4AB3745E.3070208@aicas.com>	<4ADC668F.3040405@aicas.com>	<0KRS0013M2EYCC60@fe-sfbay-10.sun.com>	<4ADD6C51.6090600@aicas.com>	<4ADF7BD0.50202@sun.com>	<4AE84181.1070602@aicas.com>	<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>	<4AE87D7A.2040103@Sun.COM>	<4AE88C70.7000207@sun.com>
	<4AE890C1.70305@Sun.COM> <4AE9918A.7050208@aicas.com>
Message-ID: <4AEAFAF3.3080909@aicas.com>

Il 29/10/2009 13:58, Mario Torre ha scritto:
> Il 28/10/2009 19:43, Jennifer Godinez ha scritto:
>> Hi Mario,
>>
>> Please use the sun bug ID 6896068 when pushing the change. Make sure
>> that you push it in 2D repository. If you need help, let me know.
>>
>> Thank you.
>>
>> Jennifer
>
> Hi Jennifer!
>
> I'll try to do everything today, thanks a lot for the help and support
> everybody!
>
> Cheers,
> Mario

Hi all!

I'm trying to get a full build up and running before the final push of 
this bug.

I got a fresh checkout of the j2d forest:

ssh://hg.openjdk.java.net/jdk7/2d/

But this is what I get when I do a "LANG=C make":

# Running javah:
/NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah 
-bootclasspath 
/home/neugens/work_space/netbeans/openjdk-2d/build/linux-amd64/classes 
-d 
/home/neugens/work_space/netbeans/openjdk-2d/build/linux-amd64/tmp/java/java.lang/java/CClassHeaders/ 
\
                 java.lang.Object java.lang.Class java.lang.Compiler 
java.lang.String java.lang.Thread java.lang.ThreadGroup 
java.lang.StrictMath java.lang.Number java.lang.Byte java.lang.Short 
java.lang.Integer java.lang.Long java.lang.Float java.lang.Double 
java.lang.Boolean java.lang.Character java.lang.System 
java.lang.ClassLoader java.lang.Runtime java.lang.SecurityManager 
java.lang.Shutdown java.lang.Package java.lang.ref.Finalizer 
java.lang.reflect.AccessibleObject java.lang.reflect.Field 
java.lang.reflect.Method java.lang.reflect.Constructor 
java.lang.reflect.InvocationTargetException java.lang.reflect.Array 
java.lang.reflect.Proxy java.security.AccessController java.util.Date 
java.util.TimeZone java.util.ResourceBundle 
java.util.concurrent.atomic.AtomicLong 
java.util.prefs.FileSystemPreferences java.io.Console 
java.io.FileDescriptor java.io.InputStream java.io.FileInputStream 
java.io.FileOutputStream java.io.PrintStream java.io.RandomAccessFile 
java.io.DataInputStream java.io.DataOutputStream java.io.File 
java.io.FileSystem java.io.UnixFileSystem java.io.ObjectInputStream 
java.io.ObjectOutputStream java.io.ObjectStreamClass java.lang.Throwable 
java.lang.NoClassDefFoundError java.lang.StringIndexOutOfBoundsException 
java.lang.OutOfMemoryError sun.misc.Version sun.misc.VM 
sun.misc.VMSupport sun.misc.Signal sun.misc.MessageUtils 
sun.misc.NativeSignalHandler sun.misc.GC sun.reflect.ConstantPool 
sun.reflect.NativeConstructorAccessorImpl 
sun.reflect.NativeMethodAccessorImpl sun.reflect.Reflection 
java.lang.ClassLoader\$NativeLibrary
make[4]: 
/NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah: 
Command not found
make[4]: *** 
[/home/neugens/work_space/netbeans/openjdk-2d/build/linux-amd64/tmp/java/java.lang/java/obj64/.class.headers.amd64] 
Error 127
make[4]: Leaving directory 
`/home/neugens/work_space/netbeans/openjdk-2d/jdk/make/java/java'
make[3]: *** [all] Error 1
make[3]: Leaving directory 
`/home/neugens/work_space/netbeans/openjdk-2d/jdk/make/java'
make[2]: *** [all] Error 1
make[2]: Leaving directory 
`/home/neugens/work_space/netbeans/openjdk-2d/jdk/make'
make[1]: *** [jdk-build] Error 2
make[1]: Leaving directory `/home/neugens/work_space/netbeans/openjdk-2d'
make: *** [build_product_image] Error 2

I can do a full build of the latest jdk7 forest, so looks like something 
specific of the j2d one.

Those are the envs I use:

export ALT_BOOTDIR=/usr/lib/jvm/java-1.6.0
export 
ALT_BINARY_PLUGS_PATH=/home/neugens/work_space/netbeans/plugs/openjdk-binary-plugs

(I know I don't need the binary plugs).

Looking at the build machinery looks like some envs variable are 
missing, but I never had to set those explicitly, so I guess something 
is going wrong in the process.

Does anyone knows about that, or I'm doing something wrong?

Thanks,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From linuxhippy at gmail.com  Fri Oct 30 07:50:27 2009
From: linuxhippy at gmail.com (Clemens Eisserer)
Date: Fri, 30 Oct 2009 10:50:27 -0400
Subject: [OpenJDK 2D-Dev] Integration of the xrender pipeline rewite
In-Reply-To: <194f62550910280223q1e5fc2a1y40790910544f90ee@mail.gmail.com>
References: <194f62550910271411mf9c7450w9221ac0ed8a3c775@mail.gmail.com>
	<4AE780A2.5040009@sun.com>
	<194f62550910280223q1e5fc2a1y40790910544f90ee@mail.gmail.com>
Message-ID: <194f62550910300750u1410e722xa031915f43df3c70@mail.gmail.com>

Hi again,

I've uploaded a new version, which includes some fixes for the
problems you mentioned, including one fix from icedtea using static
initializers for X11SurfaceData. Would be great if you could have
another look.

http://93.83.133.214/xrender_002.zip

Thanks, Clemens


From gnu_andrew at member.fsf.org  Fri Oct 30 07:53:18 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Fri, 30 Oct 2009 14:53:18 +0000
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
	exposes a reference to itself while non fully initialised
In-Reply-To: <4AEAFAF3.3080909@aicas.com>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<4ADD6C51.6090600@aicas.com> <4ADF7BD0.50202@sun.com>
	<4AE84181.1070602@aicas.com>
	<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>
	<4AE87D7A.2040103@Sun.COM> <4AE88C70.7000207@sun.com>
	<4AE890C1.70305@Sun.COM> <4AE9918A.7050208@aicas.com>
	<4AEAFAF3.3080909@aicas.com>
Message-ID: <17c6771e0910300753p7e58a677v5dec0fa76f0237bb@mail.gmail.com>

2009/10/30 Mario Torre <mario.torre at aicas.com>:
> Il 29/10/2009 13:58, Mario Torre ha scritto:
>>
>> Il 28/10/2009 19:43, Jennifer Godinez ha scritto:
>>>
>>> Hi Mario,
>>>
>>> Please use the sun bug ID 6896068 when pushing the change. Make sure
>>> that you push it in 2D repository. If you need help, let me know.
>>>
>>> Thank you.
>>>
>>> Jennifer
>>
>> Hi Jennifer!
>>
>> I'll try to do everything today, thanks a lot for the help and support
>> everybody!
>>
>> Cheers,
>> Mario
>
> Hi all!
>
> I'm trying to get a full build up and running before the final push of this
> bug.
>
> I got a fresh checkout of the j2d forest:
>
> ssh://hg.openjdk.java.net/jdk7/2d/
>
> But this is what I get when I do a "LANG=C make":
>
> # Running javah:
> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah
> -bootclasspath
> /home/neugens/work_space/netbeans/openjdk-2d/build/linux-amd64/classes -d
> /home/neugens/work_space/netbeans/openjdk-2d/build/linux-amd64/tmp/java/java.lang/java/CClassHeaders/
> \
> ? ? ? ? ? ? ? ?java.lang.Object java.lang.Class java.lang.Compiler
> java.lang.String java.lang.Thread java.lang.ThreadGroup java.lang.StrictMath
> java.lang.Number java.lang.Byte java.lang.Short java.lang.Integer
> java.lang.Long java.lang.Float java.lang.Double java.lang.Boolean
> java.lang.Character java.lang.System java.lang.ClassLoader java.lang.Runtime
> java.lang.SecurityManager java.lang.Shutdown java.lang.Package
> java.lang.ref.Finalizer java.lang.reflect.AccessibleObject
> java.lang.reflect.Field java.lang.reflect.Method
> java.lang.reflect.Constructor java.lang.reflect.InvocationTargetException
> java.lang.reflect.Array java.lang.reflect.Proxy
> java.security.AccessController java.util.Date java.util.TimeZone
> java.util.ResourceBundle java.util.concurrent.atomic.AtomicLong
> java.util.prefs.FileSystemPreferences java.io.Console java.io.FileDescriptor
> java.io.InputStream java.io.FileInputStream java.io.FileOutputStream
> java.io.PrintStream java.io.RandomAccessFile java.io.DataInputStream
> java.io.DataOutputStream java.io.File java.io.FileSystem
> java.io.UnixFileSystem java.io.ObjectInputStream java.io.ObjectOutputStream
> java.io.ObjectStreamClass java.lang.Throwable java.lang.NoClassDefFoundError
> java.lang.StringIndexOutOfBoundsException java.lang.OutOfMemoryError
> sun.misc.Version sun.misc.VM sun.misc.VMSupport sun.misc.Signal
> sun.misc.MessageUtils sun.misc.NativeSignalHandler sun.misc.GC
> sun.reflect.ConstantPool sun.reflect.NativeConstructorAccessorImpl
> sun.reflect.NativeMethodAccessorImpl sun.reflect.Reflection
> java.lang.ClassLoader\$NativeLibrary
> make[4]:
> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah:
> Command not found
> make[4]: ***
> [/home/neugens/work_space/netbeans/openjdk-2d/build/linux-amd64/tmp/java/java.lang/java/obj64/.class.headers.amd64]
> Error 127
> make[4]: Leaving directory
> `/home/neugens/work_space/netbeans/openjdk-2d/jdk/make/java/java'
> make[3]: *** [all] Error 1
> make[3]: Leaving directory
> `/home/neugens/work_space/netbeans/openjdk-2d/jdk/make/java'
> make[2]: *** [all] Error 1
> make[2]: Leaving directory
> `/home/neugens/work_space/netbeans/openjdk-2d/jdk/make'
> make[1]: *** [jdk-build] Error 2
> make[1]: Leaving directory `/home/neugens/work_space/netbeans/openjdk-2d'
> make: *** [build_product_image] Error 2
>
> I can do a full build of the latest jdk7 forest, so looks like something
> specific of the j2d one.
>
> Those are the envs I use:
>
> export ALT_BOOTDIR=/usr/lib/jvm/java-1.6.0
> export
> ALT_BINARY_PLUGS_PATH=/home/neugens/work_space/netbeans/plugs/openjdk-binary-plugs
>
> (I know I don't need the binary plugs).
>
> Looking at the build machinery looks like some envs variable are missing,
> but I never had to set those explicitly, so I guess something is going wrong
> in the process.
>
> Does anyone knows about that, or I'm doing something wrong?
>
> Thanks,
> Mario
> --
> Mario Torre, Software Developer, http://www.jroller.com/neugens/
> aicas Allerton Interworks Computer Automated Systems GmbH
> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
> http://www.aicas.com ? * Tel: +49-721-663 968-44
> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
> Fingerprint: BA39 9666 94EC 8B73 27FA ?FC7C 4086 63E3 80F2 40CF
>
> USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
> Gesch?ftsf?hrer: Dr. James J. Hunt
>
> Please, support open standards:
> http://endsoftpatents.org/
>
>

http://mail.openjdk.java.net/pipermail/build-dev/2009-October/002447.html

Simple solution is to build with ALT_JDK_IMPORT_PATH set to the same
as what you set ALT_BOOTDIR to for now.  You shouldn't need to, but
it's a quicker and simpler solution than patching the build.  It
should be fixed when b75 is pulled in to the 2d tree.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From mario.torre at aicas.com  Fri Oct 30 07:54:37 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Fri, 30 Oct 2009 15:54:37 +0100
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <17c6771e0910300753p7e58a677v5dec0fa76f0237bb@mail.gmail.com>
References: <1244588287.3580.53.camel@localhost.localdomain>	
	<4ADD6C51.6090600@aicas.com> <4ADF7BD0.50202@sun.com>	
	<4AE84181.1070602@aicas.com>	
	<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>	
	<4AE87D7A.2040103@Sun.COM> <4AE88C70.7000207@sun.com>	
	<4AE890C1.70305@Sun.COM> <4AE9918A.7050208@aicas.com>	
	<4AEAFAF3.3080909@aicas.com>
	<17c6771e0910300753p7e58a677v5dec0fa76f0237bb@mail.gmail.com>
Message-ID: <4AEAFE2D.1050602@aicas.com>

Il 30/10/2009 15:53, Andrew John Hughes ha scritto:

> http://mail.openjdk.java.net/pipermail/build-dev/2009-October/002447.html
>
> Simple solution is to build with ALT_JDK_IMPORT_PATH set to the same
> as what you set ALT_BOOTDIR to for now.  You shouldn't need to, but
> it's a quicker and simpler solution than patching the build.  It
> should be fixed when b75 is pulled in to the 2d tree.

Good Andrew,

Thanks a lot,
Mario

-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From gnu_andrew at member.fsf.org  Fri Oct 30 07:55:58 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Fri, 30 Oct 2009 14:55:58 +0000
Subject: [OpenJDK 2D-Dev] Integration of the xrender pipeline rewite
In-Reply-To: <194f62550910300750u1410e722xa031915f43df3c70@mail.gmail.com>
References: <194f62550910271411mf9c7450w9221ac0ed8a3c775@mail.gmail.com>
	<4AE780A2.5040009@sun.com>
	<194f62550910280223q1e5fc2a1y40790910544f90ee@mail.gmail.com>
	<194f62550910300750u1410e722xa031915f43df3c70@mail.gmail.com>
Message-ID: <17c6771e0910300755x3abe74dah2b832d7adef1183f@mail.gmail.com>

2009/10/30 Clemens Eisserer <linuxhippy at gmail.com>:
> Hi again,
>
> I've uploaded a new version, which includes some fixes for the
> problems you mentioned, including one fix from icedtea using static
> initializers for X11SurfaceData. Would be great if you could have
> another look.
>
> http://93.83.133.214/xrender_002.zip
>
> Thanks, Clemens
>

Hi Clemens,

How close is what you have to what we have in IcedTea?  I'm thinking
it might be a good idea to have your XRender work in the IcedTea
forest rather than as patches in IcedTea7.  That would give you a
clean webrev against the latest JDK7 code.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From linuxhippy at gmail.com  Fri Oct 30 08:36:05 2009
From: linuxhippy at gmail.com (Clemens Eisserer)
Date: Fri, 30 Oct 2009 11:36:05 -0400
Subject: [OpenJDK 2D-Dev] Integration of the xrender pipeline rewite
In-Reply-To: <17c6771e0910300755x3abe74dah2b832d7adef1183f@mail.gmail.com>
References: <194f62550910271411mf9c7450w9221ac0ed8a3c775@mail.gmail.com>
	<4AE780A2.5040009@sun.com>
	<194f62550910280223q1e5fc2a1y40790910544f90ee@mail.gmail.com>
	<194f62550910300750u1410e722xa031915f43df3c70@mail.gmail.com>
	<17c6771e0910300755x3abe74dah2b832d7adef1183f@mail.gmail.com>
Message-ID: <194f62550910300836tfae9720g3dcc22aae3d0a696@mail.gmail.com>

Hi Andrew,

> How close is what you have to what we have in IcedTea? ?I'm thinking
> it might be a good idea to have your XRender work in the IcedTea
> forest rather than as patches in IcedTea7. ?That would give you a
> clean webrev against the latest JDK7 code.

Its a complete rewrite and doesn't share much code with what is in IcedTea.
I'll try to update to the lastest JDK7 code from the mercurial repos
later today, after backing that stuff up ;)

- Clemens


From gnu_andrew at member.fsf.org  Fri Oct 30 08:41:53 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Fri, 30 Oct 2009 15:41:53 +0000
Subject: [OpenJDK 2D-Dev] Integration of the xrender pipeline rewite
In-Reply-To: <194f62550910300836tfae9720g3dcc22aae3d0a696@mail.gmail.com>
References: <194f62550910271411mf9c7450w9221ac0ed8a3c775@mail.gmail.com>
	<4AE780A2.5040009@sun.com>
	<194f62550910280223q1e5fc2a1y40790910544f90ee@mail.gmail.com>
	<194f62550910300750u1410e722xa031915f43df3c70@mail.gmail.com>
	<17c6771e0910300755x3abe74dah2b832d7adef1183f@mail.gmail.com>
	<194f62550910300836tfae9720g3dcc22aae3d0a696@mail.gmail.com>
Message-ID: <17c6771e0910300841t3080474dn254430877c0b191e@mail.gmail.com>

2009/10/30 Clemens Eisserer <linuxhippy at gmail.com>:
> Hi Andrew,
>
>> How close is what you have to what we have in IcedTea? ?I'm thinking
>> it might be a good idea to have your XRender work in the IcedTea
>> forest rather than as patches in IcedTea7. ?That would give you a
>> clean webrev against the latest JDK7 code.
>
> Its a complete rewrite and doesn't share much code with what is in IcedTea.
> I'll try to update to the lastest JDK7 code from the mercurial repos
> later today, after backing that stuff up ;)
>
> - Clemens
>

So I should just ditch what we have in IcedTea7 and use this webrev?
I had to reroll all the patches for b74 anyway so get rid of that
maintenance headache would be nice.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From mario.torre at aicas.com  Fri Oct 30 10:42:32 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Fri, 30 Oct 2009 18:42:32 +0100
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4AEAFE2D.1050602@aicas.com>
References: <1244588287.3580.53.camel@localhost.localdomain>		<4ADD6C51.6090600@aicas.com>
	<4ADF7BD0.50202@sun.com>		<4AE84181.1070602@aicas.com>		<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>		<4AE87D7A.2040103@Sun.COM>
	<4AE88C70.7000207@sun.com>		<4AE890C1.70305@Sun.COM>
	<4AE9918A.7050208@aicas.com>		<4AEAFAF3.3080909@aicas.com>	<17c6771e0910300753p7e58a677v5dec0fa76f0237bb@mail.gmail.com>
	<4AEAFE2D.1050602@aicas.com>
Message-ID: <4AEB2588.3020900@aicas.com>

Il 30/10/2009 15:54, Mario Torre ha scritto:
> Il 30/10/2009 15:53, Andrew John Hughes ha scritto:
>
>> http://mail.openjdk.java.net/pipermail/build-dev/2009-October/002447.html
>>
>> Simple solution is to build with ALT_JDK_IMPORT_PATH set to the same
>> as what you set ALT_BOOTDIR to for now. You shouldn't need to, but
>> it's a quicker and simpler solution than patching the build. It
>> should be fixed when b75 is pulled in to the 2d tree.
>
> Good Andrew,
>
> Thanks a lot,
> Mario

Finally ready to push, this would be the Changeset entry:

6896068: SunGraphics2D exposes a reference to itself while non fully 
initialised.
Summary: Introduce a new Interface to mark the Loops based pipes and 
initialise the loops accordingly.
Reviewed-by: flar, rkennke
Contributed-by: Mario Torre <neugens at aicas.com>

Is it OK?

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From Jennifer.Godinez at Sun.COM  Fri Oct 30 10:50:08 2009
From: Jennifer.Godinez at Sun.COM (Jennifer Godinez)
Date: Fri, 30 Oct 2009 10:50:08 -0700
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4AEB2588.3020900@aicas.com>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<4ADD6C51.6090600@aicas.com> <4ADF7BD0.50202@sun.com>
	<4AE84181.1070602@aicas.com>
	<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>
	<4AE87D7A.2040103@Sun.COM> <4AE88C70.7000207@sun.com>
	<4AE890C1.70305@Sun.COM>
	<4AE9918A.7050208@aicas.com> <4AEAFAF3.3080909@aicas.com>
	<17c6771e0910300753p7e58a677v5dec0fa76f0237bb@mail.gmail.com>
	<4AEAFE2D.1050602@aicas.com> <4AEB2588.3020900@aicas.com>
Message-ID: <4AEB2750.9060908@Sun.COM>

Hi Mario,

Since you are pushing the fix yourself, you don't really need the "Contributed-by". This is used for 
someone pushing it for you.

Jennifer

Mario Torre wrote:
> Il 30/10/2009 15:54, Mario Torre ha scritto:
>> Il 30/10/2009 15:53, Andrew John Hughes ha scritto:
>>
>>> http://mail.openjdk.java.net/pipermail/build-dev/2009-October/002447.html 
>>>
>>>
>>> Simple solution is to build with ALT_JDK_IMPORT_PATH set to the same
>>> as what you set ALT_BOOTDIR to for now. You shouldn't need to, but
>>> it's a quicker and simpler solution than patching the build. It
>>> should be fixed when b75 is pulled in to the 2d tree.
>>
>> Good Andrew,
>>
>> Thanks a lot,
>> Mario
> 
> Finally ready to push, this would be the Changeset entry:
> 
> 6896068: SunGraphics2D exposes a reference to itself while non fully 
> initialised.
> Summary: Introduce a new Interface to mark the Loops based pipes and 
> initialise the loops accordingly.
> Reviewed-by: flar, rkennke
> Contributed-by: Mario Torre <neugens at aicas.com>
> 
> Is it OK?
> 
> Cheers,
> Mario


From mario.torre at aicas.com  Fri Oct 30 11:24:30 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Fri, 30 Oct 2009 19:24:30 +0100
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
 exposes a reference to itself while non fully initialised
In-Reply-To: <4AEB2750.9060908@Sun.COM>
References: <1244588287.3580.53.camel@localhost.localdomain>	<4ADD6C51.6090600@aicas.com>
	<4ADF7BD0.50202@sun.com>	<4AE84181.1070602@aicas.com>	<17c6771e0910280818t456d6eeek7ecb8ced71763d5e@mail.gmail.com>	<4AE87D7A.2040103@Sun.COM>
	<4AE88C70.7000207@sun.com>	<4AE890C1.70305@Sun.COM>	<4AE9918A.7050208@aicas.com>
	<4AEAFAF3.3080909@aicas.com>	<17c6771e0910300753p7e58a677v5dec0fa76f0237bb@mail.gmail.com>	<4AEAFE2D.1050602@aicas.com>
	<4AEB2588.3020900@aicas.com> <4AEB2750.9060908@Sun.COM>
Message-ID: <4AEB2F5E.5090102@aicas.com>

Il 30/10/2009 18:50, Jennifer Godinez ha scritto:
> Hi Mario,
>
> Since you are pushing the fix yourself, you don't really need the
> "Contributed-by". This is used for someone pushing it for you.
>
> Jennifer

Hi Jennifer, Jim and all,

Committed!

Thanks for the help, I'll celebrate with some Port wine tonight :)

Cheers!
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From gnu_andrew at member.fsf.org  Fri Oct 30 11:26:09 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Fri, 30 Oct 2009 18:26:09 +0000
Subject: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D
	exposes a reference to itself while non fully initialised
In-Reply-To: <4AEB2F5E.5090102@aicas.com>
References: <1244588287.3580.53.camel@localhost.localdomain>
	<4AE88C70.7000207@sun.com> <4AE890C1.70305@Sun.COM>
	<4AE9918A.7050208@aicas.com> <4AEAFAF3.3080909@aicas.com>
	<17c6771e0910300753p7e58a677v5dec0fa76f0237bb@mail.gmail.com>
	<4AEAFE2D.1050602@aicas.com> <4AEB2588.3020900@aicas.com>
	<4AEB2750.9060908@Sun.COM> <4AEB2F5E.5090102@aicas.com>
Message-ID: <17c6771e0910301126r16193d44sf86fe23c338a8c1b@mail.gmail.com>

2009/10/30 Mario Torre <mario.torre at aicas.com>:
> Il 30/10/2009 18:50, Jennifer Godinez ha scritto:
>>
>> Hi Mario,
>>
>> Since you are pushing the fix yourself, you don't really need the
>> "Contributed-by". This is used for someone pushing it for you.
>>
>> Jennifer
>
> Hi Jennifer, Jim and all,
>
> Committed!
>
> Thanks for the help, I'll celebrate with some Port wine tonight :)
>
> Cheers!
> Mario
> --
> Mario Torre, Software Developer, http://www.jroller.com/neugens/
> aicas Allerton Interworks Computer Automated Systems GmbH
> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
> http://www.aicas.com ? * Tel: +49-721-663 968-44
> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
> Fingerprint: BA39 9666 94EC 8B73 27FA ?FC7C 4086 63E3 80F2 40CF
>
> USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
> Gesch?ftsf?hrer: Dr. James J. Hunt
>
> Please, support open standards:
> http://endsoftpatents.org/
>
>


w00t! http://hg.openjdk.java.net/jdk7/2d/jdk/rev/634221297c37

Congratulations!
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From neugens.limasoftware at gmail.com  Fri Oct 30 11:20:13 2009
From: neugens.limasoftware at gmail.com (neugens.limasoftware at gmail.com)
Date: Fri, 30 Oct 2009 18:20:13 +0000
Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6896068: SunGraphics2D exposes a
	reference to itself	while non fully initialised.
Message-ID: <20091030182039.B56F641919@hg.openjdk.java.net>

Changeset: 634221297c37
Author:    neugens
Date:      2009-10-30 19:19 +0100
URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/634221297c37

6896068: SunGraphics2D exposes a reference to itself while non fully initialised.
Summary: Introduce a new Interface to mark the Loops based pipes and initialise the loops accordingly.
Reviewed-by: flar, rkennke

! src/share/classes/sun/java2d/SunGraphics2D.java
! src/share/classes/sun/java2d/SurfaceData.java
! src/share/classes/sun/java2d/pipe/AATextRenderer.java
! src/share/classes/sun/java2d/pipe/GlyphListLoopPipe.java
+ src/share/classes/sun/java2d/pipe/LoopBasedPipe.java
! src/share/classes/sun/java2d/pipe/LoopPipe.java
! src/share/classes/sun/java2d/pipe/SolidTextRenderer.java
! src/share/classes/sun/java2d/pipe/SpanShapeRenderer.java
! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java
! src/windows/classes/sun/java2d/windows/GDIWindowSurfaceData.java



From linuxhippy at gmail.com  Fri Oct 30 13:34:40 2009
From: linuxhippy at gmail.com (Clemens Eisserer)
Date: Fri, 30 Oct 2009 16:34:40 -0400
Subject: [OpenJDK 2D-Dev] Integration of the xrender pipeline rewite
In-Reply-To: <17c6771e0910300841t3080474dn254430877c0b191e@mail.gmail.com>
References: <194f62550910271411mf9c7450w9221ac0ed8a3c775@mail.gmail.com>
	<4AE780A2.5040009@sun.com>
	<194f62550910280223q1e5fc2a1y40790910544f90ee@mail.gmail.com>
	<194f62550910300750u1410e722xa031915f43df3c70@mail.gmail.com>
	<17c6771e0910300755x3abe74dah2b832d7adef1183f@mail.gmail.com>
	<194f62550910300836tfae9720g3dcc22aae3d0a696@mail.gmail.com>
	<17c6771e0910300841t3080474dn254430877c0b191e@mail.gmail.com>
Message-ID: <194f62550910301334r6a518cecq6ea9fd9b37af973b@mail.gmail.com>

Hi,

Thanks for all your work, integrating and maintaining the pipeline.

> So I should just ditch what we have in IcedTea7 and use this webrev?
> I had to reroll all the patches for b74 anyway so get rid of that
> maintenance headache would be nice.

Yes, in the long run I hope this code will replace what is currently in IcedTea.
However the rewrite has more impact on independent parts (like the
StrikeCache changes), so even with the pipeline disabled it could
break some stuff. Thats why some review would be great...

- Clemens