[OpenJDK 2D-Dev] [PATCH] Request for review: 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode
Phil.Race at Sun.COM
Tue Feb 2 14:12:25 PST 2010
On 2/2/2010 1:40 PM, Roman Kennke wrote:
> Here's the updated fix with testcase (I took the testcase from the
> bugreport and transformed it into a proper jtreg test).
> Is this ok to put back?
> We also need another reviewer, Igor, Dmitri?
> Am Montag, den 30.11.2009, 11:56 -0800 schrieb Phil Race:
>> sorry to sound like a broken record, fix looks fine,
>> regression test needed. In this case I don't think we
>> have one .. I suppose in this and the last case too it
>> could be that adding noreg-jck might be sufficient but
>> a regression test would be better for various reasons.
>> Roman Kennke wrote:
>>> This is a relatively simple fix for 6896335. When I did the change to
>>> GraphicsEnvironment initialization, I missed this small line that's only
>>> executed in headless mode, leading to weird exceptions...
>>> Ok to commit?
More information about the 2d-dev