From Phil.Race at Sun.COM Tue Mar 2 15:49:50 2010 From: Phil.Race at Sun.COM (Phil Race) Date: Tue, 02 Mar 2010 15:49:50 -0800 Subject: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager In-Reply-To: <1267126956.6657.40.camel@moonlight> References: <1267111145.6657.12.camel@moonlight> <4B86CDA4.3060801@sun.com> <1267126956.6657.40.camel@moonlight> Message-ID: <4B8DA41E.80302@sun.com> I am OK too. -phil. On 2/25/2010 11:42 AM, Roman Kennke wrote: > I just realized that there was another use of this field as sync lock, > which I changed to use 'this' too. The lucidaFontName field is used in > one other location (not for syncing) and it surely could use some > cleanup, but I left it alone for now. > > http://cr.openjdk.java.net/~rkennke/6892485/webrev.01/ > > I need at least another review (not sure if Igor needs to say 'go' > again?). > > Thanks, Roman > > Am Donnerstag, den 25.02.2010, 11:21 -0800 schrieb Igor Nekrestyanov: >> i am ok with this fix. >> >> -igor >> >> On 2/25/10 7:19 AM, Roman Kennke wrote: >>> Hi there, >>> >>> this patch fixes the deadlock in FontManager for OpenJDK7 that has been >>> reported repeatedly on this list. I have a testcase here (attached), >>> which I could prepare for jtreg, but it is not totally reliable and >>> depends on the system configuration (which and how many fonts >>> installed), not sure if we want this. >>> >>> The problem is that two threads run into font code, locking on two >>> different locks in wrong order. (Better analysis is in the bug). The fix >>> is to synchronize only on one lock object (the FontManager instance). >>> >>> http://cr.openjdk.java.net/~rkennke/6892485/webrev.00/ >>> >>> Ok to commit? >>> >>> >> > > From roman.kennke at sun.com Wed Mar 3 06:51:26 2010 From: roman.kennke at sun.com (roman.kennke at sun.com) Date: Wed, 03 Mar 2010 14:51:26 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6892485: Deadlock in SunGraphicsEnvironment / FontManager Message-ID: <20100303145218.93B8C43C24@hg.openjdk.java.net> Changeset: 840601ac5ab7 Author: rkennke Date: 2010-03-03 15:50 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/840601ac5ab7 6892485: Deadlock in SunGraphicsEnvironment / FontManager Summary: Synchronize on correct monitor in SunFontManager. Reviewed-by: igor, prr ! src/share/classes/sun/font/SunFontManager.java From Roman.Kennke at Sun.COM Wed Mar 3 07:01:40 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Wed, 03 Mar 2010 16:01:40 +0100 Subject: [OpenJDK 2D-Dev] Request for review/OpenJDK6: 6892485: Deadlock in SunGraphicsEnvironment / FontManager Message-ID: <1267628500.3593.4.camel@moonlight> This is the fix for the deadlock problem in SunGraphicsEnvironment/FontManager backported to OpenJDK6. It is slightly different from the OpenJDK7 version due to the restructured font manager, but the basic idea is the same: instead of sync'ing on 2 different lock objects (with the potential of entering the monitors in the wrong order) we only sync on one (the FontManager class in this case, was the FontManager instance in JDK7). http://cr.openjdk.java.net/~rkennke/6892485/webrev.02/ Ok to push? Also, is there any additional stuff that needs to be done for pushing to OpenJDK6, I never did that and I see that there are not team repositories. When I have 2 ok's, should I push directly to the jdk6/jdk6-gate/jdk repository? Thanks, Roman From Igor.Nekrestyanov at Sun.COM Wed Mar 3 11:33:36 2010 From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov) Date: Wed, 03 Mar 2010 11:33:36 -0800 Subject: [OpenJDK 2D-Dev] Request for review/OpenJDK6: 6892485: Deadlock in SunGraphicsEnvironment / FontManager In-Reply-To: <1267628500.3593.4.camel@moonlight> References: <1267628500.3593.4.camel@moonlight> Message-ID: <4B8EB990.10400@sun.com> Fix is ok with me. Here is the process description for openjdk6 - http://j2se.sfbay/web/bin/view/CoreTech/OpenJDK6 -igor On 3/3/10 7:01 AM, Roman Kennke wrote: > This is the fix for the deadlock problem in > SunGraphicsEnvironment/FontManager backported to OpenJDK6. It is > slightly different from the OpenJDK7 version due to the restructured > font manager, but the basic idea is the same: instead of sync'ing on 2 > different lock objects (with the potential of entering the monitors in > the wrong order) we only sync on one (the FontManager class in this > case, was the FontManager instance in JDK7). > > http://cr.openjdk.java.net/~rkennke/6892485/webrev.02/ > > Ok to push? > > Also, is there any additional stuff that needs to be done for pushing to > OpenJDK6, I never did that and I see that there are not team > repositories. When I have 2 ok's, should I push directly to the > jdk6/jdk6-gate/jdk repository? > > Thanks, Roman > > From yumin.qi at sun.com Mon Mar 8 11:05:50 2010 From: yumin.qi at sun.com (yumin.qi at sun.com) Date: Mon, 08 Mar 2010 19:05:50 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6918065: Crash in Java2D blit loop (IntArgbToIntArgbPreSrcOverMaskBlit) in 64bit mode Message-ID: <20100308190634.6C1954431D@hg.openjdk.java.net> Changeset: 1d7db2d5c4c5 Author: minqi Date: 2010-03-08 11:35 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/1d7db2d5c4c5 6918065: Crash in Java2D blit loop (IntArgbToIntArgbPreSrcOverMaskBlit) in 64bit mode Reviewed-by: igor, bae ! src/share/classes/java/awt/AlphaComposite.java + test/java/awt/AlphaComposite/TestAlphaCompositeForNaN.java From Anthony.Petrov at Sun.COM Thu Mar 11 09:17:40 2010 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Thu, 11 Mar 2010 20:17:40 +0300 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files In-Reply-To: <17c6771e1003100514o490a9abeyba9dffec7f6218da@mail.gmail.com> References: <17c6771e1003100514o490a9abeyba9dffec7f6218da@mail.gmail.com> Message-ID: <4B9925B4.9040702@sun.com> Hi Andrew, I'm CC'ing the 2d-dev mailing list since font-related code is under their maintenance. -- best regards, Anthony On 3/10/2010 4:14 PM Andrew John Hughes wrote: > The current fontconfig property files in OpenJDK: > > jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties > jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties > > are outdated. They pertain to Fedora Core 6 (released October 24th, > 2006 and not supported for several years) and Ubuntu 6.10 (released > October 26th, 2006 and no longer supported since April 25th, 2008). > > The patch included in this webrev: > > http://cr.openjdk.java.net/~andrew/fonts/webrev.01 > http://cr.openjdk.java.net/~andrew/fonts/webrev.01/webrev.zip > > was originally applied to IcedTea on 25-07-2007 and has been updated > in sync with the appropriate distributions, the current version the > result of an update for the next Debian release by Matthias Klose > today. > > Is this ok to push to the awt tree? If so, can I have a bug ID to do so? > > Thanks, From Roman.Kennke at Sun.COM Thu Mar 11 12:53:19 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Thu, 11 Mar 2010 21:53:19 +0100 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files In-Reply-To: <4B9925B4.9040702@sun.com> References: <17c6771e1003100514o490a9abeyba9dffec7f6218da@mail.gmail.com> <4B9925B4.9040702@sun.com> Message-ID: <1268340799.4621.16.camel@moonlight> > > The current fontconfig property files in OpenJDK: > > > > jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties > > jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties > > > > are outdated. They pertain to Fedora Core 6 (released October 24th, > > 2006 and not supported for several years) and Ubuntu 6.10 (released > > October 26th, 2006 and no longer supported since April 25th, 2008). Are they actually still used? I was under the impression that fontconfig is used to get the correct font locations. /Roman From ahughes at redhat.com Thu Mar 11 12:55:16 2010 From: ahughes at redhat.com (Andrew John Hughes) Date: Thu, 11 Mar 2010 20:55:16 +0000 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files In-Reply-To: <1268340799.4621.16.camel@moonlight> References: <17c6771e1003100514o490a9abeyba9dffec7f6218da@mail.gmail.com> <4B9925B4.9040702@sun.com> <1268340799.4621.16.camel@moonlight> Message-ID: <17c6771e1003111255k7db1a9d6n79288f49d64efe53@mail.gmail.com> On 11 March 2010 20:53, Roman Kennke wrote: >> > The current fontconfig property files in OpenJDK: >> > >> > jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties >> > jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties >> > >> > are outdated. ?They pertain to Fedora Core 6 (released October 24th, >> > 2006 and not supported for several years) and Ubuntu 6.10 (released >> > October 26th, 2006 and no longer supported since April 25th, 2008). > > Are they actually still used? I was under the impression that fontconfig > is used to get the correct font locations. > doko updated them this week so I assume they still make some difference. doko? > /Roman > > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Phil.Race at Sun.COM Thu Mar 11 13:16:45 2010 From: Phil.Race at Sun.COM (Phil Race) Date: Thu, 11 Mar 2010 13:16:45 -0800 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files In-Reply-To: <17c6771e1003111255k7db1a9d6n79288f49d64efe53@mail.gmail.com> References: <17c6771e1003100514o490a9abeyba9dffec7f6218da@mail.gmail.com> <4B9925B4.9040702@sun.com> <1268340799.4621.16.camel@moonlight> <17c6771e1003111255k7db1a9d6n79288f49d64efe53@mail.gmail.com> Message-ID: <4B995DBD.3030408@sun.com> The changes look OK to me. Since we aren't using X11 to render these fonts there's no need to add mappings to the appropriate NIO encoders for those new language/script symbols. The fontconfig code is a JDK 7 feature and this is a JDK 6 change I believe. Also note that there's nothing wrong (even in JDK7) with providing a fontconfig file that's just right for your distro.. the fontconfig code is motivated more by the fact that the JDKs that are separate from a distro need some way to keep up with these sorts of changes. I think these files being updated were ones I hacked together in maybe 2007 to support what distros were current at the time we open sourced JDK. Its not required that they be what a distro actually uses. FWIW historically in JDK rather than just "update" the file, we append the specific version it was targeted at to the name, and make the new updated one the default for everything else. You might want to consider doing that here although if those distros are so far past EOSL it likely doesn't matter in this case. Solaris by contrast is supported for a long, long time. -phil. Andrew John Hughes wrote: > On 11 March 2010 20:53, Roman Kennke wrote: > >>>> The current fontconfig property files in OpenJDK: >>>> >>>> jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties >>>> jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties >>>> >>>> are outdated. They pertain to Fedora Core 6 (released October 24th, >>>> 2006 and not supported for several years) and Ubuntu 6.10 (released >>>> October 26th, 2006 and no longer supported since April 25th, 2008). >>>> >> Are they actually still used? I was under the impression that fontconfig >> is used to get the correct font locations. >> >> > > doko updated them this week so I assume they still make some difference. doko? > > >> /Roman >> >> >> >> > > > > From ahughes at redhat.com Thu Mar 11 14:44:43 2010 From: ahughes at redhat.com (Andrew John Hughes) Date: Thu, 11 Mar 2010 22:44:43 +0000 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files In-Reply-To: <4B995DBD.3030408@sun.com> References: <17c6771e1003100514o490a9abeyba9dffec7f6218da@mail.gmail.com> <4B9925B4.9040702@sun.com> <1268340799.4621.16.camel@moonlight> <17c6771e1003111255k7db1a9d6n79288f49d64efe53@mail.gmail.com> <4B995DBD.3030408@sun.com> Message-ID: <17c6771e1003111444m760ba483q75e8d81c76540576@mail.gmail.com> On 11 March 2010 21:16, Phil Race wrote: > The changes look OK to me. Since we aren't using X11 to render > these fonts there's no need to add mappings to the appropriate NIO encoders > for those new language/script symbols. > > The fontconfig code is a JDK 7 feature and this is a JDK 6 change I believe. It is, though I didn't know about the fontconfig code so was assuming it needed to go in 7 first and then be backported. Indeed, the posted webrev was against the AWT JDK7 tree where they still exist. > Also note that there's nothing wrong (even in JDK7) with providing a > fontconfig file that's just right for your distro.. the fontconfig code is > motivated more by the fact that the JDKs that are separate from a distro > need some way to keep up with these sorts of changes. That does make sense. Not all of us are on Fedora or Ubuntu. > I think these files being updated were ones I hacked together in maybe 2007 > to support what distros were current at the time we open sourced JDK. > Its not required that they be what a distro actually uses. > FWIW historically in JDK rather than just "update" the file, we append > the specific version it was targeted at to the name, and make the new > updated one the default for everything else. You might want to consider > doing that here although if those distros are so far past EOSL it likely > doesn't matter in this case. Solaris by contrast is supported for a long, > long time. > I agree it doesn't matter for these. There wasn't even an OpenJDK/IcedTea package until Fedora 8 in any case. These files have been patched pretty much from the start and then updated intermittently. Can I have a bug ID to push this? I assume, given the list redirection, it wants to be in the 2d forest. Joe, is this also ok for 6? > -phil. > > Andrew John Hughes wrote: >> >> On 11 March 2010 20:53, Roman Kennke wrote: >> >>>>> >>>>> The current fontconfig property files in OpenJDK: >>>>> >>>>> >>>>> jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties >>>>> >>>>> jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties >>>>> >>>>> are outdated. ?They pertain to Fedora Core 6 (released October 24th, >>>>> 2006 and not supported for several years) and Ubuntu 6.10 (released >>>>> October 26th, 2006 and no longer supported since April 25th, 2008). >>>>> >>> >>> Are they actually still used? I was under the impression that fontconfig >>> is used to get the correct font locations. >>> >>> >> >> doko updated them this week so I assume they still make some difference. >> ?doko? >> >> >>> >>> /Roman >>> >>> >>> >>> >> >> >> >> > > Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Phil.Race at Sun.COM Thu Mar 11 16:47:32 2010 From: Phil.Race at Sun.COM (Phil Race) Date: Thu, 11 Mar 2010 16:47:32 -0800 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files In-Reply-To: <17c6771e1003111444m760ba483q75e8d81c76540576@mail.gmail.com> References: <17c6771e1003100514o490a9abeyba9dffec7f6218da@mail.gmail.com> <4B9925B4.9040702@sun.com> <1268340799.4621.16.camel@moonlight> <17c6771e1003111255k7db1a9d6n79288f49d64efe53@mail.gmail.com> <4B995DBD.3030408@sun.com> <17c6771e1003111444m760ba483q75e8d81c76540576@mail.gmail.com> Message-ID: <4B998F24.6090705@sun.com> Andrew John Hughes wrote: > > . > > Can I have a bug ID to push this? I assume, given the list > redirection, it wants to be in the 2d forest. Joe, is this also ok > for 6? > > Bug ID is 6934327: Update linux fontconfigs for Ubuntu and Fedora. I am sure this is fine for 6 too .. -phil. From Joe.Darcy at Sun.COM Thu Mar 11 17:08:24 2010 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Thu, 11 Mar 2010 17:08:24 -0800 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files In-Reply-To: <4B998F24.6090705@sun.com> References: <17c6771e1003100514o490a9abeyba9dffec7f6218da@mail.gmail.com> <4B9925B4.9040702@sun.com> <1268340799.4621.16.camel@moonlight> <17c6771e1003111255k7db1a9d6n79288f49d64efe53@mail.gmail.com> <4B995DBD.3030408@sun.com> <17c6771e1003111444m760ba483q75e8d81c76540576@mail.gmail.com> <4B998F24.6090705@sun.com> Message-ID: <4B999408.2040600@sun.com> Phil Race wrote: > Andrew John Hughes wrote: >> >> . >> >> Can I have a bug ID to push this? I assume, given the list >> redirection, it wants to be in the 2d forest. Joe, is this also ok >> for 6? >> >> > Bug ID is 6934327: Update linux fontconfigs for Ubuntu and Fedora. > > I am sure this is fine for 6 too .. Given Phil's review, I'm happy to have this change in OpenJDK 6. Thanks, -Joe From ahughes at redhat.com Thu Mar 11 17:09:41 2010 From: ahughes at redhat.com (ahughes at redhat.com) Date: Fri, 12 Mar 2010 01:09:41 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6934327: Update linux fontconfigs for Ubuntu and Fedora. Message-ID: <20100312011019.7B144447B7@hg.openjdk.java.net> Changeset: d23dcd3e3ce4 Author: andrew Date: 2010-03-12 01:09 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d23dcd3e3ce4 6934327: Update linux fontconfigs for Ubuntu and Fedora. Summary: Use fontconfigs suitable for recent Fedora, Ubuntu and Debian releases. Reviewed-by: prr ! src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties ! src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties From ahughes at redhat.com Thu Mar 11 17:38:34 2010 From: ahughes at redhat.com (Andrew John Hughes) Date: Fri, 12 Mar 2010 01:38:34 +0000 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files In-Reply-To: <4B999408.2040600@sun.com> References: <17c6771e1003100514o490a9abeyba9dffec7f6218da@mail.gmail.com> <4B9925B4.9040702@sun.com> <1268340799.4621.16.camel@moonlight> <17c6771e1003111255k7db1a9d6n79288f49d64efe53@mail.gmail.com> <4B995DBD.3030408@sun.com> <17c6771e1003111444m760ba483q75e8d81c76540576@mail.gmail.com> <4B998F24.6090705@sun.com> <4B999408.2040600@sun.com> Message-ID: <17c6771e1003111738n2ab2cad1ycdf32b515975b923@mail.gmail.com> On 12 March 2010 01:08, Joe Darcy wrote: > Phil Race wrote: >> >> Andrew John Hughes wrote: >>> >>> . >>> >>> Can I have a bug ID to push this? I assume, given the list >>> redirection, it wants to be in the 2d forest. ?Joe, is this also ok >>> for 6? >>> >>> >> >> Bug ID is 6934327: Update linux fontconfigs for Ubuntu and Fedora. >> >> I am sure this is fine for 6 too .. > > Given Phil's review, I'm happy to have this change in OpenJDK 6. > > Thanks, > > -Joe > Both done: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d23dcd3e3ce4 http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/178f954e1fd1 -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From lana.steuck at sun.com Fri Mar 19 22:46:50 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Mar 2010 05:46:50 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d: 5 new changesets Message-ID: <20100320054651.8976244351@hg.openjdk.java.net> Changeset: 3ddf90b39176 Author: mikejwre Date: 2010-03-04 13:50 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/3ddf90b39176 Added tag jdk7-b85 for changeset cf26288a114b ! .hgtags Changeset: 4d7419e4b759 Author: ohair Date: 2010-03-06 15:00 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/4d7419e4b759 6928700: Configure top repo for JPRT testing Reviewed-by: alanb, jjg ! make/jprt.properties + test/Makefile Changeset: f3664d6879ab Author: ohair Date: 2010-03-06 15:01 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/f3664d6879ab Merge Changeset: 433a60a9c0bf Author: lana Date: 2010-03-09 15:28 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/433a60a9c0bf Merge Changeset: 6b1069f53fbc Author: mikejwre Date: 2010-03-18 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/rev/6b1069f53fbc Added tag jdk7-b86 for changeset 433a60a9c0bf ! .hgtags From lana.steuck at sun.com Fri Mar 19 22:46:58 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Mar 2010 05:46:58 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/corba: 2 new changesets Message-ID: <20100320054704.EE12344352@hg.openjdk.java.net> Changeset: 6253e28826d1 Author: mikejwre Date: 2010-03-04 13:50 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/6253e28826d1 Added tag jdk7-b85 for changeset c67a9df7bc0c ! .hgtags Changeset: 09a41111a401 Author: mikejwre Date: 2010-03-18 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/09a41111a401 Added tag jdk7-b86 for changeset 6253e28826d1 ! .hgtags From lana.steuck at sun.com Fri Mar 19 22:51:45 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Mar 2010 05:51:45 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/hotspot: 29 new changesets Message-ID: <20100320055320.C2F1744354@hg.openjdk.java.net> Changeset: 745c853ee57f Author: johnc Date: 2010-01-29 14:51 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/745c853ee57f 6885297: java -XX:RefDiscoveryPolicy=2 or -XX:TLABWasteTargetPercent=0 cause VM crash Summary: Interval checking is now being performed on the values passed in for these two flags. The current acceptable range for RefDiscoveryPolicy is [0..1], and for TLABWasteTargetPercent it is [1..100]. Reviewed-by: apetrusenko, ysr ! src/share/vm/includeDB_core ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 6484c4ee11cb Author: ysr Date: 2010-02-01 17:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/6484c4ee11cb 6904516: More object array barrier fixes, following up on 6906727 Summary: Fixed missing pre-barrier calls for G1, modified C1 to call pre- and correct post-barrier interfaces, deleted obsolete interface, (temporarily) disabled redundant deferred barrier in BacktraceBuilder. Reviewed-by: coleenp, jmasa, kvn, never ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/memory/barrierSet.inline.hpp ! src/share/vm/runtime/stubRoutines.cpp Changeset: deada8912c54 Author: johnc Date: 2010-02-02 18:39 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/deada8912c54 6914402: G1: assert(!is_young_card(cached_ptr),"shouldn't get a card in young region") Summary: Invalid assert. Filter cards evicted from the card count cache instead. Reviewed-by: apetrusenko, tonyp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp Changeset: 230fac611b50 Author: johnc Date: 2010-02-08 09:58 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/230fac611b50 Merge ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/includeDB_core Changeset: 455df1b81409 Author: kamg Date: 2010-02-08 13:49 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/455df1b81409 6587322: dtrace probe object__alloc doesn't fire in some situations on amd64 Summary: Fix misplaced probe point Reviewed-by: rasbold, phh Contributed-by: neojia at gmail.com ! src/cpu/x86/vm/templateTable_x86_64.cpp Changeset: 95d21201c29a Author: apangin Date: 2010-02-11 10:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/95d21201c29a Merge Changeset: 3f5b7efb9642 Author: never Date: 2010-02-05 11:07 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3f5b7efb9642 6920293: OptimizeStringConcat causing core dumps Reviewed-by: kvn, twisti ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 576e77447e3c Author: kvn Date: 2010-02-07 12:15 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/576e77447e3c 6923002: assert(false,"this call site should not be polymorphic") Summary: Clear the total count when a receiver information is cleared. Reviewed-by: never, jrose ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/arguments.cpp Changeset: f516d5d7a019 Author: kvn Date: 2010-02-08 12:20 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f516d5d7a019 6910605: C2: NullPointerException/ClassCaseException is thrown when C2 with DeoptimizeALot is used Summary: Set the reexecute bit for runtime calls _new_array_Java when they used for _multianewarray bytecode. Reviewed-by: never ! src/share/vm/code/pcDesc.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/parse3.cpp + test/compiler/6910605/Test.java Changeset: f70b0d9ab095 Author: kvn Date: 2010-02-09 01:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f70b0d9ab095 6910618: C2: Error: assert(d->is_oop(),"JVM_ArrayCopy: dst not an oop") Summary: Mark in PcDesc call sites which return oop and save the result oop across objects reallocation during deoptimization. Reviewed-by: never ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/code/debugInfoRec.cpp ! src/share/vm/code/debugInfoRec.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/pcDesc.hpp ! src/share/vm/code/scopeDesc.cpp ! src/share/vm/code/scopeDesc.hpp ! src/share/vm/includeDB_core ! src/share/vm/opto/output.cpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/runtime/deoptimization.cpp + test/compiler/6910618/Test.java Changeset: 4ee1c645110e Author: kvn Date: 2010-02-09 10:21 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/4ee1c645110e 6924097: assert((_type == Type::MEMORY) == (_adr_type != 0),"adr_type for memory phis only") Summary: Use PhiNode::make_blank(r, n) method to construct the phi. Reviewed-by: never ! src/share/vm/opto/loopopts.cpp Changeset: e3a4305c6bc3 Author: kvn Date: 2010-02-12 08:54 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/e3a4305c6bc3 6925249: assert(last_sp < (intptr_t*) interpreter_frame_monitor_begin(),"bad tos") Summary: Fix assert since top deoptimized frame has last_sp == interpreter_frame_monitor_begin if there are no expressions. Reviewed-by: twisti ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/vframeArray.cpp Changeset: c09ee209b65c Author: kvn Date: 2010-02-12 10:34 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c09ee209b65c 6926048: Improve Zero performance Summary: Make Zero figure out result types in a similar way to C++ interpreter implementation. Reviewed-by: kvn Contributed-by: gbenson at redhat.com ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/cppInterpreter_zero.hpp Changeset: 7b4415a18c8a Author: kvn Date: 2010-02-12 15:27 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/7b4415a18c8a Merge ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/includeDB_core ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 38836cf1d8d2 Author: tonyp Date: 2010-02-05 11:05 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/38836cf1d8d2 6920977: G1: guarantee(k == probe->klass(),"klass should be in dictionary") fails Summary: the guarantee is too strict and the test will fail (incorrectly) if the class is not in the system dictionary but in the placeholders. Reviewed-by: acorn, phh ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/loaderConstraints.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/includeDB_core Changeset: 9eee977dd1a9 Author: tonyp Date: 2010-02-08 14:23 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/9eee977dd1a9 6802453: G1: hr()->is_in_reserved(from),"Precondition." Summary: The operations of re-using a RSet component and expanding the same RSet component were not mutually exlusive, and this could lead to RSets getting corrupted and entries being dropped. Reviewed-by: iveresov, johnc ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp Changeset: 8859772195c6 Author: johnc Date: 2010-02-09 13:56 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/8859772195c6 6782663: Data produced by PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime is not accurate. Summary: Update and display the timers associated with these flags for all safepoints. Reviewed-by: ysr, jcoomes ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/services/runtimeService.cpp Changeset: 0414c1049f15 Author: iveresov Date: 2010-02-11 15:52 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0414c1049f15 6923991: G1: improve scalability of RSet scanning Summary: Implemented block-based work stealing. Moved copying during the rset scanning phase to the main copying phase. Made the size of rset table depend on the region size. Reviewed-by: apetrusenko, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 58add740c4ee Author: johnc Date: 2010-02-16 14:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/58add740c4ee Merge ! src/share/vm/includeDB_core Changeset: e7b1cc79bd25 Author: kvn Date: 2010-02-16 16:17 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/e7b1cc79bd25 6926697: "optimized" VM build failed: The type "AdapterHandlerTableIterator" is incomplete Summary: Define AdapterHandlerTableIterator class as non product instead of debug. Reviewed-by: never ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 106f41e88c85 Author: never Date: 2010-02-16 20:07 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/106f41e88c85 6877221: Endless deoptimizations in OSR nmethod Reviewed-by: kvn ! src/share/vm/opto/parse1.cpp Changeset: b4b440360f1e Author: twisti Date: 2010-02-18 11:35 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/b4b440360f1e 6926782: CodeBuffer size too small after 6921352 Summary: After 6921352 the CodeBuffer size was too small. Reviewed-by: kvn, never ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/output.cpp Changeset: 3b687c53c266 Author: twisti Date: 2010-02-18 06:54 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3b687c53c266 6927165: Zero S/390 fixes Summary: Fixes two failures on 31-bit S/390. Reviewed-by: twisti Contributed-by: Gary Benson ! src/cpu/zero/vm/globals_zero.hpp ! src/os_cpu/linux_zero/vm/os_linux_zero.hpp Changeset: 72f1840531a4 Author: twisti Date: 2010-02-18 10:44 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/72f1840531a4 Merge Changeset: 1f341bb67b5b Author: trims Date: 2010-02-18 22:15 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/1f341bb67b5b Merge Changeset: 6c9796468b91 Author: trims Date: 2010-02-18 22:16 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/6c9796468b91 6927886: Bump the HS17 build number to 10 Summary: Update the HS17 build number to 10 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 418bc80ce139 Author: mikejwre Date: 2010-03-04 13:50 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/418bc80ce139 Added tag jdk7-b85 for changeset 6c9796468b91 ! .hgtags Changeset: bf823ef06b4f Author: trims Date: 2010-03-08 15:50 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/bf823ef06b4f Added tag hs17-b10 for changeset 418bc80ce139 ! .hgtags Changeset: 4b58861a3570 Author: mikejwre Date: 2010-03-18 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/4b58861a3570 Added tag jdk7-b86 for changeset bf823ef06b4f ! .hgtags From lana.steuck at sun.com Fri Mar 19 22:57:06 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Mar 2010 05:57:06 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxp: 2 new changesets Message-ID: <20100320055706.D4A1944356@hg.openjdk.java.net> Changeset: 81c0f115bbe5 Author: mikejwre Date: 2010-03-04 13:50 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/81c0f115bbe5 Added tag jdk7-b85 for changeset 6c0ccabb430d ! .hgtags Changeset: 8b493f1aa136 Author: mikejwre Date: 2010-03-18 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/8b493f1aa136 Added tag jdk7-b86 for changeset 81c0f115bbe5 ! .hgtags From lana.steuck at sun.com Fri Mar 19 22:57:13 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Mar 2010 05:57:13 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxws: 2 new changesets Message-ID: <20100320055713.81ACE44357@hg.openjdk.java.net> Changeset: 512b0e924a5a Author: mikejwre Date: 2010-03-04 13:50 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/512b0e924a5a Added tag jdk7-b85 for changeset 8424512588ff ! .hgtags Changeset: 3febd6fab2ac Author: mikejwre Date: 2010-03-18 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/3febd6fab2ac Added tag jdk7-b86 for changeset 512b0e924a5a ! .hgtags From lana.steuck at sun.com Fri Mar 19 22:58:57 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Mar 2010 05:58:57 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 52 new changesets Message-ID: <20100320061551.CA37D4435D@hg.openjdk.java.net> Changeset: 2ba381560071 Author: dcherepanov Date: 2010-02-12 19:58 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2ba381560071 6705345: Enable multiple file selection in AWT FileDialog Reviewed-by: art, anthony, alexp ! src/share/classes/java/awt/FileDialog.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/native/sun/windows/awt_FileDialog.cpp ! src/windows/native/sun/windows/awt_FileDialog.h + test/java/awt/FileDialog/MultipleMode/MultipleMode.html + test/java/awt/FileDialog/MultipleMode/MultipleMode.java Changeset: d6d2de6ee2d1 Author: lana Date: 2010-02-19 15:13 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d6d2de6ee2d1 Merge Changeset: 83c34a6b1458 Author: mchung Date: 2010-02-08 23:02 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/83c34a6b1458 6924497: HotSpotDiagnosticsMXBean.getDiagnosticOptions throws NPE Summary: Check if the element in the flags array is non-null to filter unsupported flags Reviewed-by: dcubed ! src/share/classes/sun/management/Flag.java ! src/share/native/sun/management/Flag.c Changeset: ec438f2b6886 Author: chegar Date: 2010-02-10 13:23 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/ec438f2b6886 6693244: Java Web Start app fails on 6u10 beta w/ AssertionError in AuthenticationInfo.requestCompleted Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java ! test/ProblemList.txt ! test/java/net/Authenticator/B4769350.java Changeset: 784e52734b8d Author: mchung Date: 2010-02-10 17:51 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/784e52734b8d 6915413: Module build: building of specified jdk components instead of all Summary: Define new SUBDIRS_* variables for specifying components for one group Reviewed-by: ohair ! make/Makefile ! make/com/Makefile ! make/com/sun/Makefile ! make/com/sun/demo/Makefile ! make/com/sun/demo/jvmti/Makefile ! make/com/sun/inputmethods/Makefile ! make/com/sun/java/Makefile ! make/com/sun/java/browser/Makefile ! make/com/sun/jmx/Makefile ! make/com/sun/jndi/Makefile ! make/com/sun/jndi/rmi/Makefile ! make/com/sun/nio/Makefile ! make/com/sun/org/Makefile ! make/com/sun/org/apache/Makefile ! make/com/sun/security/Makefile ! make/com/sun/tools/Makefile ! make/com/sun/tracing/Makefile ! make/common/Defs.gmk ! make/common/Sanity.gmk + make/common/Subdirs.gmk ! make/common/shared/Sanity.gmk ! make/java/Makefile ! make/java/hpi/Makefile ! make/java/java/Makefile ! make/java/java/genlocales.gmk ! make/java/main/Makefile ! make/java/nio/FILES_java.gmk ! make/java/nio/Makefile + make/java/nio/mxbean/Makefile ! make/java/redist/Makefile - make/java/text/FILES_java.gmk ! make/java/text/Makefile + make/java/text/base/FILES_java.gmk + make/java/text/base/Makefile + make/java/text/bidi/Makefile ! make/javax/Makefile ! make/javax/rmi/Makefile ! make/javax/sound/Makefile ! make/javax/swing/Makefile ! make/jpda/Makefile ! make/jpda/transport/Makefile ! make/mkdemo/Makefile ! make/mkdemo/applets/Makefile ! make/mkdemo/jfc/Makefile ! make/mkdemo/jni/Makefile ! make/mkdemo/jvmti/Makefile ! make/mkdemo/management/Makefile ! make/mkdemo/scripting/Makefile ! make/mksample/Makefile ! make/mksample/jmx/Makefile ! make/mksample/nio/Makefile ! make/mksample/scripting/Makefile ! make/mksample/webservices/Makefile ! make/org/Makefile ! make/org/ietf/Makefile ! make/sun/Makefile ! make/sun/cmm/Makefile ! make/sun/image/Makefile ! make/sun/management/Makefile ! make/sun/net/Makefile ! make/sun/net/spi/Makefile ! make/sun/net/spi/nameservice/Makefile ! make/sun/nio/Makefile ! make/sun/org/Makefile ! make/sun/org/mozilla/Makefile ! make/sun/rmi/Makefile ! make/sun/security/Makefile ! make/sun/tracing/Makefile ! make/tools/Makefile Changeset: d7d8807fca86 Author: weijun Date: 2010-02-12 10:24 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d7d8807fca86 6925639: keytool -genkeypair -help missing dname option Reviewed-by: mullan ! src/share/classes/sun/security/tools/KeyTool.java Changeset: 74f493fae483 Author: mchung Date: 2010-02-12 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/74f493fae483 6925868: Eliminate pack200's dependency on logging Summary: Replace j.u.l.Logger with sun.util.logging.PlatformLogger Reviewed-by: alanb, forax ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java Changeset: 328c5d3974fe Author: mchung Date: 2010-02-15 10:18 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/328c5d3974fe Merge Changeset: 84792500750c Author: lana Date: 2010-02-17 10:24 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/84792500750c Merge Changeset: e83d9c0d5e95 Author: chegar Date: 2010-02-22 15:27 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e83d9c0d5e95 6912868: "java.net.useSystemProxies" behavior fails to check "use_same_proxy" in GNOME Reviewed-by: alanb, chegar Contributed-by: damjan.jov at gmail.com ! src/solaris/native/sun/net/spi/DefaultProxySelector.c + test/java/net/ProxySelector/SystemProxies.java Changeset: c96d6cb31723 Author: chegar Date: 2010-02-23 17:08 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c96d6cb31723 6365587: Proxy-Connection header sent through tunnel Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: b396584a3e64 Author: lana Date: 2010-02-23 10:17 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b396584a3e64 Merge - make/java/text/FILES_java.gmk Changeset: 03cd9e62961f Author: mikejwre Date: 2010-03-04 13:50 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/03cd9e62961f Added tag jdk7-b85 for changeset b396584a3e64 ! .hgtags Changeset: 494f5e4f24da Author: lana Date: 2010-03-09 15:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/494f5e4f24da Merge Changeset: e64331144648 Author: rupashka Date: 2010-02-10 15:15 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e64331144648 6848475: JSlider does not display the correct value of its BoundedRangeModel Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java + test/javax/swing/JSlider/6848475/bug6848475.java Changeset: f81c8041ccf4 Author: peytoia Date: 2010-02-11 15:58 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f81c8041ccf4 6909002: Remove indicim.jar and thaiim.jar from JRE and move to samples if needed Reviewed-by: okutsu ! make/com/sun/Makefile Changeset: e2b58a45a426 Author: peytoia Date: 2010-02-12 14:38 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e2b58a45a426 6921289: (tz) Support tzdata2010b Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: e8340332745e Author: malenkov Date: 2010-02-18 17:46 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e8340332745e 4498236: RFE: Provide a toString method for PropertyChangeEvent and other classes Reviewed-by: peterz ! src/share/classes/java/beans/BeanDescriptor.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/FeatureDescriptor.java ! src/share/classes/java/beans/IndexedPropertyChangeEvent.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/PropertyChangeEvent.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/Test4498236.java Changeset: 5c03237838e1 Author: rupashka Date: 2010-02-27 14:26 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5c03237838e1 6913758: Specification for SynthViewportUI.paintBorder(...) should mention that this method is never called Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/synth/SynthViewportUI.java Changeset: 96205ed1b196 Author: rupashka Date: 2010-02-27 14:47 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/96205ed1b196 6918447: SynthToolBarUI.setBorderToXXXX() methods don't correspond inherited spec. They do nothing. Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java Changeset: 621e921a14cd Author: rupashka Date: 2010-02-27 15:09 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/621e921a14cd 6918861: SynthSliderUI.uninstallDefaults() is not called when UI is uninstalled Reviewed-by: malenkov ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java + test/javax/swing/JSlider/6918861/bug6918861.java Changeset: 28741de0bb4a Author: rupashka Date: 2010-02-27 16:03 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/28741de0bb4a 6923305: SynthSliderUI paints the slider track when the slider's "paintTrack" property is set to false Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java + test/javax/swing/JSlider/6923305/bug6923305.java Changeset: 2bf137beb9bd Author: rupashka Date: 2010-02-27 16:14 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2bf137beb9bd 6929298: The SynthSliderUI#calculateTickRect method should be removed Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java Changeset: d6b3a07c8752 Author: rupashka Date: 2010-03-03 17:57 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d6b3a07c8752 6924059: SynthScrollBarUI.configureScrollBarColors() should have spec different from the overridden method Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java + test/javax/swing/JScrollBar/6924059/bug6924059.java Changeset: 30c520bd148f Author: rupashka Date: 2010-03-03 20:08 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/30c520bd148f 6913768: With default SynthLookAndFeel instance installed new JTable creation leads to throwing NPE Reviewed-by: peterz ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/plaf/synth/SynthTableUI.java + test/javax/swing/JTable/6913768/bug6913768.java Changeset: f13fc955be62 Author: rupashka Date: 2010-03-03 20:53 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f13fc955be62 6917744: JScrollPane Page Up/Down keys do not handle correctly html tables with different cells contents Reviewed-by: peterz, alexp ! src/share/classes/javax/swing/text/DefaultEditorKit.java + test/javax/swing/JEditorPane/6917744/bug6917744.java + test/javax/swing/JEditorPane/6917744/test.html Changeset: 0622086d82ac Author: malenkov Date: 2010-03-04 21:17 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0622086d82ac 6921644: XMLEncoder generates invalid XML Reviewed-by: peterz ! src/share/classes/java/beans/XMLEncoder.java + test/java/beans/XMLEncoder/Test5023550.java + test/java/beans/XMLEncoder/Test5023557.java + test/java/beans/XMLEncoder/Test6921644.java Changeset: 79a509ac8f35 Author: lana Date: 2010-03-01 18:30 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/79a509ac8f35 Merge ! make/com/sun/Makefile - make/java/text/FILES_java.gmk Changeset: 90248595ec35 Author: lana Date: 2010-03-04 13:07 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/90248595ec35 Merge Changeset: 2fe4e72288ce Author: lana Date: 2010-03-09 15:28 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2fe4e72288ce Merge Changeset: 38fbb2353a6a Author: alanb Date: 2010-02-23 17:56 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/38fbb2353a6a 6925977: (file) test/java/nio/file/Path/CheckPermissions.java fails if test.src on read-only file system Reviewed-by: chegar ! test/java/nio/file/Path/CheckPermissions.java Changeset: 00abf8c232be Author: alanb Date: 2010-02-23 17:58 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/00abf8c232be 6925932: (file) Path.endsWith can throw ArrayIndexOutOfBoundsException (unx) Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/UnixPath.java ! test/java/nio/file/Path/PathOps.java Changeset: be5db597f3be Author: alanb Date: 2010-02-23 18:19 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/be5db597f3be 6928960: make modules fails to build class analyzer Reviewed-by: mchung ! make/modules/tools/Makefile Changeset: e94b296b53b4 Author: alanb Date: 2010-02-23 18:21 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e94b296b53b4 6926800: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with newer versions of find(1) Reviewed-by: forax ! test/java/nio/file/Files/PrintFileTree.java ! test/java/nio/file/Files/walk_file_tree.sh Changeset: e842e99b514a Author: darcy Date: 2010-02-24 10:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e842e99b514a 6929382: Various core classes in util and elsewhere are missing @param tags Reviewed-by: dholmes, martin ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Iterator.java ! src/share/classes/java/util/List.java Changeset: 9929203a8b98 Author: xuelei Date: 2010-02-25 13:32 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9929203a8b98 6916202: More cases of invalid ldap filters accepted and processed Reviewed-by: vinnie, weijun ! src/share/classes/com/sun/jndi/ldap/Filter.java + test/com/sun/jndi/ldap/InvalidLdapFilters.java Changeset: 77beb60b39c6 Author: alanb Date: 2010-02-27 18:18 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/77beb60b39c6 6929532: (file) WatchService should avoid queuing new modify events when lots of files are changing Reviewed-by: alanb Contributed-by: sebastian.sickelmann at gmx.de ! src/share/classes/sun/nio/fs/AbstractWatchKey.java + test/java/nio/file/WatchService/LotsOfEvents.java - test/java/nio/file/WatchService/OverflowEventIsLoner.java Changeset: b77e94f5a601 Author: alanb Date: 2010-02-27 19:15 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b77e94f5a601 6929259: Remove double spaces from Dual-pivot quicksort Reviewed-by: alanb Contributed-by: vladimir.yaroslavskiy at sun.com ! src/share/classes/java/util/DualPivotQuicksort.java Changeset: 529d2da0aee2 Author: alanb Date: 2010-02-27 19:26 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/529d2da0aee2 6815768: File.getxxxSpace() methods fail for very large file systems under 32bit Java Reviewed-by: ohair ! src/solaris/native/java/io/UnixFileSystem_md.c Changeset: f7a6eae6e1eb Author: alanb Date: 2010-02-27 19:29 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f7a6eae6e1eb 6921374: java.lang.String::hashCode() should check for count == 0 to avoid repeated stores hash = 0 Reviewed-by: darcy, ohair ! src/share/classes/java/lang/String.java Changeset: 78d91c4223cb Author: vinnie Date: 2010-03-01 17:54 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/78d91c4223cb 6921001: api/java_security/IdentityScope/IdentityScopeTests.html#getSystemScope fails starting from b78 JDK7 Reviewed-by: mullan ! src/share/classes/java/security/IdentityScope.java ! src/share/lib/security/java.security + test/java/security/IdentityScope/NoDefaultSystemScope.java Changeset: 893034df4ec2 Author: vinnie Date: 2010-03-01 18:00 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/893034df4ec2 Merge - test/java/nio/file/WatchService/OverflowEventIsLoner.java Changeset: cddb43b12d28 Author: alanb Date: 2010-03-03 16:09 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/cddb43b12d28 6931216: TEST_BUG: test/java/nio/file/WatchService/LotsOfEvents.java failed with NPE Reviewed-by: chegar ! test/java/nio/file/WatchService/LotsOfEvents.java Changeset: 507159d8d143 Author: ohair Date: 2010-03-03 11:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/507159d8d143 6931763: sanity checks broken with latest cygwin, newer egrep -i option problems Reviewed-by: jjg ! make/common/shared/Sanity.gmk Changeset: 61c298558549 Author: weijun Date: 2010-03-04 10:37 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/61c298558549 6844909: support allow_weak_crypto in krb5.conf Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/crypto/EType.java + test/sun/security/krb5/etype/WeakCrypto.java + test/sun/security/krb5/etype/weakcrypto.conf Changeset: 0f383673ce31 Author: weijun Date: 2010-03-04 10:38 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0f383673ce31 6923681: Jarsigner crashes during timestamping Reviewed-by: vinnie ! src/share/classes/sun/security/tools/TimestampedSigner.java Changeset: 5e15b70e6d27 Author: weijun Date: 2010-03-04 10:38 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5e15b70e6d27 6880321: sun.security.provider.JavaKeyStore abuse of OOM Exception handling Reviewed-by: xuelei ! src/share/classes/sun/security/provider/JavaKeyStore.java Changeset: c2d29e5695c2 Author: lana Date: 2010-03-04 13:40 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c2d29e5695c2 Merge Changeset: 58b44ac0b10d Author: ohair Date: 2010-03-06 14:59 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/58b44ac0b10d 6915983: testing problems, adjusting list of tests, needs some investigation Reviewed-by: alanb ! test/Makefile ! test/ProblemList.txt Changeset: eae6e9ab2606 Author: lana Date: 2010-03-09 15:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/eae6e9ab2606 Merge - test/java/nio/file/WatchService/OverflowEventIsLoner.java Changeset: 2cafbbe9825e Author: mikejwre Date: 2010-03-18 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2cafbbe9825e Added tag jdk7-b86 for changeset eae6e9ab2606 ! .hgtags Changeset: 45bd445f6250 Author: lana Date: 2010-03-19 18:49 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/45bd445f6250 Merge - make/java/text/FILES_java.gmk - test/java/nio/file/WatchService/OverflowEventIsLoner.java From lana.steuck at sun.com Fri Mar 19 23:26:05 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Mar 2010 06:26:05 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/langtools: 30 new changesets Message-ID: <20100320062726.7281844360@hg.openjdk.java.net> Changeset: 7d9e3a15d2b3 Author: jjg Date: 2010-02-15 16:09 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/7d9e3a15d2b3 6926555: 6921979 breaks TreePosTest Reviewed-by: darcy ! test/tools/javac/treepostests/TreePosTest.java Changeset: af18e3956985 Author: darcy Date: 2010-02-15 18:20 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/af18e3956985 6634138: Source generated in last round not compiled Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/tools/javac/T6403466.java + test/tools/javac/processing/6634138/Dummy.java + test/tools/javac/processing/6634138/ExerciseDependency.java + test/tools/javac/processing/6634138/T6634138.java Changeset: fe17a9dbef03 Author: darcy Date: 2010-02-15 20:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/fe17a9dbef03 6926699: Annotation processing regression tests should typically return SourceVersion.latest Reviewed-by: jjg ! test/tools/javac/6341866/Anno.java ! test/tools/javac/T6406771.java ! test/tools/javac/T6411379.java ! test/tools/javac/T6423583.java ! test/tools/javac/T6855236.java ! test/tools/javac/api/6421111/T6421111.java ! test/tools/javac/api/6468404/T6468404.java ! test/tools/javac/api/T6412669.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/processing/6348499/A.java ! test/tools/javac/processing/6414633/A.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/6430209/b6341534.java ! test/tools/javac/processing/T6439826.java ! test/tools/javac/processing/model/element/TypeParamBounds.java ! test/tools/javac/processing/model/type/MirroredTypeEx/OverEager.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/util/GetTypeElemBadArg.java ! test/tools/javac/processing/model/util/OverridesSpecEx.java Changeset: 631a273dac0f Author: darcy Date: 2010-02-15 20:17 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/631a273dac0f 6926703: apt tests should run with assertions enabled Reviewed-by: jjg ! src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java Changeset: 16b9b7f45933 Author: darcy Date: 2010-02-17 14:30 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/16b9b7f45933 6927061: Refactor apt implemenation to use code from JSR 269 Reviewed-by: jjg ! src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java Changeset: 67f0e05098fa Author: lana Date: 2010-02-17 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/67f0e05098fa Merge Changeset: 0fce6b64c258 Author: lana Date: 2010-02-17 16:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/0fce6b64c258 Merge Changeset: a3be81d385ee Author: jjg Date: 2010-02-18 15:41 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/a3be81d385ee 6927797: langtools/test/tools/javac/EarlyAssert.java fails when run with assertions enabled (-ea) Reviewed-by: darcy ! test/tools/javac/EarlyAssert.java + test/tools/javac/EarlyAssertWrapper.java Changeset: f25efdb55c99 Author: andrew Date: 2010-02-22 21:37 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/f25efdb55c99 6928623: Behaviour of VERBOSE=true on langtools build Summary: VERBOSE=true causes -diagnostics to be passed to ant rather than -debug Reviewed-by: jjg ! make/Makefile Changeset: 136bfc679462 Author: lana Date: 2010-02-23 10:17 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/136bfc679462 Merge Changeset: b816baf594e3 Author: mikejwre Date: 2010-03-04 13:50 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/b816baf594e3 Added tag jdk7-b85 for changeset 136bfc679462 ! .hgtags Changeset: 6eca0895a644 Author: jjg Date: 2010-02-23 18:43 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/6eca0895a644 6511613: javac unexpectedly doesn't fail in some cases if an annotation processor specified Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/processing/6511613/DummyProcessor.java + test/tools/javac/processing/6511613/clss41701.java Changeset: 87eb6edd4f21 Author: jjg Date: 2010-02-25 09:42 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/87eb6edd4f21 4880220: Add a warning when accessing a static method via an reference Reviewed-by: darcy ! make/build.properties ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/4880220/T4880220.empty.out + test/tools/javac/4880220/T4880220.error.out + test/tools/javac/4880220/T4880220.java + test/tools/javac/4880220/T4880220.warn.out Changeset: 85242c273d31 Author: darcy Date: 2010-02-25 11:04 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/85242c273d31 6929645: Address various findbugs warnings in langtools Reviewed-by: jjg ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java Changeset: dbcba45123cd Author: jjg Date: 2010-02-25 12:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/dbcba45123cd 6929544: langtools source code uses statics qualified by instance variables Reviewed-by: darcy ! make/build.properties ! src/share/classes/com/sun/tools/apt/main/CommandLine.java ! src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java ! src/share/classes/com/sun/tools/doclets/standard/Standard.java ! src/share/classes/com/sun/tools/javac/Launcher.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/main/CommandLine.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: af75fd6155de Author: jjg Date: 2010-02-25 13:32 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/af75fd6155de 6893943: exit code from javah with no args is 0 Reviewed-by: darcy ! src/share/classes/com/sun/tools/javah/JavahTask.java + test/tools/javah/T6893943.java Changeset: b030706da5b4 Author: jjg Date: 2010-02-26 08:42 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/b030706da5b4 6881645: Unchecked method call on a method declared inside anonymous inner causes javac to crash Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java + test/tools/javac/T6881645.java Changeset: 72833a8a6086 Author: jjg Date: 2010-02-26 15:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/72833a8a6086 6930076: "null" can incorrectly appear in error message compiler.err.error.reading.file Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: 7b69c7083a97 Author: jjg Date: 2010-02-26 15:30 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/7b69c7083a97 6930032: fix findbugs errors in com.sun.tools.javac.comp Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java Changeset: 7c23bbbe0dbd Author: darcy Date: 2010-03-02 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/7c23bbbe0dbd 6931130: Remove unused AnnotationCollector code from JavacProcessingEnvironment Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java Changeset: 6e1e2738c530 Author: jjg Date: 2010-03-02 16:40 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/6e1e2738c530 6931482: minor findbugs fixes Reviewed-by: darcy ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java Changeset: 235135d61974 Author: jjg Date: 2010-03-02 16:43 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/235135d61974 6931127: strange test class files Reviewed-by: darcy ! test/tools/javac/annotations/neg/Constant.java ! test/tools/javac/generics/Casting.java ! test/tools/javac/generics/Casting3.java ! test/tools/javac/generics/Casting4.java ! test/tools/javac/generics/InnerInterface1.java ! test/tools/javac/generics/InnerInterface2.java ! test/tools/javac/generics/Multibound1.java ! test/tools/javac/generics/MultipleInheritance.java ! test/tools/javac/generics/NameOrder.java ! test/tools/javac/generics/PermuteBound.java ! test/tools/javac/generics/PrimitiveVariant.java Changeset: fc7132746501 Author: darcy Date: 2010-03-03 16:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/fc7132746501 6449781: TypeElement.getQualifiedName for anonymous classes returns null instead of an empty name Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java + test/tools/javac/processing/model/element/TestAnonClassNames.java + test/tools/javac/processing/model/element/TestAnonSourceNames.java Changeset: 7f5db2e8b423 Author: jjg Date: 2010-03-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/7f5db2e8b423 6931927: position issues with synthesized anonymous class Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/tree/TestAnnotatedAnonClass.java + test/tools/javac/tree/TreePosTest.java - test/tools/javac/treepostests/TreePosTest.java Changeset: 117c95448ab9 Author: jjg Date: 2010-03-03 19:34 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/117c95448ab9 6931126: jtreg tests not Windows friendly Reviewed-by: darcy ! test/tools/javac/ThrowsIntersection_1.java ! test/tools/javac/ThrowsIntersection_2.java ! test/tools/javac/ThrowsIntersection_3.java ! test/tools/javac/ThrowsIntersection_4.java ! test/tools/javac/generics/NameOrder.java Changeset: c55733ceed61 Author: lana Date: 2010-03-04 13:40 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/c55733ceed61 Merge Changeset: a23282f17d0b Author: jjg Date: 2010-03-05 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/a23282f17d0b 6930108: IllegalArgumentException in AbstractDiagnosticFormatter for tools/javac/api/TestJavacTaskScanner.jav Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! test/tools/javac/api/TestJavacTaskScanner.java + test/tools/javac/api/TestResolveError.java Changeset: a4f3b97c8028 Author: jjg Date: 2010-03-05 16:13 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/a4f3b97c8028 Merge Changeset: ef07347428f2 Author: lana Date: 2010-03-09 15:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/ef07347428f2 Merge - test/tools/javac/treepostests/TreePosTest.java Changeset: 409db93d19c0 Author: mikejwre Date: 2010-03-18 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/409db93d19c0 Added tag jdk7-b86 for changeset ef07347428f2 ! .hgtags From neugens at limasoftware.net Mon Mar 22 15:27:17 2010 From: neugens at limasoftware.net (Mario Torre) Date: Mon, 22 Mar 2010 23:27:17 +0100 Subject: [OpenJDK 2D-Dev] Font rendering issue Message-ID: <1269296837.2362.29.camel@localhost> Hi Jim, Roman, Java2D people, I'm trying to fix an annoying bug that appears almost always fonts are rendered without antialiasing: http://www.limasoftware.net/neugens/downloads/stuff/font2dbug/bug.png I started tracking this because anything I write something with an underscore in NetBeans I don't see the underscore, and that drives me crazy (ok, it also affect JamaicaVM, but I fixed it because I type my code in NetBeans ;) My ideas was that the metrics are calculated incorrectly in presence of hinting [1]. The freetype documentation states that there can be an off-by-one (or more) in such cases. This made me check the freetype scaler native code and in turn the FontDesignMetrics. Now, by reading the code, I believe this to be a rounding error and not an off-by-one for the fixed-to-floating-point conversion and back that happens between native and java code, but it's still not 100% clear to me the reason and where the rounding goes off (the code is quite convoluted, or maybe it was just a too long day). I found two possible places where I could fix it, one is taking out the rounding from FontDesignMetrics [2]: private static float roundingUpValue = 0.0f and rounding the leading only in the freetypeScaler.c: ly = (jfloat) ROUND(FT26Dot6ToFloat( scalerInfo->face->size->metrics.height + bmodifier) + ay - dy); The other is to simply increase roundingUpValue to 1.0f. I would like some context around this, maybe those values were calculated for the closed font scaler and are not valid with freetype (maybe freetype does a better job with this even?) or maybe incrementing the rounding up does only fix the problem without fixing the cause (or worse, only for a selected group of fonts)? I'm a bit lost on that, so any hint (even subpixel ones :) is appreciated. Ah, before I forget, you can quickly test this with Open and ClosedJDK with the Font2DTest.jar and passing -Dawt.useSystemAAFontSettings=false Cheers, Mario [1] http://freetype.org/freetype2/docs/reference/ft2-base_interface.html#FT_Size_Metrics) [2] http://www.limasoftware.net/neugens/downloads/stuff/font2dbug/possible_fix.png -- pgp key: http://subkeys.pgp.net/ Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ From neugens at limasoftware.net Tue Mar 23 08:28:34 2010 From: neugens at limasoftware.net (Mario Torre) Date: Tue, 23 Mar 2010 16:28:34 +0100 Subject: [OpenJDK 2D-Dev] Font rendering issue In-Reply-To: <1269296837.2362.29.camel@localhost> References: <1269296837.2362.29.camel@localhost> Message-ID: <1269358114.2372.37.camel@localhost> Il giorno lun, 22/03/2010 alle 23.27 +0100, Mario Torre ha scritto: > I started tracking this because anything I write something with an > underscore in NetBeans I don't see the underscore, and that drives me > crazy (ok, it also affect JamaicaVM, but I fixed it because I type my > code in NetBeans ;) ... > [2] > http://www.limasoftware.net/neugens/downloads/stuff/font2dbug/possible_fix.png So, I can confirm that this also fixes my NetBeans bug. I created a bug entry: https://bugs.openjdk.java.net/show_bug.cgi?id=100134 webrev at http://cr.openjdk.java.net/~neugens/100134/webrev.00/ Cheers, Mario -- pgp key: http://subkeys.pgp.net/ Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ From Phil.Race at Sun.COM Tue Mar 23 12:32:07 2010 From: Phil.Race at Sun.COM (Phil Race) Date: Tue, 23 Mar 2010 12:32:07 -0700 Subject: [OpenJDK 2D-Dev] Font rendering issue In-Reply-To: <1269358114.2372.37.camel@localhost> References: <1269296837.2362.29.camel@localhost> <1269358114.2372.37.camel@localhost> Message-ID: <4BA91737.2070609@sun.com> Mario, If you look around lines 567-573 you'll see a comment to the effect that it was decresed fom 0.99 to 0.95 because that higher value was causing problems. This was back in 2001 and all I can recall from then is that it took a long time to get the right formula .. See http://bugs.sun.com/view_bug.do?bug_id=4467709 and there's a good number of bugs that reference that one. So putting it up to 1.0 would seem likely to regress (and then some) some of the behaviours. So a freetype specific fix is preferable here. -phil. On 3/23/2010 8:28 AM, Mario Torre wrote: > Il giorno lun, 22/03/2010 alle 23.27 +0100, Mario Torre ha scritto: > >> I started tracking this because anything I write something with an >> underscore in NetBeans I don't see the underscore, and that drives me >> crazy (ok, it also affect JamaicaVM, but I fixed it because I type my >> code in NetBeans ;) > > ... > >> [2] >> http://www.limasoftware.net/neugens/downloads/stuff/font2dbug/possible_fix.png > > So, I can confirm that this also fixes my NetBeans bug. > > I created a bug entry: > > https://bugs.openjdk.java.net/show_bug.cgi?id=100134 > > webrev at > > http://cr.openjdk.java.net/~neugens/100134/webrev.00/ > > Cheers, > Mario From Roman.Kennke at Sun.COM Tue Mar 23 12:51:46 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Tue, 23 Mar 2010 20:51:46 +0100 Subject: [OpenJDK 2D-Dev] Font rendering issue In-Reply-To: <4BA91737.2070609@sun.com> References: <1269296837.2362.29.camel@localhost> <1269358114.2372.37.camel@localhost> <4BA91737.2070609@sun.com> Message-ID: <1269373906.2613.46.camel@moonlight> Phil, is it possible that these rounding effects are different in T2K vs. FT? In this case, the rounding should probably be done in the font backends altogether. However, I doubt I fully understand what exactly is going on here. My understanding is that we need to round at least up to the next full integer, because if height is reported as e.g. 13.1, and we do normal float->int conversion, this would be treated as 13.0, i.e. at least for some glyphs layout will end up too small. Infact, this would even be true if height was reported as 13.9. In my understanding, what needs to be done is to 'ceil' the value up to the next full integer here. But the comment you reference below seems to indicate otherwise. ceil() would have the same effect as using 1.0 as rounding value, but as you said, you found that 0.95 is better for some reason. I wonder why? Wouldn't this result in bad behaviour in some rare cases, e.g. for fonts that have a very small (or none) leading? OTOH, choosing the value a little higher (1.0) does what kind of damage? Adding one pixel too much for some fonts? Is this so bad? I also wonder why this doesn't happen with other applications that use Freetype? Mario, it would be helpful if you made this a smaller testcase. It would probably render some difficult glyphs (gq_, etc) with clipping set to the font's reported height in different font sizes. And it should set a specific font, not simply use what's Swing's default, because those differ on FT vs. T2K. This way we could compare the FT vs. the T2K implementation. Maybe this gives some hints what goes wrong. > So a freetype specific fix is preferable here. The rounding should always be done when the value needs to be converted to int IMO, not earlier (i.e. in the freetype driving code). However, right now the rounding is in shared code. If we need different rounding values for FT vs. T2K, we need to pull this stuff into the FontScaler, which might be a lot of work. I took a look at how convoluted this font metrics code is, my god, what a mess! ;-) We have at least 6 different *Metrics classes, most of which seem to only carry values to another, it looks quite messy. Also, there's stuff like X11FontMetrics, which looks as if it's dead code. Thanks, Roman > > -phil. > > On 3/23/2010 8:28 AM, Mario Torre wrote: > > Il giorno lun, 22/03/2010 alle 23.27 +0100, Mario Torre ha scritto: > > > >> I started tracking this because anything I write something with an > >> underscore in NetBeans I don't see the underscore, and that drives me > >> crazy (ok, it also affect JamaicaVM, but I fixed it because I type my > >> code in NetBeans ;) > > > > ... > > > >> [2] > >> http://www.limasoftware.net/neugens/downloads/stuff/font2dbug/possible_fix.png > > > > So, I can confirm that this also fixes my NetBeans bug. > > > > I created a bug entry: > > > > https://bugs.openjdk.java.net/show_bug.cgi?id=100134 > > > > webrev at > > > > http://cr.openjdk.java.net/~neugens/100134/webrev.00/ > > > > Cheers, > > Mario > From Phil.Race at Sun.COM Tue Mar 23 13:10:49 2010 From: Phil.Race at Sun.COM (Phil Race) Date: Tue, 23 Mar 2010 13:10:49 -0700 Subject: [OpenJDK 2D-Dev] Font rendering issue In-Reply-To: <1269373906.2613.46.camel@moonlight> References: <1269296837.2362.29.camel@localhost> <1269358114.2372.37.camel@localhost> <4BA91737.2070609@sun.com> <1269373906.2613.46.camel@moonlight> Message-ID: <4BA92049.7050002@sun.com> It could be the hinting that Mario referred to. There are some notes (not by me) that the T2K values produced in JDK 1.4 when hinting was available were more correct than previously - when there was no hinting. But Swing wanted values that looked right for some common cases and 1.0 was excessive. I really can't remember exactly what cases after 9 years. And I don't have the cycles to dig up and repeat this now. So all I can say is that looking at what freetype's results are and adjusting for whether or not its using hinting is probably what's needed. Perhaps if Swing placed the mnemonics based on the underline offset of the font it would be better .. but I think Swing may just use the "height" of the font as the height of the component and taking into account that underline offset would add more runtime work and metrics churn now. And of course that offset wasn't available in 1.1 days where Swing started out. -phil. On 3/23/2010 12:51 PM, Roman Kennke wrote: > Phil, is it possible that these rounding effects are different in T2K > vs. FT? In this case, the rounding should probably be done in the font > backends altogether. However, I doubt I fully understand what exactly is > going on here. My understanding is that we need to round at least up to > the next full integer, because if height is reported as e.g. 13.1, and > we do normal float->int conversion, this would be treated as 13.0, i.e. > at least for some glyphs layout will end up too small. Infact, this > would even be true if height was reported as 13.9. In my understanding, > what needs to be done is to 'ceil' the value up to the next full integer > here. But the comment you reference below seems to indicate otherwise. > ceil() would have the same effect as using 1.0 as rounding value, but as > you said, you found that 0.95 is better for some reason. I wonder why? > Wouldn't this result in bad behaviour in some rare cases, e.g. for fonts > that have a very small (or none) leading? OTOH, choosing the value a > little higher (1.0) does what kind of damage? Adding one pixel too much > for some fonts? Is this so bad? > > I also wonder why this doesn't happen with other applications that use > Freetype? > > Mario, it would be helpful if you made this a smaller testcase. It would > probably render some difficult glyphs (gq_, etc) with clipping set to > the font's reported height in different font sizes. And it should set a > specific font, not simply use what's Swing's default, because those > differ on FT vs. T2K. This way we could compare the FT vs. the T2K > implementation. Maybe this gives some hints what goes wrong. > >> So a freetype specific fix is preferable here. > > The rounding should always be done when the value needs to be converted > to int IMO, not earlier (i.e. in the freetype driving code). However, > right now the rounding is in shared code. If we need different rounding > values for FT vs. T2K, we need to pull this stuff into the FontScaler, > which might be a lot of work. I took a look at how convoluted this font > metrics code is, my god, what a mess! ;-) We have at least 6 different > *Metrics classes, most of which seem to only carry values to another, it > looks quite messy. Also, there's stuff like X11FontMetrics, which looks > as if it's dead code. > > Thanks, Roman > >> >> -phil. >> >> On 3/23/2010 8:28 AM, Mario Torre wrote: >>> Il giorno lun, 22/03/2010 alle 23.27 +0100, Mario Torre ha scritto: >>> >>>> I started tracking this because anything I write something with an >>>> underscore in NetBeans I don't see the underscore, and that drives me >>>> crazy (ok, it also affect JamaicaVM, but I fixed it because I type my >>>> code in NetBeans ;) >>> >>> ... >>> >>>> [2] >>>> http://www.limasoftware.net/neugens/downloads/stuff/font2dbug/possible_fix.png >>> >>> So, I can confirm that this also fixes my NetBeans bug. >>> >>> I created a bug entry: >>> >>> https://bugs.openjdk.java.net/show_bug.cgi?id=100134 >>> >>> webrev at >>> >>> http://cr.openjdk.java.net/~neugens/100134/webrev.00/ >>> >>> Cheers, >>> Mario >> > >