[OpenJDK 2D-Dev] Warning Fixes from LJC Hack Session
stuart.marks at oracle.com
Mon Feb 6 14:53:50 PST 2012
Thanks for splitting up the patches and revising them in response to the review
I'm not yet entirely sure how to proceed with pushing these changes. I think
Chris assumed that I would push these changes. Since these are in awt,
printing, and beans, the changes might need to be pushed through a different
forest (2D?) than the forest in which I usually do work (TL). In addition it
might benefit from some additional review by members of the appropriate teams.
Phil, you saw this go by earlier -- do you have a recommendation for how you'd
like to proceed? I'm certainly happy to help out, but I'd end up pushing them
Oh, and Alan, Chris, Anthony, thanks for your reviews and comments.
On 2/4/12 8:40 AM, Michael Barker wrote:
> Patch with BeanSupportContext changes removed.
> On Sat, Feb 4, 2012 at 3:48 PM, Chris Hegarty<chris.hegarty at oracle.com> wrote:
>> I think you should just drop the changes to this file.
>> Michael Barker<mikeb01 at gmail.com> wrote:
>>>> Oh, good catch Alan, I missed this. This part of the change should be
>>>> reversed ( at least in the context of warnings cleanup ).
>>> Should I switch it to a wild card (protected transient ArrayList<?>
>>> bcmListeners) or just drop the modifications for that file?
More information about the 2d-dev