[OpenJDK 2D-Dev] [8] Review request for 7181438: [OGL] Incorrect alpha used, during blit from SW to the texture.

[Sergey Bylokhov]

Hi Everyone,
Please review the fix for 7181438.
This bug was introduced in 7u4b11, when macosx-port was integrated to 
jdku7 by this changeset:
http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9dfe50f456be

Note that now we always set format to GL_RGBA. So opaque surface has an 
alpha channel.
We handle this situation in: OGLBlitSurfaceToSurface, 
OGLBlitSwToSurface, OGLBlitToSurfaceViaTexture,
but there is no check in OGLBlitSwToTexture().

I assume that code for alpha verification should be the same.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7181438
Webrev can be found at: http://cr.openjdk.java.net/~serb/7181438/webrev.00

Also note that CR 7177173 and 7124244 depends from this one.

-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20120709/8ccf8bba/attachment.html>