[OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails
prasanta.sadhukhan at oracle.com
Mon Oct 29 06:47:58 UTC 2018
I do not see ImageIO.read and ImageIO.createImageInputStream throwing
IOB exception in the spec, it throws IOException so I guess there's no
point catching IOB.
Also, you need to add this bugid to @bug tag and also remove @author tag
which we do not recommend now. Also, can you please indent byte data ?
On 26-Oct-18 10:03 PM, Fairoz Matte wrote:
> Hi Prasanta,
> Thanks for looking into it.
>> -----Original Message-----
>> From: Prasanta Sadhukhan
>> Sent: Friday, October 26, 2018 8:56 AM
>> To: Fairoz Matte <fairoz.matte at oracle.com>; 2d-dev at openjdk.java.net
>> Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test
>> javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails
>> Hi Fairoz,
>> Do you know if the bmp image file has Oracle copyright? If not, you cannot
>> check it in.
> I was not aware of it. Yes image file is not Oracle copyright compliant.
>> Alternatively, you may get a hexdump of the bmp file and create a byte
>> array with that hex data and create ByteArrayInputStream with that and use
>> that for ImageIO as an ImageInputStream.
> Yes it is good approach, here is the updated webrev
>> On 25-Oct-18 11:52 AM, Fairoz Matte wrote:
>>> Kindly review the small fix.
>>> "javax/imageio/plugins/bmp/BMP8BPPLoadTest.java test case" has been
>>> added part of JDK-8182461, Test case has a dependency on input file
>> "BMP8BPPLoadTest.PNG", during push this was missed.
>>> In this fix test case also modified to refer the input file from same
>>> JBS bug - https://bugs.openjdk.java.net/browse/JDK-8212914
>>> Webrev - http://cr.openjdk.java.net/~fmatte/8212914/webrev.00/
More information about the 2d-dev