<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <p>Ok. Updated webrev just in case we are not reading the protocol
      wrongly.<br>
    </p>
    <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~psadhukhan/8170578/webrev.02/">http://cr.openjdk.java.net/~psadhukhan/8170578/webrev.02/</a><br>
    <br>
    Regards<br>
    Prasanta<br>
    <div class="moz-cite-prefix">On 1/12/2017 8:04 AM, Philip Race
      wrote:<br>
    </div>
    <blockquote cite="mid:5876EB50.2010305@oracle.com" type="cite">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      I am looking at this and the hold up is I can't remember the
      protocol readIPPResponse() is<br>
      trying to follow. Without that understanding it is hard to say
      much .. so I need to go read<br>
      up and remember .. <br>
      <br>
      Two¬† comments : There is an extra space in <br>
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <pre><span class="new">if (responseMap.length >  1) {</span></pre>
      The test update is bogus in referring to this bug. The change is
      nothing to do with the bug.<br>
      And I actually prefer printer tests to throw nasty exceptions when
      there are no printers<br>
      and they need one ... else SQE just don't configure printers on
      test systems and the tests all wrongly pass.<br>
      Would you run Linux UI tests on a blade with no X-server running ?<br>
      <br>
      -phil.<br>
      <br>
      On 1/10/17, 1:14 AM, Prasanta Sadhukhan wrote:
      <blockquote
        cite="mid:68d7b1d5-40f9-0841-0d6c-328861391f33@oracle.com"
        type="cite">
        <meta content="text/html; charset=utf-8"
          http-equiv="Content-Type">
        <p><br>
        </p>
        <br>
        <div class="moz-cite-prefix">On 1/10/2017 2:43 PM, Prasanta
          Sadhukhan wrote:<br>
        </div>
        <blockquote
          cite="mid:224e283e-47c5-f254-bafd-de5beccf1584@oracle.com"
          type="cite">
          <meta content="text/html; charset=utf-8"
            http-equiv="Content-Type">
          Actually, in ubuntu16.10 attribute map did not have
          "page-ranges-supported" attribute because 2 attribute hashmap
          is created in <span id="l1757">IPPPrintService#readIPPResponse()
            and most of the supported attributes are part of the 2nd
            hashmap (responseMap[1])<br>
            whereas only the 1st hashmap is utilised through
            responseMap[0] [<a moz-do-not-send="true"
              class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/8be0bb1aa238/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1760">http://hg.openjdk.java.net/jdk9/client/jdk/file/8be0bb1aa238/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1760</a>]<br>
          </span><br>
          As to why 2 hashmaps are created in ubuntu16.10, it is because
          readIPPResponse() checks if key is already present in existing
          map, then create a new hashmap through this <a
            moz-do-not-send="true"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/8be0bb1aa238/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1887">code</a><br>
          and in ubuntu16.10, some attributes (like
          pwg-raster-document-type-supported which is not there in
          ubuntu 14.04] are duplicated.<br>
          <br>
          Proposed fix is to check if there are more than 1 hashmaps, if
          it is, get the entries from those maps, remove duplicate
          entries and append to existing hashmap to get a consolidated
          map having all the IPP attributes.<br>
          <br>
        </blockquote>
        Missing webrev link: <a moz-do-not-send="true"
          class="moz-txt-link-freetext"
          href="http://cr.openjdk.java.net/%7Epsadhukhan/8170578/webrev.01/">http://cr.openjdk.java.net/~psadhukhan/8170578/webrev.01/</a><br>
        <blockquote
          cite="mid:224e283e-47c5-f254-bafd-de5beccf1584@oracle.com"
          type="cite"> Regards<br>
          Prasanta <br>
          <div class="moz-cite-prefix">On 12/21/2016 11:28 PM, Phil Race
            wrote:<br>
          </div>
          <blockquote
            cite="mid:90c7f438-27ee-3334-d91a-5b1aff84e025@oracle.com"
            type="cite">
            <meta content="text/html; charset=utf-8"
              http-equiv="Content-Type">
            So now I am very suspicious.<br>
            First (previous fix I reviewed) Job Sheets weren't supported
            on 16.10, now its PageRanges.<br>
            <br>
            I think this merits investigation of what is going on before
            we commit this fix.<br>
            Why are attributes that have always been supported by CUPS
            suddenly unavailable ?<br>
            <br>
            And for the cases we image the pages ourselves, we can
            implement PageRanges<br>
            internally, so for a normal PrinterJob it always can be
            supported .. regardless of<br>
            what the printer says.<br>
            <br>
            -phil.<br>
            <br>
            <br>
            <div class="moz-cite-prefix">On 12/14/2016 09:50 PM,
              Prasanta Sadhukhan wrote:<br>
            </div>
            <blockquote
              cite="mid:39f21e6d-78fb-6486-0260-620f42a63ccb@oracle.com"
              type="cite">
              <meta http-equiv="content-type" content="text/html;
                charset=utf-8">
              <p>Hi All,</p>
              <p>Please review a testbug fix for jdk9 for an issue where
                it it seen that PageRanges option is disabled in printer
                dialog in ubuntu16.10.</p>
              <p>Bug: <a moz-do-not-send="true"
                  class="moz-txt-link-freetext"
                  href="https://bugs.openjdk.java.net/browse/JDK-8170578">https://bugs.openjdk.java.net/browse/JDK-8170578</a></p>
              <p>webrev: <a moz-do-not-send="true"
                  class="moz-txt-link-freetext"
                  href="http://cr.openjdk.java.net/%7Epsadhukhan/8170578/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/8170578/webrev.00/</a></p>
              Issue was, in ubuntu16.10 the attribute map [obtained here
              <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/dc658d7dde90/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1767">http://hg.openjdk.java.net/jdk9/client/jdk/file/dc658d7dde90/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1767</a>]<br>
              does not have<br>
              "pageranges-supported" attribute returned by CUPS<br>
              so this category is not added to supported categories<br>
              [<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1030">http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1030</a>]<br>
              so isAttributeCategorySupported() called by ServiceDialog
              returns false<br>
              [<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l2763">http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l1141</a>]<br>
              resulting in PageRanges option getting disabled.<br>
              <br>
              Fix is to check if PageRanges category is supported in
              underlying platform, only then proceed with the test.<br>
              <br>
              Regards<br>
              Prasanta<br>
            </blockquote>
            <br>
          </blockquote>
          <br>
        </blockquote>
        <br>
      </blockquote>
    </blockquote>
    <br>
  </body>
</html>