<div dir="ltr">Sorry for the typo, I added also a newline before @since:<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">2017-04-20 23:04 GMT+02:00 Philip Race <span dir="ltr"><<a href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
     You have a capital letter here and I think it must be lower case ..<br>
    <br>
    <br>
    2499      * @Since 10<br>
    <br>
    -phil.<div><div class="h5"><br>
    <br>
    On 4/20/17, 1:58 PM, Laurent Bourgès wrote:
    <blockquote type="cite">
      <div dir="ltr">
        <div>
          <div>Hi Phil & Jim,<br>
            <br>
          </div>
          Here is the updated webrev:<br>
          <a href="http://cr.openjdk.java.net/%7Elbourges/path2D/Path2D-8078192.2/" target="_blank">http://cr.openjdk.java.net/~<wbr>lbourges/path2D/Path2D-<wbr>8078192.2/</a><br>
          <br>
        </div>
        <div>Changes:<br>
        </div>
        <div>- trimToSize() return void<br>
        </div>
        <div>- fixed test + jtreg passed<br>
        </div>
        <div><br>
        </div>
        <div>Bye,<br>
        </div>
        Laurent<br>
        <div class="gmail_extra"><br>
          <div class="gmail_quote">2017-04-20 21:30 GMT+02:00 Jim Graham
            <span dir="ltr"><<a href="mailto:james.graham@oracle.com" target="_blank">james.graham@oracle.com</a>></span>:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi
              Laurent,<br>
              <br>
              The implementation looks good, except that the method
              chaining-style return value seems out of place here. 
              Similar trimToSize() methods in Collections return void
              and none of the other methods in this area use the method
              chaining paradigm.  In the interest of maintaining a
              common design theme throughout 2D this method should just
              return void.<span class="m_-3829295938273823275HOEnZb"><font color="#888888"><br>
                  <br>
                                          ...jim</font></span>
              <div class="m_-3829295938273823275HOEnZb">
                <div class="m_-3829295938273823275h5"><br>
                  <br>
                  On 4/18/17 11:49 PM, Laurent Bourgès wrote:<br>
                  <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                    Hi,<br>
                    <br>
                    Here is a first attempt to propose a Path2D patch
                    (based on JDK10):<br>
                    <a href="http://cr.openjdk.java.net/%7Elbourges/path2D/Path2D-8078192.0/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~lb<wbr>ourges/path2D/Path2D-8078192.0<wbr>/</a><br>
                    <br>
                    JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8078192" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8078192</a><br>
                    <br>
                    Please review the Path2D changes, notably the
                    javadoc (english) and the modified
                    Path2DCopyConstructor test which checks<br>
                    all public Path2D methods on concrete classes
                    (Path2D.Float, Path2D.Double, GeneralPath) after
                    calling path.trimToSize()<br>
                    <br>
                    Cheers,<br>
                    Laurent<br>
                  </blockquote>
                </div>
              </div>
            </blockquote>
          </div>
          <br>
          <br clear="all">
          <br>
          -- <br>
          <div class="m_-3829295938273823275gmail_signature" data-smartmail="gmail_signature">--
            <br>
            Laurent Bourgès</div>
        </div>
      </div>
    </blockquote>
  </div></div></div>

</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">-- <br>Laurent Bourgès</div>
</div>