<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Sergey,<br>
    <br>
    This is not a comment on the content of the review; it is a minor
    comment on your interpretation of <p>.<br>
    <br>
    <p> is a block-level tag that is implicitly terminated by any
    of many block-level tags. For the full list, see the W3C definition
    of the p element in HTML 5:<br>
    <a class="moz-txt-link-freetext" href="https://www.w3.org/TR/html5/grouping-content.html#the-p-element">https://www.w3.org/TR/html5/grouping-content.html#the-p-element</a><br>
    <br>
    <blockquote type="cite">
      <dl class="element">
        <dt><a data-anolis-xref="element-dfn-tag-omission"
            href="https://www.w3.org/TR/html5/dom.html#element-dfn-tag-omission">Tag
            omission in text/html</a>:</dt>
        <dd>
          <p>A <code><a
                href="https://www.w3.org/TR/html5/grouping-content.html#the-p-element">p</a></code>
            element's <a data-anolis-xref="syntax-end-tag"
              href="https://www.w3.org/TR/html5/syntax.html#syntax-end-tag">end
              tag</a> may be omitted if the <code><a
                href="https://www.w3.org/TR/html5/grouping-content.html#the-p-element">p</a></code>
            element is immediately followed by an <code><a
                href="https://www.w3.org/TR/html5/sections.html#the-address-element">address</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/sections.html#the-article-element">article</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/sections.html#the-aside-element">aside</a></code>,
            <code><a
href="https://www.w3.org/TR/html5/grouping-content.html#the-blockquote-element">blockquote</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/grouping-content.html#the-div-element">div</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/grouping-content.html#the-dl-element">dl</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/forms.html#the-fieldset-element">fieldset</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/sections.html#the-footer-element">footer</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/forms.html#the-form-element">form</a></code>,
            <code><a
href="https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements">h1</a></code>,
            <code><a
href="https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements">h2</a></code>,
            <code><a
href="https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements">h3</a></code>,
            <code><a
href="https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements">h4</a></code>,
            <code><a
href="https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements">h5</a></code>,
            <code><a
href="https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements">h6</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/sections.html#the-header-element">header</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/obsolete.html#hgroup">hgroup</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/grouping-content.html#the-hr-element">hr</a></code>,
            <code><a
href="https://www.w3.org/TR/html5/grouping-content.html#the-main-element">main</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/sections.html#the-nav-element">nav</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/grouping-content.html#the-ol-element">ol</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/grouping-content.html#the-p-element">p</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/grouping-content.html#the-pre-element">pre</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/sections.html#the-section-element">section</a></code>,
            <code><a
                href="https://www.w3.org/TR/html5/tabular-data.html#the-table-element">table</a></code>,
            or <code><a
                href="https://www.w3.org/TR/html5/grouping-content.html#the-ul-element">ul</a></code>,
            element, or if there is no more content in the parent
            element and the parent element is not an <code><a
href="https://www.w3.org/TR/html5/text-level-semantics.html#the-a-element">a</a></code>
            element.</p>
        </dd>
      </dl>
    </blockquote>
    <br>
    <br>
    -- Jon<br>
    <br>
    <div class="moz-cite-prefix">On 05/05/2017 12:37 PM, Sergey Bylokhov
      wrote:<br>
    </div>
    <blockquote cite="mid:e2e40bf4-9f2f-46f2-86a8-1ceca25e23e6@default"
      type="cite">
      <pre wrap="">Hi, Alexey.
Yes it is possible to add </p> to this changes, but actually </p> tag is not used in JavaSound docs. The last one were removed a few years ago. The <p> tag is used in assumption that it affect the text till the next <p> or till the end of the doc.
So for example in the MidiMessage.java/SizeSequence.java there are a few <p> tags which affects the text till the next <p>, and in this fix just one more <p> was added in the middle.

----- <a class="moz-txt-link-abbreviated" href="mailto:alexey.menkov@oracle.com">alexey.menkov@oracle.com</a> wrote:

</pre>
      <blockquote type="cite">
        <pre wrap="">Overall looks good.
One minor point - there are several places when you replace <center> 
with <p> without end </p>.
Usually absent </p> doesn't cause any problem, but it would be better
to 
have end tags for all elements.

I see this in
src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java
src/java.desktop/share/classes/javax/sound/sampled/FloatControl.java
src/java.desktop/share/classes/javax/sound/sampled/TargetDataLine.java
src/java.desktop/share/classes/javax/swing/SizeSequence.java

--alex

On 05/04/2017 18:15, Sergey Bylokhov wrote:
</pre>
        <blockquote type="cite">
          <pre wrap="">Hello,
Please review the fix for jdk9-dev.
This fix is a part of the effort to make all javadoc in jdk9 be
</pre>
        </blockquote>
        <pre wrap="">compatible to HTML5.
</pre>
        <blockquote type="cite">
          <pre wrap="">
In the fix the most common issues are fixed.
The issues related to tables will be fixed later, because it is
</pre>
        </blockquote>
        <pre wrap="">depends from the new html styles which are under review[1].
</pre>
        <blockquote type="cite">
          <pre wrap="">
After the fix the number of errors reported during the build in
</pre>
        </blockquote>
        <pre wrap="">java.desktop module decreased from 300+ to 110.
</pre>
        <blockquote type="cite">
          <pre wrap="">
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8179596">https://bugs.openjdk.java.net/browse/JDK-8179596</a>
Webrev can be found at:
</pre>
        </blockquote>
        <pre wrap=""><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8179596/webrev.00">http://cr.openjdk.java.net/~serb/8179596/webrev.00</a>
</pre>
        <blockquote type="cite">
          <pre wrap="">Specdiff: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8179596/specdiff.00">http://cr.openjdk.java.net/~serb/8179596/specdiff.00</a>

[1]
</pre>
        </blockquote>
        <pre wrap=""><a class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047433.html">http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047433.html</a>
</pre>
        <blockquote type="cite">
          <pre wrap="">
</pre>
        </blockquote>
      </blockquote>
    </blockquote>
    <br>
  </body>
</html>