<div dir="auto">Ping ?<div dir="auto">In holidays ?</div></div><div class="gmail_extra"><br><div class="gmail_quote">Le 13 juil. 2017 9:36 AM, "Laurent Bourgès" <<a href="mailto:bourges.laurent@gmail.com">bourges.laurent@gmail.com</a>> a écrit :<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">Jim or Phil,<div dir="auto">Could you handle the CSR process on that patch and then push it in jdk10 ?<div dir="auto"><br></div><div dir="auto">I consider that bug finished on my side.</div><div dir="auto"><br></div><div dir="auto">Laurent</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">Le 8 juil. 2017 10:02, "Laurent Bourgès" <<a href="mailto:bourges.laurent@gmail.com" target="_blank">bourges.laurent@gmail.com</a>> a écrit :<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>Phil,</div><div dir="auto"><br></div><div dir="auto">Here are my comments on this CSR to be fixed in openjdk 10; I already submitted a patch and the review process happened in may.<br><div class="gmail_extra" dir="auto"><br><div class="gmail_quote">Le 3 juil. 2017 7:41 PM, "Phil Race" <<a href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a>> a écrit :<br type="attribution"><blockquote class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    Laurent,<br>
    <br>
    Investigation has determined that since this was ported over in the
    "CCC migration project",<br>
    due to the way that is set up it can't be assigned to non-Oracle
    employees.<br></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Ok, no problem.</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra" dir="auto"><div class="gmail_quote"><blockquote class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
    <br>
    It won't affect any new CSRs that are created.<br>
    <br>
    Since the likelihood of any other similar case is extremely low, the
    simplest answer is<br>
    that either Jim or myself will need to own and edit this one on your
    behalf.<br>
    <br>
    Send Jim or myself the changes you would like to make off-line and
    we'll take care of it.<br></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Just change the fix version to 10 and the @since javadoc tag as below:</div><div dir="auto"><br></div><div dir="auto">  /** </div><div dir="auto">    * Trims the capacity of this Path2D instance to its current </div><div dir="auto">     * size. An application can use this operation to minimize the </div><div dir="auto">     * storage of a path. </div><div dir="auto">     * </div><div dir="auto">     * @since 10 </div><div dir="auto">     */ +    public abstract void trimToSize(); <br></div><div dir="auto"><br></div><div dir="auto">It will match the proposed patch.</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Laurent</div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra" dir="auto"><div class="gmail_quote"><blockquote class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><div class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259elided-text"><blockquote type="cite"><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><div><div class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573111117434165m_479405004460737818h5"><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div><div class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573111117434165m_479405004460737818m_2760107019594871579h5"><br>
                                            <div class="gmail_quote">2017-04-20
                                              23:04 GMT+02:00 Philip
                                              Race <span dir="ltr"><<a href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a>></span>:<br>
                                              <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                                                <div bgcolor="#FFFFFF" text="#000000">  You
                                                  have a capital letter
                                                  here and I think it
                                                  must be lower case ..<br>
                                                  <br>
                                                  <br>
                                                  2499      * @Since 10<br>
                                                  <br>
                                                  -phil.
                                                  <div>
                                                    <div class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573111117434165m_479405004460737818m_2760107019594871579m_2453146926484059732h5"><br>
                                                      <br>
                                                      On 4/20/17, 1:58
                                                      PM, Laurent
                                                      Bourgès wrote:
                                                      <blockquote type="cite">
                                                        <div dir="ltr">
                                                          <div>
                                                          <div>Hi Phil
                                                          & Jim,<br>
                                                          <br>
                                                          </div>
                                                          Here is the
                                                          updated
                                                          webrev:<br>
                                                          <a href="http://cr.openjdk.java.net/%7Elbourges/path2D/Path2D-8078192.2/" target="_blank">http://cr.openjdk.java.net/~lb<wbr>ourges/path2D/Path2D-8078192.2<wbr>/</a><br>
                                                          <br>
                                                          </div>
                                                          <div>Changes:<br>
                                                          </div>
                                                          <div>-
                                                          trimToSize()
                                                          return void<br>
                                                          </div>
                                                          <div>- fixed
                                                          test + jtreg
                                                          passed<br>
                                                          </div>
                                                          <div><br>
                                                          </div>
                                                          <div>Bye,<br>
                                                          </div>
                                                          Laurent<br>
                                                          <div class="gmail_extra"><br>
                                                          <div class="gmail_quote">2017-04-20
                                                          21:30
                                                          GMT+02:00 Jim
                                                          Graham <span dir="ltr"><<a href="mailto:james.graham@oracle.com" target="_blank">james.graham@oracle.com</a>></span>:<br>
                                                          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi
                                                          Laurent,<br>
                                                          <br>
                                                          The
                                                          implementation
                                                          looks good,
                                                          except that
                                                          the method
                                                          chaining-style
                                                          return value
                                                          seems out of
                                                          place here. 
                                                          Similar
                                                          trimToSize()
                                                          methods in
                                                          Collections
                                                          return void
                                                          and none of
                                                          the other
                                                          methods in
                                                          this area use
                                                          the method
                                                          chaining
                                                          paradigm.  In
                                                          the interest
                                                          of maintaining
                                                          a common
                                                          design theme
                                                          throughout 2D
                                                          this method
                                                          should just
                                                          return void.<span class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573111117434165m_479405004460737818m_2760107019594871579m_2453146926484059732m_-3829295938273823275HOEnZb"><font color="#888888"><br>
                                                          <br>
                                                                       
                                                                   
                                                          ...jim</font></span>
                                                          <div class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573111117434165m_479405004460737818m_2760107019594871579m_2453146926484059732m_-3829295938273823275HOEnZb">
                                                          <div class="m_1358732251984629676m_5430966587385304386m_575913136501115138m_-590955008623482259m_-6816573111117434165m_479405004460737818m_2760107019594871579m_2453146926484059732m_-3829295938273823275h5"><br>
                                                          <br>
                                                          On 4/18/17
                                                          11:49 PM,
                                                          Laurent
                                                          Bourgès wrote:<br>
                                                          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                                                          Hi,<br>
                                                          <br>
                                                          Here is a
                                                          first attempt
                                                          to propose a
                                                          Path2D patch
                                                          (based on
                                                          JDK10):<br>
                                                          <a href="http://cr.openjdk.java.net/%7Elbourges/path2D/Path2D-8078192.0/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~lb<wbr>ourges/path2D/Path2D-8078192.0<wbr>/</a><br>
                                                          <br>
                                                          JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8078192" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8078192</a><br>
                                                          <br>
                                                          Please review
                                                          the Path2D
                                                          changes,
                                                          notably the
                                                          javadoc
                                                          (english) and
                                                          the modified
                                                          Path2DCopyConstructor</blockquote></div></div></blockquote></div></div></div></blockquote></div></div></div></blockquote></div></div></div></div></blockquote></div></div></blockquote></div></div></div></blockquote></div></div></blockquote></div></blockquote></div></div></blockquote></blockquote></div></div></blockquote></div></div></div></div>
</blockquote></div></div>
</blockquote></div></div>