<span style=" font-size:10pt;font-family:sans-serif">cc'ing Tom directly
in case this fell into a digest.</span>
<br>
<br><span style=" font-size:10pt;font-family:sans-serif">> I've reviewed
it. The change looks good, it's a good programming practice while loop
now :-)</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> Cheers</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> Andrew</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> Andrew Leonard</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> Java Runtimes
Development</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> IBM Hursley</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> IBM United
Kingdom Ltd</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> Phone internal:
245913, external: 01962 815913</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> internet
email: andrew_m_leonard@uk.ibm.com </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > Hi Tom,</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > Much
obliged. :)</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > Any
volunteers to be the 2nd reviewer?</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > Best
Regards</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > Adam
Farley</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
Hi Adam,</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
this patch looks good. I can sponsor this for you if noone else steps up,
but we need a second reviewer, preferably one from the 2d project.</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
Best Regards, Thomas</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
On Wed, Mar 21, 2018 at 12:41 PM, Adam Farley8 <adam.farley@uk.ibm.com>
wrote:</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
Hi All, </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
If committers really don't want this code, we could always try fixing the
code that the warning </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
is complaining about. </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
------------------------------ Change ---------------------------------------
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
diff --git a/src/java.desktop/share/native/libjavajpeg/jchuff.c b/src/java.desktop/share/native/libjavajpeg/jchuff.c
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
--- a/src/java.desktop/share/native/libjavajpeg/jchuff.c </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
+++ b/src/java.desktop/share/native/libjavajpeg/jchuff.c </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
@@ -805,7 +805,7 @@ </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
   for (i = MAX_CLEN; i > 16; i--) { </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
     while (bits[i] > 0) { </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
       j = i - 2;          
     /* find length of new prefix to be used */ </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
-      while (bits[j] == 0) </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
+      while ((bits[j] == 0) && (j > 0)) </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
         j--; </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
       bits[i] -= 2;          
  /* remove two symbols */</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
------------------------------ End of Change ---------------------------------------
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
Again, it's a small, simple change that fixes a build break on two platforms.
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
Either fix will solve this problem. </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
Best Regards</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
Adam Farley </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> Hi All, </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> I ask for a committer to add one word to make/lib/Awt2dLibraries.gmk
to solve a build break. </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> We need to go to line 495 and add array-bounds into the list of disabled
warnings. </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> So this: </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough shift-negative-value,
\ </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> becomes this: </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough shift-negative-value
array-bounds, \ </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> This fixes a build-breaking problem which occurs if you don't disable
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> errors-as-warnings on zLinux or Linux for ppcle. </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> Best Regards </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> Adam Farley </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> P.S. For further background, see this: </span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
> </span><a href="http://mail.openjdk.java.net/pipermail/2d-dev/2018-March/008958.html"><span style=" font-size:10pt;color:blue;font-family:sans-serif">http://mail.openjdk.java.net/pipermail/2d-dev/2018-March/008958.html</span></a><span style=" font-size:10pt;font-family:sans-serif">
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif">> > >
</span>
<br><span style=" font-size:10pt;font-family:sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br>
</span>