<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
As I said I prefer the make file change, since this is a change to
an upstream library.<br>
I've looked at jpeg-9c and it still looks identical to what we have
in 6b, so this code<br>
seems to have stood the test of time. I'm also unclear why the
compiler would<br>
complain about that and not the one a few lines later <br>
<br>
<pre> 819 while (bits[i] == 0) /* find largest codelength still in use */
820 i--;
A push to jchuff.c will get blown away if/when we upgrade.
A tool-chain specific fix in the makefile with an appropriate comment is more targeted.
</pre>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 03/27/2018 05:44 AM, Thomas Stüfe
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAA-vtUyugMfWjRr4tgR2ucCJrcqyVh1nqVfh5MC-V9SeasNO=w@mail.gmail.com">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>just a friendly reminder. I would like to push this tiny
fix because tripping over this on our linux s390x builds is
annoying (yes, we can maintain patch queues, but this is a
constant error source).</div>
<div><br>
</div>
<div>I will wait for 24 more hours until a reaction. If no
serious objections are forcoming, I want to push it (tier1
tests ran thru, and me and Christoph langer are both
Reviewers).</div>
<div><br>
</div>
<div>Thanks! Thomas</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Mar 21, 2018 at 6:20 PM, Thomas
Stüfe <span dir="ltr"><<a
href="mailto:thomas.stuefe@gmail.com" target="_blank"
moz-do-not-send="true">thomas.stuefe@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>may I please have another review for this really
trivial change. It fixes a gcc warning on s390 and ppc.
Also, it is probably a good idea to fix this.</div>
<div><br>
</div>
<div>bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8200052"
target="_blank" moz-do-not-send="true">https://bugs.openjdk.<wbr>java.net/browse/JDK-8200052</a></div>
<div>webrev: <a
href="http://cr.openjdk.java.net/%7Estuefe/webrevs/8200052-fix-warning-in-jchuff.c/webrev.00/webrev/"
target="_blank" moz-do-not-send="true">http://cr.openjdk.<wbr>java.net/~stuefe/webrevs/<wbr>8200052-fix-warning-in-jchuff.<wbr>c/webrev.00/webrev/</a></div>
<div><br>
</div>
<div>This was contributed by Adam Farley at IBM.</div>
<div><br>
</div>
<div>I already reviewed this. I also test-built on zlinux
and it works.</div>
<div><br>
</div>
<div>Thanks, Thomas</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>