RFR - JDK-8202442 - String::unescape (Code Review)

Jim Laskey james.laskey at oracle.com
Wed Sep 19 12:31:30 UTC 2018


> On Sep 18, 2018, at 5:55 PM, Naoto Sato <naoto.sato at oracle.com> wrote:
> Hi Jim,
> At the last sentence in the method description, there's a line "otherwise a CharacterCodingException may occur during UTF-8 decoding." It's not decoding into UTF-8, so simply "during decoding (or unescaping)" sounds better to me.
> Naoto
> On 9/18/18 10:51 AM, Jim Laskey wrote:
>> Please review the code for String::unescape. Used to translate escape sequences in a string, typically in a raw string literal, into characters represented by those escapes.
>> webrev: http://cr.openjdk.java.net/~jlaskey/8202442/webrev/index.html
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8202442
>> csr: https://bugs.openjdk.java.net/browse/JDK-8202443
>> Cheers,
>> — Jim

More information about the amber-dev mailing list