From Artem.Ananiev at Sun.COM Wed Aug 1 01:51:46 2007 From: Artem.Ananiev at Sun.COM (Artem Ananiev) Date: Wed, 01 Aug 2007 12:51:46 +0400 Subject: Window Decorations do not work on x86_64 In-Reply-To: <46AF3F51.2050908@redhat.com> References: <46AA381D.3050703@redhat.com> <46AAFDAC.9090405@sun.com> <46ADEA37.4060201@redhat.com> <46AE09F2.9070605@redhat.com> <46AE497E.9030702@redhat.com> <46AF3F51.2050908@redhat.com> Message-ID: <46B049A2.1040706@sun.com> Hi, Francis, all, the diffs in XPanelPeer are a part of the fix for 6567564 (Canvas's graphics config does not change when moved across monitors, Linux). The fix also includes some changes in XPanelPeer sub/super classes, and I think it's not a right thing to revert the changes from XPanelPeer only. At the same time, I still can't reproduce the described problem with window decorations on my desktop. I have already written to Kyle privately about the required system configuration (32/64 bit, window manager, window manager version, etc.) but haven't received any reply. Until this information is available, we can't proceed with the bug. Thanks, Artem Francis Kung wrote: > Hi everyone, > >>>>> Could you tell what window manager you're using when you observe >>>>> this behavior? Did you try running under Metacity? Is the bug still >>>>> reproducible then? >>>> >>>> This was tested under Metacity and it is still a bug. >>> Sun accepted this bug this morning as bug 6586752. >>> >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6586752 >> >> >> This problem was narrowed down to a regression between b14 and b15. >> The patch causing the problem has been uploaded here: >> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=37 >> >> Though, we are still trying to determine what part of this patch is >> the cause. > > I've found the specific area that causes this regression; it was the > change in XPanelPeer.java. I've attached the relevant b14->b15 diff; if > you revert that patch then window decorations appear once again. > > Regards, > Francis > From kgallowa at redhat.com Wed Aug 1 06:53:32 2007 From: kgallowa at redhat.com (Kyle Galloway) Date: Wed, 01 Aug 2007 09:53:32 -0400 Subject: Window Decorations do not work on x86_64 In-Reply-To: <46B049A2.1040706@sun.com> References: <46AA381D.3050703@redhat.com> <46AAFDAC.9090405@sun.com> <46ADEA37.4060201@redhat.com> <46AE09F2.9070605@redhat.com> <46AE497E.9030702@redhat.com> <46AF3F51.2050908@redhat.com> <46B049A2.1040706@sun.com> Message-ID: <46B0905C.9040805@redhat.com> Hi all, I responded to Artem directly, but I'm going to post my response here for those that are interested. I am using Gnome 2.18.3 running on Fedora 7. Metacity is my window manager, and I have tried "metacity --replace" with no effects. I am not running any composite extensions, or even a proprietary video driver (I use VESA and have an ATI video card). The latest binary JDKs do not cause this issue, it is only seen with OpenJDK/IcedTea (although it has been fixed in IcedTea 1.2 released today). I have also enclosed a screenshot of a simple awt app that appears correctly on 32-bit systems, but, as can be seen, is missing window decorations on our x86_64 machines. Hope that helps. Thanks, Kyle Artem Ananiev wrote: > Hi, Francis, all, > > the diffs in XPanelPeer are a part of the fix for 6567564 (Canvas's > graphics config does not change when moved across monitors, Linux). > The fix also includes some changes in XPanelPeer sub/super classes, > and I think it's not a right thing to revert the changes from > XPanelPeer only. > > At the same time, I still can't reproduce the described problem with > window decorations on my desktop. I have already written to Kyle > privately about the required system configuration (32/64 bit, window > manager, window manager version, etc.) but haven't received any reply. > Until this information is available, we can't proceed with the bug. > > Thanks, > > Artem > > Francis Kung wrote: >> Hi everyone, >> >>>>>> Could you tell what window manager you're using when you observe >>>>>> this behavior? Did you try running under Metacity? Is the bug >>>>>> still reproducible then? >>>>> >>>>> This was tested under Metacity and it is still a bug. >>>> Sun accepted this bug this morning as bug 6586752. >>>> >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6586752 >>> >>> >>> This problem was narrowed down to a regression between b14 and b15. >>> The patch causing the problem has been uploaded here: >>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=37 >>> >>> Though, we are still trying to determine what part of this patch is >>> the cause. >> >> I've found the specific area that causes this regression; it was the >> change in XPanelPeer.java. I've attached the relevant b14->b15 diff; >> if you revert that patch then window decorations appear once again. >> >> Regards, >> Francis >> -------------- next part -------------- A non-text attachment was scrubbed... Name: window_decs.png Type: image/png Size: 22857 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20070801/1bb9ecb8/attachment-0001.png From fkung at redhat.com Thu Aug 2 11:02:33 2007 From: fkung at redhat.com (Francis Kung) Date: Thu, 02 Aug 2007 14:02:33 -0400 Subject: Window Decorations do not work on x86_64 In-Reply-To: <46B0905C.9040805@redhat.com> References: <46AA381D.3050703@redhat.com> <46AAFDAC.9090405@sun.com> <46ADEA37.4060201@redhat.com> <46AE09F2.9070605@redhat.com> <46AE497E.9030702@redhat.com> <46AF3F51.2050908@redhat.com> <46B049A2.1040706@sun.com> <46B0905C.9040805@redhat.com> Message-ID: <46B21C39.4030602@redhat.com> Hi, It looks like I was a bit premature in blaming a patch for this bug; it turns out to be a much more subtle problem with the build system (and completely unrelated to XPanelPeer, which had the unfortunate position of being in the wrong place at the wrong time =) ). My extreme apologies for heading in the wrong direction with this. The real problem here is between lesstif and openmotif. The PropMwmHints struct has a different size, and thus lesstif is incompatible with OpenJDK on 64-bit architectures. This also explains why the Sun developers weren't seeing this (I assume they use openmotif), and a stray ALT_MOTIF_DIR setting in my build environment, left-over from a b14 build, led me on a wild goose chase last week. Regards, Francis From Anton.Tarasov at Sun.COM Tue Aug 28 09:37:39 2007 From: Anton.Tarasov at Sun.COM (Anton V. Tarasov) Date: Tue, 28 Aug 2007 20:37:39 +0400 Subject: RFC: KeyboardFocusManager patch In-Reply-To: <469DDCB6.4070800@sun.com> References: <1182417964.6814.30.camel@mercury> <467A9EDD.8010404@sun.com> <1182441936.6814.74.camel@mercury> <467AA6B6.2080402@sun.com> <1182444027.6814.83.camel@mercury> <467B60DC.4000900@sun.com> <467B76AD.6020107@sun.com> <1182505596.6166.15.camel@mercury> <1182505691.6166.17.camel@mercury> <469B52A7.8050808@sun.com> <1184609322.6246.31.camel@mercury> <469DD105.9040204@sun.com> <1184750096.6079.6.camel@mercury> <469DDCB6.4070800@sun.com> Message-ID: <46D44F53.30907@sun.com> Hi Roman, The latest update. Your fix has been finally approved and I've just put it into our local JDK 7 workspace. It's not yet integrated into the master workspace, but this should happen soon. By the way, here's the CR: http://bugs.sun.com/view_bug.do?bug_id=6580829 (you can track its state now) Also, during the process of reviewing the javadoc comments has yet been changed. And finally, I was asked to remove the @author tag. That's the final version: /src/share/classes/sun/awt/KeyboardFocusManagerPeerProvider.java 1 /* 2 * Copyright 2007 Sun Microsystems, Inc. All Rights Reserved. 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 4 * 5 * This code is free software; you can redistribute it and/or modify it 6 * under the terms of the GNU General Public License version 2 only, as 7 * published by the Free Software Foundation. Sun designates this 8 * particular file as subject to the "Classpath" exception as provided 9 * by Sun in the LICENSE file that accompanied this code. 10 * 11 * This code is distributed in the hope that it will be useful, but WITHOUT 12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 14 * version 2 for more details (a copy is included in the LICENSE file that 15 * accompanied this code). 16 * 17 * You should have received a copy of the GNU General Public License version 18 * 2 along with this work; if not, write to the Free Software Foundation, 19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. 20 * 21 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, 22 * CA 95054 USA or visit www.sun.com if you need additional information or 23 * have any questions. 24 */ 25 26 package sun.awt; 27 28 import java.awt.KeyboardFocusManager; 29 import java.awt.peer.KeyboardFocusManagerPeer; 30 31 /** 32 * {@link KeyboardFocusManagerPeerProvider} is required to be implemented by 33 * the currently used {@link java.awt.Toolkit} instance. In order to initialize 34 * {@link java.awt.KeyboardFocusManager}, an instance of {@link KeyboardFocusManagerPeer} 35 * is needed. To create that instance, the {@link #createKeyboardFocusManagerPeer} 36 * method of the current toolkit is called. 37 */ 38 public interface KeyboardFocusManagerPeerProvider { 39 40 /** 41 * Creates a KeyboardFocusManagerPeer for the specified KeyboardFocusManager. 42 */ 43 KeyboardFocusManagerPeer createKeyboardFocusManagerPeer(KeyboardFocusManager manager); 44 } --- Thanks, Anton. From roman.kennke at aicas.com Tue Aug 28 11:53:46 2007 From: roman.kennke at aicas.com (Roman Kennke) Date: Tue, 28 Aug 2007 20:53:46 +0200 Subject: RFC: KeyboardFocusManager patch In-Reply-To: <46D44F53.30907@sun.com> References: <1182417964.6814.30.camel@mercury> <467A9EDD.8010404@sun.com> <1182441936.6814.74.camel@mercury> <467AA6B6.2080402@sun.com> <1182444027.6814.83.camel@mercury> <467B60DC.4000900@sun.com> <467B76AD.6020107@sun.com> <1182505596.6166.15.camel@mercury> <1182505691.6166.17.camel@mercury> <469B52A7.8050808@sun.com> <1184609322.6246.31.camel@mercury> <469DD105.9040204@sun.com> <1184750096.6079.6.camel@mercury> <469DDCB6.4070800@sun.com> <46D44F53.30907@sun.com> Message-ID: <1188327226.6029.7.camel@mercury> Hi Anton, > The latest update. > Your fix has been finally approved and I've just put it into our local JDK 7 workspace. > It's not yet integrated into the master workspace, but this should happen soon. Very good! Thank you! > By the way, here's the CR: http://bugs.sun.com/view_bug.do?bug_id=6580829 > > (you can track its state now) > > Also, during the process of reviewing the javadoc comments has yet been changed. > And finally, I was asked to remove the @author tag. Sounds perfectly fine to me. Thank you, Roman -- Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt