From anton.tarasov at sun.com Wed Jun 4 02:10:02 2008 From: anton.tarasov at sun.com (anton.tarasov at sun.com) Date: Wed, 04 Jun 2008 09:10:02 +0000 Subject: hg: jdk7/awt/jdk: 6280057: I have audited SystemTray and TrayIcon code Message-ID: <20080604091028.4BC4B28EFD@hg.openjdk.java.net> Changeset: 80a4ace80c31 Author: ant Date: 2008-06-04 12:32 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/80a4ace80c31 6280057: I have audited SystemTray and TrayIcon code Summary: small refactoring Reviewed-by: dcherepanov ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/TrayIcon.java From anton.tarasov at sun.com Wed Jun 4 03:17:53 2008 From: anton.tarasov at sun.com (anton.tarasov at sun.com) Date: Wed, 04 Jun 2008 10:17:53 +0000 Subject: hg: jdk7/awt/jdk: 6708322: test/closed/java/awt/Focus/TemporaryLostComponentDeadlock fails Message-ID: <20080604101805.A212E28F02@hg.openjdk.java.net> Changeset: adebdf3701a4 Author: ant Date: 2008-06-04 14:16 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/adebdf3701a4 6708322: test/closed/java/awt/Focus/TemporaryLostComponentDeadlock fails Summary: Introduced new package private object for synchronization purposes. It should replace "this" in some deadlock prone cases. Reviewed-by: anthony, art ! src/share/classes/java/awt/Component.java From Denis.Fokin at Sun.COM Wed Jun 4 10:05:38 2008 From: Denis.Fokin at Sun.COM (Denis S. Fokin) Date: Wed, 04 Jun 2008 21:05:38 +0400 Subject: 4899516: Transferable has no DataFlavors when dragging from Gnome window to Swing In-Reply-To: <9e89675b0805140634t4794d778i46e21ce47563771a@mail.gmail.com> References: <9e89675b0709242121x3f5fcd44n3323ff7f3991b56f@mail.gmail.com> <46F91E6C.7050205@Sun.com> <9e89675b0709250831o122dcb37l275bad7146c6ddc3@mail.gmail.com> <46F93531.8070102@Sun.com> <9e89675b0709260120t3856e4ddr32ee816c8f6b338a@mail.gmail.com> <46FB6B3F.50106@Sun.com> <9e89675b0709302341q9645050o249c4591c725d730@mail.gmail.com> <47013435.3000707@sun.com> <9e89675b0805140634t4794d778i46e21ce47563771a@mail.gmail.com> Message-ID: <4846CB62.3010805@sun.com> Hi Damjan, I have some thoughts (sorry for the delay). At first, I like your prototype. Thank you for your efforts. So some ideas and notes are bellow. 1. The first idea is we should not return an empty List list. The better approach would be if we do not publish javaFileListFlavor data flavor. In that case we have to analyze content of the URI list and decide whether we can provide all URIs as files. If we cannot, user on target must not receive javaFileListFlavor data flavor at all. Only javaURIListFlavor. 2. Some consideration about JavaDoc ******** DataFlavor.java *********** + /** + * To transfer a list of files and/or URIs to/from Java (and + * the underlying platform) a DataFlavor of this + * type/subtype and representation class of + * java.util.List is used. Each element of this + * list is required/guaranteed to be of type + * java.net.URI. + *

+ * You should use this flavor instead of javaFileListFlavor, + * because some platforms provide only URI lists, not file + * lists. On these platforms, if and only if all URIs are + * files for the transfer in question, you can use/get + * javaFileListFlavor in addition to this flavor, for + * backward compatibility. I think that there is no need to mention javaFileListFlavor here in case if we are going provide javaURIListFlavor on Windows platform. 3. **** DataTransferer.java *************** - private String getBestCharsetForTextFormat(Long lFormat, + protected String getBestCharsetForTextFormat(Long lFormat, I do not think that changing access level is a good idea here. It is needed only in single subclass so may be it would be better redesign this approach. Thank you, Denis. Damjan Jovanovic wrote: > On Mon, Oct 1, 2007 at 7:53 PM, Denis S. Fokin wrote: > >> Hi Damjan, >> >> >>> Ok I'm sorry for arguing so much. Less talk more code :-). >>> >> > >> > This weekend I started writing code for URIListFlavor, but I quickly >> > realized another problem. If you deprecate javaFileListFlavor and use >> > URIListFlavor, the problem still exists in the opposite direction: >> > when Java is the drag source and a native application the drop target, >> > on non-XDnD implementations you still have to do lossy conversion from >> > URIs to Files and somehow disregard non-local-file URIs, and possibly >> > provide the native application with an empty file list. >> > >> > Any ideas? >> > >> > >> Currently, AWT supports OLE Drag & Drop protocol on Windows platform, >> XDnD and Motif Drag & Drop protocols on UNIX-like platforms. >> >> In case if some application asks our java source about available >> formats, we will provide javaFileListFlavor only if among our data files >> are presented. >> >> On the basis of a value returned by uri.getScheme() method we could >> understand whether we should provide javaFileListFlavor for native >> application. >> >> In this case we will not publish native flavors for file list (e.g. >> HDROP on windows). >> >> I suppose, the same scenario should works for java intra-jvm transfer. >> >> To summarize, as far as we have all information on drag source we can >> publish only data flavors which we really have. >> >> But I could miss out something, so give me know where the problems arise. >> >> Thank you, >> Denis. >> >> > > Hi again > > I've made a patch that works for me (attached). It adds a > java.awt.datatransfer.DataFlavor.javaURIListFlavor of MIME type > application/x-java-uri-list;class=java.util.List, and does full > bidirectional conversion between file lists and URI lists. That is, > file lists are promoted to URI lists, and URI lists are lossily > converted to file lists. > > If you drag a file list from native into Java, the application sees > both a URI list and a file list. If you drag in a URI list it sees a > URI list, and if all URIs are files also a non-empty file list, > otherwise just an empty file list. If a Java drag source provides a > file list to native then native sees both a URI list (where > implemented on native) and a file list, and where Java provides a URI > list native sees the URI list (where implemented) and the subset of > files taken from those URIs that are local files (javaFileListFlavor > already uses similar logic: it just ignores non-String non-File > entries). > > What happens when native doesn't support URI lists and a Java drag > source provides it? Currently if native doesn't support a URI list > format, you won't be able to do inter-JVM and Java->native URI list > transfers, only the local files in those URIs will go through and be > seen as a file list by the other side. Out of Windows, X11, and Motif, > in my patch currently only X11 supports them :-(. I haven't been able > to find proper URI list support in Windows, most of the fancy shell > clipboard types that can transfer URLs and such, seem to only transfer > 1 item instead of a list. > > Otherwise I've tested dragging files between Java and Gnome's > Nautilus, in both directions. It works well :-). > > Thoughts? Suggestions? > > Bye > Damjan > -------------- next part -------------- A non-text attachment was scrubbed... Name: 4899516.patch Type: text/x-diff Size: 19392 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20080604/c73b2ffa/attachment.bin From Alla.Redko at Sun.COM Thu Jun 5 02:36:15 2008 From: Alla.Redko at Sun.COM (Alla Redko) Date: Thu, 05 Jun 2008 13:36:15 +0400 Subject: 4899516: Transferable has no DataFlavors when dragging from Gnome window to Swing In-Reply-To: <4846CB62.3010805@sun.com> References: <9e89675b0709242121x3f5fcd44n3323ff7f3991b56f@mail.gmail.com> <46F91E6C.7050205@Sun.com> <9e89675b0709250831o122dcb37l275bad7146c6ddc3@mail.gmail.com> <46F93531.8070102@Sun.com> <9e89675b0709260120t3856e4ddr32ee816c8f6b338a@mail.gmail.com> <46FB6B3F.50106@Sun.com> <9e89675b0709302341q9645050o249c4591c725d730@mail.gmail.com> <47013435.3000707@sun.com> <9e89675b0805140634t4794d778i46e21ce47563771a@mail.gmail.com> <4846CB62.3010805@sun.com> Message-ID: <4847B38F.5030803@Sun.COM> Hi Damjan, Please find some comments on javadoc. Note: the tag is considered outdated, use the {@code} notation instead. 1. + * + * You should generally use javaURIListFlavor instead of this. */ I'd suggest: + * + * Use the {@code javaURIListFlavor} class instead. */ 2. + /** + * To transfer a list of files and/or URIs to/from Java (and + * the underlying platform) a DataFlavor of this + * type/subtype and representation class of + * java.util.List is used. Each element of this + * list is required/guaranteed to be of type + * java.net.URI. + *

+ * Use this flavor instead of {@code javaFileListFlavor}, + * because some platforms support only URI lists, not file + * lists. On these platforms you may use {@code javaFileListFlavor} as well + * to provide backward compatibility. + * + * @since 1.7 + */ 3. + /** + * Returns true if the DataFlavor specified represents + * a list of URI objects. + * @return true is the DataFlavor specified represents + * a List of File objects + */ My corrections: + /** + * Returns {@code true} if the specified {@code DataFlavor} represents + * a list of URI objects. + * @return {@code true} if the specified {@code DataFlavor} represents + * a {@code List} of {@code File} objects + */ 4. /** + * Determines whether the DataFlavor corresponding to the specified long + * format is DataFlavor.javaURIListFlavor. + */ Minor corrections: /** + * Determines whether the {@code DataFlavor} corresponding to the specified long + * format is {@code DataFlavor.javaURIListFlavor}. + */ 5. + /** + * Translate a transferable to a URI list. The default implementation + * provides a text/uri-list MIME type in the target encoding. + */ Minor corrections: + /** + * Translates a transferable object to a URI list. The default implementation + * provides a text/uri-list MIME type in the target encoding. + */ 6. + /** + * Decode URIs from either a byte array or a stream. + */ A minor correction: + /** + * Decodes URIs from either a byte array or a stream. + */ Best regards, Alla Denis S. Fokin wrote: > Hi Damjan, > > I have some thoughts (sorry for the delay). > > At first, I like your prototype. Thank you for your efforts. > > So some ideas and notes are bellow. > > 1. > The first idea is we should not return an empty List list. The > better approach would be if we do not publish javaFileListFlavor data > flavor. In that case we have to analyze content of the URI list and > decide whether we can provide all URIs as files. If we cannot, user on > target must not receive javaFileListFlavor data flavor at all. Only > javaURIListFlavor. > > 2. > Some consideration about JavaDoc > > ******** DataFlavor.java *********** > > + /** > + * To transfer a list of files and/or URIs to/from Java (and > + * the underlying platform) a DataFlavor of this > + * type/subtype and representation class of > + * java.util.List is used. Each element of this > + * list is required/guaranteed to be of type > + * java.net.URI. > + *

> + * You should use this flavor instead of javaFileListFlavor, > + * because some platforms provide only URI lists, not file > + * lists. On these platforms, if and only if all URIs are > + * files for the transfer in question, you can use/get > + * javaFileListFlavor in addition to this flavor, for > + * backward compatibility. > > I think that there is no need to mention javaFileListFlavor here in case > if we are going provide javaURIListFlavor on Windows platform. > > 3. > > **** DataTransferer.java *************** > > - private String getBestCharsetForTextFormat(Long lFormat, > + protected String getBestCharsetForTextFormat(Long lFormat, > > I do not think that changing access level is a good idea here. It is > needed only in single subclass so may be it would be better redesign > this approach. > > Thank you, > Denis. > > Damjan Jovanovic wrote: > >> On Mon, Oct 1, 2007 at 7:53 PM, Denis S. Fokin wrote: >> >> >>> Hi Damjan, >>> >>> >>> >>>> Ok I'm sorry for arguing so much. Less talk more code :-). >>>> >>>> >>> > >>> > This weekend I started writing code for URIListFlavor, but I quickly >>> > realized another problem. If you deprecate javaFileListFlavor and use >>> > URIListFlavor, the problem still exists in the opposite direction: >>> > when Java is the drag source and a native application the drop target, >>> > on non-XDnD implementations you still have to do lossy conversion from >>> > URIs to Files and somehow disregard non-local-file URIs, and possibly >>> > provide the native application with an empty file list. >>> > >>> > Any ideas? >>> > >>> > >>> Currently, AWT supports OLE Drag & Drop protocol on Windows platform, >>> XDnD and Motif Drag & Drop protocols on UNIX-like platforms. >>> >>> In case if some application asks our java source about available >>> formats, we will provide javaFileListFlavor only if among our data files >>> are presented. >>> >>> On the basis of a value returned by uri.getScheme() method we could >>> understand whether we should provide javaFileListFlavor for native >>> application. >>> >>> In this case we will not publish native flavors for file list (e.g. >>> HDROP on windows). >>> >>> I suppose, the same scenario should works for java intra-jvm transfer. >>> >>> To summarize, as far as we have all information on drag source we can >>> publish only data flavors which we really have. >>> >>> But I could miss out something, so give me know where the problems arise. >>> >>> Thank you, >>> Denis. >>> >>> >>> >> Hi again >> >> I've made a patch that works for me (attached). It adds a >> java.awt.datatransfer.DataFlavor.javaURIListFlavor of MIME type >> application/x-java-uri-list;class=java.util.List, and does full >> bidirectional conversion between file lists and URI lists. That is, >> file lists are promoted to URI lists, and URI lists are lossily >> converted to file lists. >> >> If you drag a file list from native into Java, the application sees >> both a URI list and a file list. If you drag in a URI list it sees a >> URI list, and if all URIs are files also a non-empty file list, >> otherwise just an empty file list. If a Java drag source provides a >> file list to native then native sees both a URI list (where >> implemented on native) and a file list, and where Java provides a URI >> list native sees the URI list (where implemented) and the subset of >> files taken from those URIs that are local files (javaFileListFlavor >> already uses similar logic: it just ignores non-String non-File >> entries). >> >> What happens when native doesn't support URI lists and a Java drag >> source provides it? Currently if native doesn't support a URI list >> format, you won't be able to do inter-JVM and Java->native URI list >> transfers, only the local files in those URIs will go through and be >> seen as a file list by the other side. Out of Windows, X11, and Motif, >> in my patch currently only X11 supports them :-(. I haven't been able >> to find proper URI list support in Windows, most of the fancy shell >> clipboard types that can transfer URLs and such, seem to only transfer >> 1 item instead of a list. >> >> Otherwise I've tested dragging files between Java and Gnome's >> Nautilus, in both directions. It works well :-). >> >> Thoughts? Suggestions? >> >> Bye >> Damjan >> >> > > -- Alla Redko Technical Writer Sun Microsystems, Inc. Sun Internal: x33361 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20080605/4405848a/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: Alla_Redko.vcf Type: text/x-vcard Size: 135 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20080605/4405848a/attachment.vcf From yuri.nesterenko at sun.com Wed Jun 11 01:44:43 2008 From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com) Date: Wed, 11 Jun 2008 08:44:43 +0000 Subject: hg: jdk7/awt: Added tag jdk7-b28 for changeset 56652b46f328 Message-ID: <20080611084443.48AE928874@hg.openjdk.java.net> Changeset: 8fc9d057bd12 Author: xdono Date: 2008-06-10 10:16 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/rev/8fc9d057bd12 Added tag jdk7-b28 for changeset 56652b46f328 ! .hgtags From yuri.nesterenko at sun.com Wed Jun 11 01:45:40 2008 From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com) Date: Wed, 11 Jun 2008 08:45:40 +0000 Subject: hg: jdk7/awt/corba: Added tag jdk7-b28 for changeset 27509b7d21ed Message-ID: <20080611084542.5EBCD28879@hg.openjdk.java.net> Changeset: c4dd5b7198b0 Author: xdono Date: 2008-06-10 10:17 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/corba/rev/c4dd5b7198b0 Added tag jdk7-b28 for changeset 27509b7d21ed ! .hgtags From yuri.nesterenko at sun.com Wed Jun 11 01:47:27 2008 From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com) Date: Wed, 11 Jun 2008 08:47:27 +0000 Subject: hg: jdk7/awt/hotspot: Added tag jdk7-b28 for changeset c14dab40ed9b Message-ID: <20080611084730.A30072887E@hg.openjdk.java.net> Changeset: abe7181cbe8a Author: xdono Date: 2008-06-10 10:22 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/abe7181cbe8a Added tag jdk7-b28 for changeset c14dab40ed9b ! .hgtags From yuri.nesterenko at sun.com Wed Jun 11 01:49:15 2008 From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com) Date: Wed, 11 Jun 2008 08:49:15 +0000 Subject: hg: jdk7/awt/jaxp: Added tag jdk7-b28 for changeset b996318955c0 Message-ID: <20080611084917.A2AFD28883@hg.openjdk.java.net> Changeset: 617ee8607cfd Author: xdono Date: 2008-06-10 10:27 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/617ee8607cfd Added tag jdk7-b28 for changeset b996318955c0 ! .hgtags From yuri.nesterenko at sun.com Wed Jun 11 01:50:15 2008 From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com) Date: Wed, 11 Jun 2008 08:50:15 +0000 Subject: hg: jdk7/awt/jaxws: Added tag jdk7-b28 for changeset eefcd5204500 Message-ID: <20080611085017.F388D28888@hg.openjdk.java.net> Changeset: 836c55713aba Author: xdono Date: 2008-06-10 10:28 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/836c55713aba Added tag jdk7-b28 for changeset eefcd5204500 ! .hgtags From yuri.nesterenko at sun.com Wed Jun 11 01:53:33 2008 From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com) Date: Wed, 11 Jun 2008 08:53:33 +0000 Subject: hg: jdk7/awt/jdk: 53 new changesets Message-ID: <20080611090420.8B6252888D@hg.openjdk.java.net> Changeset: 94ded5c8cfba Author: emcmanus Date: 2008-05-14 18:38 +0200 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/94ded5c8cfba 6701459: Synchronization bug pattern found in javax.management.relation.RelationService Summary: Fixed this and many other problems found by FindBugs. Reviewed-by: dfuchs ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java ! src/share/classes/com/sun/jmx/mbeanserver/Repository.java ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/security/FileLoginModule.java ! src/share/classes/com/sun/jmx/remote/security/JMXPluggableAuthenticator.java ! src/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java ! src/share/classes/javax/management/NumericValueExp.java ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/StandardMBean.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/loading/MLetParser.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfoSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanOperationInfo.java ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/monitor/CounterMonitor.java ! src/share/classes/javax/management/monitor/GaugeMonitor.java ! src/share/classes/javax/management/monitor/Monitor.java ! src/share/classes/javax/management/openmbean/ArrayType.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanConstructorInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanInfoSupport.java ! src/share/classes/javax/management/openmbean/SimpleType.java ! src/share/classes/javax/management/openmbean/TabularType.java ! src/share/classes/javax/management/relation/RelationNotification.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationSupport.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/JMXServiceURL.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/timer/Timer.java Changeset: 1483094a7c17 Author: emcmanus Date: 2008-05-16 11:34 +0200 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/1483094a7c17 6703552: Missing files from changeset for 6701459 Summary: Previous push missed a small number of files. Reviewed-by: dfuchs ! src/share/classes/javax/management/openmbean/OpenMBeanOperationInfoSupport.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/timer/Timer.java + test/javax/management/relation/RelationNotificationSeqNoTest.java Changeset: a36a7f0f11ec Author: tbell Date: 2008-05-22 15:58 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/a36a7f0f11ec Merge Changeset: cbd182c404d8 Author: tbell Date: 2008-05-23 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/cbd182c404d8 Merge Changeset: 7971bbb6dc42 Author: ohair Date: 2008-05-15 13:04 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/7971bbb6dc42 6590549: Cygwin build of OpenJDK has problems and not very well documented Summary: Just the Makefile changes to fix a cygwin nawk BINMODE=w problem. Reviewed-by: igor, tbell ! make/common/shared/Defs-utils.gmk ! make/java/java/Makefile ! make/java/nio/Makefile Changeset: b6601ba7f6df Author: xdono Date: 2008-05-27 17:18 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/b6601ba7f6df Merge Changeset: 52f4ad84d5f0 Author: prr Date: 2008-03-07 12:13 -0800 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/52f4ad84d5f0 6640532: Graphics.getFontMetrics() throws NullPointerException Summary: NIO usage needs to be robust against Thread.interrupt() Reviewed-by: tdv ! src/share/classes/sun/font/FontManager.java + test/java/awt/font/Threads/FontThread.java Changeset: 73d443d6c863 Author: prr Date: 2008-04-09 13:11 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/73d443d6c863 6683472: Incorrect handling of translation component of font transform. Reviewed-by: igor, campbell ! src/share/classes/sun/font/AttributeValues.java + test/java/awt/Graphics2D/DrawString/RotTransText.java Changeset: cae9799d0810 Author: prr Date: 2008-04-10 09:05 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/cae9799d0810 6684056: SUPERSCRIPT TextAttribute on font needs to trigger layout. Reviewed-by: igor, campbell ! src/share/classes/java/awt/Font.java + test/java/awt/Graphics2D/DrawString/DrawStrSuper.java Changeset: e4abdd4c2303 Author: jgodinez Date: 2008-04-09 15:16 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/e4abdd4c2303 6633656: Cross platform print dialog doesn't check for orientation being unsupported. Reviewed-by: prr, tdv ! src/share/classes/sun/print/ServiceDialog.java ! src/solaris/classes/sun/print/AttributeClass.java ! src/solaris/classes/sun/print/IPPPrintService.java Changeset: 929bf1062f64 Author: jgodinez Date: 2008-04-10 10:23 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/929bf1062f64 Merge Changeset: 9785a8218fd2 Author: prr Date: 2008-04-10 10:31 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/9785a8218fd2 6638477: Two external URLS referenced in 2D documentation are no longer functioning. Reviewed-by: jgodinez ! src/share/classes/java/awt/font/OpenType.java ! src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java Changeset: bda7549ac1d0 Author: prr Date: 2008-04-10 10:32 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/bda7549ac1d0 Merge Changeset: 91087975bff7 Author: prr Date: 2008-04-10 16:28 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/91087975bff7 6662775: Move imaging and color classes from closed to open Reviewed-by: tdv, campbell ! make/common/internal/BinaryPlugs.gmk ! make/java/awt/Makefile + src/share/classes/java/awt/color/CMMException.java + src/share/classes/java/awt/color/ColorSpace.java + src/share/classes/java/awt/color/ICC_ColorSpace.java + src/share/classes/java/awt/color/ICC_Profile.java + src/share/classes/java/awt/color/ICC_ProfileGray.java + src/share/classes/java/awt/color/ICC_ProfileRGB.java + src/share/classes/java/awt/image/BandedSampleModel.java + src/share/classes/java/awt/image/ColorConvertOp.java + src/share/classes/java/awt/image/ComponentSampleModel.java + src/share/classes/java/awt/image/DataBuffer.java + src/share/classes/java/awt/image/DataBufferByte.java + src/share/classes/java/awt/image/DataBufferInt.java + src/share/classes/java/awt/image/DataBufferShort.java + src/share/classes/java/awt/image/DataBufferUShort.java + src/share/classes/java/awt/image/MultiPixelPackedSampleModel.java + src/share/classes/java/awt/image/Raster.java + src/share/classes/java/awt/image/RenderedImage.java + src/share/classes/java/awt/image/SampleModel.java + src/share/classes/java/awt/image/SinglePixelPackedSampleModel.java + src/share/classes/java/awt/image/WritableRaster.java + src/share/classes/java/awt/image/WritableRenderedImage.java + src/share/classes/java/awt/image/renderable/ContextualRenderedImageFactory.java + src/share/classes/java/awt/image/renderable/RenderContext.java + src/share/classes/java/awt/image/renderable/RenderableImage.java + src/share/classes/java/awt/image/renderable/RenderableImageOp.java + src/share/classes/java/awt/image/renderable/RenderableImageProducer.java + src/share/classes/java/awt/image/renderable/RenderedImageFactory.java Changeset: 7148e1f2d7c7 Author: lana Date: 2008-04-10 15:50 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/7148e1f2d7c7 Merge Changeset: aaa5637a841d Author: lana Date: 2008-04-10 18:31 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/aaa5637a841d Merge Changeset: 99f3a382f574 Author: jgodinez Date: 2008-04-10 13:57 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/99f3a382f574 6678161: Printing to remote non-Postscript printer does not work in Linux Reviewed-by: prr, tdv ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: 90e1f09ce553 Author: jgodinez Date: 2008-04-14 11:34 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/90e1f09ce553 Merge Changeset: 804b0757d801 Author: prr Date: 2008-04-24 11:58 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/804b0757d801 6523403: Need to provide lcms library with PYCC and LINEAR_RGB OS ICC profiles Summary: Add two contributed profiles and a fix to GRAY.pf, all from Redhat, keiths at redhat.com contributed the GRAY.pf fix. Reviewed-by: jgodinez, avu, prr Contributed-by: aph at redhat.com ! make/sun/cmm/Makefile ! src/share/lib/cmm/lcms/GRAY.pf + src/share/lib/cmm/lcms/LINEAR_RGB.pf + src/share/lib/cmm/lcms/PYCC.pf ! test/sun/java2d/cmm/ProfileOp/ReadProfileTest.java Changeset: ff8302a9936b Author: prr Date: 2008-04-25 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/ff8302a9936b 6687298: Reg testcase java/awt/Graphics2D/DrawString/RotTransText.java fails on windows Reviewed-by: igor, tdv ! test/java/awt/Graphics2D/DrawString/RotTransText.java Changeset: 94d65e427402 Author: prr Date: 2008-04-25 10:40 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/94d65e427402 6692979: VM Crash when shearing text + rect over a range of values Reviewed-by: igor, tdv ! src/share/classes/sun/font/FileFontStrike.java + test/java/awt/font/Rotate/Shear.java Changeset: 48b7638b8e69 Author: prr Date: 2008-04-28 09:59 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/48b7638b8e69 6694480: Two small inefficiencies in getting font strikes for transformed fonts Reviewed-by: igor, tdv ! src/share/classes/java/awt/Font.java ! src/share/classes/sun/font/Font2D.java Changeset: f50304904b8f Author: prr Date: 2008-04-28 11:06 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/f50304904b8f 6664915: SecurityException using javax.print APIs when queuePrintJob permission is granted. Reviewed-by: tdv, jgodinez ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java + test/javax/print/PrintSE/PrintSE.java + test/javax/print/PrintSE/PrintSE.sh Changeset: d7accc312aec Author: prr Date: 2008-04-28 15:57 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d7accc312aec 6679308: Poor text rendering on translucent image. Reviewed-by: flar, campbell ! src/share/native/sun/java2d/loops/AlphaMacros.h ! src/share/native/sun/java2d/loops/ByteGray.h ! src/share/native/sun/java2d/loops/FourByteAbgr.h ! src/share/native/sun/java2d/loops/FourByteAbgrPre.h ! src/share/native/sun/java2d/loops/Index12Gray.h ! src/share/native/sun/java2d/loops/Index8Gray.h ! src/share/native/sun/java2d/loops/IntArgb.h ! src/share/native/sun/java2d/loops/IntArgbBm.h ! src/share/native/sun/java2d/loops/IntArgbPre.h ! src/share/native/sun/java2d/loops/IntBgr.h ! src/share/native/sun/java2d/loops/IntRgb.h ! src/share/native/sun/java2d/loops/IntRgbx.h ! src/share/native/sun/java2d/loops/LoopMacros.h ! src/share/native/sun/java2d/loops/ThreeByteBgr.h ! src/share/native/sun/java2d/loops/Ushort4444Argb.h ! src/share/native/sun/java2d/loops/Ushort555Rgb.h ! src/share/native/sun/java2d/loops/Ushort555Rgbx.h ! src/share/native/sun/java2d/loops/Ushort565Rgb.h ! src/share/native/sun/java2d/loops/UshortGray.h ! src/solaris/native/sun/java2d/loops/vis_FourByteAbgr.c ! src/solaris/native/sun/java2d/loops/vis_FourByteAbgrPre.c ! src/solaris/native/sun/java2d/loops/vis_IntArgb.c ! src/solaris/native/sun/java2d/loops/vis_IntArgbPre.c + test/java/awt/Graphics2D/DrawString/AlphaSurfaceText.java Changeset: 55e6548451df Author: prr Date: 2008-04-30 13:10 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/55e6548451df 6656651: Windows Look and Feel LCD glyph images have some differences from native applications. Reviewed-by: igor, tdv ! make/sun/font/FILES_c.gmk ! make/sun/font/Makefile ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java + src/windows/native/sun/font/lcdglyph.c + test/java/awt/Graphics2D/DrawString/ScaledLCDTextMetrics.java Changeset: fb61ff1cc5fd Author: prr Date: 2008-05-13 16:18 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/fb61ff1cc5fd 6699843: IllegalArgumentException when using Graphics.drawString( "", 0, 0 ) Reviewed-by: igor, tdv ! src/share/classes/sun/java2d/SunGraphics2D.java + test/java/awt/Graphics2D/DrawString/EmptyAttrString.java Changeset: 11a35970b90e Author: tdv Date: 2008-05-13 16:46 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/11a35970b90e 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above Summary: improve the check for full exclusive screen support by analyzing RANDR extension version Reviewed-by: tdv, prr Contributed-by: Dan Munckton ! src/solaris/native/sun/awt/awt_GraphicsEnv.c Changeset: 57bcfeb3d8d8 Author: prr Date: 2008-05-13 16:49 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/57bcfeb3d8d8 6696292: Printing transformed images accuracy problems Reviewed-by: jgodinez, igor ! src/share/classes/sun/print/PSPathGraphics.java ! src/windows/classes/sun/awt/windows/WPathGraphics.java Changeset: 4092c04aeae7 Author: prr Date: 2008-05-13 16:56 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/4092c04aeae7 6697721: OpenJDK: rotated text baseline different between TextLayout and drawString Reviewed-by: prr, igor Contributed-by: dougfelt at yahoo.com ! src/share/native/sun/font/freetypeScaler.c ! test/java/awt/Graphics2D/DrawString/RotTransText.java Changeset: be7daefad89f Author: prr Date: 2008-05-13 16:57 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/be7daefad89f Merge Changeset: ed68352f7e42 Author: tdv Date: 2008-05-14 09:16 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/ed68352f7e42 6604044: java crashes talking to second X screen Reviewed-by: prr ! src/solaris/native/sun/awt/awt_GraphicsEnv.c Changeset: 4af4867ed787 Author: tdv Date: 2008-05-14 16:05 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/4af4867ed787 6675596: SurfaceManagerFactory should allow plugging in different implementations Reviewed-by: tdv, campbell Contributed-by: Roman Kennke ! src/share/classes/sun/awt/image/SunVolatileImage.java + src/share/classes/sun/java2d/SurfaceManagerFactory.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java - src/solaris/classes/sun/java2d/SurfaceManagerFactory.java + src/solaris/classes/sun/java2d/UnixSurfaceManagerFactory.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java - src/windows/classes/sun/java2d/SurfaceManagerFactory.java + src/windows/classes/sun/java2d/WindowsSurfaceManagerFactory.java Changeset: bf2c66511d1b Author: igor Date: 2008-05-16 03:10 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/bf2c66511d1b 6630501: CRASH: JCK test eats much memory and jvm crashes Reviewed-by: bae, prr ! src/share/classes/sun/font/Type1Font.java Changeset: 075152aa892e Author: prr Date: 2008-05-19 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/075152aa892e 6611637: NullPointerException in sun.font.GlyphLayout$EngineRecord.init Reviewed-by: tdv, jgodinez ! src/share/classes/sun/font/GlyphLayout.java Changeset: 41470017e42f Author: prr Date: 2008-05-19 15:33 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/41470017e42f Merge ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/java2d/SunGraphics2D.java Changeset: 7fba83f5f5e0 Author: igor Date: 2008-05-21 10:59 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/7fba83f5f5e0 6703377: freetype: glyph vector outline is not translated correctly Reviewed-by: bae, prr ! src/share/native/sun/font/freetypeScaler.c + test/java/awt/font/Rotate/TranslatedOutlineTest.java Changeset: 02e4c5348592 Author: lana Date: 2008-06-03 11:18 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/02e4c5348592 Merge Changeset: b64e68bf6b0b Author: dfuchs Date: 2008-05-29 15:33 +0200 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/b64e68bf6b0b 6673853: LegacyIntrospectorTest is testing an old deprecated com.sun API not present in OpenJDK. Summary: Removed test from open test suite - the corresponding deprecated legacy API is not in open source tree Reviewed-by: emcmanus - test/javax/management/Introspector/LegacyIntrospectorTest.java Changeset: 6ca4564520e7 Author: dfuchs Date: 2008-05-30 14:35 +0200 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/6ca4564520e7 6592586: RequiredModelMBean prints a WARNING message when calling getAttributes() for a non-existing attr Summary: Switched traces to FINER - except when logging fails - in which cases the traces are logged to FINE Reviewed-by: emcmanus ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java Changeset: ca48d7cc3579 Author: chegar Date: 2008-05-15 10:26 +0100 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/ca48d7cc3579 6670408: testcase panics 1.5.0_12&_14 JVM when java.net.PlainSocketImpl trying to throw an exception Summary: Replace select with poll Reviewed-by: alanb, jccollet ! src/solaris/native/java/net/PlainSocketImpl.c Changeset: 2ebefcea77a5 Author: vinnie Date: 2008-05-14 18:59 +0100 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/2ebefcea77a5 6383078: OCSP checking does not work on end-entity certificate Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/OCSPChecker.java Changeset: 49f02cbe27b1 Author: vinnie Date: 2008-05-15 10:55 +0100 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/49f02cbe27b1 Merge Changeset: d3dfeb4295b3 Author: wetmore Date: 2008-05-17 00:27 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d3dfeb4295b3 Merge Changeset: f8049c6ff629 Author: wetmore Date: 2008-05-22 14:20 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/f8049c6ff629 6706358: jdk/test/sun/security/pkcs11/Cipher/TestSymmCiphers.java has the wrong copyright notice. Reviewed-by: valeriep ! test/sun/security/pkcs11/Cipher/TestSymmCiphers.java Changeset: ead7a5f601d5 Author: weijun Date: 2008-05-27 14:29 +0800 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/ead7a5f601d5 6705313: Incorrect exit $? in keytool's autotest.sh Reviewed-by: valeriep ! test/sun/security/tools/keytool/autotest.sh Changeset: 827f9f3d1031 Author: wetmore Date: 2008-06-02 10:16 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/827f9f3d1031 Merge Changeset: 2d5d4282d0fa Author: tbell Date: 2008-06-02 22:33 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/2d5d4282d0fa Merge Changeset: 49c3399ca7b8 Author: tbell Date: 2008-06-05 17:43 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/49c3399ca7b8 Merge - src/solaris/classes/sun/java2d/SurfaceManagerFactory.java - src/windows/classes/sun/java2d/SurfaceManagerFactory.java Changeset: 45e53cb21dad Author: xdono Date: 2008-06-10 10:33 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/45e53cb21dad Added tag jdk7-b28 for changeset 02e4c5348592 ! .hgtags Changeset: bb99fb855bdc Author: yan Date: 2008-05-30 03:02 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/bb99fb855bdc Merge Changeset: 9ab7e41b205b Author: yan Date: 2008-06-09 06:31 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/9ab7e41b205b Merge - src/solaris/classes/sun/java2d/SurfaceManagerFactory.java - src/windows/classes/sun/java2d/SurfaceManagerFactory.java - test/javax/management/Introspector/LegacyIntrospectorTest.java Changeset: 906a396bff74 Author: yan Date: 2008-06-10 13:42 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/906a396bff74 Merge Changeset: 58a2ba2767be Author: yan Date: 2008-06-11 01:31 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/58a2ba2767be Merge - src/solaris/classes/sun/java2d/SurfaceManagerFactory.java - src/windows/classes/sun/java2d/SurfaceManagerFactory.java - test/javax/management/Introspector/LegacyIntrospectorTest.java From yuri.nesterenko at sun.com Wed Jun 11 02:09:55 2008 From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com) Date: Wed, 11 Jun 2008 09:09:55 +0000 Subject: hg: jdk7/awt/langtools: 9 new changesets Message-ID: <20080611091010.3DBEA28892@hg.openjdk.java.net> Changeset: 58e352559a41 Author: jjg Date: 2008-05-22 15:51 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/langtools/rev/58e352559a41 6705945: com.sun.tools.javac.zip files do not have valid copyright Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/zip/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/zip/ZipFileIndexEntry.java Changeset: b8c8259e0d2b Author: jjg Date: 2008-05-22 16:06 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/langtools/rev/b8c8259e0d2b 6657909: javap has unchecked compilation warnings Reviewed-by: mcimadamore ! src/share/classes/sun/tools/javap/ClassData.java ! src/share/classes/sun/tools/javap/FieldData.java ! src/share/classes/sun/tools/javap/InnerClassData.java ! src/share/classes/sun/tools/javap/JavapPrinter.java ! src/share/classes/sun/tools/javap/Main.java ! src/share/classes/sun/tools/javap/MethodData.java ! src/share/classes/sun/tools/javap/Tables.java ! src/share/classes/sun/tools/javap/TypeSignature.java Changeset: 65a447c75d4b Author: jjg Date: 2008-05-22 17:40 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/langtools/rev/65a447c75d4b 6705935: javac reports path name of entry in ZipFileIndex incorectly Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/util/JavacFileManager.java ! test/tools/javac/6589361/T6589361.java + test/tools/javac/T6705935.java Changeset: ff3d4fdf9c63 Author: tbell Date: 2008-05-28 00:02 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/langtools/rev/ff3d4fdf9c63 Merge Changeset: 8852d96b593b Author: mcimadamore Date: 2008-05-30 10:29 +0100 URL: http://hg.openjdk.java.net/jdk7/awt/langtools/rev/8852d96b593b 6665223: Static import of inherited protected method causes compiler exception Summary: Buggy accessibility check causes NPE during resolution of imported static methods Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/staticImport/6665223/T6665223.java + test/tools/javac/staticImport/6665223/pkg/A.java + test/tools/javac/staticImport/6665223/pkg/B.java Changeset: 6e9a43815df7 Author: mcimadamore Date: 2008-05-30 10:42 +0100 URL: http://hg.openjdk.java.net/jdk7/awt/langtools/rev/6e9a43815df7 6507024: casting an array to a generic type results in a 'capture#69 of ?' type error Summary: Types.isSubtypeUnchecked() should handle type-variables subtyping properly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/T6507024.java Changeset: f7e64b33d5a4 Author: mcimadamore Date: 2008-05-30 11:08 +0100 URL: http://hg.openjdk.java.net/jdk7/awt/langtools/rev/f7e64b33d5a4 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors Summary: This regression has been caused by previous fix of 6660289 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/6677785/T6677785.java + test/tools/javac/generics/6677785/T6677785.out Changeset: fc780e96a16a Author: tbell Date: 2008-06-02 22:35 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/langtools/rev/fc780e96a16a Merge Changeset: dec081837b01 Author: xdono Date: 2008-06-10 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/awt/langtools/rev/dec081837b01 Added tag jdk7-b28 for changeset 4ef4bd318569 ! .hgtags From damjan.jov at gmail.com Sat Jun 14 09:17:38 2008 From: damjan.jov at gmail.com (Damjan Jovanovic) Date: Sat, 14 Jun 2008 18:17:38 +0200 Subject: 4899516: Transferable has no DataFlavors when dragging from Gnome window to Swing In-Reply-To: <4846CB62.3010805@sun.com> References: <9e89675b0709242121x3f5fcd44n3323ff7f3991b56f@mail.gmail.com> <46F91E6C.7050205@Sun.com> <9e89675b0709250831o122dcb37l275bad7146c6ddc3@mail.gmail.com> <46F93531.8070102@Sun.com> <9e89675b0709260120t3856e4ddr32ee816c8f6b338a@mail.gmail.com> <46FB6B3F.50106@Sun.com> <9e89675b0709302341q9645050o249c4591c725d730@mail.gmail.com> <47013435.3000707@sun.com> <9e89675b0805140634t4794d778i46e21ce47563771a@mail.gmail.com> <4846CB62.3010805@sun.com> Message-ID: <9e89675b0806140917k53d37667j18bd3b3b2dd52f15@mail.gmail.com> Hi Here's the second attempt. On Wed, Jun 4, 2008 at 7:05 PM, Denis S. Fokin wrote: > Hi Damjan, > > I have some thoughts (sorry for the delay). > > At first, I like your prototype. Thank you for your efforts. > > So some ideas and notes are bellow. > > 1. > The first idea is we should not return an empty List list. The > better approach would be if we do not publish javaFileListFlavor data > flavor. In that case we have to analyze content of the URI list and > decide whether we can provide all URIs as files. If we cannot, user on > target must not receive javaFileListFlavor data flavor at all. Only > javaURIListFlavor. Ok, I've added code to not publish a file list format to native when Java is the drag source, and the Java URI list can't be losslessly converted to a local file list. But, that means we have to call Transferable.getTransferData() more than once during the same transfer because it's now also called before the transfer has been accepted by the drop target, maybe that should be documented. It's not clear whether the opposite conversion (native URI list -> Java file list) can be done safely; we'd have to request the data from native at least once before the transfer has been accepted and I'm not sure all platforms and applications support/like that. Currently you'll get an empty file list. > 2. > Some consideration about JavaDoc > > ******** DataFlavor.java *********** > > + /** > + * To transfer a list of files and/or URIs to/from Java (and > + * the underlying platform) a DataFlavor of this > + * type/subtype and representation class of > + * java.util.List is used. Each element of this > + * list is required/guaranteed to be of type > + * java.net.URI. > + *