<AWT Dev> [PATCH] Cleanup AWT peer interfaces
Andrei V. Dmitriev
Andrei.Dmitriev at Sun.COM
Fri Sep 19 07:22:00 PDT 2008
I'd like to see them separated as we are in the process of reviewing
the peers cleanup already.
Roman Kennke wrote:
>> I found that reasonable since the very first time evaluated the cacio
>> code. Though this patch probably requires more time to get reviewed...
> So? We do it in a separate review&push or we put both (the peer cleanup
> and the documentation) together?
>> Roman Kennke wrote:
>>> Hi Andrei,
>>>>> Yeah sure. I reviewed all the existing implementations and they should
>>>>> not break, but a lot of stuff could be removed.
>>>> Just appeared to public access:
>>> Cool. BTW, I have another patch for the peer interfaces in the Cacio
>>> repo, that one adds API docs to all the interfaces. Nothing serious,
>>> only roughly what it does (this might be obvious by the method names
>>> anyway) and pointers to where it is used in AWT (I found this important
>>> for implementing the peers, so that people can look up the nitty gritty
>>> details themselves). In the projects I was involved in so far we had
>>> policies to separate code changes from doc and formatting changes, but I
>>> don't know how this is handled in OpenJDK. Maybe we want to push these
>>> together. Find this doc patch attached (this follows up on the
>>> cleanpeers patch, will not apply on clean OpenJDK!)
>>> Cheers, Roman
More information about the awt-dev