From kelly.ohair at oracle.com  Tue May  1 15:19:04 2012
From: kelly.ohair at oracle.com (Kelly Ohair)
Date: Tue, 1 May 2012 15:19:04 -0700
Subject: <AWT Dev> [OpenJDK 2D-Dev] Request for Review: Remove import of
	empty JNI header files
In-Reply-To: <4F98FAD2.7030808@oracle.com>
References: <4F97FFC3.3090509@oracle.com> <4F9817D6.8080701@oracle.com>
	<4F989F8F.6000905@oracle.com> <4F98FAD2.7030808@oracle.com>
Message-ID: <5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com>

Magnus,

Do you still need this integrated?
I can integrate the exact same changset to awt, 2d,  and build forests if you want.

-kto


Sent from my iPhone

On Apr 26, 2012, at 0:35, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:

> On 2012-04-26 03:06, Jim Graham wrote:
>> Can we remove these "empty JNI" classes from a list of "javah" classes somewhere so that we don't waste time generating the empty JNI headers?
> 
> Good idea -- that's exactly what is being done in the new build system (the build-infra project)! :-)
> 
> We added a new option to javac, which generates JNI headers automatically, if they are needed -- basically, if the class contains native methods *). So header generation is made always when needed and only when needed, quickly and as  a part of normal compilation.
> 
> Since these classes didn't have any native methods, the header files were not generated, and the compile of the native code failed since the #include pointed to non-exisiting files.
> 
> *) Actually, sometimes classes with constants but without native methods are needed. In this case, the new annotation @GenerateNativeHeader is needed.
> 
> /Magnus


From dmitry.cherepanov at oracle.com  Wed May  2 02:49:28 2012
From: dmitry.cherepanov at oracle.com (dmitry.cherepanov at oracle.com)
Date: Wed, 02 May 2012 09:49:28 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7154062: [macosx] Mouse cursor isn't
	updated in	applets
Message-ID: <20120502095010.DDF41470E0@hg.openjdk.java.net>

Changeset: bbbf4e63562b
Author:    dcherepanov
Date:      2012-05-02 13:53 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bbbf4e63562b

7154062: [macosx] Mouse cursor isn't updated in applets
Reviewed-by: anthony, art

! src/macosx/classes/sun/lwawt/macosx/CCursorManager.java
! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java
! src/macosx/native/sun/awt/CCursorManager.m



From leonid.romanov at oracle.com  Wed May  2 04:37:33 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Wed, 2 May 2012 15:37:33 +0400
Subject: <AWT Dev> Request for review: 7154048 [macosx] At least drag
	twice, the toolbar can be dragged to the left side.
In-Reply-To: <4F99520B.4020704@oracle.com>
References: <4F8EE086.2090809@oracle.com> <4F900FAF.6070104@oracle.com>
	<4F953825.20508@oracle.com>
	<8600BFDB-9091-4F9C-93A9-7F29B42CC5AD@oracle.com>
	<4F968CF5.4050500@oracle.com>
	<3836447A-4013-4135-9F80-B80155D86A8B@oracle.com>
	<4F99520B.4020704@oracle.com>
Message-ID: <B4983212-AF80-431F-A1D4-32430533C074@oracle.com>

Thanks! I'm OK with the fix.

On 26.04.2012, at 17:47, Alexander Scherbatiy wrote:

> On 4/25/2012 2:46 PM, Leonid Romanov wrote:
>> it is not obvious what isTopmostWindowUnderMouse is supposed to check without reading its source code.
>> It would be great if you could add a brief comment describing method's purpose. Otherwise, the fix looks good.
> 
>   I have added the following comment:
>   // checks that this window is under the mouse cursor and this point is not overlapped by others windows
> 
>    Here is the updated version:
>    http://cr.openjdk.java.net/~alexsch/7154048/webrev.03/
> 
>   Thanks,
>   Alexandr.
> 
>> On 24.04.2012, at 15:22, Alexander Scherbatiy wrote:
>> 
>>> On 4/23/2012 7:39 PM, Leonid Romanov wrote:
>>>> Hi,
>>>> I can't find where you set initial value of mouseIsOver variable. Does Objective-C guarantee that it gets some defined default value?
>>>    I really missed this part.
>>> 
>>>    Please review the new version:
>>>      http://cr.openjdk.java.net/~alexsch/7154048/webrev.02/
>>> 
>>>    The only thing that is changed is the initialization of the mouseIsOver variable to false in the -initWithRect: method of the AWTView class.
>>> 
>>>   Thanks,
>>>   Alexandr.
>>> 
>>>> On 23.04.2012, at 15:08, Alexander Scherbatiy wrote:
>>>> 
>>>>> Thank you for the review.
>>>>> 
>>>>> Here is the new version:
>>>>>  http://cr.openjdk.java.net/~alexsch/7154048/webrev.01/
>>>>> 
>>>>> 1. The synthesizeMouseEnteredExitedEvents method is added as a native method to the CPlatformWindow class.
>>>>>   Now it is invoked only in places that programmatically  change a window size:
>>>>>     - nativeSetNSWindowBounds method from the AWTWindow
>>>>>     - setVisible and setWindowState methods from the CPlatformWindow
>>>>> 
>>>>> 2. The objective-c code is formatted.
>>>>> 
>>>>> 3.  I do not think that setting the lastMouseEventPeer after sending the MOUSE_ENTERED event in the LWWindowPeer class  can affect some logic in the peer.
>>>>>    The postEvent method just post the MOUSE_ENTERED events to the queue. It does not use the lastMouseEventPeer variable and there is no a recursion that invokes the dispatchMouseEvent method again.
>>>>> 
>>>>> 4. Dragging a window under a panel should not generate mouse entered/exited events for components. However the events should be generated if the window is moved out of the frame or moved in to the frame. So one more condition that checks is the mouse crosess the frame borders are added to the  dispatchMouseEvent method from the LWWindowPeer class.
>>>>> The DragWindowOutOfFrameTest test is added that  these events are properly generated.
>>>>> 
>>>>> Thanks,
>>>>> Alexandr.
>>>>> 
>>>>> On 4/19/2012 5:14 PM, Anthony Petrov wrote:
>>>>>> Hi Alexander,
>>>>>> 
>>>>>> 1. I don't think that it's a good idea to add synthesizeMouseEnteredExitedEvents calls to CWrapper methods. These methods are supposed to perform direct calls to Cocoa API w/o any side-effects. They may be used for windows that even aren't AWT windows, and as such sending them the synthesizeMouseEnteredExitedEvents message is useless, and just doesn't seem right from CWrapper's purpose perspective. You may want to introduce CPlatformWindow._synthesizeMouseEnteredExitedEvents() native method that would call this native method, and then add a call to it where needed in Java code.
>>>>>> 
>>>>>> 2. Please follow formatting guidelines and reformat lines like this:
>>>>>> 
>>>>>>> if(id != MouseEvent.MOUSE_DRAGGED){
>>>>>> to read as
>>>>>> 
>>>>>> if (id != MouseEvent.MOUSE_DRAGGED) {
>>>>>> 
>>>>>> instead. I see lots of such mis-formatted if() statements all over your code.
>>>>>> 
>>>>>> 3. In LWWindowPeer.java you are now setting the lastMouseEventPeer after sending the MOUSE_ENTERED event. Before your fix it's been set earlier. Can this change affect some logic in the peer code while processing ENTERED events at a user event handler?
>>>>>> 
>>>>>> -- 
>>>>>> best regards,
>>>>>> Anthony
>>>>>> 
>>>>>> On 04/18/12 19:40, Alexander Scherbatiy wrote:
>>>>>>> Please review a fix for CR 7154048.
>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154048
>>>>>>> 
>>>>>>> webrev: http://cr.openjdk.java.net/~alexsch/7154048/webrev.00/
>>>>>>> 
>>>>>>> Let's see the following test case:
>>>>>>> - Frame contains two components JLabel and JButton
>>>>>>> - The JLabel component has a mouse listener
>>>>>>> mousePressed: create a Window under the mouse click
>>>>>>> mouseDragged: drag the created window
>>>>>>> mouseReleased: close the Window
>>>>>>> - A user clicks on the JLabel component, drags the mouse to the JButton
>>>>>>> component and releases the mouse button
>>>>>>> 
>>>>>>> The current JDK 8 implementation shows the following events on Mac OS X:
>>>>>>> --------------------------------------------------------
>>>>>>> mouse pressed: javax.swing.JLabel
>>>>>>> mouse exited: javax.swing.JLabel
>>>>>>> mouse entered: javax.swing.JLabel
>>>>>>> mouse dragged: javax.swing.JLabel
>>>>>>> mouse exited: javax.swing.JLabel
>>>>>>> mouse entered: javax.swing.JButton
>>>>>>> mouse dragged: javax.swing.JLabel
>>>>>>> mouse exited: javax.swing.JButton
>>>>>>> mouse entered: Drag Window
>>>>>>> mouse exited: Drag Window
>>>>>>> mouse entered: javax.swing.JButton
>>>>>>> mouse released: javax.swing.JButton
>>>>>>> --------------------------------------------------------
>>>>>>> 
>>>>>>> There are several issues:
>>>>>>> 1) The window does not receive the mouse entered event when it is
>>>>>>> created under the mouse
>>>>>>> 2) There are JLabel exited/JButton entered events during the window
>>>>>>> dragging
>>>>>>> 3) JLabel does not receive the mouse released event
>>>>>>> 
>>>>>>> The fix synthesizes the mouse entered/exited events manually if they are
>>>>>>> not received.
>>>>>>> 
>>>>>>> The entered/exited events synthesizing is added to setFrame, toFront,
>>>>>>> toBack, and zoom methods of the AWTWindow and CWrapper classes.
>>>>>>> 
>>>>>>> There is an option to add the events synthesizing to the windowDidResize
>>>>>>> notification. However this notification is sent when a window size is
>>>>>>> changed in both cases, programmatically and when user is resized the
>>>>>>> window. So in a lot of case there is no need for the our use case events
>>>>>>> generation.
>>>>>>> 
>>>>>>> The LWWindowPeer class is updated to not generate extra mouse enter/exit
>>>>>>> events during the mouse dragging.
>>>>>>> 
>>>>>>> Tho automated tests are added.
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> Alexandr.
> 



From dmitry.cherepanov at oracle.com  Wed May  2 04:56:46 2012
From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov)
Date: Wed, 02 May 2012 15:56:46 +0400
Subject: <AWT Dev> [7u6] Review request for 7154062: [macosx] Mouse cursor
 isn't updated in applets
Message-ID: <4FA120FE.4070002@oracle.com>

Hello,

Please review a fix for 7154062 ([macosx] Mouse cursor isn't updated in 
applets):

http://cr.openjdk.java.net/~dcherepanov/7154062/7u6/webrev.0/

The patch is a direct back-port of a fix from 8 [1].

Thanks,
Dmitry

[1] http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bbbf4e63562b



From anthony.petrov at oracle.com  Wed May  2 04:54:32 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Wed, 02 May 2012 15:54:32 +0400
Subject: <AWT Dev> [7u6] Review request for 7154062: [macosx] Mouse
 cursor isn't updated in applets
In-Reply-To: <4FA120FE.4070002@oracle.com>
References: <4FA120FE.4070002@oracle.com>
Message-ID: <4FA12078.3060303@oracle.com>

Still looks fine to me.

--
best regards,
Anthony

On 5/2/2012 3:56 PM, Dmitry Cherepanov wrote:
> Hello,
> 
> Please review a fix for 7154062 ([macosx] Mouse cursor isn't updated in 
> applets):
> 
> http://cr.openjdk.java.net/~dcherepanov/7154062/7u6/webrev.0/
> 
> The patch is a direct back-port of a fix from 8 [1].
> 
> Thanks,
> Dmitry
> 
> [1] http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bbbf4e63562b
> 


From Sergey.Bylokhov at oracle.com  Wed May  2 05:49:15 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 02 May 2012 16:49:15 +0400
Subject: <AWT Dev> [8] Request for review: 7124213: [macosx] pack() does
 ignore size of a component; doesn't on the other platforms.
In-Reply-To: <4F8EBF0B.3000100@oracle.com>
References: <4F8C31AA.5060900@oracle.com> <4F8EBF0B.3000100@oracle.com>
Message-ID: <4FA12D4B.7070701@oracle.com>

Hi, Artem.

Yes LWTextAreaPeer uses the same approach(60,10). But in the fix I 
change LWScrollPanePeer.

> Hi, Sergey,
>
> I'm fine with the fix, just curious about "... should work in the same
> way as on other platforms". Both on Windows and X11 TextArea peer's
> minimum size is calculated as the size of TextArea that consists of 10
> rows by 60 columns. What did you mean then?
>
> Thanks,


> On 4/16/2012 6:50 PM, Sergey Bylokhov wrote:
>> Hi Everyone,
>> LWScrollPanePeer.getMinimumSize() on macosx should work in the same 
>> way, as on other platforms.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124213
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7124213/webrev.00/
>>



From alexandr.scherbatiy at oracle.com  Wed May  2 06:53:17 2012
From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com)
Date: Wed, 02 May 2012 13:53:17 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7154048: [macosx] At least drag twice,
	the toolbar can be dragged to the left side
Message-ID: <20120502135351.B9985470E9@hg.openjdk.java.net>

Changeset: 0fad89bd606b
Author:    alexsch
Date:      2012-05-02 17:54 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0fad89bd606b

7154048: [macosx] At least drag twice, the toolbar can be dragged to the left side
Reviewed-by: anthony, leonidr

! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/native/sun/awt/AWTView.h
! src/macosx/native/sun/awt/AWTView.m
! src/macosx/native/sun/awt/AWTWindow.h
! src/macosx/native/sun/awt/AWTWindow.m
+ test/java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java
+ test/java/awt/Mouse/EnterExitEvents/DragWindowTest.java
+ test/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java
! test/java/awt/regtesthelpers/Util.java



From Sergey.Bylokhov at oracle.com  Wed May  2 07:33:05 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 02 May 2012 18:33:05 +0400
Subject: <AWT Dev> Objective-C  and jcheck
In-Reply-To: <20120502135351.B9985470E9@hg.openjdk.java.net>
References: <20120502135351.B9985470E9@hg.openjdk.java.net>
Message-ID: <4FA145A1.8060606@oracle.com>

Hi Everybody.
Looks like on the server we still use jcheck without fix for Objective-C 
files? Does anybody know how to apply the fix to jdk8? (see attachment)

[jdk]
pulling from http://hg.openjdk.java.net/jdk8/awt/jdk
searching for changes
adding changesets
adding manifests
adding file changes
added 1 changesets with 10 changes to 10 files
[jcheck 25e85a608db1 2011-07-08 09:19 -0700]

 > Changeset: 5305:0fad89bd606b
 > Author:    alexsch
 > Date:      2012-05-02 17:54
 >
 > 7154048: [macosx] At least drag twice, the toolbar can be dragged to 
the left
side
 > Reviewed-by: anthony, leonidr

src/macosx/native/sun/awt/AWTView.m:84: Trailing whitespace
src/macosx/native/sun/awt/AWTWindow.m:173: Trailing whitespace

transaction abort!
rollback completed
skipped: pretxnchangegroup.jcheck hook failed

02.05.2012 17:53, alexandr.scherbatiy at oracle.com wrote
> Changeset: 0fad89bd606b
> Author:    alexsch
> Date:      2012-05-02 17:54 +0400
> URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0fad89bd606b
>
> 7154048: [macosx] At least drag twice, the toolbar can be dragged to the left side
> Reviewed-by: anthony, leonidr
>
> ! src/macosx/classes/sun/lwawt/LWWindowPeer.java
> ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
> ! src/macosx/native/sun/awt/AWTView.h
> ! src/macosx/native/sun/awt/AWTView.m
> ! src/macosx/native/sun/awt/AWTWindow.h
> ! src/macosx/native/sun/awt/AWTWindow.m
> + test/java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java
> + test/java/awt/Mouse/EnterExitEvents/DragWindowTest.java
> + test/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java
> ! test/java/awt/regtesthelpers/Util.java
>

-------------- next part --------------
An embedded message was scrubbed...
From: Scott Kovatch <scott.kovatch at oracle.com>
Subject: Objective-C files not being checked with jcheck
Date: Thu, 29 Dec 2011 09:50:08 -0800
Size: 4142
Url: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120502/a2f5489b/.nws 

From oleg.pekhovskiy at oracle.com  Wed May  2 07:39:38 2012
From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy)
Date: Wed, 02 May 2012 18:39:38 +0400
Subject: <AWT Dev> Code Review Request for CR 7146237 -
 closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html
 failed since 1.8.0b19
In-Reply-To: <4F7989DE.6030105@oracle.com>
References: <4F747B25.5000707@oracle.com> <4F7585B5.20703@oracle.com>
	<4F75DC4A.20508@oracle.com> <4F7989DE.6030105@oracle.com>
Message-ID: <4FA1472A.3070902@oracle.com>

Hi Artem, Anthony,

Please review next version of fix that includes the same changes for 
KeyboardFocusManager, Container and JComponent:
http://cr.openjdk.java.net/~bagiras/8/7146237.3/

Those changes were also approved as CCC request:
http://ccc.us.oracle.com/7146237

Thanks,
Oleg

4/2/2012 3:13 PM, Artem Ananiev wrote:
>
> Looks fine.
>
> Thanks,
>
> Artem
>
> On 3/30/2012 8:16 PM, Oleg Pekhovskiy wrote:
>> Hi Anthony,
>>
>> thank you for this clarification, I modified those places:
>> http://cr.openjdk.java.net/~bagiras/8/7146237.2
>>
>> Thanks,
>> Oleg.
>>
>> 3/30/2012 2:06 PM, Anthony Petrov wrote:
>>> Hi Oleg,
>>>
>>> The "modern" tagging approach for the javadoc is to use {@code ...}
>>> instead of <code>...</code>.
>>>
>>> Otherwise the changes look fine to me.
>>>
>>> -- 
>>> best regards,
>>> Anthony
>>>
>>> On 3/29/2012 7:09 PM, Oleg Pekhovskiy wrote:
>>>> Hi guys,
>>>>
>>>> please review these java-doc changes for:
>>>> http://bugs.sun.com/view_bug.do?bug_id=7146237
>>>>
>>>> webrev:
>>>> http://cr.openjdk.java.net/~bagiras/8/7146237.1
>>>>
>>>> Thanks,
>>>> Oleg
>>



From anthony.petrov at oracle.com  Wed May  2 07:59:36 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Wed, 02 May 2012 18:59:36 +0400
Subject: <AWT Dev> Code Review Request for CR 7146237 -
 closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html
 failed since 1.8.0b19
In-Reply-To: <4FA1472A.3070902@oracle.com>
References: <4F747B25.5000707@oracle.com>
	<4F7585B5.20703@oracle.com>	<4F75DC4A.20508@oracle.com>
	<4F7989DE.6030105@oracle.com> <4FA1472A.3070902@oracle.com>
Message-ID: <4FA14BD8.4070305@oracle.com>

Looks great.

--
best regards,
Anthony

On 5/2/2012 6:39 PM, Oleg Pekhovskiy wrote:
> Hi Artem, Anthony,
> 
> Please review next version of fix that includes the same changes for 
> KeyboardFocusManager, Container and JComponent:
> http://cr.openjdk.java.net/~bagiras/8/7146237.3/
> 
> Those changes were also approved as CCC request:
> http://ccc.us.oracle.com/7146237
> 
> Thanks,
> Oleg
> 
> 4/2/2012 3:13 PM, Artem Ananiev wrote:
>>
>> Looks fine.
>>
>> Thanks,
>>
>> Artem
>>
>> On 3/30/2012 8:16 PM, Oleg Pekhovskiy wrote:
>>> Hi Anthony,
>>>
>>> thank you for this clarification, I modified those places:
>>> http://cr.openjdk.java.net/~bagiras/8/7146237.2
>>>
>>> Thanks,
>>> Oleg.
>>>
>>> 3/30/2012 2:06 PM, Anthony Petrov wrote:
>>>> Hi Oleg,
>>>>
>>>> The "modern" tagging approach for the javadoc is to use {@code ...}
>>>> instead of <code>...</code>.
>>>>
>>>> Otherwise the changes look fine to me.
>>>>
>>>> -- 
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 3/29/2012 7:09 PM, Oleg Pekhovskiy wrote:
>>>>> Hi guys,
>>>>>
>>>>> please review these java-doc changes for:
>>>>> http://bugs.sun.com/view_bug.do?bug_id=7146237
>>>>>
>>>>> webrev:
>>>>> http://cr.openjdk.java.net/~bagiras/8/7146237.1
>>>>>
>>>>> Thanks,
>>>>> Oleg
>>>
> 


From alexander.zuev at oracle.com  Wed May  2 08:59:20 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Wed, 02 May 2012 19:59:20 +0400
Subject: <AWT Dev> [7u6] Please review my fix for 7148289: [macosx]
 Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
In-Reply-To: <4F9BCBDF.6040709@oracle.com>
References: <4F996FD3.9080702@oracle.com> <4F9ACF63.5080406@oracle.com>
	<4F9BA768.1070404@oracle.com> <4F9BCBDF.6040709@oracle.com>
Message-ID: <4FA159D8.8060803@oracle.com>

Anthony,

   finally all the servers are up and i can present the new webrev, it 
is here:
http://cr.openjdk.java.net/~kizune/7148289/webrev.01

I have renamed methods mentioned that they are nested native event loop 
controllers.

With best regards,
Alex

On 4/28/12 14:52, Anthony Petrov wrote:
> Hi Alexander,
>
> On 4/28/2012 12:16 PM, Alexander Zuev wrote:
>>   the ToolkitThreadBlockerHandler is an interface that is supposed to 
>> be used
>> when program has to wait for the event pushed to the EDT finish its 
>> task and
>> he calls like this:
>>             while (!dispatcher.isDone()) {
>>                 
>> DataTransferer.getInstance().getToolkitThreadBlockedHandler().enter();
>>             }
>> and the event handler in its unregisterEvent() method calls for 
>> handler.exit()
>> The method is supposed to make sure that waiting on the EDT doesn't 
>> create deadlocks.
>> The implementation depends on the toolkit architecture - on some 
>> toolkits it's NoOp since
>> they don't care if EDT is waiting, but in LWCToolkit our AWT 
>> components are backed by Swing
>> delegates so there are a lot of calls from native application thread 
>> to EDT and vice versa so we
>> can't afford to stop both threads. Solution is the code that makes 
>> secondary AppKit event loop
>> to handle native events so waiting on EDT will leave at least one 
>> event loop pumping.
>
> Thanks!
>
>>   The name is correct because despite the fact that we are in AWT 
>> code (LWCToolkit) we don't
>> create nested EDT loop but running nested native (AppKit) loop - 
>> hence the name: enter/exitNativeEventLoop()
>
> Since the main event loop is already spinning, I would still suggest 
> to rename it to, say, enter/exitNestedNativeEventLoop() to stress that 
> this event loop is going to be an inner loop, rather than the main 
> (outer) event loop.
>
> -- 
> best regards,
> Anthony
>
>>
>> With best regards,
>> Alex
>>
>> On 4/27/12 20:54, Anthony Petrov wrote:
>>> Hi Alexander,
>>>
>>> Could you provide some details about the ToolkitThreadBlockedHandler 
>>> interface? How is it used by the DnD code?
>>>
>>> Also, I suggest to replace the word Native with Nested in 
>>> enter/exitNativeEventLoop() method names.
>>>
>>> -- 
>>> best regards,
>>> Anthony
>>>
>>> On 4/26/2012 7:54 PM, Alexander Zuev wrote:
>>>> Hello,
>>>>
>>>>   please review my fix for the CR 7148289: [macosx] Deadlock in 
>>>> sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
>>>>
>>>>   Bug description is 
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148289
>>>>
>>>>   Fix can be found at 
>>>> http://cr.openjdk.java.net/~kizune/7148289/webrev.00
>>>>
>>>> With best regards,
>>>> Alex
>>



From anthony.petrov at oracle.com  Wed May  2 09:11:53 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Wed, 02 May 2012 20:11:53 +0400
Subject: <AWT Dev> [7u6] Please review my fix for 7148289: [macosx]
 Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
In-Reply-To: <4FA159D8.8060803@oracle.com>
References: <4F996FD3.9080702@oracle.com> <4F9ACF63.5080406@oracle.com>
	<4F9BA768.1070404@oracle.com> <4F9BCBDF.6040709@oracle.com>
	<4FA159D8.8060803@oracle.com>
Message-ID: <4FA15CC9.4010209@oracle.com>

Looks perfect. Thank you!

--
best regards,
Anthony

On 5/2/2012 7:59 PM, Alexander Zuev wrote:
> Anthony,
> 
>   finally all the servers are up and i can present the new webrev, it is 
> here:
> http://cr.openjdk.java.net/~kizune/7148289/webrev.01
> 
> I have renamed methods mentioned that they are nested native event loop 
> controllers.
> 
> With best regards,
> Alex
> 
> On 4/28/12 14:52, Anthony Petrov wrote:
>> Hi Alexander,
>>
>> On 4/28/2012 12:16 PM, Alexander Zuev wrote:
>>>   the ToolkitThreadBlockerHandler is an interface that is supposed to 
>>> be used
>>> when program has to wait for the event pushed to the EDT finish its 
>>> task and
>>> he calls like this:
>>>             while (!dispatcher.isDone()) {
>>>                 
>>> DataTransferer.getInstance().getToolkitThreadBlockedHandler().enter();
>>>             }
>>> and the event handler in its unregisterEvent() method calls for 
>>> handler.exit()
>>> The method is supposed to make sure that waiting on the EDT doesn't 
>>> create deadlocks.
>>> The implementation depends on the toolkit architecture - on some 
>>> toolkits it's NoOp since
>>> they don't care if EDT is waiting, but in LWCToolkit our AWT 
>>> components are backed by Swing
>>> delegates so there are a lot of calls from native application thread 
>>> to EDT and vice versa so we
>>> can't afford to stop both threads. Solution is the code that makes 
>>> secondary AppKit event loop
>>> to handle native events so waiting on EDT will leave at least one 
>>> event loop pumping.
>>
>> Thanks!
>>
>>>   The name is correct because despite the fact that we are in AWT 
>>> code (LWCToolkit) we don't
>>> create nested EDT loop but running nested native (AppKit) loop - 
>>> hence the name: enter/exitNativeEventLoop()
>>
>> Since the main event loop is already spinning, I would still suggest 
>> to rename it to, say, enter/exitNestedNativeEventLoop() to stress that 
>> this event loop is going to be an inner loop, rather than the main 
>> (outer) event loop.
>>
>> -- 
>> best regards,
>> Anthony
>>
>>>
>>> With best regards,
>>> Alex
>>>
>>> On 4/27/12 20:54, Anthony Petrov wrote:
>>>> Hi Alexander,
>>>>
>>>> Could you provide some details about the ToolkitThreadBlockedHandler 
>>>> interface? How is it used by the DnD code?
>>>>
>>>> Also, I suggest to replace the word Native with Nested in 
>>>> enter/exitNativeEventLoop() method names.
>>>>
>>>> -- 
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 4/26/2012 7:54 PM, Alexander Zuev wrote:
>>>>> Hello,
>>>>>
>>>>>   please review my fix for the CR 7148289: [macosx] Deadlock in 
>>>>> sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
>>>>>
>>>>>   Bug description is 
>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148289
>>>>>
>>>>>   Fix can be found at 
>>>>> http://cr.openjdk.java.net/~kizune/7148289/webrev.00
>>>>>
>>>>> With best regards,
>>>>> Alex
>>>
> 


From artem.ananiev at oracle.com  Wed May  2 11:09:00 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Wed, 02 May 2012 22:09:00 +0400
Subject: <AWT Dev> Review Request: 7164376 Replace use of
	sun.security.action.LoadLibraryAction
In-Reply-To: <4F9998CF.9000308@oracle.com>
References: <4F9998CF.9000308@oracle.com>
Message-ID: <4FA1783C.7030809@oracle.com>

Hi, Mandy,

the client part of the fix looks fine. Let me ask a naive question, though.

 From your explanation, I see that System.loadLibrary() is now aware of 
modules. What prevents us to change LoadLibraryAction the same way? 
"FROM" code looks much more elegant than the new (the old?) "TO" one.

Thanks,

Artem

On 4/26/2012 10:49 PM, Mandy Chung wrote:
> 7164376 Replace use of sun.security.action.LoadLibraryAction
> with direct call of System.loadLibrary
>
> Webrev:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/
>
> This change is required for jdk modularization. High level summary:
> it replaces the use of LoadLibraryAction:
>
> FROM:
> java.security.AccessController.doPrivileged(new LoadLibraryAction("net"));
>
> TO:
> AccessController.doPrivileged(
> new java.security.PrivilegedAction<Void>() {
> public Void run() {
> System.loadLibrary("net");
> return null;
> }
> });
>
> It touches files in awt, security and serviceability area (cc'ed).
> For this type of simple change, I think 1-2 reviewers can
> review all files (simpler to review jdk.patch) and no need
> for all teams to do the reviews.
>
> System.loadLibrary and Runtime.loadLibrary loads a system library of the
> given
> library name that requires RuntimePermission("loadLibrary."+lib)
> permission.
> Many places in the JDK code loading a system native library is using the
> sun.security.action.LoadLibraryAction convenient class that will load the
> system library as a privileged action:
> java.security.AccessController.doPrivileged(new LoadLibraryAction("net"));
>
> The search path of native libraries are coupled with an associated class
> loader.
> For example, the application class loader uses the path specified in the
> "java.library.path" system property for native library lookup. The
> loadLibrary
> implementation uses the caller's class loader for finding the native
> library being
> requested. For system libraries, the class loader is null and the system
> library
> lookup is handled as a special case. When the
> sun.security.action.LoadLibraryAction
> class is used that is the caller of System.loadLibrary, the caller's
> class loader
> in this case is "null" loader and thus it always finds the native
> library from
> the system library path.
>
> In a modular world, JDK modules may be loaded by multiple different
> module class
> loader. The following code would not work if it is expected to load a
> native
> library from a module which is not the module where the
> sun.security.action.LoadLibraryAction lives.
>
> For example, the management module is trying to load libmanagement.so.
> Calling
> the following will fail to find libmanagement.so because the caller of
> System.loadLibrary is the LoadLibraryAction which is in the base module
> and search the library from the base module only. To prepare for jdk
> modularization, the use of LoadLibraryAction should be replaced with
> a direct call of System.loadLibrary.
>
> This patch also removes sun.security.action.LoadLibraryAction
> class to avoid regression.
>
> Thanks
> Mandy
>


From mandy.chung at oracle.com  Wed May  2 11:30:30 2012
From: mandy.chung at oracle.com (Mandy Chung)
Date: Wed, 02 May 2012 11:30:30 -0700
Subject: <AWT Dev> Review Request: 7164376 Replace use of
	sun.security.action.LoadLibraryAction
In-Reply-To: <4FA1783C.7030809@oracle.com>
References: <4F9998CF.9000308@oracle.com> <4FA1783C.7030809@oracle.com>
Message-ID: <4FA17D46.1070805@oracle.com>

On 5/2/2012 11:09 AM, Artem Ananiev wrote:
> Hi, Mandy,
>
> the client part of the fix looks fine.

Thanks for the review.  I have pushed the changeset and hope you don't 
mind I couldn't fix the changeset comment to add you as a reviewer.

> Let me ask a naive question, though.
>
> From your explanation, I see that System.loadLibrary() is now aware of 
> modules. What prevents us to change LoadLibraryAction the same way? 
> "FROM" code looks much more elegant than the new (the old?) "TO" one.
>

I would say the old code is little compact than the new one and both 
versions look elegant to me.

The fix here is to get the caller of System.loadLibrary be in the same 
class loader as the native library being loaded (see 
ClassLoader.findLibrary).

Another alternative is that each component can have its own copy of 
LoadLibraryAction (e.g. sun.awt.LoadLibraryAction) and so you can modify 
the old code like this:
    java.security.AccessController.doPrivileged(new 
sun.awt.LoadLibraryAction("awt"));

provided that sun.awt.LoadLibraryAction is loaded by the same class 
loader with whom awt.dll is associated.  Adding one copy of this simple 
LoadLibraryAction utility class for each component seems overkill and 
also error-prone e.g. refactoring a module into two modules require 
adding another copy of this per-module utility class if both have native 
libraries.  This is certainly an option if the component team prefers to 
use the utility class.

Mandy

> Thanks,
>
> Artem
>
> On 4/26/2012 10:49 PM, Mandy Chung wrote:
>> 7164376 Replace use of sun.security.action.LoadLibraryAction
>> with direct call of System.loadLibrary
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/
>>
>> This change is required for jdk modularization. High level summary:
>> it replaces the use of LoadLibraryAction:
>>
>> FROM:
>> java.security.AccessController.doPrivileged(new 
>> LoadLibraryAction("net"));
>>
>> TO:
>> AccessController.doPrivileged(
>> new java.security.PrivilegedAction<Void>() {
>> public Void run() {
>> System.loadLibrary("net");
>> return null;
>> }
>> });
>>
>> It touches files in awt, security and serviceability area (cc'ed).
>> For this type of simple change, I think 1-2 reviewers can
>> review all files (simpler to review jdk.patch) and no need
>> for all teams to do the reviews.
>>
>> System.loadLibrary and Runtime.loadLibrary loads a system library of the
>> given
>> library name that requires RuntimePermission("loadLibrary."+lib)
>> permission.
>> Many places in the JDK code loading a system native library is using the
>> sun.security.action.LoadLibraryAction convenient class that will load 
>> the
>> system library as a privileged action:
>> java.security.AccessController.doPrivileged(new 
>> LoadLibraryAction("net"));
>>
>> The search path of native libraries are coupled with an associated class
>> loader.
>> For example, the application class loader uses the path specified in the
>> "java.library.path" system property for native library lookup. The
>> loadLibrary
>> implementation uses the caller's class loader for finding the native
>> library being
>> requested. For system libraries, the class loader is null and the system
>> library
>> lookup is handled as a special case. When the
>> sun.security.action.LoadLibraryAction
>> class is used that is the caller of System.loadLibrary, the caller's
>> class loader
>> in this case is "null" loader and thus it always finds the native
>> library from
>> the system library path.
>>
>> In a modular world, JDK modules may be loaded by multiple different
>> module class
>> loader. The following code would not work if it is expected to load a
>> native
>> library from a module which is not the module where the
>> sun.security.action.LoadLibraryAction lives.
>>
>> For example, the management module is trying to load libmanagement.so.
>> Calling
>> the following will fail to find libmanagement.so because the caller of
>> System.loadLibrary is the LoadLibraryAction which is in the base module
>> and search the library from the base module only. To prepare for jdk
>> modularization, the use of LoadLibraryAction should be replaced with
>> a direct call of System.loadLibrary.
>>
>> This patch also removes sun.security.action.LoadLibraryAction
>> class to avoid regression.
>>
>> Thanks
>> Mandy
>>


From leonid.romanov at oracle.com  Wed May  2 12:10:38 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Wed, 2 May 2012 23:10:38 +0400
Subject: <AWT Dev> [8] Review request for 7124376: [macosx] Modal dialog
	lost focus
In-Reply-To: <4F9ADFBE.5070909@oracle.com>
References: <BD2F7C9B-212E-4013-B5F0-65A00BB97087@oracle.com>
	<4F9AD9C7.6020707@oracle.com>
	<57BD5F10-B0B3-4091-8777-2A084643DC4C@oracle.com>
	<4F9ADFBE.5070909@oracle.com>
Message-ID: <365B8FE6-2E62-4B95-AE56-E474F1FDD4E6@oracle.com>

Hi,
I've reworked my fix. See
http://cr.openjdk.java.net/~leonidr/7124376/webrev.01/

On 27.04.2012, at 22:04, Anthony Petrov wrote:

> I've noticed that too. I didn't point this out though, because you're also checking the MODAL_EXCLUDED flag in your modallyBlocked(), so I thought it was OK. But if you can pull this check to the Java code before even calling modallyBLocked(), then I guess the "setEnabled" name would make more sense.
> 
> --
> best regards,
> Anthony
> 
> On 4/27/2012 10:02 PM, Leonid Romanov wrote:
>> I've looked at 7124395 and the fixes you did for FX and it looks like we need setEnabled method for AWTWindow. I'll redo my fix accordingly.   On 27.04.2012, at 21:39, Anthony Petrov wrote:
>>> Hi Leonid,
>>> 
>>> I was thinking of implementing a similar mechanism in order to fix 7124395. Please see the Comments section in that bug for some additional details.
>>> 
>>> Regarding the fix itself:
>>> 
>>> 1. Even though you return NO from canBecomeMain/KeyWindow, the OS will still bring the window to front of the z-order when you click it. In FX we handle this by always returning YES from canBecome* methods, however, the windowDidBecomeKey: sends a special FOCUS_DISABLED event if the window is blocked. In that case the upper level code re-stacks windows so that the blocker window always appears on the top of the z-order. Have you verified if this works fine for AWT apps with your fix?
>>> 
>>> 2. Also, we just don't send mouse events for blocked windows from native code to Java. Is this handled somewhere else for modally blocked windows in lwawt?
>>> 
>>> --
>>> best regards,
>>> Anthony
>>> 
>>> On 4/27/2012 6:11 PM, Leonid Romanov wrote:
>>>> Hi,
>>>> Please review a fix for 7124376: [macosx] Modal dialog lost focus. One can easily reproduce this bug by launching SwingSet2, choosing JOptionPane demo and then clicking "Show Message Dialog" button. Now, click on the "SwingSet2" window title bar and you'll see the window rapidly gaining and loosing focus.
>>>> Bug:  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124376
>>>> webrev: http://cr.openjdk.java.net/~leonidr/7124376/webrev.00/
>>>> Thanks,
>>>> Leonid.



From artem.ananiev at oracle.com  Wed May  2 12:18:39 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Wed, 02 May 2012 23:18:39 +0400
Subject: <AWT Dev> [7u6] Review request for 7154062: [macosx] Mouse
 cursor isn't updated in applets
In-Reply-To: <4FA12078.3060303@oracle.com>
References: <4FA120FE.4070002@oracle.com> <4FA12078.3060303@oracle.com>
Message-ID: <4FA1888F.50303@oracle.com>


On 5/2/2012 3:54 PM, Anthony Petrov wrote:
> Still looks fine to me.

+1

Thanks,

Artem

> --
> best regards,
> Anthony
>
> On 5/2/2012 3:56 PM, Dmitry Cherepanov wrote:
>> Hello,
>>
>> Please review a fix for 7154062 ([macosx] Mouse cursor isn't updated
>> in applets):
>>
>> http://cr.openjdk.java.net/~dcherepanov/7154062/7u6/webrev.0/
>>
>> The patch is a direct back-port of a fix from 8 [1].
>>
>> Thanks,
>> Dmitry
>>
>> [1] http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bbbf4e63562b
>>


From luchsh at linux.vnet.ibm.com  Thu May  3 01:26:08 2012
From: luchsh at linux.vnet.ibm.com (Jonathan Lu)
Date: Thu, 03 May 2012 16:26:08 +0800
Subject: <AWT Dev> Behavior difference when open file dialog from applet
In-Reply-To: <4F952B84.2030601@linux.vnet.ibm.com>
References: <4F83AAD1.7030800@linux.vnet.ibm.com>	<4F857ADF.6040607@linux.vnet.ibm.com>	<4F8E66F0.1050309@linux.vnet.ibm.com>
	<4F903DCF.5030807@oracle.com> <4F915784.3010705@oracle.com>
	<4F952B84.2030601@linux.vnet.ibm.com>
Message-ID: <4FA24120.8070409@linux.vnet.ibm.com>

Hello, how about just change the code like following patch by adding a 
security check point before invoking the native dialog.

http://cr.openjdk.java.net/~luchsh/webrev_gtk_file_dialog/

Best regards!

- Jonathan

On 04/23/2012 06:14 PM, Jonathan Lu wrote:
> Basically the existance checking of files and directory without 
> explicitly granted permissions do not look very friendly to me 
> especially for applet code from the web. This might be a helpful way 
> for hackers to infer OS version, user habit or software config from 
> the directory layout retrieved by a file dialog.
>
> Any comments from the security list?
>
> best regards!
> -Jonathan
>
> On 04/20/2012 08:33 PM, Anthony Petrov wrote:
>> OTOH, using a file dialog may allow one (with a little help from a 
>> user) to check a file or a directory for existence which may be 
>> considered a security vulnerability. This is actually the reason the 
>> exception is thrown by XFileDialogPeer in the first place: it gets 
>> thrown when the code calls File.isDirectory() when setting the 
>> initial directory for the dialog.
>>
>> Not sure if this ability is much useful by itself, or if this 
>> vulnerability is "convenient" for hackers to use since it involves 
>> the user, but still this doesn't feel like a benign thing to me.
>>
>> What do security experts think about that?
>>
>> -- 
>> best regards,
>> Anthony
>>
>> On 4/19/2012 8:31 PM, Artem Ananiev wrote:
>>> Hi, Jonathan,
>>>
>>> you're right, GTK and X file dialogs behave differently when 
>>> SecurityManager is installed. However, instead of changing GTK 
>>> dialogs, I propose to correct X dialogs, so they don't throw 
>>> security exceptions.
>>>
>>> Indeed, application may create arbitrary java.io.File objects 
>>> without any permissions. File permissions are only checked when 
>>> application tries to read from, or write into, or just open the 
>>> file. AWT file dialogs are about getting File objects, they don't 
>>> provide access to File content (be it a regular file or a 
>>> directory), so I don't see any reasons to throw exceptions.
>>>
>>> What do you think about it?
>>>
>>> Thanks,
>>>
>>> Artem
>>>
>>> On 4/18/2012 11:02 AM, Jonathan Lu wrote:
>>>> Hello, is anybody interested in this problem?
>>>>
>>>> it seems to be a generic question of how to control security access in
>>>> JNI native implementation of JDK.
>>>> And consider the behavior differences, is it neccessary to reimplement
>>>> Gtk file dialog in the same way as X dialog?
>>>>
>>>> Regards
>>>> - Jonathan
>>>>
>>>> On 04/11/2012 08:36 PM, Jonathan Lu wrote:
>>>>>
>>>>> Hi awt-dev,
>>>>>
>>>>> I found a behavior difference when open file dialog from an 
>>>>> applet, bug
>>>>> 7160238 has been created for this issue.
>>>>> Here's the tiny test case to helping reproduce the problem,
>>>>>
>>>>> /*
>>>>> * Copyright (c) 2012 Oracle and/or its affiliates. All rights 
>>>>> reserved.
>>>>> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>>> *
>>>>> * This code is free software; you can redistribute it and/or 
>>>>> modify it
>>>>> * under the terms of the GNU General Public License version 2 
>>>>> only, as
>>>>> * published by the Free Software Foundation.
>>>>> *
>>>>> * This code is distributed in the hope that it will be useful, but
>>>>> WITHOUT
>>>>> * ANY WARRANTY; without even the implied warranty of 
>>>>> MERCHANTABILITY or
>>>>> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public 
>>>>> License
>>>>> * version 2 for more details (a copy is included in the LICENSE 
>>>>> file that
>>>>> * accompanied this code).
>>>>> *
>>>>> * You should have received a copy of the GNU General Public License
>>>>> version
>>>>> * 2 along with this work; if not, write to the Free Software 
>>>>> Foundation,
>>>>> * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
>>>>> *
>>>>> * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 
>>>>> 94065 USA
>>>>> * or visit www.oracle.com if you need additional information or 
>>>>> have any
>>>>> * questions.
>>>>> */
>>>>>
>>>>> /*
>>>>> * Portions Copyright (c) 2012 IBM Corporation
>>>>> */
>>>>>
>>>>> import java.applet.Applet;
>>>>> import java.awt.Button;
>>>>> import java.awt.FileDialog;
>>>>> import java.awt.Frame;
>>>>> import java.awt.event.ActionEvent;
>>>>> import java.awt.event.ActionListener;
>>>>>
>>>>> public class FileDialogTest extends Applet {
>>>>> @Override
>>>>> public void init() {
>>>>> Button button = new Button("Open FileDialog");
>>>>> add(button);
>>>>> button.addActionListener(new ActionListener() {
>>>>> @Override
>>>>> public void actionPerformed(ActionEvent event) {
>>>>> Frame f = new Frame();
>>>>> FileDialog dialog = new FileDialog(f, "FileDialog");
>>>>> dialog.show();
>>>>> }
>>>>> });
>>>>> }
>>>>> }
>>>>>
>>>>> Embeded it into an HTML document, test.html, then run appletviewer 
>>>>> with
>>>>> following two commands,
>>>>> appletviewer -J-Dsun.awt.disableGtkFileDialogs=true test.html
>>>>> appletviewer -J-Dsun.awt.disableGtkFileDialogs=false test.html
>>>>>
>>>>> The result will be different, -J-Dsun.awt.disableGtkFileDialogs=true
>>>>> will throw AccessControlException, but
>>>>> -J-Dsun.awt.disableGtkFileDialogs=false will continue to open a file
>>>>> dialog.
>>>>>
>>>>> According to the specification:
>>>>> The basic applet security model is an all or nothing proposition. 
>>>>> If you
>>>>> get a security certificate, you can give the applet full access to 
>>>>> the
>>>>> user's system. Without it, the applet has virtually no access at all.
>>>>>
>>>>> Since file dialog displays the content of user's file system, so it
>>>>> absolutely needs file system read permmission, right? but for Gtk 
>>>>> File
>>>>> Dialog, it just works fine without exceptions. I don't think this
>>>>> behavior is following the spec here, right? In OpenJDK's source code,
>>>>> GtkFileDialogPeer will create a native GTK file chooser widget and 
>>>>> keep
>>>>> a native pointer, does this leave a breach to Java applet's security
>>>>> model?
>>>>>
>>>>> Cheers!
>>>>> - Jonathan
>>>>>
>>>>>
>>>>
>



From anthony.petrov at oracle.com  Thu May  3 05:40:47 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Thu, 03 May 2012 16:40:47 +0400
Subject: <AWT Dev> [8] Review request for 7124376: [macosx] Modal dialog
	lost focus
In-Reply-To: <365B8FE6-2E62-4B95-AE56-E474F1FDD4E6@oracle.com>
References: <BD2F7C9B-212E-4013-B5F0-65A00BB97087@oracle.com>
	<4F9AD9C7.6020707@oracle.com>
	<57BD5F10-B0B3-4091-8777-2A084643DC4C@oracle.com>
	<4F9ADFBE.5070909@oracle.com>
	<365B8FE6-2E62-4B95-AE56-E474F1FDD4E6@oracle.com>
Message-ID: <4FA27CCF.2060204@oracle.com>

Hi Leonid,

The fix looks good to me. Thanks.

--
best regards,
Anthony

On 05/02/12 23:10, Leonid Romanov wrote:
> Hi,
> I've reworked my fix. See
> http://cr.openjdk.java.net/~leonidr/7124376/webrev.01/
>
> On 27.04.2012, at 22:04, Anthony Petrov wrote:
>
>> I've noticed that too. I didn't point this out though, because you're also checking the MODAL_EXCLUDED flag in your modallyBlocked(), so I thought it was OK. But if you can pull this check to the Java code before even calling modallyBLocked(), then I guess the "setEnabled" name would make more sense.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 4/27/2012 10:02 PM, Leonid Romanov wrote:
>>> I've looked at 7124395 and the fixes you did for FX and it looks like we need setEnabled method for AWTWindow. I'll redo my fix accordingly.   On 27.04.2012, at 21:39, Anthony Petrov wrote:
>>>> Hi Leonid,
>>>>
>>>> I was thinking of implementing a similar mechanism in order to fix 7124395. Please see the Comments section in that bug for some additional details.
>>>>
>>>> Regarding the fix itself:
>>>>
>>>> 1. Even though you return NO from canBecomeMain/KeyWindow, the OS will still bring the window to front of the z-order when you click it. In FX we handle this by always returning YES from canBecome* methods, however, the windowDidBecomeKey: sends a special FOCUS_DISABLED event if the window is blocked. In that case the upper level code re-stacks windows so that the blocker window always appears on the top of the z-order. Have you verified if this works fine for AWT apps with your fix?
>>>>
>>>> 2. Also, we just don't send mouse events for blocked windows from native code to Java. Is this handled somewhere else for modally blocked windows in lwawt?
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 4/27/2012 6:11 PM, Leonid Romanov wrote:
>>>>> Hi,
>>>>> Please review a fix for 7124376: [macosx] Modal dialog lost focus. One can easily reproduce this bug by launching SwingSet2, choosing JOptionPane demo and then clicking "Show Message Dialog" button. Now, click on the "SwingSet2" window title bar and you'll see the window rapidly gaining and loosing focus.
>>>>> Bug:  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124376
>>>>> webrev: http://cr.openjdk.java.net/~leonidr/7124376/webrev.00/
>>>>> Thanks,
>>>>> Leonid.
>


From sergey.bylokhov at oracle.com  Thu May  3 07:40:19 2012
From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com)
Date: Thu, 03 May 2012 14:40:19 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7160623: [macosx] Editable
	TextArea/TextField are	blocking GUI applications from exit
Message-ID: <20120503144051.095E047128@hg.openjdk.java.net>

Changeset: c31eeeda3ed1
Author:    serb
Date:      2012-05-03 18:29 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c31eeeda3ed1

7160623: [macosx] Editable TextArea/TextField are blocking GUI applications from exit
Reviewed-by: anthony, art

! src/macosx/classes/sun/lwawt/LWComponentPeer.java
! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java



From Sergey.Bylokhov at oracle.com  Thu May  3 08:16:27 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 03 May 2012 19:16:27 +0400
Subject: <AWT Dev> [7u6] Request for review: 7160623 [macosx] Editable
 TextArea/TextField are blocking GUI applications from exit
Message-ID: <4FA2A14B.8040501@oracle.com>

Hi Everyone,
This is a back port from jdk 8 to jdk 7u6.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160623
jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c31eeeda3ed1
Webrev can be found at: http://cr.openjdk.java.net/~serb/7160623/webrev.00

Discussion about the same xawt fix: 
http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002381.html


From alexander.zuev at oracle.com  Thu May  3 08:23:30 2012
From: alexander.zuev at oracle.com (alexander.zuev at oracle.com)
Date: Thu, 03 May 2012 15:23:30 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7124376: [macosx] Modal dialog lost
	focus
Message-ID: <20120503152403.67B394712A@hg.openjdk.java.net>

Changeset: a420895ee2c3
Author:    leonidr
Date:      2012-05-03 19:22 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a420895ee2c3

7124376: [macosx] Modal dialog lost focus
Reviewed-by: anthony

! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/PlatformWindow.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/native/sun/awt/AWTView.m
! src/macosx/native/sun/awt/AWTWindow.h
! src/macosx/native/sun/awt/AWTWindow.m



From Sergey.Bylokhov at oracle.com  Thu May  3 08:25:56 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 03 May 2012 19:25:56 +0400
Subject: <AWT Dev> [8] Request for review: 7147055 [macosx] Cursors are
 changing over a blocked window; also blinking
In-Reply-To: <4F8306DD.1050300@oracle.com>
References: <4F8306DD.1050300@oracle.com>
Message-ID: <4FA2A384.8020900@oracle.com>

Hi Everyone.
Does anybody has a chance to review the fix? One more reviewer needed.

Thanks.

09.04.2012 19:57, Sergey Bylokhov wrote:
> Hi Everyone,
> Cursor for blocked window was fixed. Now we use default cursor in this 
> case.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147055
> Webrev can be found at: http://cr.openjdk.java.net/~serb/7147055/webrev.00
>
> -- 
> Best regards, Sergey.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120503/305efaa4/attachment.html 

From leonid.romanov at oracle.com  Thu May  3 08:51:56 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Thu, 3 May 2012 19:51:56 +0400
Subject: <AWT Dev> [7u6] Review request for 7124376: [macosx] Modal dialog
	lost focus
Message-ID: <EE536CF8-7BAD-42F1-BCAA-F6D74BD95F49@oracle.com>

Hi,
This is a backport from JDK 8 to 7u6.

Bug:  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124376
webrev: http://cr.openjdk.java.net/~leonidr/7124376/webrev.02/
jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a420895ee2c3

Thanks,
Leonid.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120503/0086ef42/attachment.html 

From alexander.zuev at oracle.com  Thu May  3 09:44:39 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Thu, 03 May 2012 20:44:39 +0400
Subject: <AWT Dev> [8] Please review my fix for 7148289: [macosx] Deadlock
	in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
Message-ID: <4FA2B5F7.8000703@oracle.com>

Hello,

   please review my fix for the CR 7148289: [macosx] Deadlock in 
sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame

   Actually it is a forward-port of the fix already approved for 7u6
The webrev looked absolutely similar so i just pointing the final webrev 
for 7u6 targeted fix - it's absolutely the same.

   Bug description is 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148289

   Fix can be found at http://cr.openjdk.java.net/~kizune/7148289/webrev.01

With best regards,
Alex


From alexander.zuev at oracle.com  Thu May  3 10:25:21 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Thu, 3 May 2012 21:25:21 +0400
Subject: <AWT Dev> [7u6] Review request for 7124376: [macosx] Modal
	dialog lost focus
In-Reply-To: <EE536CF8-7BAD-42F1-BCAA-F6D74BD95F49@oracle.com>
References: <EE536CF8-7BAD-42F1-BCAA-F6D74BD95F49@oracle.com>
Message-ID: <D2C2954E-ABD3-4E24-A2D1-170D06F9F84A@oracle.com>

Looks fine to me.

With best regards,
Alexander Zuev

03.05.2012, ? 19:51, Leonid Romanov <leonid.romanov at oracle.com> ???????(?):

> Hi,
> This is a backport from JDK 8 to 7u6.
> 
> Bug:  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124376
> webrev: http://cr.openjdk.java.net/~leonidr/7124376/webrev.02/
> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a420895ee2c3
> 
> Thanks,
> Leonid.
> 


From leonid.romanov at oracle.com  Thu May  3 10:40:10 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Thu, 3 May 2012 21:40:10 +0400
Subject: <AWT Dev> [8] Please review my fix for 7148289: [macosx]
	Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
In-Reply-To: <4FA2B5F7.8000703@oracle.com>
References: <4FA2B5F7.8000703@oracle.com>
Message-ID: <E59BC249-09FB-403C-BA8A-BD0BA34164BB@oracle.com>

Looks fine.

Leonid.

On 03.05.2012, at 20:44, Alexander Zuev wrote:

> Hello,
> 
>  please review my fix for the CR 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
> 
>  Actually it is a forward-port of the fix already approved for 7u6
> The webrev looked absolutely similar so i just pointing the final webrev for 7u6 targeted fix - it's absolutely the same.
> 
>  Bug description is http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148289
> 
>  Fix can be found at http://cr.openjdk.java.net/~kizune/7148289/webrev.01
> 
> With best regards,
> Alex



From alexander.zuev at oracle.com  Thu May  3 10:55:06 2012
From: alexander.zuev at oracle.com (alexander.zuev at oracle.com)
Date: Thu, 03 May 2012 17:55:06 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7148289: [macosx] Deadlock
	in	sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
Message-ID: <20120503175527.CED6147130@hg.openjdk.java.net>

Changeset: 95c8b63a3c47
Author:    kizune
Date:      2012-05-03 21:54 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/95c8b63a3c47

7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
Reviewed-by: leonidr

! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java
! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java
! src/macosx/native/sun/awt/LWCToolkit.m



From alexandr.scherbatiy at oracle.com  Fri May  4 02:16:50 2012
From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com)
Date: Fri, 04 May 2012 09:16:50 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7024963: Notepad demo: remove
	non-translatable	resources from Notepad.properties file
Message-ID: <20120504091710.AAE9F4714C@hg.openjdk.java.net>

Changeset: a714e2e2b257
Author:    alexsch
Date:      2012-05-04 13:15 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a714e2e2b257

7024963: Notepad demo: remove non-translatable resources from Notepad.properties file
Reviewed-by: rupashka

! src/share/demo/jfc/Notepad/Notepad.java
! src/share/demo/jfc/Notepad/resources/Notepad.properties
+ src/share/demo/jfc/Notepad/resources/system.properties



From anthony.petrov at oracle.com  Fri May  4 04:43:17 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 04 May 2012 15:43:17 +0400
Subject: <AWT Dev> [8] Review request for 7149062: [macosx] dock menu
 don't show available frames
In-Reply-To: <586FC99C-0C39-49A6-916C-516C568FFB71@oracle.com>
References: <4F8EB5A1.6060104@oracle.com> <4F95687A.3000709@oracle.com>
	<586FC99C-0C39-49A6-916C-516C568FFB71@oracle.com>
Message-ID: <4FA3C0D5.5000908@oracle.com>

Hi Scott,

I'm sorry for the delay with my response. Thank you very much for the 
review!

On 4/23/2012 9:15 PM, Scott Kovatch wrote:
> This looks fine to me. Only question is in CPlatformWindow:
> 
>  313         if (Window.Type.UTILITY.equals(target.getType())) {
>  314             styleBits = SET(styleBits, UTILITY, true);
>  315         }
> 
> Is this new? It looks needed but not necessarily part of this fix.

Indeed. I've filed a separate CR 7166437 to address this issue.

> It's unfortunate that you have to replicate code in AWTWindow_Normal and AWTWindow_Panel, but I don't see a better way to do it since you want to override methods. Would a category work here? There's not a lot of code here, but it may be harder to maintain over time.

I've investigated that, but it looks like a category (or an extension) 
requires a class name to add methods to. It's impossible to define an 
anonymous category and then apply it to two different classes. However, 
for the sake of this fix we do need to have two distinct classes: one 
inheriting from NSWindow, and another - from NSPanel. I can't find 
anything Obj-C-wise that could help eliminate the code replication here. 
Well, we could extract it into a separate file and #include it within 
the corresponding @implementation sections. But given the really small 
size of the replicated code this would look a bit weird in my opinion.

So I re-generated the webrev w/o the UTILITY thing mentioned above. The 
final webrev is at:

http://cr.openjdk.java.net/~anthony/8-26-windowListInDockMenu-7149062.1/

Looks OK to push that?

--
best regards,
Anthony


> 
> -- Scott
> 
> On Apr 23, 2012, at 7:34 AM, Anthony Petrov wrote:
> 
>> Mike et al.,
>>
>> Could I get a review for this fix please?
>>
>> --
>> best regards,
>> Anthony
>>
>> On 04/18/12 16:37, Anthony Petrov wrote:
>>> Hello,
>>>
>>> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7149062 at:
>>>
>>> http://cr.openjdk.java.net/~anthony/8-26-windowListInDockMenu-7149062.0/
>>>
>>> The AWTWindow class now inherits from NSObject and implements the
>>> NSWindowDelegate protocol. The real NSWindow object is held in the
>>> nsWindow property of the AWTWindow class, and is represented by either
>>> an AWTWindow_Normal or AWTWindow_Panel instance. These two classes
>>> inherit from NSWindow and NSPanel correspondingly. Note, however, that
>>> we still return a reference to the NSWindow/NSPanel instance to Java so
>>> that the pointer could be used with CWrapper methods directly. A
>>> reference to an associated AWTWindow instance is always available as
>>> (AWTWindow*)[nsWindow delegate].
>>>
>>> All windows that inherit from NSWindow are added to the windows list in
>>> the dock icon menu by default. We use NSPanel-based windows for UTILITY,
>>> HUD, NONACTIVATING, and HIDES_ON_DEACTIVATE windows only, because these
>>> kinds of windows typically don't represent main application windows, and
>>> thus aren't expected to be added to the windows list. Besides, UTILITY
>>> (and HUD?) windows just have to be NSPanels.
>>>
>>> This fix is going to be back-ported to 7u6 later on.
>>>
>>> --
>>> best regards,
>>> Anthony
> 


From anthony.petrov at oracle.com  Fri May  4 05:09:16 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 04 May 2012 16:09:16 +0400
Subject: <AWT Dev> [7u6] Request for review: 7160623 [macosx] Editable
 TextArea/TextField are blocking GUI applications from exit
In-Reply-To: <4FA2A14B.8040501@oracle.com>
References: <4FA2A14B.8040501@oracle.com>
Message-ID: <4FA3C6EC.5020205@oracle.com>

The fix still looks fine.

--
best regards,
Anthony

On 5/3/2012 7:16 PM, Sergey Bylokhov wrote:
> Hi Everyone,
> This is a back port from jdk 8 to jdk 7u6.
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160623
> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c31eeeda3ed1
> Webrev can be found at: http://cr.openjdk.java.net/~serb/7160623/webrev.00
> 
> Discussion about the same xawt fix: 
> http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002381.html


From anthony.petrov at oracle.com  Fri May  4 05:15:35 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 04 May 2012 16:15:35 +0400
Subject: <AWT Dev> [8] Review request for 7166437: [macosx] Support for
 Window.Type.UTILITY on the Mac
Message-ID: <4FA3C867.9000701@oracle.com>

Hello,

Please review this rather trivial fix for 
http://bugs.sun.com/view_bug.do?bug_id=7166437 at:

http://cr.openjdk.java.net/~anthony/8-31-UTILITY-7166437.0/

--
best regards,
Anthony


From artem.ananiev at oracle.com  Fri May  4 05:40:59 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Fri, 04 May 2012 16:40:59 +0400
Subject: <AWT Dev> Code Review Request for CR 7146237 -
 closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html
 failed since 1.8.0b19
In-Reply-To: <4FA1472A.3070902@oracle.com>
References: <4F747B25.5000707@oracle.com> <4F7585B5.20703@oracle.com>
	<4F75DC4A.20508@oracle.com> <4F7989DE.6030105@oracle.com>
	<4FA1472A.3070902@oracle.com>
Message-ID: <4FA3CE5B.9010909@oracle.com>


Still looks fine :)

Thanks,

Artem

On 5/2/2012 6:39 PM, Oleg Pekhovskiy wrote:
> Hi Artem, Anthony,
>
> Please review next version of fix that includes the same changes for
> KeyboardFocusManager, Container and JComponent:
> http://cr.openjdk.java.net/~bagiras/8/7146237.3/
>
> Those changes were also approved as CCC request:
> http://ccc.us.oracle.com/7146237
>
> Thanks,
> Oleg
>
> 4/2/2012 3:13 PM, Artem Ananiev wrote:
>>
>> Looks fine.
>>
>> Thanks,
>>
>> Artem
>>
>> On 3/30/2012 8:16 PM, Oleg Pekhovskiy wrote:
>>> Hi Anthony,
>>>
>>> thank you for this clarification, I modified those places:
>>> http://cr.openjdk.java.net/~bagiras/8/7146237.2
>>>
>>> Thanks,
>>> Oleg.
>>>
>>> 3/30/2012 2:06 PM, Anthony Petrov wrote:
>>>> Hi Oleg,
>>>>
>>>> The "modern" tagging approach for the javadoc is to use {@code ...}
>>>> instead of <code>...</code>.
>>>>
>>>> Otherwise the changes look fine to me.
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 3/29/2012 7:09 PM, Oleg Pekhovskiy wrote:
>>>>> Hi guys,
>>>>>
>>>>> please review these java-doc changes for:
>>>>> http://bugs.sun.com/view_bug.do?bug_id=7146237
>>>>>
>>>>> webrev:
>>>>> http://cr.openjdk.java.net/~bagiras/8/7146237.1
>>>>>
>>>>> Thanks,
>>>>> Oleg
>>>
>


From oleg.pekhovskiy at oracle.com  Fri May  4 07:46:03 2012
From: oleg.pekhovskiy at oracle.com (oleg.pekhovskiy at oracle.com)
Date: Fri, 04 May 2012 14:46:03 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk:
	7146237:	closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html	failed
	since 1.8.0b19
Message-ID: <20120504144621.7425747154@hg.openjdk.java.net>

Changeset: 4cc873e28c78
Author:    bagiras
Date:      2012-05-04 18:42 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4cc873e28c78

7146237: closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html failed since 1.8.0b19
Reviewed-by: art, anthony

! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Container.java
! src/share/classes/java/awt/KeyboardFocusManager.java
! src/share/classes/javax/swing/JComponent.java



From anthony.petrov at oracle.com  Fri May  4 07:53:35 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 04 May 2012 18:53:35 +0400
Subject: <AWT Dev> [7u6] Review request for 7144542: [macosx] Crash in
 liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline
Message-ID: <4FA3ED6F.5010502@oracle.com>

Hello,

Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7144542 at:

http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.0/

Note: in JDK 8 we already load the headless version of the AWT library, 
and this prevents the crash. Now I'm applying the same logic to JDK 7u6.

--
best regards,
Anthony


From Sergey.Bylokhov at oracle.com  Fri May  4 08:55:29 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 04 May 2012 19:55:29 +0400
Subject: <AWT Dev> [8] Request for review: 7080109 Dialog.show() lacks
 doPrivileged() to access system event queue
In-Reply-To: <4F8C501E.2070509@oracle.com>
References: <4F75DDC3.6010403@oracle.com> <4F7D7800.2020504@oracle.com>
	<4F8C501E.2070509@oracle.com>
Message-ID: <4FA3FBF1.4090908@oracle.com>

Hi Everyone.
Artem thanks for review. Does anybody has a chance to review the fix? 
One more reviewer needed.

Thanks.

16.04.2012 21:00, Sergey Bylokhov wrote:
> Hi, Artem.
> Thanks for view.
> Scope was changed. Here is an updated version:
> http://cr.openjdk.java.net/~serb/7080109/webrev.01/
>
> 05.04.2012 14:46, Artem Ananiev wrote:
>> Hi, Sergey,
>>
>> to limit the scope of the added doPrivileged() block, I would rewrite 
>> the code this way:
>>
>>     secondaryLoop = AccessController.doPrivileged(
>>         new PrivilegedAction<SecondaryLoop>() {
>>             public SecondaryLoop run() {
>>                 EventQueue eventQueue =
>>                     Toolkit.getDefaultToolkit().getSystemEventQueue();
>>                 return eventQueue.createSecondaryLoop(
>>                     cond, modalFilter, 0);
>>             }
>>         }
>>     );
>>     if (!secondaryLoop.enter()) {
>>         secondaryLoop = null;
>>     }
>>
>> Thanks,
>>
>> Artem
>>
>> On 3/30/2012 8:22 PM, Sergey Bylokhov wrote:
>>> Hi Everyone,
>>> In the fix doPrivileged was added to Dialog.show().
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/7080109/webrev.00/
>>>
>
>



From anthony.petrov at oracle.com  Fri May  4 09:09:38 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 04 May 2012 20:09:38 +0400
Subject: <AWT Dev> [8] Review request for 7149062: [macosx] dock menu
 don't show available frames
In-Reply-To: <EE0E02C0-16AA-4DE3-99AB-B239DA4D2C8B@oracle.com>
References: <4F8EB5A1.6060104@oracle.com> <4F95687A.3000709@oracle.com>
	<586FC99C-0C39-49A6-916C-516C568FFB71@oracle.com>
	<4FA3C0D5.5000908@oracle.com>
	<EE0E02C0-16AA-4DE3-99AB-B239DA4D2C8B@oracle.com>
Message-ID: <4FA3FF42.9040503@oracle.com>

Thanks for the review.

--
best regards,
Anthony

On 5/4/2012 8:07 PM, Scott Kovatch wrote:
> On May 4, 2012, at 4:43 AM, Anthony Petrov wrote:
> 
>> I've investigated that, but it looks like a category (or an extension) requires a class name to add methods to. It's impossible to define an anonymous category and then apply it to two different classes. However, for the sake of this fix we do need to have two distinct classes: one inheriting from NSWindow, and another - from NSPanel. I can't find anything Obj-C-wise that could help eliminate the code replication here. Well, we could extract it into a separate file and #include it within the corresponding @implementation sections. But given the really small size of the replicated code this would look a bit weird in my opinion.
> 
> No problem -- it was more a random thought than a concrete suggestion. I doubt we will be changing much in either file over time.
> 
>> So I re-generated the webrev w/o the UTILITY thing mentioned above. The final webrev is at:
>>
>> http://cr.openjdk.java.net/~anthony/8-26-windowListInDockMenu-7149062.1/
>>
>> Looks OK to push that?
> 
> Looks good to me.
> 
> -- Scott K.
> 
> 


From scott.kovatch at oracle.com  Fri May  4 09:07:28 2012
From: scott.kovatch at oracle.com (Scott Kovatch)
Date: Fri, 4 May 2012 09:07:28 -0700
Subject: <AWT Dev> [8] Review request for 7149062: [macosx] dock menu
	don't show available frames
In-Reply-To: <4FA3C0D5.5000908@oracle.com>
References: <4F8EB5A1.6060104@oracle.com> <4F95687A.3000709@oracle.com>
	<586FC99C-0C39-49A6-916C-516C568FFB71@oracle.com>
	<4FA3C0D5.5000908@oracle.com>
Message-ID: <EE0E02C0-16AA-4DE3-99AB-B239DA4D2C8B@oracle.com>


On May 4, 2012, at 4:43 AM, Anthony Petrov wrote:

> I've investigated that, but it looks like a category (or an extension) requires a class name to add methods to. It's impossible to define an anonymous category and then apply it to two different classes. However, for the sake of this fix we do need to have two distinct classes: one inheriting from NSWindow, and another - from NSPanel. I can't find anything Obj-C-wise that could help eliminate the code replication here. Well, we could extract it into a separate file and #include it within the corresponding @implementation sections. But given the really small size of the replicated code this would look a bit weird in my opinion.

No problem -- it was more a random thought than a concrete suggestion. I doubt we will be changing much in either file over time.

> So I re-generated the webrev w/o the UTILITY thing mentioned above. The final webrev is at:
> 
> http://cr.openjdk.java.net/~anthony/8-26-windowListInDockMenu-7149062.1/
> 
> Looks OK to push that?

Looks good to me.

-- Scott K.




From Sergey.Bylokhov at oracle.com  Fri May  4 09:30:48 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 04 May 2012 20:30:48 +0400
Subject: <AWT Dev> [8] Request for review: 7124534 [macosx] Submenu
 title overlaps with Submenu indicator in JPopupMenu
In-Reply-To: <4F7D6B4E.6080809@oracle.com>
References: <4F79C327.3090609@oracle.com> <4F7D6B4E.6080809@oracle.com>
Message-ID: <4FA40438.5060903@oracle.com>

Hi Everyone.
Artem thanks for review. Does anybody has a chance to review the fix? 
One more reviewer needed.

Thanks.

05.04.2012 13:52, Artem Ananiev wrote:
>
> Looks fine.
>
> Thanks,
>
> Artem
>
> On 4/2/2012 7:17 PM, Sergey Bylokhov wrote:
>> Hi Everyone,
>> This testcase was targeted to the bug in metal and motif l&f.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124534
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7124534/webrev.00/
>> Webrev against closed part:
>> http://cr.openjdk.java.net/~serb/7124534/closed/webrev/
>>



From sergey.bylokhov at oracle.com  Fri May  4 10:28:07 2012
From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com)
Date: Fri, 04 May 2012 17:28:07 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7147055: [macosx] Cursors are changing
	over a	blocked window; also blinking
Message-ID: <20120504172818.B66A94715A@hg.openjdk.java.net>

Changeset: 0feee4541f67
Author:    serb
Date:      2012-05-04 21:25 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0feee4541f67

7147055: [macosx] Cursors are changing over a blocked window; also blinking
Reviewed-by: art, kizune

! src/macosx/classes/sun/lwawt/LWCursorManager.java



From swingler at apple.com  Fri May  4 14:50:10 2012
From: swingler at apple.com (Mike Swingler)
Date: Fri, 04 May 2012 14:50:10 -0700
Subject: <AWT Dev> [8] Review request for 7149062: [macosx] dock menu
 don't show available frames
In-Reply-To: <4FA3FF42.9040503@oracle.com>
References: <4F8EB5A1.6060104@oracle.com> <4F95687A.3000709@oracle.com>
	<586FC99C-0C39-49A6-916C-516C568FFB71@oracle.com>
	<4FA3C0D5.5000908@oracle.com>
	<EE0E02C0-16AA-4DE3-99AB-B239DA4D2C8B@oracle.com>
	<4FA3FF42.9040503@oracle.com>
Message-ID: <7A956413-A1B7-4E4A-8D4C-90B98A6666DF@apple.com>

Overall, this looks good, but my one suggestion would be to NOT break out AWTWindow_Normal and AWTWindow_Panel into their own files, but instead to put them side-by-side in the AWTWindow implementation.

You could possibly share part of their implementations in a macro to enforce that they don't fall out of sync with each other over time, but that might be overkill - though I think keeping them in the same file will be important for people to see both at the same time.

Regards,
Mike Swingler
Apple Inc.

On May 4, 2012, at 9:09 AM, Anthony Petrov wrote:

> Thanks for the review.
> 
> --
> best regards,
> Anthony
> 
> On 5/4/2012 8:07 PM, Scott Kovatch wrote:
>> On May 4, 2012, at 4:43 AM, Anthony Petrov wrote:
>>> I've investigated that, but it looks like a category (or an extension) requires a class name to add methods to. It's impossible to define an anonymous category and then apply it to two different classes. However, for the sake of this fix we do need to have two distinct classes: one inheriting from NSWindow, and another - from NSPanel. I can't find anything Obj-C-wise that could help eliminate the code replication here. Well, we could extract it into a separate file and #include it within the corresponding @implementation sections. But given the really small size of the replicated code this would look a bit weird in my opinion.
>> No problem -- it was more a random thought than a concrete suggestion. I doubt we will be changing much in either file over time.
>>> So I re-generated the webrev w/o the UTILITY thing mentioned above. The final webrev is at:
>>> 
>>> http://cr.openjdk.java.net/~anthony/8-26-windowListInDockMenu-7149062.1/
>>> 
>>> Looks OK to push that?
>> Looks good to me.
>> -- Scott K.



From leonid.romanov at oracle.com  Sat May  5 03:29:08 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Sat, 5 May 2012 14:29:08 +0400
Subject: <AWT Dev> [7u6] Review request for 7124411: [macosx] There's no
	KEY_TYPED for VK_ESCAPE
Message-ID: <2DC303E9-C6BD-4698-816B-15423FD6A739@oracle.com>

Hi,
This one line fix is a backport from JDK 8 to 7u6.
 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124411
webrev: http://cr.openjdk.java.net/~leonidr/7124411/webrev.00/

Thanks,
Leonid.





From anthony.petrov at oracle.com  Sat May  5 05:57:44 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Sat, 05 May 2012 16:57:44 +0400
Subject: <AWT Dev> [8] Review request for 7149062: [macosx] dock menu
 don't show available frames
In-Reply-To: <7A956413-A1B7-4E4A-8D4C-90B98A6666DF@apple.com>
References: <4F8EB5A1.6060104@oracle.com> <4F95687A.3000709@oracle.com>
	<586FC99C-0C39-49A6-916C-516C568FFB71@oracle.com>
	<4FA3C0D5.5000908@oracle.com>
	<EE0E02C0-16AA-4DE3-99AB-B239DA4D2C8B@oracle.com>
	<4FA3FF42.9040503@oracle.com>
	<7A956413-A1B7-4E4A-8D4C-90B98A6666DF@apple.com>
Message-ID: <4FA523C8.2070508@oracle.com>

Thanks for reviewing that. Your suggestion sounds reasonable, so I've 
published a new webrev at:

http://cr.openjdk.java.net/~anthony/8-26-windowListInDockMenu-7149062.2/

--
best regards,
Anthony

On 5/5/2012 1:50 AM, Mike Swingler wrote:
> Overall, this looks good, but my one suggestion would be to NOT break out AWTWindow_Normal and AWTWindow_Panel into their own files, but instead to put them side-by-side in the AWTWindow implementation.
> 
> You could possibly share part of their implementations in a macro to enforce that they don't fall out of sync with each other over time, but that might be overkill - though I think keeping them in the same file will be important for people to see both at the same time.
> 
> Regards,
> Mike Swingler
> Apple Inc.
> 
> On May 4, 2012, at 9:09 AM, Anthony Petrov wrote:
> 
>> Thanks for the review.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 5/4/2012 8:07 PM, Scott Kovatch wrote:
>>> On May 4, 2012, at 4:43 AM, Anthony Petrov wrote:
>>>> I've investigated that, but it looks like a category (or an extension) requires a class name to add methods to. It's impossible to define an anonymous category and then apply it to two different classes. However, for the sake of this fix we do need to have two distinct classes: one inheriting from NSWindow, and another - from NSPanel. I can't find anything Obj-C-wise that could help eliminate the code replication here. Well, we could extract it into a separate file and #include it within the corresponding @implementation sections. But given the really small size of the replicated code this would look a bit weird in my opinion.
>>> No problem -- it was more a random thought than a concrete suggestion. I doubt we will be changing much in either file over time.
>>>> So I re-generated the webrev w/o the UTILITY thing mentioned above. The final webrev is at:
>>>>
>>>> http://cr.openjdk.java.net/~anthony/8-26-windowListInDockMenu-7149062.1/
>>>>
>>>> Looks OK to push that?
>>> Looks good to me.
>>> -- Scott K.
> 


From anthony.petrov at oracle.com  Sat May  5 06:46:19 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Sat, 05 May 2012 17:46:19 +0400
Subject: <AWT Dev> [7u6] Review request for 7124411: [macosx] There's no
 KEY_TYPED for VK_ESCAPE
In-Reply-To: <2DC303E9-C6BD-4698-816B-15423FD6A739@oracle.com>
References: <2DC303E9-C6BD-4698-816B-15423FD6A739@oracle.com>
Message-ID: <4FA52F2B.5040007@oracle.com>

Looks great.

--
best regards,
Anthony

On 5/5/2012 2:29 PM, Leonid Romanov wrote:
> Hi,
> This one line fix is a backport from JDK 8 to 7u6.
>  
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124411
> webrev: http://cr.openjdk.java.net/~leonidr/7124411/webrev.00/
> 
> Thanks,
> Leonid.
> 
> 
> 


From anthony.petrov at oracle.com  Sat May  5 06:57:44 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Sat, 05 May 2012 17:57:44 +0400
Subject: <AWT Dev> [8] Request for review: 7080109 Dialog.show() lacks
 doPrivileged() to access system event queue
In-Reply-To: <4FA3FBF1.4090908@oracle.com>
References: <4F75DDC3.6010403@oracle.com>
	<4F7D7800.2020504@oracle.com>	<4F8C501E.2070509@oracle.com>
	<4FA3FBF1.4090908@oracle.com>
Message-ID: <4FA531D8.4010103@oracle.com>

Hi Sergey,

The fix looks good to me.

--
best regards,
Anthony

On 5/4/2012 7:55 PM, Sergey Bylokhov wrote:
> Hi Everyone.
> Artem thanks for review. Does anybody has a chance to review the fix? 
> One more reviewer needed.
> 
> Thanks.
> 
> 16.04.2012 21:00, Sergey Bylokhov wrote:
>> Hi, Artem.
>> Thanks for view.
>> Scope was changed. Here is an updated version:
>> http://cr.openjdk.java.net/~serb/7080109/webrev.01/
>>
>> 05.04.2012 14:46, Artem Ananiev wrote:
>>> Hi, Sergey,
>>>
>>> to limit the scope of the added doPrivileged() block, I would rewrite 
>>> the code this way:
>>>
>>>     secondaryLoop = AccessController.doPrivileged(
>>>         new PrivilegedAction<SecondaryLoop>() {
>>>             public SecondaryLoop run() {
>>>                 EventQueue eventQueue =
>>>                     Toolkit.getDefaultToolkit().getSystemEventQueue();
>>>                 return eventQueue.createSecondaryLoop(
>>>                     cond, modalFilter, 0);
>>>             }
>>>         }
>>>     );
>>>     if (!secondaryLoop.enter()) {
>>>         secondaryLoop = null;
>>>     }
>>>
>>> Thanks,
>>>
>>> Artem
>>>
>>> On 3/30/2012 8:22 PM, Sergey Bylokhov wrote:
>>>> Hi Everyone,
>>>> In the fix doPrivileged was added to Dialog.show().
>>>>
>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
>>>> Webrev can be found at: 
>>>> http://cr.openjdk.java.net/~serb/7080109/webrev.00/
>>>>
>>
>>
> 


From swingler at apple.com  Sun May  6 14:22:24 2012
From: swingler at apple.com (Mike Swingler)
Date: Sun, 06 May 2012 14:22:24 -0700
Subject: <AWT Dev> [8] Review request for 7149062: [macosx] dock menu
 don't show available frames
In-Reply-To: <4FA523C8.2070508@oracle.com>
References: <4F8EB5A1.6060104@oracle.com> <4F95687A.3000709@oracle.com>
	<586FC99C-0C39-49A6-916C-516C568FFB71@oracle.com>
	<4FA3C0D5.5000908@oracle.com>
	<EE0E02C0-16AA-4DE3-99AB-B239DA4D2C8B@oracle.com>
	<4FA3FF42.9040503@oracle.com>
	<7A956413-A1B7-4E4A-8D4C-90B98A6666DF@apple.com>
	<4FA523C8.2070508@oracle.com>
Message-ID: <A1DC8FB3-9EAD-432B-8295-8A8AEE7FB769@apple.com>

Looks good to me.

Cheers,
Mike Swingler
Apple Inc.

On May 5, 2012, at 5:57 AM, Anthony Petrov wrote:

> Thanks for reviewing that. Your suggestion sounds reasonable, so I've published a new webrev at:
> 
> http://cr.openjdk.java.net/~anthony/8-26-windowListInDockMenu-7149062.2/
> 
> --
> best regards,
> Anthony
> 
> On 5/5/2012 1:50 AM, Mike Swingler wrote:
>> Overall, this looks good, but my one suggestion would be to NOT break out AWTWindow_Normal and AWTWindow_Panel into their own files, but instead to put them side-by-side in the AWTWindow implementation.
>> You could possibly share part of their implementations in a macro to enforce that they don't fall out of sync with each other over time, but that might be overkill - though I think keeping them in the same file will be important for people to see both at the same time.
>> Regards,
>> Mike Swingler
>> Apple Inc.
>> On May 4, 2012, at 9:09 AM, Anthony Petrov wrote:
>>> Thanks for the review.
>>> 
>>> --
>>> best regards,
>>> Anthony
>>> 
>>> On 5/4/2012 8:07 PM, Scott Kovatch wrote:
>>>> On May 4, 2012, at 4:43 AM, Anthony Petrov wrote:
>>>>> I've investigated that, but it looks like a category (or an extension) requires a class name to add methods to. It's impossible to define an anonymous category and then apply it to two different classes. However, for the sake of this fix we do need to have two distinct classes: one inheriting from NSWindow, and another - from NSPanel. I can't find anything Obj-C-wise that could help eliminate the code replication here. Well, we could extract it into a separate file and #include it within the corresponding @implementation sections. But given the really small size of the replicated code this would look a bit weird in my opinion.
>>>> No problem -- it was more a random thought than a concrete suggestion. I doubt we will be changing much in either file over time.
>>>>> So I re-generated the webrev w/o the UTILITY thing mentioned above. The final webrev is at:
>>>>> 
>>>>> http://cr.openjdk.java.net/~anthony/8-26-windowListInDockMenu-7149062.1/
>>>>> 
>>>>> Looks OK to push that?
>>>> Looks good to me.
>>>> -- Scott K.



From artem.ananiev at oracle.com  Thu May 10 03:11:54 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Thu, 10 May 2012 14:11:54 +0400
Subject: <AWT Dev> [7u6] Please review my fix for 7148289: [macosx]
 Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
In-Reply-To: <4F9BA768.1070404@oracle.com>
References: <4F996FD3.9080702@oracle.com> <4F9ACF63.5080406@oracle.com>
	<4F9BA768.1070404@oracle.com>
Message-ID: <4FAB946A.30407@oracle.com>

Hi, Alex,

could you add this information to the bug evaluation, please?

Thanks,

Artem

On 4/28/2012 12:16 PM, Alexander Zuev wrote:
> Anthony,
>
> sure, the details are:
>
> the ToolkitThreadBlockerHandler is an interface that is supposed to be used
> when program has to wait for the event pushed to the EDT finish its task
> and
> he calls like this:
> while (!dispatcher.isDone()) {
> DataTransferer.getInstance().getToolkitThreadBlockedHandler().enter();
> }
> and the event handler in its unregisterEvent() method calls for
> handler.exit()
> The method is supposed to make sure that waiting on the EDT doesn't
> create deadlocks.
> The implementation depends on the toolkit architecture - on some
> toolkits it's NoOp since
> they don't care if EDT is waiting, but in LWCToolkit our AWT components
> are backed by Swing
> delegates so there are a lot of calls from native application thread to
> EDT and vice versa so we
> can't afford to stop both threads. Solution is the code that makes
> secondary AppKit event loop
> to handle native events so waiting on EDT will leave at least one event
> loop pumping.
>
> The name is correct because despite the fact that we are in AWT code
> (LWCToolkit) we don't
> create nested EDT loop but running nested native (AppKit) loop - hence
> the name: enter/exitNativeEventLoop()
>
> With best regards,
> Alex
>
> On 4/27/12 20:54, Anthony Petrov wrote:
>> Hi Alexander,
>>
>> Could you provide some details about the ToolkitThreadBlockedHandler
>> interface? How is it used by the DnD code?
>>
>> Also, I suggest to replace the word Native with Nested in
>> enter/exitNativeEventLoop() method names.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 4/26/2012 7:54 PM, Alexander Zuev wrote:
>>> Hello,
>>>
>>> please review my fix for the CR 7148289: [macosx] Deadlock in
>>> sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame
>>>
>>> Bug description is
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148289
>>>
>>> Fix can be found at http://cr.openjdk.java.net/~kizune/7148289/webrev.00
>>>
>>> With best regards,
>>> Alex
>


From artem.ananiev at oracle.com  Thu May 10 03:16:15 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Thu, 10 May 2012 14:16:15 +0400
Subject: <AWT Dev> [8] Review request for 7124376: [macosx] Modal dialog
 lost focus
In-Reply-To: <365B8FE6-2E62-4B95-AE56-E474F1FDD4E6@oracle.com>
References: <BD2F7C9B-212E-4013-B5F0-65A00BB97087@oracle.com>
	<4F9AD9C7.6020707@oracle.com>
	<57BD5F10-B0B3-4091-8777-2A084643DC4C@oracle.com>
	<4F9ADFBE.5070909@oracle.com>
	<365B8FE6-2E62-4B95-AE56-E474F1FDD4E6@oracle.com>
Message-ID: <4FAB956F.7000600@oracle.com>

Hi, Leonid,

I wonder why you need this check for *_EXCLUDED in platform code? 
Whether a window should be blocked or not is determined at the shared 
level, in java.awt.Window/Dialog, so it's either bug in this shared 
code, or the check in CPlatformWindow is redundant.

Thanks,

Artem

On 5/2/2012 11:10 PM, Leonid Romanov wrote:
> Hi,
> I've reworked my fix. See
> http://cr.openjdk.java.net/~leonidr/7124376/webrev.01/
>
> On 27.04.2012, at 22:04, Anthony Petrov wrote:
>
>> I've noticed that too. I didn't point this out though, because you're also checking the MODAL_EXCLUDED flag in your modallyBlocked(), so I thought it was OK. But if you can pull this check to the Java code before even calling modallyBLocked(), then I guess the "setEnabled" name would make more sense.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 4/27/2012 10:02 PM, Leonid Romanov wrote:
>>> I've looked at 7124395 and the fixes you did for FX and it looks like we need setEnabled method for AWTWindow. I'll redo my fix accordingly.   On 27.04.2012, at 21:39, Anthony Petrov wrote:
>>>> Hi Leonid,
>>>>
>>>> I was thinking of implementing a similar mechanism in order to fix 7124395. Please see the Comments section in that bug for some additional details.
>>>>
>>>> Regarding the fix itself:
>>>>
>>>> 1. Even though you return NO from canBecomeMain/KeyWindow, the OS will still bring the window to front of the z-order when you click it. In FX we handle this by always returning YES from canBecome* methods, however, the windowDidBecomeKey: sends a special FOCUS_DISABLED event if the window is blocked. In that case the upper level code re-stacks windows so that the blocker window always appears on the top of the z-order. Have you verified if this works fine for AWT apps with your fix?
>>>>
>>>> 2. Also, we just don't send mouse events for blocked windows from native code to Java. Is this handled somewhere else for modally blocked windows in lwawt?
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 4/27/2012 6:11 PM, Leonid Romanov wrote:
>>>>> Hi,
>>>>> Please review a fix for 7124376: [macosx] Modal dialog lost focus. One can easily reproduce this bug by launching SwingSet2, choosing JOptionPane demo and then clicking "Show Message Dialog" button. Now, click on the "SwingSet2" window title bar and you'll see the window rapidly gaining and loosing focus.
>>>>> Bug:  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124376
>>>>> webrev: http://cr.openjdk.java.net/~leonidr/7124376/webrev.00/
>>>>> Thanks,
>>>>> Leonid.
>


From artem.ananiev at oracle.com  Thu May 10 03:23:47 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Thu, 10 May 2012 14:23:47 +0400
Subject: <AWT Dev> [8] Review request for 7166437: [macosx] Support for
 Window.Type.UTILITY on the Mac
In-Reply-To: <4FA3C867.9000701@oracle.com>
References: <4FA3C867.9000701@oracle.com>
Message-ID: <4FAB9733.3090909@oracle.com>

Hi, Anthony,

the fix looks fine.

Thanks,

Artem

On 5/4/2012 4:15 PM, Anthony Petrov wrote:
> Hello,
>
> Please review this rather trivial fix for
> http://bugs.sun.com/view_bug.do?bug_id=7166437 at:
>
> http://cr.openjdk.java.net/~anthony/8-31-UTILITY-7166437.0/
>
> --
> best regards,
> Anthony


From artem.ananiev at oracle.com  Thu May 10 03:33:39 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Thu, 10 May 2012 14:33:39 +0400
Subject: <AWT Dev> [7u6] Review request for 7144542: [macosx] Crash in
 liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline
In-Reply-To: <4FA3ED6F.5010502@oracle.com>
References: <4FA3ED6F.5010502@oracle.com>
Message-ID: <4FAB9983.9030506@oracle.com>


On 5/4/2012 6:53 PM, Anthony Petrov wrote:
> Hello,
>
> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7144542 at:
>
> http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.0/

So what you do is to change headful CToolkit to headless XToolkit, 
correct? Note that this change will also trigger Java2D pipeline change, 
which might not be what we want.

Have you tried to find out what exactly leads to the crash when CToolkit 
is used?

Thanks,

Artem

> Note: in JDK 8 we already load the headless version of the AWT library,
> and this prevents the crash. Now I'm applying the same logic to JDK 7u6.
>
> --
> best regards,
> Anthony


From Sergey.Bylokhov at oracle.com  Thu May 10 08:16:47 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 10 May 2012 19:16:47 +0400
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7024963: Notepad demo: remove
 non-translatable resources from Notepad.properties file
In-Reply-To: <20120504091710.AAE9F4714C@hg.openjdk.java.net>
References: <20120504091710.AAE9F4714C@hg.openjdk.java.net>
Message-ID: <4FABDBDF.1000100@oracle.com>

Hi, Alexandr.
In this fix fileDialog variable was deleted from the Notepad.java. But 
it is used in Stylepad demo. So now full jdk build failed with error:

C:\moe\workspaces\jdk\8\awt-mix\build\windows-i586\democlasses\demo\jfc\Stylepad\src\Stylepad.java:249: 
error: cannot find symbol
             if (fileDialog == null) {
                 ^
   symbol:   variable fileDialog
   location: class Stylepad.OpenAction

04.05.2012 13:16, alexandr.scherbatiy at oracle.com wrote:
> Changeset: a714e2e2b257
> Author:    alexsch
> Date:      2012-05-04 13:15 +0400
> URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a714e2e2b257
>
> 7024963: Notepad demo: remove non-translatable resources from Notepad.properties file
> Reviewed-by: rupashka
>
> ! src/share/demo/jfc/Notepad/Notepad.java
> ! src/share/demo/jfc/Notepad/resources/Notepad.properties
> + src/share/demo/jfc/Notepad/resources/system.properties
>



From sergey.bylokhov at oracle.com  Thu May 10 09:10:50 2012
From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com)
Date: Thu, 10 May 2012 16:10:50 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7080109: Dialog.show() lacks
	doPrivileged() to	access system event queue
Message-ID: <20120510161117.930184722B@hg.openjdk.java.net>

Changeset: 912e666b4e1d
Author:    serb
Date:      2012-05-10 20:05 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/912e666b4e1d

7080109: Dialog.show() lacks doPrivileged() to access system event queue
Reviewed-by: art, anthony

! src/share/classes/java/awt/Dialog.java
+ test/java/awt/Dialog/ModalDialogPermission/ModalDialogPermission.java
+ test/java/awt/Dialog/ModalDialogPermission/java.policy



From lana.steuck at oracle.com  Thu May 10 18:19:05 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 11 May 2012 01:19:05 +0000
Subject: <AWT Dev> hg: jdk8/awt: 6 new changesets
Message-ID: <20120511011905.C2D7747250@hg.openjdk.java.net>

Changeset: 47aa0ddc9126
Author:    katleman
Date:      2012-04-26 14:04 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/47aa0ddc9126

Added tag jdk8-b36 for changeset 6a6ba0a07f33

! .hgtags

Changeset: afeeed8e5f8c
Author:    ihse
Date:      2012-04-30 12:13 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/afeeed8e5f8c

7165277: Fix missing execute permission issue running logger.sh
Reviewed-by: ohair

! common/autoconf/configure
! common/autoconf/configure.ac

Changeset: b2972095a4b1
Author:    katleman
Date:      2012-05-02 15:46 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/b2972095a4b1

Merge


Changeset: 2eeb9fac7dfc
Author:    katleman
Date:      2012-05-09 13:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/2eeb9fac7dfc

Added tag jdk8-b37 for changeset b2972095a4b1

! .hgtags

Changeset: 2f06b15e2439
Author:    ewendeli
Date:      2012-05-03 14:17 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/2f06b15e2439

7154130: Add Mac OS X Instructions to README-builds.html
Reviewed-by: ohair
Contributed-by: edvard.wendelin at oracle.com

! README-builds.html

Changeset: d939bd0ab13c
Author:    katleman
Date:      2012-05-09 16:12 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/d939bd0ab13c

Merge




From lana.steuck at oracle.com  Thu May 10 18:19:04 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 11 May 2012 01:19:04 +0000
Subject: <AWT Dev> hg: jdk8/awt/corba: 7 new changesets
Message-ID: <20120511011914.236D347251@hg.openjdk.java.net>

Changeset: 83fac66442cf
Author:    katleman
Date:      2012-04-26 14:05 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/83fac66442cf

Added tag jdk8-b36 for changeset a5a61f259961

! .hgtags

Changeset: c6c0b1047985
Author:    jmelvin
Date:      2012-04-16 17:10 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/c6c0b1047985

7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6
Summary: On Mac OS X, align system property "os.arch" with Apple legacy JDKs.  Also, improve os.name string matching by using .contains() method instead of .startsWith(). This fix spans multiple repositories.
Reviewed-by: dcubed, phh, ohair, katleman

! make/common/shared/Platform.gmk

Changeset: 9cdcc0152526
Author:    coffeys
Date:      2012-04-20 17:34 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/9cdcc0152526

7161925: sjava files in corba don't have copyright string and legal notice
Reviewed-by: chegar
Contributed-by: misha.bykov at oracle.com

! src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava
! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava

Changeset: df0c7369a86b
Author:    lana
Date:      2012-04-26 14:14 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/df0c7369a86b

Merge


Changeset: 4a653e435441
Author:    lana
Date:      2012-05-01 11:29 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/4a653e435441

Merge


Changeset: 2d2f6b0f855b
Author:    katleman
Date:      2012-05-09 13:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/2d2f6b0f855b

Added tag jdk8-b37 for changeset 83fac66442cf

! .hgtags

Changeset: b8cbfb31139f
Author:    katleman
Date:      2012-05-09 13:11 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/b8cbfb31139f

Merge




From lana.steuck at oracle.com  Thu May 10 18:19:07 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 11 May 2012 01:19:07 +0000
Subject: <AWT Dev> hg: jdk8/awt/jaxws: 2 new changesets
Message-ID: <20120511011917.A80DC47252@hg.openjdk.java.net>

Changeset: b05a948db1b6
Author:    katleman
Date:      2012-04-26 14:06 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/b05a948db1b6

Added tag jdk8-b36 for changeset 89b36c658e39

! .hgtags

Changeset: ac1ba3b56775
Author:    katleman
Date:      2012-05-09 13:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/ac1ba3b56775

Added tag jdk8-b37 for changeset b05a948db1b6

! .hgtags



From lana.steuck at oracle.com  Thu May 10 18:19:14 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 11 May 2012 01:19:14 +0000
Subject: <AWT Dev> hg: jdk8/awt/langtools: 2 new changesets
Message-ID: <20120511011923.57B5A47253@hg.openjdk.java.net>

Changeset: 5891b38985e8
Author:    katleman
Date:      2012-04-26 14:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/5891b38985e8

Added tag jdk8-b36 for changeset 94bbaa67686f

! .hgtags

Changeset: 1f224f160aa8
Author:    katleman
Date:      2012-05-09 13:08 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/1f224f160aa8

Added tag jdk8-b37 for changeset 5891b38985e8

! .hgtags



From lana.steuck at oracle.com  Thu May 10 18:19:11 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 11 May 2012 01:19:11 +0000
Subject: <AWT Dev> hg: jdk8/awt/jaxp: 4 new changesets
Message-ID: <20120511011927.08D3247254@hg.openjdk.java.net>

Changeset: c388369cf4da
Author:    katleman
Date:      2012-04-26 14:06 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/c388369cf4da

Added tag jdk8-b36 for changeset cfd288fe1d3e

! .hgtags

Changeset: aabc08ea546f
Author:    ohair
Date:      2012-04-30 16:03 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/aabc08ea546f

7165312: Fix jaxp source movement for new build-infra
Reviewed-by: ohrstrom

! makefiles/Makefile

Changeset: 90204bfab4e2
Author:    katleman
Date:      2012-05-02 15:47 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/90204bfab4e2

Merge


Changeset: 5bbe0cb6f2f2
Author:    katleman
Date:      2012-05-09 13:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/5bbe0cb6f2f2

Added tag jdk8-b37 for changeset 90204bfab4e2

! .hgtags



From lana.steuck at oracle.com  Thu May 10 18:19:11 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 11 May 2012 01:19:11 +0000
Subject: <AWT Dev> hg: jdk8/awt/hotspot: 21 new changesets
Message-ID: <20120511012001.D26FF47255@hg.openjdk.java.net>

Changeset: bfcf92bfefb8
Author:    katleman
Date:      2012-04-26 14:05 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bfcf92bfefb8

Added tag jdk8-b36 for changeset 50b4400ca1ec

! .hgtags

Changeset: 4ee58fcab520
Author:    katleman
Date:      2012-05-09 13:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4ee58fcab520

Added tag jdk8-b37 for changeset bfcf92bfefb8

! .hgtags

Changeset: 3c91f2c9fd21
Author:    amurillo
Date:      2012-04-20 17:13 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3c91f2c9fd21

7163193: new hotspot build - hs24-b09
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: f3a4ee95783b
Author:    kevinw
Date:      2012-04-20 14:55 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f3a4ee95783b

7162488: VM not printing unknown -XX options
Reviewed-by: dholmes, kamg

! src/share/vm/runtime/arguments.cpp
+ test/runtime/7162488/Test7162488.sh

Changeset: 29ee40a082d3
Author:    sla
Date:      2012-04-23 13:30 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/29ee40a082d3

7162063: libsaproc debug print should format size_t correctly on 64bit platform
Reviewed-by: rbackman, mgronlun, dholmes

! agent/src/os/linux/ps_core.c

Changeset: f33c4d0f4c9e
Author:    dcubed
Date:      2012-04-23 11:03 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f33c4d0f4c9e

Merge


Changeset: d652a62d6e03
Author:    dcubed
Date:      2012-03-23 11:50 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d652a62d6e03

7102323: RFE: enable Full Debug Symbols Phase 1 on Solaris
Summary: Add support for ENABLE_FULL_DEBUG_SYMBOLS and ZIP_DEBUGINFO_FILES build flags. Add support for .diz files.
Reviewed-by: dholmes, ohair, sspitsyn

! make/Makefile
! make/linux/Makefile
! make/linux/makefiles/buildtree.make
! make/linux/makefiles/defs.make
! make/linux/makefiles/gcc.make
! make/linux/makefiles/jsig.make
! make/linux/makefiles/saproc.make
! make/linux/makefiles/vm.make
! make/solaris/Makefile
! make/solaris/makefiles/buildtree.make
! make/solaris/makefiles/defs.make
! make/solaris/makefiles/dtrace.make
! make/solaris/makefiles/jsig.make
! make/solaris/makefiles/saproc.make
! make/solaris/makefiles/sparcWorks.make
! make/solaris/makefiles/vm.make
! make/windows/build.make
! make/windows/makefiles/compile.make
! make/windows/makefiles/debug.make
! make/windows/makefiles/defs.make
! make/windows/makefiles/fastdebug.make
! make/windows/makefiles/product.make
! make/windows/makefiles/sa.make

Changeset: 744728c16316
Author:    dcubed
Date:      2012-04-03 09:48 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/744728c16316

7158067: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect product builds
Summary: Build option FULL_DEBUG_SYMBOLS=0 only affects product builds.
Reviewed-by: ohair, jmelvin, sspitsyn

! make/Makefile
! make/linux/Makefile
! make/linux/makefiles/defs.make
! make/solaris/Makefile
! make/solaris/makefiles/defs.make
! make/windows/makefiles/defs.make

Changeset: 74c359c4a9e5
Author:    dcubed
Date:      2012-04-24 15:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/74c359c4a9e5

Merge

! make/Makefile
! make/linux/Makefile
! make/linux/makefiles/buildtree.make
! make/linux/makefiles/defs.make
! make/linux/makefiles/gcc.make
! make/linux/makefiles/vm.make
! make/solaris/makefiles/buildtree.make
! make/solaris/makefiles/defs.make
! make/solaris/makefiles/sparcWorks.make
! make/solaris/makefiles/vm.make
! make/windows/build.make
! make/windows/makefiles/compile.make
! make/windows/makefiles/debug.make
! make/windows/makefiles/defs.make
! make/windows/makefiles/fastdebug.make
! make/windows/makefiles/product.make

Changeset: d6c393b0164b
Author:    dcubed
Date:      2012-04-25 15:06 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d6c393b0164b

7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows
Summary: Disable FDS by default on Solaris; disable ZIP_DEBUGINFO_FILES by default on Windows.
Reviewed-by: acorn, sspitsyn

! make/solaris/makefiles/defs.make
! make/windows/makefiles/defs.make

Changeset: 973046802b6f
Author:    dlong
Date:      2012-04-26 16:24 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/973046802b6f

7162955: Attach api on Solaris, too many open files
Summary: Release server-side socket after client receives it.
Reviewed-by: sla, dsamersoff, dcubed, acorn
Contributed-by: dean.long at oracle.com

! src/os/solaris/vm/attachListener_solaris.cpp

Changeset: 6f0612ea55ce
Author:    jprovino
Date:      2012-05-02 15:47 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6f0612ea55ce

Merge


Changeset: 9f059abe8cf2
Author:    jmasa
Date:      2012-03-29 19:46 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9f059abe8cf2

7131629: Generalize the CMS free list code
Summary: Make the FreeChunk, FreeList, TreeList, and BinaryTreeDictionary classes usable outside CMS.
Reviewed-by: brutisso, johnc, jwilhelm
Contributed-by: coleen.phillimore at oracle.com

- src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp
+ src/share/vm/memory/binaryTreeDictionary.cpp
+ src/share/vm/memory/binaryTreeDictionary.hpp
+ src/share/vm/memory/freeBlockDictionary.cpp
+ src/share/vm/memory/freeBlockDictionary.hpp
+ src/share/vm/memory/freeList.cpp
+ src/share/vm/memory/freeList.hpp
! src/share/vm/memory/generationSpec.cpp
! src/share/vm/precompiled/precompiled.hpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 8a2e5a6a19a4
Author:    johnc
Date:      2012-04-25 10:23 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8a2e5a6a19a4

7143490: G1: Remove HeapRegion::_top_at_conc_mark_count
Summary: Removed the HeapRegion::_top_at_conc_mark_count field. It is no longer needed as a result of the changes for 6888336 and 7127706. Refactored the closures that finalize and verify the liveness counting data so that common functionality was placed into a base class.
Reviewed-by: brutisso, tonyp

! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/heapRegion.cpp
! src/share/vm/gc_implementation/g1/heapRegion.hpp
! src/share/vm/gc_implementation/g1/heapRegion.inline.hpp

Changeset: f69a5d43dc19
Author:    jmasa
Date:      2012-04-25 09:55 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f69a5d43dc19

7164144: Fix variable naming style in freeBlockDictionary.* and binaryTreeDictionary*
Summary: Fix naming style to be consistent with the predominant hotspot style.
Reviewed-by: ysr, brutisso

! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp
! src/share/vm/gc_implementation/shared/allocationStats.hpp
! src/share/vm/memory/binaryTreeDictionary.cpp
! src/share/vm/memory/binaryTreeDictionary.hpp
! src/share/vm/memory/freeBlockDictionary.cpp
! src/share/vm/memory/freeBlockDictionary.hpp
! src/share/vm/memory/freeList.cpp
! src/share/vm/memory/freeList.hpp

Changeset: ee89f2110312
Author:    jmasa
Date:      2012-04-25 15:51 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ee89f2110312

Merge


Changeset: 48fac5d60c3c
Author:    brutisso
Date:      2012-04-25 12:36 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/48fac5d60c3c

7163848: G1: Log GC Cause for a GC
Reviewed-by: johnc, jwilhelm, jmasa

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp

Changeset: bb18e8eecb7e
Author:    jcoomes
Date:      2012-05-04 10:46 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bb18e8eecb7e

Merge

- src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp

Changeset: 7d5ec8bf38d1
Author:    amurillo
Date:      2012-05-04 14:10 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7d5ec8bf38d1

Merge

- src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp
- src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp

Changeset: 4e6554041847
Author:    amurillo
Date:      2012-05-04 14:10 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4e6554041847

Added tag hs24-b09 for changeset 7d5ec8bf38d1

! .hgtags

Changeset: 637c3f5f068f
Author:    amurillo
Date:      2012-05-09 14:06 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/637c3f5f068f

Merge

! .hgtags



From lana.steuck at oracle.com  Thu May 10 18:20:55 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 11 May 2012 01:20:55 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 37 new changesets
Message-ID: <20120511012740.81C4947256@hg.openjdk.java.net>

Changeset: 9e82ac15ab80
Author:    katleman
Date:      2012-04-26 14:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9e82ac15ab80

Added tag jdk8-b36 for changeset 45da9cb055ee

! .hgtags

Changeset: 8e3fb7dd21cd
Author:    skovatch
Date:      2012-04-25 12:18 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8e3fb7dd21cd

7128699: Fix bundle name so it contains the bugfix number in the name.
Reviewed-by: robilad

! make/common/Release-macosx.gmk

Changeset: 919be2f7fd6e
Author:    cgruszka
Date:      2012-04-27 14:37 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/919be2f7fd6e

Merge


Changeset: 762661efef30
Author:    jgodinez
Date:      2012-04-24 13:29 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/762661efef30

7157659: [macosx] Landscape Printing orientation doesn't work
Reviewed-by: bae, prr

! src/macosx/native/sun/awt/PrinterView.m

Changeset: cdaadcc2c6a4
Author:    jgodinez
Date:      2012-04-26 13:16 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cdaadcc2c6a4

7013850: Please change the mnemonic assignment system to avoid translation issue
Reviewed-by: prr, mfang

! src/share/classes/sun/print/ServiceDialog.java
! src/share/classes/sun/print/resources/serviceui.properties
! src/share/classes/sun/print/resources/serviceui_de.properties
! src/share/classes/sun/print/resources/serviceui_es.properties
! src/share/classes/sun/print/resources/serviceui_fr.properties
! src/share/classes/sun/print/resources/serviceui_it.properties
! src/share/classes/sun/print/resources/serviceui_ja.properties
! src/share/classes/sun/print/resources/serviceui_ko.properties
! src/share/classes/sun/print/resources/serviceui_pt_BR.properties
! src/share/classes/sun/print/resources/serviceui_sv.properties
! src/share/classes/sun/print/resources/serviceui_zh_CN.properties
! src/share/classes/sun/print/resources/serviceui_zh_TW.properties

Changeset: c2d29a375871
Author:    lana
Date:      2012-04-26 18:25 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c2d29a375871

Merge


Changeset: 4a19075bb989
Author:    lana
Date:      2012-05-02 09:53 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4a19075bb989

Merge


Changeset: f906d6068b43
Author:    lana
Date:      2012-05-02 09:54 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f906d6068b43

Merge


Changeset: 7b023213681c
Author:    psandoz
Date:      2012-04-19 14:05 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7b023213681c

7162262: (fs) Typo in java.nio.file.Path class description
Reviewed-by: alanb

! src/share/classes/java/nio/file/Path.java

Changeset: 77b35c5c4b95
Author:    jmelvin
Date:      2012-04-16 18:09 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/77b35c5c4b95

7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6
Summary: On Mac OS X, align system property "os.arch" with Apple legacy JDKs.  Also, improve os.name string matching by using .contains() method instead of .startsWith(). This fix spans multiple repositories.
Reviewed-by: dcubed, phh, ohair, katleman

! make/common/Defs-macosx.gmk
! make/common/shared/Platform.gmk
! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java
! src/share/classes/java/nio/Bits.java
! src/share/classes/java/util/prefs/Preferences.java
! src/share/classes/sun/awt/OSInfo.java
! src/share/classes/sun/font/FontUtilities.java
! src/share/classes/sun/launcher/LauncherHelper.java
! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java
! src/share/classes/sun/print/PSPrinterJob.java
! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java
! src/share/classes/sun/security/krb5/Config.java
! src/share/classes/sun/security/krb5/Credentials.java
! src/share/classes/sun/security/provider/ByteArrayAccess.java
! src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java
! src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java
! src/solaris/classes/sun/print/UnixPrintServiceLookup.java
! test/demo/jvmti/DemoRun.java
! test/java/io/File/GetXSpace.java
! test/java/lang/ProcessBuilder/Basic.java
! test/java/lang/ProcessBuilder/Zombies.java
! test/java/lang/invoke/InvokeGenericTest.java
! test/java/lang/management/OperatingSystemMXBean/GetSystemLoadAverage.java
! test/java/nio/channels/FileChannel/Size.java
! test/java/nio/channels/FileChannel/Transfer.java
! test/java/nio/file/FileSystem/Basic.java
! test/sun/nio/ch/SelProvider.java
! test/tools/launcher/TestHelper.java

Changeset: 079bb040b2ee
Author:    coleenp
Date:      2012-04-19 10:53 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/079bb040b2ee

Merge


Changeset: 404c8e097ae9
Author:    vinnie
Date:      2012-04-19 16:58 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/404c8e097ae9

7162823: Modify the list of excluded tests (ProblemList
Reviewed-by: alanb

! test/ProblemList.txt

Changeset: bc51d0569ccd
Author:    khazra
Date:      2012-04-19 13:26 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bc51d0569ccd

7162385: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing again
Summary: Enable finding "foo1.jar"
Reviewed-by: chegar

! test/sun/net/www/protocol/jar/B4957695.java

Changeset: 715f50872ae7
Author:    khazra
Date:      2012-04-19 18:11 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/715f50872ae7

7158636: InterfaceAddress.getBroadcast() returns invalid broadcast address on WLAN
Summary: Update Windows native code to infer WLAN interface type in Windows Vista and later
Reviewed-by: chegar, alanb

! src/windows/native/java/net/NetworkInterface.c
! src/windows/native/java/net/NetworkInterface.h

Changeset: c3905c1f5da7
Author:    zhouyx
Date:      2012-04-20 16:11 +0800
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c3905c1f5da7

7159982: ZipFile uses static for error message when malformed zip file encountered
Reviewed-by: alanb, dholmes

! src/share/native/java/util/zip/ZipFile.c
! src/share/native/java/util/zip/zip_util.c

Changeset: ec9876082b4e
Author:    ksrini
Date:      2012-04-22 06:54 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ec9876082b4e

6981776: Pack200 must support -target 7 bytecodes
Summary: pack200 implementation of JSR-200 updated for JSR-292 changes
Reviewed-by: jrose, ksrini
Contributed-by: john.r.rose at oracle.com, kumar.x.srinivasan at oracle.com

! src/share/classes/com/sun/java/util/jar/pack/Attribute.java
! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java
! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java
! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java
! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java
! src/share/classes/com/sun/java/util/jar/pack/Constants.java
! src/share/classes/com/sun/java/util/jar/pack/Instruction.java
! src/share/classes/com/sun/java/util/jar/pack/Package.java
! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java
! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java
! src/share/classes/com/sun/java/util/jar/pack/TLGlobals.java
! src/share/classes/com/sun/java/util/jar/pack/Utils.java
! src/share/native/com/sun/java/util/jar/pack/bands.cpp
! src/share/native/com/sun/java/util/jar/pack/bands.h
! src/share/native/com/sun/java/util/jar/pack/constants.h
! src/share/native/com/sun/java/util/jar/pack/defines.h
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp
! src/share/native/com/sun/java/util/jar/pack/unpack.h
! test/tools/pack200/AttributeTests.java
! test/tools/pack200/PackageVersionTest.java
! test/tools/pack200/Utils.java
- test/tools/pack200/dyn.jar
! test/tools/pack200/pack200-verifier/data/README
! test/tools/pack200/pack200-verifier/data/golden.jar
! test/tools/pack200/pack200-verifier/make/build.xml
! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java

Changeset: c2da01f0bdc1
Author:    alanb
Date:      2012-04-22 19:09 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c2da01f0bdc1

7163395: jdk8/tl no longer builds on Mac
Reviewed-by: chegar, ohair, ksrini

- src/macosx/bin/amd64/jvm.cfg
+ src/macosx/bin/x86_64/jvm.cfg

Changeset: 07dab8d9e34a
Author:    alanb
Date:      2012-04-22 19:12 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/07dab8d9e34a

Merge

- test/tools/pack200/dyn.jar
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java

Changeset: 1980be18d0f8
Author:    alanb
Date:      2012-04-22 21:22 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1980be18d0f8

7132924: (dc) DatagramChannel.disconnect throws SocketException with IPv4 socket and IPv6 enabled [macosx]
Reviewed-by: chegar

! src/share/classes/sun/nio/ch/DatagramChannelImpl.java
! src/solaris/native/sun/nio/ch/DatagramChannelImpl.c
! src/windows/native/sun/nio/ch/DatagramChannelImpl.c
+ test/java/nio/channels/DatagramChannel/Disconnect.java

Changeset: fd22345bf1bf
Author:    sla
Date:      2012-04-23 16:34 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fd22345bf1bf

7163524: Add SecTaskAccess attribute to jstack [macosx]
Reviewed-by: dholmes

! make/launchers/Makefile.launcher

Changeset: 2c35304e885a
Author:    youdwei
Date:      2012-04-24 21:06 +0800
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2c35304e885a

7163865: Performance improvement for DateFormatSymbols.getZoneIndex(String)
Reviewed-by: okutsu

! src/share/classes/java/text/DateFormatSymbols.java

Changeset: f68c854fa584
Author:    ksrini
Date:      2012-04-24 10:37 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f68c854fa584

7151434: java -jar -XX crashes java launcher
Reviewed-by: mchung, darcy

! src/share/bin/java.c
! test/tools/launcher/Arrrghs.java
! test/tools/launcher/TestHelper.java

Changeset: fcdbd1f34309
Author:    khazra
Date:      2012-04-24 14:59 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fcdbd1f34309

7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()
Summary: Get default interface for Mac OS X when interface is not set
Reviewed-by: chegar

! src/solaris/native/java/net/PlainDatagramSocketImpl.c
! src/solaris/native/java/net/net_util_md.c

Changeset: 3e398b549cea
Author:    khazra
Date:      2012-04-25 12:31 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3e398b549cea

7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx]
Summary: Insert null check of argument in remove()'s implementation
Reviewed-by: forax, chegar, alanb

! src/macosx/classes/java/util/prefs/MacOSXPreferences.java
+ test/java/util/prefs/RemoveNullKeyCheck.java

Changeset: 108a02a57b75
Author:    khazra
Date:      2012-04-26 12:04 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/108a02a57b75

7118100: (prefs) Inconsistency when using system and user preference on OSX Lion
Summary: Enable user to read/write preferences to persistent storage
Reviewed-by: alanb

! src/macosx/classes/java/util/prefs/MacOSXPreferences.java
! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java

Changeset: 1cdcca9f3530
Author:    lana
Date:      2012-04-26 14:21 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1cdcca9f3530

Merge


Changeset: f0842ed897c3
Author:    xuelei
Date:      2012-04-27 04:25 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f0842ed897c3

6996372: synchronizing handshaking hash
Summary: remove the unnecessary synchronization. Also reviewed by David Schlosnagle (schlosna at gmail.com)
Reviewed-by: weijun

! src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java

Changeset: c22b2f9066dd
Author:    alanb
Date:      2012-05-01 11:17 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c22b2f9066dd

7164570: (fs) WatchService queues CREATE event but not DELETE event for very short lived files [sol11]
Reviewed-by: chegar

! src/solaris/classes/sun/nio/fs/SolarisWatchService.java
+ test/java/nio/file/WatchService/MayFlies.java

Changeset: 71fdf32fdc65
Author:    xuelei
Date:      2012-05-01 03:48 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/71fdf32fdc65

7158688: Typo in SSLContext Spec
Reviewed-by: weijun, wetmore

! src/share/classes/javax/net/ssl/SSLContext.java

Changeset: 6c9c3d7ce9e2
Author:    lana
Date:      2012-05-01 11:30 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6c9c3d7ce9e2

Merge


Changeset: 46e0bd218fcc
Author:    mchung
Date:      2012-05-01 19:45 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/46e0bd218fcc

7164376: Replace use of sun.security.action.LoadLibraryAction with System.loadLibrary
Reviewed-by: alanb, mullan, prr

! src/macosx/classes/apple/launcher/JavaAppLauncher.java
! src/macosx/classes/apple/security/KeychainStore.java
! src/macosx/classes/com/apple/concurrent/LibDispatchNative.java
! src/macosx/classes/com/apple/eawt/Application.java
! src/macosx/classes/com/apple/eio/FileManager.java
! src/macosx/classes/com/apple/laf/AquaFileView.java
! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java
! src/macosx/classes/com/apple/laf/AquaNativeResources.java
! src/macosx/classes/com/apple/laf/ScreenMenu.java
! src/macosx/classes/com/apple/laf/ScreenPopupFactory.java
! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java
! src/macosx/classes/sun/awt/CGraphicsEnvironment.java
! src/macosx/classes/sun/lwawt/macosx/CAccessibility.java
! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java
! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java
! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java
! src/share/classes/java/awt/SplashScreen.java
! src/share/classes/java/awt/Toolkit.java
! src/share/classes/java/awt/event/NativeLibLoader.java
! src/share/classes/java/awt/image/ColorModel.java
! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java
! src/share/classes/java/net/AbstractPlainSocketImpl.java
! src/share/classes/java/net/DatagramPacket.java
! src/share/classes/java/net/InetAddress.java
! src/share/classes/java/net/NetworkInterface.java
! src/share/classes/sun/awt/NativeLibLoader.java
! src/share/classes/sun/awt/image/JPEGImageDecoder.java
! src/share/classes/sun/awt/image/NativeLibLoader.java
! src/share/classes/sun/java2d/Disposer.java
! src/share/classes/sun/management/ManagementFactoryHelper.java
! src/share/classes/sun/net/sdp/SdpSupport.java
! src/share/classes/sun/net/spi/DefaultProxySelector.java
! src/share/classes/sun/nio/ch/Util.java
- src/share/classes/sun/security/action/LoadLibraryAction.java
! src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java
! src/share/classes/sun/security/smartcardio/PCSC.java
! src/share/classes/sun/tracing/dtrace/JVM.java
! src/solaris/classes/sun/management/FileSystemImpl.java
! src/solaris/classes/sun/net/dns/ResolverConfigurationImpl.java
! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java
! src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java
! src/solaris/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java
! src/solaris/classes/sun/print/CUPSPrinter.java
! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java
! src/windows/classes/sun/awt/windows/WToolkit.java
! src/windows/classes/sun/management/FileSystemImpl.java
! src/windows/classes/sun/net/dns/ResolverConfigurationImpl.java
! src/windows/classes/sun/print/Win32PrintServiceLookup.java
! src/windows/classes/sun/security/smartcardio/PlatformPCSC.java

Changeset: d78c6095dc98
Author:    vinnie
Date:      2012-05-02 14:50 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d78c6095dc98

7087021: TEST: com/sun/crypto/provider/Mac/MacClone.java failed on Solaris sparc 5.10
Reviewed-by: mullan

! test/com/sun/crypto/provider/Mac/MacClone.java

Changeset: 717582c056f3
Author:    lana
Date:      2012-05-02 10:17 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/717582c056f3

Merge

- src/macosx/bin/amd64/jvm.cfg
- src/share/classes/sun/security/action/LoadLibraryAction.java
! test/tools/launcher/TestHelper.java
- test/tools/pack200/dyn.jar
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java

Changeset: bc0f9e693620
Author:    lana
Date:      2012-05-08 13:08 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bc0f9e693620

Merge

- src/macosx/bin/amd64/jvm.cfg
- src/share/classes/sun/security/action/LoadLibraryAction.java
- test/tools/pack200/dyn.jar
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java

Changeset: 185821106403
Author:    katleman
Date:      2012-05-09 13:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/185821106403

Added tag jdk8-b37 for changeset 9e82ac15ab80

! .hgtags

Changeset: c45f3509a707
Author:    katleman
Date:      2012-05-09 13:13 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c45f3509a707

Merge

- src/macosx/bin/amd64/jvm.cfg
- src/share/classes/sun/security/action/LoadLibraryAction.java
- test/tools/pack200/dyn.jar
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java

Changeset: 18842bb6676a
Author:    lana
Date:      2012-05-10 11:47 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/18842bb6676a

Merge

- src/macosx/bin/amd64/jvm.cfg
- src/share/classes/sun/security/action/LoadLibraryAction.java
- test/tools/pack200/dyn.jar
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java
- test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java
- test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java



From anthony.petrov at oracle.com  Fri May 11 04:30:46 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 11 May 2012 15:30:46 +0400
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7024963: Notepad demo: remove
 non-translatable resources from Notepad.properties file
In-Reply-To: <4FABDBDF.1000100@oracle.com>
References: <20120504091710.AAE9F4714C@hg.openjdk.java.net>
	<4FABDBDF.1000100@oracle.com>
Message-ID: <4FACF866.7050209@oracle.com>

I've filed 7168151 to track this issue.

--
best regards,
Anthony

On 5/10/2012 7:16 PM, Sergey Bylokhov wrote:
> Hi, Alexandr.
> In this fix fileDialog variable was deleted from the Notepad.java. But 
> it is used in Stylepad demo. So now full jdk build failed with error:
> 
> C:\moe\workspaces\jdk\8\awt-mix\build\windows-i586\democlasses\demo\jfc\Stylepad\src\Stylepad.java:249: 
> error: cannot find symbol
>             if (fileDialog == null) {
>                 ^
>   symbol:   variable fileDialog
>   location: class Stylepad.OpenAction
> 
> 04.05.2012 13:16, alexandr.scherbatiy at oracle.com wrote:
>> Changeset: a714e2e2b257
>> Author:    alexsch
>> Date:      2012-05-04 13:15 +0400
>> URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a714e2e2b257
>>
>> 7024963: Notepad demo: remove non-translatable resources from 
>> Notepad.properties file
>> Reviewed-by: rupashka
>>
>> ! src/share/demo/jfc/Notepad/Notepad.java
>> ! src/share/demo/jfc/Notepad/resources/Notepad.properties
>> + src/share/demo/jfc/Notepad/resources/system.properties
>>
> 


From anthony.petrov at oracle.com  Fri May 11 05:11:45 2012
From: anthony.petrov at oracle.com (anthony.petrov at oracle.com)
Date: Fri, 11 May 2012 12:11:45 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7166437: [macosx] Support for
	Window.Type.UTILITY	on the Mac
Message-ID: <20120511121214.AD5244727C@hg.openjdk.java.net>

Changeset: 4f39a13e74c6
Author:    anthony
Date:      2012-05-11 16:11 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4f39a13e74c6

7166437: [macosx] Support for Window.Type.UTILITY on the Mac
Summary: Apply the native UTILITY style for UTILITY Java windows
Reviewed-by: art

! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java



From anthony.petrov at oracle.com  Fri May 11 08:55:59 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 11 May 2012 19:55:59 +0400
Subject: <AWT Dev> [7u6] Review request for 7166437: [macosx] Support for
 Window.Type.UTILITY on the Mac
Message-ID: <4FAD368F.60509@oracle.com>

Hello,

This is a backport of exactly the same fix from JDK 8.

Bug: http://bugs.sun.com/view_bug.do?bug_id=7166437

Fix: http://cr.openjdk.java.net/~anthony/7u6-8-UTILITY-7166437.0/

--
best regards,
Anthony


From Sergey.Bylokhov at oracle.com  Fri May 11 09:08:58 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 11 May 2012 20:08:58 +0400
Subject: <AWT Dev> [7u6] Review request for 7166437: [macosx] Support
 for Window.Type.UTILITY on the Mac
In-Reply-To: <4FAD368F.60509@oracle.com>
References: <4FAD368F.60509@oracle.com>
Message-ID: <4FAD399A.3060307@oracle.com>

Hi, Anthony.
Fix looks good.

11.05.2012 19:55, Anthony Petrov wrote:
> Hello,
>
> This is a backport of exactly the same fix from JDK 8.
>
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7166437
>
> Fix: http://cr.openjdk.java.net/~anthony/7u6-8-UTILITY-7166437.0/
>
> -- 
> best regards,
> Anthony



From alexander.zuev at oracle.com  Fri May 11 09:32:38 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Fri, 11 May 2012 20:32:38 +0400
Subject: <AWT Dev> [7u6] Review request for 7166437: [macosx] Support
 for Window.Type.UTILITY on the Mac
In-Reply-To: <4FAD368F.60509@oracle.com>
References: <4FAD368F.60509@oracle.com>
Message-ID: <4FAD3F26.6030500@oracle.com>

Pretty straightforward fix. Looks fine.

With best regards,
Alexander Zuev

On 5/11/12 19:55, Anthony Petrov wrote:
> Hello,
>
> This is a backport of exactly the same fix from JDK 8.
>
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7166437
>
> Fix: http://cr.openjdk.java.net/~anthony/7u6-8-UTILITY-7166437.0/
>
> -- 
> best regards,
> Anthony



From anthony.petrov at oracle.com  Fri May 11 09:37:30 2012
From: anthony.petrov at oracle.com (anthony.petrov at oracle.com)
Date: Fri, 11 May 2012 16:37:30 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7149062: [macosx] dock menu don't show
	available	frames
Message-ID: <20120511163804.E37AB47293@hg.openjdk.java.net>

Changeset: 689c0cd214e8
Author:    anthony
Date:      2012-05-11 20:37 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/689c0cd214e8

7149062: [macosx] dock menu don't show available frames
Summary: Inherit from either NSWindow for normal windows or NSPanel for utility windows
Reviewed-by: skovatch, swingler

! src/macosx/native/sun/awt/AWTView.m
! src/macosx/native/sun/awt/AWTWindow.h
! src/macosx/native/sun/awt/AWTWindow.m



From alexandr.scherbatiy at oracle.com  Sat May 12 01:02:58 2012
From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com)
Date: Sat, 12 May 2012 08:02:58 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7024965: Stylepad demo: remove
	non-translatable	resources from Stylepad.properties file
Message-ID: <20120512080329.5FB92472BA@hg.openjdk.java.net>

Changeset: 3b8635e357e9
Author:    alexsch
Date:      2012-05-12 12:01 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3b8635e357e9

7024965: Stylepad demo: remove non-translatable resources from Stylepad.properties file
Reviewed-by: alexp

! src/share/demo/jfc/Notepad/Notepad.java
+ src/share/demo/jfc/Notepad/resources/NotepadSystem.properties
- src/share/demo/jfc/Notepad/resources/system.properties



From alexandr.scherbatiy at oracle.com  Sat May 12 03:50:47 2012
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Sat, 12 May 2012 14:50:47 +0400
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7024963: Notepad demo: remove
 non-translatable resources from Notepad.properties file
In-Reply-To: <4FACF866.7050209@oracle.com>
References: <20120504091710.AAE9F4714C@hg.openjdk.java.net>
	<4FABDBDF.1000100@oracle.com> <4FACF866.7050209@oracle.com>
Message-ID: <4FAE4087.5060708@oracle.com>

On 5/11/2012 3:30 PM, Anthony Petrov wrote:
> I've filed 7168151 to track this issue.

     Sorry. It should be fixed now as part of the issue 7024965 fix.

    Thanks,
    Alexandr.

>
> -- 
> best regards,
> Anthony
>
> On 5/10/2012 7:16 PM, Sergey Bylokhov wrote:
>> Hi, Alexandr.
>> In this fix fileDialog variable was deleted from the Notepad.java. 
>> But it is used in Stylepad demo. So now full jdk build failed with 
>> error:
>>
>> C:\moe\workspaces\jdk\8\awt-mix\build\windows-i586\democlasses\demo\jfc\Stylepad\src\Stylepad.java:249: 
>> error: cannot find symbol
>>             if (fileDialog == null) {
>>                 ^
>>   symbol:   variable fileDialog
>>   location: class Stylepad.OpenAction
>>
>> 04.05.2012 13:16, alexandr.scherbatiy at oracle.com wrote:
>>> Changeset: a714e2e2b257
>>> Author:    alexsch
>>> Date:      2012-05-04 13:15 +0400
>>> URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a714e2e2b257
>>>
>>> 7024963: Notepad demo: remove non-translatable resources from 
>>> Notepad.properties file
>>> Reviewed-by: rupashka
>>>
>>> ! src/share/demo/jfc/Notepad/Notepad.java
>>> ! src/share/demo/jfc/Notepad/resources/Notepad.properties
>>> + src/share/demo/jfc/Notepad/resources/system.properties
>>>
>>



From anthony.petrov at oracle.com  Sat May 12 05:20:51 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Sat, 12 May 2012 16:20:51 +0400
Subject: <AWT Dev> [7u6] Review request for 7149062: [macosx] dock menu
 don't show available frames
Message-ID: <4FAE55A3.5040405@oracle.com>

Hello,

This is almost a direct back-port of the same fix from JDK 8.

Bug: http://bugs.sun.com/view_bug.do?bug_id=7149062

Fix: 
http://cr.openjdk.java.net/~anthony/7u6-9-windowListInDockMenu-7149062.0/

--
best regards,
Anthony



From alexander.potochkin at oracle.com  Sat May 12 06:16:11 2012
From: alexander.potochkin at oracle.com (alexander.potochkin at oracle.com)
Date: Sat, 12 May 2012 13:16:11 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7149005: [macosx] Java Control Panel's
	UI controls	are distorted when draging scroll bar.
Message-ID: <20120512131634.74BA8472BD@hg.openjdk.java.net>

Changeset: cc8d1cc533bf
Author:    alexp
Date:      2012-05-12 17:46 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cc8d1cc533bf

7149005: [macosx] Java Control Panel's UI controls are distorted when draging scroll bar.
Reviewed-by: serb

! src/macosx/classes/com/apple/laf/AquaButtonLabeledUI.java



From anton.tarasov at oracle.com  Sat May 12 07:54:29 2012
From: anton.tarasov at oracle.com (anton.tarasov at oracle.com)
Date: Sat, 12 May 2012 14:54:29 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7110683: Issues with some
	KeyboardFocusManager	method
Message-ID: <20120512145440.85A10472BE@hg.openjdk.java.net>

Changeset: 69301efaac91
Author:    ant
Date:      2012-05-12 18:50 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/69301efaac91

7110683: Issues with some KeyboardFocusManager method
Reviewed-by: ahgross

! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/DefaultKeyboardFocusManager.java
! src/share/classes/java/awt/KeyboardFocusManager.java
! src/share/classes/java/awt/Window.java



From jaroslav.tulach at oracle.com  Sat May 12 01:45:58 2012
From: jaroslav.tulach at oracle.com (Jaroslav Tulach)
Date: Sat, 12 May 2012 10:45:58 +0200
Subject: <AWT Dev> Make jdk8/jdk/make/netbeans/awt2d project usable again
Message-ID: <3856074.GxOIHSe7E0@logoutik>

Hi.
I was trying to play with AWT code by opening jdk8/jdk/make/netbeans/awt2d 
project. Alas, the IDE reports error in EventQueue.java. PlatformLogger is 
unknown. I believe this is because of no longer correct includes/excludes in 
the project metadata.

I am attaching a patch that seems to fix the problem. Can somebody with commit 
rights integrated it? Thanks.
-jt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: X.diff
Type: text/x-patch
Size: 357 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120512/fa0f9316/X.diff 

From magnus.ihse.bursie at oracle.com  Mon May 14 01:18:53 2012
From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie)
Date: Mon, 14 May 2012 10:18:53 +0200
Subject: <AWT Dev> [OpenJDK 2D-Dev] Request for Review: Remove import of
 empty JNI header files
In-Reply-To: <5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com>
References: <4F97FFC3.3090509@oracle.com> <4F9817D6.8080701@oracle.com>
	<4F989F8F.6000905@oracle.com> <4F98FAD2.7030808@oracle.com>
	<5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com>
Message-ID: <4FB0BFED.8000107@oracle.com>

On 2012-05-02 00:19, Kelly Ohair wrote:
> Magnus,
>
> Do you still need this integrated?
> I can integrate the exact same changset to awt, 2d,  and build forests if you want.

Yes, I still like to have this integrated. (Sorry for the slow response, 
it's been a bit low on the priority list.) Otherwise we need to add a 
@GenerateNativeHeaders annotation to a class that only generates an 
empty header file, and that looks kind of silly. :-)

/Magnus


From dmitry.cherepanov at oracle.com  Mon May 14 07:30:57 2012
From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov)
Date: Mon, 14 May 2012 18:30:57 +0400
Subject: <AWT Dev> [8] Review request for 7124337: [macosx] FileDialog fails
 to select multiple files
Message-ID: <4FB11721.8070907@oracle.com>

This is a direct forward port (including a minor change for 7147066) of 
the fix to jdk8.

Bug: http://bugs.sun.com/view_bug.do?bug_id=7124337

Webrev: http://cr.openjdk.java.net/~dcherepanov/7124337/8/webrev.0/

Thanks,
Dmitry



From Sergey.Bylokhov at oracle.com  Mon May 14 08:40:01 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 14 May 2012 19:40:01 +0400
Subject: <AWT Dev> [7u6] Request for review: 7080109 Dialog.show() lacks
 doPrivileged() to access system event queue
Message-ID: <4FB12751.5060000@oracle.com>

Hi Everyone,
This is a back port from jdk 8 to jdk 7u6.
In the fix doPrivileged was added to Dialog.show().

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
Webrev can be found at: http://cr.openjdk.java.net/~serb/7080109/webrev.01
jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/912e666b4e1d

-- 
Best regards, Sergey.



From Sergey.Bylokhov at oracle.com  Mon May 14 08:40:14 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 14 May 2012 19:40:14 +0400
Subject: <AWT Dev> [7u6] Request for review: 7080109 Dialog.show() lacks
 doPrivileged() to access system event queue
Message-ID: <4FB1275E.5030701@oracle.com>

Hi Everyone,
This is a back port from jdk 8 to jdk 7u6.
In the fix doPrivileged was added to Dialog.show().

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
Webrev can be found at: http://cr.openjdk.java.net/~serb/7080109/webrev.01
jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/912e666b4e1d

-- 
Best regards, Sergey.



From swingler at apple.com  Mon May 14 09:24:26 2012
From: swingler at apple.com (Mike Swingler)
Date: Mon, 14 May 2012 09:24:26 -0700
Subject: <AWT Dev> [8] Review request for 7124337: [macosx] FileDialog
 fails to select multiple files
In-Reply-To: <4FB11721.8070907@oracle.com>
References: <4FB11721.8070907@oracle.com>
Message-ID: <04BF6C8B-B09A-434A-8248-7229AC0470BD@apple.com>

On May 14, 2012, at 7:30 AM, Dmitry Cherepanov wrote:

> This is a direct forward port (including a minor change for 7147066) of the fix to jdk8.
> 
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7124337
> 
> Webrev: http://cr.openjdk.java.net/~dcherepanov/7124337/8/webrev.0/

Looks good,
Mike Swingler
Apple Inc.



From Sergey.Bylokhov at oracle.com  Mon May 14 09:44:06 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 14 May 2012 20:44:06 +0400
Subject: <AWT Dev> [7u6] Request for review: 7160623 [macosx] Editable
 TextArea/TextField are blocking GUI applications from exit
In-Reply-To: <4FA3C6EC.5020205@oracle.com>
References: <4FA2A14B.8040501@oracle.com> <4FA3C6EC.5020205@oracle.com>
Message-ID: <4FB13656.3000302@oracle.com>

Thanks, Anthony.
Does anybody has a chance to review the fix? One more reviewer needed.

04.05.2012 16:09, Anthony Petrov wrote:
> The fix still looks fine.
>
> -- 
> best regards,
> Anthony
>
> On 5/3/2012 7:16 PM, Sergey Bylokhov wrote:
>> Hi Everyone,
>> This is a back port from jdk 8 to jdk 7u6.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160623
>> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c31eeeda3ed1
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7160623/webrev.00
>>
>> Discussion about the same xawt fix: 
>> http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002381.html


-- 
Best regards, Sergey.



From swingler at apple.com  Mon May 14 09:54:18 2012
From: swingler at apple.com (Mike Swingler)
Date: Mon, 14 May 2012 09:54:18 -0700
Subject: <AWT Dev> [7u6] Review request for 7149062: [macosx] dock menu
 don't show available frames
In-Reply-To: <4FAE55A3.5040405@oracle.com>
References: <4FAE55A3.5040405@oracle.com>
Message-ID: <1740289B-A97E-41E5-84BC-E7B3F520A190@apple.com>

On May 12, 2012, at 5:20 AM, Anthony Petrov wrote:

> Hello,
> 
> This is almost a direct back-port of the same fix from JDK 8.
> 
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7149062
> 
> Fix: http://cr.openjdk.java.net/~anthony/7u6-9-windowListInDockMenu-7149062.0/

Looks good,
Mike Swingler
Apple Inc.



From alexander.zuev at oracle.com  Mon May 14 10:28:50 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Mon, 14 May 2012 21:28:50 +0400
Subject: <AWT Dev> [7u6] Request for review: 7160623 [macosx] Editable
 TextArea/TextField are blocking GUI applications from exit
In-Reply-To: <4FB13656.3000302@oracle.com>
References: <4FA2A14B.8040501@oracle.com> <4FA3C6EC.5020205@oracle.com>
	<4FB13656.3000302@oracle.com>
Message-ID: <4FB140D2.60101@oracle.com>

Fix looks fine.
WBR,
Alex

On 5/14/12 20:44, Sergey Bylokhov wrote:
> Thanks, Anthony.
> Does anybody has a chance to review the fix? One more reviewer needed.
>
> 04.05.2012 16:09, Anthony Petrov wrote:
>> The fix still looks fine.
>>
>> -- 
>> best regards,
>> Anthony
>>
>> On 5/3/2012 7:16 PM, Sergey Bylokhov wrote:
>>> Hi Everyone,
>>> This is a back port from jdk 8 to jdk 7u6.
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160623
>>> jdk8 changeset: 
>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c31eeeda3ed1
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/7160623/webrev.00
>>>
>>> Discussion about the same xawt fix: 
>>> http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002381.html
>
>



From dmitry.cherepanov at oracle.com  Tue May 15 04:00:16 2012
From: dmitry.cherepanov at oracle.com (dmitry.cherepanov at oracle.com)
Date: Tue, 15 May 2012 11:00:16 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7168550: [macosx] duplicate OGL context
	state	changes related to vertex cache
Message-ID: <20120515110050.7E82D47315@hg.openjdk.java.net>

Changeset: 28ec5b811aa2
Author:    dcherepanov
Date:      2012-05-15 15:04 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/28ec5b811aa2

7168550: [macosx] duplicate OGL context state changes related to vertex cache
Reviewed-by: bae, swingler

! src/macosx/native/sun/java2d/opengl/CGLSurfaceData.m
! src/share/native/sun/java2d/opengl/OGLContext.h
! src/share/native/sun/java2d/opengl/OGLTextRenderer.c
! src/share/native/sun/java2d/opengl/OGLVertexCache.c
! src/share/native/sun/java2d/opengl/OGLVertexCache.h



From anthony.petrov at oracle.com  Tue May 15 06:26:30 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Tue, 15 May 2012 17:26:30 +0400
Subject: <AWT Dev> [8] Review request for 7168851: [macosx] Netbeans crashes
	in CImage.nativeCreateNSImageFromArray
Message-ID: <4FB25986.6060908@oracle.com>

Hi Dmitry,

Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7168851 at:

http://cr.openjdk.java.net/~anthony/8-32-nativeCreateNSImageFromArrayCrash-7168851.0/

--
best regards,
Anthony


From dmitry.cherepanov at oracle.com  Tue May 15 06:59:17 2012
From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov)
Date: Tue, 15 May 2012 17:59:17 +0400
Subject: <AWT Dev> [8] Review request for 7168851: [macosx] Netbeans
 crashes in CImage.nativeCreateNSImageFromArray
In-Reply-To: <4FB25986.6060908@oracle.com>
References: <4FB25986.6060908@oracle.com>
Message-ID: <4FB26135.2020107@oracle.com>

Hi Anthony,

Thanks for fixing this, minor comment:

- 166         [reps release];

Looks fine to me as [NSMutableArray arrayWithCapacity:] returns 
auto-released object.

- 117         [imageRep release];

We should probably keep this 'release' as, looks like, it corresponds to 
"[NSBitmapImageRep alloc] ..."  from CImage_CreateImageRep.

Thanks,
Dmitry


Anthony Petrov wrote:
> Hi Dmitry,
>
> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7168851 
> at:
>
> http://cr.openjdk.java.net/~anthony/8-32-nativeCreateNSImageFromArrayCrash-7168851.0/ 
>
>
> -- 
> best regards,
> Anthony



From anthony.petrov at oracle.com  Tue May 15 07:08:36 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Tue, 15 May 2012 18:08:36 +0400
Subject: <AWT Dev> [8] Review request for 7168851: [macosx] Netbeans
 crashes in CImage.nativeCreateNSImageFromArray
In-Reply-To: <4FB26135.2020107@oracle.com>
References: <4FB25986.6060908@oracle.com> <4FB26135.2020107@oracle.com>
Message-ID: <4FB26364.1080000@oracle.com>

On 5/15/2012 5:59 PM, Dmitry Cherepanov wrote:
> Thanks for fixing this, minor comment:
> 
> - 166         [reps release];
> 
> Looks fine to me as [NSMutableArray arrayWithCapacity:] returns 
> auto-released object.
> 
> - 117         [imageRep release];
> 
> We should probably keep this 'release' as, looks like, it corresponds to 
> "[NSBitmapImageRep alloc] ..."  from CImage_CreateImageRep.

"I've learned something today!" :)

Indeed. A good catch! Thank you. Here's an updated fix:

http://cr.openjdk.java.net/~anthony/8-32-nativeCreateNSImageFromArrayCrash-7168851.1/

--
best regards,
Anthony

> 
> Thanks,
> Dmitry
> 
> 
> Anthony Petrov wrote:
>> Hi Dmitry,
>>
>> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7168851 
>> at:
>>
>> http://cr.openjdk.java.net/~anthony/8-32-nativeCreateNSImageFromArrayCrash-7168851.0/ 
>>
>>
>> -- 
>> best regards,
>> Anthony
> 


From dmitry.cherepanov at oracle.com  Tue May 15 07:15:28 2012
From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov)
Date: Tue, 15 May 2012 18:15:28 +0400
Subject: <AWT Dev> [8] Review request for 7168851: [macosx] Netbeans
 crashes in CImage.nativeCreateNSImageFromArray
In-Reply-To: <4FB26364.1080000@oracle.com>
References: <4FB25986.6060908@oracle.com> <4FB26135.2020107@oracle.com>
	<4FB26364.1080000@oracle.com>
Message-ID: <4FB26500.2030104@oracle.com>

Anthony Petrov wrote:
> On 5/15/2012 5:59 PM, Dmitry Cherepanov wrote:
>> Thanks for fixing this, minor comment:
>>
>> - 166         [reps release];
>>
>> Looks fine to me as [NSMutableArray arrayWithCapacity:] returns 
>> auto-released object.
>>
>> - 117         [imageRep release];
>>
>> We should probably keep this 'release' as, looks like, it corresponds 
>> to "[NSBitmapImageRep alloc] ..."  from CImage_CreateImageRep.
>
> "I've learned something today!" :)
>
> Indeed. A good catch! Thank you. Here's an updated fix:
>
> http://cr.openjdk.java.net/~anthony/8-32-nativeCreateNSImageFromArrayCrash-7168851.1/ 
>

Looks fine to me, thanks! :)

>
> -- 
> best regards,
> Anthony
>
>>
>> Thanks,
>> Dmitry
>>
>>
>> Anthony Petrov wrote:
>>> Hi Dmitry,
>>>
>>> Please review a fix for 
>>> http://bugs.sun.com/view_bug.do?bug_id=7168851 at:
>>>
>>> http://cr.openjdk.java.net/~anthony/8-32-nativeCreateNSImageFromArrayCrash-7168851.0/ 
>>>
>>>
>>> -- 
>>> best regards,
>>> Anthony
>>



From anthony.petrov at oracle.com  Tue May 15 08:17:40 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Tue, 15 May 2012 19:17:40 +0400
Subject: <AWT Dev> [8] Review request for 7124337: [macosx] FileDialog
 fails to select multiple files
In-Reply-To: <4FB11721.8070907@oracle.com>
References: <4FB11721.8070907@oracle.com>
Message-ID: <4FB27394.20502@oracle.com>

Looks fine to me.

--
best regards,
Anthony

On 5/14/2012 6:30 PM, Dmitry Cherepanov wrote:
> This is a direct forward port (including a minor change for 7147066) of 
> the fix to jdk8.
> 
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7124337
> 
> Webrev: http://cr.openjdk.java.net/~dcherepanov/7124337/8/webrev.0/
> 
> Thanks,
> Dmitry
> 


From anthony.petrov at oracle.com  Tue May 15 08:21:22 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Tue, 15 May 2012 19:21:22 +0400
Subject: <AWT Dev> [7u6] Request for review: 7080109 Dialog.show() lacks
 doPrivileged() to access system event queue
In-Reply-To: <4FB1275E.5030701@oracle.com>
References: <4FB1275E.5030701@oracle.com>
Message-ID: <4FB27472.5020501@oracle.com>

Looks good to me.

--
best regards,
Anthony

On 5/14/2012 7:40 PM, Sergey Bylokhov wrote:
> Hi Everyone,
> This is a back port from jdk 8 to jdk 7u6.
> In the fix doPrivileged was added to Dialog.show().
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
> Webrev can be found at: http://cr.openjdk.java.net/~serb/7080109/webrev.01
> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/912e666b4e1d
> 


From anthony.petrov at oracle.com  Tue May 15 09:46:49 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Tue, 15 May 2012 20:46:49 +0400
Subject: <AWT Dev> [7u6] Review request for 7144542: [macosx] Crash in
 liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline
In-Reply-To: <4FAB9983.9030506@oracle.com>
References: <4FA3ED6F.5010502@oracle.com> <4FAB9983.9030506@oracle.com>
Message-ID: <4FB28879.8080502@oracle.com>

Hi Artem,

On 5/10/2012 2:33 PM, Artem Ananiev wrote:
> On 5/4/2012 6:53 PM, Anthony Petrov wrote:
>> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7144542 
>> at:
>>
>> http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.0/
> 
> So what you do is to change headful CToolkit to headless XToolkit, 
> correct? Note that this change will also trigger Java2D pipeline change, 
> which might not be what we want.

Actually, while performing more testing I've found one issue with the 
fix: we must also choose the correct font manager class. Otherwise the 
MACOSX_PORT-705 is resurrected. An updated fix is here:

http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.1/

Meanwhile I've performed some performance measurement using the GUIMark2 
for FX, and here are some results:

BitmapTest:
    w/o the fix:  ~4.22 FPS
    with the fix: ~4.19 FPS

VectorTest:
    w/o the fix:  ~21.0 FPS
    with the fix: ~21.3 FPS

So it looks like there's no any major performance difference between the 
CToolkit and XToolkit Java2D pipelines.

> Have you tried to find out what exactly leads to the crash when CToolkit 
> is used?

Since the crash is actually happening in the HotSpot code, it's being 
investigated by HotSpot team under 7166725.

--
best regards,
Anthony


> 
> Thanks,
> 
> Artem
> 
>> Note: in JDK 8 we already load the headless version of the AWT library,
>> and this prevents the crash. Now I'm applying the same logic to JDK 7u6.
>>
>> -- 
>> best regards,
>> Anthony


From dmitry.cherepanov at oracle.com  Wed May 16 02:12:59 2012
From: dmitry.cherepanov at oracle.com (dmitry.cherepanov at oracle.com)
Date: Wed, 16 May 2012 09:12:59 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7124337: [macosx] FileDialog fails to
	select	multiple files
Message-ID: <20120516091432.9A3D047346@hg.openjdk.java.net>

Changeset: cad0bb1a9bdb
Author:    dcherepanov
Date:      2012-05-16 13:15 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cad0bb1a9bdb

7124337: [macosx] FileDialog fails to select multiple files
Reviewed-by: anthony, swingler

! src/macosx/classes/sun/lwawt/macosx/CFileDialog.java
! src/macosx/native/sun/awt/CFileDialog.h
! src/macosx/native/sun/awt/CFileDialog.m
! src/share/classes/java/awt/FileDialog.java
! src/share/classes/sun/awt/AWTAccessor.java
! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java
! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java
! src/windows/classes/sun/awt/windows/WFileDialogPeer.java



From anthony.petrov at oracle.com  Wed May 16 03:28:34 2012
From: anthony.petrov at oracle.com (anthony.petrov at oracle.com)
Date: Wed, 16 May 2012 10:28:34 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7168851: [macosx] Netbeans crashes
	in	CImage.nativeCreateNSImageFromArray
Message-ID: <20120516102853.0CF574734A@hg.openjdk.java.net>

Changeset: 7c0b390ab5f9
Author:    anthony
Date:      2012-05-16 14:28 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7c0b390ab5f9

7168851: [macosx] Netbeans crashes in CImage.nativeCreateNSImageFromArray
Summary: Eliminate unnecessary -release call
Reviewed-by: dcherepanov

! src/macosx/native/sun/awt/CImage.m



From alexandr.scherbatiy at oracle.com  Wed May 16 05:28:30 2012
From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com)
Date: Wed, 16 May 2012 12:28:30 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7169226: NLS: Please change the
	mnemonic assignment	system for windows and motif properties
Message-ID: <20120516122841.7FE314734E@hg.openjdk.java.net>

Changeset: 3c819d638e36
Author:    alexsch
Date:      2012-05-16 16:27 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3c819d638e36

7169226: NLS: Please change the mnemonic assignment system for windows and motif properties
Reviewed-by: rupashka

! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties



From alexandr.scherbatiy at oracle.com  Wed May 16 07:08:19 2012
From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com)
Date: Wed, 16 May 2012 14:08:19 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7158928: [macosx] NLS: Please change
	the mnemonic	assignment system
Message-ID: <20120516140829.4E6974734F@hg.openjdk.java.net>

Changeset: 19edcc438203
Author:    alexsch
Date:      2012-05-16 18:11 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/19edcc438203

7158928: [macosx] NLS: Please change the mnemonic assignment system
Reviewed-by: rupashka, serb

! make/com/apple/osxui/Makefile
! make/common/internal/Resources.gmk
! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java
! src/macosx/classes/com/apple/laf/resources/aqua.properties



From zhouyx at linux.vnet.ibm.com  Wed May 16 20:17:11 2012
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Thu, 17 May 2012 11:17:11 +0800
Subject: <AWT Dev> Request for review: 7071248 : IME composition window does
 not disappear when file dialog is closed
Message-ID: <CAOo=rxU-TuBPZQkQA6f6udV5n4kcMMnCid20GbqYksbYGEzxfA@mail.gmail.com>

Hi all,

    When verifying bug 7071248, I found the problem is not resolved,
because the original changeset(
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4) is not complete.
It lacks another one line change
in src/windows/native/sun/windows/awt_Component.cpp .
    The problem is only seen on windowsXP, but as the patch is half
committed, I think it's better to make it complete.
    The webrev to complete the patch:
http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/  . Please take a look.


original changeset:
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4
sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248


-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120517/7258979f/attachment.html 

From alexandr.scherbatiy at oracle.com  Thu May 17 03:23:35 2012
From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com)
Date: Thu, 17 May 2012 10:23:35 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7148281: [macosx] JTabbedPane tabs with
	HTML text	do not render correctly
Message-ID: <20120517102405.ED78547380@hg.openjdk.java.net>

Changeset: 731ee59c6ba2
Author:    alexsch
Date:      2012-05-17 14:27 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/731ee59c6ba2

7148281: [macosx] JTabbedPane tabs with HTML text do not render correctly
Reviewed-by: kizune

! src/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java



From pavel.porvatov at oracle.com  Thu May 17 04:43:32 2012
From: pavel.porvatov at oracle.com (pavel.porvatov at oracle.com)
Date: Thu, 17 May 2012 11:43:32 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk:
	7166322:	closed/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java	failed
	since 1.8.0b36
Message-ID: <20120517114345.EBA8D47382@hg.openjdk.java.net>

Changeset: f9217bd87199
Author:    rupashka
Date:      2012-05-17 15:41 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f9217bd87199

7166322: closed/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java failed since 1.8.0b36
Reviewed-by: alexsch

+ test/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java



From anton.tarasov at oracle.com  Thu May 17 06:27:33 2012
From: anton.tarasov at oracle.com (anton.tarasov at oracle.com)
Date: Thu, 17 May 2012 13:27:33 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7142565: [macosx] Many special keys
	processed twice	in text fields
Message-ID: <20120517132744.7D69A47385@hg.openjdk.java.net>

Changeset: c00d6508afce
Author:    ant
Date:      2012-05-17 21:27 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c00d6508afce

7142565: [macosx] Many special keys processed twice in text fields
Summary: forward port from 7u4
Reviewed-by: anthony

! src/macosx/native/sun/awt/AWTView.m



From anton.tarasov at oracle.com  Thu May 17 06:32:19 2012
From: anton.tarasov at oracle.com (anton.tarasov at oracle.com)
Date: Thu, 17 May 2012 13:32:19 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7154072: [macosx] swallowing key events
Message-ID: <20120517133229.22A3647386@hg.openjdk.java.net>

Changeset: 17c5e1a12965
Author:    ant
Date:      2012-05-17 21:31 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/17c5e1a12965

7154072: [macosx] swallowing key events
Summary: forward posrt from 7u4
Reviewed-by: anthony

! src/macosx/native/sun/awt/AWTView.m



From anton.tarasov at oracle.com  Thu May 17 06:49:12 2012
From: anton.tarasov at oracle.com (anton.tarasov at oracle.com)
Date: Thu, 17 May 2012 13:49:12 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7125044: [macosx] Test failure
	because	Component.transferFocus() works differently in applet
	and application.
Message-ID: <20120517134922.4821047388@hg.openjdk.java.net>

Changeset: ef77fa799b34
Author:    ant
Date:      2012-05-17 21:48 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ef77fa799b34

7125044: [macosx] Test failure because Component.transferFocus() works differently in applet and application.
Summary: forward port from 7u4
Reviewed-by: art

! src/share/classes/java/awt/Dialog.java
! src/share/classes/java/awt/Frame.java
! src/share/classes/java/awt/Window.java
! src/share/classes/javax/swing/JApplet.java
! src/share/classes/javax/swing/JDialog.java
! src/share/classes/javax/swing/JFrame.java
! src/share/classes/javax/swing/JInternalFrame.java
! src/share/classes/javax/swing/JWindow.java
! src/share/classes/javax/swing/UIManager.java
! src/share/classes/sun/awt/SunToolkit.java
+ test/java/awt/Focus/FocusTraversalPolicy/InitialFTP.java
+ test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_AWT.java
+ test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_Swing.java
+ test/java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java



From anton.tarasov at oracle.com  Thu May 17 07:10:56 2012
From: anton.tarasov at oracle.com (anton.tarasov at oracle.com)
Date: Thu, 17 May 2012 14:10:56 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7145768: [macosx] Regression: failure
	in b11 of	ModalDialogInFocusEventTest
Message-ID: <20120517141106.D81A747389@hg.openjdk.java.net>

Changeset: 5976b5848554
Author:    ant
Date:      2012-05-17 22:10 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5976b5848554

7145768: [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest
Summary: forward port from 7u4
Reviewed-by: art

! src/macosx/classes/sun/lwawt/LWComponentPeer.java
! src/macosx/classes/sun/lwawt/LWWindowPeer.java



From anton.tarasov at oracle.com  Thu May 17 07:21:42 2012
From: anton.tarasov at oracle.com (anton.tarasov at oracle.com)
Date: Thu, 17 May 2012 14:21:42 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7145827: [macosx] JCK failure in
	b11:	FocusableWindow3
Message-ID: <20120517142152.F1C564738A@hg.openjdk.java.net>

Changeset: 1d75ff45586e
Author:    ant
Date:      2012-05-17 22:21 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1d75ff45586e

7145827: [macosx] JCK failure in b11: FocusableWindow3
Summary: forward posrt from 7u4
Reviewed-by: art

! src/macosx/classes/sun/lwawt/LWWindowPeer.java



From zhouyx at linux.vnet.ibm.com  Thu May 17 19:52:16 2012
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Fri, 18 May 2012 10:52:16 +0800
Subject: <AWT Dev> Fwd: Request for review: 7071248 : IME composition window
 does not disappear when file dialog is closed
In-Reply-To: <CAOo=rxU-TuBPZQkQA6f6udV5n4kcMMnCid20GbqYksbYGEzxfA@mail.gmail.com>
References: <CAOo=rxU-TuBPZQkQA6f6udV5n4kcMMnCid20GbqYksbYGEzxfA@mail.gmail.com>
Message-ID: <CAOo=rxU3g_oju+UmOkT7r5rXRb6cRJquxvO1EQo+SAwn1FfHsA@mail.gmail.com>

Hello, would anyone like to take a look at this ?


---------- Forwarded message ----------
From: Sean Chou <zhouyx at linux.vnet.ibm.com>
Date: Thu, May 17, 2012 at 11:17 AM
Subject: <AWT Dev> Request for review: 7071248 : IME composition window
does not disappear when file dialog is closed
To: OpenJDK awt-dev <awt-dev at openjdk.java.net>


Hi all,

    When verifying bug 7071248, I found the problem is not resolved,
because the original changeset(
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4) is not complete.
It lacks another one line change
in src/windows/native/sun/windows/awt_Component.cpp .
    The problem is only seen on windowsXP, but as the patch is half
committed, I think it's better to make it complete.
    The webrev to complete the patch:
http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/  . Please take a look.


original changeset:
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4
sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248


-- 
Best Regards,
Sean Chou




-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120518/bd156d8a/attachment.html 

From artem.ananiev at oracle.com  Fri May 18 06:43:14 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Fri, 18 May 2012 17:43:14 +0400
Subject: <AWT Dev> [7u6] Review request for 7144542: [macosx] Crash in
 liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline
In-Reply-To: <4FB28879.8080502@oracle.com>
References: <4FA3ED6F.5010502@oracle.com> <4FAB9983.9030506@oracle.com>
	<4FB28879.8080502@oracle.com>
Message-ID: <4FB651F2.4050706@oracle.com>


Looks fine. Thanks for additional testing!

Artem

On 5/15/2012 8:46 PM, Anthony Petrov wrote:
> Hi Artem,
>
> On 5/10/2012 2:33 PM, Artem Ananiev wrote:
>> On 5/4/2012 6:53 PM, Anthony Petrov wrote:
>>> Please review a fix for
>>> http://bugs.sun.com/view_bug.do?bug_id=7144542 at:
>>>
>>> http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.0/
>>
>> So what you do is to change headful CToolkit to headless XToolkit,
>> correct? Note that this change will also trigger Java2D pipeline
>> change, which might not be what we want.
>
> Actually, while performing more testing I've found one issue with the
> fix: we must also choose the correct font manager class. Otherwise the
> MACOSX_PORT-705 is resurrected. An updated fix is here:
>
> http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.1/
>
> Meanwhile I've performed some performance measurement using the GUIMark2
> for FX, and here are some results:
>
> BitmapTest:
> w/o the fix: ~4.22 FPS
> with the fix: ~4.19 FPS
>
> VectorTest:
> w/o the fix: ~21.0 FPS
> with the fix: ~21.3 FPS
>
> So it looks like there's no any major performance difference between the
> CToolkit and XToolkit Java2D pipelines.
>
>> Have you tried to find out what exactly leads to the crash when
>> CToolkit is used?
>
> Since the crash is actually happening in the HotSpot code, it's being
> investigated by HotSpot team under 7166725.
>
> --
> best regards,
> Anthony
>
>
>>
>> Thanks,
>>
>> Artem
>>
>>> Note: in JDK 8 we already load the headless version of the AWT library,
>>> and this prevents the crash. Now I'm applying the same logic to JDK 7u6.
>>>
>>> --
>>> best regards,
>>> Anthony


From dmitry.cherepanov at oracle.com  Fri May 18 08:18:34 2012
From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov)
Date: Fri, 18 May 2012 19:18:34 +0400
Subject: <AWT Dev> [8] Review request for 7156191: [macosx] Can't type into
 applet demos in Pivot
Message-ID: <4FB6684A.5080207@oracle.com>

This is a direct forward port of the fix to jdk8.

Bug: http://bugs.sun.com/view_bug.do?bug_id=7156191

Webrev: http://cr.openjdk.java.net/~dcherepanov/7156191/8/webrev.0/

Thanks,
Dmitry



From artem.ananiev at oracle.com  Fri May 18 08:34:18 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Fri, 18 May 2012 19:34:18 +0400
Subject: <AWT Dev> [8] Review request for 7156191: [macosx] Can't type
 into applet demos in Pivot
In-Reply-To: <4FB6684A.5080207@oracle.com>
References: <4FB6684A.5080207@oracle.com>
Message-ID: <4FB66BFA.4040907@oracle.com>


Looks fine.

Thanks,

Artem

On 5/18/2012 7:18 PM, Dmitry Cherepanov wrote:
> This is a direct forward port of the fix to jdk8.
>
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7156191
>
> Webrev: http://cr.openjdk.java.net/~dcherepanov/7156191/8/webrev.0/
>
> Thanks,
> Dmitry
>


From dmitry.cherepanov at oracle.com  Fri May 18 08:34:53 2012
From: dmitry.cherepanov at oracle.com (dmitry.cherepanov at oracle.com)
Date: Fri, 18 May 2012 15:34:53 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7156191: [macosx] Can't type into
	applet demos in	Pivot
Message-ID: <20120518153514.D68D8473DE@hg.openjdk.java.net>

Changeset: 2eca75e0a063
Author:    dcherepanov
Date:      2012-05-18 19:39 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2eca75e0a063

7156191: [macosx] Can't type into applet demos in Pivot
Reviewed-by: art

! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java



From pavel.porvatov at oracle.com  Mon May 21 07:57:56 2012
From: pavel.porvatov at oracle.com (pavel.porvatov at oracle.com)
Date: Mon, 21 May 2012 14:57:56 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7168144: No appropriate CCC request for
	changes	introduced by 7154030
Message-ID: <20120521145818.4A7414743F@hg.openjdk.java.net>

Changeset: 1ee12bca4823
Author:    rupashka
Date:      2012-05-21 18:55 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1ee12bca4823

7168144: No appropriate CCC request for changes introduced by 7154030
Reviewed-by: alexsch

! src/share/classes/javax/swing/JComponent.java



From anton.tarasov at oracle.com  Mon May 21 10:12:32 2012
From: anton.tarasov at oracle.com (anton.tarasov at oracle.com)
Date: Mon, 21 May 2012 17:12:32 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7170427:
	setGlobalCurrentFocusCycleRoot	unexpectedly throws SecurityException
Message-ID: <20120521171251.25CE147446@hg.openjdk.java.net>

Changeset: 967b38bfd5c1
Author:    ant
Date:      2012-05-22 01:12 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/967b38bfd5c1

7170427: setGlobalCurrentFocusCycleRoot unexpectedly throws SecurityException
Reviewed-by: art

! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Container.java
! src/share/classes/java/awt/KeyboardFocusManager.java



From kelly.ohair at oracle.com  Mon May 21 18:48:29 2012
From: kelly.ohair at oracle.com (Kelly O'Hair)
Date: Mon, 21 May 2012 18:48:29 -0700
Subject: <AWT Dev> [OpenJDK 2D-Dev] Request for Review: Remove import of
	empty JNI header files
In-Reply-To: <4FB0BFED.8000107@oracle.com>
References: <4F97FFC3.3090509@oracle.com> <4F9817D6.8080701@oracle.com>
	<4F989F8F.6000905@oracle.com> <4F98FAD2.7030808@oracle.com>
	<5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com>
	<4FB0BFED.8000107@oracle.com>
Message-ID: <F32C750F-4F0C-42FA-A18F-0400B0E586BB@oracle.com>


On May 14, 2012, at 1:18 AM, Magnus Ihse Bursie wrote:

> On 2012-05-02 00:19, Kelly Ohair wrote:
>> Magnus,
>> 
>> Do you still need this integrated?
>> I can integrate the exact same changset to awt, 2d,  and build forests if you want.
> 
> Yes, I still like to have this integrated. (Sorry for the slow response, it's been a bit low on the priority list.) Otherwise we need to add a @GenerateNativeHeaders annotation to a class that only generates an empty header file, and that looks kind of silly. :-)
> 
> /Magnus


Is this the patch I need to integrate?
   http://cr.openjdk.java.net/~ihse/remove-empty-imports/webrev.00/

And who do I put down as the reviewers?

-kto



From zhouyx at linux.vnet.ibm.com  Mon May 21 21:32:13 2012
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Tue, 22 May 2012 12:32:13 +0800
Subject: <AWT Dev> Request for review: 7071248 : IME composition window
 does not disappear when file dialog is closed
In-Reply-To: <4FBA7FF7.6060002@oracle.com>
References: <CAOo=rxU-TuBPZQkQA6f6udV5n4kcMMnCid20GbqYksbYGEzxfA@mail.gmail.com>
	<4FB65299.8050007@oracle.com> <4FBA7FF7.6060002@oracle.com>
Message-ID: <4FBB16CD.4080000@linux.vnet.ibm.com>

Hi Oleg and Artem,

     Thank you!   I'll find Charles to help commit it.

On 2012/5/22 1:48, Oleg Pekhovskiy wrote:
> Hi Sean et all,
>
> I checked that one-liner on XP and looked like it's ok.
>
> Thanks,
> Oleg
>
> On 05/18/2012 17:46, Artem Ananiev wrote:
>> Hi, Oleg,
>>
>> could you take a look at this short fix, please? I'm not an expert 
>> here, but the changes look really fine and harmless to me.
>>
>> Thanks,
>>
>> Artem
>>
>> On 5/17/2012 7:17 AM, Sean Chou wrote:
>>> Hi all,
>>>
>>>      When verifying bug 7071248, I found the problem is not resolved,
>>> because the original
>>> changeset(http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4) is
>>> not complete. It lacks another one line change
>>> in src/windows/native/sun/windows/awt_Component.cpp .
>>>      The problem is only seen on windowsXP, but as the patch is half
>>> committed, I think it's better to make it complete.
>>>      The webrev to complete the patch:
>>> http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/  . Please take 
>>> a look.
>>>
>>>
>>> original changeset:
>>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4
>>> sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248
>>>
>>>
>>> -- 
>>> Best Regards,
>>> Sean Chou
>>>
>



From luchsh at linux.vnet.ibm.com  Tue May 22 00:47:14 2012
From: luchsh at linux.vnet.ibm.com (Jonathan Lu)
Date: Tue, 22 May 2012 15:47:14 +0800
Subject: <AWT Dev> Request for Review: 7170655 frame size change does not
 follow label font change
Message-ID: <4FBB4482.4040201@linux.vnet.ibm.com>

Hi awt-dev,

Here's a patch for bug 7170655, could anybody please help to take a look?
http://cr.openjdk.java.net/~luchsh/7170655/

The problem is that painting event from EDT during painting handling 
does not get processed immediately, so leave a lag to the user. My 
solution here is to coalesce and dispatch the new paint event right 
after it was posted. This happens only to AWT components.

Thanks!
-Jonathan



From dmitry.cherepanov at oracle.com  Tue May 22 01:33:15 2012
From: dmitry.cherepanov at oracle.com (dmitry.cherepanov at oracle.com)
Date: Tue, 22 May 2012 08:33:15 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7160293: [macosx] FileDialog appears on
	secondary	display
Message-ID: <20120522083336.E52604745D@hg.openjdk.java.net>

Changeset: 5ff4693406ad
Author:    dcherepanov
Date:      2012-05-22 12:35 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5ff4693406ad

7160293: [macosx] FileDialog appears on secondary display
Reviewed-by: art, bae

! src/macosx/classes/sun/awt/CGraphicsEnvironment.java
! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/PlatformWindow.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/native/sun/awt/AWTWindow.m



From littlee at linux.vnet.ibm.com  Tue May 22 02:46:33 2012
From: littlee at linux.vnet.ibm.com (Charles Lee)
Date: Tue, 22 May 2012 17:46:33 +0800
Subject: <AWT Dev> Request for review: 7071248 : IME composition window
 does not disappear when file dialog is closed
In-Reply-To: <4FBB16CD.4080000@linux.vnet.ibm.com>
References: <CAOo=rxU-TuBPZQkQA6f6udV5n4kcMMnCid20GbqYksbYGEzxfA@mail.gmail.com>
	<4FB65299.8050007@oracle.com> <4FBA7FF7.6060002@oracle.com>
	<4FBB16CD.4080000@linux.vnet.ibm.com>
Message-ID: <4FBB6079.5020602@linux.vnet.ibm.com>

Hi Sean,

7071248 has been used (apparently). Would you please create a new CR?

On 05/22/2012 12:32 PM, Sean Chou wrote:
> Hi Oleg and Artem,
>
>     Thank you!   I'll find Charles to help commit it.
>
> On 2012/5/22 1:48, Oleg Pekhovskiy wrote:
>> Hi Sean et all,
>>
>> I checked that one-liner on XP and looked like it's ok.
>>
>> Thanks,
>> Oleg
>>
>> On 05/18/2012 17:46, Artem Ananiev wrote:
>>> Hi, Oleg,
>>>
>>> could you take a look at this short fix, please? I'm not an expert 
>>> here, but the changes look really fine and harmless to me.
>>>
>>> Thanks,
>>>
>>> Artem
>>>
>>> On 5/17/2012 7:17 AM, Sean Chou wrote:
>>>> Hi all,
>>>>
>>>>      When verifying bug 7071248, I found the problem is not resolved,
>>>> because the original
>>>> changeset(http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4) is 
>>>>
>>>> not complete. It lacks another one line change
>>>> in src/windows/native/sun/windows/awt_Component.cpp .
>>>>      The problem is only seen on windowsXP, but as the patch is half
>>>> committed, I think it's better to make it complete.
>>>>      The webrev to complete the patch:
>>>> http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/  . Please 
>>>> take a look.
>>>>
>>>>
>>>> original changeset:
>>>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4
>>>> sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248
>>>>
>>>>
>>>> -- 
>>>> Best Regards,
>>>> Sean Chou
>>>>
>>
>


-- 
Yours Charles



From zhouyx at linux.vnet.ibm.com  Mon May 21 21:27:04 2012
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Tue, 22 May 2012 12:27:04 +0800
Subject: <AWT Dev> Request for review: 7071248 : IME composition window
 does not disappear when file dialog is closed
In-Reply-To: <4FBA7FF7.6060002@oracle.com>
References: <CAOo=rxU-TuBPZQkQA6f6udV5n4kcMMnCid20GbqYksbYGEzxfA@mail.gmail.com>
	<4FB65299.8050007@oracle.com> <4FBA7FF7.6060002@oracle.com>
Message-ID: <4FBB1598.6020004@linux.vnet.ibm.com>

Hi Oleg and Artem,

     Thank you!   I'll find Charles to help commit it.

On 2012/5/22 1:48, Oleg Pekhovskiy wrote:
> Hi Sean et all,
>
> I checked that one-liner on XP and looked like it's ok.
>
> Thanks,
> Oleg
>
> On 05/18/2012 17:46, Artem Ananiev wrote:
>> Hi, Oleg,
>>
>> could you take a look at this short fix, please? I'm not an expert 
>> here, but the changes look really fine and harmless to me.
>>
>> Thanks,
>>
>> Artem
>>
>> On 5/17/2012 7:17 AM, Sean Chou wrote:
>>> Hi all,
>>>
>>>      When verifying bug 7071248, I found the problem is not resolved,
>>> because the original
>>> changeset(http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4) is
>>> not complete. It lacks another one line change
>>> in src/windows/native/sun/windows/awt_Component.cpp .
>>>      The problem is only seen on windowsXP, but as the patch is half
>>> committed, I think it's better to make it complete.
>>>      The webrev to complete the patch:
>>> http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/  . Please take 
>>> a look.
>>>
>>>
>>> original changeset:
>>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4
>>> sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248
>>>
>>>
>>> -- 
>>> Best Regards,
>>> Sean Chou
>>>
>



From magnus.ihse.bursie at oracle.com  Tue May 22 01:06:41 2012
From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie)
Date: Tue, 22 May 2012 10:06:41 +0200
Subject: <AWT Dev> [OpenJDK 2D-Dev] Request for Review: Remove import of
 empty JNI header files
In-Reply-To: <F32C750F-4F0C-42FA-A18F-0400B0E586BB@oracle.com>
References: <4F97FFC3.3090509@oracle.com> <4F9817D6.8080701@oracle.com>
	<4F989F8F.6000905@oracle.com> <4F98FAD2.7030808@oracle.com>
	<5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com>
	<4FB0BFED.8000107@oracle.com>
	<F32C750F-4F0C-42FA-A18F-0400B0E586BB@oracle.com>
Message-ID: <4FBB4911.3000103@oracle.com>

On 2012-05-22 03:48, Kelly O'Hair wrote:
> On May 14, 2012, at 1:18 AM, Magnus Ihse Bursie wrote:
>
>> On 2012-05-02 00:19, Kelly Ohair wrote:
>>> Magnus,
>>>
>>> Do you still need this integrated?
>>> I can integrate the exact same changset to awt, 2d,  and build forests if you want.
>> Yes, I still like to have this integrated. (Sorry for the slow response, it's been a bit low on the priority list.) Otherwise we need to add a @GenerateNativeHeaders annotation to a class that only generates an empty header file, and that looks kind of silly. :-)
>>
>> /Magnus
>
> Is this the patch I need to integrate?
>     http://cr.openjdk.java.net/~ihse/remove-empty-imports/webrev.00/

Yes.
> And who do I put down as the reviewers?

 From the mail replies:
Anthony Petrov <anthony.petrov at oracle.com>
Chris Hegarty <chris.hegarty at oracle.com>
Phil Race <philip.race at oracle.com>

/Magnus


From Sergey.Bylokhov at oracle.com  Tue May 22 07:15:39 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 22 May 2012 18:15:39 +0400
Subject: <AWT Dev> [7u6] Request for review: 7080109 Dialog.show() lacks
 doPrivileged() to access system event queue
In-Reply-To: <4FB27472.5020501@oracle.com>
References: <4FB1275E.5030701@oracle.com> <4FB27472.5020501@oracle.com>
Message-ID: <4FBB9F8B.9000803@oracle.com>

Anthony thanks for review. Does anybody has a chance to review the fix? 
One more reviewer needed.

15.05.2012 19:21, Anthony Petrov wrote:
> Looks good to me.
>
> -- 
> best regards,
> Anthony
>
> On 5/14/2012 7:40 PM, Sergey Bylokhov wrote:
>> Hi Everyone,
>> This is a back port from jdk 8 to jdk 7u6.
>> In the fix doPrivileged was added to Dialog.show().
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7080109/webrev.01
>> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/912e666b4e1d
>>


-- 
Best regards, Sergey.



From Sergey.Bylokhov at oracle.com  Tue May 22 07:23:42 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 22 May 2012 18:23:42 +0400
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FBB4482.4040201@linux.vnet.ibm.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com>
Message-ID: <4FBBA16E.2070804@oracle.com>

Hi, Jonathan,
Looks like this bug is duplicate of 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
And the reason of the issue is that we post UpdateEvent in 
target.repaint() in XLabelPeer.setFont(), but we should paint native 
part of the component in place[1] and then post PaintEvent[2].

  - To fix [1] we can replace target.repaint() to repaint() in 
setFont(). Does it solve your issue?

22.05.2012 11:47, Jonathan Lu wrote:
> Hi awt-dev,
>
> Here's a patch for bug 7170655, could anybody please help to take a look?
> http://cr.openjdk.java.net/~luchsh/7170655/
>
> The problem is that painting event from EDT during painting handling 
> does not get processed immediately, so leave a lag to the user. My 
> solution here is to coalesce and dispatch the new paint event right 
> after it was posted. This happens only to AWT components.
>
> Thanks!
> -Jonathan
>


-- 
Best regards, Sergey.



From Sergey.Bylokhov at oracle.com  Tue May 22 12:42:06 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 22 May 2012 23:42:06 +0400
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FBBA16E.2070804@oracle.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
Message-ID: <4FBBEC0E.6050709@oracle.com>

Hi, Jonathan,
It`s strange to me that the component size depends on the sequence of 
paint events and I`ve looked deeper. And I`ve found that the main 
problem is that XLabelPeer updates its caches (cachedFontMetrics and 
oldfont) in the paintPeer(). So when we postpone the paint, 
frame.pack()->...->getMinimumSize() uses old caches and when we paint in 
a place, getMinimumSize() uses correct values.

22.05.2012 18:23, Sergey Bylokhov wrote:
> Hi, Jonathan,
> Looks like this bug is duplicate of 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
> And the reason of the issue is that we post UpdateEvent in 
> target.repaint() in XLabelPeer.setFont(), but we should paint native 
> part of the component in place[1] and then post PaintEvent[2].
>
>  - To fix [1] we can replace target.repaint() to repaint() in 
> setFont(). Does it solve your issue?
>
> 22.05.2012 11:47, Jonathan Lu wrote:
>> Hi awt-dev,
>>
>> Here's a patch for bug 7170655, could anybody please help to take a 
>> look?
>> http://cr.openjdk.java.net/~luchsh/7170655/
>>
>> The problem is that painting event from EDT during painting handling 
>> does not get processed immediately, so leave a lag to the user. My 
>> solution here is to coalesce and dispatch the new paint event right 
>> after it was posted. This happens only to AWT components.
>>
>> Thanks!
>> -Jonathan
>>
>
>


-- 
Best regards, Sergey.



From kelly.ohair at oracle.com  Tue May 22 18:25:32 2012
From: kelly.ohair at oracle.com (Kelly O'Hair)
Date: Tue, 22 May 2012 18:25:32 -0700
Subject: <AWT Dev> Fwd: Need reviewer - @GenerateNativeHeader
References: <A15AFA68-B8B8-4549-A55A-8A89F9055C98@oracle.com>
Message-ID: <A1A7271C-66EC-43A6-A4D1-AE3D0337C1C5@oracle.com>


FYI...


A review and OK from the awt team would be nice here. ;^)

-kto

Begin forwarded message:

> From: "Kelly O'Hair" <kelly.ohair at oracle.com>
> Subject: Need reviewer - @GenerateNativeHeader
> Date: May 22, 2012 6:14:54 PM PDT
> To: "build-dev at openjdk.java.net build-dev" <build-dev at openjdk.java.net>
> 
> 
> 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI
> http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/
> 
> The new build infrastructure wants to fully automate the generation of the JNI header files (running javah).
> On classes that have "native" methods this is obvious, but class that only export constants, and whose constants
> are needed in the JNI native code, we need to mark these classes as needing their native header file generated.
> 
> This change is adding:
> 
> import javax.tools.annotation.GenerateNativeHeader;
> 
> /* No native methods here, but the constants are needed in the supporting JNI code */
> @GenerateNativeHeader
> 
> To any class without a native method, but needing to expose it's constants to the native code.
> 
> -kto
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120522/aa071df1/attachment.html 

From zhouyx at linux.vnet.ibm.com  Tue May 22 20:13:44 2012
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Wed, 23 May 2012 11:13:44 +0800
Subject: <AWT Dev> Request for review: 7071248 : IME composition window
 does not disappear when file dialog is closed
In-Reply-To: <4FBB6079.5020602@linux.vnet.ibm.com>
References: <CAOo=rxU-TuBPZQkQA6f6udV5n4kcMMnCid20GbqYksbYGEzxfA@mail.gmail.com>
	<4FB65299.8050007@oracle.com> <4FBA7FF7.6060002@oracle.com>
	<4FBB16CD.4080000@linux.vnet.ibm.com>
	<4FBB6079.5020602@linux.vnet.ibm.com>
Message-ID: <CAOo=rxXS7tknW6YjwEG_AQGMkVLBr=hiaUKLCTFpZAWMpkYNXA@mail.gmail.com>

Hi Charles,

    I reported a new bug
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170996 , it might
take some time to be valid.

On Tue, May 22, 2012 at 5:46 PM, Charles Lee <littlee at linux.vnet.ibm.com>wrote:

> Hi Sean,
>
> 7071248 has been used (apparently). Would you please create a new CR?
>
>
> On 05/22/2012 12:32 PM, Sean Chou wrote:
>
>> Hi Oleg and Artem,
>>
>>    Thank you!   I'll find Charles to help commit it.
>>
>> On 2012/5/22 1:48, Oleg Pekhovskiy wrote:
>>
>>> Hi Sean et all,
>>>
>>> I checked that one-liner on XP and looked like it's ok.
>>>
>>> Thanks,
>>> Oleg
>>>
>>> On 05/18/2012 17:46, Artem Ananiev wrote:
>>>
>>>> Hi, Oleg,
>>>>
>>>> could you take a look at this short fix, please? I'm not an expert
>>>> here, but the changes look really fine and harmless to me.
>>>>
>>>> Thanks,
>>>>
>>>> Artem
>>>>
>>>> On 5/17/2012 7:17 AM, Sean Chou wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>>     When verifying bug 7071248, I found the problem is not resolved,
>>>>> because the original
>>>>> changeset(http://hg.openjdk.**java.net/jdk8/jdk8/jdk/rev/**
>>>>> 25564f7b29c4<http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4>)
>>>>> is
>>>>> not complete. It lacks another one line change
>>>>> in src/windows/native/sun/**windows/awt_Component.cpp .
>>>>>     The problem is only seen on windowsXP, but as the patch is half
>>>>> committed, I think it's better to make it complete.
>>>>>     The webrev to complete the patch:
>>>>> http://cr.openjdk.java.net/~**zhouyx/7071248/webrev.00/<http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/> . Please take a look.
>>>>>
>>>>>
>>>>> original changeset:
>>>>> http://hg.openjdk.java.net/**jdk8/jdk8/jdk/rev/25564f7b29c4<http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4>
>>>>> sunbug: http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7071248<http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>> Sean Chou
>>>>>
>>>>>
>>>
>>
>
> --
> Yours Charles
>
>


-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120523/570a06b5/attachment.html 

From littlee at linux.vnet.ibm.com  Tue May 22 21:38:51 2012
From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com)
Date: Wed, 23 May 2012 04:38:51 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7170996: IME composition window does
	not disappear	when file dialog is closed : Japanese WinXP
Message-ID: <20120523043915.965E04748D@hg.openjdk.java.net>

Changeset: cac4daf60283
Author:    zhouyx
Date:      2012-05-23 12:37 +0800
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cac4daf60283

7170996: IME composition window does not disappear when file dialog is closed : Japanese WinXP
Reviewed-by: art, bagiras

! src/windows/native/sun/windows/awt_Component.cpp



From littlee at linux.vnet.ibm.com  Tue May 22 21:50:17 2012
From: littlee at linux.vnet.ibm.com (Charles Lee)
Date: Wed, 23 May 2012 12:50:17 +0800
Subject: <AWT Dev> Request for review: 7071248 : IME composition window
 does not disappear when file dialog is closed
In-Reply-To: <CAOo=rxXS7tknW6YjwEG_AQGMkVLBr=hiaUKLCTFpZAWMpkYNXA@mail.gmail.com>
References: <CAOo=rxU-TuBPZQkQA6f6udV5n4kcMMnCid20GbqYksbYGEzxfA@mail.gmail.com>
	<4FB65299.8050007@oracle.com>	<4FBA7FF7.6060002@oracle.com>
	<4FBB16CD.4080000@linux.vnet.ibm.com>	<4FBB6079.5020602@linux.vnet.ibm.com>
	<CAOo=rxXS7tknW6YjwEG_AQGMkVLBr=hiaUKLCTFpZAWMpkYNXA@mail.gmail.com>
Message-ID: <4FBC6C89.7000605@linux.vnet.ibm.com>

Hi Sean,

The patch is committed @

Changeset: cac4daf60283
Author:    zhouyx
Date:      2012-05-23 12:37 +0800
URL:http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cac4daf60283

7170996: IME composition window does not disappear when file dialog is closed : Japanese WinXP
Reviewed-by: art, bagiras

Please verify it and thank you all for reviewing.

On 05/23/2012 11:13 AM, Sean Chou wrote:
> Hi Charles,
>
>     I reported a new bug 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170996 , it might
> take some time to be valid.
>
> On Tue, May 22, 2012 at 5:46 PM, Charles Lee 
> <littlee at linux.vnet.ibm.com <mailto:littlee at linux.vnet.ibm.com>> wrote:
>
>     Hi Sean,
>
>     7071248 has been used (apparently). Would you please create a new CR?
>
>
>     On 05/22/2012 12:32 PM, Sean Chou wrote:
>
>         Hi Oleg and Artem,
>
>            Thank you!   I'll find Charles to help commit it.
>
>         On 2012/5/22 1:48, Oleg Pekhovskiy wrote:
>
>             Hi Sean et all,
>
>             I checked that one-liner on XP and looked like it's ok.
>
>             Thanks,
>             Oleg
>
>             On 05/18/2012 17:46, Artem Ananiev wrote:
>
>                 Hi, Oleg,
>
>                 could you take a look at this short fix, please? I'm
>                 not an expert here, but the changes look really fine
>                 and harmless to me.
>
>                 Thanks,
>
>                 Artem
>
>                 On 5/17/2012 7:17 AM, Sean Chou wrote:
>
>                     Hi all,
>
>                         When verifying bug 7071248, I found the
>                     problem is not resolved,
>                     because the original
>                     changeset(http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4)
>                     is
>                     not complete. It lacks another one line change
>                     in src/windows/native/sun/windows/awt_Component.cpp .
>                         The problem is only seen on windowsXP, but as
>                     the patch is half
>                     committed, I think it's better to make it complete.
>                         The webrev to complete the patch:
>                     http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/
>                     <http://cr.openjdk.java.net/%7Ezhouyx/7071248/webrev.00/>
>                      . Please take a look.
>
>
>                     original changeset:
>                     http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4
>                     sunbug:
>                     http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248
>
>
>                     -- 
>                     Best Regards,
>                     Sean Chou
>
>
>
>
>
>     -- 
>     Yours Charles
>
>
>
>
> -- 
> Best Regards,
> Sean Chou
>


-- 
Yours Charles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120523/c3b83d2c/attachment.html 

From zhouyx at linux.vnet.ibm.com  Tue May 22 23:00:08 2012
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Wed, 23 May 2012 14:00:08 +0800
Subject: <AWT Dev> Request for review: 7071248 : IME composition window
 does not disappear when file dialog is closed
In-Reply-To: <4FBC6C89.7000605@linux.vnet.ibm.com>
References: <CAOo=rxU-TuBPZQkQA6f6udV5n4kcMMnCid20GbqYksbYGEzxfA@mail.gmail.com>
	<4FB65299.8050007@oracle.com> <4FBA7FF7.6060002@oracle.com>
	<4FBB16CD.4080000@linux.vnet.ibm.com>
	<4FBB6079.5020602@linux.vnet.ibm.com>
	<CAOo=rxXS7tknW6YjwEG_AQGMkVLBr=hiaUKLCTFpZAWMpkYNXA@mail.gmail.com>
	<4FBC6C89.7000605@linux.vnet.ibm.com>
Message-ID: <CAOo=rxWt6hpdXeV9SGm07vKwHcp=UAXT2Htd=u+XExAdz43Aag@mail.gmail.com>

   Verified, thanks.

On Wed, May 23, 2012 at 12:50 PM, Charles Lee <littlee at linux.vnet.ibm.com>wrote:

>  Hi Sean,
>
> The patch is committed @
>
> Changeset: cac4daf60283
> Author:    zhouyx
> Date:      2012-05-23 12:37 +0800
> URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cac4daf60283
>
> 7170996: IME composition window does not disappear when file dialog is closed : Japanese WinXP
> Reviewed-by: art, bagiras
>
> Please verify it and thank you all for reviewing.
>
>
> On 05/23/2012 11:13 AM, Sean Chou wrote:
>
> Hi Charles,
>
>      I reported a new bug
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170996 , it might
> take some time to be valid.
>
> On Tue, May 22, 2012 at 5:46 PM, Charles Lee <littlee at linux.vnet.ibm.com>wrote:
>
>> Hi Sean,
>>
>> 7071248 has been used (apparently). Would you please create a new CR?
>>
>>
>> On 05/22/2012 12:32 PM, Sean Chou wrote:
>>
>>> Hi Oleg and Artem,
>>>
>>>    Thank you!   I'll find Charles to help commit it.
>>>
>>> On 2012/5/22 1:48, Oleg Pekhovskiy wrote:
>>>
>>>> Hi Sean et all,
>>>>
>>>> I checked that one-liner on XP and looked like it's ok.
>>>>
>>>> Thanks,
>>>> Oleg
>>>>
>>>> On 05/18/2012 17:46, Artem Ananiev wrote:
>>>>
>>>>> Hi, Oleg,
>>>>>
>>>>> could you take a look at this short fix, please? I'm not an expert
>>>>> here, but the changes look really fine and harmless to me.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Artem
>>>>>
>>>>> On 5/17/2012 7:17 AM, Sean Chou wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>>     When verifying bug 7071248, I found the problem is not resolved,
>>>>>> because the original
>>>>>> changeset(http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4)
>>>>>> is
>>>>>> not complete. It lacks another one line change
>>>>>> in src/windows/native/sun/windows/awt_Component.cpp .
>>>>>>     The problem is only seen on windowsXP, but as the patch is half
>>>>>> committed, I think it's better to make it complete.
>>>>>>     The webrev to complete the patch:
>>>>>> http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/  . Please take
>>>>>> a look.
>>>>>>
>>>>>>
>>>>>> original changeset:
>>>>>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4
>>>>>> sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best Regards,
>>>>>> Sean Chou
>>>>>>
>>>>>>
>>>>
>>>
>>
>>   --
>> Yours Charles
>>
>>
>
>
>  --
> Best Regards,
> Sean Chou
>
>
>
> --
> Yours Charles
>
>


-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120523/8c632dac/attachment.html 

From artem.ananiev at oracle.com  Wed May 23 02:42:26 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Wed, 23 May 2012 13:42:26 +0400
Subject: <AWT Dev> [7u6] Request for review: 7080109 Dialog.show() lacks
 doPrivileged() to access system event queue
In-Reply-To: <4FBB9F8B.9000803@oracle.com>
References: <4FB1275E.5030701@oracle.com> <4FB27472.5020501@oracle.com>
	<4FBB9F8B.9000803@oracle.com>
Message-ID: <4FBCB102.1090806@oracle.com>

Hi, Sergey,

the fix looks fine. You can make it even more simple: there is no need 
to declare "cond" final anymore as it's not referenced in the 
doPriviliged() block.

Thanks,

Artem

On 5/22/2012 6:15 PM, Sergey Bylokhov wrote:
> Anthony thanks for review. Does anybody has a chance to review the fix?
> One more reviewer needed.
>
> 15.05.2012 19:21, Anthony Petrov wrote:
>> Looks good to me.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 5/14/2012 7:40 PM, Sergey Bylokhov wrote:
>>> Hi Everyone,
>>> This is a back port from jdk 8 to jdk 7u6.
>>> In the fix doPrivileged was added to Dialog.show().
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/7080109/webrev.01
>>> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/912e666b4e1d
>>>
>
>


From artem.ananiev at oracle.com  Wed May 23 02:48:43 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Wed, 23 May 2012 13:48:43 +0400
Subject: <AWT Dev> Fwd: Need reviewer - @GenerateNativeHeader
In-Reply-To: <A1A7271C-66EC-43A6-A4D1-AE3D0337C1C5@oracle.com>
References: <A15AFA68-B8B8-4549-A55A-8A89F9055C98@oracle.com>
	<A1A7271C-66EC-43A6-A4D1-AE3D0337C1C5@oracle.com>
Message-ID: <4FBCB27B.7080107@oracle.com>

Hi, Kelly,

here is my AWT OK :)

Thanks,

Artem

On 5/23/2012 5:25 AM, Kelly O'Hair wrote:
>
> FYI...
>
>
> A review and OK from the awt team would be nice here. ;^)
>
> -kto
>
> Begin forwarded message:
>
>> *From: *"Kelly O'Hair" <kelly.ohair at oracle.com
>> <mailto:kelly.ohair at oracle.com>>
>> *Subject: **Need reviewer - @GenerateNativeHeader*
>> *Date: *May 22, 2012 6:14:54 PM PDT
>> *To: *"build-dev at openjdk.java.net <mailto:build-dev at openjdk.java.net>
>> build-dev" <build-dev at openjdk.java.net
>> <mailto:build-dev at openjdk.java.net>>
>>
>>
>> 7170969: Add @GenerateNativeHeader to classes whose fields need to be
>> exported for JNI
>> http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/
>>
>> The new build infrastructure wants to fully automate the generation of
>> the JNI header files (running javah).
>> On classes that have "native" methods this is obvious, but class that
>> only export constants, and whose constants
>> are needed in the JNI native code, we need to mark these classes as
>> needing their native header file generated.
>>
>> This change is adding:
>>
>> import javax.tools.annotation.GenerateNativeHeader;
>>
>> /* No native methods here, but the constants are needed in the
>> supporting JNI code */
>> @GenerateNativeHeader
>>
>> To any class without a native method, but needing to expose it's
>> constants to the native code.
>>
>> -kto
>>
>


From alexandr.scherbatiy at oracle.com  Wed May 23 03:34:31 2012
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 23 May 2012 14:34:31 +0400
Subject: <AWT Dev> [8] Request for review: 7092551 Double-click in
 TextField sets caret to the beginning
In-Reply-To: <4F991D6C.7030705@oracle.com>
References: <4F88312E.1010907@oracle.com> <4F991D6C.7030705@oracle.com>
Message-ID: <4FBCBD37.3080703@oracle.com>


    Could one more person review the fix? I need at least two reviewers 
before pushing it.

     Thanks,
     Alexandr.

On 4/26/2012 2:03 PM, Alexander Scherbatiy wrote:
>
>    Could someone else review the fix? I need at least two reviewers 
> before pushing it.
>
>    Webrev: http://cr.openjdk.java.net/~alexsch/7092551/webrev.01/
>
>   Thanks,
>   Alexandr.
>
>
> On 4/13/2012 5:59 PM, Oleg Pekhovskiy wrote:
>> Looks good for me.
>>
>> Thanks,
>> OIeg.
>>
>> On 4/06/2012 3:45 PM, Alexander Scherbatiy wrote:
>>
>>
>>>  Hello,
>>>
>>>  Please review a fix for:
>>>
>>>  CR 7092551 Double-click in TextField sets caret to the beginning
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7092551
>>>
>>>  Webrev:http://cr.openjdk.java.net/~alexsch/7092551/webrev.01/ 
>>> <http://cr.openjdk.java.net/%7Ealexsch/7092551/webrev.01/>
>>>
>>>  A Double-click in TextField does not work because the TextField is 
>>> based
>>>  on the windows EDIT control which does not have EM_FINDWORDBREAK 
>>> method.
>>>  A solution is to use the RICHEDIT control instead of EDIT. Because the
>>>  TextArea also is based on the RICHEDIT control it is possible to make
>>>  some unification between AwtTextField and AwtTextArea classes.
>>>
>>>  Changes:
>>>
>>>  1) Moving getting RICHEDIT class name from the TextArea to 
>>> TextComponent
>>>
>>>  2) Updating TextField Create method to use the TextArea workarounds.
>>>
>>>  3) Moving OLE callbacks class defenition and creation to the
>>>  TextComponent  (both classes TextField and TextArea now use it)
>>>
>>>  4) EditGetCharFromPos method bodies are differenet for TextField and
>>>  TextArea.
>>>  Using the old one in the TextField leads to the 
>>> EXCEPTION_ACCESS_VIOLATION.
>>>  So using the one from the TextArea and moving it to TextComponent.
>>>
>>>
>>>  The issue 7092551 (Double-click in TextField sets caret to the
>>>  beginning) is resolved.
>>>
>>>  Issues:
>>>
>>>  5) Setting editable for TextField to false does not show gray 
>>> background.
>>>
>>>  Moving workaround for the Enable, SetColor and SetBackground methods
>>>  definitions from TextArea to TextComponent
>>>
>>>
>>>  6) Setting an echo char for TextField and double click selects only
>>>  part  of the echoed text.
>>>  Addding checking the echo char to the HandleEvent method where a text
>>>  is  selected.
>>>
>>>  7) Adding issue 6417581 workaround to EditSetSel method of the
>>>  TextField  component.
>>>  There is one more workaround 5003402 for TextArea control which needs
>>>  to  enable the  automatic scrolling and there is no need to use it in
>>>  the TextField.
>>>
>>>  8) Move PreProcessMsg method from the TextArea to TextComponent to
>>>  workaround filtering the  WM_LBUTTONUP after WM_LBUTTONDBLCLK for
>>>  RichEdit 1.0
>>>
>>>  9) CR 6480547 is not reproduced with the RICHEDIT control.
>>>  Removing using initialRescroll workaround from the TextField.
>>>  Not need to override the Reshape method in the Textfield.
>>>
>>>
>>>  Requested changes:
>>>  10)  NOERROR  is changed to S_OK
>>>
>>>  11) The OleCallback is not deleted explicitly in the
>>>  OleCallback::Release() method.
>>>       Only number of the object references is returned.
>>>
>>>  12) if-else block in the OleCallback::QueryInterface method is 
>>> unified.
>>>
>>>  13) Because only the RichEdit 2.0 control is used (and it is not
>>>  necessary to support the RichEdit 1.0)
>>>    the AwtTextArea::PreProcessMsg method that tries to avoid issue with
>>>  the WM_LBUTTONUP event after double click is removed.
>>>     The right behavior is that there are 2 WM_LBUTTONUP events after 
>>> the
>>>  WM_LBUTTONDOWN during the mouse double click.
>>>      So the RichEdit 2.0 control has a right behavior.
>>>      However the  RichEdit 1.0  generates a pair of events
>>>  WM_LBUTTONDOWN, WM_LBUTTONUP during the double click.
>>>
>>>  14)   Methods merging
>>>      - The create method is unified and moved to the 
>>> AwtTextComponent class.
>>>      - I do not merge the HandleEvent method. They are quite similar in
>>>  both classes AwtTextField and AwtTextArea. However there are 
>>> differences
>>>  in some 'if' branches.
>>>
>>>  Thanks,
>>>  Alexandr.
>>
>>
>



From luchsh at linux.vnet.ibm.com  Wed May 23 03:15:32 2012
From: luchsh at linux.vnet.ibm.com (Jonathan Lu)
Date: Wed, 23 May 2012 18:15:32 +0800
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FBBA16E.2070804@oracle.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
Message-ID: <4FBCB8C4.6060205@linux.vnet.ibm.com>

Hi Sergey,

On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
> Hi, Jonathan,
> Looks like this bug is duplicate of 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
> And the reason of the issue is that we post UpdateEvent in 
> target.repaint() in XLabelPeer.setFont(), but we should paint native 
> part of the component in place[1] and then post PaintEvent[2].
>
>  - To fix [1] we can replace target.repaint() to repaint() in 
> setFont(). Does it solve your issue?

Yes, this resolves my problem, and here's the updated patch from your 
suggestion,
http://cr.openjdk.java.net/~luchsh/7170655_2/

Thanks a lot!
- Jonathan

>
> 22.05.2012 11:47, Jonathan Lu wrote:
>> Hi awt-dev,
>>
>> Here's a patch for bug 7170655, could anybody please help to take a 
>> look?
>> http://cr.openjdk.java.net/~luchsh/7170655/
>>
>> The problem is that painting event from EDT during painting handling 
>> does not get processed immediately, so leave a lag to the user. My 
>> solution here is to coalesce and dispatch the new paint event right 
>> after it was posted. This happens only to AWT components.
>>
>> Thanks!
>> -Jonathan
>>
>
>



From Sergey.Bylokhov at oracle.com  Wed May 23 05:34:05 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 23 May 2012 16:34:05 +0400
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FBCB8C4.6060205@linux.vnet.ibm.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
	<4FBCB8C4.6060205@linux.vnet.ibm.com>
Message-ID: <4FBCD93D.2070202@oracle.com>

Hi, Jonathan,
Fix looks good. But I guess this bug was not caught by the regression 
tests, so new test should be added(automatic test is better).

23.05.2012 14:15, Jonathan Lu wrote:
> Hi Sergey,
>
> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>> Hi, Jonathan,
>> Looks like this bug is duplicate of 
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>> And the reason of the issue is that we post UpdateEvent in 
>> target.repaint() in XLabelPeer.setFont(), but we should paint native 
>> part of the component in place[1] and then post PaintEvent[2].
>>
>>  - To fix [1] we can replace target.repaint() to repaint() in 
>> setFont(). Does it solve your issue?
>
> Yes, this resolves my problem, and here's the updated patch from your 
> suggestion,
> http://cr.openjdk.java.net/~luchsh/7170655_2/
>
> Thanks a lot!
> - Jonathan
>
>>
>> 22.05.2012 11:47, Jonathan Lu wrote:
>>> Hi awt-dev,
>>>
>>> Here's a patch for bug 7170655, could anybody please help to take a 
>>> look?
>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>
>>> The problem is that painting event from EDT during painting handling 
>>> does not get processed immediately, so leave a lag to the user. My 
>>> solution here is to coalesce and dispatch the new paint event right 
>>> after it was posted. This happens only to AWT components.
>>>
>>> Thanks!
>>> -Jonathan
>>>
>>
>>
>


-- 
Best regards, Sergey.



From leonid.romanov at oracle.com  Wed May 23 06:26:21 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Wed, 23 May 2012 17:26:21 +0400
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java processes
	on Mac should use Oracle Java branded icons
Message-ID: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>

Hi, 
Please review a fix for  7168062: [macosx] Java processes on Mac should use Oracle Java branded icons. This is about using new Oracle Java branded icon as the default icon for Java apps instead of the Apple supplied icon found in /System/Library/Frameworks/JavaVM.framework.
I've discussed this bug with Artem Ananiev and we decided that the best way to do it is to convert icon file to .h file with icon data as an array of bytes and then include this .h file where icon data is needed. So, we basically compile in icon data into the binaries. 
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168062
Webrev: http://cr.openjdk.java.net/~leonidr/7168062/webrev.00/

Thanks,
Leonid.



From leonid.romanov at oracle.com  Wed May 23 06:35:37 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Wed, 23 May 2012 17:35:37 +0400
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
	processes on Mac should use Oracle Java branded icons
In-Reply-To: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>
Message-ID: <51783A11-AA0E-477E-89F1-5F7953C70DF2@oracle.com>

A little followup: the icon file itself is located at 
jdk/src/macosx/native/sun/osxapp/resource/icons

On 23.05.2012, at 17:26, Leonid Romanov wrote:

> Hi, 
> Please review a fix for  7168062: [macosx] Java processes on Mac should use Oracle Java branded icons. This is about using new Oracle Java branded icon as the default icon for Java apps instead of the Apple supplied icon found in /System/Library/Frameworks/JavaVM.framework.
> I've discussed this bug with Artem Ananiev and we decided that the best way to do it is to convert icon file to .h file with icon data as an array of bytes and then include this .h file where icon data is needed. So, we basically compile in icon data into the binaries. 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168062
> Webrev: http://cr.openjdk.java.net/~leonidr/7168062/webrev.00/
> 
> Thanks,
> Leonid.
> 



From scott.kovatch at oracle.com  Wed May 23 07:39:58 2012
From: scott.kovatch at oracle.com (Scott Kovatch)
Date: Wed, 23 May 2012 18:39:58 +0400
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
	processes on Mac should use Oracle Java branded icons
In-Reply-To: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>
Message-ID: <DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>


On May 23, 2012, at 5:26 PM, Leonid Romanov wrote:

> Hi, 
> Please review a fix for  7168062: [macosx] Java processes on Mac should use Oracle Java branded icons. This is about using new Oracle Java branded icon as the default icon for Java apps instead of the Apple supplied icon found in /System/Library/Frameworks/JavaVM.framework.
> I've discussed this bug with Artem Ananiev and we decided that the best way to do it is to convert icon file to .h file with icon data as an array of bytes and then include this .h file where icon data is needed. So, we basically compile in icon data into the binaries. 

That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?

-- Scott

----------------------------------------
Scott Kovatch
scott.kovatch at oracle.com
Santa Clara/Pleasanton, CA

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120523/618f607b/attachment.html 

From scott.kovatch at oracle.com  Wed May 23 08:29:21 2012
From: scott.kovatch at oracle.com (Scott Kovatch)
Date: Wed, 23 May 2012 19:29:21 +0400
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
	processes on Mac should use Oracle Java branded icons
In-Reply-To: <CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>
	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
Message-ID: <D5B03F1A-69C4-4991-94D9-B5B26F0998D8@oracle.com>


On May 23, 2012, at 7:25 PM, Henri Gomez wrote:

>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
> 
> OpenJDK will use Oracle icons ? Even for the community version ?

We don't want to use the Apple java icons. It doesn't have 'Oracle' or anything like that on it -- it's just the generic steaming coffee cup in orange and blue. In fact, I believe it is already in use as the bundle icon for the JDK.

-- Scott



From philip.race at oracle.com  Wed May 23 08:41:33 2012
From: philip.race at oracle.com (Phil Race)
Date: Wed, 23 May 2012 08:41:33 -0700
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
 processes on Mac should use Oracle Java branded icons
In-Reply-To: <CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
Message-ID: <4FBD052D.7080101@oracle.com>


On 5/23/2012 8:25 AM, Henri Gomez wrote:
>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
> OpenJDK will use Oracle icons ? Even for the community version ?

I was wondering about this too. It seems wrong. The icon, and/or the 
header file
should be in "closed".  We do not put branded images in the open tree, no
matter how its encoded since they aren't open source.
The openjdk should use something like the open source duke icon.
I am not sure I see how/where that works.

BTW good luck seeing

>  Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168062

its marked for internal consumption only (for some reason I can't fathom).

-phil.





From philip.race at oracle.com  Wed May 23 08:45:17 2012
From: philip.race at oracle.com (Phil Race)
Date: Wed, 23 May 2012 08:45:17 -0700
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
 processes on Mac should use Oracle Java branded icons
In-Reply-To: <D5B03F1A-69C4-4991-94D9-B5B26F0998D8@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<D5B03F1A-69C4-4991-94D9-B5B26F0998D8@oracle.com>
Message-ID: <4FBD060D.5090604@oracle.com>

We shouldn't use the Apple one obviously.

We can use the steaming coffee cup for the Oracle JDK but *not* for the 
openjdk.

Duke was open sourced for use by open jdk but not the coffee cup one ..

-phil.

On 5/23/2012 8:29 AM, Scott Kovatch wrote:
> On May 23, 2012, at 7:25 PM, Henri Gomez wrote:
>
>>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
>> OpenJDK will use Oracle icons ? Even for the community version ?
> We don't want to use the Apple java icons. It doesn't have 'Oracle' or anything like that on it -- it's just the generic steaming coffee cup in orange and blue. In fact, I believe it is already in use as the bundle icon for the JDK.
>
> -- Scott
>



From alexander.zuev at oracle.com  Wed May 23 09:51:54 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Wed, 23 May 2012 20:51:54 +0400
Subject: <AWT Dev> [7u6] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
Message-ID: <4FBD15AA.7060206@oracle.com>

Hello,

   please review my fix for the
7171163: [macosx] Shortcomings in the design of the secondary native 
event loop made JavaFX DnD deadlock

   Bug can be found at 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163

   Webrev can be found at: 
http://cr.openjdk.java.net/~kizune/7171163/webrev.00/

With best regards,
Alexander Zuev


From alexander.zuev at oracle.com  Wed May 23 11:11:37 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Wed, 23 May 2012 22:11:37 +0400
Subject: <AWT Dev> [7u6] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <4FBD1CA8.8080703@oracle.com>
References: <4FBD15AA.7060206@oracle.com> <4FBD1CA8.8080703@oracle.com>
Message-ID: <4FBD2859.9010000@oracle.com>

Steve,

   you are absolutely right - this native method is used only by our 
implementation of the DnD so
i may just rename it and the only reason i have not done it is to 
minimize the scope of the change.
So if you think renaming the method is required i will gladly do it.

With best regards,
Alex

On 5/23/12 21:21, steve.x.northover at oracle.com wrote:
> The implementation matches how these methods are used by drag and drop 
> but the naming makes no sense.  Who else calls these methods?  I'm 
> assuming nobody (or that they are all called with the same 
> implementation in mind).
>
> startNativeNestedEventLoop is really "read and dispatch an event 
> without blocking".
>
> Steve
>
> On 23/05/2012 12:51 PM, Alexander Zuev wrote:
>> Hello,
>>
>>   please review my fix for the
>> 7171163: [macosx] Shortcomings in the design of the secondary native 
>> event loop made JavaFX DnD deadlock
>>
>>   Bug can be found at 
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>>
>>   Webrev can be found at: 
>> http://cr.openjdk.java.net/~kizune/7171163/webrev.00/
>>
>> With best regards,
>> Alexander Zuev



From luchsh at linux.vnet.ibm.com  Thu May 24 00:50:56 2012
From: luchsh at linux.vnet.ibm.com (Jonathan Lu)
Date: Thu, 24 May 2012 15:50:56 +0800
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FBCD93D.2070202@oracle.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
	<4FBCB8C4.6060205@linux.vnet.ibm.com> <4FBCD93D.2070202@oracle.com>
Message-ID: <4FBDE860.2060203@linux.vnet.ibm.com>

Hello Sergey,

I made one automatic jtreg test case and put it to following link along 
with the patch.
http://cr.openjdk.java.net/~luchsh/7170655_3/

Could you please take a look?

Thanks!
- Jonathan

On 05/23/2012 08:34 PM, Sergey Bylokhov wrote:
> Hi, Jonathan,
> Fix looks good. But I guess this bug was not caught by the regression 
> tests, so new test should be added(automatic test is better).
>
> 23.05.2012 14:15, Jonathan Lu wrote:
>> Hi Sergey,
>>
>> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>>> Hi, Jonathan,
>>> Looks like this bug is duplicate of 
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>>> And the reason of the issue is that we post UpdateEvent in 
>>> target.repaint() in XLabelPeer.setFont(), but we should paint native 
>>> part of the component in place[1] and then post PaintEvent[2].
>>>
>>>  - To fix [1] we can replace target.repaint() to repaint() in 
>>> setFont(). Does it solve your issue?
>>
>> Yes, this resolves my problem, and here's the updated patch from your 
>> suggestion,
>> http://cr.openjdk.java.net/~luchsh/7170655_2/
>>
>> Thanks a lot!
>> - Jonathan
>>
>>>
>>> 22.05.2012 11:47, Jonathan Lu wrote:
>>>> Hi awt-dev,
>>>>
>>>> Here's a patch for bug 7170655, could anybody please help to take a 
>>>> look?
>>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>>
>>>> The problem is that painting event from EDT during painting 
>>>> handling does not get processed immediately, so leave a lag to the 
>>>> user. My solution here is to coalesce and dispatch the new paint 
>>>> event right after it was posted. This happens only to AWT components.
>>>>
>>>> Thanks!
>>>> -Jonathan
>>>>
>>>
>>>
>>
>
>



From alexander.zuev at oracle.com  Thu May 24 02:35:29 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Thu, 24 May 2012 13:35:29 +0400
Subject: <AWT Dev> [7u6] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <4FBD2BD3.7080706@oracle.com>
References: <4FBD15AA.7060206@oracle.com> <4FBD1CA8.8080703@oracle.com>
	<4FBD2859.9010000@oracle.com> <4FBD2BD3.7080706@oracle.com>
Message-ID: <4FBE00E1.1040600@oracle.com>

Steve,

   i've updated comments anywhere i can to reflect specific design of 
this feature on Mac.
Also i have removed the unneeded call to the native function from the 
exit() method to save
us some cycles on Java<->JNI call.

   Updated webrev can be found here:
http://cr.openjdk.java.net/~kizune/7171163/webrev.01/

   I also will send the formal request to approve the same change in 
jdk8 since we have to push change
there before we can push it into the jdk7u6.

With best regards,
Alex

On 5/23/12 22:26, steve.x.northover at oracle.com wrote:
> ToolkitThreadBlockedHandler seems to be shared code and it follows the 
> enter / exit naming that is wrong.  It seems that a lot of changes 
> will be needed in shared code so I'm not sure the renaming is worth it.
>
> You could add update the comments to indicate how this is used and 
> save the renaming for another day.
>
> Steve
>
> On 23/05/2012 2:11 PM, Alexander Zuev wrote:
>> Steve,
>>
>>   you are absolutely right - this native method is used only by our 
>> implementation of the DnD so
>> i may just rename it and the only reason i have not done it is to 
>> minimize the scope of the change.
>> So if you think renaming the method is required i will gladly do it.
>>
>> With best regards,
>> Alex
>>
>> On 5/23/12 21:21, steve.x.northover at oracle.com wrote:
>>> The implementation matches how these methods are used by drag and 
>>> drop but the naming makes no sense.  Who else calls these methods?  
>>> I'm assuming nobody (or that they are all called with the same 
>>> implementation in mind).
>>>
>>> startNativeNestedEventLoop is really "read and dispatch an event 
>>> without blocking".
>>>
>>> Steve
>>>
>>> On 23/05/2012 12:51 PM, Alexander Zuev wrote:
>>>> Hello,
>>>>
>>>>   please review my fix for the
>>>> 7171163: [macosx] Shortcomings in the design of the secondary 
>>>> native event loop made JavaFX DnD deadlock
>>>>
>>>>   Bug can be found at 
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>>>>
>>>>   Webrev can be found at: 
>>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.00/
>>>>
>>>> With best regards,
>>>> Alexander Zuev
>>



From alexander.zuev at oracle.com  Thu May 24 02:36:12 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Thu, 24 May 2012 13:36:12 +0400
Subject: <AWT Dev> [8] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
Message-ID: <4FBE010C.4000405@oracle.com>

Hello,

   please review my fix for the
7171163: [macosx] Shortcomings in the design of the secondary native 
event loop made JavaFX DnD deadlock

   Bug can be found at 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163

   Webrev can be found at:
http://cr.openjdk.java.net/~kizune/7171163/webrev.01/

With best regards,
Alexander Zuev


From alexander.zuev at oracle.com  Thu May 24 04:12:44 2012
From: alexander.zuev at oracle.com (alexander.zuev at oracle.com)
Date: Thu, 24 May 2012 11:12:44 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7144064: [macosx] "Could not find
	class" error in	JTree's ctor when called in headless mode
Message-ID: <20120524111306.5C717474BF@hg.openjdk.java.net>

Changeset: bb3ada9822e4
Author:    kizune
Date:      2012-05-24 15:11 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bb3ada9822e4

7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode
Reviewed-by: art, leonidr

! src/solaris/native/java/lang/java_props_md.c



From leonid.romanov at oracle.com  Thu May 24 05:22:00 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Thu, 24 May 2012 16:22:00 +0400
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
	processes on Mac should use Oracle Java branded icons
In-Reply-To: <4FBD052D.7080101@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<4FBD052D.7080101@oracle.com>
Message-ID: <14564BAB-38B9-45C5-B921-C6CBCB568685@oracle.com>

I'm not sure whether Jeff Hoffman, who filed 7168062, is on the list, so I'm adding him to CC. Perhaps he would be able to comment on what repo the branded icon should go and what icon to use for the open tree.
As for 7168062 not being visible to the outside world, there isn't much to see. It basically states "we should use branded icon instead what we use now" and that is.  

On 23.05.2012, at 19:41, Phil Race wrote:

> 
> On 5/23/2012 8:25 AM, Henri Gomez wrote:
>>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
>> OpenJDK will use Oracle icons ? Even for the community version ?
> 
> I was wondering about this too. It seems wrong. The icon, and/or the header file
> should be in "closed".  We do not put branded images in the open tree, no
> matter how its encoded since they aren't open source.
> The openjdk should use something like the open source duke icon.
> I am not sure I see how/where that works.
> 
> BTW good luck seeing
> 
>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168062
> 
> its marked for internal consumption only (for some reason I can't fathom).
> 
> -phil.
> 
> 
> 



From leonid.romanov at oracle.com  Thu May 24 06:23:14 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Thu, 24 May 2012 17:23:14 +0400
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
	defaults to Generic Java Application Category
Message-ID: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>

Hi,
Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything. 

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/

Thanks,
Leonid.



From scott.kovatch at oracle.com  Thu May 24 06:39:19 2012
From: scott.kovatch at oracle.com (Scott Kovatch)
Date: Thu, 24 May 2012 17:39:19 +0400
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
	defaults to Generic Java Application Category
In-Reply-To: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
References: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
Message-ID: <C23C80B4-4B63-4A13-B335-9612E2402A27@oracle.com>

Looks good to me. Ripping out code for a fix is a good thing.

-- Scott

On May 24, 2012, at 5:23 PM, Leonid Romanov wrote:

> Hi,
> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything. 
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
> 
> Thanks,
> Leonid.
> 



From alexander.zuev at oracle.com  Thu May 24 07:33:04 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Thu, 24 May 2012 18:33:04 +0400
Subject: <AWT Dev> [7u6] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <4FBE3C36.7030808@oracle.com>
References: <4FBD15AA.7060206@oracle.com> <4FBD1CA8.8080703@oracle.com>
	<4FBD2859.9010000@oracle.com> <4FBD2BD3.7080706@oracle.com>
	<4FBE00E1.1040600@oracle.com> <4FBE3C36.7030808@oracle.com>
Message-ID: <4FBE46A0.20702@oracle.com>

Steve,

   i guess you are right and i gladly borrow your version of comment to use.
This and two other typos caught by Scott Palmer leads us to the fourth 
version of
the webrev which can be found here: 
http://cr.openjdk.java.net/~kizune/7171163/webrev.03

With best regards,
Alex

On 5/24/12 17:48, steve.x.northover at oracle.com wrote:
> Thanks for commenting this for the next guy.
>
> Nit pick:
>
> // Despite the naming this method on MacOS only making one event from
> // the native loop to be executed so this call is not blocking
>
> Is not great English.  How about "Despite the naming of this method, 
> on MacOS only one event is read and dispatched before this method 
> returns.  This call is non-blocking and does not wait for an event"
>
> Thanks,
> Steve
>
> On 24/05/2012 5:35 AM, Alexander Zuev wrote:
>> Steve,
>>
>>   i've updated comments anywhere i can to reflect specific design of 
>> this feature on Mac.
>> Also i have removed the unneeded call to the native function from the 
>> exit() method to save
>> us some cycles on Java<->JNI call.
>>
>>   Updated webrev can be found here:
>> http://cr.openjdk.java.net/~kizune/7171163/webrev.01/
>>
>>   I also will send the formal request to approve the same change in 
>> jdk8 since we have to push change
>> there before we can push it into the jdk7u6.
>>
>> With best regards,
>> Alex
>>
>> On 5/23/12 22:26, steve.x.northover at oracle.com wrote:
>>> ToolkitThreadBlockedHandler seems to be shared code and it follows 
>>> the enter / exit naming that is wrong.  It seems that a lot of 
>>> changes will be needed in shared code so I'm not sure the renaming 
>>> is worth it.
>>>
>>> You could add update the comments to indicate how this is used and 
>>> save the renaming for another day.
>>>
>>> Steve
>>>
>>> On 23/05/2012 2:11 PM, Alexander Zuev wrote:
>>>> Steve,
>>>>
>>>>   you are absolutely right - this native method is used only by our 
>>>> implementation of the DnD so
>>>> i may just rename it and the only reason i have not done it is to 
>>>> minimize the scope of the change.
>>>> So if you think renaming the method is required i will gladly do it.
>>>>
>>>> With best regards,
>>>> Alex
>>>>
>>>> On 5/23/12 21:21, steve.x.northover at oracle.com wrote:
>>>>> The implementation matches how these methods are used by drag and 
>>>>> drop but the naming makes no sense.  Who else calls these 
>>>>> methods?  I'm assuming nobody (or that they are all called with 
>>>>> the same implementation in mind).
>>>>>
>>>>> startNativeNestedEventLoop is really "read and dispatch an event 
>>>>> without blocking".
>>>>>
>>>>> Steve
>>>>>
>>>>> On 23/05/2012 12:51 PM, Alexander Zuev wrote:
>>>>>> Hello,
>>>>>>
>>>>>>   please review my fix for the
>>>>>> 7171163: [macosx] Shortcomings in the design of the secondary 
>>>>>> native event loop made JavaFX DnD deadlock
>>>>>>
>>>>>>   Bug can be found at 
>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>>>>>>
>>>>>>   Webrev can be found at: 
>>>>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.00/
>>>>>>
>>>>>> With best regards,
>>>>>> Alexander Zuev
>>>>
>>



From artem.ananiev at oracle.com  Thu May 24 09:12:14 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Thu, 24 May 2012 20:12:14 +0400
Subject: <AWT Dev> [7u6] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <4FBE46A0.20702@oracle.com>
References: <4FBD15AA.7060206@oracle.com> <4FBD1CA8.8080703@oracle.com>
	<4FBD2859.9010000@oracle.com> <4FBD2BD3.7080706@oracle.com>
	<4FBE00E1.1040600@oracle.com> <4FBE3C36.7030808@oracle.com>
	<4FBE46A0.20702@oracle.com>
Message-ID: <4FBE5DDE.4090901@oracle.com>

Hi, Alex,

the fix looks fine for 7u6. In JDK8 version of the fix, I would rename 
startNativeNestedEventLoop() in LWCToolkit to something like runOneEvent().

Thanks,

Artem

On 5/24/2012 6:33 PM, Alexander Zuev wrote:
> Steve,
>
> i guess you are right and i gladly borrow your version of comment to use.
> This and two other typos caught by Scott Palmer leads us to the fourth
> version of
> the webrev which can be found here:
> http://cr.openjdk.java.net/~kizune/7171163/webrev.03
>
> With best regards,
> Alex
>
> On 5/24/12 17:48, steve.x.northover at oracle.com wrote:
>> Thanks for commenting this for the next guy.
>>
>> Nit pick:
>>
>> // Despite the naming this method on MacOS only making one event from
>> // the native loop to be executed so this call is not blocking
>>
>> Is not great English. How about "Despite the naming of this method, on
>> MacOS only one event is read and dispatched before this method
>> returns. This call is non-blocking and does not wait for an event"
>>
>> Thanks,
>> Steve
>>
>> On 24/05/2012 5:35 AM, Alexander Zuev wrote:
>>> Steve,
>>>
>>> i've updated comments anywhere i can to reflect specific design of
>>> this feature on Mac.
>>> Also i have removed the unneeded call to the native function from the
>>> exit() method to save
>>> us some cycles on Java<->JNI call.
>>>
>>> Updated webrev can be found here:
>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.01/
>>>
>>> I also will send the formal request to approve the same change in
>>> jdk8 since we have to push change
>>> there before we can push it into the jdk7u6.
>>>
>>> With best regards,
>>> Alex
>>>
>>> On 5/23/12 22:26, steve.x.northover at oracle.com wrote:
>>>> ToolkitThreadBlockedHandler seems to be shared code and it follows
>>>> the enter / exit naming that is wrong. It seems that a lot of
>>>> changes will be needed in shared code so I'm not sure the renaming
>>>> is worth it.
>>>>
>>>> You could add update the comments to indicate how this is used and
>>>> save the renaming for another day.
>>>>
>>>> Steve
>>>>
>>>> On 23/05/2012 2:11 PM, Alexander Zuev wrote:
>>>>> Steve,
>>>>>
>>>>> you are absolutely right - this native method is used only by our
>>>>> implementation of the DnD so
>>>>> i may just rename it and the only reason i have not done it is to
>>>>> minimize the scope of the change.
>>>>> So if you think renaming the method is required i will gladly do it.
>>>>>
>>>>> With best regards,
>>>>> Alex
>>>>>
>>>>> On 5/23/12 21:21, steve.x.northover at oracle.com wrote:
>>>>>> The implementation matches how these methods are used by drag and
>>>>>> drop but the naming makes no sense. Who else calls these methods?
>>>>>> I'm assuming nobody (or that they are all called with the same
>>>>>> implementation in mind).
>>>>>>
>>>>>> startNativeNestedEventLoop is really "read and dispatch an event
>>>>>> without blocking".
>>>>>>
>>>>>> Steve
>>>>>>
>>>>>> On 23/05/2012 12:51 PM, Alexander Zuev wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> please review my fix for the
>>>>>>> 7171163: [macosx] Shortcomings in the design of the secondary
>>>>>>> native event loop made JavaFX DnD deadlock
>>>>>>>
>>>>>>> Bug can be found at
>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>>>>>>>
>>>>>>> Webrev can be found at:
>>>>>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.00/
>>>>>>>
>>>>>>> With best regards,
>>>>>>> Alexander Zuev
>>>>>
>>>
>


From leonid.romanov at oracle.com  Thu May 24 11:33:29 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Thu, 24 May 2012 22:33:29 +0400
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
	processes on Mac should use Oracle Java branded icons
In-Reply-To: <4FBE7C26.9050609@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<4FBD052D.7080101@oracle.com>
	<14564BAB-38B9-45C5-B921-C6CBCB568685@oracle.com>
	<4FBE7C26.9050609@oracle.com>
Message-ID: <D1F55F0A-E351-41D4-B6E7-A613305BFFE4@oracle.com>

Yep, we do need a generic icon file for the OpenJDK distribution. It would be great if you could provide me with one.

On 24.05.2012, at 22:21, Jeff Hoffman wrote:

> I need to do some research on this question...  We should follow what has been done before.  It makes sense that we don't put Oracle branded images in the OpenJDK distribution -- but I'm not exactly sure what we have been putting in there up until now...  If we need a "generic" icns file for the Mac port, I can supply one.
> 
> -jeff
> 
> On 5/24/12 5:22 AM, Leonid Romanov wrote:
>> I'm not sure whether Jeff Hoffman, who filed 7168062, is on the list, so I'm adding him to CC. Perhaps he would be able to comment on what repo the branded icon should go and what icon to use for the open tree.
>> As for 7168062 not being visible to the outside world, there isn't much to see. It basically states "we should use branded icon instead what we use now" and that is.
>> 
>> On 23.05.2012, at 19:41, Phil Race wrote:
>> 
>>> On 5/23/2012 8:25 AM, Henri Gomez wrote:
>>>>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
>>>> OpenJDK will use Oracle icons ? Even for the community version ?
>>> I was wondering about this too. It seems wrong. The icon, and/or the header file
>>> should be in "closed".  We do not put branded images in the open tree, no
>>> matter how its encoded since they aren't open source.
>>> The openjdk should use something like the open source duke icon.
>>> I am not sure I see how/where that works.
>>> 
>>> BTW good luck seeing
>>> 
>>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168062
>>> its marked for internal consumption only (for some reason I can't fathom).
>>> 
>>> -phil.
>>> 
>>> 
>>> 



From dalibor.topic at oracle.com  Thu May 24 16:12:06 2012
From: dalibor.topic at oracle.com (Dalibor Topic)
Date: Fri, 25 May 2012 01:12:06 +0200
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
 processes on Mac should use Oracle Java branded icons
In-Reply-To: <4FBD052D.7080101@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<4FBD052D.7080101@oracle.com>
Message-ID: <4FBEC046.8090309@oracle.com>

On 5/23/12 5:41 PM, Phil Race wrote:
> 
> On 5/23/2012 8:25 AM, Henri Gomez wrote:
>>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
>> OpenJDK will use Oracle icons ? Even for the community version ?
> 
> I was wondering about this too. It seems wrong. The icon, and/or the header file
> should be in "closed".  

Correct.

> We do not put branded images in the open tree, no
> matter how its encoded since they aren't open source.

Correct.

> The openjdk should use something like the open source duke icon.

Or even better, no image by default in OpenJDK, with an ALT_ICON_DATA that can be supplied to point 
to the icon to use. That way we don't have to bikeshed about say following the annual Duke fashion 
trends, and yet people who want to add some open source icon to their builds can do so.

cheers,
dalibor topic
-- 
Oracle <http://www.oracle.com>
Dalibor Topic | Principal Product Manager
Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961>
Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 M?nchen
Registergericht: Amtsgericht M?nchen, HRA 95603
Gesch?ftsf?hrer: J?rgen Kunz

Komplement?rin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment


From scott.kovatch at oracle.com  Thu May 24 19:49:49 2012
From: scott.kovatch at oracle.com (Scott Kovatch)
Date: Fri, 25 May 2012 06:49:49 +0400
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
	processes on Mac should use Oracle Java branded icons
In-Reply-To: <4FBEC046.8090309@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<4FBD052D.7080101@oracle.com> <4FBEC046.8090309@oracle.com>
Message-ID: <5C3B17A4-7005-424C-9FB5-3DC5CBFCD498@oracle.com>


On May 25, 2012, at 3:12 AM, Dalibor Topic <dalibor.topic at oracle.com> wrote:

> On 5/23/12 5:41 PM, Phil Race wrote:
>> 
>> On 5/23/2012 8:25 AM, Henri Gomez wrote:
>>>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
>>> OpenJDK will use Oracle icons ? Even for the community version ?
>> 
>> I was wondering about this too. It seems wrong. The icon, and/or the header file
>> should be in "closed".  
> 
> Correct.
> 
>> We do not put branded images in the open tree, no
>> matter how its encoded since they aren't open source.
> 
> Correct.
> 
>> The openjdk should use something like the open source duke icon.
> 
> Or even better, no image by default in OpenJDK, with an ALT_ICON_DATA that can be supplied to point 
> to the icon to use. That way we don't have to bikeshed about say following the annual Duke fashion 
> trends, and yet people who want to add some open source icon to their builds can do so.

Okay, let's get the facts out before we do anything crazy.

Java applications should have a Dock icon when running, so we don't use the default application icon. Currently the AWT uses /System/Library/Frameworks/JavaVM.framework/Resources/GenericApp.icns, which means it's Apple's icon right now. Oracle would like to use its own icon.

OpenJDK (IMO) shouldn't rely on an icon in a framework that could disappear in the next year or two, so it should use its own icon. The AWT will need to change for that to happen. If Apple would like to donate this icon I think it would be great, and would solve that problem nicely. It's then up to Leonid to decide how to best use it.

Next, Oracle would like to override the default icon so it can use its own icon. If OpenJDK would like to specify the path with a make variable that can be overridden, I think that would solve that part of the problem as well.

Does this sound like a plan? Mike S., what do you think? Leonid, does this work for you?

- Scott K.



From philip.race at oracle.com  Thu May 24 21:40:36 2012
From: philip.race at oracle.com (Phil Race)
Date: Thu, 24 May 2012 21:40:36 -0700
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
 processes on Mac should use Oracle Java branded icons
In-Reply-To: <5C3B17A4-7005-424C-9FB5-3DC5CBFCD498@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<4FBD052D.7080101@oracle.com> <4FBEC046.8090309@oracle.com>
	<5C3B17A4-7005-424C-9FB5-3DC5CBFCD498@oracle.com>
Message-ID: <4FBF0D44.3060709@oracle.com>

We don't need Apple to donate an Icon .. we can simply provide one for 
OpenJDK (open) AND one for Oracle JDK (closed).
Jeff Hoffman is concocting a Duke one for OpenJDK
The build process can then simply determine which one to used based on 
which build its doing
(Oracle or Open) as happens in a number of places. No need for a new 
make variable.

-phil.

On 5/24/2012 7:49 PM, Scott Kovatch wrote:
> On May 25, 2012, at 3:12 AM, Dalibor Topic<dalibor.topic at oracle.com>  wrote:
>
>> On 5/23/12 5:41 PM, Phil Race wrote:
>>> On 5/23/2012 8:25 AM, Henri Gomez wrote:
>>>>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
>>>> OpenJDK will use Oracle icons ? Even for the community version ?
>>> I was wondering about this too. It seems wrong. The icon, and/or the header file
>>> should be in "closed".
>> Correct.
>>
>>> We do not put branded images in the open tree, no
>>> matter how its encoded since they aren't open source.
>> Correct.
>>
>>> The openjdk should use something like the open source duke icon.
>> Or even better, no image by default in OpenJDK, with an ALT_ICON_DATA that can be supplied to point
>> to the icon to use. That way we don't have to bikeshed about say following the annual Duke fashion
>> trends, and yet people who want to add some open source icon to their builds can do so.
> Okay, let's get the facts out before we do anything crazy.
>
> Java applications should have a Dock icon when running, so we don't use the default application icon. Currently the AWT uses /System/Library/Frameworks/JavaVM.framework/Resources/GenericApp.icns, which means it's Apple's icon right now. Oracle would like to use its own icon.
>
> OpenJDK (IMO) shouldn't rely on an icon in a framework that could disappear in the next year or two, so it should use its own icon. The AWT will need to change for that to happen. If Apple would like to donate this icon I think it would be great, and would solve that problem nicely. It's then up to Leonid to decide how to best use it.
>
> Next, Oracle would like to override the default icon so it can use its own icon. If OpenJDK would like to specify the path with a make variable that can be overridden, I think that would solve that part of the problem as well.
>
> Does this sound like a plan? Mike S., what do you think? Leonid, does this work for you?
>
> - Scott K.
>



From david.holmes at oracle.com  Thu May 24 23:20:09 2012
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 25 May 2012 16:20:09 +1000
Subject: <AWT Dev> RFR: 7171653 32-bit cross-compile on 64-bit build host
 generates 64-bit data for awt/X11 leading to crash
Message-ID: <4FBF2499.1040304@oracle.com>

This is a tweak to the cross-compilation rules in sun/xawt/Makefile to 
force correct compilation of the sizers utility.

http://cr.openjdk.java.net/~dholmes/7171653/webrev/

webrev is against tl/jdk but I can use a different repo if you prefer.

Now that we use CFLAGS_32/64 in the cross compilation case we no longer 
need different cc commands, other than the actual choice of compiler.

Longer term 7153072 will make this fix obsolete but for now we need this 
for our new build servers, and I wanted to make sure this only affected 
cross-compilation.

Same change will need to go to the 7u train as well.

Thanks,
David


From henri.gomez at gmail.com  Wed May 23 08:25:10 2012
From: henri.gomez at gmail.com (Henri Gomez)
Date: Wed, 23 May 2012 08:25:10 -0700
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
 processes on Mac should use Oracle Java branded icons
In-Reply-To: <DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>
	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
Message-ID: <CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>

> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?

OpenJDK will use Oracle icons ? Even for the community version ?


From henri.gomez at gmail.com  Wed May 23 08:36:19 2012
From: henri.gomez at gmail.com (Henri Gomez)
Date: Wed, 23 May 2012 08:36:19 -0700
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
 processes on Mac should use Oracle Java branded icons
In-Reply-To: <D5B03F1A-69C4-4991-94D9-B5B26F0998D8@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>
	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<D5B03F1A-69C4-4991-94D9-B5B26F0998D8@oracle.com>
Message-ID: <CALyUpY1ByN2LhsCBWMpPLKkin3WQ0NeJC-Xxv7BrEK5egd2Grw@mail.gmail.com>

> We don't want to use the Apple java icons. It doesn't have 'Oracle' or anything like that on it -- it's just the generic steaming coffee cup in orange and blue. In fact, I believe it is already in use as the bundle icon for the JDK.

Ok Scott.

Didn't see any icon (.icns) under Contents/Home/jre/lib/images
(OpenJDK / Oracle JDK).

Only notice an icon for visualvm in Oracle JDK.


From steve.x.northover at oracle.com  Wed May 23 10:21:44 2012
From: steve.x.northover at oracle.com (steve.x.northover at oracle.com)
Date: Wed, 23 May 2012 13:21:44 -0400
Subject: <AWT Dev> [7u6] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <4FBD15AA.7060206@oracle.com>
References: <4FBD15AA.7060206@oracle.com>
Message-ID: <4FBD1CA8.8080703@oracle.com>

The implementation matches how these methods are used by drag and drop 
but the naming makes no sense.  Who else calls these methods?  I'm 
assuming nobody (or that they are all called with the same 
implementation in mind).

startNativeNestedEventLoop is really "read and dispatch an event without 
blocking".

Steve

On 23/05/2012 12:51 PM, Alexander Zuev wrote:
> Hello,
>
>   please review my fix for the
> 7171163: [macosx] Shortcomings in the design of the secondary native 
> event loop made JavaFX DnD deadlock
>
>   Bug can be found at 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>
>   Webrev can be found at: 
> http://cr.openjdk.java.net/~kizune/7171163/webrev.00/
>
> With best regards,
> Alexander Zuev


From steve.x.northover at oracle.com  Wed May 23 11:26:27 2012
From: steve.x.northover at oracle.com (steve.x.northover at oracle.com)
Date: Wed, 23 May 2012 14:26:27 -0400
Subject: <AWT Dev> [7u6] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <4FBD2859.9010000@oracle.com>
References: <4FBD15AA.7060206@oracle.com> <4FBD1CA8.8080703@oracle.com>
	<4FBD2859.9010000@oracle.com>
Message-ID: <4FBD2BD3.7080706@oracle.com>

ToolkitThreadBlockedHandler seems to be shared code and it follows the 
enter / exit naming that is wrong.  It seems that a lot of changes will 
be needed in shared code so I'm not sure the renaming is worth it.

You could add update the comments to indicate how this is used and save 
the renaming for another day.

Steve

On 23/05/2012 2:11 PM, Alexander Zuev wrote:
> Steve,
>
>   you are absolutely right - this native method is used only by our 
> implementation of the DnD so
> i may just rename it and the only reason i have not done it is to 
> minimize the scope of the change.
> So if you think renaming the method is required i will gladly do it.
>
> With best regards,
> Alex
>
> On 5/23/12 21:21, steve.x.northover at oracle.com wrote:
>> The implementation matches how these methods are used by drag and 
>> drop but the naming makes no sense.  Who else calls these methods?  
>> I'm assuming nobody (or that they are all called with the same 
>> implementation in mind).
>>
>> startNativeNestedEventLoop is really "read and dispatch an event 
>> without blocking".
>>
>> Steve
>>
>> On 23/05/2012 12:51 PM, Alexander Zuev wrote:
>>> Hello,
>>>
>>>   please review my fix for the
>>> 7171163: [macosx] Shortcomings in the design of the secondary native 
>>> event loop made JavaFX DnD deadlock
>>>
>>>   Bug can be found at 
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>>>
>>>   Webrev can be found at: 
>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.00/
>>>
>>> With best regards,
>>> Alexander Zuev
>


From steve.x.northover at oracle.com  Thu May 24 06:48:38 2012
From: steve.x.northover at oracle.com (steve.x.northover at oracle.com)
Date: Thu, 24 May 2012 09:48:38 -0400
Subject: <AWT Dev> [7u6] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <4FBE00E1.1040600@oracle.com>
References: <4FBD15AA.7060206@oracle.com> <4FBD1CA8.8080703@oracle.com>
	<4FBD2859.9010000@oracle.com> <4FBD2BD3.7080706@oracle.com>
	<4FBE00E1.1040600@oracle.com>
Message-ID: <4FBE3C36.7030808@oracle.com>

Thanks for commenting this for the next guy.

Nit pick:

// Despite the naming this method on MacOS only making one event from
// the native loop to be executed so this call is not blocking

Is not great English.  How about "Despite the naming of this method, on 
MacOS only one event is read and dispatched before this method returns.  
This call is non-blocking and does not wait for an event"

Thanks,
Steve

On 24/05/2012 5:35 AM, Alexander Zuev wrote:
> Steve,
>
>   i've updated comments anywhere i can to reflect specific design of 
> this feature on Mac.
> Also i have removed the unneeded call to the native function from the 
> exit() method to save
> us some cycles on Java<->JNI call.
>
>   Updated webrev can be found here:
> http://cr.openjdk.java.net/~kizune/7171163/webrev.01/
>
>   I also will send the formal request to approve the same change in 
> jdk8 since we have to push change
> there before we can push it into the jdk7u6.
>
> With best regards,
> Alex
>
> On 5/23/12 22:26, steve.x.northover at oracle.com wrote:
>> ToolkitThreadBlockedHandler seems to be shared code and it follows 
>> the enter / exit naming that is wrong.  It seems that a lot of 
>> changes will be needed in shared code so I'm not sure the renaming is 
>> worth it.
>>
>> You could add update the comments to indicate how this is used and 
>> save the renaming for another day.
>>
>> Steve
>>
>> On 23/05/2012 2:11 PM, Alexander Zuev wrote:
>>> Steve,
>>>
>>>   you are absolutely right - this native method is used only by our 
>>> implementation of the DnD so
>>> i may just rename it and the only reason i have not done it is to 
>>> minimize the scope of the change.
>>> So if you think renaming the method is required i will gladly do it.
>>>
>>> With best regards,
>>> Alex
>>>
>>> On 5/23/12 21:21, steve.x.northover at oracle.com wrote:
>>>> The implementation matches how these methods are used by drag and 
>>>> drop but the naming makes no sense.  Who else calls these methods?  
>>>> I'm assuming nobody (or that they are all called with the same 
>>>> implementation in mind).
>>>>
>>>> startNativeNestedEventLoop is really "read and dispatch an event 
>>>> without blocking".
>>>>
>>>> Steve
>>>>
>>>> On 23/05/2012 12:51 PM, Alexander Zuev wrote:
>>>>> Hello,
>>>>>
>>>>>   please review my fix for the
>>>>> 7171163: [macosx] Shortcomings in the design of the secondary 
>>>>> native event loop made JavaFX DnD deadlock
>>>>>
>>>>>   Bug can be found at 
>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>>>>>
>>>>>   Webrev can be found at: 
>>>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.00/
>>>>>
>>>>> With best regards,
>>>>> Alexander Zuev
>>>
>


From steve.x.northover at oracle.com  Thu May 24 08:26:34 2012
From: steve.x.northover at oracle.com (steve.x.northover at oracle.com)
Date: Thu, 24 May 2012 11:26:34 -0400
Subject: <AWT Dev> [7u6] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <4FBE46A0.20702@oracle.com>
References: <4FBD15AA.7060206@oracle.com> <4FBD1CA8.8080703@oracle.com>
	<4FBD2859.9010000@oracle.com> <4FBD2BD3.7080706@oracle.com>
	<4FBE00E1.1040600@oracle.com> <4FBE3C36.7030808@oracle.com>
	<4FBE46A0.20702@oracle.com>
Message-ID: <4FBE532A.2020609@oracle.com>

Thanks so much for finding and fixing this critical issue.

Steve

On 24/05/2012 10:33 AM, Alexander Zuev wrote:
> Steve,
>
>   i guess you are right and i gladly borrow your version of comment to 
> use.
> This and two other typos caught by Scott Palmer leads us to the fourth 
> version of
> the webrev which can be found here: 
> http://cr.openjdk.java.net/~kizune/7171163/webrev.03
>
> With best regards,
> Alex
>
> On 5/24/12 17:48, steve.x.northover at oracle.com wrote:
>> Thanks for commenting this for the next guy.
>>
>> Nit pick:
>>
>> // Despite the naming this method on MacOS only making one event from
>> // the native loop to be executed so this call is not blocking
>>
>> Is not great English.  How about "Despite the naming of this method, 
>> on MacOS only one event is read and dispatched before this method 
>> returns.  This call is non-blocking and does not wait for an event"
>>
>> Thanks,
>> Steve
>>
>> On 24/05/2012 5:35 AM, Alexander Zuev wrote:
>>> Steve,
>>>
>>>   i've updated comments anywhere i can to reflect specific design of 
>>> this feature on Mac.
>>> Also i have removed the unneeded call to the native function from 
>>> the exit() method to save
>>> us some cycles on Java<->JNI call.
>>>
>>>   Updated webrev can be found here:
>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.01/
>>>
>>>   I also will send the formal request to approve the same change in 
>>> jdk8 since we have to push change
>>> there before we can push it into the jdk7u6.
>>>
>>> With best regards,
>>> Alex
>>>
>>> On 5/23/12 22:26, steve.x.northover at oracle.com wrote:
>>>> ToolkitThreadBlockedHandler seems to be shared code and it follows 
>>>> the enter / exit naming that is wrong.  It seems that a lot of 
>>>> changes will be needed in shared code so I'm not sure the renaming 
>>>> is worth it.
>>>>
>>>> You could add update the comments to indicate how this is used and 
>>>> save the renaming for another day.
>>>>
>>>> Steve
>>>>
>>>> On 23/05/2012 2:11 PM, Alexander Zuev wrote:
>>>>> Steve,
>>>>>
>>>>>   you are absolutely right - this native method is used only by 
>>>>> our implementation of the DnD so
>>>>> i may just rename it and the only reason i have not done it is to 
>>>>> minimize the scope of the change.
>>>>> So if you think renaming the method is required i will gladly do it.
>>>>>
>>>>> With best regards,
>>>>> Alex
>>>>>
>>>>> On 5/23/12 21:21, steve.x.northover at oracle.com wrote:
>>>>>> The implementation matches how these methods are used by drag and 
>>>>>> drop but the naming makes no sense.  Who else calls these 
>>>>>> methods?  I'm assuming nobody (or that they are all called with 
>>>>>> the same implementation in mind).
>>>>>>
>>>>>> startNativeNestedEventLoop is really "read and dispatch an event 
>>>>>> without blocking".
>>>>>>
>>>>>> Steve
>>>>>>
>>>>>> On 23/05/2012 12:51 PM, Alexander Zuev wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>>   please review my fix for the
>>>>>>> 7171163: [macosx] Shortcomings in the design of the secondary 
>>>>>>> native event loop made JavaFX DnD deadlock
>>>>>>>
>>>>>>>   Bug can be found at 
>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>>>>>>>
>>>>>>>   Webrev can be found at: 
>>>>>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.00/
>>>>>>>
>>>>>>> With best regards,
>>>>>>> Alexander Zuev
>>>>>
>>>
>


From jeff.hoffman at oracle.com  Thu May 24 11:21:26 2012
From: jeff.hoffman at oracle.com (Jeff Hoffman)
Date: Thu, 24 May 2012 11:21:26 -0700
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
 processes on Mac should use Oracle Java branded icons
In-Reply-To: <14564BAB-38B9-45C5-B921-C6CBCB568685@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<4FBD052D.7080101@oracle.com>
	<14564BAB-38B9-45C5-B921-C6CBCB568685@oracle.com>
Message-ID: <4FBE7C26.9050609@oracle.com>

I need to do some research on this question...  We should follow what 
has been done before.  It makes sense that we don't put Oracle branded 
images in the OpenJDK distribution -- but I'm not exactly sure what we 
have been putting in there up until now...  If we need a "generic" icns 
file for the Mac port, I can supply one.

-jeff

On 5/24/12 5:22 AM, Leonid Romanov wrote:
> I'm not sure whether Jeff Hoffman, who filed 7168062, is on the list, so I'm adding him to CC. Perhaps he would be able to comment on what repo the branded icon should go and what icon to use for the open tree.
> As for 7168062 not being visible to the outside world, there isn't much to see. It basically states "we should use branded icon instead what we use now" and that is.
>
> On 23.05.2012, at 19:41, Phil Race wrote:
>
>> On 5/23/2012 8:25 AM, Henri Gomez wrote:
>>>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
>>> OpenJDK will use Oracle icons ? Even for the community version ?
>> I was wondering about this too. It seems wrong. The icon, and/or the header file
>> should be in "closed".  We do not put branded images in the open tree, no
>> matter how its encoded since they aren't open source.
>> The openjdk should use something like the open source duke icon.
>> I am not sure I see how/where that works.
>>
>> BTW good luck seeing
>>
>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168062
>> its marked for internal consumption only (for some reason I can't fathom).
>>
>> -phil.
>>
>>
>>


From leonid.romanov at oracle.com  Fri May 25 03:10:28 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Fri, 25 May 2012 14:10:28 +0400
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
	processes on Mac should use Oracle Java branded icons
In-Reply-To: <4FBF0D44.3060709@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<4FBD052D.7080101@oracle.com> <4FBEC046.8090309@oracle.com>
	<5C3B17A4-7005-424C-9FB5-3DC5CBFCD498@oracle.com>
	<4FBF0D44.3060709@oracle.com>
Message-ID: <844C61F1-23F8-46E6-8134-A071A1ED4382@oracle.com>

I've looked at what icon is used in OpenJDK for Windows and X11, and they both use Duke icon. So, I guess, it makes sense for OS X to use Duke image as well. 

On 25.05.2012, at 8:40, Phil Race wrote:

> We don't need Apple to donate an Icon .. we can simply provide one for OpenJDK (open) AND one for Oracle JDK (closed).
> Jeff Hoffman is concocting a Duke one for OpenJDK
> The build process can then simply determine which one to used based on which build its doing
> (Oracle or Open) as happens in a number of places. No need for a new make variable.
> 
> -phil.
> 
> On 5/24/2012 7:49 PM, Scott Kovatch wrote:
>> On May 25, 2012, at 3:12 AM, Dalibor Topic<dalibor.topic at oracle.com>  wrote:
>> 
>>> On 5/23/12 5:41 PM, Phil Race wrote:
>>>> On 5/23/2012 8:25 AM, Henri Gomez wrote:
>>>>>> That seems like overkill to me. Can't we just put the .icns in the JRE (Contents/Home/jre/lib/images) and load it from there? What are we guarding against by putting it into a .h file?
>>>>> OpenJDK will use Oracle icons ? Even for the community version ?
>>>> I was wondering about this too. It seems wrong. The icon, and/or the header file
>>>> should be in "closed".
>>> Correct.
>>> 
>>>> We do not put branded images in the open tree, no
>>>> matter how its encoded since they aren't open source.
>>> Correct.
>>> 
>>>> The openjdk should use something like the open source duke icon.
>>> Or even better, no image by default in OpenJDK, with an ALT_ICON_DATA that can be supplied to point
>>> to the icon to use. That way we don't have to bikeshed about say following the annual Duke fashion
>>> trends, and yet people who want to add some open source icon to their builds can do so.
>> Okay, let's get the facts out before we do anything crazy.
>> 
>> Java applications should have a Dock icon when running, so we don't use the default application icon. Currently the AWT uses /System/Library/Frameworks/JavaVM.framework/Resources/GenericApp.icns, which means it's Apple's icon right now. Oracle would like to use its own icon.
>> 
>> OpenJDK (IMO) shouldn't rely on an icon in a framework that could disappear in the next year or two, so it should use its own icon. The AWT will need to change for that to happen. If Apple would like to donate this icon I think it would be great, and would solve that problem nicely. It's then up to Leonid to decide how to best use it.
>> 
>> Next, Oracle would like to override the default icon so it can use its own icon. If OpenJDK would like to specify the path with a make variable that can be overridden, I think that would solve that part of the problem as well.
>> 
>> Does this sound like a plan? Mike S., what do you think? Leonid, does this work for you?
>> 
>> - Scott K.
>> 
> 



From anthony.petrov at oracle.com  Fri May 25 03:38:11 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 25 May 2012 14:38:11 +0400
Subject: <AWT Dev> [8] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <4FBE010C.4000405@oracle.com>
References: <4FBE010C.4000405@oracle.com>
Message-ID: <4FBF6113.6050601@oracle.com>

Hi Alexander,

I guess I'm a bit late with the review, but my comment also concerns the 
fix for 7u6. You're changing the shared file 
SunDropTargetContextPeer.java and reverting a boolean argument when 
calling postDropTargetEvent. Can this change affect other platforms? 
Have you run some tests for DnD area on Win and X11 to verify nothing is 
broken?

--
best regards,
Anthony

On 5/24/2012 1:36 PM, Alexander Zuev wrote:
> Hello,
> 
>   please review my fix for the
> 7171163: [macosx] Shortcomings in the design of the secondary native 
> event loop made JavaFX DnD deadlock
> 
>   Bug can be found at 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
> 
>   Webrev can be found at:
> http://cr.openjdk.java.net/~kizune/7171163/webrev.01/
> 
> With best regards,
> Alexander Zuev


From anthony.petrov at oracle.com  Fri May 25 04:08:13 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 25 May 2012 15:08:13 +0400
Subject: <AWT Dev> [8] Please review my fix for 7171163: [macosx]
 Shortcomings in the design of the secondary native event loop made JavaFX
 DnD deadlock
In-Reply-To: <D187CA06-C509-4C6A-BC5C-A7211EF98979@oracle.com>
References: <4FBE010C.4000405@oracle.com> <4FBF6113.6050601@oracle.com>
	<D187CA06-C509-4C6A-BC5C-A7211EF98979@oracle.com>
Message-ID: <4FBF681D.5080607@oracle.com>

Thanks for the confirmation. The fix looks fine to me then.

--
best regards,
Anthony

On 5/25/2012 3:04 PM, Alexander Zuev wrote:
> Anthony, I have checked it on Windows and Ubuntu - seems like there's no regressions caused by this fix.
> 
> With best regards,
> Alexander Zuev
> 
> 25.05.2012, ? 14:38, Anthony Petrov <anthony.petrov at oracle.com> ???????(?):
> 
>> Hi Alexander,
>>
>> I guess I'm a bit late with the review, but my comment also concerns the fix for 7u6. You're changing the shared file SunDropTargetContextPeer.java and reverting a boolean argument when calling postDropTargetEvent. Can this change affect other platforms? Have you run some tests for DnD area on Win and X11 to verify nothing is broken?
>>
>> --
>> best regards,
>> Anthony
>>
>> On 5/24/2012 1:36 PM, Alexander Zuev wrote:
>>> Hello,
>>>  please review my fix for the
>>> 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock
>>>  Bug can be found at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>>>  Webrev can be found at:
>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.01/
>>> With best regards,
>>> Alexander Zuev


From anthony.petrov at oracle.com  Fri May 25 04:27:55 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 25 May 2012 15:27:55 +0400
Subject: <AWT Dev> RFR: 7171653 32-bit cross-compile on 64-bit build
 host generates 64-bit data for awt/X11 leading to crash
In-Reply-To: <4FBF2499.1040304@oracle.com>
References: <4FBF2499.1040304@oracle.com>
Message-ID: <4FBF6CBB.3010706@oracle.com>

Hi David,

The fix looks fine to me. Is the empty line 281 OK in Makefiles? I'd 
remove it just in case. Besides it would make it more clearer that the 
SIZERS_CC commands are related to the SIZERS target.

--
best regards,
Anthony

On 5/25/2012 10:20 AM, David Holmes wrote:
> This is a tweak to the cross-compilation rules in sun/xawt/Makefile to 
> force correct compilation of the sizers utility.
> 
> http://cr.openjdk.java.net/~dholmes/7171653/webrev/
> 
> webrev is against tl/jdk but I can use a different repo if you prefer.
> 
> Now that we use CFLAGS_32/64 in the cross compilation case we no longer 
> need different cc commands, other than the actual choice of compiler.
> 
> Longer term 7153072 will make this fix obsolete but for now we need this 
> for our new build servers, and I wanted to make sure this only affected 
> cross-compilation.
> 
> Same change will need to go to the 7u train as well.
> 
> Thanks,
> David


From neugens.limasoftware at gmail.com  Fri May 25 05:17:03 2012
From: neugens.limasoftware at gmail.com (neugens.limasoftware at gmail.com)
Date: Fri, 25 May 2012 12:17:03 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 6800513: GTK-LaF renders menus
	incompletely
Message-ID: <20120525121734.556D947510@hg.openjdk.java.net>

Changeset: cd00d68e06ac
Author:    neugens
Date:      2012-05-25 14:16 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cd00d68e06ac

6800513: GTK-LaF renders menus incompletely
Reviewed-by: rupashka

! src/share/classes/javax/swing/JPopupMenu.java



From anton.tarasov at oracle.com  Fri May 25 05:58:07 2012
From: anton.tarasov at oracle.com (anton.tarasov at oracle.com)
Date: Fri, 25 May 2012 12:58:07 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7171776: one more
	setGlobalCurrentFocusCycleRoot	call requires doPrivileged
Message-ID: <20120525125819.012CC47514@hg.openjdk.java.net>

Changeset: 4b2b963f8774
Author:    ant
Date:      2012-05-25 20:57 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4b2b963f8774

7171776: one more setGlobalCurrentFocusCycleRoot call requires doPrivileged
Reviewed-by: art

! src/share/classes/java/awt/KeyboardFocusManager.java



From swingler at apple.com  Fri May 25 08:55:10 2012
From: swingler at apple.com (Mike Swingler)
Date: Fri, 25 May 2012 08:55:10 -0700
Subject: <AWT Dev> [7u6] Review request for 7168062: [macosx] Java
 processes on Mac should use Oracle Java branded icons
In-Reply-To: <5C3B17A4-7005-424C-9FB5-3DC5CBFCD498@oracle.com>
References: <6D5F1922-CA7C-4B08-A630-405A8920142F@oracle.com>
	<DA4EB10A-8B6C-4F1F-AD26-E1292238D844@oracle.com>
	<CALyUpY3Ok_VHg7kKX8vH18HPHpoDEzrKwr9j_7A98CCS3QQ=aA@mail.gmail.com>
	<4FBD052D.7080101@oracle.com> <4FBEC046.8090309@oracle.com>
	<5C3B17A4-7005-424C-9FB5-3DC5CBFCD498@oracle.com>
Message-ID: <9B4E36FF-A1C4-4B03-94C6-3E4FDACCD0E1@apple.com>

On May 24, 2012, at 7:49 PM, Scott Kovatch wrote:

> OpenJDK (IMO) shouldn't rely on an icon in a framework that could disappear in the next year or two, so it should use its own icon. The AWT will need to change for that to happen. If Apple would like to donate this icon I think it would be great, and would solve that problem nicely. It's then up to Leonid to decide how to best use it.

Just my 2? here:
* It is not accurate to imply that any Apple framework or resource therein is going to "go away in the next year or two".
* The Apple GenericApp.icns will be around as long as JavaRuntimeSupport and JavaNativeFoundation.
* The Apple GenericApp.icns will stay as is (it will not be up-res'd or improved).

The GA'd versions of 7u4 have effectively locked the filesystem location of this icon in stone for their supported lifetimes, in addition to all of Apple's Java SE 6 versions. I wouldn't suggest using the Apple icon if there is better or more accurate iconography available, but there is no risk in having a runtime dependency on it, as there is already today.

Regards,
Mike Swingler
Apple Inc.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120525/e11d425c/attachment.html 

From Sergey.Bylokhov at oracle.com  Fri May 25 12:32:46 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 25 May 2012 23:32:46 +0400
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FBDE860.2060203@linux.vnet.ibm.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
	<4FBCB8C4.6060205@linux.vnet.ibm.com> <4FBCD93D.2070202@oracle.com>
	<4FBDE860.2060203@linux.vnet.ibm.com>
Message-ID: <4FBFDE5E.1050400@oracle.com>

Hi, Jonathan.
Fix looks good to me. Just note that one more reviewer needed.

Thanks for the fix.

24.05.2012 11:50, Jonathan Lu wrote:
> Hello Sergey,
>
> I made one automatic jtreg test case and put it to following link 
> along with the patch.
> http://cr.openjdk.java.net/~luchsh/7170655_3/
>
> Could you please take a look?
>
> Thanks!
> - Jonathan
>
> On 05/23/2012 08:34 PM, Sergey Bylokhov wrote:
>> Hi, Jonathan,
>> Fix looks good. But I guess this bug was not caught by the regression 
>> tests, so new test should be added(automatic test is better).
>>
>> 23.05.2012 14:15, Jonathan Lu wrote:
>>> Hi Sergey,
>>>
>>> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>>>> Hi, Jonathan,
>>>> Looks like this bug is duplicate of 
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>>>> And the reason of the issue is that we post UpdateEvent in 
>>>> target.repaint() in XLabelPeer.setFont(), but we should paint 
>>>> native part of the component in place[1] and then post PaintEvent[2].
>>>>
>>>>  - To fix [1] we can replace target.repaint() to repaint() in 
>>>> setFont(). Does it solve your issue?
>>>
>>> Yes, this resolves my problem, and here's the updated patch from 
>>> your suggestion,
>>> http://cr.openjdk.java.net/~luchsh/7170655_2/
>>>
>>> Thanks a lot!
>>> - Jonathan
>>>
>>>>
>>>> 22.05.2012 11:47, Jonathan Lu wrote:
>>>>> Hi awt-dev,
>>>>>
>>>>> Here's a patch for bug 7170655, could anybody please help to take 
>>>>> a look?
>>>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>>>
>>>>> The problem is that painting event from EDT during painting 
>>>>> handling does not get processed immediately, so leave a lag to the 
>>>>> user. My solution here is to coalesce and dispatch the new paint 
>>>>> event right after it was posted. This happens only to AWT components.
>>>>>
>>>>> Thanks!
>>>>> -Jonathan
>>>>>
>>>>
>>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.



From lana.steuck at oracle.com  Fri May 25 14:34:29 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 25 May 2012 21:34:29 +0000
Subject: <AWT Dev> hg: jdk8/awt: 6 new changesets
Message-ID: <20120525213430.9FD6947526@hg.openjdk.java.net>

Changeset: b67bdaca36c2
Author:    katleman
Date:      2012-05-10 10:24 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/b67bdaca36c2

Added tag jdk8-b38 for changeset d939bd0ab13c

! .hgtags

Changeset: 955a3e8ed4f0
Author:    ohair
Date:      2012-05-10 08:26 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/955a3e8ed4f0

7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest
Reviewed-by: erikj, asaha, chegar, sla, dholmes, mbykov, coleenp

! get_source.sh
! make/scripts/hgforest.sh

Changeset: 8a4e92c10a9a
Author:    ohair
Date:      2012-05-11 17:52 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/8a4e92c10a9a

7167976: Fix broken get_source.sh script
Reviewed-by: tbell

! make/scripts/hgforest.sh

Changeset: 8927dd68aee3
Author:    katleman
Date:      2012-05-16 22:06 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/8927dd68aee3

Merge


Changeset: a2b2d435f1d2
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/a2b2d435f1d2

Added tag jdk8-b39 for changeset 8927dd68aee3

! .hgtags

Changeset: 1a8c7c530f8a
Author:    katleman
Date:      2012-05-24 16:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/rev/1a8c7c530f8a

Added tag jdk8-b40 for changeset a2b2d435f1d2

! .hgtags



From lana.steuck at oracle.com  Fri May 25 14:34:29 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 25 May 2012 21:34:29 +0000
Subject: <AWT Dev> hg: jdk8/awt/corba: 3 new changesets
Message-ID: <20120525213434.5DFE047527@hg.openjdk.java.net>

Changeset: 785af00e2827
Author:    katleman
Date:      2012-05-10 10:24 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/785af00e2827

Added tag jdk8-b38 for changeset b8cbfb31139f

! .hgtags

Changeset: 56d030e5035f
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/56d030e5035f

Added tag jdk8-b39 for changeset 785af00e2827

! .hgtags

Changeset: 113f0d5f0a08
Author:    katleman
Date:      2012-05-24 16:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/corba/rev/113f0d5f0a08

Added tag jdk8-b40 for changeset 56d030e5035f

! .hgtags



From lana.steuck at oracle.com  Fri May 25 14:34:30 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 25 May 2012 21:34:30 +0000
Subject: <AWT Dev> hg: jdk8/awt/jaxws: 3 new changesets
Message-ID: <20120525213441.D93CB47528@hg.openjdk.java.net>

Changeset: 7f6b44fd3034
Author:    katleman
Date:      2012-05-10 10:25 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/7f6b44fd3034

Added tag jdk8-b38 for changeset ac1ba3b56775

! .hgtags

Changeset: 09a0ddda03cb
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/09a0ddda03cb

Added tag jdk8-b39 for changeset 7f6b44fd3034

! .hgtags

Changeset: f2072b164b05
Author:    katleman
Date:      2012-05-24 16:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/f2072b164b05

Added tag jdk8-b40 for changeset 09a0ddda03cb

! .hgtags



From lana.steuck at oracle.com  Fri May 25 14:34:32 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 25 May 2012 21:34:32 +0000
Subject: <AWT Dev> hg: jdk8/awt/jaxp: 3 new changesets
Message-ID: <20120525213446.6B37547529@hg.openjdk.java.net>

Changeset: f95fdbe525c8
Author:    katleman
Date:      2012-05-10 10:25 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/f95fdbe525c8

Added tag jdk8-b38 for changeset 5bbe0cb6f2f2

! .hgtags

Changeset: 9ecfdbd6aed4
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/9ecfdbd6aed4

Added tag jdk8-b39 for changeset f95fdbe525c8

! .hgtags

Changeset: 6f5c0e17415d
Author:    katleman
Date:      2012-05-24 16:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/6f5c0e17415d

Added tag jdk8-b40 for changeset 9ecfdbd6aed4

! .hgtags



From lana.steuck at oracle.com  Fri May 25 14:34:34 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 25 May 2012 21:34:34 +0000
Subject: <AWT Dev> hg: jdk8/awt/langtools: 8 new changesets
Message-ID: <20120525213455.041EA4752A@hg.openjdk.java.net>

Changeset: a9f547c218d9
Author:    katleman
Date:      2012-05-10 10:25 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/a9f547c218d9

Added tag jdk8-b38 for changeset 1f224f160aa8

! .hgtags

Changeset: 8b869afd2eb4
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/8b869afd2eb4

Added tag jdk8-b39 for changeset a9f547c218d9

! .hgtags

Changeset: d10db3576c08
Author:    ksrini
Date:      2012-05-04 07:55 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/d10db3576c08

7166010: (javac) JavacMessager incorrectly restores log source file
Reviewed-by: jjg
Contributed-by: jan.lahoda at oracle.com

! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java
+ test/tools/javac/processing/messager/MessagerDiags.java

Changeset: 833bab705918
Author:    ksrini
Date:      2012-05-10 12:32 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/833bab705918

7159445: (javac) emits inaccurate diagnostics for enhanced for-loops
Reviewed-by: jjg
Contributed-by: jan.lahoda at oracle.com

! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/tools/javac/diags/examples/ForeachBadInitialization.java
! test/tools/javac/parser/JavacParserTest.java

Changeset: 96a8278e323c
Author:    sundar
Date:      2012-05-11 20:06 +0530
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/96a8278e323c

7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/Lower.java
+ test/tools/javac/TryWithResources/T7164542.java

Changeset: 885806e74240
Author:    lana
Date:      2012-05-11 12:53 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/885806e74240

Merge


Changeset: 86e0dad6aadf
Author:    lana
Date:      2012-05-21 11:44 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/86e0dad6aadf

Merge


Changeset: 179fa85aeefa
Author:    katleman
Date:      2012-05-24 16:16 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/langtools/rev/179fa85aeefa

Added tag jdk8-b40 for changeset 86e0dad6aadf

! .hgtags



From lana.steuck at oracle.com  Fri May 25 14:34:34 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 25 May 2012 21:34:34 +0000
Subject: <AWT Dev> hg: jdk8/awt/hotspot: 33 new changesets
Message-ID: <20120525213549.7A5364752B@hg.openjdk.java.net>

Changeset: 3c394919ca69
Author:    katleman
Date:      2012-05-10 10:25 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3c394919ca69

Added tag jdk8-b38 for changeset 637c3f5f068f

! .hgtags

Changeset: 36538fd1225e
Author:    amurillo
Date:      2012-05-04 15:26 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/36538fd1225e

7166615: new hotspot build - hs24-b10
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 8bafad97cd26
Author:    jiangli
Date:      2012-05-02 13:21 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8bafad97cd26

7158552: The instanceKlsss::_host_klass is only needed for anonymous class for JSR 292 support.
Summary: Change the _host_klass to be conditionally created embedded instanceKlass field.
Reviewed-by: jrose, coleenp, dholmes

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/memory/oopFactory.cpp
! src/share/vm/memory/oopFactory.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/instanceKlassKlass.cpp
! src/share/vm/oops/instanceKlassKlass.hpp

Changeset: 38b4116b6766
Author:    jprovino
Date:      2012-05-05 10:24 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/38b4116b6766

Merge


Changeset: c7ed11779ce8
Author:    jiangli
Date:      2012-04-10 09:31 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c7ed11779ce8

7159772: instanceKlass::all_fields_count() returns incorrect total field count
Summary: Fix instanceKlass::all_fields_count() bug.
Reviewed-by: kvn, never
Contributed-by: Jiangli Zhou <jiangli.zhou at oracle.com>

! src/share/vm/oops/instanceKlass.hpp

Changeset: 3576af4cb939
Author:    iveresov
Date:      2012-04-11 19:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3576af4cb939

7160539: JDeveloper crashes on 64-bit Windows
Summary: x64 C1 needs to zero upper 32bits when doing l2i conversion
Reviewed-by: never, kvn

! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp

Changeset: 847da049d62f
Author:    never
Date:      2012-04-17 11:04 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/847da049d62f

7162094: LateInlineCallGenerator::do_late_inline crashed on uninitialized _call_node
Reviewed-by: never, twisti
Contributed-by: nils.eliasson at oracle.com

! src/share/vm/opto/callGenerator.cpp

Changeset: df3d4a91f7f6
Author:    never
Date:      2012-04-18 16:08 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/df3d4a91f7f6

7161796: PhaseStringOpts::fetch_static_field tries to fetch field from the Klass instead of the mirror
Reviewed-by: twisti

! src/share/vm/opto/stringopts.cpp

Changeset: ec15e8f6e4f1
Author:    twisti
Date:      2012-04-24 12:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ec15e8f6e4f1

7157695: Add windows implementation of socket interface
Reviewed-by: kvn, dholmes, twisti
Contributed-by: Nils Eliasson <nils.eliasson at oracle.com>

! src/os/windows/vm/jvm_windows.h
! src/os/windows/vm/os_windows.cpp

Changeset: dc682d9431f3
Author:    kvn
Date:      2012-05-07 12:37 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dc682d9431f3

7160610: Unknown Native Code compilation issue
Summary: When constructing input vector use type of vector's operation which use it since element's sizes should match.
Reviewed-by: never, twisti

! src/share/vm/opto/superword.cpp
+ test/compiler/7160610/Test7160610.java

Changeset: 3a97daec1b34
Author:    kvn
Date:      2012-05-08 15:47 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3a97daec1b34

7167266: missing copyright notes in 3rd party code
Summary: add missing copyright notes to the regression test file.
Reviewed-by: twisti, johnc

! test/compiler/7070134/Stemmer.java

Changeset: 2766551175a0
Author:    kvn
Date:      2012-05-09 10:54 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2766551175a0

Merge

! src/share/vm/oops/instanceKlass.hpp

Changeset: a05a695ea044
Author:    stefank
Date:      2012-05-10 11:27 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a05a695ea044

7167437: Can't build on linux without precompiled headers
Reviewed-by: brutisso, mgerdin

! src/share/vm/memory/space.hpp
! src/share/vm/memory/space.inline.hpp

Changeset: f47478089efc
Author:    brutisso
Date:      2012-05-10 14:16 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f47478089efc

7167069: 6 VM flags crash the VM when queried via jinfo
Summary: Added missing double format to Flag::print_as_flag()
Reviewed-by: dholmes, stefank, coleenp

! src/share/vm/runtime/globals.cpp
+ test/runtime/7167069/PrintAsFlag.java

Changeset: 5799726c54d7
Author:    jcoomes
Date:      2012-05-11 06:37 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5799726c54d7

Merge


Changeset: 73147e6c4881
Author:    amurillo
Date:      2012-05-11 14:47 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/73147e6c4881

Merge


Changeset: 96a403721094
Author:    amurillo
Date:      2012-05-11 14:47 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/96a403721094

Added tag hs24-b10 for changeset 73147e6c4881

! .hgtags

Changeset: 26423ef693ac
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/26423ef693ac

Added tag jdk8-b39 for changeset 96a403721094

! .hgtags

Changeset: 56d1af561395
Author:    amurillo
Date:      2012-05-11 14:54 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/56d1af561395

7168247: new hotspot build - hs24-b11
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 35e504cb49a6
Author:    collins
Date:      2012-05-11 11:30 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/35e504cb49a6

7167625: Adjustments for SE-Embedded build process
Summary: Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users.
Reviewed-by: kvn, dholmes

! make/linux/makefiles/vm.make
! src/share/vm/runtime/arguments.cpp

Changeset: fada85d11d92
Author:    jprovino
Date:      2012-05-16 13:33 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fada85d11d92

Merge


Changeset: 8f972594effc
Author:    kvn
Date:      2012-05-14 09:36 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8f972594effc

6924259: Remove String.count/String.offset
Summary: Allow a version of String class that doesn't have count and offset fields.
Reviewed-by: never, coleenp

! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp
! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp
! src/share/vm/classfile/javaClasses.cpp
! src/share/vm/classfile/javaClasses.hpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/memory/dump.cpp
! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/graphKit.hpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/stringopts.cpp
! src/share/vm/opto/stringopts.hpp

Changeset: de0cc3dd9f10
Author:    kvn
Date:      2012-05-17 09:50 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/de0cc3dd9f10

Merge


Changeset: 3a22b77e755a
Author:    brutisso
Date:      2012-05-14 17:32 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3a22b77e755a

7161545: G1: Minor cleanups to the G1 logging
Summary: Rename "to-space-overflow" to "to-space-exhausted", Introduce one decimal point in the size format, Add Sum to the aggregate and re-order the entries, Add number of GC workers to the log output
Reviewed-by: johnc, jwilhelm

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp
! src/share/vm/utilities/globalDefinitions.hpp

Changeset: 78a1b285cda8
Author:    mikael
Date:      2012-05-15 00:56 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/78a1b285cda8

7158457: division by zero in adaptiveweightedaverage
Summary: Add ceiling to AdaptiveWeightedAverage
Reviewed-by: ysr, iveresov

! src/share/vm/gc_implementation/shared/gcUtil.cpp
! src/share/vm/gc_implementation/shared/gcUtil.hpp

Changeset: 33e366609904
Author:    johnc
Date:      2012-05-14 21:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/33e366609904

Merge


Changeset: 1096fc5a52eb
Author:    johnc
Date:      2012-05-15 09:49 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1096fc5a52eb

7168294: G1: Some Full GCs incorrectly report GC cause as "No GC"
Summary: GC cause was not being set by the VM_G1CollectForAllocation VM operation.
Reviewed-by: jmasa, ysr, brutisso

! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp

Changeset: cdfa5139bd58
Author:    brutisso
Date:      2012-05-15 22:26 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cdfa5139bd58

7169056: Add gigabyte unit to proper_unit_for_byte_size() and byte_size_in_proper_unit()
Reviewed-by: jwilhelm, johnc, dholmes

! src/share/vm/utilities/globalDefinitions.hpp

Changeset: 9d679effd28c
Author:    brutisso
Date:      2012-05-15 10:25 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9d679effd28c

7166894: Add gc cause to GC logging for all collectors
Reviewed-by: mgerdin, johnc

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_interface/gcCause.hpp
! src/share/vm/memory/defNewGeneration.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genMarkSweep.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/java.hpp

Changeset: cdeda3fd141e
Author:    jcoomes
Date:      2012-05-18 10:27 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cdeda3fd141e

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: 14b0e07ab9a6
Author:    amurillo
Date:      2012-05-18 14:50 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/14b0e07ab9a6

Merge


Changeset: ff9decc8235d
Author:    amurillo
Date:      2012-05-18 14:50 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ff9decc8235d

Added tag hs24-b11 for changeset 14b0e07ab9a6

! .hgtags

Changeset: 48064e53e997
Author:    katleman
Date:      2012-05-24 16:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/48064e53e997

Added tag jdk8-b40 for changeset ff9decc8235d

! .hgtags



From lana.steuck at oracle.com  Fri May 25 14:35:22 2012
From: lana.steuck at oracle.com (lana.steuck at oracle.com)
Date: Fri, 25 May 2012 21:35:22 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 49 new changesets
Message-ID: <20120525214349.2EC2C4752C@hg.openjdk.java.net>

Changeset: b5726775b0d8
Author:    katleman
Date:      2012-05-10 10:25 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b5726775b0d8

Added tag jdk8-b38 for changeset c45f3509a707

! .hgtags

Changeset: c2d9166f3284
Author:    ihse
Date:      2012-05-11 08:21 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c2d9166f3284

7168208: Change use of @ in one sed command involving paths to different character
Reviewed-by: ohair

! make/common/Release.gmk

Changeset: 8d665b69ebf1
Author:    mfang
Date:      2012-05-15 11:46 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8d665b69ebf1

7157855: jvisualvm.1 not included in binaries
Reviewed-by: katleman, thurka

! make/common/Release.gmk

Changeset: b6f529117521
Author:    katleman
Date:      2012-05-16 22:07 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b6f529117521

Merge


Changeset: 47cd90bf0f66
Author:    katleman
Date:      2012-05-17 06:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/47cd90bf0f66

Added tag jdk8-b39 for changeset b6f529117521

! .hgtags

Changeset: 7c4eed4b6c19
Author:    bae
Date:      2012-05-21 14:04 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7c4eed4b6c19

7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to member (does not copy configs)
Reviewed-by: anthony, kizune

! src/macosx/classes/sun/awt/CGraphicsDevice.java
! test/java/awt/GraphicsDevice/CloneConfigsTest.java

Changeset: 416b3a498e71
Author:    bae
Date:      2012-05-21 14:53 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/416b3a498e71

7154088: [macosx] Regression: Component.createImage do not inherits component attributes
Reviewed-by: art, kizune

! src/macosx/classes/sun/lwawt/LWComponentPeer.java

Changeset: 1b90a0113359
Author:    lana
Date:      2012-05-21 11:20 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1b90a0113359

Merge


Changeset: 5b2095d7a60b
Author:    lana
Date:      2012-05-21 11:41 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5b2095d7a60b

Merge

! src/macosx/classes/sun/lwawt/LWComponentPeer.java

Changeset: bb2cefc89bc0
Author:    forax
Date:      2012-05-02 20:01 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bb2cefc89bc0

7165102: Only run assertion on Integer autoboxing cache size once
Reviewed-by: darcy, alanb

! src/share/classes/java/lang/Integer.java

Changeset: 531ebfd8eb65
Author:    jgish
Date:      2012-05-02 21:46 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/531ebfd8eb65

7160714: Strange or obsolete @see tags in some exception java.util javadoc
Reviewed-by: mduigou, dholmes, alanb

! src/share/classes/java/util/NoSuchElementException.java

Changeset: 4580652d9828
Author:    lancea
Date:      2012-05-04 16:00 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4580652d9828

7166598: FilteredRowSetImpl can result in Invalid Cursor Position
Reviewed-by: lancea
Contributed-by: Knut Anders Hatlen <knut.hatlen at oracle.com>

! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java

Changeset: 41d3f7509e00
Author:    xuelei
Date:      2012-05-04 17:28 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/41d3f7509e00

7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites
Reviewed-by: weijun

! src/share/classes/sun/security/ssl/SSLContextImpl.java

Changeset: 62557a1336c0
Author:    zhouyx
Date:      2012-05-07 16:43 +0800
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/62557a1336c0

7166048: Remove the embeded epoll data structure.
Reviewed-by: alanb

! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c

Changeset: b26c04717735
Author:    robm
Date:      2012-05-07 13:34 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b26c04717735

7166687: InetAddress.getLocalHost().getHostName() returns FQDN
Reviewed-by: chegar

! src/solaris/native/java/net/Inet6AddressImpl.c

Changeset: 48513d156965
Author:    dholmes
Date:      2012-05-08 02:59 -0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/48513d156965

7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is installed
Summary: Perform class.getField inside a doPrivileged block
Reviewed-by: chegar, psandoz

! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java
+ test/java/util/concurrent/atomic/AtomicUpdaters.java

Changeset: af209a223b6b
Author:    sherman
Date:      2012-05-08 10:57 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/af209a223b6b

7014640: To add a metachar \R for line ending and character classes for vertical/horizontal ws \v \V \h \H
Summary: added propsoed constructs
Reviewed-by: alanb

! src/share/classes/java/util/regex/Pattern.java
! test/java/util/regex/RegExTest.java

Changeset: 1ece20885be4
Author:    sherman
Date:      2012-05-08 11:16 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1ece20885be4

7157656: (zipfs) SeekableByteChannel to entry in zip file always reports its position as 0
Summary: updated SeekableByteChannel.read() to count the bytes read correctly
Reviewed-by: sherman
Contributed-by: paul.sandoz at oracle.com

! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java
! test/demo/zipfs/ZipFSTester.java
! test/demo/zipfs/basic.sh

Changeset: fbf98cbd2e6b
Author:    xuelei
Date:      2012-05-08 17:56 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fbf98cbd2e6b

7167092: Need to put the return clause in the synchronized block
Summary: a regression fix for bug 7153184
Reviewed-by: wetmore

! src/share/classes/sun/security/ssl/SSLContextImpl.java

Changeset: 0f63f3390ac9
Author:    xuelei
Date:      2012-05-08 18:08 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0f63f3390ac9

7166570: JSSE certificate validation has started to fail for certificate chains
Reviewed-by: wetmore

! src/share/classes/sun/security/validator/SimpleValidator.java
+ test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/BasicConstraints.java

Changeset: abb63b7357a1
Author:    luchsh
Date:      2012-05-09 11:19 +0800
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/abb63b7357a1

7165722: Invalid path in MemoryMonitor demo's README.txt
Reviewed-by: alanb, sla

! src/share/demo/management/MemoryMonitor/README.txt

Changeset: 5e8caf6984f5
Author:    ksrini
Date:      2012-05-09 07:28 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5e8caf6984f5

7166955: (pack200) JNI_GetCreatedJavaVMs needs additional checking
Reviewed-by: alanb, dholmes, ksrini
Contributed-by: youdwei at linux.vnet.ibm.com

! src/share/native/com/sun/java/util/jar/pack/jni.cpp

Changeset: 59121a4c71c6
Author:    khazra
Date:      2012-05-09 11:14 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/59121a4c71c6

7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE
Summary: Insert null argument check in AbstractPreferences.remove()
Reviewed-by: dholmes, chegar, alanb

! src/share/classes/java/util/prefs/AbstractPreferences.java
! test/java/util/prefs/RemoveNullKeyCheck.java

Changeset: 6438f1277df6
Author:    wetmore
Date:      2012-05-09 16:33 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6438f1277df6

7167362: SecureRandom.init should be converted, amendment to 7084245
Reviewed-by: sherman

! src/share/classes/sun/security/provider/SecureRandom.java

Changeset: 5152c832745a
Author:    khazra
Date:      2012-05-09 16:55 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5152c832745a

7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking
Summary: Set localAddress only when connection is established
Reviewed-by: alanb

! src/share/classes/sun/nio/ch/SocketChannelImpl.java

Changeset: fdf5e15293e6
Author:    coffeys
Date:      2012-05-10 10:45 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fdf5e15293e6

7163470: Build fails if javax.crypto src files not present
Reviewed-by: valeriep

! make/com/oracle/security/ucrypto/Makefile
! make/common/shared/Defs-java.gmk
! make/sun/security/ec/Makefile
! make/sun/security/mscapi/Makefile
! make/sun/security/pkcs11/Makefile
! makefiles/com/oracle/security/ucrypto/Makefile
! makefiles/common/shared/Defs-java.gmk
! makefiles/sun/security/ec/Makefile
! makefiles/sun/security/mscapi/Makefile
! makefiles/sun/security/pkcs11/Makefile

Changeset: 3e3017eba8ac
Author:    valeriep
Date:      2012-05-08 17:57 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3e3017eba8ac

4963723: Implement SHA-224
Summary: Add support for SHA-224, SHA224withRSA, SHA224withECDSA, HmacSHA224 and OAEPwithSHA-224AndMGF1Padding.
Reviewed-by: vinnie

! src/share/classes/com/sun/crypto/provider/HmacCore.java
! src/share/classes/com/sun/crypto/provider/HmacMD5.java
! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java
! src/share/classes/com/sun/crypto/provider/HmacSHA1.java
! src/share/classes/com/sun/crypto/provider/KeyGeneratorCore.java
! src/share/classes/com/sun/crypto/provider/OAEPParameters.java
! src/share/classes/com/sun/crypto/provider/SunJCE.java
! src/share/classes/java/security/spec/MGF1ParameterSpec.java
! src/share/classes/java/security/spec/PSSParameterSpec.java
! src/share/classes/sun/security/ec/ECDSASignature.java
! src/share/classes/sun/security/ec/SunECEntries.java
! src/share/classes/sun/security/pkcs11/P11Digest.java
! src/share/classes/sun/security/pkcs11/P11Mac.java
! src/share/classes/sun/security/pkcs11/P11Signature.java
! src/share/classes/sun/security/pkcs11/SunPKCS11.java
! src/share/classes/sun/security/pkcs11/wrapper/Functions.java
! src/share/classes/sun/security/provider/DigestBase.java
! src/share/classes/sun/security/provider/MD2.java
! src/share/classes/sun/security/provider/MD4.java
! src/share/classes/sun/security/provider/MD5.java
! src/share/classes/sun/security/provider/SHA.java
! src/share/classes/sun/security/provider/SHA2.java
! src/share/classes/sun/security/provider/SHA5.java
! src/share/classes/sun/security/provider/SunEntries.java
! src/share/classes/sun/security/rsa/RSASignature.java
! src/share/classes/sun/security/rsa/SunRsaSignEntries.java
! src/share/classes/sun/security/x509/AlgorithmId.java
! src/windows/classes/sun/security/mscapi/RSASignature.java
! src/windows/classes/sun/security/mscapi/SunMSCAPI.java
! test/com/sun/crypto/provider/Cipher/RSA/TestOAEP.java
! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPParameterSpec.java
! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPWithParams.java
! test/com/sun/crypto/provider/KeyGenerator/Test4628062.java
! test/com/sun/crypto/provider/Mac/MacClone.java
! test/com/sun/crypto/provider/Mac/MacKAT.java
! test/sun/security/mscapi/SignUsingNONEwithRSA.java
! test/sun/security/mscapi/SignUsingSHA2withRSA.java
! test/sun/security/pkcs11/MessageDigest/DigestKAT.java
! test/sun/security/pkcs11/MessageDigest/TestCloning.java
! test/sun/security/pkcs11/Signature/TestRSAKeyLength.java
! test/sun/security/pkcs11/ec/TestCurves.java
! test/sun/security/pkcs11/rsa/TestKeyPairGenerator.java
! test/sun/security/pkcs11/rsa/TestSignatures.java
! test/sun/security/provider/MessageDigest/DigestKAT.java
! test/sun/security/provider/MessageDigest/Offsets.java
! test/sun/security/provider/MessageDigest/TestSHAClone.java
! test/sun/security/rsa/TestKeyPairGenerator.java
! test/sun/security/rsa/TestSignatures.java

Changeset: dfce31760a2f
Author:    valeriep
Date:      2012-05-08 18:57 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/dfce31760a2f

Merge


Changeset: 9f8210f23773
Author:    valeriep
Date:      2012-05-10 11:19 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9f8210f23773

Merge


Changeset: c5a07e3dca63
Author:    youdwei
Date:      2012-05-11 16:20 +0800
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c5a07e3dca63

7163874: InetAddress.isReachable should support pinging 0.0.0.0
Reviewed-by: alanb, chegar

! src/share/native/java/net/net_util.h
! src/solaris/native/java/net/Inet4AddressImpl.c
! src/solaris/native/java/net/Inet6AddressImpl.c
! src/solaris/native/java/net/net_util_md.c
+ test/java/net/Inet4Address/PingThis.java

Changeset: 3e83229a3779
Author:    coffeys
Date:      2012-05-11 10:09 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3e83229a3779

7167359: (tz) SEGV on solaris if TZ variable not set
Reviewed-by: okutsu

! src/solaris/native/java/util/TimeZone_md.c

Changeset: 944676ef3c58
Author:    mduigou
Date:      2012-05-11 11:31 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/944676ef3c58

7071826: Avoid benign race condition in initialization of UUID
Summary: Avoids mostly benign but sometimes expensive race condition on initialization of UUID.numberGenerator which is used by UUID.randomUUID()
Reviewed-by: alanb, chegar

! src/share/classes/java/util/UUID.java
! test/java/util/UUID/UUIDTest.java

Changeset: 85d7677a75bf
Author:    lana
Date:      2012-05-11 12:53 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/85d7677a75bf

Merge


Changeset: f131d4361faf
Author:    olagneau
Date:      2012-05-11 14:13 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f131d4361faf

7144861: speed up RMI activation tests
Reviewed-by: alanb, smarks, dholmes, dmocek

! test/java/rmi/activation/checkusage/CheckUsage.java
! test/java/rmi/testlibrary/ActivationLibrary.java
! test/java/rmi/testlibrary/JavaVM.java
! test/java/rmi/testlibrary/RMID.java
! test/java/rmi/testlibrary/StreamPipe.java
! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java

Changeset: df3152beef2f
Author:    xuelei
Date:      2012-05-14 07:26 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/df3152beef2f

7167988: PKIX CertPathBuilder in reverse mode doesn't work if more than one trust anchor is specified
Reviewed-by: mullan

! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java
+ test/sun/security/provider/certpath/ReverseBuilder/ReverseBuild.java

Changeset: df33f5f750ec
Author:    dsamersoff
Date:      2012-05-15 16:46 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/df33f5f750ec

7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario
Reviewed-by: dholmes, sla
Contributed-by: Deven You <youdwei at linux.vnet.ibm.com>

! src/share/classes/sun/management/Agent.java
+ test/sun/management/AgentCMETest.java

Changeset: 9a18e318f95a
Author:    khazra
Date:      2012-05-15 11:51 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9a18e318f95a

7164636: (prefs) Cleanup src/macosx/classes/java/util/prefs
Summary: Remove rawtype usages and other code cleanup
Reviewed-by: chegar, briangoetz

! src/macosx/classes/java/util/prefs/MacOSXPreferences.java
! src/macosx/classes/java/util/prefs/MacOSXPreferencesFactory.java
! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java

Changeset: 332bebb463d1
Author:    alanb
Date:      2012-05-16 12:43 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/332bebb463d1

7168505: (bf) MappedByteBuffer.load does not load buffer's content into memory
Reviewed-by: mduigou, forax

! src/share/classes/java/nio/MappedByteBuffer.java

Changeset: ce165aa48dcb
Author:    dcubed
Date:      2012-05-17 06:26 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ce165aa48dcb

7168520: No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231
Summary: ZIP libjsig.debuginfo links into libjsig.diz files since aurora doesn't like dangling symlinks
Reviewed-by: katleman

! make/java/redist/Makefile

Changeset: 178c480998b1
Author:    robm
Date:      2012-05-17 22:42 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/178c480998b1

7168110: Misleading jstack error message
Reviewed-by: alanb, dsamersoff

! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c

Changeset: 9fe6ebbe5895
Author:    xuelei
Date:      2012-05-17 21:59 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9fe6ebbe5895

7145960: sun/security/mscapi/ShortRSAKey1024.sh failing on windows
Reviewed-by: vinnie, wetmore

! test/sun/security/mscapi/ShortRSAKey1024.sh
! test/sun/security/mscapi/ShortRSAKey512.sh
! test/sun/security/mscapi/ShortRSAKey768.sh

Changeset: af1030be726a
Author:    valeriep
Date:      2012-05-18 12:29 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/af1030be726a

7169496: Problem with the SHA-224 support for SunMSCAPI provider
Summary: Remove SHA224withRSA signature from SunMSCAPI provider due to lack of windows support.
Reviewed-by: vinnie

! src/windows/classes/sun/security/mscapi/RSASignature.java
! src/windows/classes/sun/security/mscapi/SunMSCAPI.java
! test/sun/security/mscapi/SignUsingNONEwithRSA.java
! test/sun/security/mscapi/SignUsingSHA2withRSA.java

Changeset: 72af24348b2b
Author:    weijun
Date:      2012-05-21 15:40 +0800
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/72af24348b2b

7170308: timing error in the krb5 test SSL.java
Reviewed-by: xuelei

! test/sun/security/krb5/auto/SSL.java

Changeset: 9cb304dd71d4
Author:    alanb
Date:      2012-05-21 10:41 +0100
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9cb304dd71d4

7170203: TEST_BUG: test/java/nio/MappedByteBuffer/Truncate.java failing intermittently
Reviewed-by: chegar

! test/java/nio/MappedByteBuffer/Truncate.java

Changeset: f109feb13698
Author:    ksrini
Date:      2012-05-21 09:40 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f109feb13698

7170087: tools/launcher/Arrghs.java test has wrong bugID for 7151434
Reviewed-by: ohair

! test/tools/launcher/Arrrghs.java

Changeset: 0a1ef7e07e01
Author:    sla
Date:      2012-05-21 19:28 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0a1ef7e07e01

7167157: jcmd command file parsing does not respect the "stop" command
Reviewed-by: alanb, dsamersoff, nloodin

! src/share/classes/sun/tools/jcmd/JCmd.java

Changeset: b88fc3359dc7
Author:    lana
Date:      2012-05-21 11:44 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b88fc3359dc7

Merge


Changeset: 7def50698e78
Author:    katleman
Date:      2012-05-24 16:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7def50698e78

Added tag jdk8-b40 for changeset b88fc3359dc7

! .hgtags

Changeset: bcdb6e5f31cc
Author:    lana
Date:      2012-05-25 13:39 -0700
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bcdb6e5f31cc

Merge




From david.holmes at oracle.com  Sun May 27 18:10:56 2012
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 28 May 2012 11:10:56 +1000
Subject: <AWT Dev> RFR: 7171653 32-bit cross-compile on 64-bit build
 host generates 64-bit data for awt/X11 leading to crash
In-Reply-To: <4FBF2499.1040304@oracle.com>
References: <4FBF2499.1040304@oracle.com>
Message-ID: <4FC2D0A0.3040005@oracle.com>

I have a review from AWT (thanks Anthony), can I have one from build please.

Any preference as to where to push this?

Thanks,
David

On 25/05/2012 4:20 PM, David Holmes wrote:
> This is a tweak to the cross-compilation rules in sun/xawt/Makefile to
> force correct compilation of the sizers utility.
>
> http://cr.openjdk.java.net/~dholmes/7171653/webrev/
>
> webrev is against tl/jdk but I can use a different repo if you prefer.
>
> Now that we use CFLAGS_32/64 in the cross compilation case we no longer
> need different cc commands, other than the actual choice of compiler.
>
> Longer term 7153072 will make this fix obsolete but for now we need this
> for our new build servers, and I wanted to make sure this only affected
> cross-compilation.
>
> Same change will need to go to the 7u train as well.
>
> Thanks,
> David


From luchsh at linux.vnet.ibm.com  Sun May 27 22:17:41 2012
From: luchsh at linux.vnet.ibm.com (Jonathan Lu)
Date: Mon, 28 May 2012 13:17:41 +0800
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FBFDE5E.1050400@oracle.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
	<4FBCB8C4.6060205@linux.vnet.ibm.com> <4FBCD93D.2070202@oracle.com>
	<4FBDE860.2060203@linux.vnet.ibm.com> <4FBFDE5E.1050400@oracle.com>
Message-ID: <4FC30A75.8000009@linux.vnet.ibm.com>

Hello Sergey,

On 05/26/2012 03:32 AM, Sergey Bylokhov wrote:
> Hi, Jonathan.
> Fix looks good to me. Just note that one more reviewer needed.

Thanks for review.

Can anybody please help to take another look?

>
> Thanks for the fix.

Best regards!
- Jonathan
> 24.05.2012 11:50, Jonathan Lu wrote:
>> Hello Sergey,
>>
>> I made one automatic jtreg test case and put it to following link 
>> along with the patch.
>> http://cr.openjdk.java.net/~luchsh/7170655_3/
>>
>> Could you please take a look?
>>
>> Thanks!
>> - Jonathan
>>
>> On 05/23/2012 08:34 PM, Sergey Bylokhov wrote:
>>> Hi, Jonathan,
>>> Fix looks good. But I guess this bug was not caught by the 
>>> regression tests, so new test should be added(automatic test is 
>>> better).
>>>
>>> 23.05.2012 14:15, Jonathan Lu wrote:
>>>> Hi Sergey,
>>>>
>>>> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>>>>> Hi, Jonathan,
>>>>> Looks like this bug is duplicate of 
>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>>>>> And the reason of the issue is that we post UpdateEvent in 
>>>>> target.repaint() in XLabelPeer.setFont(), but we should paint 
>>>>> native part of the component in place[1] and then post PaintEvent[2].
>>>>>
>>>>>  - To fix [1] we can replace target.repaint() to repaint() in 
>>>>> setFont(). Does it solve your issue?
>>>>
>>>> Yes, this resolves my problem, and here's the updated patch from 
>>>> your suggestion,
>>>> http://cr.openjdk.java.net/~luchsh/7170655_2/
>>>>
>>>> Thanks a lot!
>>>> - Jonathan
>>>>
>>>>>
>>>>> 22.05.2012 11:47, Jonathan Lu wrote:
>>>>>> Hi awt-dev,
>>>>>>
>>>>>> Here's a patch for bug 7170655, could anybody please help to take 
>>>>>> a look?
>>>>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>>>>
>>>>>> The problem is that painting event from EDT during painting 
>>>>>> handling does not get processed immediately, so leave a lag to 
>>>>>> the user. My solution here is to coalesce and dispatch the new 
>>>>>> paint event right after it was posted. This happens only to AWT 
>>>>>> components.
>>>>>>
>>>>>> Thanks!
>>>>>> -Jonathan
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>



From artem.ananiev at oracle.com  Mon May 28 05:46:29 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Mon, 28 May 2012 16:46:29 +0400
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
 defaults to Generic Java Application Category
In-Reply-To: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
References: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
Message-ID: <4FC373A5.9030508@oracle.com>

Hi, Leonid,

the fix looks fine. Is the application name issue (also mentioned in 
7159381) addressed in another fix?

Thanks,

Artem

On 5/24/2012 5:23 PM, Leonid Romanov wrote:
> Hi,
> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
>
> Thanks,
> Leonid.
>


From artem.ananiev at oracle.com  Mon May 28 06:12:01 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Mon, 28 May 2012 17:12:01 +0400
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FC30A75.8000009@linux.vnet.ibm.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
	<4FBCB8C4.6060205@linux.vnet.ibm.com> <4FBCD93D.2070202@oracle.com>
	<4FBDE860.2060203@linux.vnet.ibm.com> <4FBFDE5E.1050400@oracle.com>
	<4FC30A75.8000009@linux.vnet.ibm.com>
Message-ID: <4FC379A1.9000604@oracle.com>

Hi, Jonathan,

the fix looks fine.

The test requires some corrections, though:

1. "@bug 7150655" should be replaced with "@bug 7170655".

2. Most of the tests in test/java/awt/ have some "meaningful" names, 
e.g. LabelFontToAffectFrameSize, so every developer can easily 
understand what a test is about.

3. Instead of Thread.sleep() calls, I would recommend to use the 
test.java.awt.regtesthelpers.Util class. An example can be found here:

test/java/awt/Window/WindowType/WindowType.java

Thanks,

Artem

On 5/28/2012 9:17 AM, Jonathan Lu wrote:
> Hello Sergey,
>
> On 05/26/2012 03:32 AM, Sergey Bylokhov wrote:
>> Hi, Jonathan.
>> Fix looks good to me. Just note that one more reviewer needed.
>
> Thanks for review.
>
> Can anybody please help to take another look?
>
>>
>> Thanks for the fix.
>
> Best regards!
> - Jonathan
>> 24.05.2012 11:50, Jonathan Lu wrote:
>>> Hello Sergey,
>>>
>>> I made one automatic jtreg test case and put it to following link
>>> along with the patch.
>>> http://cr.openjdk.java.net/~luchsh/7170655_3/
>>>
>>> Could you please take a look?
>>>
>>> Thanks!
>>> - Jonathan
>>>
>>> On 05/23/2012 08:34 PM, Sergey Bylokhov wrote:
>>>> Hi, Jonathan,
>>>> Fix looks good. But I guess this bug was not caught by the
>>>> regression tests, so new test should be added(automatic test is
>>>> better).
>>>>
>>>> 23.05.2012 14:15, Jonathan Lu wrote:
>>>>> Hi Sergey,
>>>>>
>>>>> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>>>>>> Hi, Jonathan,
>>>>>> Looks like this bug is duplicate of
>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>>>>>> And the reason of the issue is that we post UpdateEvent in
>>>>>> target.repaint() in XLabelPeer.setFont(), but we should paint
>>>>>> native part of the component in place[1] and then post PaintEvent[2].
>>>>>>
>>>>>> - To fix [1] we can replace target.repaint() to repaint() in
>>>>>> setFont(). Does it solve your issue?
>>>>>
>>>>> Yes, this resolves my problem, and here's the updated patch from
>>>>> your suggestion,
>>>>> http://cr.openjdk.java.net/~luchsh/7170655_2/
>>>>>
>>>>> Thanks a lot!
>>>>> - Jonathan
>>>>>
>>>>>>
>>>>>> 22.05.2012 11:47, Jonathan Lu wrote:
>>>>>>> Hi awt-dev,
>>>>>>>
>>>>>>> Here's a patch for bug 7170655, could anybody please help to take
>>>>>>> a look?
>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>>>>>
>>>>>>> The problem is that painting event from EDT during painting
>>>>>>> handling does not get processed immediately, so leave a lag to
>>>>>>> the user. My solution here is to coalesce and dispatch the new
>>>>>>> paint event right after it was posted. This happens only to AWT
>>>>>>> components.
>>>>>>>
>>>>>>> Thanks!
>>>>>>> -Jonathan
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


From leonid.romanov at oracle.com  Mon May 28 07:06:38 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Mon, 28 May 2012 18:06:38 +0400
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
	defaults to Generic Java Application Category
In-Reply-To: <4FC373A5.9030508@oracle.com>
References: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
	<4FC373A5.9030508@oracle.com>
Message-ID: <89803632-78F2-410F-B66B-09AEFC8CAB11@oracle.com>

Hi,
The problem with the application name is that the app in question uses "com.apple.mrj.application.apple.menu.about.name" property to set its name. Mu understanding is that we don't support this property in OpenJDK.

On 28.05.2012, at 16:46, Artem Ananiev wrote:

> Hi, Leonid,
> 
> the fix looks fine. Is the application name issue (also mentioned in 7159381) addressed in another fix?
> 
> Thanks,
> 
> Artem
> 
> On 5/24/2012 5:23 PM, Leonid Romanov wrote:
>> Hi,
>> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything.
>> 
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
>> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
>> 
>> Thanks,
>> Leonid.
>> 



From artem.ananiev at oracle.com  Mon May 28 08:35:11 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Mon, 28 May 2012 19:35:11 +0400
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
 defaults to Generic Java Application Category
In-Reply-To: <89803632-78F2-410F-B66B-09AEFC8CAB11@oracle.com>
References: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
	<4FC373A5.9030508@oracle.com>
	<89803632-78F2-410F-B66B-09AEFC8CAB11@oracle.com>
Message-ID: <4FC39B2F.6070805@oracle.com>


On 5/28/2012 6:06 PM, Leonid Romanov wrote:
> Hi,
> The problem with the application name is that the app in question uses "com.apple.mrj.application.apple.menu.about.name" property to set its name. Mu understanding is that we don't support this property in OpenJDK.

OK, fine. Is the application name set correctly when it is passed from 
app bundle or as -Xdock:name?

Thanks,

Artem

> On 28.05.2012, at 16:46, Artem Ananiev wrote:
>
>> Hi, Leonid,
>>
>> the fix looks fine. Is the application name issue (also mentioned in 7159381) addressed in another fix?
>>
>> Thanks,
>>
>> Artem
>>
>> On 5/24/2012 5:23 PM, Leonid Romanov wrote:
>>> Hi,
>>> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything.
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
>>> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
>>>
>>> Thanks,
>>> Leonid.
>>>
>


From luchsh at linux.vnet.ibm.com  Mon May 28 22:23:58 2012
From: luchsh at linux.vnet.ibm.com (Jonathan Lu)
Date: Tue, 29 May 2012 13:23:58 +0800
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FC379A1.9000604@oracle.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
	<4FBCB8C4.6060205@linux.vnet.ibm.com> <4FBCD93D.2070202@oracle.com>
	<4FBDE860.2060203@linux.vnet.ibm.com> <4FBFDE5E.1050400@oracle.com>
	<4FC30A75.8000009@linux.vnet.ibm.com> <4FC379A1.9000604@oracle.com>
Message-ID: <4FC45D6E.9060500@linux.vnet.ibm.com>

Hi Artem,

Thanks for review!

On 05/28/2012 09:12 PM, Artem Ananiev wrote:
> Hi, Jonathan,
>
> the fix looks fine.
>
> The test requires some corrections, though:
>
> 1. "@bug 7150655" should be replaced with "@bug 7170655".
Sorry for the typo.
>
> 2. Most of the tests in test/java/awt/ have some "meaningful" names, 
> e.g. LabelFontToAffectFrameSize, so every developer can easily 
> understand what a test is about.
>
In the new patch, I've renamed it to "ResizeAfterSetFont".

> 3. Instead of Thread.sleep() calls, I would recommend to use the 
> test.java.awt.regtesthelpers.Util class. An example can be found here:
>
> test/java/awt/Window/WindowType/WindowType.java

Thanks for the reference, I've updated it in the new patch, see

http://cr.openjdk.java.net/~luchsh/7170655_4/

Best regards!
- Jonathan

>
> Thanks,
>
> Artem
>
> On 5/28/2012 9:17 AM, Jonathan Lu wrote:
>> Hello Sergey,
>>
>> On 05/26/2012 03:32 AM, Sergey Bylokhov wrote:
>>> Hi, Jonathan.
>>> Fix looks good to me. Just note that one more reviewer needed.
>>
>> Thanks for review.
>>
>> Can anybody please help to take another look?
>>
>>>
>>> Thanks for the fix.
>>
>> Best regards!
>> - Jonathan
>>> 24.05.2012 11:50, Jonathan Lu wrote:
>>>> Hello Sergey,
>>>>
>>>> I made one automatic jtreg test case and put it to following link
>>>> along with the patch.
>>>> http://cr.openjdk.java.net/~luchsh/7170655_3/
>>>>
>>>> Could you please take a look?
>>>>
>>>> Thanks!
>>>> - Jonathan
>>>>
>>>> On 05/23/2012 08:34 PM, Sergey Bylokhov wrote:
>>>>> Hi, Jonathan,
>>>>> Fix looks good. But I guess this bug was not caught by the
>>>>> regression tests, so new test should be added(automatic test is
>>>>> better).
>>>>>
>>>>> 23.05.2012 14:15, Jonathan Lu wrote:
>>>>>> Hi Sergey,
>>>>>>
>>>>>> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>>>>>>> Hi, Jonathan,
>>>>>>> Looks like this bug is duplicate of
>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>>>>>>> And the reason of the issue is that we post UpdateEvent in
>>>>>>> target.repaint() in XLabelPeer.setFont(), but we should paint
>>>>>>> native part of the component in place[1] and then post 
>>>>>>> PaintEvent[2].
>>>>>>>
>>>>>>> - To fix [1] we can replace target.repaint() to repaint() in
>>>>>>> setFont(). Does it solve your issue?
>>>>>>
>>>>>> Yes, this resolves my problem, and here's the updated patch from
>>>>>> your suggestion,
>>>>>> http://cr.openjdk.java.net/~luchsh/7170655_2/
>>>>>>
>>>>>> Thanks a lot!
>>>>>> - Jonathan
>>>>>>
>>>>>>>
>>>>>>> 22.05.2012 11:47, Jonathan Lu wrote:
>>>>>>>> Hi awt-dev,
>>>>>>>>
>>>>>>>> Here's a patch for bug 7170655, could anybody please help to take
>>>>>>>> a look?
>>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>>>>>>
>>>>>>>> The problem is that painting event from EDT during painting
>>>>>>>> handling does not get processed immediately, so leave a lag to
>>>>>>>> the user. My solution here is to coalesce and dispatch the new
>>>>>>>> paint event right after it was posted. This happens only to AWT
>>>>>>>> components.
>>>>>>>>
>>>>>>>> Thanks!
>>>>>>>> -Jonathan
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>



From artem.ananiev at oracle.com  Tue May 29 08:10:02 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Tue, 29 May 2012 19:10:02 +0400
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FC45D6E.9060500@linux.vnet.ibm.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
	<4FBCB8C4.6060205@linux.vnet.ibm.com> <4FBCD93D.2070202@oracle.com>
	<4FBDE860.2060203@linux.vnet.ibm.com> <4FBFDE5E.1050400@oracle.com>
	<4FC30A75.8000009@linux.vnet.ibm.com> <4FC379A1.9000604@oracle.com>
	<4FC45D6E.9060500@linux.vnet.ibm.com>
Message-ID: <4FC4E6CA.1050100@oracle.com>


Thanks, Jonathan, the fix now looks perfect :)

Artem

On 5/29/2012 9:23 AM, Jonathan Lu wrote:
> Hi Artem,
>
> Thanks for review!
>
> On 05/28/2012 09:12 PM, Artem Ananiev wrote:
>> Hi, Jonathan,
>>
>> the fix looks fine.
>>
>> The test requires some corrections, though:
>>
>> 1. "@bug 7150655" should be replaced with "@bug 7170655".
> Sorry for the typo.
>>
>> 2. Most of the tests in test/java/awt/ have some "meaningful" names,
>> e.g. LabelFontToAffectFrameSize, so every developer can easily
>> understand what a test is about.
>>
> In the new patch, I've renamed it to "ResizeAfterSetFont".
>
>> 3. Instead of Thread.sleep() calls, I would recommend to use the
>> test.java.awt.regtesthelpers.Util class. An example can be found here:
>>
>> test/java/awt/Window/WindowType/WindowType.java
>
> Thanks for the reference, I've updated it in the new patch, see
>
> http://cr.openjdk.java.net/~luchsh/7170655_4/
>
> Best regards!
> - Jonathan
>
>>
>> Thanks,
>>
>> Artem
>>
>> On 5/28/2012 9:17 AM, Jonathan Lu wrote:
>>> Hello Sergey,
>>>
>>> On 05/26/2012 03:32 AM, Sergey Bylokhov wrote:
>>>> Hi, Jonathan.
>>>> Fix looks good to me. Just note that one more reviewer needed.
>>>
>>> Thanks for review.
>>>
>>> Can anybody please help to take another look?
>>>
>>>>
>>>> Thanks for the fix.
>>>
>>> Best regards!
>>> - Jonathan
>>>> 24.05.2012 11:50, Jonathan Lu wrote:
>>>>> Hello Sergey,
>>>>>
>>>>> I made one automatic jtreg test case and put it to following link
>>>>> along with the patch.
>>>>> http://cr.openjdk.java.net/~luchsh/7170655_3/
>>>>>
>>>>> Could you please take a look?
>>>>>
>>>>> Thanks!
>>>>> - Jonathan
>>>>>
>>>>> On 05/23/2012 08:34 PM, Sergey Bylokhov wrote:
>>>>>> Hi, Jonathan,
>>>>>> Fix looks good. But I guess this bug was not caught by the
>>>>>> regression tests, so new test should be added(automatic test is
>>>>>> better).
>>>>>>
>>>>>> 23.05.2012 14:15, Jonathan Lu wrote:
>>>>>>> Hi Sergey,
>>>>>>>
>>>>>>> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>>>>>>>> Hi, Jonathan,
>>>>>>>> Looks like this bug is duplicate of
>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>>>>>>>> And the reason of the issue is that we post UpdateEvent in
>>>>>>>> target.repaint() in XLabelPeer.setFont(), but we should paint
>>>>>>>> native part of the component in place[1] and then post
>>>>>>>> PaintEvent[2].
>>>>>>>>
>>>>>>>> - To fix [1] we can replace target.repaint() to repaint() in
>>>>>>>> setFont(). Does it solve your issue?
>>>>>>>
>>>>>>> Yes, this resolves my problem, and here's the updated patch from
>>>>>>> your suggestion,
>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655_2/
>>>>>>>
>>>>>>> Thanks a lot!
>>>>>>> - Jonathan
>>>>>>>
>>>>>>>>
>>>>>>>> 22.05.2012 11:47, Jonathan Lu wrote:
>>>>>>>>> Hi awt-dev,
>>>>>>>>>
>>>>>>>>> Here's a patch for bug 7170655, could anybody please help to take
>>>>>>>>> a look?
>>>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>>>>>>>
>>>>>>>>> The problem is that painting event from EDT during painting
>>>>>>>>> handling does not get processed immediately, so leave a lag to
>>>>>>>>> the user. My solution here is to coalesce and dispatch the new
>>>>>>>>> paint event right after it was posted. This happens only to AWT
>>>>>>>>> components.
>>>>>>>>>
>>>>>>>>> Thanks!
>>>>>>>>> -Jonathan
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>


From kelly.ohair at oracle.com  Tue May 29 09:54:00 2012
From: kelly.ohair at oracle.com (Kelly O'Hair)
Date: Tue, 29 May 2012 09:54:00 -0700
Subject: <AWT Dev> RFR: 7171653 32-bit cross-compile on 64-bit build
	host generates 64-bit data for awt/X11 leading to crash
In-Reply-To: <4FC2D0A0.3040005@oracle.com>
References: <4FBF2499.1040304@oracle.com> <4FC2D0A0.3040005@oracle.com>
Message-ID: <BEAD0647-5A6A-4622-9718-8984BB4AB2B9@oracle.com>

Build-dev please.

-kto

On May 27, 2012, at 6:10 PM, David Holmes wrote:

> I have a review from AWT (thanks Anthony), can I have one from build please.
> 
> Any preference as to where to push this?
> 
> Thanks,
> David
> 
> On 25/05/2012 4:20 PM, David Holmes wrote:
>> This is a tweak to the cross-compilation rules in sun/xawt/Makefile to
>> force correct compilation of the sizers utility.
>> 
>> http://cr.openjdk.java.net/~dholmes/7171653/webrev/
>> 
>> webrev is against tl/jdk but I can use a different repo if you prefer.
>> 
>> Now that we use CFLAGS_32/64 in the cross compilation case we no longer
>> need different cc commands, other than the actual choice of compiler.
>> 
>> Longer term 7153072 will make this fix obsolete but for now we need this
>> for our new build servers, and I wanted to make sure this only affected
>> cross-compilation.
>> 
>> Same change will need to go to the 7u train as well.
>> 
>> Thanks,
>> David



From leonid.romanov at oracle.com  Tue May 29 09:59:57 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Tue, 29 May 2012 20:59:57 +0400
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
	defaults to Generic Java Application Category
In-Reply-To: <4FC39B2F.6070805@oracle.com>
References: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
	<4FC373A5.9030508@oracle.com>
	<89803632-78F2-410F-B66B-09AEFC8CAB11@oracle.com>
	<4FC39B2F.6070805@oracle.com>
Message-ID: <32533319-5E00-483F-AE69-6E79419C3757@oracle.com>

Well, the order is the following: first, we check if -Xdock:name has been set. If it hasn't, we check for the "apple.awt.application.name" property. If this property hasn't been set, we try to get the app name from the JAVA_MAIN_CLASS_<pid> environment variable, which is used to pass  the name of a Java class whose main() method was invoked by the Java launcher code to start the application. If JAVA_MAIN_CLASS_<pid> hasn't been set, then as the last resort we try to get the app name from the bundle.

On 28.05.2012, at 19:35, Artem Ananiev wrote:

> 
> On 5/28/2012 6:06 PM, Leonid Romanov wrote:
>> Hi,
>> The problem with the application name is that the app in question uses "com.apple.mrj.application.apple.menu.about.name" property to set its name. Mu understanding is that we don't support this property in OpenJDK.
> 
> OK, fine. Is the application name set correctly when it is passed from app bundle or as -Xdock:name?
> 
> Thanks,
> 
> Artem
> 
>> On 28.05.2012, at 16:46, Artem Ananiev wrote:
>> 
>>> Hi, Leonid,
>>> 
>>> the fix looks fine. Is the application name issue (also mentioned in 7159381) addressed in another fix?
>>> 
>>> Thanks,
>>> 
>>> Artem
>>> 
>>> On 5/24/2012 5:23 PM, Leonid Romanov wrote:
>>>> Hi,
>>>> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything.
>>>> 
>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
>>>> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
>>>> 
>>>> Thanks,
>>>> Leonid.
>>>> 
>> 



From leonid.romanov at oracle.com  Tue May 29 11:41:46 2012
From: leonid.romanov at oracle.com (Leonid Romanov)
Date: Tue, 29 May 2012 22:41:46 +0400
Subject: <AWT Dev> [8] Review request for 7150089: [macosx] Default for a
	custom cursor created from non-existent image is not transparent
Message-ID: <BACCEA75-CBC1-4F6C-A542-1753E1D41A96@oracle.com>

Hi,
Please review a fix for 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent. Exactly the same fix under the same CR has already been pushed into 7u4.

Bug: http://monaco.us.oracle.com/detail.jsf?cr=7150089
Webrev: http://cr.openjdk.java.net/~leonidr/7150089/webrev.00/

Thanks,
Leonid.



From littlee at linux.vnet.ibm.com  Tue May 29 19:58:58 2012
From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com)
Date: Wed, 30 May 2012 02:58:58 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7170655: Frame size does not follow
	font size	change with XToolkit
Message-ID: <20120530025935.9C76D475AD@hg.openjdk.java.net>

Changeset: 3c9adc88956d
Author:    luchsh
Date:      2012-05-30 10:58 +0800
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3c9adc88956d

7170655: Frame size does not follow font size change with XToolkit
Reviewed-by: serb, art

! src/solaris/classes/sun/awt/X11/XLabelPeer.java
+ test/java/awt/Frame/ResizeAfterSetFont/ResizeAfterSetFont.java



From luchsh at linux.vnet.ibm.com  Tue May 29 20:08:41 2012
From: luchsh at linux.vnet.ibm.com (Jonathan Lu)
Date: Wed, 30 May 2012 11:08:41 +0800
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FC4E6CA.1050100@oracle.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com> <4FBBA16E.2070804@oracle.com>
	<4FBCB8C4.6060205@linux.vnet.ibm.com> <4FBCD93D.2070202@oracle.com>
	<4FBDE860.2060203@linux.vnet.ibm.com> <4FBFDE5E.1050400@oracle.com>
	<4FC30A75.8000009@linux.vnet.ibm.com> <4FC379A1.9000604@oracle.com>
	<4FC45D6E.9060500@linux.vnet.ibm.com> <4FC4E6CA.1050100@oracle.com>
Message-ID: <4FC58F39.6020602@linux.vnet.ibm.com>

Hi Artem,

Thanks a lot for review!

Regards
- Jonathan

On 05/29/2012 11:10 PM, Artem Ananiev wrote:
>
> Thanks, Jonathan, the fix now looks perfect :)
>
> Artem
>
> On 5/29/2012 9:23 AM, Jonathan Lu wrote:
>> Hi Artem,
>>
>> Thanks for review!
>>
>> On 05/28/2012 09:12 PM, Artem Ananiev wrote:
>>> Hi, Jonathan,
>>>
>>> the fix looks fine.
>>>
>>> The test requires some corrections, though:
>>>
>>> 1. "@bug 7150655" should be replaced with "@bug 7170655".
>> Sorry for the typo.
>>>
>>> 2. Most of the tests in test/java/awt/ have some "meaningful" names,
>>> e.g. LabelFontToAffectFrameSize, so every developer can easily
>>> understand what a test is about.
>>>
>> In the new patch, I've renamed it to "ResizeAfterSetFont".
>>
>>> 3. Instead of Thread.sleep() calls, I would recommend to use the
>>> test.java.awt.regtesthelpers.Util class. An example can be found here:
>>>
>>> test/java/awt/Window/WindowType/WindowType.java
>>
>> Thanks for the reference, I've updated it in the new patch, see
>>
>> http://cr.openjdk.java.net/~luchsh/7170655_4/
>>
>> Best regards!
>> - Jonathan
>>
>>>
>>> Thanks,
>>>
>>> Artem
>>>
>>> On 5/28/2012 9:17 AM, Jonathan Lu wrote:
>>>> Hello Sergey,
>>>>
>>>> On 05/26/2012 03:32 AM, Sergey Bylokhov wrote:
>>>>> Hi, Jonathan.
>>>>> Fix looks good to me. Just note that one more reviewer needed.
>>>>
>>>> Thanks for review.
>>>>
>>>> Can anybody please help to take another look?
>>>>
>>>>>
>>>>> Thanks for the fix.
>>>>
>>>> Best regards!
>>>> - Jonathan
>>>>> 24.05.2012 11:50, Jonathan Lu wrote:
>>>>>> Hello Sergey,
>>>>>>
>>>>>> I made one automatic jtreg test case and put it to following link
>>>>>> along with the patch.
>>>>>> http://cr.openjdk.java.net/~luchsh/7170655_3/
>>>>>>
>>>>>> Could you please take a look?
>>>>>>
>>>>>> Thanks!
>>>>>> - Jonathan
>>>>>>
>>>>>> On 05/23/2012 08:34 PM, Sergey Bylokhov wrote:
>>>>>>> Hi, Jonathan,
>>>>>>> Fix looks good. But I guess this bug was not caught by the
>>>>>>> regression tests, so new test should be added(automatic test is
>>>>>>> better).
>>>>>>>
>>>>>>> 23.05.2012 14:15, Jonathan Lu wrote:
>>>>>>>> Hi Sergey,
>>>>>>>>
>>>>>>>> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>>>>>>>>> Hi, Jonathan,
>>>>>>>>> Looks like this bug is duplicate of
>>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>>>>>>>>> And the reason of the issue is that we post UpdateEvent in
>>>>>>>>> target.repaint() in XLabelPeer.setFont(), but we should paint
>>>>>>>>> native part of the component in place[1] and then post
>>>>>>>>> PaintEvent[2].
>>>>>>>>>
>>>>>>>>> - To fix [1] we can replace target.repaint() to repaint() in
>>>>>>>>> setFont(). Does it solve your issue?
>>>>>>>>
>>>>>>>> Yes, this resolves my problem, and here's the updated patch from
>>>>>>>> your suggestion,
>>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655_2/
>>>>>>>>
>>>>>>>> Thanks a lot!
>>>>>>>> - Jonathan
>>>>>>>>
>>>>>>>>>
>>>>>>>>> 22.05.2012 11:47, Jonathan Lu wrote:
>>>>>>>>>> Hi awt-dev,
>>>>>>>>>>
>>>>>>>>>> Here's a patch for bug 7170655, could anybody please help to 
>>>>>>>>>> take
>>>>>>>>>> a look?
>>>>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>>>>>>>>
>>>>>>>>>> The problem is that painting event from EDT during painting
>>>>>>>>>> handling does not get processed immediately, so leave a lag to
>>>>>>>>>> the user. My solution here is to coalesce and dispatch the new
>>>>>>>>>> paint event right after it was posted. This happens only to AWT
>>>>>>>>>> components.
>>>>>>>>>>
>>>>>>>>>> Thanks!
>>>>>>>>>> -Jonathan
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>



From littlee at linux.vnet.ibm.com  Tue May 29 20:02:20 2012
From: littlee at linux.vnet.ibm.com (Charles Lee)
Date: Wed, 30 May 2012 11:02:20 +0800
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FC45D6E.9060500@linux.vnet.ibm.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com>
	<4FBBA16E.2070804@oracle.com>	<4FBCB8C4.6060205@linux.vnet.ibm.com>
	<4FBCD93D.2070202@oracle.com>	<4FBDE860.2060203@linux.vnet.ibm.com>
	<4FBFDE5E.1050400@oracle.com>	<4FC30A75.8000009@linux.vnet.ibm.com>
	<4FC379A1.9000604@oracle.com> <4FC45D6E.9060500@linux.vnet.ibm.com>
Message-ID: <4FC58DBC.6070401@linux.vnet.ibm.com>

Hi Jonathan,

The patch is committed @

Changeset: 3c9adc88956d
Author:    luchsh
Date:      2012-05-30 10:58 +0800
URL:http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3c9adc88956d

7170655: Frame size does not follow font size change with XToolkit
Reviewed-by: serb, art

Please verify it and thank you all for reviewing the patch.

On 05/29/2012 01:23 PM, Jonathan Lu wrote:
> Hi Artem,
>
> Thanks for review!
>
> On 05/28/2012 09:12 PM, Artem Ananiev wrote:
>> Hi, Jonathan,
>>
>> the fix looks fine.
>>
>> The test requires some corrections, though:
>>
>> 1. "@bug 7150655" should be replaced with "@bug 7170655".
> Sorry for the typo.
>>
>> 2. Most of the tests in test/java/awt/ have some "meaningful" names, 
>> e.g. LabelFontToAffectFrameSize, so every developer can easily 
>> understand what a test is about.
>>
> In the new patch, I've renamed it to "ResizeAfterSetFont".
>
>> 3. Instead of Thread.sleep() calls, I would recommend to use the 
>> test.java.awt.regtesthelpers.Util class. An example can be found here:
>>
>> test/java/awt/Window/WindowType/WindowType.java
>
> Thanks for the reference, I've updated it in the new patch, see
>
> http://cr.openjdk.java.net/~luchsh/7170655_4/
>
> Best regards!
> - Jonathan
>
>>
>> Thanks,
>>
>> Artem
>>
>> On 5/28/2012 9:17 AM, Jonathan Lu wrote:
>>> Hello Sergey,
>>>
>>> On 05/26/2012 03:32 AM, Sergey Bylokhov wrote:
>>>> Hi, Jonathan.
>>>> Fix looks good to me. Just note that one more reviewer needed.
>>>
>>> Thanks for review.
>>>
>>> Can anybody please help to take another look?
>>>
>>>>
>>>> Thanks for the fix.
>>>
>>> Best regards!
>>> - Jonathan
>>>> 24.05.2012 11:50, Jonathan Lu wrote:
>>>>> Hello Sergey,
>>>>>
>>>>> I made one automatic jtreg test case and put it to following link
>>>>> along with the patch.
>>>>> http://cr.openjdk.java.net/~luchsh/7170655_3/
>>>>>
>>>>> Could you please take a look?
>>>>>
>>>>> Thanks!
>>>>> - Jonathan
>>>>>
>>>>> On 05/23/2012 08:34 PM, Sergey Bylokhov wrote:
>>>>>> Hi, Jonathan,
>>>>>> Fix looks good. But I guess this bug was not caught by the
>>>>>> regression tests, so new test should be added(automatic test is
>>>>>> better).
>>>>>>
>>>>>> 23.05.2012 14:15, Jonathan Lu wrote:
>>>>>>> Hi Sergey,
>>>>>>>
>>>>>>> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>>>>>>>> Hi, Jonathan,
>>>>>>>> Looks like this bug is duplicate of
>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>>>>>>>> And the reason of the issue is that we post UpdateEvent in
>>>>>>>> target.repaint() in XLabelPeer.setFont(), but we should paint
>>>>>>>> native part of the component in place[1] and then post 
>>>>>>>> PaintEvent[2].
>>>>>>>>
>>>>>>>> - To fix [1] we can replace target.repaint() to repaint() in
>>>>>>>> setFont(). Does it solve your issue?
>>>>>>>
>>>>>>> Yes, this resolves my problem, and here's the updated patch from
>>>>>>> your suggestion,
>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655_2/
>>>>>>>
>>>>>>> Thanks a lot!
>>>>>>> - Jonathan
>>>>>>>
>>>>>>>>
>>>>>>>> 22.05.2012 11:47, Jonathan Lu wrote:
>>>>>>>>> Hi awt-dev,
>>>>>>>>>
>>>>>>>>> Here's a patch for bug 7170655, could anybody please help to take
>>>>>>>>> a look?
>>>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>>>>>>>
>>>>>>>>> The problem is that painting event from EDT during painting
>>>>>>>>> handling does not get processed immediately, so leave a lag to
>>>>>>>>> the user. My solution here is to coalesce and dispatch the new
>>>>>>>>> paint event right after it was posted. This happens only to AWT
>>>>>>>>> components.
>>>>>>>>>
>>>>>>>>> Thanks!
>>>>>>>>> -Jonathan
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>


-- 
Yours Charles



From luchsh at linux.vnet.ibm.com  Tue May 29 20:07:39 2012
From: luchsh at linux.vnet.ibm.com (Jonathan Lu)
Date: Wed, 30 May 2012 11:07:39 +0800
Subject: <AWT Dev> Request for Review: 7170655 frame size change does
 not follow label font change
In-Reply-To: <4FC58DBC.6070401@linux.vnet.ibm.com>
References: <4FBB4482.4040201@linux.vnet.ibm.com>
	<4FBBA16E.2070804@oracle.com>	<4FBCB8C4.6060205@linux.vnet.ibm.com>
	<4FBCD93D.2070202@oracle.com>	<4FBDE860.2060203@linux.vnet.ibm.com>
	<4FBFDE5E.1050400@oracle.com>	<4FC30A75.8000009@linux.vnet.ibm.com>
	<4FC379A1.9000604@oracle.com> <4FC45D6E.9060500@linux.vnet.ibm.com>
	<4FC58DBC.6070401@linux.vnet.ibm.com>
Message-ID: <4FC58EFB.9040008@linux.vnet.ibm.com>

Hi Charles,

Verified, thanks!

Regards
- Jonathan

On 05/30/2012 11:02 AM, Charles Lee wrote:
> Hi Jonathan,
>
> The patch is committed @
>
> Changeset: 3c9adc88956d
> Author:    luchsh
> Date:      2012-05-30 10:58 +0800
> URL:http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3c9adc88956d
>
> 7170655: Frame size does not follow font size change with XToolkit
> Reviewed-by: serb, art
>
> Please verify it and thank you all for reviewing the patch.
>
> On 05/29/2012 01:23 PM, Jonathan Lu wrote:
>> Hi Artem,
>>
>> Thanks for review!
>>
>> On 05/28/2012 09:12 PM, Artem Ananiev wrote:
>>> Hi, Jonathan,
>>>
>>> the fix looks fine.
>>>
>>> The test requires some corrections, though:
>>>
>>> 1. "@bug 7150655" should be replaced with "@bug 7170655".
>> Sorry for the typo.
>>>
>>> 2. Most of the tests in test/java/awt/ have some "meaningful" names, 
>>> e.g. LabelFontToAffectFrameSize, so every developer can easily 
>>> understand what a test is about.
>>>
>> In the new patch, I've renamed it to "ResizeAfterSetFont".
>>
>>> 3. Instead of Thread.sleep() calls, I would recommend to use the 
>>> test.java.awt.regtesthelpers.Util class. An example can be found here:
>>>
>>> test/java/awt/Window/WindowType/WindowType.java
>>
>> Thanks for the reference, I've updated it in the new patch, see
>>
>> http://cr.openjdk.java.net/~luchsh/7170655_4/
>>
>> Best regards!
>> - Jonathan
>>
>>>
>>> Thanks,
>>>
>>> Artem
>>>
>>> On 5/28/2012 9:17 AM, Jonathan Lu wrote:
>>>> Hello Sergey,
>>>>
>>>> On 05/26/2012 03:32 AM, Sergey Bylokhov wrote:
>>>>> Hi, Jonathan.
>>>>> Fix looks good to me. Just note that one more reviewer needed.
>>>>
>>>> Thanks for review.
>>>>
>>>> Can anybody please help to take another look?
>>>>
>>>>>
>>>>> Thanks for the fix.
>>>>
>>>> Best regards!
>>>> - Jonathan
>>>>> 24.05.2012 11:50, Jonathan Lu wrote:
>>>>>> Hello Sergey,
>>>>>>
>>>>>> I made one automatic jtreg test case and put it to following link
>>>>>> along with the patch.
>>>>>> http://cr.openjdk.java.net/~luchsh/7170655_3/
>>>>>>
>>>>>> Could you please take a look?
>>>>>>
>>>>>> Thanks!
>>>>>> - Jonathan
>>>>>>
>>>>>> On 05/23/2012 08:34 PM, Sergey Bylokhov wrote:
>>>>>>> Hi, Jonathan,
>>>>>>> Fix looks good. But I guess this bug was not caught by the
>>>>>>> regression tests, so new test should be added(automatic test is
>>>>>>> better).
>>>>>>>
>>>>>>> 23.05.2012 14:15, Jonathan Lu wrote:
>>>>>>>> Hi Sergey,
>>>>>>>>
>>>>>>>> On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
>>>>>>>>> Hi, Jonathan,
>>>>>>>>> Looks like this bug is duplicate of
>>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161865
>>>>>>>>> And the reason of the issue is that we post UpdateEvent in
>>>>>>>>> target.repaint() in XLabelPeer.setFont(), but we should paint
>>>>>>>>> native part of the component in place[1] and then post 
>>>>>>>>> PaintEvent[2].
>>>>>>>>>
>>>>>>>>> - To fix [1] we can replace target.repaint() to repaint() in
>>>>>>>>> setFont(). Does it solve your issue?
>>>>>>>>
>>>>>>>> Yes, this resolves my problem, and here's the updated patch from
>>>>>>>> your suggestion,
>>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655_2/
>>>>>>>>
>>>>>>>> Thanks a lot!
>>>>>>>> - Jonathan
>>>>>>>>
>>>>>>>>>
>>>>>>>>> 22.05.2012 11:47, Jonathan Lu wrote:
>>>>>>>>>> Hi awt-dev,
>>>>>>>>>>
>>>>>>>>>> Here's a patch for bug 7170655, could anybody please help to 
>>>>>>>>>> take
>>>>>>>>>> a look?
>>>>>>>>>> http://cr.openjdk.java.net/~luchsh/7170655/
>>>>>>>>>>
>>>>>>>>>> The problem is that painting event from EDT during painting
>>>>>>>>>> handling does not get processed immediately, so leave a lag to
>>>>>>>>>> the user. My solution here is to coalesce and dispatch the new
>>>>>>>>>> paint event right after it was posted. This happens only to AWT
>>>>>>>>>> components.
>>>>>>>>>>
>>>>>>>>>> Thanks!
>>>>>>>>>> -Jonathan
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>
>
>



From littlee at linux.vnet.ibm.com  Wed May 30 01:57:40 2012
From: littlee at linux.vnet.ibm.com (Charles Lee)
Date: Wed, 30 May 2012 16:57:40 +0800
Subject: <AWT Dev> Behavior difference when open file dialog from applet
In-Reply-To: <4FA24120.8070409@linux.vnet.ibm.com>
References: <4F83AAD1.7030800@linux.vnet.ibm.com>
	<4F857ADF.6040607@linux.vnet.ibm.com>	<4F8E66F0.1050309@linux.vnet.ibm.com>
	<4F903DCF.5030807@oracle.com> <4F915784.3010705@oracle.com>
	<4F952B84.2030601@linux.vnet.ibm.com>
	<4FA24120.8070409@linux.vnet.ibm.com>
Message-ID: <4FC5E104.8060802@linux.vnet.ibm.com>

Hi security-devs,

I'd like to sponsor this patch. Would any security guys please have some 
time to review this patch?

On 05/03/2012 04:26 PM, Jonathan Lu wrote:
> Hello, how about just change the code like following patch by adding a 
> security check point before invoking the native dialog.
>
> http://cr.openjdk.java.net/~luchsh/webrev_gtk_file_dialog/
>
> Best regards!
>
> - Jonathan
>
> On 04/23/2012 06:14 PM, Jonathan Lu wrote:
>> Basically the existance checking of files and directory without 
>> explicitly granted permissions do not look very friendly to me 
>> especially for applet code from the web. This might be a helpful way 
>> for hackers to infer OS version, user habit or software config from 
>> the directory layout retrieved by a file dialog.
>>
>> Any comments from the security list?
>>
>> best regards!
>> -Jonathan
>>
>> On 04/20/2012 08:33 PM, Anthony Petrov wrote:
>>> OTOH, using a file dialog may allow one (with a little help from a 
>>> user) to check a file or a directory for existence which may be 
>>> considered a security vulnerability. This is actually the reason the 
>>> exception is thrown by XFileDialogPeer in the first place: it gets 
>>> thrown when the code calls File.isDirectory() when setting the 
>>> initial directory for the dialog.
>>>
>>> Not sure if this ability is much useful by itself, or if this 
>>> vulnerability is "convenient" for hackers to use since it involves 
>>> the user, but still this doesn't feel like a benign thing to me.
>>>
>>> What do security experts think about that?
>>>
>>> -- 
>>> best regards,
>>> Anthony
>>>
>>> On 4/19/2012 8:31 PM, Artem Ananiev wrote:
>>>> Hi, Jonathan,
>>>>
>>>> you're right, GTK and X file dialogs behave differently when 
>>>> SecurityManager is installed. However, instead of changing GTK 
>>>> dialogs, I propose to correct X dialogs, so they don't throw 
>>>> security exceptions.
>>>>
>>>> Indeed, application may create arbitrary java.io.File objects 
>>>> without any permissions. File permissions are only checked when 
>>>> application tries to read from, or write into, or just open the 
>>>> file. AWT file dialogs are about getting File objects, they don't 
>>>> provide access to File content (be it a regular file or a 
>>>> directory), so I don't see any reasons to throw exceptions.
>>>>
>>>> What do you think about it?
>>>>
>>>> Thanks,
>>>>
>>>> Artem
>>>>
>>>> On 4/18/2012 11:02 AM, Jonathan Lu wrote:
>>>>> Hello, is anybody interested in this problem?
>>>>>
>>>>> it seems to be a generic question of how to control security 
>>>>> access in
>>>>> JNI native implementation of JDK.
>>>>> And consider the behavior differences, is it neccessary to 
>>>>> reimplement
>>>>> Gtk file dialog in the same way as X dialog?
>>>>>
>>>>> Regards
>>>>> - Jonathan
>>>>>
>>>>> On 04/11/2012 08:36 PM, Jonathan Lu wrote:
>>>>>>
>>>>>> Hi awt-dev,
>>>>>>
>>>>>> I found a behavior difference when open file dialog from an 
>>>>>> applet, bug
>>>>>> 7160238 has been created for this issue.
>>>>>> Here's the tiny test case to helping reproduce the problem,
>>>>>>
>>>>>> /*
>>>>>> * Copyright (c) 2012 Oracle and/or its affiliates. All rights 
>>>>>> reserved.
>>>>>> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>>>> *
>>>>>> * This code is free software; you can redistribute it and/or 
>>>>>> modify it
>>>>>> * under the terms of the GNU General Public License version 2 
>>>>>> only, as
>>>>>> * published by the Free Software Foundation.
>>>>>> *
>>>>>> * This code is distributed in the hope that it will be useful, but
>>>>>> WITHOUT
>>>>>> * ANY WARRANTY; without even the implied warranty of 
>>>>>> MERCHANTABILITY or
>>>>>> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public 
>>>>>> License
>>>>>> * version 2 for more details (a copy is included in the LICENSE 
>>>>>> file that
>>>>>> * accompanied this code).
>>>>>> *
>>>>>> * You should have received a copy of the GNU General Public License
>>>>>> version
>>>>>> * 2 along with this work; if not, write to the Free Software 
>>>>>> Foundation,
>>>>>> * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
>>>>>> *
>>>>>> * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 
>>>>>> 94065 USA
>>>>>> * or visit www.oracle.com if you need additional information or 
>>>>>> have any
>>>>>> * questions.
>>>>>> */
>>>>>>
>>>>>> /*
>>>>>> * Portions Copyright (c) 2012 IBM Corporation
>>>>>> */
>>>>>>
>>>>>> import java.applet.Applet;
>>>>>> import java.awt.Button;
>>>>>> import java.awt.FileDialog;
>>>>>> import java.awt.Frame;
>>>>>> import java.awt.event.ActionEvent;
>>>>>> import java.awt.event.ActionListener;
>>>>>>
>>>>>> public class FileDialogTest extends Applet {
>>>>>> @Override
>>>>>> public void init() {
>>>>>> Button button = new Button("Open FileDialog");
>>>>>> add(button);
>>>>>> button.addActionListener(new ActionListener() {
>>>>>> @Override
>>>>>> public void actionPerformed(ActionEvent event) {
>>>>>> Frame f = new Frame();
>>>>>> FileDialog dialog = new FileDialog(f, "FileDialog");
>>>>>> dialog.show();
>>>>>> }
>>>>>> });
>>>>>> }
>>>>>> }
>>>>>>
>>>>>> Embeded it into an HTML document, test.html, then run 
>>>>>> appletviewer with
>>>>>> following two commands,
>>>>>> appletviewer -J-Dsun.awt.disableGtkFileDialogs=true test.html
>>>>>> appletviewer -J-Dsun.awt.disableGtkFileDialogs=false test.html
>>>>>>
>>>>>> The result will be different, -J-Dsun.awt.disableGtkFileDialogs=true
>>>>>> will throw AccessControlException, but
>>>>>> -J-Dsun.awt.disableGtkFileDialogs=false will continue to open a file
>>>>>> dialog.
>>>>>>
>>>>>> According to the specification:
>>>>>> The basic applet security model is an all or nothing proposition. 
>>>>>> If you
>>>>>> get a security certificate, you can give the applet full access 
>>>>>> to the
>>>>>> user's system. Without it, the applet has virtually no access at 
>>>>>> all.
>>>>>>
>>>>>> Since file dialog displays the content of user's file system, so it
>>>>>> absolutely needs file system read permmission, right? but for Gtk 
>>>>>> File
>>>>>> Dialog, it just works fine without exceptions. I don't think this
>>>>>> behavior is following the spec here, right? In OpenJDK's source 
>>>>>> code,
>>>>>> GtkFileDialogPeer will create a native GTK file chooser widget 
>>>>>> and keep
>>>>>> a native pointer, does this leave a breach to Java applet's security
>>>>>> model?
>>>>>>
>>>>>> Cheers!
>>>>>> - Jonathan
>>>>>>
>>>>>>
>>>>>
>>
>


-- 
Yours Charles



From alexandr.scherbatiy at oracle.com  Wed May 30 03:43:02 2012
From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com)
Date: Wed, 30 May 2012 10:43:02 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7146131: [macosx] When click the show
	optionpane	button,
	it display partly of dialog and hung until timeout
Message-ID: <20120530104334.7B310475B4@hg.openjdk.java.net>

Changeset: 14f9e9060370
Author:    alexsch
Date:      2012-05-30 14:46 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/14f9e9060370

7146131: [macosx] When click the show optionpane button,it display partly of dialog and hung until timeout
Reviewed-by: rupashka

! src/macosx/classes/com/apple/laf/AquaInternalFrameUI.java



From alexandr.scherbatiy at oracle.com  Wed May 30 03:54:27 2012
From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com)
Date: Wed, 30 May 2012 10:54:27 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7141296: [macosx] Mouse Wheel Turn
	closes combobox	popup
Message-ID: <20120530105447.1A724475B5@hg.openjdk.java.net>

Changeset: e6de02da6870
Author:    alexsch
Date:      2012-05-30 14:58 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e6de02da6870

7141296: [macosx] Mouse Wheel Turn closes combobox popup
Reviewed-by: rupashka

! src/macosx/classes/com/apple/laf/AquaScrollPaneUI.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java



From anthony.petrov at oracle.com  Wed May 30 03:55:24 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Wed, 30 May 2012 14:55:24 +0400
Subject: <AWT Dev> [8] Review request for 7150089: [macosx] Default for
 a custom cursor created from non-existent image is not transparent
In-Reply-To: <BACCEA75-CBC1-4F6C-A542-1753E1D41A96@oracle.com>
References: <BACCEA75-CBC1-4F6C-A542-1753E1D41A96@oracle.com>
Message-ID: <4FC5FC9C.3070809@oracle.com>

The fix looks good to me.

--
best regards,
Anthony

On 5/29/2012 10:41 PM, Leonid Romanov wrote:
> Hi,
> Please review a fix for 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent. Exactly the same fix under the same CR has already been pushed into 7u4.
> 
> Bug: http://monaco.us.oracle.com/detail.jsf?cr=7150089
> Webrev: http://cr.openjdk.java.net/~leonidr/7150089/webrev.00/
> 
> Thanks,
> Leonid.
> 


From anthony.petrov at oracle.com  Wed May 30 05:13:18 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Wed, 30 May 2012 16:13:18 +0400
Subject: <AWT Dev> [8] Review request for: 7172722: Latest jdk7u from OSX
 broke universal build
Message-ID: <4FC60EDE.4020805@oracle.com>

Hello,

Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7172722 at:

http://cr.openjdk.java.net/~anthony/8-33-MacUniversalBuild-7172722.0/

I've simplified the fix comparing to original Henri's proposal [1] to 
follow the same pattern as we use with other properties: we simply give 
  the corresponding class fields the same names as to the properties 
themselves.

Henri: please verify if the new patch works for you.

[1] http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/003191.html

--
best regards,
Anthony


From alexander.zuev at oracle.com  Wed May 30 06:36:26 2012
From: alexander.zuev at oracle.com (Alexander Zuev)
Date: Wed, 30 May 2012 17:36:26 +0400
Subject: <AWT Dev> [8] Review request for 7150089: [macosx] Default for
 a custom cursor created from non-existent image is not transparent
In-Reply-To: <BACCEA75-CBC1-4F6C-A542-1753E1D41A96@oracle.com>
References: <BACCEA75-CBC1-4F6C-A542-1753E1D41A96@oracle.com>
Message-ID: <4FC6225A.2060402@oracle.com>

Looks Ok to me.

On 5/29/12 22:41, Leonid Romanov wrote:
> Hi,
> Please review a fix for 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent. Exactly the same fix under the same CR has already been pushed into 7u4.
>
> Bug: http://monaco.us.oracle.com/detail.jsf?cr=7150089
> Webrev: http://cr.openjdk.java.net/~leonidr/7150089/webrev.00/
>
> Thanks,
> Leonid.
>



From neugens.limasoftware at gmail.com  Wed May 30 09:15:32 2012
From: neugens.limasoftware at gmail.com (neugens.limasoftware at gmail.com)
Date: Wed, 30 May 2012 16:15:32 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7171806: Missing test for bug ID
	6800513 fix
Message-ID: <20120530161551.2E6CA475C0@hg.openjdk.java.net>

Changeset: 8800a98316b2
Author:    neugens
Date:      2012-05-30 18:15 +0200
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8800a98316b2

7171806: Missing test for bug ID 6800513 fix
Reviewed-by: rupashka

+ test/javax/swing/JPopupMenu/6800513/bug6800513.java



From denis.fokin at oracle.com  Thu May 31 03:59:10 2012
From: denis.fokin at oracle.com (Denis S. Fokin)
Date: Thu, 31 May 2012 14:59:10 +0400
Subject: <AWT Dev> [7u6] Review request for 7112115:
 Component.getLocationOnScreen() work incorrectly if create window in point
 (0, 0) on oel
Message-ID: <4FC74EFE.6060502@oracle.com>

Hi,

could you take a look at the next fix. I have moved the test from the 
closed repository and changed

Util.blockTillDisplayed(spinner2);

to

((sun.awt.SunToolkit)Toolkit.getDefaultToolkit()).realSync();

because getLocationOnScreen does not guarantee that we will get the last 
value for component location and blockTillDisplayed uses 
getLocationOnScreen method.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112115
Webrev: http://cr.openjdk.java.net/~denis/7112115/webrev.01/

Thank you,
     Denis.


From Vladislav.Karnaukhov at oracle.com  Thu May 31 04:33:01 2012
From: Vladislav.Karnaukhov at oracle.com (Vladislav Karnaukhov)
Date: Thu, 31 May 2012 15:33:01 +0400
Subject: <AWT Dev> Review request for 6891269 non-compliance with Section
 508 using 1.6.0_18
Message-ID: <4FC756ED.1040300@oracle.com>

Hello,

please review a fix for the following issue: 6891269 non-compliance with 
Section 508 using 1.6.0_18

http://monaco.sfbay.sun.com/detail.jsf?cr=6891269

Please find webrev here: 
http://washi.ru.oracle.com/vk220959/webrevs/CR-6891269/7u6/

This is a forward-port from JDK6. The fix introduces support for Windows 
Accessibility/Ease Of Access to TextArea control.

Regards,
- Vlad


From Vladislav.Karnaukhov at oracle.com  Thu May 31 04:46:23 2012
From: Vladislav.Karnaukhov at oracle.com (Vladislav Karnaukhov)
Date: Thu, 31 May 2012 15:46:23 +0400
Subject: <AWT Dev> Review request for 6891269 non-compliance with
 Section 508 using 1.6.0_18
In-Reply-To: <4FC756ED.1040300@oracle.com>
References: <4FC756ED.1040300@oracle.com>
Message-ID: <4FC75A0F.5050407@oracle.com>

Please ignore.

- Vlad

On 31.05.12 15:33, Vladislav Karnaukhov wrote:
> Hello,
>
> please review a fix for the following issue: 6891269 non-compliance 
> with Section 508 using 1.6.0_18
>
> http://monaco.sfbay.sun.com/detail.jsf?cr=6891269
>
> Please find webrev here: 
> http://washi.ru.oracle.com/vk220959/webrevs/CR-6891269/7u6/
>
> This is a forward-port from JDK6. The fix introduces support for 
> Windows Accessibility/Ease Of Access to TextArea control.
>
> Regards,
> - Vlad



From Sergey.Bylokhov at oracle.com  Thu May 31 05:49:15 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 31 May 2012 16:49:15 +0400
Subject: <AWT Dev> [7u6] Review request for 7112115:
 Component.getLocationOnScreen() work incorrectly if create window in point
 (0, 0) on oel
In-Reply-To: <4FC74EFE.6060502@oracle.com>
References: <4FC74EFE.6060502@oracle.com>
Message-ID: <4FC768CB.9000803@oracle.com>

Hi, Denis.
I guess that copyright header should be added.

31.05.2012 14:59, Denis S. Fokin wrote:
> Hi,
>
> could you take a look at the next fix. I have moved the test from the 
> closed repository and changed
>
> Util.blockTillDisplayed(spinner2);
>
> to
>
> ((sun.awt.SunToolkit)Toolkit.getDefaultToolkit()).realSync();
>
> because getLocationOnScreen does not guarantee that we will get the 
> last value for component location and blockTillDisplayed uses 
> getLocationOnScreen method.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112115
> Webrev: http://cr.openjdk.java.net/~denis/7112115/webrev.01/
>
> Thank you,
>     Denis.


-- 
Best regards, Sergey.



From Sergey.Bylokhov at oracle.com  Thu May 31 05:50:56 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 31 May 2012 16:50:56 +0400
Subject: <AWT Dev> [7u6] Review request for 7112115:
 Component.getLocationOnScreen() work incorrectly if create window in point
 (0, 0) on oel
In-Reply-To: <4FC768CB.9000803@oracle.com>
References: <4FC74EFE.6060502@oracle.com> <4FC768CB.9000803@oracle.com>
Message-ID: <4FC76930.8090802@oracle.com>

31.05.2012 16:49, Sergey Bylokhov wrote:
> Hi, Denis.
> I guess that copyright header should be added.
And probably it should be fixed in 8 first?
>
> 31.05.2012 14:59, Denis S. Fokin wrote:
>> Hi,
>>
>> could you take a look at the next fix. I have moved the test from the 
>> closed repository and changed
>>
>> Util.blockTillDisplayed(spinner2);
>>
>> to
>>
>> ((sun.awt.SunToolkit)Toolkit.getDefaultToolkit()).realSync();
>>
>> because getLocationOnScreen does not guarantee that we will get the 
>> last value for component location and blockTillDisplayed uses 
>> getLocationOnScreen method.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112115
>> Webrev: http://cr.openjdk.java.net/~denis/7112115/webrev.01/
>>
>> Thank you,
>>     Denis.
>
>


-- 
Best regards, Sergey.



From Sergey.Bylokhov at oracle.com  Thu May 31 06:43:46 2012
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 31 May 2012 17:43:46 +0400
Subject: <AWT Dev> [8] Review request for 7142091: [macosx] RFE: Refactoring
 of peer initialization/disposing
Message-ID: <4FC77592.7020900@oracle.com>

Hi Everyone,
Please review the fix.

Notes from the bug and comments:
1. setVisible() should be called at the end of the peers initialization. 
We can move super.initialize() to the end of the peers initializations.
Initialize() was split to initialize() and initializeImpl(). In the 
initialize() we call initializeImpl and then we call to setVisible(). 
initializeImpl overridden in subclasses.

2. Invokelater in the initialization/disposing is a tricky.
Left it as is. Probably later it will be changed. Comments was updated.

3. replaceSurfacedata() should be moved outside of LWWindowPeer.setVisible()
Done. Also duplicate code was extracted to setVisible() method which 
call setVisibleImpl().

4. Backbuffer in replaceSurfacedata() should be initialized by clearRect 
instead of fillrect(composite is important).
Done. related to composite.

5. During lwwindowpeer initialization we call two similar methods 
nativeSetNSWindowAlpha() and setAlphaValue().
nativeSetNSWindowAlpha() removed from CPlatformWindow.java.


Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142091
Webrev can be found at: http://cr.openjdk.java.net/~serb/7142091/webrev.00/

-- 
Best regards, Sergey.



From denis.fokin at oracle.com  Thu May 31 07:03:19 2012
From: denis.fokin at oracle.com (Denis S. Fokin)
Date: Thu, 31 May 2012 18:03:19 +0400
Subject: <AWT Dev> [8] Review request for 7112115:
 Component.getLocationOnScreen() work incorrectly if create window in point
 (0, 0) on oel
Message-ID: <4FC77A27.8070400@oracle.com>

Hi,

could you take a look at the next fix. I have moved the test from the 
closed repository and changed

Util.blockTillDisplayed(spinner2);

to

((sun.awt.SunToolkit)Toolkit.getDefaultToolkit()).realSync();

because getLocationOnScreen does not guarantee that we will get the last 
value for component location and blockTillDisplayed uses 
getLocationOnScreen method.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112115
Webrev: http://cr.openjdk.java.net/~denis/7112115/webrev.02/

Thank you,
     Denis.


From artem.ananiev at oracle.com  Thu May 31 08:30:10 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Thu, 31 May 2012 19:30:10 +0400
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
 defaults to Generic Java Application Category
In-Reply-To: <32533319-5E00-483F-AE69-6E79419C3757@oracle.com>
References: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
	<4FC373A5.9030508@oracle.com>
	<89803632-78F2-410F-B66B-09AEFC8CAB11@oracle.com>
	<4FC39B2F.6070805@oracle.com>
	<32533319-5E00-483F-AE69-6E79419C3757@oracle.com>
Message-ID: <4FC78E82.1030500@oracle.com>

Hi, Leonid,

shouldn't app name set in the bundler be of higher priority than 
JAVA_MAIN_CLASS_<pid> value, set by Java launcher?

Thanks,

Artem

On 5/29/2012 8:59 PM, Leonid Romanov wrote:
> Well, the order is the following: first, we check if -Xdock:name has been set. If it hasn't, we check for the "apple.awt.application.name" property. If this property hasn't been set, we try to get the app name from the JAVA_MAIN_CLASS_<pid>  environment variable, which is used to pass  the name of a Java class whose main() method was invoked by the Java launcher code to start the application. If JAVA_MAIN_CLASS_<pid>  hasn't been set, then as the last resort we try to get the app name from the bundle.
>
> On 28.05.2012, at 19:35, Artem Ananiev wrote:
>
>>
>> On 5/28/2012 6:06 PM, Leonid Romanov wrote:
>>> Hi,
>>> The problem with the application name is that the app in question uses "com.apple.mrj.application.apple.menu.about.name" property to set its name. Mu understanding is that we don't support this property in OpenJDK.
>>
>> OK, fine. Is the application name set correctly when it is passed from app bundle or as -Xdock:name?
>>
>> Thanks,
>>
>> Artem
>>
>>> On 28.05.2012, at 16:46, Artem Ananiev wrote:
>>>
>>>> Hi, Leonid,
>>>>
>>>> the fix looks fine. Is the application name issue (also mentioned in 7159381) addressed in another fix?
>>>>
>>>> Thanks,
>>>>
>>>> Artem
>>>>
>>>> On 5/24/2012 5:23 PM, Leonid Romanov wrote:
>>>>> Hi,
>>>>> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything.
>>>>>
>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
>>>>> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
>>>>>
>>>>> Thanks,
>>>>> Leonid.
>>>>>
>>>
>


From artem.ananiev at oracle.com  Thu May 31 09:20:59 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Thu, 31 May 2012 20:20:59 +0400
Subject: <AWT Dev> [8] Review request for 7112115:
 Component.getLocationOnScreen() work incorrectly if create window in point
 (0, 0) on oel
In-Reply-To: <4FC77A27.8070400@oracle.com>
References: <4FC77A27.8070400@oracle.com>
Message-ID: <4FC79A6B.9090209@oracle.com>

Hi, Denis,

the test looks fine. A minor comment: since we don't expect any 
exceptions in the doTest() method, shouldn't "ex" be re-thrown then to 
cause the test failure?

Thanks,

Artem

On 5/31/2012 6:03 PM, Denis S. Fokin wrote:
> Hi,
>
> could you take a look at the next fix. I have moved the test from the
> closed repository and changed
>
> Util.blockTillDisplayed(spinner2);
>
> to
>
> ((sun.awt.SunToolkit)Toolkit.getDefaultToolkit()).realSync();
>
> because getLocationOnScreen does not guarantee that we will get the last
> value for component location and blockTillDisplayed uses
> getLocationOnScreen method.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112115
> Webrev: http://cr.openjdk.java.net/~denis/7112115/webrev.02/
>
> Thank you,
> Denis.


From alexander.zuev at oracle.com  Thu May 31 09:18:39 2012
From: alexander.zuev at oracle.com (alexander.zuev at oracle.com)
Date: Thu, 31 May 2012 16:18:39 +0000
Subject: <AWT Dev> hg: jdk8/awt/jdk: 7150089: [macosx] Default for a custom
	cursor	created from non-existent image is not transparent
Message-ID: <20120531161909.52F024764B@hg.openjdk.java.net>

Changeset: 06a0302856eb
Author:    leonidr
Date:      2012-05-31 20:18 +0400
URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/06a0302856eb

7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent
Reviewed-by: anthony, kizune

! src/macosx/classes/sun/lwawt/macosx/CCustomCursor.java



From scott.kovatch at oracle.com  Thu May 31 09:20:31 2012
From: scott.kovatch at oracle.com (Scott Kovatch)
Date: Thu, 31 May 2012 09:20:31 -0700
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
	defaults to Generic Java Application Category
In-Reply-To: <4FC78E82.1030500@oracle.com>
References: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
	<4FC373A5.9030508@oracle.com>
	<89803632-78F2-410F-B66B-09AEFC8CAB11@oracle.com>
	<4FC39B2F.6070805@oracle.com>
	<32533319-5E00-483F-AE69-6E79419C3757@oracle.com>
	<4FC78E82.1030500@oracle.com>
Message-ID: <99A4EEA8-726B-4319-AEDE-DC84E9F9D32F@oracle.com>

I think what Artem is saying is that if the application is bundled, and CFBundleName is set, it should take higher priority than JAVA_MAIN_CLASS_<pid>.

If that is what you are saying, Artem, I agree. :-)

We're straying away from the original review, though.

-- Scott

On May 31, 2012, at 8:30 AM, Artem Ananiev <artem.ananiev at oracle.com> wrote:

> Hi, Leonid,
> 
> shouldn't app name set in the bundler be of higher priority than JAVA_MAIN_CLASS_<pid> value, set by Java launcher?
> 
> Thanks,
> 
> Artem
> 
> On 5/29/2012 8:59 PM, Leonid Romanov wrote:
>> Well, the order is the following: first, we check if -Xdock:name has been set. If it hasn't, we check for the "apple.awt.application.name" property. If this property hasn't been set, we try to get the app name from the JAVA_MAIN_CLASS_<pid>  environment variable, which is used to pass  the name of a Java class whose main() method was invoked by the Java launcher code to start the application. If JAVA_MAIN_CLASS_<pid>  hasn't been set, then as the last resort we try to get the app name from the bundle.
>> 
>> On 28.05.2012, at 19:35, Artem Ananiev wrote:
>> 
>>> 
>>> On 5/28/2012 6:06 PM, Leonid Romanov wrote:
>>>> Hi,
>>>> The problem with the application name is that the app in question uses "com.apple.mrj.application.apple.menu.about.name" property to set its name. Mu understanding is that we don't support this property in OpenJDK.
>>> 
>>> OK, fine. Is the application name set correctly when it is passed from app bundle or as -Xdock:name?
>>> 
>>> Thanks,
>>> 
>>> Artem
>>> 
>>>> On 28.05.2012, at 16:46, Artem Ananiev wrote:
>>>> 
>>>>> Hi, Leonid,
>>>>> 
>>>>> the fix looks fine. Is the application name issue (also mentioned in 7159381) addressed in another fix?
>>>>> 
>>>>> Thanks,
>>>>> 
>>>>> Artem
>>>>> 
>>>>> On 5/24/2012 5:23 PM, Leonid Romanov wrote:
>>>>>> Hi,
>>>>>> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything.
>>>>>> 
>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
>>>>>> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
>>>>>> 
>>>>>> Thanks,
>>>>>> Leonid.
>>>>>> 
>>>> 
>> 



From scott.kovatch at oracle.com  Thu May 31 09:32:34 2012
From: scott.kovatch at oracle.com (Scott Kovatch)
Date: Thu, 31 May 2012 09:32:34 -0700
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
	defaults to Generic Java Application Category
In-Reply-To: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
References: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
Message-ID: <11ECC2F5-E492-46BC-8837-BCD28314A6C5@oracle.com>


On May 24, 2012, at 6:23 AM, Leonid Romanov <leonid.romanov at oracle.com> wrote:

> Hi,
> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything. 
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/


I re-read the change after seeing the discussion about the app name, and I see that we are now separating the decision of which icon to use from the decision of which name to use, and that's definitely correct.

However, it looks like we will now override the application icon if an icon was specified via property name or if -Xdock:name was used. Is that intentional? If so I think it's worth a comment or two.

I _think_ this is the right way to go. In my opinion, it's a developer error if the application was bundled and the developer used CFBundleIconFile, but then also set apple.awt.application.icon or "-Xdock:icon=" in the Info.plist or in code.

What did Apple's JDK 6 do? I can't remember now. I think we should follow the rules set there, and document them one way or the other.

Any thoughts?

-- Scott K.


From artem.ananiev at oracle.com  Thu May 31 09:44:10 2012
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Thu, 31 May 2012 20:44:10 +0400
Subject: <AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon
 defaults to Generic Java Application Category
In-Reply-To: <99A4EEA8-726B-4319-AEDE-DC84E9F9D32F@oracle.com>
References: <DBFD5672-16C6-4FD2-A979-94E8C9F7BBBE@oracle.com>
	<4FC373A5.9030508@oracle.com>
	<89803632-78F2-410F-B66B-09AEFC8CAB11@oracle.com>
	<4FC39B2F.6070805@oracle.com>
	<32533319-5E00-483F-AE69-6E79419C3757@oracle.com>
	<4FC78E82.1030500@oracle.com>
	<99A4EEA8-726B-4319-AEDE-DC84E9F9D32F@oracle.com>
Message-ID: <4FC79FDA.3010809@oracle.com>


On 5/31/2012 8:20 PM, Scott Kovatch wrote:
> I think what Artem is saying is that if the application is bundled, and CFBundleName is set, it should take higher priority than JAVA_MAIN_CLASS_<pid>.
>
> If that is what you are saying, Artem, I agree. :-)

Yes, exactly, thanks for clear wording, Scott :)

> We're straying away from the original review, though.

Since we touch that code anyway, we may want to extend the fix to make 
JAVA_MAIN_CLASS_<pid> of lower priority instead of filing a new bug for 
that.

Thanks,

Artem

> -- Scott
>
> On May 31, 2012, at 8:30 AM, Artem Ananiev<artem.ananiev at oracle.com>  wrote:
>
>> Hi, Leonid,
>>
>> shouldn't app name set in the bundler be of higher priority than JAVA_MAIN_CLASS_<pid>  value, set by Java launcher?
>>
>> Thanks,
>>
>> Artem
>>
>> On 5/29/2012 8:59 PM, Leonid Romanov wrote:
>>> Well, the order is the following: first, we check if -Xdock:name has been set. If it hasn't, we check for the "apple.awt.application.name" property. If this property hasn't been set, we try to get the app name from the JAVA_MAIN_CLASS_<pid>   environment variable, which is used to pass  the name of a Java class whose main() method was invoked by the Java launcher code to start the application. If JAVA_MAIN_CLASS_<pid>   hasn't been set, then as the last resort we try to get the app name from the bundle.
>>>
>>> On 28.05.2012, at 19:35, Artem Ananiev wrote:
>>>
>>>>
>>>> On 5/28/2012 6:06 PM, Leonid Romanov wrote:
>>>>> Hi,
>>>>> The problem with the application name is that the app in question uses "com.apple.mrj.application.apple.menu.about.name" property to set its name. Mu understanding is that we don't support this property in OpenJDK.
>>>>
>>>> OK, fine. Is the application name set correctly when it is passed from app bundle or as -Xdock:name?
>>>>
>>>> Thanks,
>>>>
>>>> Artem
>>>>
>>>>> On 28.05.2012, at 16:46, Artem Ananiev wrote:
>>>>>
>>>>>> Hi, Leonid,
>>>>>>
>>>>>> the fix looks fine. Is the application name issue (also mentioned in 7159381) addressed in another fix?
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Artem
>>>>>>
>>>>>> On 5/24/2012 5:23 PM, Leonid Romanov wrote:
>>>>>>> Hi,
>>>>>>> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything.
>>>>>>>
>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
>>>>>>> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Leonid.
>>>>>>>
>>>>>
>>>
>


From anthony.petrov at oracle.com  Thu May 31 14:55:28 2012
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Fri, 01 Jun 2012 01:55:28 +0400
Subject: <AWT Dev> [8] Review request for: 7172722: Latest jdk7u from
 OSX broke universal build
In-Reply-To: <CALyUpY2qMeYkSYGFfrOvKN6QSftHUx4AuUiZ6=+EeT2XFvR7Pg@mail.gmail.com>
References: <4FC77E3A.4060408@oracle.com>
	<CALyUpY2qMeYkSYGFfrOvKN6QSftHUx4AuUiZ6=+EeT2XFvR7Pg@mail.gmail.com>
Message-ID: <4FC7E8D0.4070100@oracle.com>

All: please review the fix (a link to the webrev is below)

Hi Henri,

On 5/31/2012 11:41 PM, Henri Gomez wrote:
> Not subscribed to this mailing list.

This is not a problem at all! You may just hit the Reply All button on 
the original review request email that I've sent (I've included your 
address in the To: section so you should have received a copy). The 
message will simply go through a moderator of the mailing list, and once 
approved will hit the mailing list as usual.

Anyway, I'm CC'ing the original aliases right now so that this 
conversation could contribute to the code review.

> +    NSWindow *nsWindow;
> 
> BTW, your patch should do the work (it was my first attempt before

Thanks for verifying that.

> friends told me that _nsWindow is a convention to follow in ObjC/Cocoa
> land.

I realize that this may be a convention in the ObjC world. However, in 
JDK we tend to establish a pattern and then follow it everywhere to 
simplify maintenance of the code. Since other properties are defined 
this way, I decided to do the same with this one too.

--
best regards,
Anthony

> 2012/5/31 Anthony Petrov <anthony.petrov at oracle.com>:
>> Hi Henri,
>>
>> Have you had a chance to give this patch a try? Please reply to the mailing
>> list with your testing results.
>>
>> --
>> best regards,
>> Anthony
>>
>>
>> -------- Original Message --------
>> Subject: <AWT Dev> [8] Review request for: 7172722: Latest jdk7u from OSX
>> broke universal build
>> Date: Wed, 30 May 2012 16:13:18 +0400
>> From: Anthony Petrov <anthony.petrov at oracle.com>
>> To: macosx-port-dev <macosx-port-dev at openjdk.java.net>,
>> "awt-dev at openjdk.java.net" <awt-dev at openjdk.java.net>,        Henri Gomez
>> <henri.gomez at gmail.com>
>>
>> Hello,
>>
>> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7172722 at:
>>
>> http://cr.openjdk.java.net/~anthony/8-33-MacUniversalBuild-7172722.0/
>>
>> I've simplified the fix comparing to original Henri's proposal [1] to
>> follow the same pattern as we use with other properties: we simply give
>>  the corresponding class fields the same names as to the properties
>> themselves.
>>
>> Henri: please verify if the new patch works for you.
>>
>> [1] http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/003191.html
>>


From konstantin.shefov at oracle.com  Thu May 31 06:59:24 2012
From: konstantin.shefov at oracle.com (Konstantin Shefov)
Date: Thu, 31 May 2012 17:59:24 +0400
Subject: <AWT Dev> [8] Review request for 6868690 TEST:
 java/awt/FontClass/CreateFont/BigFont.java test should be modified in
 jdk7&8 to run via jtreg
Message-ID: <4FC7793C.8020105@oracle.com>

Hello,

Please review a fix for the issue:
         6868690 TEST: java/awt/FontClass/CreateFont/BigFont.java test 
should be modified in jdk7&8 to run via jtreg

The webrev is http://cr.openjdk.java.net/~serb/6868690/webrev.00/

The test in the current state affects a whole session if it's executed 
under jtreg. It was fixed already by the implemented modifications in 
1.7.0 that are used as a base for modifications applicable for 1.8.0 
also. There is not risk are seen if the test be updated in jdk8 repo.

The current fix is identical to already pushed fix for jdk 7.

The test works in the automatic invocation (under jtreg) without 
bigfont.html file involvement. The only possible reason we may keep it 
(bigfont.html) for is - the test can be used in both the manual and 
automatic invocations. It include two methods runTest1() & runTest2(). 
runTest2() is commented in the BigFont.java file as it's too "risky" to 
execute it in the automatic mode from the the applet environment. But it 
(runTest2()) is still valid for the manual invocation just for 
"legacy/coverage" reason to be executed under applet environment that is 
more challenging. As mentioned bigfont.html does not work in automatic 
invocation, but it can work if somebody decide to run the test manually 
(runTest2()) under applet environment.

Thanks,
Konstantin