<AWT Dev> RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt
krishna.addepalli at oracle.com
Tue Oct 2 15:23:24 UTC 2018
Yes, that is right.
I have compiled it Mac, Linux and Windows locally. I tried submitting a Mach5 job, but was unable to as it was down. Will try it again.
> On 02-Oct-2018, at 3:39 AM, Philip Race <philip.race at oracle.com> wrote:
> I suspect I understand this one now .. the array is stack allocated so we don't want NULL
> but the compiler probably complained about possible uninitialised use of the values ?
> On 10/1/18, 9:38 AM, Philip Race wrote:
>> You really do need to explain *each* of the changes better.
>> This one .. why not NULL ?
>> http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html <http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html>
>> On 10/1/18, 9:19 AM, Philip Race wrote:
>>> 1) Has this been built on all platforms ?
>>> 2) I can't find the list of warnings that you are seeing and fixing and they are all over the place.
>>> So adding 2d-dev and build-dev.
>>> For each of these changes, please show what was the warning that you received from the compiler
>>> This might sound like a lot of work, but it won't be disproportionate and I've made the same
>>> request for similar reviews and without it, it is hard to review the changes.
>>> For example (and I do mean just example)
>>> http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html <http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html>
>>> why would that not be #ifdef instead ?
>>> 3) Testing .. did you run at least all our jtreg tests to make sure you didn't break
>>> some behaviour ..
>>> On 9/29/18, 8:18 PM, Krishna Addepalli wrote:
>>>> Hi All,
>>>> Please review a fix for JDK-8074824: https://bugs.openjdk.java.net/browse/JDK-8074824 <https://bugs.openjdk.java.net/browse/JDK-8074824>
>>>> Webrev: http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/ <http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/>
>>>> Most of the warnings have been fixed for Linux, Mac and Windows.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev