<AWT Dev>  RFR : JDK-8198001 : java/awt/Menu/WrongParentAfterRemoveMenu/WrongParentAfterRemoveMenu.java debug assert on Windows
ambarish.rapte at oracle.com
Tue Oct 30 16:45:41 UTC 2018
Thanks for the review comments.
Please take a look at updated webrev: http://cr.openjdk.java.net/~arapte/8198001/webrev.01/
Updated the test with bud ID.
The test is not included in problem list.
From: Phil Race
Sent: Tuesday, October 30, 2018 12:46 AM
To: Ambarish Rapte <ambarish.rapte at oracle.com>; awt-dev at openjdk.java.net
Subject: Re: <AWT Dev>  RFR : JDK-8198001 : java/awt/Menu/WrongParentAfterRemoveMenu/WrongParentAfterRemoveMenu.java debug assert on Windows
The failing test should be updated with this bug id. Else it looks like a fix with no regression test.
Also if this was on the problem list (probably not if it only failed in debug builds) it
should be removed.
On 10/29/18 9:29 AM, Ambarish Rapte wrote:
Please review this windows only fix:
Test asserts with debug build jdk, only on windows.
This test fails when Menu is removed from MenuBar (WrongParentAfterRemoveMenu.java :: Line no 100)
Assert at Line no. 209, awt_MenuBar.cpp :: RedrawMenuBar()
AwtMenuBar::DeleteItem() -> AwtMenuBar::RedrawMenuBar() => calls GetOwnerHWnd() which returns NULL.
Fix: Value returned by GetOwnerHWnd() should be checked for NULL value.
Verification: All MenuBar tests pass.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev