<div dir="ltr">So, what is the best place for webrev, if I don't have access to ftp server? <div>I don't have possibility to set up Apache server for that.<br><div>Also, maybe I'm wrong, but to view index.html on ftp, you need to download it as well.</div>
<div><br></div><div>Okay, I will remove "and and" at line 2887.</div></div><div><br></div><div>About <em> tag, let me look at Javadoc documentation, I have no idea, how it will behave in {@code} tag</div><div>
<br></div><div>Konstantin.</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/8/8 Sergey Bylokhov <span dir="ltr"><<a href="mailto:Sergey.Bylokhov@oracle.com" target="_blank">Sergey.Bylokhov@oracle.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>Hi, Konstantin.<br>
A few comments about the fix.<br>
<code><em>Foo</em>Listener</code> in a few
places was changed to the {@code <em>Foo</em>Listener}
but it is not equivalent.<br>
Also I suggest to remove one of "and" from the "and and" in the
line 2887, because you change this line anyway.<div class="im"><br>
<br>
On 08.08.2013 16:54, Konstantin Perikov wrote:<br>
</div></div><div class="im">
<blockquote type="cite">
<div dir="ltr">Okay. I keep comment about synchronization for the
"type" field and return comment style for transient field.
<div><br>
</div>
<div>Is Google Drive better place for it? (that's why I ask
yesterday about "good" place for webrev)</div>
<div><a href="https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing" target="_blank">https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing</a><br>
</div>
</div>
</blockquote></div>
No, it is not better, atleast i don't understand how to view
index.html in this case or download all files at once.<div class="im"><br>
<blockquote type="cite">
<div dir="ltr"><br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2013/8/8 Artem Ananiev <span dir="ltr"><<a href="mailto:artem.ananiev@oracle.com" target="_blank">artem.ananiev@oracle.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,
Konstantin,<br>
<br>
I looked through the changes, which mostly replacements
<code></code> with {@code}. This part of the fix
looks fine.<br>
<br>
Changing /* to /** for the "isInShow" field doesn't make
sense, as this field is transient and is not serialized
anyway. However, it doesn't hurt as well.<br>
<br>
Please, keep comment about synchronization for the "type"
field. It's a hint for developers, that this field should
only be accessed or modified under the object lock. I agree,
JavaDoc is not the best place for such hints, but I don't
see any better solutions.<br>
<br>
Non-technical comments:<br>
<br>
1. Please, provide a direct link to webrev, so people can
click and see the changes. Downloading archives is not as
convenient (and in this particular case just impossible, as
Yandex.Disk is in Russian, people just won't be able to read
the "Download" button).<br>
<br>
2. Please, wait for at least one more person to have
reviewed this fix.<br>
<br>
Thanks,<br>
<br>
Artem<br>
<br>
On 8/8/2013 2:20 PM, Konstantin Perikov wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi, AWT team,<br>
<br>
Could you please review the fix for the following bug:<br>
<br>
*7027045: : (doc) java/awt/Window.java has several typos
in javadoc*<br>
<br>
Fix for version OpenJDK8. Also, I fix some
<code></code> stuff and change it for {@code }<br>
<br>
The webrev is available here:<br>
<br>
<a href="http://yadi.sk/d/KHB0hBlA7gkke" target="_blank">http://yadi.sk/d/KHB0hBlA7gkke</a><br>
<br>
<br>
P.S. Since, I'm newcomer, I don't have rights to push, so
I need a sponsor. Who could help me?<br>
<br>
Thanks,<br>
<br>
Konstantin<br>
<br>
</blockquote>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<br>
</div><span class="HOEnZb"><font color="#888888"><pre cols="72">--
Best regards, Sergey. </pre>
</font></span></div>
</blockquote></div><br></div>