<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hi, Konstantin.<br>
      Fix looks fine to me.<br>
      Thanks!<br>
      <br>
      On 09.08.2013 14:01, Konstantin Perikov wrote:<br>
    </div>
    <blockquote
cite="mid:CAD=kh=+_o6pK5ZejdNE7G9maeVc2RQR62sWEQP1GtwyZ6o1Bwg@mail.gmail.com"
      type="cite">
      <div dir="ltr">Hi, AWT team
        <div><br>
        </div>
        <div>I update fix. Short summary:</div>
        <div><br>
        </div>
        <div>
          <div>
            <ul>
              <li>Javadoc fixed from /* to /** for two serializable
                fields</li>
              <li>Hint about synchronization still exists</li>
              <li>Also, I change &nbsp;&lt;code&gt;&lt;/code&gt; to {@code},
                but left some of them, where &lt;em&gt;&lt;/em&gt; is
                using inside &lt;code&gt; tags</li>
              <li>Remove "and and" at line 2887</li>
            </ul>
          </div>
        </div>
        <div><br>
        </div>
        <div>Now webrev placed in Dropbox here-&nbsp;<a
            moz-do-not-send="true"
            href="https://www.dropbox.com/sh/fz7qws34btuvq8f/KvIB0ZdL79">https://www.dropbox.com/sh/fz7qws34btuvq8f/KvIB0ZdL79</a></div>
        <div>You could donwload webrev in one click or open jdk.patch
          and looks inside, using your favourite browser.</div>
        <div><br>
        </div>
        <div>Please review it.</div>
        <div><br>
        </div>
        <div>Thanks,&nbsp;</div>
        <div><br>
        </div>
        <div>Konstantin.</div>
        <div><br>
        </div>
      </div>
      <div class="gmail_extra"><br>
        <br>
        <div class="gmail_quote">2013/8/8 Konstantin Perikov <span
            dir="ltr">&lt;<a moz-do-not-send="true"
              href="mailto:konstantin.perikov@gmail.com" target="_blank">konstantin.perikov@gmail.com</a>&gt;</span><br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div dir="ltr">So, what is the best place for webrev, if I
              don't have access to ftp server?&nbsp;
              <div>I don't have possibility to set up Apache server for
                that.<br>
                <div>Also, maybe I'm wrong, but to view index.html on
                  ftp, you need to download it as well.</div>
                <div><br>
                </div>
                <div>Okay, I will remove "and and" at line 2887.</div>
              </div>
              <div><br>
              </div>
              <div>About &lt;em&gt; tag, let me look at Javadoc
                documentation, I have no idea, how it will behave in
                {@code} tag</div>
              <span class="HOEnZb"><font color="#888888">
                  <div>
                    <br>
                  </div>
                  <div>Konstantin.</div>
                  <div><br>
                  </div>
                  <div><br>
                  </div>
                </font></span></div>
            <div class="HOEnZb">
              <div class="h5">
                <div class="gmail_extra"><br>
                  <br>
                  <div class="gmail_quote">2013/8/8 Sergey Bylokhov <span
                      dir="ltr">&lt;<a moz-do-not-send="true"
                        href="mailto:Sergey.Bylokhov@oracle.com"
                        target="_blank">Sergey.Bylokhov@oracle.com</a>&gt;</span><br>
                    <blockquote class="gmail_quote" style="margin:0 0 0
                      .8ex;border-left:1px #ccc solid;padding-left:1ex">
                      <div text="#000000" bgcolor="#FFFFFF">
                        <div>Hi, Konstantin.<br>
                          A few comments about the fix.<br>
                          &lt;code&gt;&lt;em&gt;Foo&lt;/em&gt;Listener&lt;/code&gt;
                          in a few places was changed to the {@code
                          &lt;em&gt;Foo&lt;/em&gt;Listener} but it is
                          not equivalent.<br>
                          Also I suggest to remove one of "and" from the
                          "and and" in the line 2887, because you change
                          this line anyway.
                          <div><br>
                            <br>
                            On 08.08.2013 16:54, Konstantin Perikov
                            wrote:<br>
                          </div>
                        </div>
                        <div>
                          <blockquote type="cite">
                            <div dir="ltr">Okay. I keep comment about
                              synchronization for the "type" field and
                              return comment style for transient field.
                              <div><br>
                              </div>
                              <div>Is Google Drive better place for it?
                                (that's why I ask yesterday about "good"
                                place for webrev)</div>
                              <div><a moz-do-not-send="true"
href="https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&amp;usp=sharing"
                                  target="_blank">https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&amp;usp=sharing</a><br>
                              </div>
                            </div>
                          </blockquote>
                        </div>
                        No, it is not better, atleast i don't understand
                        how to view index.html in this case or download
                        all files at once.
                        <div><br>
                          <blockquote type="cite">
                            <div dir="ltr"><br>
                            </div>
                            <div class="gmail_extra"><br>
                              <br>
                              <div class="gmail_quote">2013/8/8 Artem
                                Ananiev <span dir="ltr">&lt;<a
                                    moz-do-not-send="true"
                                    href="mailto:artem.ananiev@oracle.com"
                                    target="_blank">artem.ananiev@oracle.com</a>&gt;</span><br>
                                <blockquote class="gmail_quote"
                                  style="margin:0 0 0
                                  .8ex;border-left:1px #ccc
                                  solid;padding-left:1ex">Hi,
                                  Konstantin,<br>
                                  <br>
                                  I looked through the changes, which
                                  mostly replacements
                                  &lt;code&gt;&lt;/code&gt; with
                                  {@code}. This part of the fix looks
                                  fine.<br>
                                  <br>
                                  Changing /* to /** for the "isInShow"
                                  field doesn't make sense, as this
                                  field is transient and is not
                                  serialized anyway. However, it doesn't
                                  hurt as well.<br>
                                  <br>
                                  Please, keep comment about
                                  synchronization for the "type" field.
                                  It's a hint for developers, that this
                                  field should only be accessed or
                                  modified under the object lock. I
                                  agree, JavaDoc is not the best place
                                  for such hints, but I don't see any
                                  better solutions.<br>
                                  <br>
                                  Non-technical comments:<br>
                                  <br>
                                  1. Please, provide a direct link to
                                  webrev, so people can click and see
                                  the changes. Downloading archives is
                                  not as convenient (and in this
                                  particular case just impossible, as
                                  Yandex.Disk is in Russian, people just
                                  won't be able to read the "Download"
                                  button).<br>
                                  <br>
                                  2. Please, wait for at least one more
                                  person to have reviewed this fix.<br>
                                  <br>
                                  Thanks,<br>
                                  <br>
                                  Artem<br>
                                  <br>
                                  On 8/8/2013 2:20 PM, Konstantin
                                  Perikov wrote:<br>
                                  <blockquote class="gmail_quote"
                                    style="margin:0 0 0
                                    .8ex;border-left:1px #ccc
                                    solid;padding-left:1ex"> Hi, AWT
                                    team,<br>
                                    <br>
                                    Could you please review the fix for
                                    the following bug:<br>
                                    <br>
                                    *7027045: &nbsp;: (doc)
                                    java/awt/Window.java has several
                                    typos in javadoc*<br>
                                    <br>
                                    Fix for version OpenJDK8. Also, I
                                    fix some &lt;code&gt;&lt;/code&gt;
                                    stuff and change it for {@code }<br>
                                    <br>
                                    The webrev is available here:<br>
                                    <br>
                                    <a moz-do-not-send="true"
                                      href="http://yadi.sk/d/KHB0hBlA7gkke"
                                      target="_blank">http://yadi.sk/d/KHB0hBlA7gkke</a><br>
                                    <br>
                                    <br>
                                    P.S. Since, I'm newcomer, I don't
                                    have rights to push, so I need a
                                    sponsor. Who could help me?<br>
                                    <br>
                                    Thanks,<br>
                                    <br>
                                    Konstantin<br>
                                    <br>
                                  </blockquote>
                                </blockquote>
                              </div>
                              <br>
                            </div>
                          </blockquote>
                          <br>
                          <br>
                        </div>
                        <span><font color="#888888">
                            <pre cols="72">-- 
Best regards, Sergey. </pre>
                          </font></span></div>
                    </blockquote>
                  </div>
                  <br>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
  </body>
</html>