<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Hi Artem,<br>
      <br>
      I'm Ok with the fix, provided that LWWindowPeer.setVisibleImpl()
      is called on EDT for applets (if I'm not mistaken). Otherwise, we
      still have a client method (getTarget().isFocusableWindow())
      called on the toolkit thread, which is generally no good.<br>
      <br>
      Regards,<br>
      Anton.<br>
      <br>
      On 24.07.2014 10:25, artem malinko wrote:<br>
    </div>
    <blockquote cite="mid:53D0A6BC.1060902@oracle.com" type="cite">
      <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
      Thank you, Petr.<br>
      <br>
      Could anyone else review the fix, please?<br>
      <br>
      <div class="moz-cite-prefix">On 7/23/2014 10:30 PM, Petr Pchelko
        wrote:<br>
      </div>
      <blockquote
        cite="mid:28B1A970-DBDE-4C63-A519-04A791C22EF7@oracle.com"
        type="cite">
        <meta http-equiv="Content-Type" content="text/html;
          charset=UTF-8">
        Hello, Artem.
        <div><br>
        </div>
        <div>The new version (it’s .00 for some reason) looks good.</div>
        <div><br>
        </div>
        <div>With best regards. Petr.</div>
        <div><br>
          <div>
            <blockquote type="cite">
              <div>On Jul 23, 2014, at 6:55 PM, artem malinko <<a
                  moz-do-not-send="true"
                  href="mailto:artem.malinko@oracle.com">artem.malinko@oracle.com</a>>

                wrote:</div>
              <br class="Apple-interchange-newline">
              <div>
                <meta content="text/html; charset=UTF-8"
                  http-equiv="Content-Type">
                <div text="#000000" bgcolor="#FFFFFF"> Hi, Petr. I ran
                  focus regression tests and jck tests on awt. For fixed
                  jdk results is the same. Except my new test, of course
                  which is not passed on not fixed jdk:) And also I
                  fixed issues in test. New webrev:<br>
                  <a moz-do-not-send="true"
                    class="moz-txt-link-freetext"
                    href="http://cr.openjdk.java.net/%7Ebae/8047288/9/webrev.00/">http://cr.openjdk.java.net/~bae/8047288/9/webrev.00/</a><br>
                  <br>
                  <div class="moz-cite-prefix">On 7/22/2014 8:23 PM,
                    Petr Pchelko wrote:<br>
                  </div>
                  <blockquote
                    cite="mid:D741BDAC-3A69-46D1-A565-53360414E406@oracle.com"
                    type="cite">
                    <meta http-equiv="Content-Type" content="text/html;
                      charset=UTF-8">
                    Hello, Artem.
                    <div><br>
                    </div>
                    <div>A couple of comments:</div>
                    <div>1. LWWindowPeer: 268 - please remove an empty
                      line.</div>
                    <div>2. LWWIndowPeer. isTargetFocusable - the method
                      is not needed at all. </div>
                    <div>3. I’m concerned about the test. Do you really
                      need the close button? </div>
                    <div>4. frame and window variables are set from main
                      thread and read from EDT. They should be declared
                      volatile.</div>
                    <div><br>
                    </div>
                    <div>Also please run all focus regression and JCK
                      tests, because this area is very sensitive.</div>
                    <div><br>
                    </div>
                    <div>With best regards. Petr.</div>
                    <div><br>
                      <div>
                        <blockquote type="cite">
                          <div>On Jul 22, 2014, at 8:04 PM, artem
                            malinko <<a moz-do-not-send="true"
                              href="mailto:artem.malinko@oracle.com">artem.malinko@oracle.com</a>>


                            wrote:</div>
                          <br class="Apple-interchange-newline">
                          <div>
                            <meta http-equiv="content-type"
                              content="text/html; charset=UTF-8">
                            <div text="#000000" bgcolor="#FFFFFF">
                              Hello, AWT Team. <br>
                              <br>
                              Please review a fix for the issue: <br>
                              <a moz-do-not-send="true"
                                class="moz-txt-link-freetext"
                                href="https://bugs.openjdk.java.net/browse/JDK-8040076">https://bugs.openjdk.java.net/browse/JDK-8047288</a><br>
                              The fix is available at: <br>
                              <a moz-do-not-send="true"
                                href="http://cr.openjdk.java.net/%7Emcherkas/artem/8047288/webrev.01/">http://cr.openjdk.java.net/~mcherkas/artem/8047288/webrev.01/</a><br>
                              <br>
                              <span style="font-family: sans-serif;
                                font-size: 13px; font-style: normal;
                                font-variant: normal; font-weight:
                                normal; letter-spacing: normal;
                                line-height: 17.000099182128906px;
                                orphans: auto; text-align: start;
                                text-indent: 0px; text-transform: none;
                                white-space: normal; widows: auto;
                                word-spacing: 0px;
                                -webkit-text-stroke-width: 0px; float:
                                none; background-color: rgb(240, 240,
                                240); display: inline !important;">Window.isFocusableWindow()

                                could lead to deadlock if it is invoked
                                on AppKit thread. Fix caches result of </span><span
                                style="font-family: sans-serif;
                                font-size: 13px; font-style: normal;
                                font-variant: normal; font-weight:
                                normal; letter-spacing: normal;
                                line-height: 17.000099182128906px;
                                orphans: auto; text-align: start;
                                text-indent: 0px; text-transform: none;
                                white-space: normal; widows: auto;
                                word-spacing: 0px;
                                -webkit-text-stroke-width: 0px; float:
                                none; background-color: rgb(240, 240,
                                240); display: inline !important;">Window.isFocusableWindow()

                                on a peer level and method is not
                                invoked on AppkitThread.</span><br>
                              <br>
                              Thank you. </div>
                          </div>
                        </blockquote>
                      </div>
                      <br>
                    </div>
                  </blockquote>
                  <br>
                </div>
              </div>
            </blockquote>
          </div>
          <br>
        </div>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>