<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Yes, please, wait a second review.<br>
      <br>
      On 10.11.2014 17:04, Denis S. Fokin wrote:<br>
    </div>
    <blockquote
      cite="mid:4E9BD468-BB2B-4299-ABE7-A332C77BB68A@gmail.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      <div class="">Hi Sergey,</div>
      <div class=""><br class="">
      </div>
      <div class="">Thank you for the review. Do I need another reviewer
        to push?</div>
      <div class=""><br class="">
      </div>
      <div class="">Thank you,</div>
      <div class="">            Denis.</div>
      <br class="">
      <div>
        <blockquote type="cite" class="">
          <div class="">On 10 Nov 2014, at 15:12, Sergey Bylokhov <<a
              moz-do-not-send="true"
              href="mailto:Sergey.Bylokhov@oracle.com" class="">Sergey.Bylokhov@oracle.com</a>>
            wrote:</div>
          <br class="Apple-interchange-newline">
          <div class="">
            <meta content="text/html; charset=windows-1252"
              http-equiv="Content-Type" class="">
            <div bgcolor="#FFFFFF" text="#000000" class="">
              <div class="moz-cite-prefix">Hi, Denis.<br class="">
                The fix looks fine.<br class="">
                Updated webrev for the current jdk layout:<br class="">
                <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/denis/8057788/webrev.00">http://cr.openjdk.java.net/~serb/denis/8057788/webrev.00</a><br
                  class="">
                <br class="">
                On 08.09.2014 16:12, Denis Fokin wrote:<br class="">
              </div>
              <blockquote
                cite="mid:D7041F2F-419C-42EB-9AFD-1E4381F43237@gmail.com"
                type="cite" class="">
                <meta http-equiv="Content-Type" content="text/html;
                  charset=windows-1252" class="">
                <div class="">Hi AWT team,</div>
                <div class=""><br class="">
                </div>
                <div class="">I know a lot of people who miss “pinch to
                  zoom” feature in Java.</div>
                <div class=""><br class="">
                </div>
                <div class="">It is implemented for jdk 6 but the
                  functionality does not work in jdk 7 and latter
                  releases.</div>
                <div class=""><br class="">
                </div>
                <div class="">Gesture related callbacks were mistakenly
                  placed in NSWindowDelegate instead of NSWindow.</div>
                <div class=""><br class="">
                </div>
                <div class="">Please take a look at this simple move
                  refactoring.</div>
                <div class=""><br class="">
                </div>
                <a moz-do-not-send="true"
                  href="http://web-dot.ru/openjdk/pinch-to-zoom-fix/webrev.00/index.html"
                  class="">http://web-dot.ru/openjdk/pinch-to-zoom-fix/webrev.00/index.html</a>
                <div class=""><br class="">
                </div>
                <div class="">Actually, I would eliminate the macros
                   AWT_NS_WINDOW_IMPLEMENTATION. <span
                    style="white-space: pre-wrap;" class="">It is
                    difficult to debug. </span>Looks like it was added
                  to avoid code duplication but if <span
                    style="white-space: pre-wrap;" class="">AWTWindow_Normal</span> and <span
                    style="white-space: pre-wrap;" class="">AWTWindow_Panel
                    implementations are the same we should reuse the
                    same class. </span></div>
                <div class=""><span style="white-space: pre-wrap;"
                    class=""><br class="">
                  </span></div>
                <div class=""><span style="white-space: pre-wrap;"
                    class="">I have submitted a bug about the issue but
                    it is not visible yet.</span></div>
                <div class=""><span style="white-space: pre-wrap;"
                    class=""><br class="">
                  </span></div>
                <div class=""><span style="white-space: pre-wrap;"
                    class="">Thank you,</span></div>
                <div class=""><span style="white-space: pre-wrap;"
                    class="">  Denis.</span></div>
              </blockquote>
              <br class="">
              <br class="">
              <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
            </div>
          </div>
        </blockquote>
      </div>
      <br class="">
    </blockquote>
    <br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
  </body>
</html>