<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Hi, Semyon.<br>
      The fix looks good.<br>
      <br>
      On 22.05.15 17:51, Semyon Sadetsky wrote:<br>
    </div>
    <blockquote cite="mid:555F427E.1080404@oracle.com" type="cite">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      Sergey,<br>
      <br>
      Thank you for the review.<br>
      the improved version:  <a moz-do-not-send="true"
        class="moz-txt-link-freetext"
        href="http://cr.openjdk.java.net/%7Essadetsky/8003399/webrev.03/">http://cr.openjdk.java.net/~ssadetsky/8003399/webrev.03/</a><br>
      <br>
      --Semyon<br>
      <div class="moz-cite-prefix"><br>
        On 5/22/2015 2:59 PM, Sergey Bylokhov wrote:<br>
      </div>
      <blockquote cite="mid:555F1A17.9060708@oracle.com" type="cite">
        <meta content="text/html; charset=utf-8"
          http-equiv="Content-Type">
        <div class="moz-cite-prefix">Hi, Semyon.<br>
          A few notes:<br>
           - You need to check all possible exceptions and nulls in the
          native part of the fix(for example when you call
          JNU_NewStringPlatform). It can be double checked using
          parfait.<br>
           - Please send a request about this comment "this is a temp
          fix until java.io starts support Libraries" to the core-lib
          alias. If it will not be supported will mean that out fix is
          not temporary.<br>
           - Small issues in using spaces in "if("<br>
          <br>
          On 21.05.15 18:15, Anton Tarasov wrote:<br>
        </div>
        <blockquote cite="mid:555DF67A.7090809@oracle.com" type="cite">
          <meta content="text/html; charset=utf-8"
            http-equiv="Content-Type">
          So, it looks fine to me now. Thanks.<br>
          <br>
          Anton.<br>
          <br>
          <div class="moz-cite-prefix">On 20/05/15 17:12, Semyon
            Sadetsky wrote:<br>
          </div>
          <blockquote cite="mid:555C9639.1080305@oracle.com" type="cite">
            <meta content="text/html; charset=utf-8"
              http-equiv="Content-Type">
            Hi Anton,<br>
            <br>
            <a moz-do-not-send="true" class="moz-txt-link-freetext"
              href="http://cr.openjdk.java.net/%7Essadetsky/8003399/webrev.02/">http://cr.openjdk.java.net/~ssadetsky/8003399/webrev.02/</a><br>
            I have added the macro you requested.<br>
            <br>
            --Semyon<br>
            <br>
            <div class="moz-cite-prefix">On 5/20/2015 3:34 PM, Anton V.
              Tarasov wrote:<br>
            </div>
            <blockquote cite="mid:555C7F60.5040407@oracle.com"
              type="cite">
              <meta content="text/html; charset=utf-8"
                http-equiv="Content-Type">
              <div class="moz-cite-prefix">Hi Semyon,<br>
                <br>
                I'm fine with it, but don't you want to define a simple
                macro for this:<br>
                <br>
                <pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="new" style="color: blue; font-weight: normal;">+    jfieldID field_guid = env->GetFieldID(cl, "guid", "Ljava/lang/String;");</span>
<span class="new" style="color: blue; font-weight: normal;">+    DASSERT(field_guid != NULL);</span>
<span class="new" style="color: blue; font-weight: normal;">+    CHECK_NULL_RETURN(field_guid, NULL);</span>
</pre>
                <br>
                To call it like:<br>
                <br>
                DEFINE_FIELD_ID(field_guid, cl, "guid",
                "Ljava/lang/String;");<br>
                <br>
                You would reduce the code a lot and make it more
                readable.<br>
                <br>
                Regards,<br>
                Anton.<br>
                <br>
                On 19.05.2015 18:45, Semyon Sadetsky wrote:<br>
              </div>
              <blockquote cite="mid:555B5A9F.3090207@oracle.com"
                type="cite">Hi Anton, <br>
                <br>
                here is an updated version: <a moz-do-not-send="true"
                  class="moz-txt-link-freetext"
                  href="http://cr.openjdk.java.net/%7Essadetsky/8003399/webrev.01/">http://cr.openjdk.java.net/~ssadetsky/8003399/webrev.01/</a>
                <br>
                <br>
                --Semyon <br>
                <br>
                On 5/8/2015 5:01 PM, Semyon Sadetsky wrote: <br>
                <blockquote type="cite"> <br>
                  On 5/8/2015 3:45 PM, Sergey Bylokhov wrote: <br>
                  <blockquote type="cite">On 07.05.15 15:29, Semyon
                    Sadetsky wrote: <br>
                    <blockquote type="cite">Hi Sergey, <br>
                      <br>
                      Yes, after the fix filedialog produces usual
                      filesystem paths for libraries which are readable
                      for java.io. <br>
                    </blockquote>
                    Just to clarify: after the fix, both Open and Save
                    dialog works? <br>
                  </blockquote>
                  Open file in library was not a problem, because an
                  exicting file has real FS path already. <br>
                  <br>
                  <blockquote type="cite">
                    <blockquote type="cite">But there are no possibility
                      to reference files in libraries directly using new
                      File(<library link>). <br>
                      <br>
                      --Semyon <br>
                      <br>
                      On 5/7/2015 11:26 AM, Sergey Bylokhov wrote: <br>
                      <blockquote type="cite">Hi, Semyon. <br>
                        Can you please raise the supportness of this in
                        the java.io on the core-libs alias. <br>
                        Does the open filedialog will work after the
                        fix? <br>
                        <br>
                        On 07.05.15 11:14, Semyon Sadetsky wrote: <br>
                        <blockquote type="cite">Hello, <br>
                          <br>
                          Please review fix for JDK9. <br>
                          webrev: <a moz-do-not-send="true"
                            class="moz-txt-link-freetext"
                            href="http://cr.openjdk.java.net/%7Essadetsky/8003399/webrev.00/">http://cr.openjdk.java.net/~ssadetsky/8003399/webrev.00/</a>
                          <br>
                          bug: <a moz-do-not-send="true"
                            class="moz-txt-link-freetext"
                            href="https://bugs.openjdk.java.net/browse/JDK-8003399">https://bugs.openjdk.java.net/browse/JDK-8003399</a>
                          <br>
                          <br>
                          ***THE ROOT CAUSE <br>
                          JDK uses legacy WINAPI special folders calls
                          while MS introduced a new interfaces
                          IKnownFolder and IShellLibrary to manage
                          special folder locations and the new Libraries
                          functionality in Windows 7 is not backward
                          compatible with old special folders CSIDL. <br>
                          <br>
                          ***SOLUTION <br>
                          Since it is too expensive to migrate AWT shell
                          to the new interfaces and still they are not
                          supported in java.io the solution is to map
                          virtual folder PIDL to the Known Folder GUID
                          and replace libraries links with the default
                          library save location. Thus the File save
                          dialog will be able to work with any Libraries
                          registered in the system (Windows Libraries
                          concept assumes that Libraries can be added
                          arbitrary). <br>
                          The resulting code should be compatible with
                          older Windows versions because the new COM
                          interfaces are called only if they are
                          available and a Libraries link has been
                          actually requested. <br>
                          <br>
                          ***TESTING <br>
                          A test scenario is added to check that all
                          available Libraries links are converted into
                          filesystem paths. <br>
                          <br>
                          --Semyon <br>
                          <br>
                        </blockquote>
                        <br>
                        <br>
                      </blockquote>
                      <br>
                    </blockquote>
                    <br>
                    <br>
                  </blockquote>
                  <br>
                </blockquote>
                <br>
              </blockquote>
              <br>
            </blockquote>
            <br>
          </blockquote>
          <br>
        </blockquote>
        <br>
        <br>
        <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
      </blockquote>
      <br>
    </blockquote>
    <br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
  </body>
</html>