<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Hi, Anton.<br>
      It is unclear from the documentation, what happen when one of the
      replaceStart/replaceEnd will contain correct range and another
      will be -1?<br>
      Plus since this is an RFE, which adds a new functionality, I
      suggest to write a new tests for it.<br>
      <br>
      <br>
      On 12.04.15 13:57, Alexander Zuev wrote:<br>
    </div>
    <blockquote
      cite="mid:F8F4260D-F0DC-4F23-9D52-0C9FF49EC590@oracle.com"
      type="cite">
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <div>Looks fine to me.<br>
        <br>
        <span style="font-size: 13pt;">/Alex</span></div>
      <div><br>
        On 10 Apr 2015, at 15:12, Anton Nashatyrev <<a
          moz-do-not-send="true"
          href="mailto:anton.nashatyrev@oracle.com">anton.nashatyrev@oracle.com</a>>
        wrote:<br>
        <br>
      </div>
      <blockquote type="cite">
        <div><span>Hello,</span><br>
          <span></span><br>
          <span>    any volunteers to review?</span><br>
          <span></span><br>
          <span>Thanks!</span><br>
          <span>Anton.</span><br>
          <span></span><br>
          <span>On 01.04.2015 18:43, Anton Nashatyrev wrote:</span><br>
          <blockquote type="cite"><span>Hello,</span><br>
          </blockquote>
          <blockquote type="cite"><span>    could you please review the
              following IM API extension proposal:</span><br>
          </blockquote>
          <blockquote type="cite"><span></span><br>
          </blockquote>
          <blockquote type="cite"><span>fix: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eanashaty/8074882/9/webrev.00/">http://cr.openjdk.java.net/~anashaty/8074882/9/webrev.00/</a>
              <<a moz-do-not-send="true"
                href="http://cr.openjdk.java.net/%7Eanashaty/8074882/9/webrev.00/">http://cr.openjdk.java.net/%7Eanashaty/8074882/9/webrev.00/</a>></span><br>
          </blockquote>
          <blockquote type="cite"><span>bug: <a moz-do-not-send="true"
                href="https://bugs.openjdk.java.net/browse/JDK-8074882">https://bugs.openjdk.java.net/browse/JDK-8074882</a></span><br>
          </blockquote>
          <blockquote type="cite"><span></span><br>
          </blockquote>
          <blockquote type="cite"><span>    Problem: Press-and-hold Mac
              IM (when an accented char variant could be selected)
              couldn't be supported by the components other than
              TextComponent</span><br>
          </blockquote>
          <blockquote type="cite"><span></span><br>
          </blockquote>
          <blockquote type="cite"><span>    MacOS Cocoa Input Method API
              supports the 'replacement range' parameter in its
              callbacks indicating what range of the committed text of
              the document should be replaced with the new composed
              text. In case of press-and-hold IM this parameter always
              indicates the previous char.</span><br>
          </blockquote>
          <blockquote type="cite"><span></span><br>
          </blockquote>
          <blockquote type="cite"><span>    Fix: extends the IM API to
              support the 'replacement range'. The fix includes the new
              API, its implementation and adoption to the existing
              JTextComponent, the changes to be made in the MacOS code
              to conform the new API.</span><br>
          </blockquote>
          <blockquote type="cite"><span>    The sample custom Java IM is
              attached to the JBS report to demonstrate the new API
              usage and test the implementation.</span><br>
          </blockquote>
          <blockquote type="cite"><span></span><br>
          </blockquote>
          <blockquote type="cite"><span>Thanks!</span><br>
          </blockquote>
          <blockquote type="cite"><span>Anton.</span><br>
          </blockquote>
          <span></span><br>
        </div>
      </blockquote>
    </blockquote>
    <br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
  </body>
</html>