<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Looks ok to me<br>
    <br>
    Regards<br>
    Prasanta<br>
    <div class="moz-cite-prefix">On 11/20/2015 5:19 PM, Ambarish Rapte
      wrote:<br>
    </div>
    <blockquote cite="mid:ee61c74c-d751-4fa1-b8c8-c6a4ce03e254@default"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      <meta name="Generator" content="Microsoft Word 12 (filtered
        medium)">
      <style><!--
/* Font Definitions */
@font-face
        {font-family:Wingdings;
        panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:Tahoma;
        panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        margin-bottom:.0001pt;
        font-size:11.0pt;
        font-family:"Calibri","sans-serif";
        color:black;}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:blue;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:purple;
        text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
        {mso-style-priority:99;
        mso-style-link:"Balloon Text Char";
        margin:0in;
        margin-bottom:.0001pt;
        font-size:8.0pt;
        font-family:"Tahoma","sans-serif";
        color:black;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
        {mso-style-priority:34;
        margin-top:0in;
        margin-right:0in;
        margin-bottom:0in;
        margin-left:.5in;
        margin-bottom:.0001pt;
        font-size:11.0pt;
        font-family:"Calibri","sans-serif";
        color:black;}
span.EmailStyle18
        {mso-style-type:personal;
        font-family:"Calibri","sans-serif";
        color:windowtext;}
span.EmailStyle19
        {mso-style-type:personal;
        font-family:"Calibri","sans-serif";
        color:#1F497D;}
span.EmailStyle20
        {mso-style-type:personal-reply;
        font-family:"Calibri","sans-serif";
        color:#1F497D;}
span.BalloonTextChar
        {mso-style-name:"Balloon Text Char";
        mso-style-priority:99;
        mso-style-link:"Balloon Text";
        font-family:"Tahoma","sans-serif";
        color:black;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-size:10.0pt;}
@page WordSection1
        {size:8.5in 11.0in;
        margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
        {page:WordSection1;}
/* List Definitions */
@list l0
        {mso-list-id:699091139;
        mso-list-type:hybrid;
        mso-list-template-ids:-1251953962 -1175008136 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
        {mso-level-tab-stop:none;
        mso-level-number-position:left;
        margin-left:.75in;
        text-indent:-.25in;}
@list l0:level2
        {mso-level-tab-stop:1.0in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level3
        {mso-level-tab-stop:1.5in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level4
        {mso-level-tab-stop:2.0in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level5
        {mso-level-tab-stop:2.5in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level6
        {mso-level-tab-stop:3.0in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level7
        {mso-level-tab-stop:3.5in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level8
        {mso-level-tab-stop:4.0in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level9
        {mso-level-tab-stop:4.5in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1
        {mso-list-id:1231421503;
        mso-list-type:hybrid;
        mso-list-template-ids:-1377910040 -124908778 67698691 67698693 67698689 67698691 67698693 67698689 67698691 67698693;}
@list l1:level1
        {mso-level-number-format:bullet;
        mso-level-text:\F0F0;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        margin-left:1.0in;
        text-indent:-.25in;
        font-family:Wingdings;
        mso-fareast-font-family:Calibri;
        mso-bidi-font-family:"Times New Roman";}
@list l1:level2
        {mso-level-tab-stop:1.0in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level3
        {mso-level-tab-stop:1.5in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level4
        {mso-level-tab-stop:2.0in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level5
        {mso-level-tab-stop:2.5in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level6
        {mso-level-tab-stop:3.0in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level7
        {mso-level-tab-stop:3.5in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level8
        {mso-level-tab-stop:4.0in;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level9
        {mso-level-tab-stop:4.5in;
        mso-level-number-position:left;
        text-indent:-.25in;}
ol
        {margin-bottom:0in;}
ul
        {margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
      <div class="WordSection1">
        <p class="MsoNormal"><span style="color:#1F497D">Hi ,<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D"><o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D">
            Updating the patch to use <i>(peer != null) { } </i>instead
            of <i>(peer == null) retrun;<o:p></o:p></i></span></p>
        <p class="MsoNormal"><span style="color:#1F497D">
            Please take a look<i><o:p></o:p></i></span></p>
        <p class="MsoNormal" style="text-indent:.5in"><i><span
              style="color:#1F497D"><a moz-do-not-send="true"
                href="http://cr.openjdk.java.net/%7Earapte/8060137/webrev.02/">http://cr.openjdk.java.net/~arapte/8060137/webrev.02/</a><o:p></o:p></span></i></p>
        <p class="MsoNormal" style="text-indent:.5in"><i><span
              style="color:#1F497D"><o:p></o:p></span></i></p>
        <p class="MsoNormal" style="text-indent:.5in"><i><span
              style="color:#1F497D"><o:p></o:p></span></i></p>
        <p class="MsoNormal"><span style="color:#1F497D">Many Thanks,<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D">Ambarish<o:p></o:p></span></p>
        <p class="MsoNormal" style="margin-left:.5in;text-indent:.5in"><i><span
              style="color:#1F497D"><o:p></o:p></span></i></p>
        <p class="MsoNormal"><span style="color:#1F497D"><o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D"><o:p></o:p></span></p>
        <div>
          <div style="border:none;border-top:solid #B5C4DF
            1.0pt;padding:3.0pt 0in 0in 0in">
            <p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
                Ambarish Rapte <br>
                <b>Sent:</b> Thursday, November 19, 2015 9:19 PM<br>
                <b>To:</b> Semyon Sadetsky; Prasanta Sadhukhan;
                <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
                <b>Subject:</b> RE: Review request for 8060137: Removing
                Text from TextField / TextArea is not possible after
                typing<o:p></o:p></span></p>
          </div>
        </div>
        <p class="MsoNormal"><o:p></o:p></p>
        <p class="MsoNormal"><span style="color:#1F497D">Hi Semyon,<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D"><o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D">
            Please review the updated patch as per the review comments,<o:p></o:p></span></p>
        <p class="MsoNormal" style="text-indent:.5in"><a
            moz-do-not-send="true"
            href="http://cr.openjdk.java.net/%7Earapte/8060137/webrev.01/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~arapte/8060137/webrev.01/">http://cr.openjdk.java.net/~arapte/8060137/webrev.01/</a></a><o:p></o:p></p>
        <p class="MsoNormal" style="text-indent:.5in"><o:p></o:p></p>
        <p class="MsoNormal"><o:p></o:p></p>
        <p class="MsoNormal">Many Thanks<o:p></o:p></p>
        <p class="MsoNormal">Ambarish<o:p></o:p></p>
        <p class="MsoNormal" style="text-indent:.5in"><span
            style="color:#1F497D"><o:p></o:p></span></p>
        <div>
          <div style="border:none;border-top:solid #B5C4DF
            1.0pt;padding:3.0pt 0in 0in 0in">
            <p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
                Semyon Sadetsky <br>
                <b>Sent:</b> Thursday, November 19, 2015 2:54 PM<br>
                <b>To:</b> Ambarish Rapte; Prasanta Sadhukhan; <a
                  moz-do-not-send="true"
                  href="mailto:awt-dev@openjdk.java.net"><a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a></a><br>
                <b>Subject:</b> Re: Review request for 8060137: Removing
                Text from TextField / TextArea is not possible after
                typing<o:p></o:p></span></p>
          </div>
        </div>
        <p class="MsoNormal"><o:p></o:p></p>
        <p class="MsoNormal" style="margin-bottom:12.0pt">Hi Prasanta,<br>
          <br>
          Could you rework the fix a bit?<br>
          When peer != null is false there is no need to continue the
          method execution. And then second peer is null test is not
          needed.<br>
          <br>
          --Semyon<o:p></o:p></p>
        <div>
          <p class="MsoNormal">On 11/16/2015 1:24 PM, Ambarish Rapte
            wrote:<o:p></o:p></p>
        </div>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p class="MsoNormal">Dear All,<o:p></o:p></p>
          <p class="MsoNormal"><o:p></o:p></p>
          <p class="MsoNormal"> Please review the fix for
            JDK9,<o:p></o:p></p>
          <p class="MsoNormal"> Bug: <a
              moz-do-not-send="true"
              href="https://bugs.openjdk.java.net/browse/JDK-8060137"><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8060137">https://bugs.openjdk.java.net/browse/JDK-8060137</a></a><o:p></o:p></p>
          <p class="MsoNormal"> Webrev: <a
              moz-do-not-send="true"
              href="http://cr.openjdk.java.net/%7Earapte/8060137/webrev.00/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~arapte/8060137/webrev.00/">http://cr.openjdk.java.net/~arapte/8060137/webrev.00/</a></a><o:p></o:p></p>
          <p class="MsoNormal"><o:p></o:p></p>
          <p class="MsoNormal">Issue:<o:p></o:p></p>
          <p class="MsoListParagraph"
            style="margin-left:.75in;text-indent:-.25in;mso-list:l0
            level1 lfo2"><!--[if !supportLists]--><span
              style="mso-list:Ignore">1.<span style="font:7.0pt
                "Times New Roman""> </span></span><!--[endif]-->Type
            any character in <i>TextArea</i> or <i>TextField</i><o:p></o:p></p>
          <p class="MsoListParagraph"
            style="margin-left:.75in;text-indent:-.25in;mso-list:l0
            level1 lfo2"><!--[if !supportLists]--><span
              style="mso-list:Ignore">2.<span style="font:7.0pt
                "Times New Roman""> </span></span><!--[endif]-->Call
            <i>setText(null)</i><o:p></o:p></p>
          <p class="MsoListParagraph"
            style="margin-left:1.0in;text-indent:-.25in;mso-list:l1
            level1 lfo4"><!--[if !supportLists]--><span
              style="font-family:Wingdings"><span
                style="mso-list:Ignore"><span style="font:7.0pt
                  "Times New Roman""> </span></span></span><!--[endif]-->The
            text in <i>TextArea</i> or <i>TextField</i> does not get
            set to null.<o:p></o:p></p>
          <p class="MsoNormal"><o:p></o:p></p>
          <p class="MsoNormal">Cause:<o:p></o:p></p>
          <p class="MsoNormal"> <i>TextComponent::setText()</i>,
            verifies <i>TextComponent::text</i> variable for null value
            in <i>TextComponent::setText()</i>.<o:p></o:p></p>
          <p class="MsoNormal"> But text is a java
            variable which may not have latest value of actual at peer
            side.<o:p></o:p></p>
          <p class="MsoNormal"><o:p></o:p></p>
          <p class="MsoNormal">Fix:<o:p></o:p></p>
          <p class="MsoNormal"> Fetch the latest value
            from <i>peer.getText(),</i> before validating for null
            value.<o:p></o:p></p>
          <p class="MsoNormal"> Also updated tests for <i>TextArea</i>
            & <i>TextField</i> with the patch.<o:p></o:p></p>
          <p class="MsoNormal"><o:p></o:p></p>
          <p class="MsoNormal"><o:p></o:p></p>
          <p class="MsoNormal">Many Thanks,<o:p></o:p></p>
          <p class="MsoNormal">Ambarish<o:p></o:p></p>
          <p class="MsoNormal"><o:p></o:p></p>
        </blockquote>
        <p class="MsoNormal"><span
            style="font-size:12.0pt;font-family:"Times New
            Roman","serif""><o:p></o:p></span></p>
      </div>
    </blockquote>
    <br>
  </body>
</html>