<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class="">Hi Semyon,</font></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class=""><br class=""></font></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class="">Could you please push the patch to JDK9 with the following details:</font></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class=""><br class=""></font></div><div style="line-height: 16px;" class=""><a href="http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/" class="" style="line-height: normal;"><font face="Menlo" size="2" color="#1a0a53" class="">http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/</font></a></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class=""><br class=""></font></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class="">8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac</font></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class="">Reviewed-by: <span style="line-height: normal;" class="">psadhukhan, </span><span style="line-height: normal;" class="">prr</span></font></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class="">username: mhalder</font></div></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class=""><br class=""></font></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class="">Thanks,</font></div><div style="line-height: 16px;" class=""><font face="Menlo" size="2" color="#1a0a53" class="">Manajit</font></div><br class=""><div><blockquote type="cite" class=""><div class="">On 03-May-2016, at 10:57 pm, Phil Race <<a href="mailto:philip.race@oracle.com" class="">philip.race@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
  
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type" class="">
  
  <div bgcolor="#FFFFFF" text="#000000" class="">
    <div class="moz-cite-prefix">+1<br class="">
      <br class="">
      -phil.<br class="">
      <br class="">
      On 04/19/2016 01:40 AM, prasanta sadhukhan wrote:<br class="">
    </div>
    <blockquote cite="mid:5715EF0C.6070805@oracle.com" type="cite" class="">
      <meta content="text/html; charset=UTF-8" http-equiv="Content-Type" class="">
      Looks ok to me.<br class="">
      <br class="">
      Regards<br class="">
      Prasanta<br class="">
      <div class="moz-cite-prefix">On 4/19/2016 1:25 PM, Manajit Halder
        wrote:<br class="">
      </div>
      <blockquote cite="mid:8CDCEF1E-0030-4A0C-9A94-287C28A70B15@oracle.com" type="cite" class="">
        <meta http-equiv="Content-Type" content="text/html;
          charset=UTF-8" class="">
        <font class="" size="2" face="Menlo">Hi Prasanta,</font>
        <div class=""><font class="" size="2" face="Menlo"><br class="">
          </font></div>
        <div class=""><font class="" size="2" face="Menlo">Thank you for
            the review comments. Please review the updated webrev.</font></div>
        <div class=""><font class="" size="2" face="Menlo"><br class="">
          </font></div>
        <div class=""><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Emhalder/8137137/webrev.02/" class=""><font class="" size="2" face="Menlo">http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/</font></a></div>
        <div class=""><font class="" size="2" face="Menlo"><br class="">
          </font></div>
        <div class=""><font class="" size="2" face="Menlo">Regards,</font></div>
        <div class=""><font class="" size="2" face="Menlo">Manajit</font></div>
        <div class=""><br class="">
          <div class="">
            <blockquote type="cite" class="">
              <div class="">On 18-Apr-2016, at 3:30 pm, prasanta
                sadhukhan <<a moz-do-not-send="true" href="mailto:prasanta.sadhukhan@oracle.com" class="">prasanta.sadhukhan@oracle.com</a>>

                wrote:</div>
              <br class="Apple-interchange-newline">
              <div class="">
                <meta content="text/html; charset=UTF-8" http-equiv="Content-Type" class="">
                <div bgcolor="#FFFFFF" text="#000000" class=""> Hi
                  Manajit.<br class="">
                  <br class="">
                  While pressing x button , the test dialog is not
                  closing in windows. Please check that. Also, the
                  failure message <br class="">
                  <i class="">throw new RuntimeException("Updating
                    TrayIcon popup menu"</i><i class=""><br class="">
                  </i><i class="">                        + " items
                    FAILED");</i><i class=""><br class="">
                  </i>
                  <div class="moz-cite-prefix">seems to be wrong.<br class="">
                    <br class="">
                    Regards<br class="">
                    Prasanta<br class="">
                    On 4/18/2016 2:59 PM, Manajit Halder wrote:<br class="">
                  </div>
                  <blockquote cite="mid:7F9D6D31-9706-4C67-861C-CF8384321CA8@oracle.com" type="cite" class="">
                    <meta http-equiv="Content-Type" content="text/html;
                      charset=UTF-8" class="">
                    <font class="" size="2" face="Menlo">Hi Phil,</font>
                    <div class=""><font class="" size="2" face="Menlo"><br class="">
                      </font></div>
                    <div class=""><font class="" size="2" face="Menlo">Thank

                        you for the review comments. Please review the
                        updated webrev.</font></div>
                    <div class=""><font class="" size="2" face="Menlo"><br class="">
                      </font></div>
                    <div class=""><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Emhalder/8137137/webrev.01/" class=""><font class="" size="2" face="Menlo">http://cr.openjdk.java.net/~mhalder/8137137/webrev.01/</font></a></div>
                    <div class=""><font class="" size="2" face="Menlo"><br class="">
                      </font></div>
                    <div class=""><font class="" size="2" face="Menlo">Regards,</font></div>
                    <div class=""><font class="" size="2" face="Menlo">Manajit</font></div>
                    <div class=""><br class="">
                      <div class="">
                        <div class="">
                          <blockquote type="cite" class="">
                            <div class="">On 15-Apr-2016, at 11:39 pm,
                              Phil Race <<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>>


                              wrote:</div>
                            <br class="Apple-interchange-newline">
                            <div class="">
                              <meta content="text/html; charset=UTF-8" http-equiv="Content-Type" class="">
                              <div bgcolor="#FFFFFF" text="#000000" class="">
                                <div class="moz-cite-prefix">
                                  <pre class="">Hi,

Good to get rid of one applet test. Only 1,499 to go :-)

Even though you effectively re-wrote this you should set the (c) as a range "2007, 2016"

Also I think we should try to use the natural size of the component rather than explicitly
setting the size :-

instructionFrame.setBounds(0, 0, 650, 230);</pre>
                                  instructionTextArea.setBounds(10, 10,
                                  650, 230);<br class="">
                                  <br class="">
                                  -phil.<br class="">
                                  <br class="">
                                  On 04/15/2016 10:53 AM, Manajit Halder
                                  wrote:<br class="">
                                </div>
                                <blockquote cite="mid:717E645F-1A6D-4FC5-8D34-645BF72D0402@oracle.com" type="cite" class="">
                                  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
                                  <div class=""><font class="" size="2" face="Menlo">Hi All,</font></div>
                                  <div class=""><font class="" size="2" face="Menlo"><br class="">
                                    </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">Kindly review the fix
                                      for JDK9.</font></div>
                                  <div class=""><font class="" size="2" face="Menlo"><br class="">
                                    </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">Bug: </font></div>
                                  <div class=""><a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8137137" class=""><font class="" size="2" face="Menlo">https://bugs.openjdk.java.net/browse/JDK-8137137</font></a></div>
                                  <div class=""><font class="" size="2" face="Menlo"><br class="">
                                    </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">Webrev: </font></div>
                                  <div class=""><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Emhalder/8137137/webrev.00/" class=""><font class="" size="2" face="Menlo">http://cr.openjdk.java.net/~mhalder/8137137/webrev.00/</font></a></div>
                                  <div class=""><font class="" size="2" face="Menlo"><br class="">
                                    </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">Issue: </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">The native print
                                      dialog and native page dialog
                                      doesn’t display close(X) button in
                                      Mac OS X.</font></div>
                                  <div class=""><font class="" size="2" face="Menlo"><br class="">
                                    </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">Cause: </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">The reported problem
                                      is the expected behaviour on Mac
                                      OS. The native print dialog does
                                      not have ‘close’(X) button on
                                      MacOS, instead the dialog contains
                                      OK or Cancel buttons and expects
                                      either Cancel or OK button clicks
                                      from the user.</font></div>
                                  <div class=""><span class="Apple-tab-span" style="white-space:pre"><font class="" size="2" face="Menlo">
                                      </font></span></div>
                                  <div class=""><font class="" size="2" face="Menlo">The native print
                                      dialogs (“native print dialog” and
                                      “native page dialogs”) calls Cocoa
                                      method runModalWithPrintInfo on
                                      MacOS to display the print and
                                      page dialogs.
                                      runModalWithPrintInfo method does
                                      not have any close button and also
                                      the normal behaviour of a modal
                                      window is to exclude all other
                                      windows and panels from receiving
                                      events. Therefore as long as the
                                      print or page dialog window is
                                      open, no other windows will
                                      receive any events.</font></div>
                                  <div class=""><font class="" size="2" face="Menlo"><br class="">
                                    </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">The user is expected
                                      to either click OK button or
                                      Cancel button (or press the ESC
                                      key) to close the print or page
                                      dialog.</font></div>
                                  <div class=""><font class="" size="2" face="Menlo"><br class="">
                                    </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">Fix: </font></div>
                                  <div class=""><font class="" size="2" face="Menlo">No fix required. The
                                      code changed for the following
                                      reasons:</font></div>
                                  <div class=""><font class="" size="2" face="Menlo">  </font><span style="font-family: Menlo;
                                      font-size: small;" class="">To add
                                      proper instruction with colse(X)
                                      button behaviour on Mac OS X.</span></div>
                                  <div class=""><span style="font-family: Menlo;
                                      font-size: small;" class=""> 
                                      Rewrite the test case without
                                      Applets.</span></div>
                                  <div class="">    </div>
                                  <div class=""><br class="">
                                  </div>
                                  <div class=""><font class="" size="2" face="Menlo">Regards,</font></div>
                                  <div class=""><font class="" size="2" face="Menlo">Manajit</font></div>
                                </blockquote>
                                <br class="">
                              </div>
                            </div>
                          </blockquote>
                        </div>
                        <br class="">
                      </div>
                    </div>
                  </blockquote>
                  <br class="">
                </div>
              </div>
            </blockquote>
          </div>
          <br class="">
        </div>
      </blockquote>
      <br class="">
    </blockquote>
    <br class="">
  </div>

</div></blockquote></div><br class=""></body></html>