<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    On 6/28/2016 11:14 AM, Manajit Halder wrote:<br>
    <blockquote
      cite="mid:6A67C60C-A2C0-4EDA-860C-A9790804376B@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      Hi All,
      <div class=""><br class="">
      </div>
      <div class="">Gentle remainder. Please review the changes.</div>
    </blockquote>
       It is better to use "if (leftAltKeyPressed)" instead of "if
    (leftAltKeyPressed == YES)" and "if (!altGRPressed)" instead of "if
    (altGRPressed == NO)".<br>
    <br>
      Thanks,<br>
      Alexandr.<br>
    <blockquote
      cite="mid:6A67C60C-A2C0-4EDA-860C-A9790804376B@oracle.com"
      type="cite">
      <div class=""><br class="">
      </div>
      <div class="">Thanks,</div>
      <div class="">Manajit</div>
      <div class=""><br class="">
        <div>
          <blockquote type="cite" class="">
            <div class="">On 25-Jun-2016, at 7:46 pm, Manajit Halder
              <<a moz-do-not-send="true"
                href="mailto:manajit.halder@oracle.com" class="">manajit.halder@oracle.com</a>>
              wrote:</div>
            <br class="Apple-interchange-newline">
            <div class="">
              <meta http-equiv="Content-Type" content="text/html;
                charset=windows-1252" class="">
              <div style="word-wrap: break-word; -webkit-nbsp-mode:
                space; -webkit-line-break: after-white-space;" class=""><font
                  class="" face="Menlo">Hi All,</font>
                <div class=""><font class="" face="Menlo"><br class="">
                  </font></div>
                <div class=""><font class="" face="Menlo">The code was
                    changed on the same lines in one file after the
                    first review was generated. A new review is
                    generated after taking an update of the code.</font></div>
                <div class=""><font class="" face="Menlo">Fix wise the
                    webrev.00 and webrev.01 are same.</font></div>
                <div class=""><font class="" face="Menlo"><br class="">
                  </font></div>
                <div class=""><font class="" face="Menlo">Please review
                    webrev.01</font></div>
                <div class=""><a moz-do-not-send="true"
                    href="http://cr.openjdk.java.net/%7Emhalder/8156460/webrev.01/"
                    class=""><font class="" face="Menlo">http://cr.openjdk.java.net/~mhalder/8156460/webrev.01/</font></a></div>
                <div class=""><font class="" face="Menlo"><br class="">
                  </font></div>
                <div class=""><font class="" face="Menlo">Also note that
                    along with the previous 10 issues as mentioned in
                    the first review mail below another two new issues
                    created 2 days ago also gets resolved by this fix.</font></div>
                <div class=""><font class="" face="Menlo">The 2 new
                    issues are:</font></div>
                <div class=""><font class="" face="Menlo"><br class="">
                  </font></div>
                <div class=""><a moz-do-not-send="true"
                    href="https://bugs.openjdk.java.net/browse/JDK-8160144"
                    class=""><font class="" face="Menlo">https://bugs.openjdk.java.net/browse/JDK-8160144</font></a></div>
                <div class=""><a moz-do-not-send="true"
                    href="https://bugs.openjdk.java.net/browse/JDK-8160145"
                    class=""><font class="" face="Menlo">https://bugs.openjdk.java.net/browse/JDK-8160145</font></a></div>
                <div class=""><font class="" face="Menlo"><br class="">
                  </font></div>
                <div class=""><font class="" face="Menlo">Thank you Avik
                    for your comment. The lines were moved up to
                    maintain the order of modifier values in increasing
                    order.</font></div>
                <div class=""><font class="" face="Menlo"><br class="">
                  </font></div>
                <div class=""><font class="" face="Menlo">Thanks,</font></div>
                <div class=""><font class="" face="Menlo">Manajit</font></div>
                <div class=""><br class="">
                </div>
                <div class=""><br class="">
                  <div class="">
                    <blockquote type="cite" class="">
                      <div class="">On 21-Jun-2016, at 12:10 pm, Avik
                        Niyogi <<a moz-do-not-send="true"
                          href="mailto:avik.niyogi@oracle.com" class="">avik.niyogi@oracle.com</a>>
                        wrote:</div>
                      <br class="Apple-interchange-newline">
                      <div class="">
                        <meta http-equiv="Content-Type"
                          content="text/html; charset=windows-1252"
                          class="">
                        <div style="word-wrap: break-word;
                          -webkit-nbsp-mode: space; -webkit-line-break:
                          after-white-space;" class="">
                          <div class="">Hi,</div>
                          <div class="">The fix looks good to me. </div>
                          <div class="">A small query though, line 281 -
                            290 is required at that position, looks like
                            it was moved.</div>
                          <div class=""><br class="">
                          </div>
                          <div class="">With Regards,</div>
                          <div class="">Avik Niyogi<br class="">
                            <blockquote type="cite" class="">
                              <div class="">
                                <div class="WordSection1" style="page:
                                  WordSection1; font-family: Helvetica;
                                  font-size: 12px; font-style: normal;
                                  font-variant: normal; font-weight:
                                  normal; letter-spacing: normal;
                                  line-height: normal; orphans: auto;
                                  text-align: start; text-indent: 0px;
                                  text-transform: none; white-space:
                                  normal; widows: auto; word-spacing:
                                  0px; -webkit-text-stroke-width: 0px;">
                                  <div class="">
                                    <div style="border-style: solid none
                                      none; border-top-color: rgb(181,
                                      196, 223); border-top-width: 1pt;
                                      padding: 3pt 0in 0in;" class="">
                                      <div style="margin: 0in 0in
                                        0.0001pt; font-size: 12pt;
                                        font-family: 'Times New Roman',
                                        serif;" class=""><b class=""><span
                                            style="font-size: 10pt;
                                            font-family: Tahoma,
                                            sans-serif;" class="">From:</span></b><span
                                          style="font-size: 10pt;
                                          font-family: Tahoma,
                                          sans-serif;" class=""><span
                                            class="Apple-converted-space"> </span>Manajit
                                          Halder<span
                                            class="Apple-converted-space"> </span><br
                                            class="">
                                          <b class="">Sent:</b><span
                                            class="Apple-converted-space"> </span>Monday,
                                          June 20, 2016 1:56 AM<br
                                            class="">
                                          <b class="">To:</b><span
                                            class="Apple-converted-space"> </span>Sergey
                                          Bylokhov; Semyon Sadetsky<br
                                            class="">
                                          <b class="">Cc:</b><span
                                            class="Apple-converted-space"> </span><a
                                            moz-do-not-send="true"
                                            href="mailto:awt-dev@openjdk.java.net"
                                            style="color: purple;
                                            text-decoration: underline;"
                                            class=""><a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a></a><br
                                            class="">
                                          <b class="">Subject:</b><span
class="Apple-converted-space"> </span><AWT Dev> <AWT dev>[9]
                                          Review request for JDK-8156460
                                          [macosx] Test case
                                          javax/swing/JPopupMenu/6827786/bug6827786.java
                                          fails<o:p class=""></o:p></span></div>
                                    </div>
                                  </div>
                                  <div style="margin: 0in 0in 0.0001pt;
                                    font-size: 12pt; font-family: 'Times
                                    New Roman', serif;" class=""><o:p
                                      class=""> </o:p></div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        style="font-family: Menlo,
                                        serif;" class="">Hi All,</span><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><o:p class=""> </o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        style="font-family: Menlo,
                                        serif;" class="">Please review
                                        the regression fix for issue <a
                                          moz-do-not-send="true"
                                          href="https://bugs.openjdk.java.net/browse/JDK-8156460"
                                          style="color: purple;
                                          text-decoration: underline;"
                                          class="">JDK-8156460</a> which
                                        fixes below mentioned test
                                        cases.</span><o:p class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="http://cr.openjdk.java.net/%7Emhalder/8156460/webrev.00/"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~mhalder/8156460/webrev.00/">http://cr.openjdk.java.net/~mhalder/8156460/webrev.00/</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><o:p class=""> </o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        style="font-family: Menlo,
                                        serif;" class="">This fix
                                        resolves the following 3 JCK
                                        failures and 7 test failures:</span><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><o:p class=""> </o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        style="font-family: Menlo,
                                        serif;" class="">JCK tests:</span><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8158621"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158621">https://bugs.openjdk.java.net/browse/JDK-8158621</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8158485"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158485">https://bugs.openjdk.java.net/browse/JDK-8158485</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8158501"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158501">https://bugs.openjdk.java.net/browse/JDK-8158501</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><o:p class=""> </o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        style="font-family: Menlo,
                                        serif;" class="">Jtreg tests:</span><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8158389"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158389">https://bugs.openjdk.java.net/browse/JDK-8158389</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8158526"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158526">https://bugs.openjdk.java.net/browse/JDK-8158526</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8158496"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158496">https://bugs.openjdk.java.net/browse/JDK-8158496</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8158362"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158362">https://bugs.openjdk.java.net/browse/JDK-8158362</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8158512"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158512">https://bugs.openjdk.java.net/browse/JDK-8158512</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8156460"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8156460">https://bugs.openjdk.java.net/browse/JDK-8156460</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><a
                                        moz-do-not-send="true"
                                        href="https://bugs.openjdk.java.net/browse/JDK-8158377"
                                        style="color: purple;
                                        text-decoration: underline;"
                                        class=""><span
                                          style="font-family: Menlo,
                                          serif;" class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158377">https://bugs.openjdk.java.net/browse/JDK-8158377</a></span></a><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><o:p class=""> </o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        style="font-family: Menlo,
                                        serif; color: rgb(0, 30, 87);"
                                        class="">Reason of failure:</span><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        class="apple-tab-span"><span
                                          style="font-family: Menlo,
                                          serif; color: rgb(0, 30, 87);"
                                          class="">           <span
                                            class="Apple-converted-space"> </span></span></span><span
                                        style="font-family: Menlo,
                                        serif; color: rgb(0, 30, 87);"
                                        class="">The modifier value
                                        calculation was wrong.</span><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><o:p class=""> </o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        style="font-family: Menlo,
                                        serif; color: rgb(0, 30, 87);"
                                        class="">Note that with this fix
                                        the
                                        test /java/awt/keyboard/AllKeyCode/AllKeyCode.java
                                        will fail due to the reason that
                                        pressing number (0 to 9) after
                                        pressing arrow keys( up, down,
                                        left and right) will generate
                                        corresponding Numpad keys code
                                        for number keys (0 to 9).
                                        Whereas if the arrow key are
                                        pressed after number keys are
                                        pressed then there is no
                                        problem. An issue will be
                                        created for this issue once this
                                        fix is accepted.</span><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><o:p class=""> </o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        style="font-family: Menlo,
                                        serif; color: rgb(0, 30, 87);"
                                        class="">Thanks,</span><o:p
                                        class=""></o:p></div>
                                  </div>
                                  <div class="">
                                    <div style="margin: 0in 0in
                                      0.0001pt; font-size: 12pt;
                                      font-family: 'Times New Roman',
                                      serif;" class=""><span
                                        style="font-family: Menlo,
                                        serif; color: rgb(0, 30, 87);"
                                        class="">Manajit</span></div>
                                  </div>
                                </div>
                              </div>
                            </blockquote>
                          </div>
                          <br class="">
                        </div>
                      </div>
                    </blockquote>
                  </div>
                  <br class="">
                </div>
              </div>
            </div>
          </blockquote>
        </div>
        <br class="">
      </div>
    </blockquote>
    <br>
  </body>
</html>