<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Alexandr,<div class=""><br class=""></div><div class="">Thank you for the review comments. Code is modified as per you suggestion. RobotUtilities class is replaced with direct calls to corresponding methods in Robot class and also Util class is used in some places.</div><div class="">Please review the modified code.</div><div class=""><br class=""></div><div class=""><a href="http://cr.openjdk.java.net/~mhalder/8160266/webrev.01/" class="">http://cr.openjdk.java.net/~mhalder/8160266/webrev.01/</a></div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Manajit</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On 08-Jul-2016, at 3:57 pm, Alexandr Scherbatiy <<a href="mailto:alexandr.scherbatiy@oracle.com" class="">alexandr.scherbatiy@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
  
    <meta content="text/html; charset=windows-1252" http-equiv="Content-Type" class="">
  
  <div bgcolor="#FFFFFF" text="#000000" class="">
    <br class="">
    Is it possible to get rid of the RobotUtilities class? Methods like
    RobotUtilities.pressKey(int num)/releaseKey(int num) are just direct
    calls to the corresponding methods in Robot.<br class="">
    Other necessary methods can be added to 
    test/java/awt/regtesthelpers/Util.java<br class="">
    <br class="">
    Thanks,<br class="">
    Alexandr.<br class="">
    <br class="">
    <div class="moz-cite-prefix">On 7/7/2016 1:32 PM, Manajit Halder
      wrote:<br class="">
    </div>
    <blockquote cite="mid:15EAC7D9-0681-4AD2-B7C0-EF72190E4C65@oracle.com" type="cite" class="">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252" class="">
      Hi All,
      <div class=""><br class="">
      </div>
      <div class="">Gentle remainder. Please review the fix for issue <a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8160266" class="">https://bugs.openjdk.java.net/browse/JDK-8160266</a>.</div>
      <div class=""><br class="">
      </div>
      <div class="">Thanks,</div>
      <div class="">Manajit</div>
      <div class=""><br class="">
        <div class="">
          <blockquote type="cite" class="">
            <div class="">On 24-Jun-2016, at 8:53 pm, Manajit Halder
              <<a moz-do-not-send="true" href="mailto:manajit.halder@oracle.com" class="">manajit.halder@oracle.com</a>>
              wrote:</div>
            <br class="Apple-interchange-newline">
            <div class="">
              <meta http-equiv="Content-Type" content="text/html;
                charset=windows-1252" class="">
              <div style="word-wrap: break-word; -webkit-nbsp-mode:
                space; -webkit-line-break: after-white-space;" class="">
                <div style="font-family: -apple-system-font;
                  line-height: 16px;" class=""><span style="color:
                    rgb(0, 30, 87); font-family: Menlo;" class="">Hi
                    Sergey,</span></div>
                <div class="">
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><br class="">
                    </font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57">Kindly review the fix
                      for JDK9.</font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><br class="">
                    </font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Bug</b>: </font></div>
                  <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height: 16px;" class=""><a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8160266" class="">https://bugs.openjdk.java.net/browse/JDK-8160266</a></span></font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><u class=""><br class="">
                      </u></font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Webrev</b>: </font></div>
                  <div class=""><font class="" face="-apple-system-font"><span style="line-height: 16px;" class=""><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Emhalder/8160266/webrev.00/" class="">http://cr.openjdk.java.net/~mhalder/8160266/webrev.00/</a></span></font></div>
                  <div class=""><br class="">
                  </div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Issue: </b></font></div>
                  <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height: 16px;" class="">[macosx] NestedModalDialogTest.java and
                        NestedModelessDialogTest.java tests does not run
                        with current JDK codebase after taking the files
                        from MACOSX_PORT</span></font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><br class="">
                    </font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Cause: </b></font></div>
                  <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height: 16px;" class="">Both the tests were written
                        using unit.framework.</span></font></div>
                  <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height: 16px;" class=""><br class="">
                      </span></font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Fix: </b></font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><span style="color:
                      rgb(0, 30, 87); font-family: Menlo;" class="">Test
                      files are modified to remove the dependency of
                      junit.framework and related API calls. Test files
                      were moved from MACOSX_PORT to the current JDK 9
                      codebase and added at the corresponding folder
                      location:</span></div>
                  <div class="">
                    <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height: 16px;" class="">test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java</span></font></div>
                    <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height: 16px;" class="">test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java</span></font></div>
                  </div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><span style="color:
                      rgb(0, 30, 87); font-family: Menlo;" class=""><br class="">
                    </span></div>
                  <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height: 16px;" class="">Along with the test file 3 supporting
                        files are also moved. The files are:</span></font></div>
                  <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height: 16px;" class="">
                        <div class="">test/java/awt/regtesthelpers/RobotUtilities.java</div>
                        <div class="">test/java/awt/regtesthelpers/VisibilityValidator.java</div>
                        <div class="">test/java/awt/regtesthelpers/Waypoint.java</div>
                      </span></font></div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class="">
                    <div class=""><font class="" face="Menlo" color="#001e57"><br class="">
                      </font></div>
                    <div class=""><font class="" face="Menlo" color="#001e57"><br class="">
                      </font></div>
                  </div>
                  <div style="font-family: -apple-system-font;
                    line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57">Regards,<br class="">
                      Manajit</font></div>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
        <br class="">
      </div>
    </blockquote>
    <br class="">
  </div>

</div></blockquote></div><br class=""></div></body></html>