<div dir="ltr"><div><div><div>Hello Mikhail,<br><br></div>just double checking: now that 2 reviewers have approved the patch, do you need anything extra from me to be able to commit and push the patch ?<br></div>Or can I assume that this patch will get checked in ?<br><br></div>Robin<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 13, 2016 at 10:29 AM, Alexandr Scherbatiy <span dir="ltr"><<a href="mailto:alexandr.scherbatiy@oracle.com" target="_blank">alexandr.scherbatiy@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    The fix looks good to me.<br>
    <br>
    Thanks,<br>
    Alexandr.<span class=""><br>
    <br>
    <div>On 7/12/2016 3:12 PM, Robin Stevens
      wrote:<br>
    </div>
    <blockquote type="cite">
      <div dir="ltr">
        <div>
          <div>
            <div>
              <div>
                <div>Hello Mikhail,<br>
                  <br>
                </div>
                thanks for the review.<br>
              </div>
              Would you mind performing the actual commit once it is
              approved (I assume I need a review from a second person) ?<br>
            </div>
            I have no commit rights, so I cannot do it myself.<br>
            <br>
          </div>
          Thanks<br>
          <br>
        </div>
        Robin<br>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Tue, Jul 12, 2016 at 2:04 PM,
          Mikhail Cherkasov <span dir="ltr"><<a href="mailto:mikhail.cherkasov@oracle.com" target="_blank">mikhail.cherkasov@oracle.com</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div bgcolor="#FFFFFF" text="#000000"> Looks good.
              <div>
                <div><br>
                  <br>
                  <div>On 12.07.2016 0:15, Robin Stevens wrote:<br>
                  </div>
                  <blockquote type="cite">
                    <div dir="ltr">Hello Mikhail,
                      <div><br>
                      </div>
                      <div>good catch. I adjusted the code.</div>
                      <div><br>
                      </div>
                      <div>Webrev: <a href="http://cr.openjdk.java.net/%7Erstevens/8160941/webrev.01" target="_blank">http://cr.openjdk.java.net/~rstevens/8160941/webrev.01</a></div>
                      <div><br>
                      </div>
                      <div><br>
                      </div>
                      <div>Robin</div>
                    </div>
                    <div class="gmail_extra"><br>
                      <div class="gmail_quote">On Mon, Jul 11, 2016 at
                        6:08 PM, Mikhail Cherkasov <span dir="ltr"><<a href="mailto:mikhail.cherkasov@oracle.com" target="_blank">mikhail.cherkasov@oracle.com</a>></span>
                        wrote:<br>
                        <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 11.07.2016
                            18:55, Robin Stevens wrote:<br>
                            <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> However,
                              that would cause an inconsistency with
                              other operating systems.<br>
                            </blockquote>
                          </span> ok, but then let's simplify it:<br>
                          <br>
                          remove this line:<br>
                               sb.append(strings[0]);<br>
                          <br>
                          and start cycle from 0:<br>
                          for(int i = 0; i < strings.length; i++) {<br>
                             sb.append(strings[i]);<br>
                             sb.append(separator);<br>
                          }<br>
                          <br>
                        </blockquote>
                      </div>
                      <br>
                    </div>
                  </blockquote>
                  <br>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </span></div>

</blockquote></div><br></div>