<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    The fix looks good to me.<br>
    <br>
    It would be better if a native speaker look at the documentation
    change in the launcher.properties file.<br>
    <br>
    Thanks,<br>
    Alexandr.<br>
    <br>
    <div class="moz-cite-prefix">On 8/16/2016 8:26 AM, Rajeev Chamyal
      wrote:<br>
    </div>
    <blockquote cite="mid:020c37cc-c9af-4790-a591-29b71b410533@default"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      <meta name="Generator" content="Microsoft Word 15 (filtered
        medium)">
      <style><!--
/* Font Definitions */
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0cm;
        margin-bottom:.0001pt;
        font-size:11.0pt;
        font-family:"Calibri",sans-serif;
        color:black;
        mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:#0563C1;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:#954F72;
        text-decoration:underline;}
p
        {mso-style-priority:99;
        mso-margin-top-alt:auto;
        margin-right:0cm;
        mso-margin-bottom-alt:auto;
        margin-left:0cm;
        font-size:11.0pt;
        font-family:"Calibri",sans-serif;
        color:black;
        mso-fareast-language:EN-US;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
        {mso-style-priority:34;
        margin-top:0cm;
        margin-right:0cm;
        margin-bottom:0cm;
        margin-left:36.0pt;
        margin-bottom:.0001pt;
        font-size:11.0pt;
        font-family:"Calibri",sans-serif;
        color:black;
        mso-fareast-language:EN-US;}
span.EmailStyle18
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:windowtext;}
span.EmailStyle19
        {mso-style-type:personal-reply;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-size:10.0pt;}
@page WordSection1
        {size:612.0pt 792.0pt;
        margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
        {page:WordSection1;}
/* List Definitions */
@list l0
        {mso-list-id:706565634;
        mso-list-type:hybrid;
        mso-list-template-ids:1387313554 1074331665 1074331673 1074331675 1074331663 1074331673 1074331675 1074331663 1074331673 1074331675;}
@list l0:level1
        {mso-level-text:"%1\)";
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-18.0pt;}
@list l0:level2
        {mso-level-number-format:alpha-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-18.0pt;}
@list l0:level3
        {mso-level-number-format:roman-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:right;
        text-indent:-9.0pt;}
@list l0:level4
        {mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-18.0pt;}
@list l0:level5
        {mso-level-number-format:alpha-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-18.0pt;}
@list l0:level6
        {mso-level-number-format:roman-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:right;
        text-indent:-9.0pt;}
@list l0:level7
        {mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-18.0pt;}
@list l0:level8
        {mso-level-number-format:alpha-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-18.0pt;}
@list l0:level9
        {mso-level-number-format:roman-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:right;
        text-indent:-9.0pt;}
ol
        {margin-bottom:0cm;}
ul
        {margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
      <div class="WordSection1">
        <p class="MsoNormal"><span style="color:#1F497D">Hello Alexandr,<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D">Please review
            the updated webrev.<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D"><a
              moz-do-not-send="true"
              href="http://cr.openjdk.java.net/%7Erchamyal/8151787/webrev.01/">http://cr.openjdk.java.net/~rchamyal/8151787/webrev.01/</a><o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D">Updates : <o:p></o:p></span></p>
        <p class="MsoListParagraph"
          style="text-indent:-18.0pt;mso-list:l0 level1 lfo1"><!--[if !supportLists]--><span
            style="color:#1F497D"><span style="mso-list:Ignore">1)<span
                style="font:7.0pt "Times New Roman"">      </span></span></span><!--[endif]--><span
            style="color:#1F497D">Updated the consition as suggested
             if(*scaleFactor - (int)*scaleFactor < 0.000001)<o:p></o:p></span></p>
        <p class="MsoListParagraph"
          style="text-indent:-18.0pt;mso-list:l0 level1 lfo1"><!--[if !supportLists]--><span
            style="color:#1F497D"><span style="mso-list:Ignore">2)<span
                style="font:7.0pt "Times New Roman"">      </span></span></span><!--[endif]--><span
            style="color:#1F497D">Includes the changes of </span><span
            style="font-size:12.0pt;font-family:"Times New
            Roman",serif;mso-fareast-language:EN-IN">src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c</span><span
            style="color:#1F497D"><o:p></o:p></span></p>
        <p class="MsoListParagraph"
          style="text-indent:-18.0pt;mso-list:l0 level1 lfo1"><!--[if !supportLists]--><span
            style="color:#1F497D"><span style="mso-list:Ignore">3)<span
                style="font:7.0pt "Times New Roman"">      </span></span></span><!--[endif]--><span
            style="font-size:12.0pt;font-family:"Times New
            Roman",serif;mso-fareast-language:EN-IN">+        //map
            the splash co-ordinates as per system scale<br>
            +        splash->x /= splash->scaleFactor;<br>
            +        splash->y /= splash->scaleFactor;<br>
            <br>
          </span><span style="color:#1F497D"><o:p></o:p></span></p>
        <p class="MsoListParagraph"><span style="color:#1F497D">This
            change is required only for windows and linux. As we use
            absolute system resolution for centring the splash on screen
            on these.<o:p></o:p></span></p>
        <p class="MsoListParagraph"><span style="color:#1F497D">i.e. if
            system resolution is 1920 X 1080(i.e. unscaled resolution)
            on windows and linux we use this for centring the splash on
            screen. For mac scaled resolution is used directly.<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D">Regards,<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D">Rajeev Chamyal<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
        <div>
          <div style="border:none;border-top:solid #E1E1E1
            1.0pt;padding:3.0pt 0cm 0cm 0cm">
            <p class="MsoNormal"><b><span
                  style="color:windowtext;mso-fareast-language:EN-IN"
                  lang="EN-US">From:</span></b><span
                style="color:windowtext;mso-fareast-language:EN-IN"
                lang="EN-US"> Alexander Scherbatiy <br>
                <b>Sent:</b> 11 August 2016 14:44<br>
                <b>To:</b> Rajeev Chamyal; <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>;
                Philip Race; Sergey Bylokhov<br>
                <b>Subject:</b> Re: <AWT Dev> <Swing Dev>[9]
                Review Request JDK-8151787 Unify the HiDPI splash screen
                image naming convention<o:p></o:p></span></p>
          </div>
        </div>
        <p class="MsoNormal"><o:p> </o:p></p>
        <p class="MsoNormal">On 10/08/16 19:24, Alexandr Scherbatiy
          wrote:<br>
          <br>
          <span style="font-size:12.0pt;mso-fareast-language:EN-IN"><o:p></o:p></span></p>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p>On 8/9/2016 11:18 AM, Rajeev Chamyal wrote:<o:p></o:p></p>
          <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
            <p class="MsoNormal">Hello All,<o:p></o:p></p>
            <p class="MsoNormal"> <o:p></o:p></p>
            <p class="MsoNormal">Please review the following webrev.<o:p></o:p></p>
            <p class="MsoNormal"> <o:p></o:p></p>
            <p class="MsoNormal">Bug: <a moz-do-not-send="true"
                href="https://bugs.openjdk.java.net/browse/JDK-8151787">https://bugs.openjdk.java.net/browse/JDK-8151787</a>
              <o:p></o:p></p>
            <p class="MsoNormal">Webrev: <a moz-do-not-send="true"
                href="http://cr.openjdk.java.net/%7Erchamyal/8151787/webrev.00/">http://cr.openjdk.java.net/~rchamyal/8151787/webrev.00/</a>
              <o:p></o:p></p>
            <p class="MsoNormal"> <o:p></o:p></p>
            <p class="MsoNormal">Issue: Currently different naming
              conventions are used for Hidpi image on different
              platforms.<o:p></o:p></p>
            <p class="MsoNormal"> <o:p></o:p></p>
            <p class="MsoNormal">With this change the names will be
              unified across all platforms.<o:p></o:p></p>
            <p class="MsoNormal"> <o:p></o:p></p>
            <p class="MsoNormal">For a unscaled image image.ext
              following naming convention will be followed.<o:p></o:p></p>
            <p class="MsoNormal"> <o:p></o:p></p>
            <p class="MsoNormal">Unscaled name: image.ext<o:p></o:p></p>
            <p class="MsoNormal"> <o:p></o:p></p>
            <p class="MsoNormal">Supported Scaled Names:<o:p></o:p></p>
            <p class="MsoNormal">If screen scale is integer number e.g.
              2: <a moz-do-not-send="true" href="mailto:image@2x.ext">image@2x.ext</a><o:p></o:p></p>
            <p class="MsoNormal">If screen scale is float value like
              1.25: <a moz-do-not-send="true"
                href="mailto:image@125pct.ext">image@125pct.ext</a><o:p></o:p></p>
          </blockquote>
          <p class="MsoNormal"><span
              style="font-size:12.0pt;font-family:"Times New
              Roman",serif;mso-fareast-language:EN-IN"><br>
              The fix should be reviewed on the awt-dev alias.<br>
              <br>
              + if(*scaleFactor - (int)*scaleFactor < 0.000001)<br>
              <br>
              Should there be so high precision there? Could only
              percent values be compared like<br>
               if ((*scaleFactor *100) != ((int)(*scaleFactor)) * 100)<br>
              <br>
              <br>
              +        //map the splash co-ordinates as per system scale<br>
              +        splash->x /= splash->scaleFactor;<br>
              +        splash->y /= splash->scaleFactor;<br>
              <br>
              It looks like the splash coordinates and sizes are
              rescaled in different places. Is it possible to do that in
              the same place? May be in java_awt_SplashScreen.c file
              getBounds() function?<o:p></o:p></span></p>
        </blockquote>
        <p class="MsoNormal"><span
            style="font-size:12.0pt;font-family:"Times New
            Roman",serif;mso-fareast-language:EN-IN"><br>
src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c<br>
                   *scaleFactor = getNativeScaleFactor();<br>
            <br>
            Could you also include the change which requires to add some
            default output screen name to the getNativeScaleFactor()
            function on Linux. There is the discussion about that: <a
              moz-do-not-send="true"
href="http://mail.openjdk.java.net/pipermail/awt-dev/2016-August/011766.html">http://mail.openjdk.java.net/pipermail/awt-dev/2016-August/011766.html</a><br>
            <br>
            Thanks,<br>
            Alexandr.<br>
            <br>
            <o:p></o:p></span></p>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p class="MsoNormal"><span
              style="font-size:12.0pt;font-family:"Times New
              Roman",serif;mso-fareast-language:EN-IN"><br>
              Thanks,<br>
              Alexandr.<br>
              <br>
              <br>
              <o:p></o:p></span></p>
          <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
            <p class="MsoNormal"> <o:p></o:p></p>
            <p class="MsoNormal">Regards,<o:p></o:p></p>
            <p class="MsoNormal">Rajeev Chamyal<o:p></o:p></p>
            <p class="MsoNormal"> <o:p></o:p></p>
            <p class="MsoNormal"> <o:p></o:p></p>
          </blockquote>
          <p class="MsoNormal"><span
              style="font-size:12.0pt;font-family:"Times New
              Roman",serif;mso-fareast-language:EN-IN"><o:p> </o:p></span></p>
        </blockquote>
        <p class="MsoNormal"><span
            style="font-size:12.0pt;font-family:"Times New
            Roman",serif;mso-fareast-language:EN-IN"><o:p> </o:p></span></p>
      </div>
    </blockquote>
    <br>
  </body>
</html>