<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <p>Hi Ambarish,</p>
    <p>omitted unused file GenerateTestImage.java from the patch.<br>
      <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~vagarwal/8140329/webrev_03/">http://cr.openjdk.java.net/~vagarwal/8140329/webrev_03/</a></p>
    <p>-Regards,<br>
      Rahul Singh<br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 2017-01-11 1:40 PM, Ambarish Rapte
      wrote:<br>
    </div>
    <blockquote cite="mid:4c261f8c-6702-4693-a1b6-3d5a204f4074@default"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <meta name="Generator" content="Microsoft Word 12 (filtered
        medium)">
      <style><!--
/* Font Definitions */
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:Tahoma;
        panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
        {font-family:Consolas;
        panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Times New Roman","serif";
        color:black;}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:blue;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:purple;
        text-decoration:underline;}
p
        {mso-style-priority:99;
        mso-margin-top-alt:auto;
        margin-right:0in;
        mso-margin-bottom-alt:auto;
        margin-left:0in;
        font-size:12.0pt;
        font-family:"Times New Roman","serif";
        color:black;}
pre
        {mso-style-priority:99;
        mso-style-link:"HTML Preformatted Char";
        margin:0in;
        margin-bottom:.0001pt;
        font-size:10.0pt;
        font-family:"Courier New";
        color:black;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
        {mso-style-priority:99;
        mso-style-link:"Balloon Text Char";
        margin:0in;
        margin-bottom:.0001pt;
        font-size:8.0pt;
        font-family:"Tahoma","sans-serif";
        color:black;}
span.HTMLPreformattedChar
        {mso-style-name:"HTML Preformatted Char";
        mso-style-priority:99;
        mso-style-link:"HTML Preformatted";
        font-family:Consolas;
        color:black;}
span.EmailStyle20
        {mso-style-type:personal;
        font-family:"Calibri","sans-serif";
        color:#1F497D;}
span.EmailStyle21
        {mso-style-type:personal-reply;
        font-family:"Calibri","sans-serif";
        color:#1F497D;}
span.BalloonTextChar
        {mso-style-name:"Balloon Text Char";
        mso-style-priority:99;
        mso-style-link:"Balloon Text";
        font-family:"Tahoma","sans-serif";
        color:black;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-size:10.0pt;}
@page WordSection1
        {size:8.5in 11.0in;
        margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
        {page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
      <div class="WordSection1">
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi
            Rahul,<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">               
            Fix looks good.<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">               
            But I think the file <i>GenerateTestImage.java</i><b> </b>should
            be omitted from patch as it does not have any fix related
            change<b>.<o:p></o:p></b></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Ambarish</span><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">               
            <o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
        <div>
          <div style="border:none;border-top:solid #B5C4DF
            1.0pt;padding:3.0pt 0in 0in 0in">
            <p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
                Rahul Singh <br>
                <b>Sent:</b> Friday, January 06, 2017 11:22 AM<br>
                <b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
                <b>Subject:</b> Re: <AWT Dev> [awt-dev] Request
                for Approval and Review: JDK-8140329 [TEST BUG]
                java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java<o:p></o:p></span></p>
          </div>
        </div>
        <p class="MsoNormal"><o:p> </o:p></p>
        <p>Hi all,<br>
          The "user.dir" is saving the generated image in a common
          folder scratch whereas "test.classes" is saving it to a
          specific folder. Compiling the test file before running it is
          actually solving the problem.<o:p></o:p></p>
        <p> <a moz-do-not-send="true"
            href="http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev_02/">http://cr.openjdk.java.net/~vagarwal/8140329/webrev_02/</a><br>
          <br>
          Regards,<br>
          Rahul Singh<o:p></o:p></p>
        <p class="MsoNormal"><o:p> </o:p></p>
        <div>
          <p class="MsoNormal">On 1/4/2017 5:32 PM, Rahul Singh wrote:<o:p></o:p></p>
        </div>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p>Hi Ajit,<br>
            Changes made<br>
            <a moz-do-not-send="true"
              href="http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev_01/">http://cr.openjdk.java.net/~vagarwal/8140329/webrev_01/</a><br>
            <br>
            Regards,<br>
            Rahul Singh<o:p></o:p></p>
          <p class="MsoNormal"><o:p> </o:p></p>
          <div>
            <p class="MsoNormal">On 1/4/2017 10:38 AM, Ajit Ghaisas
              wrote:<o:p></o:p></p>
          </div>
          <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">The
                fix looks good.</span><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I
                suggest to replace wildcard import statements with
                specific ones in both the files in webrev.</span><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,</span><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Ajit</span><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
            <div>
              <div style="border:none;border-top:solid #E1E1E1
                1.0pt;padding:3.0pt 0in 0in 0in">
                <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext">
                    Rahul Singh <br>
                    <b>Sent:</b> Tuesday, January 03, 2017 6:17 PM<br>
                    <b>To:</b> <a moz-do-not-send="true"
                      href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
                    <b>Subject:</b> <AWT Dev> [awt-dev] Request
                    for Approval and Review: JDK-8140329 [TEST BUG]
                    java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java</span><o:p></o:p></p>
              </div>
            </div>
            <p class="MsoNormal"> <o:p></o:p></p>
            <pre>Hi All,<o:p></o:p></pre>
            <pre> <o:p></o:p></pre>
            <pre>Please review the fix for the bug: <a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-7146533">JDK-8140329</a> [TEST BUG]<o:p></o:p></pre>
            <pre>The test java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java fails to create test.png in the given path by GenerateTestImage.java utility. I used "user.dir" to obtain the path.<o:p></o:p></pre>
            <pre> <o:p></o:p></pre>
            <pre>Bug Link: <a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-7146533">https://bugs.openjdk.java.net/browse/JDK-8140329</a><o:p></o:p></pre>
            <pre> <o:p></o:p></pre>
            <pre>The webrev is : <a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev/">http://cr.openjdk.java.net/~vagarwal/8140329/webrev/</a><o:p></o:p></pre>
            <pre> <o:p></o:p></pre>
            <pre>Regards,<o:p></o:p></pre>
            <pre> <o:p></o:p></pre>
            <pre>Rahul Singh<o:p></o:p></pre>
          </blockquote>
          <p class="MsoNormal"><o:p> </o:p></p>
        </blockquote>
        <p class="MsoNormal"><o:p> </o:p></p>
      </div>
    </blockquote>
    <br>
  </body>
</html>