<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>Hi All, <br>
    </p>
    <p>Gentle remainder. Please review this fix.</p>
    <p>Regards,<br>
      Manajit<br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 08/10/18 10:27 AM, Krishna Addepalli
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:5cbd5dd5-b21a-4fcc-b824-3e91b00c9b2f@default">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <meta name="Generator" content="Microsoft Word 15 (filtered
        medium)">
      <style><!--
/* Font Definitions */
@font-face
        {font-family:"MS Gothic";
        panose-1:2 11 6 9 7 2 5 8 2 4;}
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:"Yu Gothic";
        panose-1:2 11 4 0 0 0 0 0 0 0;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:"\@MS Gothic";
        panose-1:2 11 6 9 7 2 5 8 2 4;}
@font-face
        {font-family:"\@Yu Gothic";
        panose-1:2 11 4 0 0 0 0 0 0 0;}
@font-face
        {font-family:"MS Gothic \,serif";
        panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Times New Roman",serif;
        color:black;}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:blue;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:purple;
        text-decoration:underline;}
p
        {mso-style-priority:99;
        mso-margin-top-alt:auto;
        margin-right:0in;
        mso-margin-bottom-alt:auto;
        margin-left:0in;
        font-size:12.0pt;
        font-family:"Times New Roman",serif;
        color:black;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
        {mso-style-priority:34;
        margin-top:0in;
        margin-right:0in;
        margin-bottom:0in;
        margin-left:.5in;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Times New Roman",serif;
        color:black;}
p.msonormal0, li.msonormal0, div.msonormal0
        {mso-style-name:msonormal;
        mso-style-priority:99;
        mso-margin-top-alt:auto;
        margin-right:0in;
        mso-margin-bottom-alt:auto;
        margin-left:0in;
        font-size:12.0pt;
        font-family:"Times New Roman",serif;
        color:black;}
span.EmailStyle20
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
span.EmailStyle21
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
span.EmailStyle22
        {mso-style-type:personal-reply;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-size:10.0pt;}
@page WordSection1
        {size:8.5in 11.0in;
        margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
        {page:WordSection1;}
/* List Definitions */
@list l0
        {mso-list-id:868378131;
        mso-list-type:hybrid;
        mso-list-template-ids:867486474 67698703 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
        {mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level2
        {mso-level-number-format:alpha-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level3
        {mso-level-number-format:roman-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:right;
        text-indent:-9.0pt;}
@list l0:level4
        {mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level5
        {mso-level-number-format:alpha-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level6
        {mso-level-number-format:roman-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:right;
        text-indent:-9.0pt;}
@list l0:level7
        {mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level8
        {mso-level-number-format:alpha-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l0:level9
        {mso-level-number-format:roman-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:right;
        text-indent:-9.0pt;}
@list l1
        {mso-list-id:1957445236;
        mso-list-type:hybrid;
        mso-list-template-ids:-1052069716 67698703 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l1:level1
        {mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level2
        {mso-level-number-format:alpha-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level3
        {mso-level-number-format:roman-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:right;
        text-indent:-9.0pt;}
@list l1:level4
        {mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level5
        {mso-level-number-format:alpha-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level6
        {mso-level-number-format:roman-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:right;
        text-indent:-9.0pt;}
@list l1:level7
        {mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level8
        {mso-level-number-format:alpha-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;}
@list l1:level9
        {mso-level-number-format:roman-lower;
        mso-level-tab-stop:none;
        mso-level-number-position:right;
        text-indent:-9.0pt;}
ol
        {margin-bottom:0in;}
ul
        {margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
      <div class="WordSection1">
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Looks
            fine.<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Krishna<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <div>
          <div style="border:none;border-top:solid #E1E1E1
            1.0pt;padding:3.0pt 0in 0in 0in">
            <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                Manajit Halder <br>
                <b>Sent:</b> Thursday, October 4, 2018 6:01 PM<br>
                <b>To:</b> Krishna Addepalli
                <a class="moz-txt-link-rfc2396E" href="mailto:krishna.addepalli@oracle.com"><krishna.addepalli@oracle.com></a>;
                <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
                <b>Subject:</b> Re: <AWT Dev> <AWT dev>[12]
                Review request for JDK-8209123: [Macosx] Maximized frame
                is resizable on Mac but not on Windows and Ubuntu<o:p></o:p></span></p>
          </div>
        </div>
        <p class="MsoNormal"><o:p> </o:p></p>
        <p>Hi Krishna,<o:p></o:p></p>
        <p>Thanks for your review comments. Answers are updated inline
          to your queries.<o:p></o:p></p>
        <p>Please review the modified webrev:<br>
          <a
            href="http://cr.openjdk.java.net/%7Emhalder/8209123/webrev.01/"
            moz-do-not-send="true">http://cr.openjdk.java.net/~mhalder/8209123/webrev.01/</a><o:p></o:p></p>
        <p>Thanks,<br>
          Manajit<o:p></o:p></p>
        <p><o:p> </o:p></p>
        <div>
          <p class="MsoNormal">On 04/10/18 8:13 AM, Krishna Addepalli
            wrote:<o:p></o:p></p>
        </div>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
              Manajit, </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">I
              have some questions which need to be answered:</span><o:p></o:p></p>
          <p class="MsoListParagraph"
            style="text-indent:-.25in;mso-list:l1 level1 lfo2"><!--[if !supportLists]--><span
              style="mso-list:Ignore">1.<span style="font:7.0pt
                "Times New Roman"">      </span></span><!--[endif]--><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">You
              have same piece of code repeated in “setWindowState” and
              in “setVisible” functions, which tests if the frame is
              resizable flag is changed and sets the state to false. Is
              it not true that setWindowState will be called before
              setVisible, and if so, then why do you need to check
              twice?</span><o:p></o:p></p>
        </blockquote>
        <p class="MsoNormal">    The code has to be repeated at places
          where window state is changing. Both the methods
          setWindowState and setVisible calls methods maximize() and
          unmaximize()  where window state is changing to a new state.<br>
          <br>
          <o:p></o:p></p>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p class="MsoListParagraph"
            style="text-indent:-.25in;mso-list:l1 level1 lfo2"><!--[if !supportLists]--><span
              style="mso-list:Ignore">2.<span style="font:7.0pt
                "Times New Roman"">      </span></span><!--[endif]--><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">In
              the deliverDoubleClickOnTitleBar() function, you may want
              to include a note which describes why you are temporarily
              enabling the resizable flag, and posting a native event,
              and then enabling the flag.</span><o:p></o:p></p>
        </blockquote>
        <p class="MsoNormal">    Added comment.<br>
          <br>
          <o:p></o:p></p>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p class="MsoListParagraph"
            style="text-indent:-.25in;mso-list:l1 level1 lfo2"><!--[if !supportLists]--><span
              style="mso-list:Ignore">3.<span style="font:7.0pt
                "Times New Roman"">      </span></span><!--[endif]--><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">At
              line 825, you could initialize windowResizable like this:
              “resizable && !isMaximizedBoth()”.</span><o:p></o:p></p>
        </blockquote>
        <p class="MsoNormal">    Changed code as per the comment.<br>
          <br>
          <o:p></o:p></p>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p class="MsoListParagraph"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks,</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Krishna</span><o:p></o:p></p>
          <p class="MsoListParagraph"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <div>
            <div style="border:none;border-top:solid #E1E1E1
              1.0pt;padding:3.0pt 0in 0in 0in">
              <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                  Manajit Halder <br>
                  <b>Sent:</b> Tuesday, September 25, 2018 3:23 PM<br>
                  <b>To:</b> Krishna Addepalli <<a
                    href="mailto:krishna.addepalli@oracle.com"
                    moz-do-not-send="true">krishna.addepalli@oracle.com</a>><br>
                  <b>Subject:</b> Re: <AWT Dev> <AWT
                  dev>[12] Review request for JDK-8209123: [Macosx]
                  Maximized frame is resizable on Mac but not on Windows
                  and Ubuntu</span><o:p></o:p></p>
            </div>
          </div>
          <p class="MsoNormal"> <o:p></o:p></p>
          <p>Hi Krishna,<o:p></o:p></p>
          <p>Could you please review my fix.<o:p></o:p></p>
          <p>Regards,<br>
            Manajit<o:p></o:p></p>
          <p class="MsoNormal"> <o:p></o:p></p>
          <div>
            <p class="MsoNormal">On 21/09/18 5:07 PM, Manajit Halder
              wrote:<o:p></o:p></p>
          </div>
          <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
            <p>Hi All,<br>
              <br>
              Please review the fix for JDK12.<br>
              <br>
              <span style="font-family:"MS Gothic"" lang="JA">

</span>Bug:
              <br>
                  <a
                href="https://bugs.openjdk.java.net/browse/JDK-8209123"
                moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8209123</a><o:p></o:p></p>
            <p><span style="font-family:"MS Gothic"" lang="JA">
</span>Webrev:
              <span style="font-family:"MS Gothic"" lang="JA">
</span><br>
                  <a
                href="http://cr.openjdk.java.net/%7Emhalder/8209123/webrev.00/"
                moz-do-not-send="true">http://cr.openjdk.java.net/~mhalder/8209123/webrev.00/</a><o:p></o:p></p>
            <p>Fix: <span style="font-family:"MS Gothic""
                lang="JA">
</span><br>
                  Resizibility of Frame with state MAXIMIZED_BOTH is set
              to false when Frame is resized and when Frame state is
              set. Resizibility of Frame in other states (NORMAL and
              ICONIFIED) is changed if the previous state of the frame
              was MAXIMIZED_BOTH otherwise it is not changed. <o:p></o:p></p>
            <p>Changes in method setResizable()<br>
               1) if setResizable passed true, then check if frame is in
              MAXIMIZED_BOTH state, if so then set setResizable to
              false, otherwise set to true.<br>
               2) if setResizable passed false, then set false without
              checking the frame MAXIMIZED_BOTH state.<br>
              <br>
              Changes done in method setVisible and setWindowState where
              Frame state is set:<br>
               1) Before setting any state check if resizibility was
              changed to MAXIMIZED_BOTH earlier, if so then set
              resizibility to false.<br>
               2) When Frame state is set to MAXIMIZED_BOTH then set
              resizibility to false.<o:p></o:p></p>
            <p>JCK and Jtreg (open and close) tests executed with the
              change:<br>
               1) All automated AWT and Swing tests.<br>
               2) All manual AWT and Swing tests related to Frame,
              Window, JFrame and JWindow. <br>
                  <o:p></o:p></p>
            <p>Regards, <span style="font-family:"MS Gothic
                ,serif",serif">
</span><br>
              Manajit<o:p></o:p></p>
            <p class="MsoNormal" style="margin-bottom:12.0pt"> <o:p></o:p></p>
          </blockquote>
          <p class="MsoNormal"> <o:p></o:p></p>
        </blockquote>
        <p class="MsoNormal"><o:p> </o:p></p>
      </div>
    </blockquote>
    <br>
  </body>
</html>