From Alan.Bateman at Sun.COM Mon Nov 9 06:37:48 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Mon, 09 Nov 2009 14:37:48 +0000 Subject: 6899147: java.beans.MetaData should not require JDBC to be present Message-ID: <4AF8293C.1040905@sun.com> Sergey, As we discussed today, the persistent delegate for java.sql.Timestamp in java.beans.Metadata creates an undesirable dependency on JDBC. I'd like to change this to use reflection so as to eliminate the static dependency. This doesn't change anything at runtime in that this persistent delegate will only be loaded if the type is a Timestamp. I've put the webrev with the change here: http://cr.openjdk.java.net/~alanb/6899147/webrev.00/ For testing, I've run the tests in test/java/beans/XMLEncoder - the java_sql_Timestamp.java test in particular, provides good coverage. Thanks, -Alan. From Sergey.Malenkov at Sun.COM Tue Nov 10 01:07:48 2009 From: Sergey.Malenkov at Sun.COM (Sergey Malenkov) Date: Tue, 10 Nov 2009 12:07:48 +0300 Subject: Approved: 6899147: java.beans.MetaData should not require JDBC to be present In-Reply-To: <4AF8293C.1040905@sun.com> References: <4AF8293C.1040905@sun.com> Message-ID: <4AF92D64.9040502@sun.com> Hi Alan, The fix looks good for me. I approve. Thanks, SAM Alan Bateman wrote: > Sergey, > > As we discussed today, the persistent delegate for java.sql.Timestamp in > java.beans.Metadata creates an undesirable dependency on JDBC. I'd like > to change this to use reflection so as to eliminate the static > dependency. This doesn't change anything at runtime in that this > persistent delegate will only be loaded if the type is a Timestamp. I've > put the webrev with the change here: > http://cr.openjdk.java.net/~alanb/6899147/webrev.00/ > > For testing, I've run the tests in test/java/beans/XMLEncoder - the > java_sql_Timestamp.java test in particular, provides good coverage. > > Thanks, > > -Alan. >