From xiomara.jayasena at sun.com Wed Jul 2 13:00:44 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 02 Jul 2008 20:00:44 +0000 Subject: hg: jdk7/build: 6719955: Update copyright year Message-ID: <20080702200044.9039C28852@hg.openjdk.java.net> Changeset: 2dab2f712e18 Author: xdono Date: 2008-07-02 12:55 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/2dab2f712e18 6719955: Update copyright year Summary: Update copyright year for files that have been modified in 2008 Reviewed-by: ohair, tbell ! Makefile ! make/Defs-internal.gmk ! make/jdk-rules.gmk From xiomara.jayasena at sun.com Wed Jul 2 13:01:53 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 02 Jul 2008 20:01:53 +0000 Subject: hg: jdk7/build/corba: 6719955: Update copyright year Message-ID: <20080702200155.628EF28857@hg.openjdk.java.net> Changeset: c0252adbb2ab Author: xdono Date: 2008-07-02 12:55 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/c0252adbb2ab 6719955: Update copyright year Summary: Update copyright year for files that have been modified in 2008 Reviewed-by: ohair, tbell ! make/common/shared/Compiler-sun.gmk ! make/common/shared/Defs.gmk ! make/jprt.config ! src/share/classes/org/omg/CORBA/ir.idl ! src/share/classes/org/omg/DynamicAny/DynamicAny.idl From xiomara.jayasena at sun.com Wed Jul 2 13:03:14 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 02 Jul 2008 20:03:14 +0000 Subject: hg: jdk7/build/hotspot: 6719955: Update copyright year Message-ID: <20080702200317.CF19C2885C@hg.openjdk.java.net> Changeset: d1605aabd0a1 Author: xdono Date: 2008-07-02 12:55 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/d1605aabd0a1 6719955: Update copyright year Summary: Update copyright year for files that have been modified in 2008 Reviewed-by: ohair, tbell ! agent/make/Makefile ! agent/src/os/linux/ps_core.c ! agent/src/os/linux/ps_proc.c ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/HSDB.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/SALauncherLoader.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/OopMapSet.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/OopMapValue.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/OopMapVisitor.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/Address.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/Debugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/JVMDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/MachineDescription.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/MachineDescriptionAMD64.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/MachineDescriptionIA64.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/MachineDescriptionIntelX86.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/MachineDescriptionSPARC32Bit.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/MachineDescriptionSPARC64Bit.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/dbx/DbxDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/dummy/DummyAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerServer.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Address.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32Debugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/win32/Win32DebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/SAJDIClassLoader.java ! agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java ! agent/src/share/classes/sun/jvm/hotspot/memory/CompactibleFreeListSpace.java ! agent/src/share/classes/sun/jvm/hotspot/memory/DefNewGeneration.java ! agent/src/share/classes/sun/jvm/hotspot/memory/FreeChunk.java ! agent/src/share/classes/sun/jvm/hotspot/memory/FreeList.java ! agent/src/share/classes/sun/jvm/hotspot/memory/LinearAllocBlock.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! agent/src/share/classes/sun/jvm/hotspot/memory/Universe.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Array.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCache.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCacheKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/DefaultOopVisitor.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Instance.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Klass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Mark.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjArray.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHistogram.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHistogramElement.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java ! agent/src/share/classes/sun/jvm/hotspot/oops/OopPrinter.java ! agent/src/share/classes/sun/jvm/hotspot/oops/OopUtilities.java ! agent/src/share/classes/sun/jvm/hotspot/oops/OopVisitor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/AddressVisitor.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Frame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/types/Field.java ! agent/src/share/classes/sun/jvm/hotspot/types/Type.java ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicField.java ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicFieldWrapper.java ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicOopField.java ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicType.java ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/ui/AnnotatedMemoryPanel.java ! agent/src/share/classes/sun/jvm/hotspot/ui/CommandProcessorPanel.java ! agent/src/share/classes/sun/jvm/hotspot/ui/DebuggerConsolePanel.java ! agent/src/share/classes/sun/jvm/hotspot/ui/FindInHeapPanel.java ! agent/src/share/classes/sun/jvm/hotspot/ui/HighPrecisionJScrollBar.java ! agent/src/share/classes/sun/jvm/hotspot/ui/JFrameWrapper.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/ui/treetable/JTreeTable.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/AbstractHeapGraphWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/ReversePtrsAnalysis.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/RobustOopDeterminator.java ! make/Makefile ! make/defs.make ! make/hotspot_distro ! make/hotspot_version ! make/jprt.config ! make/jprt.properties ! make/linux/Makefile ! make/linux/build.sh ! make/linux/makefiles/adjust-mflags.sh ! make/linux/makefiles/adlc.make ! make/linux/makefiles/amd64.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/compiler1.make ! make/linux/makefiles/compiler2.make ! make/linux/makefiles/core.make ! make/linux/makefiles/cscope.make ! make/linux/makefiles/debug.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/dtrace.make ! make/linux/makefiles/fastdebug.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/hp.make ! make/linux/makefiles/hp1.make ! make/linux/makefiles/i486.make ! make/linux/makefiles/ia64.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/jvmg.make ! make/linux/makefiles/jvmti.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/makedeps.make ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-jsig ! make/linux/makefiles/mapfile-vers-product ! make/linux/makefiles/optimized.make ! make/linux/makefiles/product.make ! make/linux/makefiles/profiled.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sa.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/sparc.make ! make/linux/makefiles/sparcWorks.make ! make/linux/makefiles/sparcv9.make ! make/linux/makefiles/tiered.make ! make/linux/makefiles/top.make ! make/linux/makefiles/vm.make ! make/openjdk_distro ! make/sa.files ! make/solaris/Makefile ! make/solaris/build.sh ! make/solaris/makefiles/adjust-mflags.sh ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/amd64.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/compiler1.make ! make/solaris/makefiles/compiler2.make ! make/solaris/makefiles/core.make ! make/solaris/makefiles/cscope.make ! make/solaris/makefiles/debug.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/hp.make ! make/solaris/makefiles/hp1.make ! make/solaris/makefiles/i486.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/jvmti.make ! make/solaris/makefiles/launcher.make ! make/solaris/makefiles/makedeps.make ! make/solaris/makefiles/mapfile-vers ! make/solaris/makefiles/mapfile-vers-COMPILER1 ! make/solaris/makefiles/mapfile-vers-COMPILER2 ! make/solaris/makefiles/mapfile-vers-CORE ! make/solaris/makefiles/mapfile-vers-TIERED ! make/solaris/makefiles/mapfile-vers-debug ! make/solaris/makefiles/mapfile-vers-jsig ! make/solaris/makefiles/mapfile-vers-jvm_db ! make/solaris/makefiles/mapfile-vers-jvm_dtrace ! make/solaris/makefiles/mapfile-vers-nonproduct ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/profiled.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/sa.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/sparcv9.make ! make/solaris/makefiles/tiered.make ! make/solaris/makefiles/top.make ! make/solaris/makefiles/vm.make ! make/solaris/reorder.sh ! make/test/Queens.java ! make/windows/build.bat ! make/windows/build.make ! make/windows/build_vm_def.sh ! make/windows/create.bat ! make/windows/cross_build.bat ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/generated.make ! make/windows/makefiles/jvmti.make ! make/windows/makefiles/makedeps.make ! make/windows/makefiles/product.make ! make/windows/makefiles/rules.make ! make/windows/makefiles/sa.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/shared.make ! make/windows/makefiles/top.make ! make/windows/makefiles/vm.make ! make/windows/projectfiles/common/Makefile ! make/windows/projectfiles/compiler1/Makefile ! make/windows/projectfiles/compiler2/Makefile ! make/windows/projectfiles/core/Makefile ! make/windows/projectfiles/tiered/Makefile ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/bytecodeInterpreter_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/copy_sparc.hpp ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.hpp ! src/cpu/sparc/vm/register_definitions_sparc.cpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/relocInfo_sparc.hpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86_32.cpp ! src/cpu/x86/vm/assembler_x86_32.hpp ! src/cpu/x86/vm/assembler_x86_64.cpp ! src/cpu/x86/vm/assembler_x86_64.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interpreter_x86_64.cpp ! src/cpu/x86/vm/nativeInst_x86.cpp ! src/cpu/x86/vm/nativeInst_x86.hpp ! src/cpu/x86/vm/register_definitions_x86.cpp ! src/cpu/x86/vm/relocInfo_x86.cpp ! src/cpu/x86/vm/relocInfo_x86.hpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86_32.cpp ! src/cpu/x86/vm/vm_version_x86_64.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os/linux/vm/attachListener_linux.cpp ! src/os/linux/vm/dtraceJSDT_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/jhelper.d ! src/os/solaris/dtrace/libjvm_db.c ! src/os/solaris/vm/dtraceJSDT_solaris.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/dtraceJSDT_windows.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/atomic_linux_sparc.inline.hpp ! src/os_cpu/linux_sparc/vm/globals_linux_sparc.hpp ! src/os_cpu/linux_sparc/vm/linux_sparc.ad ! src/os_cpu/linux_sparc/vm/linux_sparc.s ! src/os_cpu/linux_sparc/vm/orderAccess_linux_sparc.inline.hpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.hpp ! src/os_cpu/linux_sparc/vm/prefetch_linux_sparc.inline.hpp ! src/os_cpu/linux_sparc/vm/threadLS_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/threadLS_linux_sparc.hpp ! src/os_cpu/linux_sparc/vm/thread_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/thread_linux_sparc.hpp ! src/os_cpu/linux_sparc/vm/vmStructs_linux_sparc.hpp ! src/os_cpu/linux_sparc/vm/vm_version_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/assembler_linux_x86_32.cpp ! src/os_cpu/linux_x86/vm/assembler_linux_x86_64.cpp ! src/os_cpu/linux_x86/vm/bytes_linux_x86.inline.hpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/solaris_sparc.s ! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86_32.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86_64.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/thread_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86_32.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86_64.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethodBlocks.cpp ! src/share/vm/ci/ciMethodBlocks.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/debugInfo.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/scopeDesc.cpp ! src/share/vm/code/vmreg.cpp ! src/share/vm/code/vmreg.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/compiler/oopMap.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.inline.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp ! src/share/vm/gc_implementation/includeDB_gc_concurrentMarkSweep ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/includeDB_gc_shared ! src/share/vm/gc_implementation/parNew/asParNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parGCAllocBuffer.cpp ! src/share/vm/gc_implementation/parNew/parGCAllocBuffer.hpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.hpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/prefetchQueue.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionLAB.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionLAB.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_implementation/shared/allocationStats.cpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/immutableSpace.cpp ! src/share/vm/gc_implementation/shared/immutableSpace.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.hpp ! src/share/vm/gc_implementation/shared/mutableSpace.cpp ! src/share/vm/gc_implementation/shared/mutableSpace.hpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/includeDB_compiler1 ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/bytecodeInterpreterWithChecks.xml ! src/share/vm/interpreter/bytecodeInterpreterWithChecks.xsl ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/oopMapCache.cpp ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/memory/barrierSet.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/compactingPermGenGen.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/defNewGeneration.inline.hpp ! src/share/vm/memory/dump.cpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/genOopClosures.hpp ! src/share/vm/memory/genOopClosures.inline.hpp ! src/share/vm/memory/genRemSet.hpp ! src/share/vm/memory/genRemSet.inline.hpp ! src/share/vm/memory/generation.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/heap.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/modRefBarrierSet.hpp ! src/share/vm/memory/permGen.cpp ! src/share/vm/memory/permGen.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/memory/restore.cpp ! src/share/vm/memory/serialize.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolKlass.hpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheKlass.hpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceOop.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/markOop.hpp ! src/share/vm/oops/methodDataKlass.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/objArrayOop.cpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/oopsHierarchy.hpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/c2compiler.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/divnode.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/locknode.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/mulnode.hpp ! src/share/vm/opto/multnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/opcodes.cpp ! src/share/vm/opto/opcodes.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/subnode.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/opto/vectornode.cpp ! src/share/vm/opto/vectornode.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClassesTrace.hpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/dtraceJSDT.cpp ! src/share/vm/runtime/dtraceJSDT.hpp ! src/share/vm/runtime/fprofiler.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/hpi.cpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/java.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/mutex.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/task.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vframe.hpp ! src/share/vm/runtime/vframe_hp.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_operations.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/utilities/copy.hpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/globalDefinitions.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_sparcWorks.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.cpp ! test/compiler/6659207/Test.java ! test/compiler/6661247/Test.java ! test/compiler/6663621/IVTest.java From xiomara.jayasena at sun.com Wed Jul 2 13:04:27 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 02 Jul 2008 20:04:27 +0000 Subject: hg: jdk7/build/jaxp: 6719955: Update copyright year Message-ID: <20080702200430.2757E28863@hg.openjdk.java.net> Changeset: 2d94a238a164 Author: xdono Date: 2008-07-02 12:55 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/2d94a238a164 6719955: Update copyright year Summary: Update copyright year for files that have been modified in 2008 Reviewed-by: ohair, tbell ! make/Makefile From xiomara.jayasena at sun.com Wed Jul 2 13:05:39 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 02 Jul 2008 20:05:39 +0000 Subject: hg: jdk7/build/jaxws: 6719955: Update copyright year Message-ID: <20080702200541.9272A28868@hg.openjdk.java.net> Changeset: 7f2466f8cc70 Author: xdono Date: 2008-07-02 12:55 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/7f2466f8cc70 6719955: Update copyright year Summary: Update copyright year for files that have been modified in 2008 Reviewed-by: ohair, tbell ! make/Makefile From xiomara.jayasena at sun.com Wed Jul 2 13:07:08 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 02 Jul 2008 20:07:08 +0000 Subject: hg: jdk7/build/jdk: 6719955: Update copyright year Message-ID: <20080702200727.B33F72886D@hg.openjdk.java.net> Changeset: b6d6877c1155 Author: xdono Date: 2008-07-02 12:55 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b6d6877c1155 6719955: Update copyright year Summary: Update copyright year for files that have been modified in 2008 Reviewed-by: ohair, tbell ! make/com/sun/Makefile ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/Release.gmk ! make/common/Rules.gmk ! make/common/internal/BinaryPlugs.gmk ! make/common/internal/Defs-langtools.gmk ! make/common/shared/Compiler-gcc.gmk ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Compiler-sun.gmk ! make/common/shared/Defs-control.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Platform.gmk ! make/common/shared/Sanity.gmk ! make/docs/CORE_PKGS.gmk ! make/docs/Makefile ! make/docs/NON_CORE_PKGS.gmk ! make/java/awt/Makefile ! make/java/java/Makefile ! make/java/java/genlocales.gmk ! make/java/java/localegen.sh ! make/java/java/mapfile-vers ! make/java/jli/Makefile ! make/java/main/java/Makefile ! make/java/main/javaw/Makefile ! make/java/nio/Makefile ! make/java/nio/genCharsetProvider.sh ! make/java/nio/genExceptions.sh ! make/java/sun_nio/FILES_java.gmk ! make/javax/Makefile ! make/javax/others/Makefile ! make/jdk_generic_profile.sh ! make/jprt.config ! make/sun/Makefile ! make/sun/cmm/Makefile ! make/sun/font/FILES_c.gmk ! make/sun/font/Makefile ! make/sun/jawt/Makefile ! make/sun/splashscreen/Makefile ! make/tools/Makefile ! make/tools/freetypecheck/Makefile ! make/tools/freetypecheck/freetypecheck.c ! make/tools/src/build/tools/jdwpgen/CommandNode.java ! make/tools/src/build/tools/jdwpgen/ConstantSetNode.java ! make/tools/src/build/tools/jdwpgen/RepeatNode.java ! src/share/bin/java.h ! src/share/bin/main.c ! src/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFWritableImageMetadata.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKColorChooserPanel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java ! src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifGraphicsUtils.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifInternalFrameTitlePane.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/share/classes/com/sun/jmx/mbeanserver/ConvertingMethod.java ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanAnalyzer.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanIntrospector.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanSupport.java ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanIntrospector.java ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanLookup.java ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanProxy.java ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanSupport.java ! src/share/classes/com/sun/jmx/mbeanserver/NotificationMBeanSupport.java ! src/share/classes/com/sun/jmx/mbeanserver/PerInterface.java ! src/share/classes/com/sun/jmx/mbeanserver/Repository.java ! src/share/classes/com/sun/jmx/mbeanserver/StandardMBeanSupport.java ! src/share/classes/com/sun/jmx/mbeanserver/Util.java ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/security/FileLoginModule.java ! src/share/classes/com/sun/jmx/remote/security/JMXPluggableAuthenticator.java ! src/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/com/sun/tools/example/debug/bdi/EventRequestSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/EventRequestSpecList.java ! src/share/classes/com/sun/tools/example/debug/bdi/ExecutionManager.java ! src/share/classes/com/sun/tools/example/debug/bdi/JDIEventSource.java ! src/share/classes/com/sun/tools/example/debug/bdi/LineBreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/MethodBreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/ThreadGroupIterator.java ! src/share/classes/com/sun/tools/example/debug/bdi/ThreadIterator.java ! src/share/classes/com/sun/tools/example/debug/expr/LValue.java ! src/share/classes/com/sun/tools/example/debug/gui/ClassTreeTool.java ! src/share/classes/com/sun/tools/example/debug/gui/CommandInterpreter.java ! src/share/classes/com/sun/tools/example/debug/gui/JDBFileFilter.java ! src/share/classes/com/sun/tools/example/debug/gui/LaunchTool.java ! src/share/classes/com/sun/tools/example/debug/gui/SearchPath.java ! src/share/classes/com/sun/tools/example/debug/gui/SourceManager.java ! src/share/classes/com/sun/tools/example/debug/gui/SourceModel.java ! src/share/classes/com/sun/tools/example/debug/gui/StackTraceTool.java ! src/share/classes/com/sun/tools/example/debug/gui/ThreadTreeTool.java ! src/share/classes/com/sun/tools/example/debug/tty/BreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/Commands.java ! src/share/classes/com/sun/tools/example/debug/tty/Env.java ! src/share/classes/com/sun/tools/example/debug/tty/EventHandler.java ! src/share/classes/com/sun/tools/example/debug/tty/EventRequestSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/EventRequestSpecList.java ! src/share/classes/com/sun/tools/example/debug/tty/SourceMapper.java ! src/share/classes/com/sun/tools/example/debug/tty/TTY.java ! src/share/classes/com/sun/tools/example/debug/tty/ThreadGroupIterator.java ! src/share/classes/com/sun/tools/example/debug/tty/ThreadInfo.java ! src/share/classes/com/sun/tools/example/debug/tty/ThreadIterator.java ! src/share/classes/com/sun/tools/example/debug/tty/VMConnection.java ! src/share/classes/com/sun/tools/hat/Main.java ! src/share/classes/com/sun/tools/hat/build.xml ! src/share/classes/com/sun/tools/hat/internal/model/AbstractJavaHeapObjectVisitor.java ! src/share/classes/com/sun/tools/hat/internal/model/ArrayTypeCodes.java ! src/share/classes/com/sun/tools/hat/internal/model/HackJavaValue.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaBoolean.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaByte.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaChar.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaClass.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaDouble.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaField.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaFloat.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaHeapObject.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaHeapObjectVisitor.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaInt.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaLazyReadObject.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaLong.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaObject.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaObjectArray.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaObjectRef.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaShort.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaStatic.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaThing.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaValue.java ! src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java ! src/share/classes/com/sun/tools/hat/internal/model/ReachableExcludes.java ! src/share/classes/com/sun/tools/hat/internal/model/ReachableExcludesImpl.java ! src/share/classes/com/sun/tools/hat/internal/model/ReachableObjects.java ! src/share/classes/com/sun/tools/hat/internal/model/ReferenceChain.java ! src/share/classes/com/sun/tools/hat/internal/model/Root.java ! src/share/classes/com/sun/tools/hat/internal/model/Snapshot.java ! src/share/classes/com/sun/tools/hat/internal/model/StackFrame.java ! src/share/classes/com/sun/tools/hat/internal/model/StackTrace.java ! src/share/classes/com/sun/tools/hat/internal/oql/OQLEngine.java ! src/share/classes/com/sun/tools/hat/internal/oql/OQLException.java ! src/share/classes/com/sun/tools/hat/internal/oql/OQLQuery.java ! src/share/classes/com/sun/tools/hat/internal/oql/ObjectVisitor.java ! src/share/classes/com/sun/tools/hat/internal/parser/FileReadBuffer.java ! src/share/classes/com/sun/tools/hat/internal/parser/HprofReader.java ! src/share/classes/com/sun/tools/hat/internal/parser/MappedReadBuffer.java ! src/share/classes/com/sun/tools/hat/internal/parser/PositionDataInputStream.java ! src/share/classes/com/sun/tools/hat/internal/parser/PositionInputStream.java ! src/share/classes/com/sun/tools/hat/internal/parser/ReadBuffer.java ! src/share/classes/com/sun/tools/hat/internal/parser/Reader.java ! src/share/classes/com/sun/tools/hat/internal/server/AllClassesQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/AllRootsQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/ClassQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/FinalizerObjectsQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/FinalizerSummaryQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/HistogramQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/HttpReader.java ! src/share/classes/com/sun/tools/hat/internal/server/InstancesCountQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/InstancesQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/OQLHelp.java ! src/share/classes/com/sun/tools/hat/internal/server/OQLQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/ObjectQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/PlatformClasses.java ! src/share/classes/com/sun/tools/hat/internal/server/QueryHandler.java ! src/share/classes/com/sun/tools/hat/internal/server/QueryListener.java ! src/share/classes/com/sun/tools/hat/internal/server/ReachableQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/RefsByTypeQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/RootStackQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/RootsQuery.java ! src/share/classes/com/sun/tools/hat/internal/util/ArraySorter.java ! src/share/classes/com/sun/tools/hat/internal/util/Comparer.java ! src/share/classes/com/sun/tools/hat/internal/util/CompositeEnumeration.java ! src/share/classes/com/sun/tools/hat/internal/util/Misc.java ! src/share/classes/com/sun/tools/hat/internal/util/VectorSorter.java ! src/share/classes/com/sun/tools/hat/resources/hat.js ! src/share/classes/com/sun/tools/jdi/AbstractLauncher.java ! src/share/classes/com/sun/tools/jdi/ClassTypeImpl.java ! src/share/classes/com/sun/tools/jdi/ConcreteMethodImpl.java ! src/share/classes/com/sun/tools/jdi/EventSetImpl.java ! src/share/classes/com/sun/tools/jdi/JNITypeParser.java ! src/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/PacketStream.java ! src/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/share/classes/com/sun/tools/jdi/SDE.java ! src/share/classes/com/sun/tools/jdi/StackFrameImpl.java ! src/share/classes/com/sun/tools/jdi/TargetVM.java ! src/share/classes/com/sun/tools/jdi/ThreadGroupReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Color.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/GradientPaint.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/LinearGradientPaint.java ! src/share/classes/java/awt/MenuItem.java ! src/share/classes/java/awt/Paint.java ! src/share/classes/java/awt/RadialGradientPaint.java ! src/share/classes/java/awt/TexturePaint.java ! src/share/classes/java/awt/color/ColorSpace.java ! src/share/classes/java/awt/color/ICC_ColorSpace.java ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/awt/color/ICC_ProfileGray.java ! src/share/classes/java/awt/color/ICC_ProfileRGB.java ! src/share/classes/java/awt/dnd/DropTargetEvent.java ! src/share/classes/java/awt/event/AdjustmentEvent.java ! src/share/classes/java/awt/event/ComponentEvent.java ! src/share/classes/java/awt/event/ContainerEvent.java ! src/share/classes/java/awt/event/FocusEvent.java ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/awt/event/ItemEvent.java ! src/share/classes/java/awt/event/MouseEvent.java ! src/share/classes/java/awt/event/PaintEvent.java ! src/share/classes/java/awt/event/WindowEvent.java ! src/share/classes/java/awt/font/OpenType.java ! src/share/classes/java/awt/image/BandedSampleModel.java ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/classes/java/awt/image/ColorConvertOp.java ! src/share/classes/java/awt/image/ComponentSampleModel.java ! src/share/classes/java/awt/image/DataBuffer.java ! src/share/classes/java/awt/image/DataBufferByte.java ! src/share/classes/java/awt/image/DataBufferInt.java ! src/share/classes/java/awt/image/DataBufferShort.java ! src/share/classes/java/awt/image/DataBufferUShort.java ! src/share/classes/java/awt/image/MultiPixelPackedSampleModel.java ! src/share/classes/java/awt/image/Raster.java ! src/share/classes/java/awt/image/RenderedImage.java ! src/share/classes/java/awt/image/SampleModel.java ! src/share/classes/java/awt/image/SinglePixelPackedSampleModel.java ! src/share/classes/java/awt/image/WritableRaster.java ! src/share/classes/java/awt/image/WritableRenderedImage.java ! src/share/classes/java/awt/image/renderable/ContextualRenderedImageFactory.java ! src/share/classes/java/awt/image/renderable/RenderContext.java ! src/share/classes/java/awt/image/renderable/RenderableImage.java ! src/share/classes/java/awt/image/renderable/RenderableImageOp.java ! src/share/classes/java/awt/image/renderable/RenderableImageProducer.java ! src/share/classes/java/awt/image/renderable/RenderedImageFactory.java ! src/share/classes/java/beans/EventHandler.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Compiler.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/Process.java ! src/share/classes/java/lang/StringCoding.java ! src/share/classes/java/lang/instrument/Instrumentation.java ! src/share/classes/java/lang/management/ClassLoadingMXBean.java ! src/share/classes/java/lang/management/CompilationMXBean.java ! src/share/classes/java/lang/management/GarbageCollectorMXBean.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/MemoryMXBean.java ! src/share/classes/java/lang/management/MemoryManagerMXBean.java ! src/share/classes/java/lang/management/MemoryPoolMXBean.java ! src/share/classes/java/lang/management/OperatingSystemMXBean.java ! src/share/classes/java/lang/management/RuntimeMXBean.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/lang/management/ThreadMXBean.java ! src/share/classes/java/lang/ref/Finalizer.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/Modifier.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/CookieHandler.java ! src/share/classes/java/net/CookieManager.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/HttpCookie.java ! src/share/classes/java/net/InterfaceAddress.java ! src/share/classes/java/net/NetworkInterface.java ! src/share/classes/java/net/ResponseCache.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/nio/StringCharBuffer.java ! src/share/classes/java/nio/channels/Channels.java ! src/share/classes/java/nio/channels/spi/SelectorProvider.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/rmi/activation/ActivationGroupDesc.java ! src/share/classes/java/rmi/dgc/VMID.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/cert/TrustAnchor.java ! src/share/classes/java/security/cert/X509CertSelector.java ! src/share/classes/java/text/DictionaryBasedBreakIterator.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/EnumMap.java ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/JumboEnumSet.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/TreeSet.java ! src/share/classes/java/util/Vector.java ! src/share/classes/java/util/WeakHashMap.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/java/util/logging/LoggingMXBean.java ! src/share/classes/java/util/prefs/AbstractPreferences.java ! src/share/classes/java/util/prefs/Preferences.java ! src/share/classes/java/util/regex/Matcher.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/javax/imageio/stream/ImageInputStreamImpl.java ! src/share/classes/javax/management/AndQueryExp.java ! src/share/classes/javax/management/AttributeValueExp.java ! src/share/classes/javax/management/BetweenQueryExp.java ! src/share/classes/javax/management/BinaryOpValueExp.java ! src/share/classes/javax/management/BinaryRelQueryExp.java ! src/share/classes/javax/management/BooleanValueExp.java ! src/share/classes/javax/management/InQueryExp.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/MBeanServerInvocationHandler.java ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/MatchQueryExp.java ! src/share/classes/javax/management/NotQueryExp.java ! src/share/classes/javax/management/NumericValueExp.java ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/OrQueryExp.java ! src/share/classes/javax/management/QualifiedAttributeValueExp.java ! src/share/classes/javax/management/Query.java ! src/share/classes/javax/management/QueryEval.java ! src/share/classes/javax/management/QueryExp.java ! src/share/classes/javax/management/QueryNotificationFilter.java ! src/share/classes/javax/management/StandardMBean.java ! src/share/classes/javax/management/StringValueExp.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/loading/MLetParser.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfoSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanOperationInfo.java ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/monitor/CounterMonitor.java ! src/share/classes/javax/management/monitor/GaugeMonitor.java ! src/share/classes/javax/management/monitor/Monitor.java ! src/share/classes/javax/management/openmbean/ArrayType.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! src/share/classes/javax/management/openmbean/MXBeanMapping.java ! src/share/classes/javax/management/openmbean/MXBeanMappingClass.java ! src/share/classes/javax/management/openmbean/MXBeanMappingFactory.java ! src/share/classes/javax/management/openmbean/MXBeanMappingFactoryClass.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanConstructorInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanOperationInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenType.java ! src/share/classes/javax/management/openmbean/SimpleType.java ! src/share/classes/javax/management/openmbean/TabularType.java ! src/share/classes/javax/management/relation/RelationNotification.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationSupport.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/JMXServiceURL.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/timer/Timer.java ! src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java ! src/share/classes/javax/rmi/ssl/SslRMIClientSocketFactory.java ! src/share/classes/javax/rmi/ssl/SslRMIServerSocketFactory.java ! src/share/classes/javax/security/auth/kerberos/KeyImpl.java ! src/share/classes/javax/security/cert/X509Certificate.java ! src/share/classes/javax/swing/DebugGraphicsInfo.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JProgressBar.java ! src/share/classes/javax/swing/JScrollBar.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextArea.java ! src/share/classes/javax/swing/JTextPane.java ! src/share/classes/javax/swing/MenuSelectionManager.java ! src/share/classes/javax/swing/Popup.java ! src/share/classes/javax/swing/PopupFactory.java ! src/share/classes/javax/swing/ScrollPaneLayout.java ! src/share/classes/javax/swing/SpinnerNumberModel.java ! src/share/classes/javax/swing/TablePrintable.java ! src/share/classes/javax/swing/filechooser/FileSystemView.java ! src/share/classes/javax/swing/plaf/FileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicButtonUI.java ! src/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarUI.java ! src/share/classes/javax/swing/plaf/metal/MetalIconFactory.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/SynthArrowButton.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/plaf/synth/doc-files/synth.dtd ! src/share/classes/javax/swing/table/TableColumn.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/FlowView.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/Segment.java ! src/share/classes/javax/swing/text/StyleConstants.java ! src/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/parser/AttributeList.java ! src/share/classes/javax/swing/text/html/parser/DTD.java ! src/share/classes/javax/swing/text/html/parser/Element.java ! src/share/classes/javax/swing/text/html/parser/Entity.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/text/rtf/RTFAttributes.java ! src/share/classes/javax/swing/text/rtf/RTFGenerator.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/sun/applet/AppletPanel.java ! src/share/classes/sun/applet/AppletViewer.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/awt/im/InputContext.java ! src/share/classes/sun/awt/image/SunVolatileImage.java ! src/share/classes/sun/awt/shell/ShellFolder.java ! src/share/classes/sun/awt/shell/ShellFolderManager.java ! src/share/classes/sun/font/AttributeValues.java ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/Font2D.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/FontResolver.java ! src/share/classes/sun/font/GlyphLayout.java ! src/share/classes/sun/font/PhysicalStrike.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/share/classes/sun/font/Type1Font.java ! src/share/classes/sun/instrument/InstrumentationImpl.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/loops/SurfaceType.java ! src/share/classes/sun/management/ClassLoadingImpl.java ! src/share/classes/sun/management/CompilationImpl.java ! src/share/classes/sun/management/Flag.java ! src/share/classes/sun/management/GarbageCollectorImpl.java ! src/share/classes/sun/management/GcInfoBuilder.java ! src/share/classes/sun/management/GcInfoCompositeData.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/classes/sun/management/HotspotCompilation.java ! src/share/classes/sun/management/HotspotInternal.java ! src/share/classes/sun/management/LockDataConverter.java ! src/share/classes/sun/management/ManagementFactoryHelper.java ! src/share/classes/sun/management/MappedMXBeanType.java ! src/share/classes/sun/management/MemoryImpl.java ! src/share/classes/sun/management/MemoryManagerImpl.java ! src/share/classes/sun/management/MemoryNotifInfoCompositeData.java ! src/share/classes/sun/management/MemoryPoolImpl.java ! src/share/classes/sun/management/MemoryUsageCompositeData.java ! src/share/classes/sun/management/MonitorInfoCompositeData.java ! src/share/classes/sun/management/NotificationEmitterSupport.java ! src/share/classes/sun/management/OperatingSystemImpl.java ! src/share/classes/sun/management/RuntimeImpl.java ! src/share/classes/sun/management/StackTraceElementCompositeData.java ! src/share/classes/sun/management/ThreadImpl.java ! src/share/classes/sun/management/ThreadInfoCompositeData.java ! src/share/classes/sun/management/Util.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/classes/sun/management/VMOptionCompositeData.java ! src/share/classes/sun/management/snmp/jvminstr/JvmMemPoolEntryImpl.java ! src/share/classes/sun/misc/ClassFileTransformer.java ! src/share/classes/sun/misc/Cleaner.java ! src/share/classes/sun/misc/ExtensionDependency.java ! src/share/classes/sun/misc/GC.java ! src/share/classes/sun/misc/Launcher.java ! src/share/classes/sun/misc/PerformanceLogger.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/misc/URLClassPath.java ! src/share/classes/sun/net/NetProperties.java ! src/share/classes/sun/net/NetworkClient.java ! src/share/classes/sun/net/ftp/FtpClient.java ! src/share/classes/sun/net/spi/DefaultProxySelector.java ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/MimeTable.java ! src/share/classes/sun/net/www/http/ChunkedOutputStream.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/http/KeepAliveCache.java ! src/share/classes/sun/net/www/http/KeepAliveStream.java ! src/share/classes/sun/net/www/http/KeepAliveStreamCleaner.java ! src/share/classes/sun/net/www/protocol/ftp/FtpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/InMemoryCookieStore.java ! src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java ! src/share/classes/sun/net/www/protocol/jar/URLJarFile.java ! src/share/classes/sun/net/www/protocol/mailto/MailToURLConnection.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/share/classes/sun/nio/ch/NativeThreadSet.java ! src/share/classes/sun/nio/ch/Reflect.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/Util.java ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! src/share/classes/sun/print/PSPathGraphics.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/print/RasterPrinterJob.java ! src/share/classes/sun/print/ServiceDialog.java ! src/share/classes/sun/reflect/ClassDefiner.java ! src/share/classes/sun/reflect/MethodAccessorGenerator.java ! src/share/classes/sun/reflect/ReflectionFactory.java ! src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java ! src/share/classes/sun/reflect/misc/MethodUtil.java ! src/share/classes/sun/rmi/log/ReliableLog.java ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/rmic/RemoteClass.java ! src/share/classes/sun/rmi/rmic/newrmic/jrmp/RemoteClass.java ! src/share/classes/sun/rmi/runtime/Log.java ! src/share/classes/sun/rmi/server/LoaderHandler.java ! src/share/classes/sun/rmi/server/MarshalInputStream.java ! src/share/classes/sun/rmi/server/MarshalOutputStream.java ! src/share/classes/sun/rmi/server/Util.java ! src/share/classes/sun/rmi/server/WeakClassHashMap.java ! src/share/classes/sun/rmi/transport/DGCClient.java ! src/share/classes/sun/rmi/transport/Target.java ! src/share/classes/sun/rmi/transport/Transport.java ! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java ! src/share/classes/sun/rmi/transport/proxy/HttpSendSocket.java ! src/share/classes/sun/rmi/transport/proxy/RMIMasterSocketFactory.java ! src/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java ! src/share/classes/sun/security/jgss/GSSManagerImpl.java ! src/share/classes/sun/security/jgss/krb5/InitSecContextToken.java ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KrbTgsReq.java ! src/share/classes/sun/security/krb5/internal/ETypeInfo2.java ! src/share/classes/sun/security/krb5/internal/crypto/dk/AesDkCrypto.java ! src/share/classes/sun/security/krb5/internal/crypto/dk/ArcFourCrypto.java ! src/share/classes/sun/security/provider/certpath/OCSPChecker.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/DHCrypt.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/InputRecord.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/OutputRecord.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/share/classes/sun/security/ssl/SessionId.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/tools/PolicyTool.java ! src/share/classes/sun/security/validator/EndEntityChecker.java ! src/share/classes/sun/security/x509/AVA.java ! src/share/classes/sun/security/x509/CertificatePolicySet.java ! src/share/classes/sun/security/x509/X509Cert.java ! src/share/classes/sun/swing/FilePane.java ! src/share/classes/sun/swing/WindowsPlacesBar.java ! src/share/classes/sun/text/normalizer/VersionInfo.java ! src/share/classes/sun/tools/jar/JarVerifierStream.java ! src/share/classes/sun/tools/jconsole/MBeansTab.java ! src/share/classes/sun/tools/jconsole/MemoryPoolStat.java ! src/share/classes/sun/tools/jconsole/ProxyClient.java ! src/share/classes/sun/tools/jconsole/VMPanel.java ! src/share/classes/sun/tools/jconsole/inspector/OperationEntry.java ! src/share/classes/sun/tools/jconsole/inspector/TableSorter.java ! src/share/classes/sun/tools/jconsole/inspector/ThreadDialog.java ! src/share/classes/sun/tools/jconsole/inspector/Utils.java ! src/share/classes/sun/tools/jconsole/inspector/XDataViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XMBean.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanAttributes.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanInfo.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanNotifications.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanOperations.java ! src/share/classes/sun/tools/jconsole/inspector/XObject.java ! src/share/classes/sun/tools/jconsole/inspector/XOperations.java ! src/share/classes/sun/tools/jconsole/inspector/XPlotter.java ! src/share/classes/sun/tools/jconsole/inspector/XPlottingViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XSheet.java ! src/share/classes/sun/tools/jconsole/inspector/XTable.java ! src/share/classes/sun/tools/jconsole/inspector/XTextField.java ! src/share/classes/sun/tools/jconsole/inspector/XTextFieldEditor.java ! src/share/classes/sun/tools/jconsole/inspector/XTree.java ! src/share/classes/sun/tools/native2ascii/N2AFilter.java ! src/share/instrument/InvocationAdapter.c ! src/share/instrument/JPLISAgent.c ! src/share/instrument/JPLISAgent.h ! src/share/instrument/JarFacade.c ! src/share/instrument/Reentrancy.c ! src/share/instrument/Utilities.c ! src/share/javavm/export/jvm.h ! src/share/native/java/io/io_util.c ! src/share/native/java/lang/System.c ! src/share/native/java/net/net_util.c ! src/share/native/sun/java2d/loops/AlphaMacros.h ! src/share/native/sun/java2d/loops/ByteGray.h ! src/share/native/sun/java2d/loops/FourByteAbgr.h ! src/share/native/sun/java2d/loops/FourByteAbgrPre.h ! src/share/native/sun/java2d/loops/Index12Gray.h ! src/share/native/sun/java2d/loops/Index8Gray.h ! src/share/native/sun/java2d/loops/IntArgb.h ! src/share/native/sun/java2d/loops/IntArgbBm.h ! src/share/native/sun/java2d/loops/IntArgbPre.h ! src/share/native/sun/java2d/loops/IntBgr.h ! src/share/native/sun/java2d/loops/IntRgb.h ! src/share/native/sun/java2d/loops/IntRgbx.h ! src/share/native/sun/java2d/loops/LoopMacros.h ! src/share/native/sun/java2d/loops/ThreeByteBgr.h ! src/share/native/sun/java2d/loops/Ushort4444Argb.h ! src/share/native/sun/java2d/loops/Ushort555Rgb.h ! src/share/native/sun/java2d/loops/Ushort555Rgbx.h ! src/share/native/sun/java2d/loops/Ushort565Rgb.h ! src/share/native/sun/java2d/loops/UshortGray.h ! src/share/sample/vm/clr-jvm/Makefile ! src/share/sample/vm/clr-jvm/invoker.cs ! src/share/sample/vm/jvm-clr/invoked.cs ! src/solaris/bin/java_md.c ! src/solaris/classes/java/io/FileDescriptor.java ! src/solaris/classes/java/lang/ProcessImpl.java ! src/solaris/classes/java/net/PlainSocketImpl.java ! src/solaris/classes/java/util/prefs/FileSystemPreferences.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java ! src/solaris/classes/sun/awt/X11/XScrollbar.java ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/classes/sun/awt/motif/MDialogPeer.java ! src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/motif/MFramePeer.java ! src/solaris/classes/sun/awt/motif/MWindowPeer.java ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/NativeThread.java ! src/solaris/classes/sun/print/AttributeClass.java ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintJob.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! src/solaris/classes/sun/security/provider/NativePRNG.java ! src/solaris/hpi/native_threads/src/sys_api_td.c ! src/solaris/hpi/src/linker_md.c ! src/solaris/native/java/io/FileOutputStream_md.c ! src/solaris/native/java/io/UnixFileSystem_md.c ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainSocketImpl.c ! src/solaris/native/sun/awt/MouseInfo.c ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/splashscreen/splashscreen_sys.c ! src/solaris/native/sun/java2d/loops/vis_FourByteAbgr.c ! src/solaris/native/sun/java2d/loops/vis_FourByteAbgrPre.c ! src/solaris/native/sun/java2d/loops/vis_IntArgb.c ! src/solaris/native/sun/java2d/loops/vis_IntArgbPre.c ! src/solaris/native/sun/nio/ch/FileChannelImpl.c ! src/solaris/native/sun/security/pkcs11/wrapper/p11_md.c ! src/solaris/native/sun/xawt/XWindow.c ! src/solaris/native/sun/xawt/XlibWrapper.c ! src/windows/bin/java_md.c ! src/windows/classes/java/io/FileDescriptor.java ! src/windows/classes/java/lang/ProcessImpl.java ! src/windows/classes/java/net/DualStackPlainSocketImpl.java ! src/windows/classes/java/net/PlainSocketImpl.java ! src/windows/classes/java/net/TwoStacksPlainSocketImpl.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java ! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java ! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java ! src/windows/classes/sun/awt/windows/WDataTransferer.java ! src/windows/classes/sun/awt/windows/WDialogPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFramePeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java ! src/windows/classes/sun/awt/windows/WInputMethod.java ! src/windows/classes/sun/awt/windows/WPanelPeer.java ! src/windows/classes/sun/awt/windows/WPathGraphics.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/classes/sun/nio/ch/NativeThread.java ! src/windows/classes/sun/print/Win32PrintService.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java ! src/windows/native/java/io/FileOutputStream_md.c ! src/windows/native/java/io/WinNTFileSystem_md.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.h ! src/windows/native/java/lang/ProcessImpl_md.c ! src/windows/native/java/lang/java_props_md.c ! src/windows/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet6AddressImpl.c ! src/windows/native/sun/net/www/protocol/http/NTLMAuthSequence.c ! src/windows/native/sun/security/krb5/NativeCreds.c ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_TrayIcon.cpp ! src/windows/native/sun/windows/awt_TrayIcon.h ! test/com/sun/crypto/provider/KeyFactory/TestProviderLeak.java ! test/com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java ! test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticOptions.java ! test/com/sun/management/HotSpotDiagnosticMXBean/GetVMOption.java ! test/com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java ! test/java/awt/Component/isLightweightCrash/IsLightweightCrash.java ! test/java/awt/Component/isLightweightCrash/StubPeerCrash.java ! test/java/awt/Focus/RestoreFocusOnDisabledComponentTest/RestoreFocusOnDisabledComponentTest.java ! test/java/awt/Mixing/ValidBounds.java ! test/java/awt/Modal/WsDisabledStyle/CloseBlocker/CloseBlocker.java ! test/java/awt/Modal/WsDisabledStyle/OverBlocker/OverBlocker.java ! test/java/awt/Modal/WsDisabledStyle/Winkey/Winkey.java ! test/java/awt/event/MouseEvent/SmoothWheel/SmoothWheel.java ! test/java/awt/font/Threads/FontThread.java ! test/java/beans/Introspector/Test4896879.java ! test/java/beans/Introspector/Test4935607.java ! test/java/beans/XMLEncoder/Test4935607.java ! test/java/io/File/SetLastModified.java ! test/java/io/File/SetReadOnly.java ! test/java/io/FileOutputStream/AtomicAppend.java ! test/java/lang/ProcessBuilder/Basic.java ! test/java/lang/System/Versions.java ! test/java/lang/instrument/BootClassPath/BootClassPathTest.sh ! test/java/lang/instrument/MakeJAR2.sh ! test/java/lang/instrument/NativeMethodPrefixAgent.java ! test/java/lang/instrument/PremainClass/DummyMain.java ! test/java/lang/instrument/PremainClass/PremainClassTest.sh ! test/java/lang/instrument/RetransformAgent.java ! test/java/lang/instrument/TransformerManagementThreadAddTests.java ! test/java/lang/instrument/TransformerManagementThreadRemoveTests.java ! test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh ! test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh ! test/java/net/CookieHandler/CookieManagerTest.java ! test/java/nio/Buffer/StringCharBufferSliceTest.java ! test/java/nio/channels/AsyncCloseAndInterrupt.java ! test/java/nio/channels/SocketChannel/AsyncCloseChannel.java ! test/java/nio/channels/TestUtil.java ! test/java/rmi/activation/Activatable/createPrivateActivable/CreatePrivateActivatable.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails_Stub.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateMe.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ShutdownThread.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup_Stub.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/MyActivationGroupImpl.java ! test/java/rmi/activation/ActivationGroupDesc/checkDefaultGroupName/CheckDefaultGroupName.java ! test/java/rmi/activation/ActivationSystem/activeGroup/IdempotentActiveGroup.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ActivateMe.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor_Stub.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/CanCreateStubs.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/ActivateMe.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/java/rmi/dgc/VMID/CheckVMID.java ! test/java/rmi/dgc/dgcAckFailure/DGCAckFailure.java ! test/java/rmi/dgc/dgcAckFailure/DGCAckFailure_Stub.java ! test/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation.java ! test/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation_Stub.java ! test/java/rmi/dgc/retryDirtyCalls/RetryDirtyCalls.java ! test/java/rmi/dgc/retryDirtyCalls/RetryDirtyCalls_Stub.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/altSecurityManager/TestSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/classPathCodebase/ClassPathCodebase.java ! test/java/rmi/registry/classPathCodebase/Dummy.java ! test/java/rmi/registry/emptyName/EmptyName.java ! test/java/rmi/registry/interfaceHash/InterfaceHash.java ! test/java/rmi/registry/interfaceHash/ReferenceRegistryStub.java ! test/java/rmi/registry/multipleRegistries/MultipleRegistries.java ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/reliability/benchmark/bench/rmi/BenchServer.java ! test/java/rmi/reliability/benchmark/bench/rmi/BenchServerImpl.java ! test/java/rmi/reliability/benchmark/bench/rmi/BooleanArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/BooleanCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ByteArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ByteCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/CharArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/CharCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ClassLoading.java ! test/java/rmi/reliability/benchmark/bench/rmi/DoubleArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/DoubleCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ExceptionCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ExportObjs.java ! test/java/rmi/reliability/benchmark/bench/rmi/FloatArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/FloatCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/IntArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/IntCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/LongArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/LongCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/Main.java ! test/java/rmi/reliability/benchmark/bench/rmi/NullCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ObjArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ObjTreeCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ProxyArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/RemoteObjArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ShortArrayCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/ShortCalls.java ! test/java/rmi/reliability/benchmark/bench/rmi/SmallObjTreeCalls.java ! test/java/rmi/reliability/benchmark/bench/serial/BooleanArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Booleans.java ! test/java/rmi/reliability/benchmark/bench/serial/ByteArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Bytes.java ! test/java/rmi/reliability/benchmark/bench/serial/CharArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Chars.java ! test/java/rmi/reliability/benchmark/bench/serial/ClassDesc.java ! test/java/rmi/reliability/benchmark/bench/serial/Cons.java ! test/java/rmi/reliability/benchmark/bench/serial/CustomDefaultObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/CustomObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/DoubleArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Doubles.java ! test/java/rmi/reliability/benchmark/bench/serial/ExternObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/FloatArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Floats.java ! test/java/rmi/reliability/benchmark/bench/serial/GetPutFieldTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/IntArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Ints.java ! test/java/rmi/reliability/benchmark/bench/serial/LongArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Longs.java ! test/java/rmi/reliability/benchmark/bench/serial/Main.java ! test/java/rmi/reliability/benchmark/bench/serial/ObjArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/ObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/ProxyArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/ProxyClassDesc.java ! test/java/rmi/reliability/benchmark/bench/serial/RepeatObjs.java ! test/java/rmi/reliability/benchmark/bench/serial/ReplaceTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/ShortArrays.java ! test/java/rmi/reliability/benchmark/bench/serial/Shorts.java ! test/java/rmi/reliability/benchmark/bench/serial/SmallObjTrees.java ! test/java/rmi/reliability/benchmark/bench/serial/StreamBuffer.java ! test/java/rmi/reliability/benchmark/bench/serial/Strings.java ! test/java/rmi/reliability/juicer/Apple.java ! test/java/rmi/reliability/juicer/AppleEvent.java ! test/java/rmi/reliability/juicer/AppleImpl.java ! test/java/rmi/reliability/juicer/AppleUser.java ! test/java/rmi/reliability/juicer/AppleUserImpl.java ! test/java/rmi/reliability/juicer/ApplicationServer.java ! test/java/rmi/reliability/juicer/Orange.java ! test/java/rmi/reliability/juicer/OrangeEcho.java ! test/java/rmi/reliability/juicer/OrangeEchoImpl.java ! test/java/rmi/reliability/juicer/OrangeImpl.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/CompressConstants.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/CompressInputStream.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/CompressOutputStream.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/Echo.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/EchoImpl.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/EchoImpl_Stub.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/MultiSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/Compress.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/Hello.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/HelloImpl.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/HelloImpl_Stub.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/CompressConstants.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/CompressInputStream.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/CompressOutputStream.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/Echo.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/EchoImpl.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/EchoImpl_Stub.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/MultiSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/UseCustomSocketFactory.java ! test/java/rmi/server/RemoteServer/setLogPermission/SetLogPermission.java ! test/java/rmi/server/UnicastRemoteObject/changeHostName/ChangeHostName.java ! test/java/rmi/server/UnicastRemoteObject/changeHostName/ChangeHostName_Stub.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall_Stub.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/Shutdown.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/ShutdownImpl.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/ShutdownImpl_Stub.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/ShutdownMonitor.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport2.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport2_Stub.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport_Stub.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/Ping.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak_Stub.java ! test/java/rmi/server/UnicastRemoteObject/useDynamicProxies/UseDynamicProxies.java ! test/java/rmi/server/UnicastRemoteObject/useDynamicProxies/UseDynamicProxies_Stub.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshalOnStopThread.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshalOnStopThread_Stub.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/PoisonPill.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/RuntimeExceptionParameter.java ! test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency.java ! test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency_Stub.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval_Stub.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/SelfTerminator.java ! test/java/rmi/server/Unreferenced/marshalledObjectGet/MarshalledObjectGet.java ! test/java/rmi/server/Unreferenced/marshalledObjectGet/MarshalledObjectGet_Stub.java ! test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext.java ! test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext_Stub.java ! test/java/rmi/transport/acceptLoop/CloseServerSocketOnTermination.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkFQDN/CheckFQDNClient.java ! test/java/rmi/transport/checkFQDN/CheckFQDN_Stub.java ! test/java/rmi/transport/checkFQDN/TellServerName.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak_Stub.java ! test/java/rmi/transport/checkLeaseInfoLeak/LeaseLeak.java ! test/java/rmi/transport/checkLeaseInfoLeak/LeaseLeakClient.java ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java ! test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java ! test/java/rmi/transport/dgcDeadLock/Test.java ! test/java/rmi/transport/dgcDeadLock/TestImpl.java ! test/java/rmi/transport/dgcDeadLock/TestImpl_Stub.java ! test/java/rmi/transport/handshakeFailure/HandshakeFailure.java ! test/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java ! test/java/rmi/transport/httpSocket/HttpSocketTest.java ! test/java/rmi/transport/httpSocket/HttpSocketTest_Stub.java ! test/java/rmi/transport/pinClientSocketFactory/PinClientSocketFactory.java ! test/java/rmi/transport/pinLastArguments/PinLastArguments.java ! test/java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java ! test/java/rmi/transport/readTimeout/ReadTimeoutTest.java ! test/java/rmi/transport/readTimeout/TestIface.java ! test/java/rmi/transport/readTimeout/TestImpl.java ! test/java/rmi/transport/readTimeout/TestImpl_Stub.java ! test/java/rmi/transport/reuseDefaultPort/ReuseDefaultPort.java ! test/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java ! test/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak_Stub.java ! test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java ! test/java/util/concurrent/SynchronousQueue/Fairness.java ! test/javax/management/mxbean/CustomTypeTest.java ! test/javax/management/mxbean/JMXServiceURLTest.java ! test/javax/management/mxbean/customtypes/CustomLongMXBean.java ! test/javax/management/mxbean/customtypes/CustomMXBean.java ! test/javax/management/mxbean/customtypes/IntegerIsLongFactory.java ! test/javax/management/mxbean/customtypes/IntegerIsStringFactory.java ! test/javax/management/mxbean/customtypes/package-info.java ! test/javax/management/query/QueryExpStringTest.java ! test/javax/management/query/QueryNotifFilterTest.java ! test/javax/management/relation/RelationNotificationSeqNoTest.java ! test/javax/swing/JFileChooser/4252173/bug4252173.java ! test/javax/swing/JSlider/4987336/bug4987336.java ! test/sun/java2d/cmm/ProfileOp/ReadProfileTest.java ! test/sun/management/HotspotClassLoadingMBean/GetClassInitializationTime.java ! test/sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java ! test/sun/management/HotspotClassLoadingMBean/GetInitializedClassCount.java ! test/sun/management/HotspotClassLoadingMBean/GetLoadedClassSize.java ! test/sun/management/HotspotClassLoadingMBean/GetMethodDataSize.java ! test/sun/management/HotspotClassLoadingMBean/GetUnloadedClassSize.java ! test/sun/management/HotspotRuntimeMBean/GetSafepointCount.java ! test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java ! test/sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java ! test/sun/management/HotspotThreadMBean/GetInternalThreads.java ! test/sun/net/www/http/ChunkedOutputStream/Test.java ! test/sun/security/krb5/OptionPADataInKDCReq.java ! test/sun/security/krb5/TimeInCCache.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/AsyncSSLSocketClose.java ! test/sun/security/tools/keytool/StartDateTest.java ! test/sun/security/tools/keytool/console.sh From xiomara.jayasena at sun.com Wed Jul 2 13:08:38 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 02 Jul 2008 20:08:38 +0000 Subject: hg: jdk7/build/langtools: 6719955: Update copyright year Message-ID: <20080702200841.8ACF728872@hg.openjdk.java.net> Changeset: eaf608c64fec Author: xdono Date: 2008-07-02 12:56 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/eaf608c64fec 6719955: Update copyright year Summary: Update copyright year for files that have been modified in 2008 Reviewed-by: ohair, tbell ! make/build.xml ! make/netbeans/common/standard-ide-actions-no-javadoc.ent ! make/netbeans/common/standard-ide-actions.ent ! src/share/classes/com/sun/tools/apt/main/JavaCompiler.java ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/classfile/AccessFlags.java ! src/share/classes/com/sun/tools/classfile/Annotation.java ! src/share/classes/com/sun/tools/classfile/AnnotationDefault_attribute.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/Attributes.java ! src/share/classes/com/sun/tools/classfile/CharacterRangeTable_attribute.java ! src/share/classes/com/sun/tools/classfile/ClassFile.java ! src/share/classes/com/sun/tools/classfile/ClassReader.java ! src/share/classes/com/sun/tools/classfile/Code_attribute.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/classfile/ConstantValue_attribute.java ! src/share/classes/com/sun/tools/classfile/DefaultAttribute.java ! src/share/classes/com/sun/tools/classfile/Deprecated_attribute.java ! src/share/classes/com/sun/tools/classfile/Descriptor.java ! src/share/classes/com/sun/tools/classfile/EnclosingMethod_attribute.java ! src/share/classes/com/sun/tools/classfile/Exceptions_attribute.java ! src/share/classes/com/sun/tools/classfile/Field.java ! src/share/classes/com/sun/tools/classfile/InnerClasses_attribute.java ! src/share/classes/com/sun/tools/classfile/LineNumberTable_attribute.java ! src/share/classes/com/sun/tools/classfile/LocalVariableTable_attribute.java ! src/share/classes/com/sun/tools/classfile/LocalVariableTypeTable_attribute.java ! src/share/classes/com/sun/tools/classfile/Method.java ! src/share/classes/com/sun/tools/classfile/ModuleExportTable_attribute.java ! src/share/classes/com/sun/tools/classfile/ModuleMemberTable_attribute.java ! src/share/classes/com/sun/tools/classfile/Module_attribute.java ! src/share/classes/com/sun/tools/classfile/OpCodes.java ! src/share/classes/com/sun/tools/classfile/RuntimeAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeInvisibleAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeInvisibleParameterAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeParameterAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeVisibleAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/RuntimeVisibleParameterAnnotations_attribute.java ! src/share/classes/com/sun/tools/classfile/Signature.java ! src/share/classes/com/sun/tools/classfile/Signature_attribute.java ! src/share/classes/com/sun/tools/classfile/SourceDebugExtension_attribute.java ! src/share/classes/com/sun/tools/classfile/SourceFile_attribute.java ! src/share/classes/com/sun/tools/classfile/StackMapTable_attribute.java ! src/share/classes/com/sun/tools/classfile/StackMap_attribute.java ! src/share/classes/com/sun/tools/classfile/Synthetic_attribute.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Old199.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/JavacOption.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/parser/Parser.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/DiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/BasicWriter.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/ConstantWriter.java ! src/share/classes/com/sun/tools/javap/Context.java ! src/share/classes/com/sun/tools/javap/DisassemblerTool.java ! src/share/classes/com/sun/tools/javap/InternalError.java ! src/share/classes/com/sun/tools/javap/JavapFileManager.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/Main.java ! src/share/classes/com/sun/tools/javap/Options.java ! src/share/classes/sun/tools/javap/ClassData.java ! src/share/classes/sun/tools/javap/FieldData.java ! src/share/classes/sun/tools/javap/InnerClassData.java ! src/share/classes/sun/tools/javap/JavapPrinter.java ! src/share/classes/sun/tools/javap/Main.java ! src/share/classes/sun/tools/javap/MethodData.java ! src/share/classes/sun/tools/javap/Tables.java ! src/share/classes/sun/tools/javap/TypeSignature.java ! test/tools/javac/6304921/TestLog.java ! test/tools/javac/6341866/T6341866.java ! test/tools/javac/T6358024.java ! test/tools/javac/T6358166.java ! test/tools/javac/T6358168.java ! test/tools/javac/api/6431257/T6431257.java ! test/tools/javac/api/T6358786.java ! test/tools/javac/api/TestResolveIdent.java ! test/tools/javac/generics/Casting5.java ! test/tools/javac/generics/InheritanceConflict.java ! test/tools/javac/generics/InheritanceConflict2.java ! test/tools/javac/generics/wildcards/T6450290.java ! test/tools/javac/util/filemanager/TestName.java ! test/tools/javap/OptionTest.java From martinrb at google.com Wed Jul 2 16:09:25 2008 From: martinrb at google.com (Martin Buchholz) Date: Wed, 2 Jul 2008 16:09:25 -0700 Subject: OpenJDK 7 build failure in com/sun/tools Message-ID: <1ccfd1c10807021609u7c6f5134qa4e93c3a1451bade@mail.gmail.com> While building images in a mercurial workspace updated as of today, I get /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/classfile : no such file or directory /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/javap : no such file or directory make[1]: *** [initial-image-jdk] Error 1 make[1]: Leaving directory `/usr/local/google/home/martin/ws/build/jdk/make' make: *** [jdk-build] Error 2 The failing command appears to be a (very long) jar command invoked from Release.gmk $(BOOT_JAR_CMD) c0f $(LIBDIR)/tools.jar $(addprefix \ -C $(CLASSBINDIR) , $(TOOLS)) \ $(JAR_JFLAGS) This happens both building a complete OpenJDK forest and when building the "jdk" repository. 32-bit linux Ubuntu 6.06 This is a very recently introduced failure (over the past week?). Fortunately, there is a workaround that's not too painful. Simply create the two missing directories and restart the build. Even javap works! I'm currently successfully building like this: make clobber; mkdir -p ../build/linux-i586/classes/com/sun/tools/{classfile,javap}; make all images But it's still a P1 bug, right? Martin From Tim.Bell at Sun.COM Wed Jul 2 16:55:26 2008 From: Tim.Bell at Sun.COM (Tim Bell) Date: Wed, 02 Jul 2008 16:55:26 -0700 Subject: OpenJDK 7 build failure in com/sun/tools In-Reply-To: <1ccfd1c10807021609u7c6f5134qa4e93c3a1451bade@mail.gmail.com> References: <1ccfd1c10807021609u7c6f5134qa4e93c3a1451bade@mail.gmail.com> Message-ID: <486C156E.8010506@sun.com> Hi Martin: > While building images in a mercurial workspace updated as of today, I get > > /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/classfile > : no such file or directory > /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/javap : > no such file or directory > make[1]: *** [initial-image-jdk] Error 1 > make[1]: Leaving directory `/usr/local/google/home/martin/ws/build/jdk/make' > make: *** [jdk-build] Error 2 > This happens both building a complete OpenJDK forest and > when building the "jdk" repository. I will test the "complete OpenJDK forest" part. See below for the "when building the "jdk" repository" part: When you build only jdk the other pieces are assembled from the latest promoted JDK (or your ALT_BUILD_JDK_IMPORT_PATH). The new classes Jon added for 6708729/6439940 are not there yet, so they are not pulled over. The build fails later when trying to assemble tools.jar. This is an outcome of code and Makefile changes that span two repositories. Until b30 is promoted, or your ALT_BUILD_JDK_IMPORT_PATH is updated by some other means to a build that includes the 6708729/6439940 fixes, you _must_ do a control build of (at least) langtools plus jdk to get the new classes added. See email thread [1] from last month for a discussion of this. Your control build may include any or all of the rest (corba hotspot jaxp jaxws etc...) if you wish. > This is a very recently introduced failure (over the past week?). The changes went into jdk7/jdk7 (the master) when I pushed the jdk7/tl b30 changes on 25 June. > Fortunately, there is a workaround that's not too painful. > Simply create the two missing directories and restart the build. > Even javap works! I think if you check you will find that you got the 'old' javap from BOOTDIR (nothing wrong with that - it still works as ever) but the new classes added by 6708729/6439940 are not present. Tim [1] http://mail.openjdk.java.net/pipermail/build-dev/2008-June/001121.html From Tim.Bell at Sun.COM Wed Jul 2 18:33:15 2008 From: Tim.Bell at Sun.COM (Tim Bell) Date: Wed, 02 Jul 2008 18:33:15 -0700 Subject: OpenJDK 7 build failure in com/sun/tools In-Reply-To: <486C156E.8010506@sun.com> References: <1ccfd1c10807021609u7c6f5134qa4e93c3a1451bade@mail.gmail.com> <486C156E.8010506@sun.com> Message-ID: <486C2C5B.3040504@sun.com> I (Tim Bell) wrote: > I will test the "complete OpenJDK forest" part. See below for the "when > building the "jdk" repository" part: My complete OpenJDK forest build ran OK on solaris-i586. [... snip ...] > I think if you check you will find that you got the 'old' javap from > BOOTDIR (nothing wrong with that - it still works as ever) but the new I tell a lie here - that should be [ALT_]BUILD_JDK_IMPORT_PATH and not BOOTDIR > classes added by 6708729/6439940 are not present. Tim From martinrb at google.com Thu Jul 3 09:20:14 2008 From: martinrb at google.com (Martin Buchholz) Date: Thu, 3 Jul 2008 09:20:14 -0700 Subject: OpenJDK 7 build failure in com/sun/tools In-Reply-To: <486C2C5B.3040504@sun.com> References: <1ccfd1c10807021609u7c6f5134qa4e93c3a1451bade@mail.gmail.com> <486C156E.8010506@sun.com> <486C2C5B.3040504@sun.com> Message-ID: <1ccfd1c10807030920m70dbc9c3l74d2e2f9f17ca1b3@mail.gmail.com> On Wed, Jul 2, 2008 at 6:33 PM, Tim Bell wrote: > I (Tim Bell) wrote: > >> I will test the "complete OpenJDK forest" part. See below for the "when >> building the "jdk" repository" part: > > My complete OpenJDK forest build ran OK on solaris-i586. Thanks. I can reproduce this problem on my personal Ubuntu 7.10 machine with forest MASTER, linux-i586. updated as of yesterday. That would be the kind of build to try. > [... snip ...] > >> I think if you check you will find that you got the 'old' javap from >> BOOTDIR (nothing wrong with that - it still works as ever) but the new > > I tell a lie here - that should be [ALT_]BUILD_JDK_IMPORT_PATH and not > BOOTDIR Agreed. From martinrb at google.com Sun Jul 6 20:12:23 2008 From: martinrb at google.com (Martin Buchholz) Date: Sun, 6 Jul 2008 20:12:23 -0700 Subject: OpenJDK 7 build failure in com/sun/tools In-Reply-To: <1ccfd1c10807021609u7c6f5134qa4e93c3a1451bade@mail.gmail.com> References: <1ccfd1c10807021609u7c6f5134qa4e93c3a1451bade@mail.gmail.com> Message-ID: <1ccfd1c10807062012yac4d00r2d39cc3448e34132@mail.gmail.com> I don't know how, when or why, but I can no longer reproduce this problem in the latest OpenJDK. Probably a temporary glitch. Martin On Wed, Jul 2, 2008 at 4:09 PM, Martin Buchholz wrote: > While building images in a mercurial workspace updated as of today, I get > > /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/classfile > : no such file or directory > /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/javap : > no such file or directory > make[1]: *** [initial-image-jdk] Error 1 > make[1]: Leaving directory `/usr/local/google/home/martin/ws/build/jdk/make' > make: *** [jdk-build] Error 2 > From Jonathan.Gibbons at Sun.COM Mon Jul 7 04:40:24 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Mon, 07 Jul 2008 04:40:24 -0700 Subject: [NEW BUG] Running jtreg tests on NetBSD In-Reply-To: <1ccfd1c10806280117i4e4bab36h358963f98f7e39aa@mail.gmail.com> References: <4861A4BC.2090801@mcs.vuw.ac.nz> <1ccfd1c10806280117i4e4bab36h358963f98f7e39aa@mail.gmail.com> Message-ID: <487200A8.40403@sun.com> Alex, It is a long term goal to replace as many shell tests as possible in the langtools repository, typically with Java equivalents. For the short term, Martin's suggestion is a good one. I'd be happy to work with you on short or medium term changes if you want to help. -- Jon Martin Buchholz wrote: > Of course, the non-portable constructs in the shell scripts come from > a long term mindset of "if it's not solaris or linux, it must be windows." > > Better would be "if it's not windows, it must be unix" > > Very compactly (untested): > > case "`uname -s`" in > Windows* | CYGWIN*) NULL=NUL PS=";" FS="\\" ;; > *) NULL=/dev/null PS=":" FS="/" ;; > esac > > This would be a pervasive change. > > Martin > > > On Tue, Jun 24, 2008 at 6:51 PM, Alex Potanin > wrote: > >> Hello, >> >> I am working on the javac extension and I tried to run the javac tests in >> the OpenJDK's latest Mercurial repository. >> em daqsh w3.org >> I see that a few of them contain the following in the shell scripts: >> >> # set platform-dependent variables >> OS=`uname -s` >> case "$OS" in >> SunOS | Linux ) >> NULL=/dev/null >> PS=":" >> FS="/" >> ;; >> Windows* ) >> NULL=NUL >> PS=";" >> FS="\\" >> ;; >> * ) >> echo "Unrecognized system!" >> exit 1; >> ;; >> esac >> >> Since I use NetBSD, my 'uname -s' returns NetBSD. >> >> I had to add "| NetBSD" to the "SunOS | Linux" line to fix the test scripts >> so that they don't return "Unrecognized system!". >> >> Some of the affected scripts are: >> >> tools/javac/4846262/Test.sh >> tools/javac/6302184/T6302184.sh >> tools/javac/ClassPathTest/ClassPathTest.sh >> >> But there are others that I can find if required (I suspect grepping will do >> a good job). >> >> I was wondering if it can please be fixed to take NetBSD into account or >> whether there is a better way of fixing this? >> >> Thanks, >> Alex. >> >> From kelly.ohair at sun.com Mon Jul 7 09:13:22 2008 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Mon, 07 Jul 2008 16:13:22 +0000 Subject: hg: jdk7/build: 2 new changesets Message-ID: <20080707161322.A343A28B24@hg.openjdk.java.net> Changeset: cda4ce5a6494 Author: ohair Date: 2008-07-03 10:09 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/cda4ce5a6494 6563752: Build and test JDK7 with Sun Studio 12 Express compilers (prep makefiles) Summary: Changes to support building with SS12. Reviewed-by: tbell ! make/jprt.config Changeset: e42c6a1e1fb4 Author: ohair Date: 2008-07-07 09:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/e42c6a1e1fb4 Merge From kelly.ohair at sun.com Tue Jul 8 10:54:05 2008 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Tue, 08 Jul 2008 17:54:05 +0000 Subject: hg: jdk7/build/jdk: 6695765: Remove winver.exe completely from jdk sources Message-ID: <20080708175417.5711828C8E@hg.openjdk.java.net> Changeset: 80759df0d279 Author: ohair Date: 2008-07-08 09:27 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/80759df0d279 6695765: Remove winver.exe completely from jdk sources Summary: Binary file winver.exe is unnecessary and the repositories should not manage binary files. Reviewed-by: darcy ! make/common/shared/Platform.gmk ! make/common/shared/Sanity.gmk ! make/tools/Makefile - make/tools/winver/Makefile - make/tools/winver/bin/winver.exe - make/tools/winver/src/StdAfx.cpp - make/tools/winver/src/StdAfx.h - make/tools/winver/src/winver.cpp From xiomara.jayasena at sun.com Wed Jul 9 10:14:31 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 09 Jul 2008 17:14:31 +0000 Subject: hg: jdk7/build: 2 new changesets Message-ID: <20080709171431.A8A8428D2F@hg.openjdk.java.net> Changeset: 91b0b5f6f4a1 Author: xdono Date: 2008-07-03 11:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/91b0b5f6f4a1 Added tag jdk7-b30 for changeset 2dab2f712e18 ! .hgtags Changeset: 3300a35a0bd5 Author: xdono Date: 2008-07-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/3300a35a0bd5 Merge From xiomara.jayasena at sun.com Wed Jul 9 10:15:46 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 09 Jul 2008 17:15:46 +0000 Subject: hg: jdk7/build/corba: Added tag jdk7-b30 for changeset c0252adbb2ab Message-ID: <20080709171547.9563E28D34@hg.openjdk.java.net> Changeset: ef6af34d75a7 Author: xdono Date: 2008-07-03 11:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/ef6af34d75a7 Added tag jdk7-b30 for changeset c0252adbb2ab ! .hgtags From xiomara.jayasena at sun.com Wed Jul 9 10:19:05 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 09 Jul 2008 17:19:05 +0000 Subject: hg: jdk7/build/hotspot: Added tag jdk7-b30 for changeset d1605aabd0a1 Message-ID: <20080709171907.2B17928D39@hg.openjdk.java.net> Changeset: de141433919f Author: xdono Date: 2008-07-03 11:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/de141433919f Added tag jdk7-b30 for changeset d1605aabd0a1 ! .hgtags From xiomara.jayasena at sun.com Wed Jul 9 10:23:15 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 09 Jul 2008 17:23:15 +0000 Subject: hg: jdk7/build/jaxp: Added tag jdk7-b30 for changeset 2d94a238a164 Message-ID: <20080709172317.5F14F28D3E@hg.openjdk.java.net> Changeset: 255d64ee287e Author: xdono Date: 2008-07-03 11:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/255d64ee287e Added tag jdk7-b30 for changeset 2d94a238a164 ! .hgtags From xiomara.jayasena at sun.com Wed Jul 9 10:24:32 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 09 Jul 2008 17:24:32 +0000 Subject: hg: jdk7/build/jaxws: Added tag jdk7-b30 for changeset 7f2466f8cc70 Message-ID: <20080709172433.EDA9928D43@hg.openjdk.java.net> Changeset: f97862382536 Author: xdono Date: 2008-07-03 11:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/f97862382536 Added tag jdk7-b30 for changeset 7f2466f8cc70 ! .hgtags From xiomara.jayasena at sun.com Wed Jul 9 10:26:11 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 09 Jul 2008 17:26:11 +0000 Subject: hg: jdk7/build/jdk: 17 new changesets Message-ID: <20080709172932.0B73F28D49@hg.openjdk.java.net> Changeset: cf6acc673506 Author: xdono Date: 2008-07-03 11:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/cf6acc673506 Added tag jdk7-b30 for changeset b6d6877c1155 ! .hgtags Changeset: c78fb2e96d8c Author: sherman Date: 2008-06-25 08:27 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/c78fb2e96d8c 4752069: (cs spec) BOM should not be ignored in UTF-16 charsets Summary: API doc update regarding BOM hanlding in UTF-16 charsets Reviewed-by: alanb ! src/share/classes/java/nio/charset/Charset.java Changeset: b212b96b3919 Author: sherman Date: 2008-06-25 13:58 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b212b96b3919 6481955: Uncanonicalized absolute filepath with length 248-260 no longer works (win) Summary: Uncanonicalized absolute filepath with length 248-260 no longer works (win) Reviewed-by: alanb ! src/windows/native/java/io/io_util_md.c + test/java/io/File/MaxPath.java Changeset: 4edf07b01e29 Author: tbell Date: 2008-06-25 23:29 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/4edf07b01e29 Merge Changeset: 496cb56af58d Author: sherman Date: 2008-06-27 08:32 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/496cb56af58d 6645197: (so) Timed read with socket adaptor throws ClosedSelectorException if temporary selector GC'ed Summary: Temporary selector for timeout is not protected from possilbe GC when used first time Reviewed-by: alanb ! src/share/classes/sun/nio/ch/Util.java Changeset: d20c51803e8b Author: sherman Date: 2008-06-27 09:05 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/d20c51803e8b Merge Changeset: 267da79ad5d8 Author: sherman Date: 2008-06-27 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/267da79ad5d8 6541631: (fc) java/nio/channels/Filechannel/LongTransferTest.java should clean up after itself Summary: Should close the channel before delete the file Reviewed-by: alanb ! test/java/nio/channels/FileChannel/LongTransferTest.java Changeset: 2f21c9f8136a Author: mullan Date: 2008-06-17 10:34 -0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/2f21c9f8136a 6673277: Thread unsafe lazy initialization code in sun.security.provider.certpath.*Checker classes Summary: make supportedExts variable non-static Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/ConstraintsChecker.java ! src/share/classes/sun/security/provider/certpath/KeyChecker.java ! src/share/classes/sun/security/provider/certpath/PolicyChecker.java Changeset: bc5159dc2a81 Author: mullan Date: 2008-06-17 10:53 -0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/bc5159dc2a81 Merge Changeset: 4be8dfa19e27 Author: mullan Date: 2008-06-19 14:20 -0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/4be8dfa19e27 6714842: CertPathBuilder returns incorrect CertPath for BasicConstraints in builderParams Summary: Do not consider CA target certificates if selector.getBasicConstraints() == -2 Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java + test/java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java + test/java/security/cert/CertPathBuilder/targetConstraints/anchor.cer + test/java/security/cert/CertPathBuilder/targetConstraints/ca.cer + test/java/security/cert/CertPathBuilder/targetConstraints/ee.cer Changeset: 3a7345910333 Author: weijun Date: 2008-06-20 12:05 +0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/3a7345910333 6716534: Krb5LoginModule has not cleaned temp info between authentication attempts Reviewed-by: valeriep ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java Changeset: 9cf5011bfe38 Author: wetmore Date: 2008-06-26 00:26 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9cf5011bfe38 Merge Changeset: 47c4a285e238 Author: wetmore Date: 2008-06-29 00:25 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/47c4a285e238 Merge Changeset: bc9a0bba6e72 Author: sherman Date: 2008-06-30 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/bc9a0bba6e72 6675856: Open charset tests Summary: Moved non-confidiential test cased from closed repo to open repo Reviewed-by: martin + test/sun/nio/cs/BufferUnderflowEUCTWTest.java + test/sun/nio/cs/CheckCaseInsensitiveEncAliases.java + test/sun/nio/cs/CheckHistoricalNames.java + test/sun/nio/cs/ConvertSingle.java + test/sun/nio/cs/Decode.java + test/sun/nio/cs/DecoderOverflow.java + test/sun/nio/cs/EUCJPUnderflowDecodeTest.java + test/sun/nio/cs/EucJpLinux0212.java + test/sun/nio/cs/EucJpLinuxDecoderRecoveryTest.java + test/sun/nio/cs/EuroConverter.java + test/sun/nio/cs/FindASCIICodingBugs.java + test/sun/nio/cs/FindASCIIRangeCodingBugs.java + test/sun/nio/cs/FindCanEncodeBugs.java + test/sun/nio/cs/FindDecoderBugs.java + test/sun/nio/cs/FindEncoderBugs.java + test/sun/nio/cs/FindOneCharEncoderBugs.java + test/sun/nio/cs/HWKatakanaMS932EncodeTest.java + test/sun/nio/cs/ISCIITest.java + test/sun/nio/cs/ISO2022JP.trailEsc + test/sun/nio/cs/ISO8859x.java + test/sun/nio/cs/JISAutoDetectTest.java + test/sun/nio/cs/LatinCharReplacementTWTest.java + test/sun/nio/cs/LeftOverSurrogate.java + test/sun/nio/cs/MalformedSurrogates.java + test/sun/nio/cs/NIOJISAutoDetectTest.java + test/sun/nio/cs/ReadZero.java + test/sun/nio/cs/SJISCanEncode.java + test/sun/nio/cs/StreamEncoderClose.java + test/sun/nio/cs/SurrogateGB18030Test.java + test/sun/nio/cs/SurrogateTestEUCTW.java + test/sun/nio/cs/SurrogateTestEUCTW.plane15.surrogates + test/sun/nio/cs/SurrogateTestEUCTW.plane3.surrogates + test/sun/nio/cs/SurrogateTestEUCTW.plane4.surrogates + test/sun/nio/cs/SurrogateTestEUCTW.plane5.surrogates + test/sun/nio/cs/SurrogateTestEUCTW.plane6.surrogates + test/sun/nio/cs/SurrogateTestEUCTW.plane7.surrogates + test/sun/nio/cs/SurrogateTestHKSCS.java + test/sun/nio/cs/Test4200310.sh + test/sun/nio/cs/Test4206507.java + test/sun/nio/cs/Test6254467.java + test/sun/nio/cs/Test6275027.java + test/sun/nio/cs/Test6392804.java + test/sun/nio/cs/TestCompoundTest.java + test/sun/nio/cs/TestConverterDroppedCharacters.java + test/sun/nio/cs/TestCp834_SBCS.java + test/sun/nio/cs/TestCp93xSISO.java + test/sun/nio/cs/TestIBMBugs.java + test/sun/nio/cs/TestISCII91.java + test/sun/nio/cs/TestISO2022CNDecoder.java + test/sun/nio/cs/TestISO2022JP.java + test/sun/nio/cs/TestISO2022JPEncoder.java + test/sun/nio/cs/TestISO2022JPSubBytes.java + test/sun/nio/cs/TestIllegalISO2022Esc.java + test/sun/nio/cs/TestIllegalSJIS.java + test/sun/nio/cs/TestJIS0208Decoder.java + test/sun/nio/cs/TestJIS0212Decoder.java + test/sun/nio/cs/TestMS5022X.java + test/sun/nio/cs/TestMiscEUC_JP.java + test/sun/nio/cs/TestSJIS0213.java + test/sun/nio/cs/TestTrailingEscapesISO2022JP.java + test/sun/nio/cs/TestUTF8BOM.java + test/sun/nio/cs/TestUTF_16.java + test/sun/nio/cs/TestUTF_32.java + test/sun/nio/cs/TestUni2HKSCS.java + test/sun/nio/cs/TestX11JIS0201.java + test/sun/nio/cs/UkrainianIsNotRussian.java + test/sun/nio/cs/ZeroedByteArrayEUCTWTest.java Changeset: 92b0c40af537 Author: sherman Date: 2008-06-30 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/92b0c40af537 Merge Changeset: 08f77c507252 Author: tbell Date: 2008-07-04 14:41 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/08f77c507252 Merge ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/ch/Util.java ! src/windows/native/java/io/io_util_md.c Changeset: b7474b739d13 Author: xdono Date: 2008-07-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b7474b739d13 Merge From xiomara.jayasena at sun.com Wed Jul 9 10:33:40 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 09 Jul 2008 17:33:40 +0000 Subject: hg: jdk7/build/langtools: 8 new changesets Message-ID: <20080709173353.9A93828D4E@hg.openjdk.java.net> Changeset: 1ffdb836f632 Author: xdono Date: 2008-07-03 11:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/1ffdb836f632 Added tag jdk7-b30 for changeset eaf608c64fec ! .hgtags Changeset: f9a4b9e1a521 Author: jjg Date: 2008-06-17 10:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/f9a4b9e1a521 6625520: javac handles missing entries on classpath badly Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javap/JavapFileManager.java + test/tools/javac/T6625520.java Changeset: aa67a5da66e3 Author: jjg Date: 2008-06-18 07:23 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/aa67a5da66e3 6714365: refactor JavacFileManager to move nested classes to top level Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java + src/share/classes/com/sun/tools/javac/file/RegularFileObject.java + src/share/classes/com/sun/tools/javac/file/SymbolArchive.java + src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java + src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java - src/share/classes/com/sun/tools/javac/file/ZipFileIndexEntry.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java Changeset: 8bc2ca2a3b0a Author: jjg Date: 2008-06-19 15:52 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/8bc2ca2a3b0a 6716866: some javac regression tests fail to compile with re-orged file manager Reviewed-by: darcy ! test/tools/javac/T6358024.java ! test/tools/javac/T6358166.java ! test/tools/javac/T6358168.java ! test/tools/javac/T6625520.java Changeset: 4a3b9801f7a0 Author: mcimadamore Date: 2008-06-20 11:25 +0100 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/4a3b9801f7a0 6294779: Problem with interface inheritance and covariant return types Summary: Problematic overriding check when two methods defined in two distinct superinterfaces are overriden by an interface Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/6294779/T6294779a.java + test/tools/javac/generics/6294779/T6294779b.java + test/tools/javac/generics/6294779/T6294779c.java Changeset: 29d2485c1085 Author: jjg Date: 2008-06-25 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/29d2485c1085 6507179: javadoc -source 1.3 does not work with jdk6 Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java + test/tools/javadoc/sourceOption/SourceOption.java + test/tools/javadoc/sourceOption/p/A.java Changeset: a0de486e86a1 Author: tbell Date: 2008-06-25 23:30 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/a0de486e86a1 Merge - src/share/classes/com/sun/tools/javac/file/ZipFileIndexEntry.java Changeset: 07c916ecfc71 Author: tbell Date: 2008-07-04 15:06 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/07c916ecfc71 Merge ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javap/JavapFileManager.java ! test/tools/javac/T6358024.java ! test/tools/javac/T6358166.java ! test/tools/javac/T6358168.java From Kelly.Ohair at Sun.COM Wed Jul 9 15:23:48 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Wed, 09 Jul 2008 15:23:48 -0700 Subject: Need Reviewers - OpenJDK README-builds.html Message-ID: <48753A74.3030108@sun.com> Attached is a diff and an updated OpenJDK README-builds.html file. If anyone has the time to review the changes I would appreciate it. The bugs fixed are: 6704966: OpenJDK README needs additional info on how to build freetype 6704968: OpenJDK Build README is missing ant requirement 6704973: OpenJDK Build readme needs cygwin package list improvements 6462815: cygwin's gnumake 3.81-1 does not support MS-DOS path names And the environment variable list is sorted. -kto -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20080709/bb0b4031/attachment.html -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20080709/bb0b4031/attachment-0001.html From kelly.ohair at sun.com Wed Jul 9 15:43:36 2008 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Wed, 09 Jul 2008 22:43:36 +0000 Subject: hg: jdk7/build: 6704966: OpenJDK README needs additional info on how to build freetype; ... Message-ID: <20080709224336.ED8D928DB2@hg.openjdk.java.net> Changeset: 8a275f439862 Author: ohair Date: 2008-07-09 15:42 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/8a275f439862 6704966: OpenJDK README needs additional info on how to build freetype 6704968: OpenJDK Build README is missing ant requirement 6704973: OpenJDK Build readme needs cygwin package list improvements 6590549: Cygwin build of OpenJDK has problems and not very well documented 6462815: cygwin's gnumake 3.81-1 does not support MS-DOS path names 6597857: JDK build instructions need to be updated (BUILD_JDK_IMPORT_PATH, BUILD_BINARY_PLUGS_PATH) Reviewed-by: jjg, igor ! README-builds.html From dan at fabulich.com Wed Jul 9 23:11:28 2008 From: dan at fabulich.com (Dan Fabulich) Date: Wed, 9 Jul 2008 23:11:28 -0700 (Pacific Daylight Time) Subject: Need Reviewers - OpenJDK README-builds.html In-Reply-To: <48753A74.3030108@sun.com> References: <48753A74.3030108@sun.com> Message-ID: IMO, this document should not make any predictions about make 3.82, which is not yet released. Last time I researched the "C:/" problem, the developers had said that "C:/" paths were defective and that they deliberately pulled support for them because they were too much hassle to support in cygwin. They recommended using MSYS make instead. Here's where they explain their position: http://cygwin.com/ml/cygwin/2006-07/msg00671.html > > Was this a deliberate break with backwards compatibility? > Yes. See . > If you are using a POSIX-like "OS" (i.e. Cygwin), you should be using > POSIX paths. That's not an inconvenience, that's called writing a bad > makefile. If you aren't using Cygwin for the POSIX environment, you > should be using MinGW. [aka MSYS make] Kelly O'Hair wrote: > > Attached is a diff and an updated OpenJDK README-builds.html file. > > If anyone has the time to review the changes I would appreciate it. > > The bugs fixed are: > > 6704966: OpenJDK README needs additional info on how to build freetype > 6704968: OpenJDK Build README is missing ant requirement > 6704973: OpenJDK Build readme needs cygwin package list improvements > 6462815: cygwin's gnumake 3.81-1 does not support MS-DOS path names > > And the environment variable list is sorted. > > -kto > From Jonathan.Gibbons at Sun.COM Thu Jul 10 09:14:44 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Thu, 10 Jul 2008 09:14:44 -0700 Subject: getting a handle on build warnings Message-ID: <48763574.3060404@sun.com> The JDK build generates a whole lot of warnings along the way. This is bad because these warnings can sometimes mask real errors. For a variety of reasons, it appears to be hard to try and get rid of all the warnings, so this message is about a set of possible ideas to try and get some control over the problem, by providing a relatively general framework to use within the build, to minimize the introduction of new warnings, and by providing a reporting framework for those developers that *are* interested in reducing the warnings in their code. 1. Collecting warnings. The simplest, easiest way to collect the warnings is to save the output from a build, for subsequent processing by any new tools we provide. David Herron has also suggested we could prefix the build macros for selected commands like cc, javac, javadoc etc such that the output from each invocation of the command is appended to a log, perhaps a directory specific log. For example, the macro to invoke javac could instead invoke savelog -a $(pwd)/javac.log javac ... where savelog is a new command to run a subcommand and save its output. Whichever way we go, the first step in getting a handle on warnings would be to save the output from the commands generating the warnings. 2. Analyzing and normalizing warnings. Warnings can be divided into two groups: - those we know how to and want to deal with, and - those we don't. Ignore the latter group for now. Perhaps in time we'll figure out how to deal with them and become interested in dealing with them. We can select the warnings in the first group with grep or regular expressions. Then we want to normalize the warnings. Normalizing a warning consists of a number of steps: - remove any information specific to that instance of the build. Typically, this will mean the head of any user-specific paths, such as absolute paths on the build machine. - remove any information that may not be inherent to the warning Typically, this will mean line numbers in the build. Someone could edit the text in the source file ahead of the warning, and change the line number used in the warning. This should not change the normalized form of the warning - adjust the location of the warning to be relative to one of the standard "subroots" within the tree, such as "src/share/classes", "src/PLATFORM/classes", etc. In addition, standardize file separators in the location of the warning. At the end of the normalization, warnings should all begin with a location, such as the following made up examples, java/lang/String.java: warning: unchecked type com/sun/tools/javac/Main.java: warning: using deprecated method Sorting the overall set of warnings would be good too. 3. Reporting and further analysis If Release Engineering could produce a normalized list of warnings for each promoted build, it would be possible for a developer to compare the results of any new build against the "official" set of currently known warnings, to see if any new warnings have been introduced. PIT testing could verify that no new warnings have been introduced, and possibly give waivers for any justifiable new warnings. The "official" set of currently known warnings could be posted on OpenJDK, so that OpenJDK developers outside of Sun could compare their results to the published results. Developers could put "assertions" into the build to assert that portions of the code are warning-free. -Werror achieves that to a limited extent but doesn't work on tools like javadoc, which processes large amounts of code which may not all be warning-free. From the normalized list of warnings, it would be possible a summary table, grouped by package, and sorted either alphabetically or by quantity. This way, we could see where are the worst offending source files, and perhaps use that as motivation for fixing warnings. Summary Dealing with warnings has proven almost impossibly difficult over the years. The ideas presented here make it simpler to deal with the problems by identifying warnings that we know how to fix, in areas where we are interested in fixing them. In addition, it provides a way we can ensure that the situation doesn't get any worse, going forward. -- Jon From martinrb at google.com Thu Jul 10 09:33:26 2008 From: martinrb at google.com (Martin Buchholz) Date: Thu, 10 Jul 2008 09:33:26 -0700 Subject: Need Reviewers - OpenJDK README-builds.html In-Reply-To: References: <48753A74.3030108@sun.com> Message-ID: <1ccfd1c10807100933h41e39bc7u651db5b6a5017f4d@mail.gmail.com> The maintainer of GNU make makes a commitment here: http://article.gmane.org/gmane.comp.gnu.make.windows/2937 to fix the problem in 3.82 ---- On Mon, 2008-06-30 at 18:08 -0700, Kelly O'Hair wrote: > I assume cygwin will not be fixing this, in 3.82 or ever, is that > the conclusion I am seeing? No; I'm pretty sure it's already been fixed in CVS actually. I just think that, in general, it's not guaranteed by make (or any other cygwin tool) that you'll be able to use full DOS-style pathnames. However, at least for make, unless there's some serious incompatibility that makes it very difficult (or unless whomever maintains the Cygwin port declines to make the change, which is not the case here) we'll make an effort to be compatible. ---- Martin On Wed, Jul 9, 2008 at 11:11 PM, Dan Fabulich wrote: > IMO, this document should not make any predictions about make 3.82, which is > not yet released. > > Last time I researched the "C:/" problem, the developers had said that "C:/" > paths were defective and that they deliberately pulled support for them > because they were too much hassle to support in cygwin. They recommended > using MSYS make instead. > > Here's where they explain their position: > http://cygwin.com/ml/cygwin/2006-07/msg00671.html >> >> > Was this a deliberate break with backwards compatibility? >> Yes. See . If >> you are using a POSIX-like "OS" (i.e. Cygwin), you should be using POSIX >> paths. That's not an inconvenience, that's called writing a bad makefile. If >> you aren't using Cygwin for the POSIX environment, you should be using >> MinGW. > > [aka MSYS make] > > Kelly O'Hair wrote: > >> >> Attached is a diff and an updated OpenJDK README-builds.html file. >> >> If anyone has the time to review the changes I would appreciate it. >> >> The bugs fixed are: >> >> 6704966: OpenJDK README needs additional info on how to build freetype >> 6704968: OpenJDK Build README is missing ant requirement >> 6704973: OpenJDK Build readme needs cygwin package list improvements >> 6462815: cygwin's gnumake 3.81-1 does not support MS-DOS path names >> >> And the environment variable list is sorted. >> >> -kto >> > > From martinrb at google.com Thu Jul 10 09:56:56 2008 From: martinrb at google.com (Martin Buchholz) Date: Thu, 10 Jul 2008 09:56:56 -0700 Subject: getting a handle on build warnings In-Reply-To: <48763574.3060404@sun.com> References: <48763574.3060404@sun.com> Message-ID: <1ccfd1c10807100956r6cebbf9ej444a891e27a493f2@mail.gmail.com> One significant simple annoyance is that compile errors are hard to find amongst the mass of warnings, because errors are not identified as such. It would be very nice if errors were prefixed by "error:" the same way that warnings are prefixed by "warning:", making them easy to search for. Martin From Jonathan.Gibbons at Sun.COM Thu Jul 10 10:20:51 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Thu, 10 Jul 2008 10:20:51 -0700 Subject: getting a handle on build warnings In-Reply-To: <1ccfd1c10807100956r6cebbf9ej444a891e27a493f2@mail.gmail.com> References: <48763574.3060404@sun.com> <1ccfd1c10807100956r6cebbf9ej444a891e27a493f2@mail.gmail.com> Message-ID: <487644F3.6020405@sun.com> The point is noted, but it seems to me that it would be better to work on removing warnings rather than making it even easier to continue ignoring them :-) With the possible exception of the obnoxious proprietary API warnings from javac (which typically do not occur in the build anyway), all warnings from javac can be eliminated one way or another, and we should be doing all we can to have developers eliminate the warnings in the code for which they are responsible. Even if we can't clean all the warnings from all the files, I think it is reasonable to remove all the warnings from any file a developer edits. -- Jon Martin Buchholz wrote: > One significant simple annoyance is that compile errors are hard to find > amongst the mass of warnings, because errors are not identified as such. > It would be very nice if errors were prefixed by "error:" the same > way that warnings are prefixed by "warning:", > making them easy to search for. > > Martin > From Kelly.Ohair at Sun.COM Thu Jul 10 10:45:31 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 10 Jul 2008 10:45:31 -0700 Subject: getting a handle on build warnings In-Reply-To: <487644F3.6020405@sun.com> References: <48763574.3060404@sun.com> <1ccfd1c10807100956r6cebbf9ej444a891e27a493f2@mail.gmail.com> <487644F3.6020405@sun.com> Message-ID: <48764ABB.4050609@sun.com> +1 from me. --- It might help that when people do remove some of the more tricky warnings, that they send a short email on how they did it. I remember having to walk down the hall to see Peter Ahe a few times when I was trying to get rid of some of the trickier warnings in some of my java code. Using the annotation to suppress the warning should be a last resort. -kto Jonathan Gibbons wrote: > The point is noted, but it seems to me that it would be better to > work on removing warnings rather than making it even easier > to continue ignoring them :-) > > With the possible exception of the obnoxious proprietary API > warnings from javac (which typically do not occur in the build > anyway), all warnings from javac can be eliminated one way or > another, and we should be doing all we can to have developers > eliminate the warnings in the code for which they are responsible. > Even if we can't clean all the warnings from all the files, I think > it is reasonable to remove all the warnings from any file a > developer edits. > > -- Jon > > Martin Buchholz wrote: >> One significant simple annoyance is that compile errors are hard to find >> amongst the mass of warnings, because errors are not identified as such. >> It would be very nice if errors were prefixed by "error:" the same >> way that warnings are prefixed by "warning:", >> making them easy to search for. >> >> Martin >> > From Kelly.Ohair at Sun.COM Thu Jul 10 11:10:46 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 10 Jul 2008 11:10:46 -0700 Subject: Need Reviewers - OpenJDK README-builds.html In-Reply-To: <1ccfd1c10807100933h41e39bc7u651db5b6a5017f4d@mail.gmail.com> References: <48753A74.3030108@sun.com> <1ccfd1c10807100933h41e39bc7u651db5b6a5017f4d@mail.gmail.com> Message-ID: <487650A6.8020507@sun.com> Thanks Martin. The GNU Make people claim it's fixed, but CYGWIN in general will probably continue to have issues with MS-DOS style paths. The basic OpenJDK Makefile rules I'm trying to follow will be: * Avoid full paths if at all possible, use relative paths or limit the commands/utilities that get full paths. * Where full paths are needed, be explicit in the comments or otherwise as to what kind of full path is needed and why. Converting to the MSYS make is a possibility. On Windows, it's not just the drive letter paths, but the backslashes and spaces, and the bizarre shortpath rules. All things that Unix like shells and utilities will have problems with. :^( -kto Martin Buchholz wrote: > The maintainer of GNU make makes a commitment here: > > http://article.gmane.org/gmane.comp.gnu.make.windows/2937 > > to fix the problem in 3.82 > > ---- > On Mon, 2008-06-30 at 18:08 -0700, Kelly O'Hair wrote: >> I assume cygwin will not be fixing this, in 3.82 or ever, is that >> the conclusion I am seeing? > > No; I'm pretty sure it's already been fixed in CVS actually. > > I just think that, in general, it's not guaranteed by make (or any other > cygwin tool) that you'll be able to use full DOS-style pathnames. > However, at least for make, unless there's some serious incompatibility > that makes it very difficult (or unless whomever maintains the Cygwin > port declines to make the change, which is not the case here) we'll make > an effort to be compatible. > ---- > > Martin > > On Wed, Jul 9, 2008 at 11:11 PM, Dan Fabulich wrote: >> IMO, this document should not make any predictions about make 3.82, which is >> not yet released. >> >> Last time I researched the "C:/" problem, the developers had said that "C:/" >> paths were defective and that they deliberately pulled support for them >> because they were too much hassle to support in cygwin. They recommended >> using MSYS make instead. >> >> Here's where they explain their position: >> http://cygwin.com/ml/cygwin/2006-07/msg00671.html >>>> Was this a deliberate break with backwards compatibility? >>> Yes. See . If >>> you are using a POSIX-like "OS" (i.e. Cygwin), you should be using POSIX >>> paths. That's not an inconvenience, that's called writing a bad makefile. If >>> you aren't using Cygwin for the POSIX environment, you should be using >>> MinGW. >> [aka MSYS make] >> >> Kelly O'Hair wrote: >> >>> Attached is a diff and an updated OpenJDK README-builds.html file. >>> >>> If anyone has the time to review the changes I would appreciate it. >>> >>> The bugs fixed are: >>> >>> 6704966: OpenJDK README needs additional info on how to build freetype >>> 6704968: OpenJDK Build README is missing ant requirement >>> 6704973: OpenJDK Build readme needs cygwin package list improvements >>> 6462815: cygwin's gnumake 3.81-1 does not support MS-DOS path names >>> >>> And the environment variable list is sorted. >>> >>> -kto >>> >> From regina.anger at hotmail.com Thu Jul 10 15:17:28 2008 From: regina.anger at hotmail.com (Regina Anger) Date: Fri, 11 Jul 2008 00:17:28 +0200 Subject: Howto build with debugging symbols? Message-ID: I am hacking inside the JRE native libraries just for fun, having troubles to track a crash down. Is it possible to build OpenJDK with debugging symbols included in external native libraries like libzip.so, and if it is how can I enable it? Mfg regina _________________________________________________________________ Explore the seven wonders of the world http://search.msn.com/results.aspx?q=7+wonders+world&mkt=en-US&form=QBRE -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20080711/16da53da/attachment.html From Dmitri.Trembovetski at Sun.COM Thu Jul 10 16:23:51 2008 From: Dmitri.Trembovetski at Sun.COM (Dmitri Trembovetski) Date: Thu, 10 Jul 2008 16:23:51 -0700 Subject: Howto build with debugging symbols? In-Reply-To: References: Message-ID: <48769A07.4070406@Sun.COM> Hi Regina, set FASTDEBUG=true to enable debug symbols (with compiler optimizations enabled), or DEBUG=true to get a build with compiler opt. disabled (and I believe a debug runtime will be used on windows in this case as well). I recommend using FASTDEBUG=true - the resulting binaries are much faster than DEBUG and are useful for most debugging applications. You can also mix and match optimized and fastdebug binaries. Suppose you have an optimized build - you can then rebuild part of the workspace with FASTDEBUG so that only some libs will be recompiled with debug symbols (there are some exceptions to this, but mostly it should work). For example, #> cd jdk/make/sun/awt #> gnumake FASTDEBUG=true will build awt libraries with debug symbols, while the rest of the binaries will be optimized. Thanks, Dmitri Regina Anger wrote: > I am hacking inside the JRE native libraries just for fun, having > troubles to track a crash down. > Is it possible to build OpenJDK with debugging symbols included in > external native libraries like libzip.so, and if it is how can I enable it? > > Mfg regina > > ------------------------------------------------------------------------ > Explore the seven wonders of the world Learn more! > From Kelly.Ohair at Sun.COM Thu Jul 10 16:54:00 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 10 Jul 2008 16:54:00 -0700 Subject: Howto build with debugging symbols? In-Reply-To: References: Message-ID: <4876A118.5060603@sun.com> With a separate cloned jdk repository, try running 'cd make && gmake debug' It should compile everything with -g. Then copy the libzip.so into the JDK you are playing with, that way just the debug version of libzip.so is used instead of the entire debug jdk. That's assuming you have isolated the problem to libzip.so. -kto Regina Anger wrote: > I am hacking inside the JRE native libraries just for fun, having > troubles to track a crash down. > Is it possible to build OpenJDK with debugging symbols included in > external native libraries like libzip.so, and if it is how can I enable it? > > Mfg regina > > ------------------------------------------------------------------------ > Explore the seven wonders of the world Learn more! > From volker.simonis at gmail.com Fri Jul 11 02:29:03 2008 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 11 Jul 2008 11:29:03 +0200 Subject: getting a handle on build warnings In-Reply-To: <48763574.3060404@sun.com> References: <48763574.3060404@sun.com> Message-ID: On 7/10/08, Jonathan Gibbons wrote: > The JDK build generates a whole lot of warnings along the way. This is > bad because these warnings can sometimes mask real errors. For a > variety of reasons, it appears to be hard to try and get rid of all the > warnings, so this message is about a set of possible ideas to try and > get some control over the problem, by providing a relatively general > framework to use within the build, to minimize the introduction of new > warnings, and by providing a reporting framework for those developers > that *are* interested in reducing the warnings in their code. > This would be nice! > 1. Collecting warnings. > > The simplest, easiest way to collect the warnings is to save the output > from > a build, for subsequent processing by any new tools we provide. > > David Herron has also suggested we could prefix the build macros for > selected commands like cc, javac, javadoc etc such that the output from > each invocation of the command is appended to a log, perhaps a directory > specific log. For example, the macro to invoke javac could instead invoke > savelog -a $(pwd)/javac.log javac ... > where savelog is a new command to run a subcommand and save its output. > > Whichever way we go, the first step in getting a handle on warnings would > be to save the output from the commands generating the warnings. I always build with "make jvmg 2>&1 | tee ../../hotspot_c2_debug.log". This way I get the whole output produced by the build in the terminal window as well as in a log-file. Perhaps the easiest thing would be to add this feature to a top-level Makefile such that it always calls subsequent Makefiles in a way that redirects their output to a file (e.g. .log). From Jonathan.Gibbons at Sun.COM Fri Jul 11 04:52:34 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Fri, 11 Jul 2008 04:52:34 -0700 Subject: getting a handle on build warnings In-Reply-To: References: <48763574.3060404@sun.com> Message-ID: <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> On Jul 11, 2008, at 2:29 AM, Volker Simonis wrote: > On 7/10/08, Jonathan Gibbons wrote: >> The JDK build generates a whole lot of warnings along the way. This >> is >> bad because these warnings can sometimes mask real errors. For a >> variety of reasons, it appears to be hard to try and get rid of all >> the >> warnings, so this message is about a set of possible ideas to try and >> get some control over the problem, by providing a relatively general >> framework to use within the build, to minimize the introduction of >> new >> warnings, and by providing a reporting framework for those developers >> that *are* interested in reducing the warnings in their code. >> > > This would be nice! > >> 1. Collecting warnings. >> >> The simplest, easiest way to collect the warnings is to save the >> output >> from >> a build, for subsequent processing by any new tools we provide. >> >> David Herron has also suggested we could prefix the build macros for >> selected commands like cc, javac, javadoc etc such that the output >> from >> each invocation of the command is appended to a log, perhaps a >> directory >> specific log. For example, the macro to invoke javac could instead >> invoke >> savelog -a $(pwd)/javac.log javac ... >> where savelog is a new command to run a subcommand and save its >> output. >> >> Whichever way we go, the first step in getting a handle on warnings >> would >> be to save the output from the commands generating the warnings. > > I always build with "make jvmg 2>&1 | tee ../../hotspot_c2_debug.log". > This way I get the whole output produced by the build in the terminal > window as well as in a log-file. > > Perhaps the easiest thing would be to add this feature to a top-level > Makefile such that it always calls subsequent Makefiles in a way that > redirects their output to a file (e.g. .log). Yes, that technique can work well. But either way, the next step is to try writing the code to analyze the build log, to see how far the general idea can be taken, and how much interest there is to track/fix warnings. -- Jon From thunderaxiom at gmail.com Fri Jul 11 10:00:46 2008 From: thunderaxiom at gmail.com (=?ISO-8859-1?Q?Thorbj=F8rn_Ravn_Andersen?=) Date: Fri, 11 Jul 2008 19:00:46 +0200 Subject: getting a handle on build warnings In-Reply-To: <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> Message-ID: <487791BE.9000202@gmail.com> Jonathan Gibbons skrev den 11-07-2008 13:52: > > Yes, that technique can work well. But either way, the next step is > to try writing the code to analyze the build log, to see how far the > general > idea can be taken, and how much interest there is to track/fix warnings. > Personally I'd like there to be no warnings at all, and would like to contribute work to get there From Jonathan.Gibbons at Sun.COM Fri Jul 11 10:43:32 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Fri, 11 Jul 2008 10:43:32 -0700 Subject: getting a handle on build warnings In-Reply-To: <487791BE.9000202@gmail.com> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> Message-ID: On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: > Jonathan Gibbons skrev den 11-07-2008 13:52: >> >> Yes, that technique can work well. But either way, the next step is >> to try writing the code to analyze the build log, to see how far >> the general >> idea can be taken, and how much interest there is to track/fix >> warnings. >> > Personally I'd like there to be no warnings at all, and would like > to contribute work to get there > Thank you. Getting rid of the actual warnings will require cooperation from the teams who are responsible for the various parts of the code. In some cases, there may be resistance, since stability is sometimes preferred over "no warnings". That being said, what I'm hoping to achieve with this discussion and any related effort is a non- intrusive way of gathering information about warnings, so that we have a better understanding of where the warnings are, in what areas of the code and in which source files. That way, we can work with the teams involved to see if there is interest in reducing their warning count in as safe a way as possible. Any assistance in getting to that point would be welcome. (Note that anyone contributing to OpenJDK must first sign the Sun Contributor Agreement; you can find details at http://sca.dev.java.net.) -- Jon From rob.ross at gmail.com Fri Jul 11 10:52:39 2008 From: rob.ross at gmail.com (Rob Ross) Date: Fri, 11 Jul 2008 10:52:39 -0700 Subject: getting a handle on build warnings In-Reply-To: References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> Message-ID: Just curious, would part of this revision process entail removing calls to deprecated methods and replacing them with their documented replacement methods? There are many warnings about calls to deprecated methods in the OpenJDK code. Rob Ross, Lead Software Engineer E! Networks --------------------------------------------------- "Beware of he who would deny you access to information, for in his heart he dreams himself your master." -- Commissioner Pravin Lal On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: > > On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: > >> Jonathan Gibbons skrev den 11-07-2008 13:52: >>> >>> Yes, that technique can work well. But either way, the next step is >>> to try writing the code to analyze the build log, to see how far >>> the general >>> idea can be taken, and how much interest there is to track/fix >>> warnings. >>> >> Personally I'd like there to be no warnings at all, and would like >> to contribute work to get there >> > > Thank you. > > Getting rid of the actual warnings will require cooperation from > the teams who are > responsible for the various parts of the code. In some cases, there > may be resistance, > since stability is sometimes preferred over "no warnings". That > being said, what I'm > hoping to achieve with this discussion and any related effort is a > non-intrusive way > of gathering information about warnings, so that we have a better > understanding of > where the warnings are, in what areas of the code and in which > source files. That way, > we can work with the teams involved to see if there is interest in > reducing their > warning count in as safe a way as possible. Any assistance in > getting to that point > would be welcome. > > (Note that anyone contributing to OpenJDK must first sign the Sun > Contributor Agreement; > you can find details at http://sca.dev.java.net.) > > -- Jon > > From Jonathan.Gibbons at Sun.COM Fri Jul 11 11:02:51 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Fri, 11 Jul 2008 11:02:51 -0700 Subject: getting a handle on build warnings In-Reply-To: References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> Message-ID: Depending on what lint options you use, deprecation warnings are typically reported as a single "Note:" at the end of the compilation, rather than as individual warning messages. Ideally, they should go too, but for now, I'd settle for removing messages that show up as diagnostics in IDEs, emacs, etc. For my part, I work mostly in the langtools area, and we are having a general background effort to clean up the code there. The goal is to clean the code and then use -Werror to treat any reappearance of warnings as errors. -- Jon On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: > Just curious, would part of this revision process entail removing > calls to deprecated methods and replacing them with their documented > replacement methods? > > There are many warnings about calls to deprecated methods in the > OpenJDK code. > > > Rob Ross, Lead Software Engineer > E! Networks > > --------------------------------------------------- > "Beware of he who would deny you access to information, for in his > heart he dreams himself your master." -- Commissioner Pravin Lal > > > > On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: > >> >> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >> >>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>> >>>> Yes, that technique can work well. But either way, the next step is >>>> to try writing the code to analyze the build log, to see how far >>>> the general >>>> idea can be taken, and how much interest there is to track/fix >>>> warnings. >>>> >>> Personally I'd like there to be no warnings at all, and would like >>> to contribute work to get there >>> >> >> Thank you. >> >> Getting rid of the actual warnings will require cooperation from >> the teams who are >> responsible for the various parts of the code. In some cases, there >> may be resistance, >> since stability is sometimes preferred over "no warnings". That >> being said, what I'm >> hoping to achieve with this discussion and any related effort is a >> non-intrusive way >> of gathering information about warnings, so that we have a better >> understanding of >> where the warnings are, in what areas of the code and in which >> source files. That way, >> we can work with the teams involved to see if there is interest in >> reducing their >> warning count in as safe a way as possible. Any assistance in >> getting to that point >> would be welcome. >> >> (Note that anyone contributing to OpenJDK must first sign the Sun >> Contributor Agreement; >> you can find details at http://sca.dev.java.net.) >> >> -- Jon >> >> > From Jonathan.Gibbons at Sun.COM Fri Jul 11 15:20:24 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Fri, 11 Jul 2008 15:20:24 -0700 Subject: getting a handle on build warnings In-Reply-To: References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> Message-ID: <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> Well, here's an unexpected initial result. I just ran a build of langtools+jdk on my ubuntu laptop. I got a whopping 2658 warnings!! [Those who volunteered to help get rid of all the warnings, don't all step back at once!] But surprisingly, after a quick "sort -u", only 625 of them are unique. So that means we get on average a 4x bang for the buck for each warning we fix :-) -- Jon On Jul 11, 2008, at 11:02 AM, Jonathan Gibbons wrote: > Depending on what lint options you use, deprecation warnings are > typically reported as a single "Note:" at the end of the > compilation, rather than as individual warning messages. Ideally, > they should go too, but for now, I'd settle for removing messages > that show up as diagnostics in IDEs, emacs, etc. > > For my part, I work mostly in the langtools area, and we are having > a general background effort to clean up the code there. The goal is > to clean the code and then use -Werror to treat any reappearance of > warnings as errors. > > -- Jon > > > On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: > >> Just curious, would part of this revision process entail removing >> calls to deprecated methods and replacing them with their >> documented replacement methods? >> >> There are many warnings about calls to deprecated methods in the >> OpenJDK code. >> >> >> Rob Ross, Lead Software Engineer >> E! Networks >> >> --------------------------------------------------- >> "Beware of he who would deny you access to information, for in his >> heart he dreams himself your master." -- Commissioner Pravin Lal >> >> >> >> On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: >> >>> >>> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >>> >>>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>>> >>>>> Yes, that technique can work well. But either way, the next step >>>>> is >>>>> to try writing the code to analyze the build log, to see how far >>>>> the general >>>>> idea can be taken, and how much interest there is to track/fix >>>>> warnings. >>>>> >>>> Personally I'd like there to be no warnings at all, and would >>>> like to contribute work to get there >>>> >>> >>> Thank you. >>> >>> Getting rid of the actual warnings will require cooperation from >>> the teams who are >>> responsible for the various parts of the code. In some cases, >>> there may be resistance, >>> since stability is sometimes preferred over "no warnings". That >>> being said, what I'm >>> hoping to achieve with this discussion and any related effort is a >>> non-intrusive way >>> of gathering information about warnings, so that we have a better >>> understanding of >>> where the warnings are, in what areas of the code and in which >>> source files. That way, >>> we can work with the teams involved to see if there is interest in >>> reducing their >>> warning count in as safe a way as possible. Any assistance in >>> getting to that point >>> would be welcome. >>> >>> (Note that anyone contributing to OpenJDK must first sign the Sun >>> Contributor Agreement; >>> you can find details at http://sca.dev.java.net.) >>> >>> -- Jon >>> >>> >> > From Jonathan.Gibbons at Sun.COM Sun Jul 13 17:42:22 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Sun, 13 Jul 2008 17:42:22 -0700 Subject: getting a handle on build warnings In-Reply-To: <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> Message-ID: <487AA0EE.8070009@sun.com> I've written a program to analyze the warnings in a build log, containing most of the ideas I outlined earlier, and more. Right now, a "warning" is defined as a line containing the string "warning" with false positives filtered out (e.g. a reference to a file called warning.png) It can generate a report in plain text or html, containing any/all of the following: - comparison against a reference log, such as the log for an earlier promoted build - a summary of the warnings, grouped by the location contained in the warning - a summary of the warnings, grouped by the type of the warning The summaries are given sorted both alphabetically and by frequency. I've attached a sample of the output. The input was the log for a build on my laptop. For the purposes of testing, the "reference" was the same log truncated to 25000 lines. The big surprise: One file is responsible for nearly 72% of all the warnings in this build: 1928 warnings out of a total of 2684! The file in question is com/sun/java/util/jar/pack/coding.cpp The corollary is good news for everyone else; there are fewer warnings through the rest of the build than I expected, with only 14 files having 10 or more warnings. But, there are still over 150 files containing warnings :-( -- Jon Jonathan Gibbons wrote: > Well, here's an unexpected initial result. > > I just ran a build of langtools+jdk on my ubuntu laptop. I got a > whopping 2658 warnings!! [Those who volunteered to help get rid of > all the warnings, don't all step back at once!] But surprisingly, > after a quick "sort -u", only 625 of them are unique. So that means we > get on average a 4x bang for the buck for each warning we fix :-) > > -- Jon > > > On Jul 11, 2008, at 11:02 AM, Jonathan Gibbons wrote: > >> Depending on what lint options you use, deprecation warnings are >> typically reported as a single "Note:" at the end of the compilation, >> rather than as individual warning messages. Ideally, they should go >> too, but for now, I'd settle for removing messages that show up as >> diagnostics in IDEs, emacs, etc. >> >> For my part, I work mostly in the langtools area, and we are having >> a general background effort to clean up the code there. The goal is >> to clean the code and then use -Werror to treat any reappearance of >> warnings as errors. >> >> -- Jon >> >> >> On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: >> >>> Just curious, would part of this revision process entail removing >>> calls to deprecated methods and replacing them with their documented >>> replacement methods? >>> >>> There are many warnings about calls to deprecated methods in the >>> OpenJDK code. >>> >>> >>> Rob Ross, Lead Software Engineer >>> E! Networks >>> >>> --------------------------------------------------- >>> "Beware of he who would deny you access to information, for in his >>> heart he dreams himself your master." -- Commissioner Pravin Lal >>> >>> >>> >>> On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: >>> >>>> >>>> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >>>> >>>>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>>>> >>>>>> Yes, that technique can work well. But either way, the next step is >>>>>> to try writing the code to analyze the build log, to see how far >>>>>> the general >>>>>> idea can be taken, and how much interest there is to track/fix >>>>>> warnings. >>>>>> >>>>> Personally I'd like there to be no warnings at all, and would like >>>>> to contribute work to get there >>>>> >>>> >>>> Thank you. >>>> >>>> Getting rid of the actual warnings will require cooperation from >>>> the teams who are >>>> responsible for the various parts of the code. In some cases, there >>>> may be resistance, >>>> since stability is sometimes preferred over "no warnings". That >>>> being said, what I'm >>>> hoping to achieve with this discussion and any related effort is a >>>> non-intrusive way >>>> of gathering information about warnings, so that we have a better >>>> understanding of >>>> where the warnings are, in what areas of the code and in which >>>> source files. That way, >>>> we can work with the teams involved to see if there is interest in >>>> reducing their >>>> warning count in as safe a way as possible. Any assistance in >>>> getting to that point >>>> would be welcome. >>>> >>>> (Note that anyone contributing to OpenJDK must first sign the Sun >>>> Contributor Agreement; >>>> you can find details at http://sca.dev.java.net.) >>>> >>>> -- Jon >>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20080713/e5eb68aa/attachment.html From Kelly.Ohair at Sun.COM Mon Jul 14 10:11:25 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Mon, 14 Jul 2008 10:11:25 -0700 Subject: getting a handle on build warnings In-Reply-To: <487AA0EE.8070009@sun.com> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> <487AA0EE.8070009@sun.com> Message-ID: <487B88BD.5050004@sun.com> Was this a Windows X86 build? --- I'll file a bug on the serviceability related files, I thought we had fixed all our warnings. e.g. these: back/ArrayTypeImpl.c 1 back/inStream.c 4 back/outStream.c 8 back/stream.c 4 demo/jvmti/hprof/hprof_init.c 1 democlasses/demo/jvmti/hprof/src/hprof_init.c 1 democlasses/demo/jvmti/waiters/src/Agent.cpp 1 democlasses/demo/jvmti/waiters/src/waiters.cpp 2 instrument/JarFacade.c 1 transport/socket/socket_md.c 3 If we chip away at this, I think we can clean it up over time. -kto Jonathan Gibbons wrote: > I've written a program to analyze the warnings in a build log, > containing most of > the ideas I outlined earlier, and more. > > Right now, a "warning" is defined as a line containing the string "warning" > with false positives filtered out (e.g. a reference to a file called > warning.png) > > It can generate a report in plain text or html, containing any/all of > the following: > - comparison against a reference log, such as the log for an earlier > promoted build > - a summary of the warnings, grouped by the location contained in the > warning > - a summary of the warnings, grouped by the type of the warning > The summaries are given sorted both alphabetically and by frequency. > > I've attached a sample of the output. The input was the log for a build > on my > laptop. For the purposes of testing, the "reference" was the same log > truncated > to 25000 lines. > > The big surprise: One file is responsible for nearly 72% of all the > warnings in this > build: 1928 warnings out of a total of 2684! The file in question is > com/sun/java/util/jar/pack/coding.cpp > > The corollary is good news for everyone else; there are fewer warnings > through > the rest of the build than I expected, with only 14 files having 10 or > more warnings. > But, there are still over 150 files containing warnings :-( > > -- Jon > > > > Jonathan Gibbons wrote: >> Well, here's an unexpected initial result. >> >> I just ran a build of langtools+jdk on my ubuntu laptop. I got a >> whopping 2658 warnings!! [Those who volunteered to help get rid of >> all the warnings, don't all step back at once!] But surprisingly, >> after a quick "sort -u", only 625 of them are unique. So that means we >> get on average a 4x bang for the buck for each warning we fix :-) >> >> -- Jon >> >> >> On Jul 11, 2008, at 11:02 AM, Jonathan Gibbons wrote: >> >>> Depending on what lint options you use, deprecation warnings are >>> typically reported as a single "Note:" at the end of the compilation, >>> rather than as individual warning messages. Ideally, they should go >>> too, but for now, I'd settle for removing messages that show up as >>> diagnostics in IDEs, emacs, etc. >>> >>> For my part, I work mostly in the langtools area, and we are having >>> a general background effort to clean up the code there. The goal is >>> to clean the code and then use -Werror to treat any reappearance of >>> warnings as errors. >>> >>> -- Jon >>> >>> >>> On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: >>> >>>> Just curious, would part of this revision process entail removing >>>> calls to deprecated methods and replacing them with their documented >>>> replacement methods? >>>> >>>> There are many warnings about calls to deprecated methods in the >>>> OpenJDK code. >>>> >>>> >>>> Rob Ross, Lead Software Engineer >>>> E! Networks >>>> >>>> --------------------------------------------------- >>>> "Beware of he who would deny you access to information, for in his >>>> heart he dreams himself your master." -- Commissioner Pravin Lal >>>> >>>> >>>> >>>> On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: >>>> >>>>> >>>>> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >>>>> >>>>>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>>>>> >>>>>>> Yes, that technique can work well. But either way, the next step is >>>>>>> to try writing the code to analyze the build log, to see how far >>>>>>> the general >>>>>>> idea can be taken, and how much interest there is to track/fix >>>>>>> warnings. >>>>>>> >>>>>> Personally I'd like there to be no warnings at all, and would like >>>>>> to contribute work to get there >>>>>> >>>>> >>>>> Thank you. >>>>> >>>>> Getting rid of the actual warnings will require cooperation from >>>>> the teams who are >>>>> responsible for the various parts of the code. In some cases, there >>>>> may be resistance, >>>>> since stability is sometimes preferred over "no warnings". That >>>>> being said, what I'm >>>>> hoping to achieve with this discussion and any related effort is a >>>>> non-intrusive way >>>>> of gathering information about warnings, so that we have a better >>>>> understanding of >>>>> where the warnings are, in what areas of the code and in which >>>>> source files. That way, >>>>> we can work with the teams involved to see if there is interest in >>>>> reducing their >>>>> warning count in as safe a way as possible. Any assistance in >>>>> getting to that point >>>>> would be welcome. >>>>> >>>>> (Note that anyone contributing to OpenJDK must first sign the Sun >>>>> Contributor Agreement; >>>>> you can find details at http://sca.dev.java.net.) >>>>> >>>>> -- Jon >>>>> >>>>> >>>> >>> >> > > > ------------------------------------------------------------------------ > > > JDK Build Warnings > > ------------------------------------------------------------------------ > > * Comparison against reference results > o New warnings not found in reference files <#REF_DELTA_LOCNS> > * Warnings categorized by location > o Warning counts, sorted alphabetically by location > <#LOCN_COUNTS_ALPHA> > o Warning counts, sorted by frequency of location > <#LOCN_COUNTS_FREQ> > o Warning counts, sorted alphabetically by location directory > <#LOCN_DIR_COUNTS_ALPHA> > o Warning counts, sorted by frequency of location directory > <#LOCN_DIR_COUNTS_FREQ> > o Warning counts, sorted alphabetically by location directory > <#LOCN_DIR_COUNTS_ALPHA> > o Warning counts, sorted by frequency of location directory > <#LOCN_DIR_COUNTS_FREQ> > * Warnings categorized by type > o Warning counts, sorted alphabetically by type > <#TYPE_COUNTS_ALPHA> > o Warning counts, sorted by frequency of type <#TYPE_COUNTS_FREQ> > o Warnings with unrecognized types <#TYPE_UNKNOWN> > > ------------------------------------------------------------------------ > > > Log files analyzed > > * build.log > > total lines read 28834 > total warnings found 2648 > unique warnings found 617 > > > Reference files analyzed > > * build-25000.log > > total lines read 25000 > total warnings found 2618 > unique warnings found 590 > > > New warnings not found in reference files > > democlasses/demo/jvmti/hprof/src/hprof_init.c 1 > democlasses/demo/jvmti/waiters/src/Agent.cpp 1 > democlasses/demo/jvmti/waiters/src/waiters.cpp 2 > javax/swing/JColorChooser.java 1 > javax/swing/JComponent.java 4 > javax/swing/JInternalFrame.java 2 > javax/swing/JList.java 4 > javax/swing/JPopupMenu.java 1 > javax/swing/JTabbedPane.java 1 > javax/swing/JTable.java 5 > javax/swing/JTree.java 4 > javax/swing/text/JTextComponent.java 3 > ~NONE~ 1 > > > Warning counts, sorted alphabetically by location > > /usr/include/X11/IntrinsicP.h 1 > /usr/include/langinfo.h 1 > /usr/include/sys/cdefs.h 1 > /usr/include/sys/param.h 2 > back/ArrayTypeImpl.c 1 > back/inStream.c 4 > back/outStream.c 8 > back/stream.c 4 > bin/jexec.c 1 > bin/parse_manifest.c 1 > build/tools/compilefontconfig/CompileFontConfig.java 4 > build/tools/dtdbuilder/DTDParser.java 2 > build/tools/fontchecker/FontChecker.java 2 > build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java 3 > build/tools/javazic/Gen.java 23 > build/tools/javazic/GenDoc.java 2 > build/tools/javazic/Time.java 7 > com/sun/java/util/jar/pack/bands.cpp 2 > com/sun/java/util/jar/pack/coding.cpp 1928 > com/sun/java/util/jar/pack/main.cpp 1 > com/sun/java/util/jar/pack/unpack.cpp 32 > com/sun/java/util/jar/pack/unpack.h 24 > com/sun/java/util/jar/pack/utils.cpp 2 > com/sun/java/util/jar/pack/zip.cpp 1 > com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c 1 > com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c 5 > com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c 1 > common/check_code.c 9 > common/check_format.c 1 > demo/jvmti/hprof/hprof_init.c 1 > democlasses/demo/jvmti/hprof/src/hprof_init.c 1 > democlasses/demo/jvmti/waiters/src/Agent.cpp 1 > democlasses/demo/jvmti/waiters/src/waiters.cpp 2 > hpi/native_threads/src/sys_api_td.c 1 > instrument/JarFacade.c 1 > java/io/canonicalize_md.c 2 > java/io/io_util_md.h 8 > java/lang/Class.c 1 > java/lang/ClassLoader.c 2 > java/lang/fdlibm/include/fdlibm.h 1 > java/lang/fdlibm/src/e_jn.c 1 > java/lang/fdlibm/src/e_pow.c 1 > java/lang/fdlibm/src/e_sqrt.c 1 > java/lang/fdlibm/src/s_ceil.c 1 > java/lang/fdlibm/src/s_floor.c 1 > java/lang/fdlibm/src/s_log1p.c 1 > java/lang/java_props_md.c 3 > java/lang/reflect/Proxy.c 1 > java/net/Inet4AddressImpl.c 2 > java/net/Inet6AddressImpl.c 3 > java/net/NetworkInterface.c 1 > java/net/PlainDatagramSocketImpl.c 6 > java/net/linux_close.c 3 > java/net/net_util_md.c 2 > java/nio/Bits.c 8 > java/nio/MappedByteBuffer.c 1 > java/util/zip/zip_util.c 1 > java/util/zip/zlib-1.1.3/inftrees.c 3 > javavm/include/typedefs.h 8 > javax/swing/JColorChooser.java 1 > javax/swing/JComponent.java 4 > javax/swing/JInternalFrame.java 2 > javax/swing/JList.java 4 > javax/swing/JPopupMenu.java 1 > javax/swing/JTabbedPane.java 1 > javax/swing/JTable.java 5 > javax/swing/JTree.java 4 > javax/swing/text/JTextComponent.java 3 > sun/awt/awt_DrawingSurface.c 1 > sun/awt/awt_Font.c 1 > sun/awt/awt_GraphicsEnv.c 1 > sun/awt/awt_InputMethod.c 11 > sun/awt/awt_LoadLibrary.c 2 > sun/awt/awt_UNIXToolkit.c 1 > sun/awt/giflib/dgif_lib.c 16 > sun/awt/image/BufImgSurfaceData.c 1 > sun/awt/image/jpeg/imageioJPEG.c 19 > sun/awt/image/jpeg/jpegdecoder.c 1 > sun/awt/java2d/loops/ByteBinary1Bit.c 5 > sun/awt/java2d/loops/ByteBinary2Bit.c 5 > sun/awt/java2d/loops/ByteBinary4Bit.c 5 > sun/awt/java2d/loops/ByteGray.c 2 > sun/awt/java2d/loops/ByteIndexed.c 6 > sun/awt/java2d/loops/FourByteAbgr.c 2 > sun/awt/java2d/loops/FourByteAbgrPre.c 2 > sun/awt/java2d/loops/Index12Gray.c 2 > sun/awt/java2d/loops/Index8Gray.c 2 > sun/awt/java2d/loops/IntArgb.c 6 > sun/awt/java2d/loops/IntArgbBm.c 5 > sun/awt/java2d/loops/IntArgbPre.c 6 > sun/awt/java2d/loops/IntBgr.c 2 > sun/awt/java2d/loops/IntRgb.c 2 > sun/awt/java2d/loops/IntRgbx.c 2 > sun/awt/java2d/loops/ThreeByteBgr.c 2 > sun/awt/java2d/loops/TransformHelper.c 3 > sun/awt/java2d/loops/Ushort555Rgb.c 2 > sun/awt/java2d/loops/Ushort565Rgb.c 2 > sun/awt/java2d/loops/UshortGray.c 2 > sun/awt/java2d/loops/UshortIndexed.c 6 > sun/awt/java2d/pipe/Region.c 1 > sun/awt/libpng/pngread.c 1 > sun/awt/libpng/pngrtran.c 1 > sun/awt/libpng/pngrutil.c 1 > sun/awt/libpng/pngwrite.c 1 > sun/awt/medialib/mlib_ImageAffine.c 7 > sun/awt/medialib/mlib_ImageAffineEdge.c 34 > sun/awt/medialib/mlib_ImageColorTrue2Index.c 10 > sun/awt/medialib/mlib_ImageConvMxN.c 9 > sun/awt/medialib/mlib_ImageConv_16ext.c 4 > sun/awt/medialib/mlib_ImageConv_16nw.c 3 > sun/awt/medialib/mlib_ImageConv_32nw.c 2 > sun/awt/medialib/mlib_ImageConv_8ext.c 4 > sun/awt/medialib/mlib_ImageConv_8nw.c 3 > sun/awt/medialib/mlib_ImageConv_D64nw.c 2 > sun/awt/medialib/mlib_ImageConv_F32nw.c 1 > sun/awt/medialib/mlib_ImageConv_u16ext.c 4 > sun/awt/medialib/mlib_ImageConv_u16nw.c 3 > sun/awt/medialib/mlib_ImageCopy_Bit.c 4 > sun/awt/medialib/mlib_ImageCreate.c 2 > sun/awt/splashscreen/splashscreen_gfx_impl.c 2 > sun/font/DrawGlyphList.c 5 > sun/font/X11FontScaler.c 7 > sun/font/layout/LEGlyphStorage.h 32 > sun/font/layout/LEInsertionList.h 33 > sun/font/layout/MorphTables.cpp 1 > sun/java2d/cmm/lcms/LCMS.c 2 > sun/java2d/cmm/lcms/cmscgats.c 2 > sun/java2d/cmm/lcms/cmsio1.c 2 > sun/java2d/cmm/lcms/cmslut.c 4 > sun/java2d/cmm/lcms/cmswtpnt.c 1 > sun/java2d/x11/X11PMBlitLoops.c 2 > sun/java2d/x11/X11Renderer.c 45 > sun/java2d/x11/X11SurfaceData.c 10 > sun/java2d/x11/X11TextRenderer_md.c 1 > sun/net/spi/DefaultProxySelector.c 1 > sun/nio/ch/DatagramChannelImpl.c 1 > sun/nio/ch/InheritedChannel.c 1 > sun/nio/ch/Net.c 2 > sun/nio/ch/ServerSocketChannelImpl.c 1 > sun/nio/ch/SocketChannelImpl.c 1 > sun/rmi/rmic/Main.java 1 > sun/rmi/rmic/newrmic/Resources.java 1 > sun/security/jgss/wrapper/GSSLibStub.c 63 > sun/security/jgss/wrapper/NativeUtil.c 2 > sun/security/pkcs11/j2secmod_md.c 3 > sun/security/pkcs11/wrapper/p11_crypt.c 6 > sun/security/pkcs11/wrapper/p11_digest.c 1 > sun/security/pkcs11/wrapper/p11_keymgmt.c 1 > sun/security/pkcs11/wrapper/p11_md.c 1 > sun/security/pkcs11/wrapper/p11_sign.c 3 > sun/security/pkcs11/wrapper/p11_util.c 2 > sun/tools/serialver/SerialVer.java 1 > sun/tracing/dtrace/JVM.c 1 > sun/xawt/XToolkit.c 2 > sun/xawt/XWindow.c 4 > sun/xawt/awt_Desktop.c 1 > transport/socket/socket_md.c 3 > unpack.cpp 1 > ~NONE~ 5 > > > Warning counts, sorted by frequency of location > > 1928 com/sun/java/util/jar/pack/coding.cpp > 63 sun/security/jgss/wrapper/GSSLibStub.c > 45 sun/java2d/x11/X11Renderer.c > 34 sun/awt/medialib/mlib_ImageAffineEdge.c > 33 sun/font/layout/LEInsertionList.h > 32 com/sun/java/util/jar/pack/unpack.cpp > 32 sun/font/layout/LEGlyphStorage.h > 24 com/sun/java/util/jar/pack/unpack.h > 23 build/tools/javazic/Gen.java > 19 sun/awt/image/jpeg/imageioJPEG.c > 16 sun/awt/giflib/dgif_lib.c > 11 sun/awt/awt_InputMethod.c > 10 sun/awt/medialib/mlib_ImageColorTrue2Index.c > 10 sun/java2d/x11/X11SurfaceData.c > 9 common/check_code.c > 9 sun/awt/medialib/mlib_ImageConvMxN.c > 8 back/outStream.c > 8 java/io/io_util_md.h > 8 java/nio/Bits.c > 8 javavm/include/typedefs.h > 7 build/tools/javazic/Time.java > 7 sun/awt/medialib/mlib_ImageAffine.c > 7 sun/font/X11FontScaler.c > 6 java/net/PlainDatagramSocketImpl.c > 6 sun/awt/java2d/loops/ByteIndexed.c > 6 sun/awt/java2d/loops/IntArgb.c > 6 sun/awt/java2d/loops/IntArgbPre.c > 6 sun/awt/java2d/loops/UshortIndexed.c > 6 sun/security/pkcs11/wrapper/p11_crypt.c > 5 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c > 5 javax/swing/JTable.java > 5 sun/awt/java2d/loops/ByteBinary1Bit.c > 5 sun/awt/java2d/loops/ByteBinary2Bit.c > 5 sun/awt/java2d/loops/ByteBinary4Bit.c > 5 sun/awt/java2d/loops/IntArgbBm.c > 5 sun/font/DrawGlyphList.c > 5 ~NONE~ > 4 back/inStream.c > 4 back/stream.c > 4 build/tools/compilefontconfig/CompileFontConfig.java > 4 javax/swing/JComponent.java > 4 javax/swing/JList.java > 4 javax/swing/JTree.java > 4 sun/awt/medialib/mlib_ImageConv_16ext.c > 4 sun/awt/medialib/mlib_ImageConv_8ext.c > 4 sun/awt/medialib/mlib_ImageConv_u16ext.c > 4 sun/awt/medialib/mlib_ImageCopy_Bit.c > 4 sun/java2d/cmm/lcms/cmslut.c > 4 sun/xawt/XWindow.c > 3 build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java > 3 java/lang/java_props_md.c > 3 java/net/Inet6AddressImpl.c > 3 java/net/linux_close.c > 3 java/util/zip/zlib-1.1.3/inftrees.c > 3 javax/swing/text/JTextComponent.java > 3 sun/awt/java2d/loops/TransformHelper.c > 3 sun/awt/medialib/mlib_ImageConv_16nw.c > 3 sun/awt/medialib/mlib_ImageConv_8nw.c > 3 sun/awt/medialib/mlib_ImageConv_u16nw.c > 3 sun/security/pkcs11/j2secmod_md.c > 3 sun/security/pkcs11/wrapper/p11_sign.c > 3 transport/socket/socket_md.c > 2 /usr/include/sys/param.h > 2 build/tools/dtdbuilder/DTDParser.java > 2 build/tools/fontchecker/FontChecker.java > 2 build/tools/javazic/GenDoc.java > 2 com/sun/java/util/jar/pack/bands.cpp > 2 com/sun/java/util/jar/pack/utils.cpp > 2 democlasses/demo/jvmti/waiters/src/waiters.cpp > 2 java/io/canonicalize_md.c > 2 java/lang/ClassLoader.c > 2 java/net/Inet4AddressImpl.c > 2 java/net/net_util_md.c > 2 javax/swing/JInternalFrame.java > 2 sun/awt/awt_LoadLibrary.c > 2 sun/awt/java2d/loops/ByteGray.c > 2 sun/awt/java2d/loops/FourByteAbgr.c > 2 sun/awt/java2d/loops/FourByteAbgrPre.c > 2 sun/awt/java2d/loops/Index12Gray.c > 2 sun/awt/java2d/loops/Index8Gray.c > 2 sun/awt/java2d/loops/IntBgr.c > 2 sun/awt/java2d/loops/IntRgb.c > 2 sun/awt/java2d/loops/IntRgbx.c > 2 sun/awt/java2d/loops/ThreeByteBgr.c > 2 sun/awt/java2d/loops/Ushort555Rgb.c > 2 sun/awt/java2d/loops/Ushort565Rgb.c > 2 sun/awt/java2d/loops/UshortGray.c > 2 sun/awt/medialib/mlib_ImageConv_32nw.c > 2 sun/awt/medialib/mlib_ImageConv_D64nw.c > 2 sun/awt/medialib/mlib_ImageCreate.c > 2 sun/awt/splashscreen/splashscreen_gfx_impl.c > 2 sun/java2d/cmm/lcms/LCMS.c > 2 sun/java2d/cmm/lcms/cmscgats.c > 2 sun/java2d/cmm/lcms/cmsio1.c > 2 sun/java2d/x11/X11PMBlitLoops.c > 2 sun/nio/ch/Net.c > 2 sun/security/jgss/wrapper/NativeUtil.c > 2 sun/security/pkcs11/wrapper/p11_util.c > 2 sun/xawt/XToolkit.c > 1 /usr/include/X11/IntrinsicP.h > 1 /usr/include/langinfo.h > 1 /usr/include/sys/cdefs.h > 1 back/ArrayTypeImpl.c > 1 bin/jexec.c > 1 bin/parse_manifest.c > 1 com/sun/java/util/jar/pack/main.cpp > 1 com/sun/java/util/jar/pack/zip.cpp > 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c > 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c > 1 common/check_format.c > 1 demo/jvmti/hprof/hprof_init.c > 1 democlasses/demo/jvmti/hprof/src/hprof_init.c > 1 democlasses/demo/jvmti/waiters/src/Agent.cpp > 1 hpi/native_threads/src/sys_api_td.c > 1 instrument/JarFacade.c > 1 java/lang/Class.c > 1 java/lang/fdlibm/include/fdlibm.h > 1 java/lang/fdlibm/src/e_jn.c > 1 java/lang/fdlibm/src/e_pow.c > 1 java/lang/fdlibm/src/e_sqrt.c > 1 java/lang/fdlibm/src/s_ceil.c > 1 java/lang/fdlibm/src/s_floor.c > 1 java/lang/fdlibm/src/s_log1p.c > 1 java/lang/reflect/Proxy.c > 1 java/net/NetworkInterface.c > 1 java/nio/MappedByteBuffer.c > 1 java/util/zip/zip_util.c > 1 javax/swing/JColorChooser.java > 1 javax/swing/JPopupMenu.java > 1 javax/swing/JTabbedPane.java > 1 sun/awt/awt_DrawingSurface.c > 1 sun/awt/awt_Font.c > 1 sun/awt/awt_GraphicsEnv.c > 1 sun/awt/awt_UNIXToolkit.c > 1 sun/awt/image/BufImgSurfaceData.c > 1 sun/awt/image/jpeg/jpegdecoder.c > 1 sun/awt/java2d/pipe/Region.c > 1 sun/awt/libpng/pngread.c > 1 sun/awt/libpng/pngrtran.c > 1 sun/awt/libpng/pngrutil.c > 1 sun/awt/libpng/pngwrite.c > 1 sun/awt/medialib/mlib_ImageConv_F32nw.c > 1 sun/font/layout/MorphTables.cpp > 1 sun/java2d/cmm/lcms/cmswtpnt.c > 1 sun/java2d/x11/X11TextRenderer_md.c > 1 sun/net/spi/DefaultProxySelector.c > 1 sun/nio/ch/DatagramChannelImpl.c > 1 sun/nio/ch/InheritedChannel.c > 1 sun/nio/ch/ServerSocketChannelImpl.c > 1 sun/nio/ch/SocketChannelImpl.c > 1 sun/rmi/rmic/Main.java > 1 sun/rmi/rmic/newrmic/Resources.java > 1 sun/security/pkcs11/wrapper/p11_digest.c > 1 sun/security/pkcs11/wrapper/p11_keymgmt.c > 1 sun/security/pkcs11/wrapper/p11_md.c > 1 sun/tools/serialver/SerialVer.java > 1 sun/tracing/dtrace/JVM.c > 1 sun/xawt/awt_Desktop.c > 1 unpack.cpp > > > Warning counts, sorted alphabetically by location directory > > /usr/include 1 > /usr/include/X11 1 > /usr/include/sys 3 > back 17 > bin 2 > build/tools/compilefontconfig 4 > build/tools/dtdbuilder 2 > build/tools/fontchecker 2 > build/tools/generatebreakiteratordata 3 > build/tools/javazic 32 > com/sun/java/util/jar/pack 1990 > com/sun/media/sound 7 > common 10 > demo/jvmti/hprof 1 > democlasses/demo/jvmti/hprof/src 1 > democlasses/demo/jvmti/waiters/src 3 > hpi/native_threads/src 1 > instrument 1 > java/io 10 > java/lang 6 > java/lang/fdlibm/include 1 > java/lang/fdlibm/src 6 > java/lang/reflect 1 > java/net 17 > java/nio 9 > java/util/zip 1 > java/util/zip/zlib-1.1.3 3 > javavm/include 8 > javax/swing 22 > javax/swing/text 3 > sun/awt 17 > sun/awt/giflib 16 > sun/awt/image 1 > sun/awt/image/jpeg 20 > sun/awt/java2d/loops 71 > sun/awt/java2d/pipe 1 > sun/awt/libpng 4 > sun/awt/medialib 92 > sun/awt/splashscreen 2 > sun/font 12 > sun/font/layout 66 > sun/java2d/cmm/lcms 11 > sun/java2d/x11 58 > sun/net/spi 1 > sun/nio/ch 6 > sun/rmi/rmic 1 > sun/rmi/rmic/newrmic 1 > sun/security/jgss/wrapper 65 > sun/security/pkcs11 3 > sun/security/pkcs11/wrapper 14 > sun/tools/serialver 1 > sun/tracing/dtrace 1 > sun/xawt 7 > transport/socket 3 > unpack.cpp 1 > ~NONE~ 5 > > > Warning counts, sorted by frequency of location > > 1990 com/sun/java/util/jar/pack > 92 sun/awt/medialib > 71 sun/awt/java2d/loops > 66 sun/font/layout > 65 sun/security/jgss/wrapper > 58 sun/java2d/x11 > 32 build/tools/javazic > 22 javax/swing > 20 sun/awt/image/jpeg > 17 back > 17 java/net > 17 sun/awt > 16 sun/awt/giflib > 14 sun/security/pkcs11/wrapper > 12 sun/font > 11 sun/java2d/cmm/lcms > 10 common > 10 java/io > 9 java/nio > 8 javavm/include > 7 com/sun/media/sound > 7 sun/xawt > 6 java/lang > 6 java/lang/fdlibm/src > 6 sun/nio/ch > 5 ~NONE~ > 4 build/tools/compilefontconfig > 4 sun/awt/libpng > 3 /usr/include/sys > 3 build/tools/generatebreakiteratordata > 3 democlasses/demo/jvmti/waiters/src > 3 java/util/zip/zlib-1.1.3 > 3 javax/swing/text > 3 sun/security/pkcs11 > 3 transport/socket > 2 bin > 2 build/tools/dtdbuilder > 2 build/tools/fontchecker > 2 sun/awt/splashscreen > 1 /usr/include > 1 /usr/include/X11 > 1 demo/jvmti/hprof > 1 democlasses/demo/jvmti/hprof/src > 1 hpi/native_threads/src > 1 instrument > 1 java/lang/fdlibm/include > 1 java/lang/reflect > 1 java/util/zip > 1 sun/awt/image > 1 sun/awt/java2d/pipe > 1 sun/net/spi > 1 sun/rmi/rmic > 1 sun/rmi/rmic/newrmic > 1 sun/tools/serialver > 1 sun/tracing/dtrace > 1 unpack.cpp > > > Warning counts, sorted alphabetically by location extension > > .c 474 > .cpp 61 > .h 12 > .java 68 > ~NONE~ 2 > > > Warning counts, sorted by frequency of location extension > > 474 .c > 68 .java > 61 .cpp > 12 .h > 2 ~NONE~ > > > Warning counts, sorted alphabetically by type > > "*" redefined 13 > '*' may be used uninitialized in this function 126 > 'class *' has virtual functions but non-virtual destructor 65 > 'static' is not at beginning of declaration 2 > argument '*' might be clobbered by '*' 1 > assignment from incompatible pointer type 1 > assignment makes integer from pointer without a cast 1 > cast from pointer to integer of different size 22 > cast to java.lang.Object[] for a non-varargs call and to suppress this > warning 4 > cast to pointer from integer of different size 137 > comparison between pointer and integer 3 > comparison between signed and unsigned 106 > comparison is always false due to limited range of data type 2 > constant is too large for*type 18 > control reaches end of non-void function 1 > dereferencing type-punned pointer will break strict-aliasing rules 4 > enumeration value * not handled in switch 101 > format '*' expects type '*', but argument * has type '*' 12 > implicit declaration of function 3 > is Sun proprietary API and may be removed in a future release 67 > missing braces around initializer 2 > missing initializer 1 > missing initializer for member 1874 > non-varargs call of varargs method with inexact argument type for last > parameter 4 > package * does not exist 1 > passing * from incompatible pointer type 3 > pointer targets * differ in signedness 32 > return makes integer from pointer without a cast 5 > signed and unsigned type in conditional expression 16 > the use of `*' is dangerous 1 > this is the location of the previous definition 13 > type defaults to * in declaration 2 > variable '*' might be clobbered by '*' 4 > ~UNKNOWN~ 1 > > > Warning counts, sorted by frequency of type > > 1874 missing initializer for member > 137 cast to pointer from integer of different size > 126 '*' may be used uninitialized in this function > 106 comparison between signed and unsigned > 101 enumeration value * not handled in switch > 67 is Sun proprietary API and may be removed in a future release > 65 'class *' has virtual functions but non-virtual destructor > 32 pointer targets * differ in signedness > 22 cast from pointer to integer of different size > 18 constant is too large for*type > 16 signed and unsigned type in conditional expression > 13 "*" redefined > 13 this is the location of the previous definition > 12 format '*' expects type '*', but argument * has type '*' > 5 return makes integer from pointer without a cast > 4 cast to java.lang.Object[] for a non-varargs call and to suppress > this warning > 4 dereferencing type-punned pointer will break strict-aliasing rules > 4 non-varargs call of varargs method with inexact argument type for > last parameter > 4 variable '*' might be clobbered by '*' > 3 comparison between pointer and integer > 3 implicit declaration of function > 3 passing * from incompatible pointer type > 2 'static' is not at beginning of declaration > 2 comparison is always false due to limited range of data type > 2 missing braces around initializer > 2 type defaults to * in declaration > 1 argument '*' might be clobbered by '*' > 1 assignment from incompatible pointer type > 1 assignment makes integer from pointer without a cast > 1 control reaches end of non-void function > 1 missing initializer > 1 package * does not exist > 1 the use of `*' is dangerous > 1 ~UNKNOWN~ > > > Warnings with unrecognized types > > * ../../../src/solaris/native/java/lang/java_props_md.c:124: > warning: (near initialization for 'sprops.os_version') > > ------------------------------------------------------------------------ > Generated on Sun Jul 13 17:36:12 PDT 2008 From Kelly.Ohair at Sun.COM Mon Jul 14 10:20:51 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Mon, 14 Jul 2008 10:20:51 -0700 Subject: getting a handle on build warnings In-Reply-To: <487B88BD.5050004@sun.com> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> <487AA0EE.8070009@sun.com> <487B88BD.5050004@sun.com> Message-ID: <487B8AF3.8060307@sun.com> Jonathan, I started to look at these warnings and they just aren't in the latest jdk7 nightly log files. Swamy in the serviceability team had fixed all our serviceability warnings at one point, so I'm wondering what jdk7 sources you are using. Or was this openjdk6? -kto Kelly O'Hair wrote: > Was this a Windows X86 build? > > --- > > I'll file a bug on the serviceability related files, I thought we had > fixed all our warnings. e.g. these: > > back/ArrayTypeImpl.c 1 > back/inStream.c 4 > back/outStream.c 8 > back/stream.c 4 > demo/jvmti/hprof/hprof_init.c 1 > democlasses/demo/jvmti/hprof/src/hprof_init.c 1 > democlasses/demo/jvmti/waiters/src/Agent.cpp 1 > democlasses/demo/jvmti/waiters/src/waiters.cpp 2 > instrument/JarFacade.c 1 > transport/socket/socket_md.c 3 > > If we chip away at this, I think we can clean it up over time. > > -kto > > Jonathan Gibbons wrote: >> I've written a program to analyze the warnings in a build log, >> containing most of >> the ideas I outlined earlier, and more. >> >> Right now, a "warning" is defined as a line containing the string >> "warning" >> with false positives filtered out (e.g. a reference to a file called >> warning.png) >> >> It can generate a report in plain text or html, containing any/all of >> the following: >> - comparison against a reference log, such as the log for an earlier >> promoted build >> - a summary of the warnings, grouped by the location contained in the >> warning >> - a summary of the warnings, grouped by the type of the warning >> The summaries are given sorted both alphabetically and by frequency. >> >> I've attached a sample of the output. The input was the log for a >> build on my >> laptop. For the purposes of testing, the "reference" was the same log >> truncated >> to 25000 lines. >> >> The big surprise: One file is responsible for nearly 72% of all the >> warnings in this >> build: 1928 warnings out of a total of 2684! The file in question is >> com/sun/java/util/jar/pack/coding.cpp >> >> The corollary is good news for everyone else; there are fewer warnings >> through >> the rest of the build than I expected, with only 14 files having 10 or >> more warnings. >> But, there are still over 150 files containing warnings :-( >> >> -- Jon >> >> >> >> Jonathan Gibbons wrote: >>> Well, here's an unexpected initial result. >>> >>> I just ran a build of langtools+jdk on my ubuntu laptop. I got a >>> whopping 2658 warnings!! [Those who volunteered to help get rid of >>> all the warnings, don't all step back at once!] But surprisingly, >>> after a quick "sort -u", only 625 of them are unique. So that means >>> we get on average a 4x bang for the buck for each warning we fix :-) >>> >>> -- Jon >>> >>> >>> On Jul 11, 2008, at 11:02 AM, Jonathan Gibbons wrote: >>> >>>> Depending on what lint options you use, deprecation warnings are >>>> typically reported as a single "Note:" at the end of the >>>> compilation, rather than as individual warning messages. Ideally, >>>> they should go too, but for now, I'd settle for removing messages >>>> that show up as diagnostics in IDEs, emacs, etc. >>>> >>>> For my part, I work mostly in the langtools area, and we are having >>>> a general background effort to clean up the code there. The goal is >>>> to clean the code and then use -Werror to treat any reappearance of >>>> warnings as errors. >>>> >>>> -- Jon >>>> >>>> >>>> On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: >>>> >>>>> Just curious, would part of this revision process entail removing >>>>> calls to deprecated methods and replacing them with their >>>>> documented replacement methods? >>>>> >>>>> There are many warnings about calls to deprecated methods in the >>>>> OpenJDK code. >>>>> >>>>> >>>>> Rob Ross, Lead Software Engineer >>>>> E! Networks >>>>> >>>>> --------------------------------------------------- >>>>> "Beware of he who would deny you access to information, for in his >>>>> heart he dreams himself your master." -- Commissioner Pravin Lal >>>>> >>>>> >>>>> >>>>> On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: >>>>> >>>>>> >>>>>> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >>>>>> >>>>>>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>>>>>> >>>>>>>> Yes, that technique can work well. But either way, the next step is >>>>>>>> to try writing the code to analyze the build log, to see how far >>>>>>>> the general >>>>>>>> idea can be taken, and how much interest there is to track/fix >>>>>>>> warnings. >>>>>>>> >>>>>>> Personally I'd like there to be no warnings at all, and would >>>>>>> like to contribute work to get there >>>>>>> >>>>>> >>>>>> Thank you. >>>>>> >>>>>> Getting rid of the actual warnings will require cooperation from >>>>>> the teams who are >>>>>> responsible for the various parts of the code. In some cases, >>>>>> there may be resistance, >>>>>> since stability is sometimes preferred over "no warnings". That >>>>>> being said, what I'm >>>>>> hoping to achieve with this discussion and any related effort is a >>>>>> non-intrusive way >>>>>> of gathering information about warnings, so that we have a better >>>>>> understanding of >>>>>> where the warnings are, in what areas of the code and in which >>>>>> source files. That way, >>>>>> we can work with the teams involved to see if there is interest in >>>>>> reducing their >>>>>> warning count in as safe a way as possible. Any assistance in >>>>>> getting to that point >>>>>> would be welcome. >>>>>> >>>>>> (Note that anyone contributing to OpenJDK must first sign the Sun >>>>>> Contributor Agreement; >>>>>> you can find details at http://sca.dev.java.net.) >>>>>> >>>>>> -- Jon >>>>>> >>>>>> >>>>> >>>> >>> >> >> >> ------------------------------------------------------------------------ >> >> >> JDK Build Warnings >> >> ------------------------------------------------------------------------ >> >> * Comparison against reference results >> o New warnings not found in reference files <#REF_DELTA_LOCNS> >> * Warnings categorized by location >> o Warning counts, sorted alphabetically by location >> <#LOCN_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of location >> <#LOCN_COUNTS_FREQ> >> o Warning counts, sorted alphabetically by location directory >> <#LOCN_DIR_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of location directory >> <#LOCN_DIR_COUNTS_FREQ> >> o Warning counts, sorted alphabetically by location directory >> <#LOCN_DIR_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of location directory >> <#LOCN_DIR_COUNTS_FREQ> >> * Warnings categorized by type >> o Warning counts, sorted alphabetically by type >> <#TYPE_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of type >> <#TYPE_COUNTS_FREQ> >> o Warnings with unrecognized types <#TYPE_UNKNOWN> >> >> ------------------------------------------------------------------------ >> >> >> Log files analyzed >> >> * build.log >> >> total lines read 28834 >> total warnings found 2648 >> unique warnings found 617 >> >> >> Reference files analyzed >> >> * build-25000.log >> >> total lines read 25000 >> total warnings found 2618 >> unique warnings found 590 >> >> >> New warnings not found in reference files >> >> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >> javax/swing/JColorChooser.java 1 >> javax/swing/JComponent.java 4 >> javax/swing/JInternalFrame.java 2 >> javax/swing/JList.java 4 >> javax/swing/JPopupMenu.java 1 >> javax/swing/JTabbedPane.java 1 >> javax/swing/JTable.java 5 >> javax/swing/JTree.java 4 >> javax/swing/text/JTextComponent.java 3 >> ~NONE~ 1 >> >> >> Warning counts, sorted alphabetically by location >> >> /usr/include/X11/IntrinsicP.h 1 >> /usr/include/langinfo.h 1 >> /usr/include/sys/cdefs.h 1 >> /usr/include/sys/param.h 2 >> back/ArrayTypeImpl.c 1 >> back/inStream.c 4 >> back/outStream.c 8 >> back/stream.c 4 >> bin/jexec.c 1 >> bin/parse_manifest.c 1 >> build/tools/compilefontconfig/CompileFontConfig.java 4 >> build/tools/dtdbuilder/DTDParser.java 2 >> build/tools/fontchecker/FontChecker.java 2 >> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >> 3 >> build/tools/javazic/Gen.java 23 >> build/tools/javazic/GenDoc.java 2 >> build/tools/javazic/Time.java 7 >> com/sun/java/util/jar/pack/bands.cpp 2 >> com/sun/java/util/jar/pack/coding.cpp 1928 >> com/sun/java/util/jar/pack/main.cpp 1 >> com/sun/java/util/jar/pack/unpack.cpp 32 >> com/sun/java/util/jar/pack/unpack.h 24 >> com/sun/java/util/jar/pack/utils.cpp 2 >> com/sun/java/util/jar/pack/zip.cpp 1 >> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c 1 >> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c 5 >> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c 1 >> common/check_code.c 9 >> common/check_format.c 1 >> demo/jvmti/hprof/hprof_init.c 1 >> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >> hpi/native_threads/src/sys_api_td.c 1 >> instrument/JarFacade.c 1 >> java/io/canonicalize_md.c 2 >> java/io/io_util_md.h 8 >> java/lang/Class.c 1 >> java/lang/ClassLoader.c 2 >> java/lang/fdlibm/include/fdlibm.h 1 >> java/lang/fdlibm/src/e_jn.c 1 >> java/lang/fdlibm/src/e_pow.c 1 >> java/lang/fdlibm/src/e_sqrt.c 1 >> java/lang/fdlibm/src/s_ceil.c 1 >> java/lang/fdlibm/src/s_floor.c 1 >> java/lang/fdlibm/src/s_log1p.c 1 >> java/lang/java_props_md.c 3 >> java/lang/reflect/Proxy.c 1 >> java/net/Inet4AddressImpl.c 2 >> java/net/Inet6AddressImpl.c 3 >> java/net/NetworkInterface.c 1 >> java/net/PlainDatagramSocketImpl.c 6 >> java/net/linux_close.c 3 >> java/net/net_util_md.c 2 >> java/nio/Bits.c 8 >> java/nio/MappedByteBuffer.c 1 >> java/util/zip/zip_util.c 1 >> java/util/zip/zlib-1.1.3/inftrees.c 3 >> javavm/include/typedefs.h 8 >> javax/swing/JColorChooser.java 1 >> javax/swing/JComponent.java 4 >> javax/swing/JInternalFrame.java 2 >> javax/swing/JList.java 4 >> javax/swing/JPopupMenu.java 1 >> javax/swing/JTabbedPane.java 1 >> javax/swing/JTable.java 5 >> javax/swing/JTree.java 4 >> javax/swing/text/JTextComponent.java 3 >> sun/awt/awt_DrawingSurface.c 1 >> sun/awt/awt_Font.c 1 >> sun/awt/awt_GraphicsEnv.c 1 >> sun/awt/awt_InputMethod.c 11 >> sun/awt/awt_LoadLibrary.c 2 >> sun/awt/awt_UNIXToolkit.c 1 >> sun/awt/giflib/dgif_lib.c 16 >> sun/awt/image/BufImgSurfaceData.c 1 >> sun/awt/image/jpeg/imageioJPEG.c 19 >> sun/awt/image/jpeg/jpegdecoder.c 1 >> sun/awt/java2d/loops/ByteBinary1Bit.c 5 >> sun/awt/java2d/loops/ByteBinary2Bit.c 5 >> sun/awt/java2d/loops/ByteBinary4Bit.c 5 >> sun/awt/java2d/loops/ByteGray.c 2 >> sun/awt/java2d/loops/ByteIndexed.c 6 >> sun/awt/java2d/loops/FourByteAbgr.c 2 >> sun/awt/java2d/loops/FourByteAbgrPre.c 2 >> sun/awt/java2d/loops/Index12Gray.c 2 >> sun/awt/java2d/loops/Index8Gray.c 2 >> sun/awt/java2d/loops/IntArgb.c 6 >> sun/awt/java2d/loops/IntArgbBm.c 5 >> sun/awt/java2d/loops/IntArgbPre.c 6 >> sun/awt/java2d/loops/IntBgr.c 2 >> sun/awt/java2d/loops/IntRgb.c 2 >> sun/awt/java2d/loops/IntRgbx.c 2 >> sun/awt/java2d/loops/ThreeByteBgr.c 2 >> sun/awt/java2d/loops/TransformHelper.c 3 >> sun/awt/java2d/loops/Ushort555Rgb.c 2 >> sun/awt/java2d/loops/Ushort565Rgb.c 2 >> sun/awt/java2d/loops/UshortGray.c 2 >> sun/awt/java2d/loops/UshortIndexed.c 6 >> sun/awt/java2d/pipe/Region.c 1 >> sun/awt/libpng/pngread.c 1 >> sun/awt/libpng/pngrtran.c 1 >> sun/awt/libpng/pngrutil.c 1 >> sun/awt/libpng/pngwrite.c 1 >> sun/awt/medialib/mlib_ImageAffine.c 7 >> sun/awt/medialib/mlib_ImageAffineEdge.c 34 >> sun/awt/medialib/mlib_ImageColorTrue2Index.c 10 >> sun/awt/medialib/mlib_ImageConvMxN.c 9 >> sun/awt/medialib/mlib_ImageConv_16ext.c 4 >> sun/awt/medialib/mlib_ImageConv_16nw.c 3 >> sun/awt/medialib/mlib_ImageConv_32nw.c 2 >> sun/awt/medialib/mlib_ImageConv_8ext.c 4 >> sun/awt/medialib/mlib_ImageConv_8nw.c 3 >> sun/awt/medialib/mlib_ImageConv_D64nw.c 2 >> sun/awt/medialib/mlib_ImageConv_F32nw.c 1 >> sun/awt/medialib/mlib_ImageConv_u16ext.c 4 >> sun/awt/medialib/mlib_ImageConv_u16nw.c 3 >> sun/awt/medialib/mlib_ImageCopy_Bit.c 4 >> sun/awt/medialib/mlib_ImageCreate.c 2 >> sun/awt/splashscreen/splashscreen_gfx_impl.c 2 >> sun/font/DrawGlyphList.c 5 >> sun/font/X11FontScaler.c 7 >> sun/font/layout/LEGlyphStorage.h 32 >> sun/font/layout/LEInsertionList.h 33 >> sun/font/layout/MorphTables.cpp 1 >> sun/java2d/cmm/lcms/LCMS.c 2 >> sun/java2d/cmm/lcms/cmscgats.c 2 >> sun/java2d/cmm/lcms/cmsio1.c 2 >> sun/java2d/cmm/lcms/cmslut.c 4 >> sun/java2d/cmm/lcms/cmswtpnt.c 1 >> sun/java2d/x11/X11PMBlitLoops.c 2 >> sun/java2d/x11/X11Renderer.c 45 >> sun/java2d/x11/X11SurfaceData.c 10 >> sun/java2d/x11/X11TextRenderer_md.c 1 >> sun/net/spi/DefaultProxySelector.c 1 >> sun/nio/ch/DatagramChannelImpl.c 1 >> sun/nio/ch/InheritedChannel.c 1 >> sun/nio/ch/Net.c 2 >> sun/nio/ch/ServerSocketChannelImpl.c 1 >> sun/nio/ch/SocketChannelImpl.c 1 >> sun/rmi/rmic/Main.java 1 >> sun/rmi/rmic/newrmic/Resources.java 1 >> sun/security/jgss/wrapper/GSSLibStub.c 63 >> sun/security/jgss/wrapper/NativeUtil.c 2 >> sun/security/pkcs11/j2secmod_md.c 3 >> sun/security/pkcs11/wrapper/p11_crypt.c 6 >> sun/security/pkcs11/wrapper/p11_digest.c 1 >> sun/security/pkcs11/wrapper/p11_keymgmt.c 1 >> sun/security/pkcs11/wrapper/p11_md.c 1 >> sun/security/pkcs11/wrapper/p11_sign.c 3 >> sun/security/pkcs11/wrapper/p11_util.c 2 >> sun/tools/serialver/SerialVer.java 1 >> sun/tracing/dtrace/JVM.c 1 >> sun/xawt/XToolkit.c 2 >> sun/xawt/XWindow.c 4 >> sun/xawt/awt_Desktop.c 1 >> transport/socket/socket_md.c 3 >> unpack.cpp 1 >> ~NONE~ 5 >> >> >> Warning counts, sorted by frequency of location >> >> 1928 com/sun/java/util/jar/pack/coding.cpp >> 63 sun/security/jgss/wrapper/GSSLibStub.c >> 45 sun/java2d/x11/X11Renderer.c >> 34 sun/awt/medialib/mlib_ImageAffineEdge.c >> 33 sun/font/layout/LEInsertionList.h >> 32 com/sun/java/util/jar/pack/unpack.cpp >> 32 sun/font/layout/LEGlyphStorage.h >> 24 com/sun/java/util/jar/pack/unpack.h >> 23 build/tools/javazic/Gen.java >> 19 sun/awt/image/jpeg/imageioJPEG.c >> 16 sun/awt/giflib/dgif_lib.c >> 11 sun/awt/awt_InputMethod.c >> 10 sun/awt/medialib/mlib_ImageColorTrue2Index.c >> 10 sun/java2d/x11/X11SurfaceData.c >> 9 common/check_code.c >> 9 sun/awt/medialib/mlib_ImageConvMxN.c >> 8 back/outStream.c >> 8 java/io/io_util_md.h >> 8 java/nio/Bits.c >> 8 javavm/include/typedefs.h >> 7 build/tools/javazic/Time.java >> 7 sun/awt/medialib/mlib_ImageAffine.c >> 7 sun/font/X11FontScaler.c >> 6 java/net/PlainDatagramSocketImpl.c >> 6 sun/awt/java2d/loops/ByteIndexed.c >> 6 sun/awt/java2d/loops/IntArgb.c >> 6 sun/awt/java2d/loops/IntArgbPre.c >> 6 sun/awt/java2d/loops/UshortIndexed.c >> 6 sun/security/pkcs11/wrapper/p11_crypt.c >> 5 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c >> 5 javax/swing/JTable.java >> 5 sun/awt/java2d/loops/ByteBinary1Bit.c >> 5 sun/awt/java2d/loops/ByteBinary2Bit.c >> 5 sun/awt/java2d/loops/ByteBinary4Bit.c >> 5 sun/awt/java2d/loops/IntArgbBm.c >> 5 sun/font/DrawGlyphList.c >> 5 ~NONE~ >> 4 back/inStream.c >> 4 back/stream.c >> 4 build/tools/compilefontconfig/CompileFontConfig.java >> 4 javax/swing/JComponent.java >> 4 javax/swing/JList.java >> 4 javax/swing/JTree.java >> 4 sun/awt/medialib/mlib_ImageConv_16ext.c >> 4 sun/awt/medialib/mlib_ImageConv_8ext.c >> 4 sun/awt/medialib/mlib_ImageConv_u16ext.c >> 4 sun/awt/medialib/mlib_ImageCopy_Bit.c >> 4 sun/java2d/cmm/lcms/cmslut.c >> 4 sun/xawt/XWindow.c >> 3 >> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >> 3 java/lang/java_props_md.c >> 3 java/net/Inet6AddressImpl.c >> 3 java/net/linux_close.c >> 3 java/util/zip/zlib-1.1.3/inftrees.c >> 3 javax/swing/text/JTextComponent.java >> 3 sun/awt/java2d/loops/TransformHelper.c >> 3 sun/awt/medialib/mlib_ImageConv_16nw.c >> 3 sun/awt/medialib/mlib_ImageConv_8nw.c >> 3 sun/awt/medialib/mlib_ImageConv_u16nw.c >> 3 sun/security/pkcs11/j2secmod_md.c >> 3 sun/security/pkcs11/wrapper/p11_sign.c >> 3 transport/socket/socket_md.c >> 2 /usr/include/sys/param.h >> 2 build/tools/dtdbuilder/DTDParser.java >> 2 build/tools/fontchecker/FontChecker.java >> 2 build/tools/javazic/GenDoc.java >> 2 com/sun/java/util/jar/pack/bands.cpp >> 2 com/sun/java/util/jar/pack/utils.cpp >> 2 democlasses/demo/jvmti/waiters/src/waiters.cpp >> 2 java/io/canonicalize_md.c >> 2 java/lang/ClassLoader.c >> 2 java/net/Inet4AddressImpl.c >> 2 java/net/net_util_md.c >> 2 javax/swing/JInternalFrame.java >> 2 sun/awt/awt_LoadLibrary.c >> 2 sun/awt/java2d/loops/ByteGray.c >> 2 sun/awt/java2d/loops/FourByteAbgr.c >> 2 sun/awt/java2d/loops/FourByteAbgrPre.c >> 2 sun/awt/java2d/loops/Index12Gray.c >> 2 sun/awt/java2d/loops/Index8Gray.c >> 2 sun/awt/java2d/loops/IntBgr.c >> 2 sun/awt/java2d/loops/IntRgb.c >> 2 sun/awt/java2d/loops/IntRgbx.c >> 2 sun/awt/java2d/loops/ThreeByteBgr.c >> 2 sun/awt/java2d/loops/Ushort555Rgb.c >> 2 sun/awt/java2d/loops/Ushort565Rgb.c >> 2 sun/awt/java2d/loops/UshortGray.c >> 2 sun/awt/medialib/mlib_ImageConv_32nw.c >> 2 sun/awt/medialib/mlib_ImageConv_D64nw.c >> 2 sun/awt/medialib/mlib_ImageCreate.c >> 2 sun/awt/splashscreen/splashscreen_gfx_impl.c >> 2 sun/java2d/cmm/lcms/LCMS.c >> 2 sun/java2d/cmm/lcms/cmscgats.c >> 2 sun/java2d/cmm/lcms/cmsio1.c >> 2 sun/java2d/x11/X11PMBlitLoops.c >> 2 sun/nio/ch/Net.c >> 2 sun/security/jgss/wrapper/NativeUtil.c >> 2 sun/security/pkcs11/wrapper/p11_util.c >> 2 sun/xawt/XToolkit.c >> 1 /usr/include/X11/IntrinsicP.h >> 1 /usr/include/langinfo.h >> 1 /usr/include/sys/cdefs.h >> 1 back/ArrayTypeImpl.c >> 1 bin/jexec.c >> 1 bin/parse_manifest.c >> 1 com/sun/java/util/jar/pack/main.cpp >> 1 com/sun/java/util/jar/pack/zip.cpp >> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c >> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c >> 1 common/check_format.c >> 1 demo/jvmti/hprof/hprof_init.c >> 1 democlasses/demo/jvmti/hprof/src/hprof_init.c >> 1 democlasses/demo/jvmti/waiters/src/Agent.cpp >> 1 hpi/native_threads/src/sys_api_td.c >> 1 instrument/JarFacade.c >> 1 java/lang/Class.c >> 1 java/lang/fdlibm/include/fdlibm.h >> 1 java/lang/fdlibm/src/e_jn.c >> 1 java/lang/fdlibm/src/e_pow.c >> 1 java/lang/fdlibm/src/e_sqrt.c >> 1 java/lang/fdlibm/src/s_ceil.c >> 1 java/lang/fdlibm/src/s_floor.c >> 1 java/lang/fdlibm/src/s_log1p.c >> 1 java/lang/reflect/Proxy.c >> 1 java/net/NetworkInterface.c >> 1 java/nio/MappedByteBuffer.c >> 1 java/util/zip/zip_util.c >> 1 javax/swing/JColorChooser.java >> 1 javax/swing/JPopupMenu.java >> 1 javax/swing/JTabbedPane.java >> 1 sun/awt/awt_DrawingSurface.c >> 1 sun/awt/awt_Font.c >> 1 sun/awt/awt_GraphicsEnv.c >> 1 sun/awt/awt_UNIXToolkit.c >> 1 sun/awt/image/BufImgSurfaceData.c >> 1 sun/awt/image/jpeg/jpegdecoder.c >> 1 sun/awt/java2d/pipe/Region.c >> 1 sun/awt/libpng/pngread.c >> 1 sun/awt/libpng/pngrtran.c >> 1 sun/awt/libpng/pngrutil.c >> 1 sun/awt/libpng/pngwrite.c >> 1 sun/awt/medialib/mlib_ImageConv_F32nw.c >> 1 sun/font/layout/MorphTables.cpp >> 1 sun/java2d/cmm/lcms/cmswtpnt.c >> 1 sun/java2d/x11/X11TextRenderer_md.c >> 1 sun/net/spi/DefaultProxySelector.c >> 1 sun/nio/ch/DatagramChannelImpl.c >> 1 sun/nio/ch/InheritedChannel.c >> 1 sun/nio/ch/ServerSocketChannelImpl.c >> 1 sun/nio/ch/SocketChannelImpl.c >> 1 sun/rmi/rmic/Main.java >> 1 sun/rmi/rmic/newrmic/Resources.java >> 1 sun/security/pkcs11/wrapper/p11_digest.c >> 1 sun/security/pkcs11/wrapper/p11_keymgmt.c >> 1 sun/security/pkcs11/wrapper/p11_md.c >> 1 sun/tools/serialver/SerialVer.java >> 1 sun/tracing/dtrace/JVM.c >> 1 sun/xawt/awt_Desktop.c >> 1 unpack.cpp >> >> >> Warning counts, sorted alphabetically by location directory >> >> /usr/include 1 >> /usr/include/X11 1 >> /usr/include/sys 3 >> back 17 >> bin 2 >> build/tools/compilefontconfig 4 >> build/tools/dtdbuilder 2 >> build/tools/fontchecker 2 >> build/tools/generatebreakiteratordata 3 >> build/tools/javazic 32 >> com/sun/java/util/jar/pack 1990 >> com/sun/media/sound 7 >> common 10 >> demo/jvmti/hprof 1 >> democlasses/demo/jvmti/hprof/src 1 >> democlasses/demo/jvmti/waiters/src 3 >> hpi/native_threads/src 1 >> instrument 1 >> java/io 10 >> java/lang 6 >> java/lang/fdlibm/include 1 >> java/lang/fdlibm/src 6 >> java/lang/reflect 1 >> java/net 17 >> java/nio 9 >> java/util/zip 1 >> java/util/zip/zlib-1.1.3 3 >> javavm/include 8 >> javax/swing 22 >> javax/swing/text 3 >> sun/awt 17 >> sun/awt/giflib 16 >> sun/awt/image 1 >> sun/awt/image/jpeg 20 >> sun/awt/java2d/loops 71 >> sun/awt/java2d/pipe 1 >> sun/awt/libpng 4 >> sun/awt/medialib 92 >> sun/awt/splashscreen 2 >> sun/font 12 >> sun/font/layout 66 >> sun/java2d/cmm/lcms 11 >> sun/java2d/x11 58 >> sun/net/spi 1 >> sun/nio/ch 6 >> sun/rmi/rmic 1 >> sun/rmi/rmic/newrmic 1 >> sun/security/jgss/wrapper 65 >> sun/security/pkcs11 3 >> sun/security/pkcs11/wrapper 14 >> sun/tools/serialver 1 >> sun/tracing/dtrace 1 >> sun/xawt 7 >> transport/socket 3 >> unpack.cpp 1 >> ~NONE~ 5 >> >> >> Warning counts, sorted by frequency of location >> >> 1990 com/sun/java/util/jar/pack >> 92 sun/awt/medialib >> 71 sun/awt/java2d/loops >> 66 sun/font/layout >> 65 sun/security/jgss/wrapper >> 58 sun/java2d/x11 >> 32 build/tools/javazic >> 22 javax/swing >> 20 sun/awt/image/jpeg >> 17 back >> 17 java/net >> 17 sun/awt >> 16 sun/awt/giflib >> 14 sun/security/pkcs11/wrapper >> 12 sun/font >> 11 sun/java2d/cmm/lcms >> 10 common >> 10 java/io >> 9 java/nio >> 8 javavm/include >> 7 com/sun/media/sound >> 7 sun/xawt >> 6 java/lang >> 6 java/lang/fdlibm/src >> 6 sun/nio/ch >> 5 ~NONE~ >> 4 build/tools/compilefontconfig >> 4 sun/awt/libpng >> 3 /usr/include/sys >> 3 build/tools/generatebreakiteratordata >> 3 democlasses/demo/jvmti/waiters/src >> 3 java/util/zip/zlib-1.1.3 >> 3 javax/swing/text >> 3 sun/security/pkcs11 >> 3 transport/socket >> 2 bin >> 2 build/tools/dtdbuilder >> 2 build/tools/fontchecker >> 2 sun/awt/splashscreen >> 1 /usr/include >> 1 /usr/include/X11 >> 1 demo/jvmti/hprof >> 1 democlasses/demo/jvmti/hprof/src >> 1 hpi/native_threads/src >> 1 instrument >> 1 java/lang/fdlibm/include >> 1 java/lang/reflect >> 1 java/util/zip >> 1 sun/awt/image >> 1 sun/awt/java2d/pipe >> 1 sun/net/spi >> 1 sun/rmi/rmic >> 1 sun/rmi/rmic/newrmic >> 1 sun/tools/serialver >> 1 sun/tracing/dtrace >> 1 unpack.cpp >> >> >> Warning counts, sorted alphabetically by location extension >> >> .c 474 >> .cpp 61 >> .h 12 >> .java 68 >> ~NONE~ 2 >> >> >> Warning counts, sorted by frequency of location extension >> >> 474 .c >> 68 .java >> 61 .cpp >> 12 .h >> 2 ~NONE~ >> >> >> Warning counts, sorted alphabetically by type >> >> "*" redefined 13 >> '*' may be used uninitialized in this function 126 >> 'class *' has virtual functions but non-virtual destructor 65 >> 'static' is not at beginning of declaration 2 >> argument '*' might be clobbered by '*' 1 >> assignment from incompatible pointer type 1 >> assignment makes integer from pointer without a cast 1 >> cast from pointer to integer of different size 22 >> cast to java.lang.Object[] for a non-varargs call and to suppress this >> warning 4 >> cast to pointer from integer of different size 137 >> comparison between pointer and integer 3 >> comparison between signed and unsigned 106 >> comparison is always false due to limited range of data type 2 >> constant is too large for*type 18 >> control reaches end of non-void function 1 >> dereferencing type-punned pointer will break strict-aliasing rules 4 >> enumeration value * not handled in switch 101 >> format '*' expects type '*', but argument * has type '*' 12 >> implicit declaration of function 3 >> is Sun proprietary API and may be removed in a future release 67 >> missing braces around initializer 2 >> missing initializer 1 >> missing initializer for member 1874 >> non-varargs call of varargs method with inexact argument type for last >> parameter 4 >> package * does not exist 1 >> passing * from incompatible pointer type 3 >> pointer targets * differ in signedness 32 >> return makes integer from pointer without a cast 5 >> signed and unsigned type in conditional expression 16 >> the use of `*' is dangerous 1 >> this is the location of the previous definition 13 >> type defaults to * in declaration 2 >> variable '*' might be clobbered by '*' 4 >> ~UNKNOWN~ 1 >> >> >> Warning counts, sorted by frequency of type >> >> 1874 missing initializer for member >> 137 cast to pointer from integer of different size >> 126 '*' may be used uninitialized in this function >> 106 comparison between signed and unsigned >> 101 enumeration value * not handled in switch >> 67 is Sun proprietary API and may be removed in a future release >> 65 'class *' has virtual functions but non-virtual destructor >> 32 pointer targets * differ in signedness >> 22 cast from pointer to integer of different size >> 18 constant is too large for*type >> 16 signed and unsigned type in conditional expression >> 13 "*" redefined >> 13 this is the location of the previous definition >> 12 format '*' expects type '*', but argument * has type '*' >> 5 return makes integer from pointer without a cast >> 4 cast to java.lang.Object[] for a non-varargs call and to >> suppress this warning >> 4 dereferencing type-punned pointer will break strict-aliasing rules >> 4 non-varargs call of varargs method with inexact argument type >> for last parameter >> 4 variable '*' might be clobbered by '*' >> 3 comparison between pointer and integer >> 3 implicit declaration of function >> 3 passing * from incompatible pointer type >> 2 'static' is not at beginning of declaration >> 2 comparison is always false due to limited range of data type >> 2 missing braces around initializer >> 2 type defaults to * in declaration >> 1 argument '*' might be clobbered by '*' >> 1 assignment from incompatible pointer type >> 1 assignment makes integer from pointer without a cast >> 1 control reaches end of non-void function >> 1 missing initializer >> 1 package * does not exist >> 1 the use of `*' is dangerous >> 1 ~UNKNOWN~ >> >> >> Warnings with unrecognized types >> >> * ../../../src/solaris/native/java/lang/java_props_md.c:124: >> warning: (near initialization for 'sprops.os_version') >> >> ------------------------------------------------------------------------ >> Generated on Sun Jul 13 17:36:12 PDT 2008 From Jonathan.Gibbons at Sun.COM Mon Jul 14 10:22:57 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Mon, 14 Jul 2008 10:22:57 -0700 Subject: getting a handle on build warnings In-Reply-To: <487B88BD.5050004@sun.com> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> <487AA0EE.8070009@sun.com> <487B88BD.5050004@sun.com> Message-ID: <487B8B71.1040000@sun.com> No, the build log was from Ubuntu 7.10. It looks like the first line of the build contains useful identifying info. I'll include that in the output. I'll look at publishing the program at least internally in Sun until we decide what to do, if anything, with it, and I'll also look at running it on the logs from the last promoted build. -- Jon Kelly O'Hair wrote: > Was this a Windows X86 build? > > --- > > I'll file a bug on the serviceability related files, I thought we had > fixed all our warnings. e.g. these: > > back/ArrayTypeImpl.c 1 > back/inStream.c 4 > back/outStream.c 8 > back/stream.c 4 > demo/jvmti/hprof/hprof_init.c 1 > democlasses/demo/jvmti/hprof/src/hprof_init.c 1 > democlasses/demo/jvmti/waiters/src/Agent.cpp 1 > democlasses/demo/jvmti/waiters/src/waiters.cpp 2 > instrument/JarFacade.c 1 > transport/socket/socket_md.c 3 > > If we chip away at this, I think we can clean it up over time. > > -kto > > Jonathan Gibbons wrote: >> I've written a program to analyze the warnings in a build log, >> containing most of >> the ideas I outlined earlier, and more. >> >> Right now, a "warning" is defined as a line containing the string >> "warning" >> with false positives filtered out (e.g. a reference to a file called >> warning.png) >> >> It can generate a report in plain text or html, containing any/all of >> the following: >> - comparison against a reference log, such as the log for an earlier >> promoted build >> - a summary of the warnings, grouped by the location contained in the >> warning >> - a summary of the warnings, grouped by the type of the warning >> The summaries are given sorted both alphabetically and by frequency. >> >> I've attached a sample of the output. The input was the log for a >> build on my >> laptop. For the purposes of testing, the "reference" was the same log >> truncated >> to 25000 lines. >> >> The big surprise: One file is responsible for nearly 72% of all the >> warnings in this >> build: 1928 warnings out of a total of 2684! The file in question is >> com/sun/java/util/jar/pack/coding.cpp >> >> The corollary is good news for everyone else; there are fewer >> warnings through >> the rest of the build than I expected, with only 14 files having 10 >> or more warnings. >> But, there are still over 150 files containing warnings :-( >> >> -- Jon >> >> >> >> Jonathan Gibbons wrote: >>> Well, here's an unexpected initial result. >>> >>> I just ran a build of langtools+jdk on my ubuntu laptop. I got a >>> whopping 2658 warnings!! [Those who volunteered to help get rid of >>> all the warnings, don't all step back at once!] But surprisingly, >>> after a quick "sort -u", only 625 of them are unique. So that means >>> we get on average a 4x bang for the buck for each warning we fix :-) >>> >>> -- Jon >>> >>> >>> On Jul 11, 2008, at 11:02 AM, Jonathan Gibbons wrote: >>> >>>> Depending on what lint options you use, deprecation warnings are >>>> typically reported as a single "Note:" at the end of the >>>> compilation, rather than as individual warning messages. Ideally, >>>> they should go too, but for now, I'd settle for removing messages >>>> that show up as diagnostics in IDEs, emacs, etc. >>>> >>>> For my part, I work mostly in the langtools area, and we are >>>> having a general background effort to clean up the code there. The >>>> goal is to clean the code and then use -Werror to treat any >>>> reappearance of warnings as errors. >>>> >>>> -- Jon >>>> >>>> >>>> On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: >>>> >>>>> Just curious, would part of this revision process entail removing >>>>> calls to deprecated methods and replacing them with their >>>>> documented replacement methods? >>>>> >>>>> There are many warnings about calls to deprecated methods in the >>>>> OpenJDK code. >>>>> >>>>> >>>>> Rob Ross, Lead Software Engineer >>>>> E! Networks >>>>> >>>>> --------------------------------------------------- >>>>> "Beware of he who would deny you access to information, for in his >>>>> heart he dreams himself your master." -- Commissioner Pravin Lal >>>>> >>>>> >>>>> >>>>> On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: >>>>> >>>>>> >>>>>> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >>>>>> >>>>>>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>>>>>> >>>>>>>> Yes, that technique can work well. But either way, the next >>>>>>>> step is >>>>>>>> to try writing the code to analyze the build log, to see how >>>>>>>> far the general >>>>>>>> idea can be taken, and how much interest there is to track/fix >>>>>>>> warnings. >>>>>>>> >>>>>>> Personally I'd like there to be no warnings at all, and would >>>>>>> like to contribute work to get there >>>>>>> >>>>>> >>>>>> Thank you. >>>>>> >>>>>> Getting rid of the actual warnings will require cooperation from >>>>>> the teams who are >>>>>> responsible for the various parts of the code. In some cases, >>>>>> there may be resistance, >>>>>> since stability is sometimes preferred over "no warnings". That >>>>>> being said, what I'm >>>>>> hoping to achieve with this discussion and any related effort is >>>>>> a non-intrusive way >>>>>> of gathering information about warnings, so that we have a better >>>>>> understanding of >>>>>> where the warnings are, in what areas of the code and in which >>>>>> source files. That way, >>>>>> we can work with the teams involved to see if there is interest >>>>>> in reducing their >>>>>> warning count in as safe a way as possible. Any assistance in >>>>>> getting to that point >>>>>> would be welcome. >>>>>> >>>>>> (Note that anyone contributing to OpenJDK must first sign the Sun >>>>>> Contributor Agreement; >>>>>> you can find details at http://sca.dev.java.net.) >>>>>> >>>>>> -- Jon >>>>>> >>>>>> >>>>> >>>> >>> >> >> >> ------------------------------------------------------------------------ >> >> >> JDK Build Warnings >> >> ------------------------------------------------------------------------ >> >> * Comparison against reference results >> o New warnings not found in reference files <#REF_DELTA_LOCNS> >> * Warnings categorized by location >> o Warning counts, sorted alphabetically by location >> <#LOCN_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of location >> <#LOCN_COUNTS_FREQ> >> o Warning counts, sorted alphabetically by location directory >> <#LOCN_DIR_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of location directory >> <#LOCN_DIR_COUNTS_FREQ> >> o Warning counts, sorted alphabetically by location directory >> <#LOCN_DIR_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of location directory >> <#LOCN_DIR_COUNTS_FREQ> >> * Warnings categorized by type >> o Warning counts, sorted alphabetically by type >> <#TYPE_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of type >> <#TYPE_COUNTS_FREQ> >> o Warnings with unrecognized types <#TYPE_UNKNOWN> >> >> ------------------------------------------------------------------------ >> >> >> Log files analyzed >> >> * build.log >> >> total lines read 28834 >> total warnings found 2648 >> unique warnings found 617 >> >> >> Reference files analyzed >> >> * build-25000.log >> >> total lines read 25000 >> total warnings found 2618 >> unique warnings found 590 >> >> >> New warnings not found in reference files >> >> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >> javax/swing/JColorChooser.java 1 >> javax/swing/JComponent.java 4 >> javax/swing/JInternalFrame.java 2 >> javax/swing/JList.java 4 >> javax/swing/JPopupMenu.java 1 >> javax/swing/JTabbedPane.java 1 >> javax/swing/JTable.java 5 >> javax/swing/JTree.java 4 >> javax/swing/text/JTextComponent.java 3 >> ~NONE~ 1 >> >> >> Warning counts, sorted alphabetically by location >> >> /usr/include/X11/IntrinsicP.h 1 >> /usr/include/langinfo.h 1 >> /usr/include/sys/cdefs.h 1 >> /usr/include/sys/param.h 2 >> back/ArrayTypeImpl.c 1 >> back/inStream.c 4 >> back/outStream.c 8 >> back/stream.c 4 >> bin/jexec.c 1 >> bin/parse_manifest.c 1 >> build/tools/compilefontconfig/CompileFontConfig.java 4 >> build/tools/dtdbuilder/DTDParser.java 2 >> build/tools/fontchecker/FontChecker.java 2 >> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >> 3 >> build/tools/javazic/Gen.java 23 >> build/tools/javazic/GenDoc.java 2 >> build/tools/javazic/Time.java 7 >> com/sun/java/util/jar/pack/bands.cpp 2 >> com/sun/java/util/jar/pack/coding.cpp 1928 >> com/sun/java/util/jar/pack/main.cpp 1 >> com/sun/java/util/jar/pack/unpack.cpp 32 >> com/sun/java/util/jar/pack/unpack.h 24 >> com/sun/java/util/jar/pack/utils.cpp 2 >> com/sun/java/util/jar/pack/zip.cpp 1 >> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c 1 >> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c 5 >> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c 1 >> common/check_code.c 9 >> common/check_format.c 1 >> demo/jvmti/hprof/hprof_init.c 1 >> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >> hpi/native_threads/src/sys_api_td.c 1 >> instrument/JarFacade.c 1 >> java/io/canonicalize_md.c 2 >> java/io/io_util_md.h 8 >> java/lang/Class.c 1 >> java/lang/ClassLoader.c 2 >> java/lang/fdlibm/include/fdlibm.h 1 >> java/lang/fdlibm/src/e_jn.c 1 >> java/lang/fdlibm/src/e_pow.c 1 >> java/lang/fdlibm/src/e_sqrt.c 1 >> java/lang/fdlibm/src/s_ceil.c 1 >> java/lang/fdlibm/src/s_floor.c 1 >> java/lang/fdlibm/src/s_log1p.c 1 >> java/lang/java_props_md.c 3 >> java/lang/reflect/Proxy.c 1 >> java/net/Inet4AddressImpl.c 2 >> java/net/Inet6AddressImpl.c 3 >> java/net/NetworkInterface.c 1 >> java/net/PlainDatagramSocketImpl.c 6 >> java/net/linux_close.c 3 >> java/net/net_util_md.c 2 >> java/nio/Bits.c 8 >> java/nio/MappedByteBuffer.c 1 >> java/util/zip/zip_util.c 1 >> java/util/zip/zlib-1.1.3/inftrees.c 3 >> javavm/include/typedefs.h 8 >> javax/swing/JColorChooser.java 1 >> javax/swing/JComponent.java 4 >> javax/swing/JInternalFrame.java 2 >> javax/swing/JList.java 4 >> javax/swing/JPopupMenu.java 1 >> javax/swing/JTabbedPane.java 1 >> javax/swing/JTable.java 5 >> javax/swing/JTree.java 4 >> javax/swing/text/JTextComponent.java 3 >> sun/awt/awt_DrawingSurface.c 1 >> sun/awt/awt_Font.c 1 >> sun/awt/awt_GraphicsEnv.c 1 >> sun/awt/awt_InputMethod.c 11 >> sun/awt/awt_LoadLibrary.c 2 >> sun/awt/awt_UNIXToolkit.c 1 >> sun/awt/giflib/dgif_lib.c 16 >> sun/awt/image/BufImgSurfaceData.c 1 >> sun/awt/image/jpeg/imageioJPEG.c 19 >> sun/awt/image/jpeg/jpegdecoder.c 1 >> sun/awt/java2d/loops/ByteBinary1Bit.c 5 >> sun/awt/java2d/loops/ByteBinary2Bit.c 5 >> sun/awt/java2d/loops/ByteBinary4Bit.c 5 >> sun/awt/java2d/loops/ByteGray.c 2 >> sun/awt/java2d/loops/ByteIndexed.c 6 >> sun/awt/java2d/loops/FourByteAbgr.c 2 >> sun/awt/java2d/loops/FourByteAbgrPre.c 2 >> sun/awt/java2d/loops/Index12Gray.c 2 >> sun/awt/java2d/loops/Index8Gray.c 2 >> sun/awt/java2d/loops/IntArgb.c 6 >> sun/awt/java2d/loops/IntArgbBm.c 5 >> sun/awt/java2d/loops/IntArgbPre.c 6 >> sun/awt/java2d/loops/IntBgr.c 2 >> sun/awt/java2d/loops/IntRgb.c 2 >> sun/awt/java2d/loops/IntRgbx.c 2 >> sun/awt/java2d/loops/ThreeByteBgr.c 2 >> sun/awt/java2d/loops/TransformHelper.c 3 >> sun/awt/java2d/loops/Ushort555Rgb.c 2 >> sun/awt/java2d/loops/Ushort565Rgb.c 2 >> sun/awt/java2d/loops/UshortGray.c 2 >> sun/awt/java2d/loops/UshortIndexed.c 6 >> sun/awt/java2d/pipe/Region.c 1 >> sun/awt/libpng/pngread.c 1 >> sun/awt/libpng/pngrtran.c 1 >> sun/awt/libpng/pngrutil.c 1 >> sun/awt/libpng/pngwrite.c 1 >> sun/awt/medialib/mlib_ImageAffine.c 7 >> sun/awt/medialib/mlib_ImageAffineEdge.c 34 >> sun/awt/medialib/mlib_ImageColorTrue2Index.c 10 >> sun/awt/medialib/mlib_ImageConvMxN.c 9 >> sun/awt/medialib/mlib_ImageConv_16ext.c 4 >> sun/awt/medialib/mlib_ImageConv_16nw.c 3 >> sun/awt/medialib/mlib_ImageConv_32nw.c 2 >> sun/awt/medialib/mlib_ImageConv_8ext.c 4 >> sun/awt/medialib/mlib_ImageConv_8nw.c 3 >> sun/awt/medialib/mlib_ImageConv_D64nw.c 2 >> sun/awt/medialib/mlib_ImageConv_F32nw.c 1 >> sun/awt/medialib/mlib_ImageConv_u16ext.c 4 >> sun/awt/medialib/mlib_ImageConv_u16nw.c 3 >> sun/awt/medialib/mlib_ImageCopy_Bit.c 4 >> sun/awt/medialib/mlib_ImageCreate.c 2 >> sun/awt/splashscreen/splashscreen_gfx_impl.c 2 >> sun/font/DrawGlyphList.c 5 >> sun/font/X11FontScaler.c 7 >> sun/font/layout/LEGlyphStorage.h 32 >> sun/font/layout/LEInsertionList.h 33 >> sun/font/layout/MorphTables.cpp 1 >> sun/java2d/cmm/lcms/LCMS.c 2 >> sun/java2d/cmm/lcms/cmscgats.c 2 >> sun/java2d/cmm/lcms/cmsio1.c 2 >> sun/java2d/cmm/lcms/cmslut.c 4 >> sun/java2d/cmm/lcms/cmswtpnt.c 1 >> sun/java2d/x11/X11PMBlitLoops.c 2 >> sun/java2d/x11/X11Renderer.c 45 >> sun/java2d/x11/X11SurfaceData.c 10 >> sun/java2d/x11/X11TextRenderer_md.c 1 >> sun/net/spi/DefaultProxySelector.c 1 >> sun/nio/ch/DatagramChannelImpl.c 1 >> sun/nio/ch/InheritedChannel.c 1 >> sun/nio/ch/Net.c 2 >> sun/nio/ch/ServerSocketChannelImpl.c 1 >> sun/nio/ch/SocketChannelImpl.c 1 >> sun/rmi/rmic/Main.java 1 >> sun/rmi/rmic/newrmic/Resources.java 1 >> sun/security/jgss/wrapper/GSSLibStub.c 63 >> sun/security/jgss/wrapper/NativeUtil.c 2 >> sun/security/pkcs11/j2secmod_md.c 3 >> sun/security/pkcs11/wrapper/p11_crypt.c 6 >> sun/security/pkcs11/wrapper/p11_digest.c 1 >> sun/security/pkcs11/wrapper/p11_keymgmt.c 1 >> sun/security/pkcs11/wrapper/p11_md.c 1 >> sun/security/pkcs11/wrapper/p11_sign.c 3 >> sun/security/pkcs11/wrapper/p11_util.c 2 >> sun/tools/serialver/SerialVer.java 1 >> sun/tracing/dtrace/JVM.c 1 >> sun/xawt/XToolkit.c 2 >> sun/xawt/XWindow.c 4 >> sun/xawt/awt_Desktop.c 1 >> transport/socket/socket_md.c 3 >> unpack.cpp 1 >> ~NONE~ 5 >> >> >> Warning counts, sorted by frequency of location >> >> 1928 com/sun/java/util/jar/pack/coding.cpp >> 63 sun/security/jgss/wrapper/GSSLibStub.c >> 45 sun/java2d/x11/X11Renderer.c >> 34 sun/awt/medialib/mlib_ImageAffineEdge.c >> 33 sun/font/layout/LEInsertionList.h >> 32 com/sun/java/util/jar/pack/unpack.cpp >> 32 sun/font/layout/LEGlyphStorage.h >> 24 com/sun/java/util/jar/pack/unpack.h >> 23 build/tools/javazic/Gen.java >> 19 sun/awt/image/jpeg/imageioJPEG.c >> 16 sun/awt/giflib/dgif_lib.c >> 11 sun/awt/awt_InputMethod.c >> 10 sun/awt/medialib/mlib_ImageColorTrue2Index.c >> 10 sun/java2d/x11/X11SurfaceData.c >> 9 common/check_code.c >> 9 sun/awt/medialib/mlib_ImageConvMxN.c >> 8 back/outStream.c >> 8 java/io/io_util_md.h >> 8 java/nio/Bits.c >> 8 javavm/include/typedefs.h >> 7 build/tools/javazic/Time.java >> 7 sun/awt/medialib/mlib_ImageAffine.c >> 7 sun/font/X11FontScaler.c >> 6 java/net/PlainDatagramSocketImpl.c >> 6 sun/awt/java2d/loops/ByteIndexed.c >> 6 sun/awt/java2d/loops/IntArgb.c >> 6 sun/awt/java2d/loops/IntArgbPre.c >> 6 sun/awt/java2d/loops/UshortIndexed.c >> 6 sun/security/pkcs11/wrapper/p11_crypt.c >> 5 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c >> 5 javax/swing/JTable.java >> 5 sun/awt/java2d/loops/ByteBinary1Bit.c >> 5 sun/awt/java2d/loops/ByteBinary2Bit.c >> 5 sun/awt/java2d/loops/ByteBinary4Bit.c >> 5 sun/awt/java2d/loops/IntArgbBm.c >> 5 sun/font/DrawGlyphList.c >> 5 ~NONE~ >> 4 back/inStream.c >> 4 back/stream.c >> 4 build/tools/compilefontconfig/CompileFontConfig.java >> 4 javax/swing/JComponent.java >> 4 javax/swing/JList.java >> 4 javax/swing/JTree.java >> 4 sun/awt/medialib/mlib_ImageConv_16ext.c >> 4 sun/awt/medialib/mlib_ImageConv_8ext.c >> 4 sun/awt/medialib/mlib_ImageConv_u16ext.c >> 4 sun/awt/medialib/mlib_ImageCopy_Bit.c >> 4 sun/java2d/cmm/lcms/cmslut.c >> 4 sun/xawt/XWindow.c >> 3 >> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >> 3 java/lang/java_props_md.c >> 3 java/net/Inet6AddressImpl.c >> 3 java/net/linux_close.c >> 3 java/util/zip/zlib-1.1.3/inftrees.c >> 3 javax/swing/text/JTextComponent.java >> 3 sun/awt/java2d/loops/TransformHelper.c >> 3 sun/awt/medialib/mlib_ImageConv_16nw.c >> 3 sun/awt/medialib/mlib_ImageConv_8nw.c >> 3 sun/awt/medialib/mlib_ImageConv_u16nw.c >> 3 sun/security/pkcs11/j2secmod_md.c >> 3 sun/security/pkcs11/wrapper/p11_sign.c >> 3 transport/socket/socket_md.c >> 2 /usr/include/sys/param.h >> 2 build/tools/dtdbuilder/DTDParser.java >> 2 build/tools/fontchecker/FontChecker.java >> 2 build/tools/javazic/GenDoc.java >> 2 com/sun/java/util/jar/pack/bands.cpp >> 2 com/sun/java/util/jar/pack/utils.cpp >> 2 democlasses/demo/jvmti/waiters/src/waiters.cpp >> 2 java/io/canonicalize_md.c >> 2 java/lang/ClassLoader.c >> 2 java/net/Inet4AddressImpl.c >> 2 java/net/net_util_md.c >> 2 javax/swing/JInternalFrame.java >> 2 sun/awt/awt_LoadLibrary.c >> 2 sun/awt/java2d/loops/ByteGray.c >> 2 sun/awt/java2d/loops/FourByteAbgr.c >> 2 sun/awt/java2d/loops/FourByteAbgrPre.c >> 2 sun/awt/java2d/loops/Index12Gray.c >> 2 sun/awt/java2d/loops/Index8Gray.c >> 2 sun/awt/java2d/loops/IntBgr.c >> 2 sun/awt/java2d/loops/IntRgb.c >> 2 sun/awt/java2d/loops/IntRgbx.c >> 2 sun/awt/java2d/loops/ThreeByteBgr.c >> 2 sun/awt/java2d/loops/Ushort555Rgb.c >> 2 sun/awt/java2d/loops/Ushort565Rgb.c >> 2 sun/awt/java2d/loops/UshortGray.c >> 2 sun/awt/medialib/mlib_ImageConv_32nw.c >> 2 sun/awt/medialib/mlib_ImageConv_D64nw.c >> 2 sun/awt/medialib/mlib_ImageCreate.c >> 2 sun/awt/splashscreen/splashscreen_gfx_impl.c >> 2 sun/java2d/cmm/lcms/LCMS.c >> 2 sun/java2d/cmm/lcms/cmscgats.c >> 2 sun/java2d/cmm/lcms/cmsio1.c >> 2 sun/java2d/x11/X11PMBlitLoops.c >> 2 sun/nio/ch/Net.c >> 2 sun/security/jgss/wrapper/NativeUtil.c >> 2 sun/security/pkcs11/wrapper/p11_util.c >> 2 sun/xawt/XToolkit.c >> 1 /usr/include/X11/IntrinsicP.h >> 1 /usr/include/langinfo.h >> 1 /usr/include/sys/cdefs.h >> 1 back/ArrayTypeImpl.c >> 1 bin/jexec.c >> 1 bin/parse_manifest.c >> 1 com/sun/java/util/jar/pack/main.cpp >> 1 com/sun/java/util/jar/pack/zip.cpp >> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c >> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c >> 1 common/check_format.c >> 1 demo/jvmti/hprof/hprof_init.c >> 1 democlasses/demo/jvmti/hprof/src/hprof_init.c >> 1 democlasses/demo/jvmti/waiters/src/Agent.cpp >> 1 hpi/native_threads/src/sys_api_td.c >> 1 instrument/JarFacade.c >> 1 java/lang/Class.c >> 1 java/lang/fdlibm/include/fdlibm.h >> 1 java/lang/fdlibm/src/e_jn.c >> 1 java/lang/fdlibm/src/e_pow.c >> 1 java/lang/fdlibm/src/e_sqrt.c >> 1 java/lang/fdlibm/src/s_ceil.c >> 1 java/lang/fdlibm/src/s_floor.c >> 1 java/lang/fdlibm/src/s_log1p.c >> 1 java/lang/reflect/Proxy.c >> 1 java/net/NetworkInterface.c >> 1 java/nio/MappedByteBuffer.c >> 1 java/util/zip/zip_util.c >> 1 javax/swing/JColorChooser.java >> 1 javax/swing/JPopupMenu.java >> 1 javax/swing/JTabbedPane.java >> 1 sun/awt/awt_DrawingSurface.c >> 1 sun/awt/awt_Font.c >> 1 sun/awt/awt_GraphicsEnv.c >> 1 sun/awt/awt_UNIXToolkit.c >> 1 sun/awt/image/BufImgSurfaceData.c >> 1 sun/awt/image/jpeg/jpegdecoder.c >> 1 sun/awt/java2d/pipe/Region.c >> 1 sun/awt/libpng/pngread.c >> 1 sun/awt/libpng/pngrtran.c >> 1 sun/awt/libpng/pngrutil.c >> 1 sun/awt/libpng/pngwrite.c >> 1 sun/awt/medialib/mlib_ImageConv_F32nw.c >> 1 sun/font/layout/MorphTables.cpp >> 1 sun/java2d/cmm/lcms/cmswtpnt.c >> 1 sun/java2d/x11/X11TextRenderer_md.c >> 1 sun/net/spi/DefaultProxySelector.c >> 1 sun/nio/ch/DatagramChannelImpl.c >> 1 sun/nio/ch/InheritedChannel.c >> 1 sun/nio/ch/ServerSocketChannelImpl.c >> 1 sun/nio/ch/SocketChannelImpl.c >> 1 sun/rmi/rmic/Main.java >> 1 sun/rmi/rmic/newrmic/Resources.java >> 1 sun/security/pkcs11/wrapper/p11_digest.c >> 1 sun/security/pkcs11/wrapper/p11_keymgmt.c >> 1 sun/security/pkcs11/wrapper/p11_md.c >> 1 sun/tools/serialver/SerialVer.java >> 1 sun/tracing/dtrace/JVM.c >> 1 sun/xawt/awt_Desktop.c >> 1 unpack.cpp >> >> >> Warning counts, sorted alphabetically by location directory >> >> /usr/include 1 >> /usr/include/X11 1 >> /usr/include/sys 3 >> back 17 >> bin 2 >> build/tools/compilefontconfig 4 >> build/tools/dtdbuilder 2 >> build/tools/fontchecker 2 >> build/tools/generatebreakiteratordata 3 >> build/tools/javazic 32 >> com/sun/java/util/jar/pack 1990 >> com/sun/media/sound 7 >> common 10 >> demo/jvmti/hprof 1 >> democlasses/demo/jvmti/hprof/src 1 >> democlasses/demo/jvmti/waiters/src 3 >> hpi/native_threads/src 1 >> instrument 1 >> java/io 10 >> java/lang 6 >> java/lang/fdlibm/include 1 >> java/lang/fdlibm/src 6 >> java/lang/reflect 1 >> java/net 17 >> java/nio 9 >> java/util/zip 1 >> java/util/zip/zlib-1.1.3 3 >> javavm/include 8 >> javax/swing 22 >> javax/swing/text 3 >> sun/awt 17 >> sun/awt/giflib 16 >> sun/awt/image 1 >> sun/awt/image/jpeg 20 >> sun/awt/java2d/loops 71 >> sun/awt/java2d/pipe 1 >> sun/awt/libpng 4 >> sun/awt/medialib 92 >> sun/awt/splashscreen 2 >> sun/font 12 >> sun/font/layout 66 >> sun/java2d/cmm/lcms 11 >> sun/java2d/x11 58 >> sun/net/spi 1 >> sun/nio/ch 6 >> sun/rmi/rmic 1 >> sun/rmi/rmic/newrmic 1 >> sun/security/jgss/wrapper 65 >> sun/security/pkcs11 3 >> sun/security/pkcs11/wrapper 14 >> sun/tools/serialver 1 >> sun/tracing/dtrace 1 >> sun/xawt 7 >> transport/socket 3 >> unpack.cpp 1 >> ~NONE~ 5 >> >> >> Warning counts, sorted by frequency of location >> >> 1990 com/sun/java/util/jar/pack >> 92 sun/awt/medialib >> 71 sun/awt/java2d/loops >> 66 sun/font/layout >> 65 sun/security/jgss/wrapper >> 58 sun/java2d/x11 >> 32 build/tools/javazic >> 22 javax/swing >> 20 sun/awt/image/jpeg >> 17 back >> 17 java/net >> 17 sun/awt >> 16 sun/awt/giflib >> 14 sun/security/pkcs11/wrapper >> 12 sun/font >> 11 sun/java2d/cmm/lcms >> 10 common >> 10 java/io >> 9 java/nio >> 8 javavm/include >> 7 com/sun/media/sound >> 7 sun/xawt >> 6 java/lang >> 6 java/lang/fdlibm/src >> 6 sun/nio/ch >> 5 ~NONE~ >> 4 build/tools/compilefontconfig >> 4 sun/awt/libpng >> 3 /usr/include/sys >> 3 build/tools/generatebreakiteratordata >> 3 democlasses/demo/jvmti/waiters/src >> 3 java/util/zip/zlib-1.1.3 >> 3 javax/swing/text >> 3 sun/security/pkcs11 >> 3 transport/socket >> 2 bin >> 2 build/tools/dtdbuilder >> 2 build/tools/fontchecker >> 2 sun/awt/splashscreen >> 1 /usr/include >> 1 /usr/include/X11 >> 1 demo/jvmti/hprof >> 1 democlasses/demo/jvmti/hprof/src >> 1 hpi/native_threads/src >> 1 instrument >> 1 java/lang/fdlibm/include >> 1 java/lang/reflect >> 1 java/util/zip >> 1 sun/awt/image >> 1 sun/awt/java2d/pipe >> 1 sun/net/spi >> 1 sun/rmi/rmic >> 1 sun/rmi/rmic/newrmic >> 1 sun/tools/serialver >> 1 sun/tracing/dtrace >> 1 unpack.cpp >> >> >> Warning counts, sorted alphabetically by location extension >> >> .c 474 >> .cpp 61 >> .h 12 >> .java 68 >> ~NONE~ 2 >> >> >> Warning counts, sorted by frequency of location extension >> >> 474 .c >> 68 .java >> 61 .cpp >> 12 .h >> 2 ~NONE~ >> >> >> Warning counts, sorted alphabetically by type >> >> "*" redefined 13 >> '*' may be used uninitialized in this function 126 >> 'class *' has virtual functions but non-virtual destructor 65 >> 'static' is not at beginning of declaration 2 >> argument '*' might be clobbered by '*' 1 >> assignment from incompatible pointer type 1 >> assignment makes integer from pointer without a cast 1 >> cast from pointer to integer of different size 22 >> cast to java.lang.Object[] for a non-varargs call and to suppress >> this warning 4 >> cast to pointer from integer of different size 137 >> comparison between pointer and integer 3 >> comparison between signed and unsigned 106 >> comparison is always false due to limited range of data type 2 >> constant is too large for*type 18 >> control reaches end of non-void function 1 >> dereferencing type-punned pointer will break strict-aliasing rules 4 >> enumeration value * not handled in switch 101 >> format '*' expects type '*', but argument * has type '*' 12 >> implicit declaration of function 3 >> is Sun proprietary API and may be removed in a future release 67 >> missing braces around initializer 2 >> missing initializer 1 >> missing initializer for member 1874 >> non-varargs call of varargs method with inexact argument type for >> last parameter 4 >> package * does not exist 1 >> passing * from incompatible pointer type 3 >> pointer targets * differ in signedness 32 >> return makes integer from pointer without a cast 5 >> signed and unsigned type in conditional expression 16 >> the use of `*' is dangerous 1 >> this is the location of the previous definition 13 >> type defaults to * in declaration 2 >> variable '*' might be clobbered by '*' 4 >> ~UNKNOWN~ 1 >> >> >> Warning counts, sorted by frequency of type >> >> 1874 missing initializer for member >> 137 cast to pointer from integer of different size >> 126 '*' may be used uninitialized in this function >> 106 comparison between signed and unsigned >> 101 enumeration value * not handled in switch >> 67 is Sun proprietary API and may be removed in a future release >> 65 'class *' has virtual functions but non-virtual destructor >> 32 pointer targets * differ in signedness >> 22 cast from pointer to integer of different size >> 18 constant is too large for*type >> 16 signed and unsigned type in conditional expression >> 13 "*" redefined >> 13 this is the location of the previous definition >> 12 format '*' expects type '*', but argument * has type '*' >> 5 return makes integer from pointer without a cast >> 4 cast to java.lang.Object[] for a non-varargs call and to >> suppress this warning >> 4 dereferencing type-punned pointer will break strict-aliasing rules >> 4 non-varargs call of varargs method with inexact argument type >> for last parameter >> 4 variable '*' might be clobbered by '*' >> 3 comparison between pointer and integer >> 3 implicit declaration of function >> 3 passing * from incompatible pointer type >> 2 'static' is not at beginning of declaration >> 2 comparison is always false due to limited range of data type >> 2 missing braces around initializer >> 2 type defaults to * in declaration >> 1 argument '*' might be clobbered by '*' >> 1 assignment from incompatible pointer type >> 1 assignment makes integer from pointer without a cast >> 1 control reaches end of non-void function >> 1 missing initializer >> 1 package * does not exist >> 1 the use of `*' is dangerous >> 1 ~UNKNOWN~ >> >> >> Warnings with unrecognized types >> >> * ../../../src/solaris/native/java/lang/java_props_md.c:124: >> warning: (near initialization for 'sprops.os_version') >> >> ------------------------------------------------------------------------ >> Generated on Sun Jul 13 17:36:12 PDT 2008 From Kelly.Ohair at Sun.COM Mon Jul 14 10:52:09 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Mon, 14 Jul 2008 10:52:09 -0700 Subject: getting a handle on build warnings In-Reply-To: <487AA0EE.8070009@sun.com> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> <487AA0EE.8070009@sun.com> Message-ID: <487B9249.9050907@sun.com> FYI... I dug up my old wstats ksh script and ran it over a concatenation of the latest jdk7 build 30 logs for all 8 of builds done by Java Release Engineering (solaris-i586, solaris-x64, solaris-sparc, solaris-sparcv9, linux-i586, linux-x64, windows-i586, and windows-x64). Granted, these are OLD Linux systems with gcc 3.2, and lots of duplicates here. The problems with dealing with the C/C++ warnings is that the different compilers and different releases of the compilers create a bit of an unknown when trying to fix warnings. Fixing a warning from gcc4 might just trigger a new warning for some other reason from the Sun Studio compiler, can be frustrating. And using just a slightly newer or patched gcc or Sun Studio compiler might generate new warnings you haven't seen before. This has gotten better over time but continues to be an issue. A danger also lies in how a warning is fixed in native code that needs to work on all platforms and with different compilers, for example, adding a cast like '(long)' might shut up a warning, but could break Windows X64 where a long is 32bits not 64bits. People need to be very careful in the native code. At least with the javac warnings, fixing them is more concrete, and probably less risky ;^) I'm all in favor of fixing the warnings, just trying to make sure it's done safely. ;^) -kto ------------------------------------- Warning Message Counts: ---------------------- 15790 ld warnings (contains 'ld:') 6686 C warnings (contains '[.]c[":]') 1616 C Include file warnings (contains '[.]h[":]') 9700 C++ warnings (contains '[.]cpp[":]') 0 C++ Include file warnings (contains '[.]hpp[":]') 4432 Java warnings (contains '.java:' or 'Note:' ) 0 VM warnings (contains 'VM warning:' ) 600 Javadoc warnings (contains ': warning -') 250 Compiler driver warnings (contains cc: or CC: or 'cl :') 59 GNU make warnings (contains '.gmk:' or 'akefile:' or '(ignored)' or starts with 'gnumake') 276 Shell warnings (contains ': not found' or 'awk:') 187 Build warnings (contains WARNING:) 312 Font warnings (contains 'entry is missing') ----- 39908 Total of above warnings 29252 Messages that appear to be duplicates 18 Remaining errors not counted warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf does not exist /usr/ccs/bin/as: "/export2/BUILD_AREA/jdk7/hotspot/src/os_cpu/solaris_sparc/vm/solaris_sparc.s", line 86: warning: label in delay slot (follows CTI) warning: package com.sun.java.swing.plaf does not exist /usr/ccs/bin/as: "/export2/BUILD_AREA/jdk7/hotspot/src/os_cpu/solaris_sparc/vm/solaris_sparc.s", line 86: warning: label in delay slot (follows CTI) warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf.gtk does not exist warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf.gtk does not exist warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf.gtk does not exist warning: package com.sun.java.swing.plaf does not exist warning: package com.sun.java.swing.plaf.gtk does not exist Top 20 'src/' files mentioned in warning messages: ------------------------------------------------- 7972 src/share/native/com/sun/java/util/jar/pack/coding.cpp 2062 src/closed/share/classes/sun/jdbc/odbc/JdbcOdbc.c 1278 src/share/native/com/sun/java/util/jar/pack/unpack.cpp 1188 src/share/classes/sun/corba/Bridge.java 1096 src/solaris/native/sun/awt/gtk2_interface.c 888 src/closed/share/native/sun/java2d/cmm/kcms/evalth13.c 720 src/share/native/com/sun/java/util/jar/pack/bands.h 276 src/share/native/com/sun/java/util/jar/pack/unpack.h 276 src/build/tools/javazic/Gen.java 272 src/closed/share/native/sun/java2d/cmm/kcms/evalth14.c 252 src/share/classes/sun/nio/ch/FileChannelImpl.java 204 src/share/native/com/sun/java/util/jar/pack/bytes.h 204 src/share/classes/org/omg/CORBA/ORB.java 192 src/share/classes/com/sun/corba/se/impl/presentation/rmi/ExceptionHandlerImpl.java 170 src/share/native/sun/security/jgss/wrapper/GSSLibStub.c 140 src/share/native/com/sun/java/util/jar/pack/zip.cpp 136 src/share/native/sun/awt/medialib/mlib_ImageAffineEdge.c 128 src/share/native/sun/font/layout/LEGlyphStorage.h 114 src/share/classes/javax/sql/rowset/BaseRowSet.java 108 src/share/classes/javax/rmi/CORBA/GetORBPropertiesFileAction.java Jonathan Gibbons wrote: > I've written a program to analyze the warnings in a build log, > containing most of > the ideas I outlined earlier, and more. > > Right now, a "warning" is defined as a line containing the string "warning" > with false positives filtered out (e.g. a reference to a file called > warning.png) > > It can generate a report in plain text or html, containing any/all of > the following: > - comparison against a reference log, such as the log for an earlier > promoted build > - a summary of the warnings, grouped by the location contained in the > warning > - a summary of the warnings, grouped by the type of the warning > The summaries are given sorted both alphabetically and by frequency. > > I've attached a sample of the output. The input was the log for a build > on my > laptop. For the purposes of testing, the "reference" was the same log > truncated > to 25000 lines. > > The big surprise: One file is responsible for nearly 72% of all the > warnings in this > build: 1928 warnings out of a total of 2684! The file in question is > com/sun/java/util/jar/pack/coding.cpp > > The corollary is good news for everyone else; there are fewer warnings > through > the rest of the build than I expected, with only 14 files having 10 or > more warnings. > But, there are still over 150 files containing warnings :-( > > -- Jon > > > > Jonathan Gibbons wrote: >> Well, here's an unexpected initial result. >> >> I just ran a build of langtools+jdk on my ubuntu laptop. I got a >> whopping 2658 warnings!! [Those who volunteered to help get rid of >> all the warnings, don't all step back at once!] But surprisingly, >> after a quick "sort -u", only 625 of them are unique. So that means we >> get on average a 4x bang for the buck for each warning we fix :-) >> >> -- Jon >> >> >> On Jul 11, 2008, at 11:02 AM, Jonathan Gibbons wrote: >> >>> Depending on what lint options you use, deprecation warnings are >>> typically reported as a single "Note:" at the end of the compilation, >>> rather than as individual warning messages. Ideally, they should go >>> too, but for now, I'd settle for removing messages that show up as >>> diagnostics in IDEs, emacs, etc. >>> >>> For my part, I work mostly in the langtools area, and we are having >>> a general background effort to clean up the code there. The goal is >>> to clean the code and then use -Werror to treat any reappearance of >>> warnings as errors. >>> >>> -- Jon >>> >>> >>> On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: >>> >>>> Just curious, would part of this revision process entail removing >>>> calls to deprecated methods and replacing them with their documented >>>> replacement methods? >>>> >>>> There are many warnings about calls to deprecated methods in the >>>> OpenJDK code. >>>> >>>> >>>> Rob Ross, Lead Software Engineer >>>> E! Networks >>>> >>>> --------------------------------------------------- >>>> "Beware of he who would deny you access to information, for in his >>>> heart he dreams himself your master." -- Commissioner Pravin Lal >>>> >>>> >>>> >>>> On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: >>>> >>>>> >>>>> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >>>>> >>>>>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>>>>> >>>>>>> Yes, that technique can work well. But either way, the next step is >>>>>>> to try writing the code to analyze the build log, to see how far >>>>>>> the general >>>>>>> idea can be taken, and how much interest there is to track/fix >>>>>>> warnings. >>>>>>> >>>>>> Personally I'd like there to be no warnings at all, and would like >>>>>> to contribute work to get there >>>>>> >>>>> >>>>> Thank you. >>>>> >>>>> Getting rid of the actual warnings will require cooperation from >>>>> the teams who are >>>>> responsible for the various parts of the code. In some cases, there >>>>> may be resistance, >>>>> since stability is sometimes preferred over "no warnings". That >>>>> being said, what I'm >>>>> hoping to achieve with this discussion and any related effort is a >>>>> non-intrusive way >>>>> of gathering information about warnings, so that we have a better >>>>> understanding of >>>>> where the warnings are, in what areas of the code and in which >>>>> source files. That way, >>>>> we can work with the teams involved to see if there is interest in >>>>> reducing their >>>>> warning count in as safe a way as possible. Any assistance in >>>>> getting to that point >>>>> would be welcome. >>>>> >>>>> (Note that anyone contributing to OpenJDK must first sign the Sun >>>>> Contributor Agreement; >>>>> you can find details at http://sca.dev.java.net.) >>>>> >>>>> -- Jon >>>>> >>>>> >>>> >>> >> > > > ------------------------------------------------------------------------ > > > JDK Build Warnings > > ------------------------------------------------------------------------ > > * Comparison against reference results > o New warnings not found in reference files <#REF_DELTA_LOCNS> > * Warnings categorized by location > o Warning counts, sorted alphabetically by location > <#LOCN_COUNTS_ALPHA> > o Warning counts, sorted by frequency of location > <#LOCN_COUNTS_FREQ> > o Warning counts, sorted alphabetically by location directory > <#LOCN_DIR_COUNTS_ALPHA> > o Warning counts, sorted by frequency of location directory > <#LOCN_DIR_COUNTS_FREQ> > o Warning counts, sorted alphabetically by location directory > <#LOCN_DIR_COUNTS_ALPHA> > o Warning counts, sorted by frequency of location directory > <#LOCN_DIR_COUNTS_FREQ> > * Warnings categorized by type > o Warning counts, sorted alphabetically by type > <#TYPE_COUNTS_ALPHA> > o Warning counts, sorted by frequency of type <#TYPE_COUNTS_FREQ> > o Warnings with unrecognized types <#TYPE_UNKNOWN> > > ------------------------------------------------------------------------ > > > Log files analyzed > > * build.log > > total lines read 28834 > total warnings found 2648 > unique warnings found 617 > > > Reference files analyzed > > * build-25000.log > > total lines read 25000 > total warnings found 2618 > unique warnings found 590 > > > New warnings not found in reference files > > democlasses/demo/jvmti/hprof/src/hprof_init.c 1 > democlasses/demo/jvmti/waiters/src/Agent.cpp 1 > democlasses/demo/jvmti/waiters/src/waiters.cpp 2 > javax/swing/JColorChooser.java 1 > javax/swing/JComponent.java 4 > javax/swing/JInternalFrame.java 2 > javax/swing/JList.java 4 > javax/swing/JPopupMenu.java 1 > javax/swing/JTabbedPane.java 1 > javax/swing/JTable.java 5 > javax/swing/JTree.java 4 > javax/swing/text/JTextComponent.java 3 > ~NONE~ 1 > > > Warning counts, sorted alphabetically by location > > /usr/include/X11/IntrinsicP.h 1 > /usr/include/langinfo.h 1 > /usr/include/sys/cdefs.h 1 > /usr/include/sys/param.h 2 > back/ArrayTypeImpl.c 1 > back/inStream.c 4 > back/outStream.c 8 > back/stream.c 4 > bin/jexec.c 1 > bin/parse_manifest.c 1 > build/tools/compilefontconfig/CompileFontConfig.java 4 > build/tools/dtdbuilder/DTDParser.java 2 > build/tools/fontchecker/FontChecker.java 2 > build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java 3 > build/tools/javazic/Gen.java 23 > build/tools/javazic/GenDoc.java 2 > build/tools/javazic/Time.java 7 > com/sun/java/util/jar/pack/bands.cpp 2 > com/sun/java/util/jar/pack/coding.cpp 1928 > com/sun/java/util/jar/pack/main.cpp 1 > com/sun/java/util/jar/pack/unpack.cpp 32 > com/sun/java/util/jar/pack/unpack.h 24 > com/sun/java/util/jar/pack/utils.cpp 2 > com/sun/java/util/jar/pack/zip.cpp 1 > com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c 1 > com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c 5 > com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c 1 > common/check_code.c 9 > common/check_format.c 1 > demo/jvmti/hprof/hprof_init.c 1 > democlasses/demo/jvmti/hprof/src/hprof_init.c 1 > democlasses/demo/jvmti/waiters/src/Agent.cpp 1 > democlasses/demo/jvmti/waiters/src/waiters.cpp 2 > hpi/native_threads/src/sys_api_td.c 1 > instrument/JarFacade.c 1 > java/io/canonicalize_md.c 2 > java/io/io_util_md.h 8 > java/lang/Class.c 1 > java/lang/ClassLoader.c 2 > java/lang/fdlibm/include/fdlibm.h 1 > java/lang/fdlibm/src/e_jn.c 1 > java/lang/fdlibm/src/e_pow.c 1 > java/lang/fdlibm/src/e_sqrt.c 1 > java/lang/fdlibm/src/s_ceil.c 1 > java/lang/fdlibm/src/s_floor.c 1 > java/lang/fdlibm/src/s_log1p.c 1 > java/lang/java_props_md.c 3 > java/lang/reflect/Proxy.c 1 > java/net/Inet4AddressImpl.c 2 > java/net/Inet6AddressImpl.c 3 > java/net/NetworkInterface.c 1 > java/net/PlainDatagramSocketImpl.c 6 > java/net/linux_close.c 3 > java/net/net_util_md.c 2 > java/nio/Bits.c 8 > java/nio/MappedByteBuffer.c 1 > java/util/zip/zip_util.c 1 > java/util/zip/zlib-1.1.3/inftrees.c 3 > javavm/include/typedefs.h 8 > javax/swing/JColorChooser.java 1 > javax/swing/JComponent.java 4 > javax/swing/JInternalFrame.java 2 > javax/swing/JList.java 4 > javax/swing/JPopupMenu.java 1 > javax/swing/JTabbedPane.java 1 > javax/swing/JTable.java 5 > javax/swing/JTree.java 4 > javax/swing/text/JTextComponent.java 3 > sun/awt/awt_DrawingSurface.c 1 > sun/awt/awt_Font.c 1 > sun/awt/awt_GraphicsEnv.c 1 > sun/awt/awt_InputMethod.c 11 > sun/awt/awt_LoadLibrary.c 2 > sun/awt/awt_UNIXToolkit.c 1 > sun/awt/giflib/dgif_lib.c 16 > sun/awt/image/BufImgSurfaceData.c 1 > sun/awt/image/jpeg/imageioJPEG.c 19 > sun/awt/image/jpeg/jpegdecoder.c 1 > sun/awt/java2d/loops/ByteBinary1Bit.c 5 > sun/awt/java2d/loops/ByteBinary2Bit.c 5 > sun/awt/java2d/loops/ByteBinary4Bit.c 5 > sun/awt/java2d/loops/ByteGray.c 2 > sun/awt/java2d/loops/ByteIndexed.c 6 > sun/awt/java2d/loops/FourByteAbgr.c 2 > sun/awt/java2d/loops/FourByteAbgrPre.c 2 > sun/awt/java2d/loops/Index12Gray.c 2 > sun/awt/java2d/loops/Index8Gray.c 2 > sun/awt/java2d/loops/IntArgb.c 6 > sun/awt/java2d/loops/IntArgbBm.c 5 > sun/awt/java2d/loops/IntArgbPre.c 6 > sun/awt/java2d/loops/IntBgr.c 2 > sun/awt/java2d/loops/IntRgb.c 2 > sun/awt/java2d/loops/IntRgbx.c 2 > sun/awt/java2d/loops/ThreeByteBgr.c 2 > sun/awt/java2d/loops/TransformHelper.c 3 > sun/awt/java2d/loops/Ushort555Rgb.c 2 > sun/awt/java2d/loops/Ushort565Rgb.c 2 > sun/awt/java2d/loops/UshortGray.c 2 > sun/awt/java2d/loops/UshortIndexed.c 6 > sun/awt/java2d/pipe/Region.c 1 > sun/awt/libpng/pngread.c 1 > sun/awt/libpng/pngrtran.c 1 > sun/awt/libpng/pngrutil.c 1 > sun/awt/libpng/pngwrite.c 1 > sun/awt/medialib/mlib_ImageAffine.c 7 > sun/awt/medialib/mlib_ImageAffineEdge.c 34 > sun/awt/medialib/mlib_ImageColorTrue2Index.c 10 > sun/awt/medialib/mlib_ImageConvMxN.c 9 > sun/awt/medialib/mlib_ImageConv_16ext.c 4 > sun/awt/medialib/mlib_ImageConv_16nw.c 3 > sun/awt/medialib/mlib_ImageConv_32nw.c 2 > sun/awt/medialib/mlib_ImageConv_8ext.c 4 > sun/awt/medialib/mlib_ImageConv_8nw.c 3 > sun/awt/medialib/mlib_ImageConv_D64nw.c 2 > sun/awt/medialib/mlib_ImageConv_F32nw.c 1 > sun/awt/medialib/mlib_ImageConv_u16ext.c 4 > sun/awt/medialib/mlib_ImageConv_u16nw.c 3 > sun/awt/medialib/mlib_ImageCopy_Bit.c 4 > sun/awt/medialib/mlib_ImageCreate.c 2 > sun/awt/splashscreen/splashscreen_gfx_impl.c 2 > sun/font/DrawGlyphList.c 5 > sun/font/X11FontScaler.c 7 > sun/font/layout/LEGlyphStorage.h 32 > sun/font/layout/LEInsertionList.h 33 > sun/font/layout/MorphTables.cpp 1 > sun/java2d/cmm/lcms/LCMS.c 2 > sun/java2d/cmm/lcms/cmscgats.c 2 > sun/java2d/cmm/lcms/cmsio1.c 2 > sun/java2d/cmm/lcms/cmslut.c 4 > sun/java2d/cmm/lcms/cmswtpnt.c 1 > sun/java2d/x11/X11PMBlitLoops.c 2 > sun/java2d/x11/X11Renderer.c 45 > sun/java2d/x11/X11SurfaceData.c 10 > sun/java2d/x11/X11TextRenderer_md.c 1 > sun/net/spi/DefaultProxySelector.c 1 > sun/nio/ch/DatagramChannelImpl.c 1 > sun/nio/ch/InheritedChannel.c 1 > sun/nio/ch/Net.c 2 > sun/nio/ch/ServerSocketChannelImpl.c 1 > sun/nio/ch/SocketChannelImpl.c 1 > sun/rmi/rmic/Main.java 1 > sun/rmi/rmic/newrmic/Resources.java 1 > sun/security/jgss/wrapper/GSSLibStub.c 63 > sun/security/jgss/wrapper/NativeUtil.c 2 > sun/security/pkcs11/j2secmod_md.c 3 > sun/security/pkcs11/wrapper/p11_crypt.c 6 > sun/security/pkcs11/wrapper/p11_digest.c 1 > sun/security/pkcs11/wrapper/p11_keymgmt.c 1 > sun/security/pkcs11/wrapper/p11_md.c 1 > sun/security/pkcs11/wrapper/p11_sign.c 3 > sun/security/pkcs11/wrapper/p11_util.c 2 > sun/tools/serialver/SerialVer.java 1 > sun/tracing/dtrace/JVM.c 1 > sun/xawt/XToolkit.c 2 > sun/xawt/XWindow.c 4 > sun/xawt/awt_Desktop.c 1 > transport/socket/socket_md.c 3 > unpack.cpp 1 > ~NONE~ 5 > > > Warning counts, sorted by frequency of location > > 1928 com/sun/java/util/jar/pack/coding.cpp > 63 sun/security/jgss/wrapper/GSSLibStub.c > 45 sun/java2d/x11/X11Renderer.c > 34 sun/awt/medialib/mlib_ImageAffineEdge.c > 33 sun/font/layout/LEInsertionList.h > 32 com/sun/java/util/jar/pack/unpack.cpp > 32 sun/font/layout/LEGlyphStorage.h > 24 com/sun/java/util/jar/pack/unpack.h > 23 build/tools/javazic/Gen.java > 19 sun/awt/image/jpeg/imageioJPEG.c > 16 sun/awt/giflib/dgif_lib.c > 11 sun/awt/awt_InputMethod.c > 10 sun/awt/medialib/mlib_ImageColorTrue2Index.c > 10 sun/java2d/x11/X11SurfaceData.c > 9 common/check_code.c > 9 sun/awt/medialib/mlib_ImageConvMxN.c > 8 back/outStream.c > 8 java/io/io_util_md.h > 8 java/nio/Bits.c > 8 javavm/include/typedefs.h > 7 build/tools/javazic/Time.java > 7 sun/awt/medialib/mlib_ImageAffine.c > 7 sun/font/X11FontScaler.c > 6 java/net/PlainDatagramSocketImpl.c > 6 sun/awt/java2d/loops/ByteIndexed.c > 6 sun/awt/java2d/loops/IntArgb.c > 6 sun/awt/java2d/loops/IntArgbPre.c > 6 sun/awt/java2d/loops/UshortIndexed.c > 6 sun/security/pkcs11/wrapper/p11_crypt.c > 5 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c > 5 javax/swing/JTable.java > 5 sun/awt/java2d/loops/ByteBinary1Bit.c > 5 sun/awt/java2d/loops/ByteBinary2Bit.c > 5 sun/awt/java2d/loops/ByteBinary4Bit.c > 5 sun/awt/java2d/loops/IntArgbBm.c > 5 sun/font/DrawGlyphList.c > 5 ~NONE~ > 4 back/inStream.c > 4 back/stream.c > 4 build/tools/compilefontconfig/CompileFontConfig.java > 4 javax/swing/JComponent.java > 4 javax/swing/JList.java > 4 javax/swing/JTree.java > 4 sun/awt/medialib/mlib_ImageConv_16ext.c > 4 sun/awt/medialib/mlib_ImageConv_8ext.c > 4 sun/awt/medialib/mlib_ImageConv_u16ext.c > 4 sun/awt/medialib/mlib_ImageCopy_Bit.c > 4 sun/java2d/cmm/lcms/cmslut.c > 4 sun/xawt/XWindow.c > 3 build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java > 3 java/lang/java_props_md.c > 3 java/net/Inet6AddressImpl.c > 3 java/net/linux_close.c > 3 java/util/zip/zlib-1.1.3/inftrees.c > 3 javax/swing/text/JTextComponent.java > 3 sun/awt/java2d/loops/TransformHelper.c > 3 sun/awt/medialib/mlib_ImageConv_16nw.c > 3 sun/awt/medialib/mlib_ImageConv_8nw.c > 3 sun/awt/medialib/mlib_ImageConv_u16nw.c > 3 sun/security/pkcs11/j2secmod_md.c > 3 sun/security/pkcs11/wrapper/p11_sign.c > 3 transport/socket/socket_md.c > 2 /usr/include/sys/param.h > 2 build/tools/dtdbuilder/DTDParser.java > 2 build/tools/fontchecker/FontChecker.java > 2 build/tools/javazic/GenDoc.java > 2 com/sun/java/util/jar/pack/bands.cpp > 2 com/sun/java/util/jar/pack/utils.cpp > 2 democlasses/demo/jvmti/waiters/src/waiters.cpp > 2 java/io/canonicalize_md.c > 2 java/lang/ClassLoader.c > 2 java/net/Inet4AddressImpl.c > 2 java/net/net_util_md.c > 2 javax/swing/JInternalFrame.java > 2 sun/awt/awt_LoadLibrary.c > 2 sun/awt/java2d/loops/ByteGray.c > 2 sun/awt/java2d/loops/FourByteAbgr.c > 2 sun/awt/java2d/loops/FourByteAbgrPre.c > 2 sun/awt/java2d/loops/Index12Gray.c > 2 sun/awt/java2d/loops/Index8Gray.c > 2 sun/awt/java2d/loops/IntBgr.c > 2 sun/awt/java2d/loops/IntRgb.c > 2 sun/awt/java2d/loops/IntRgbx.c > 2 sun/awt/java2d/loops/ThreeByteBgr.c > 2 sun/awt/java2d/loops/Ushort555Rgb.c > 2 sun/awt/java2d/loops/Ushort565Rgb.c > 2 sun/awt/java2d/loops/UshortGray.c > 2 sun/awt/medialib/mlib_ImageConv_32nw.c > 2 sun/awt/medialib/mlib_ImageConv_D64nw.c > 2 sun/awt/medialib/mlib_ImageCreate.c > 2 sun/awt/splashscreen/splashscreen_gfx_impl.c > 2 sun/java2d/cmm/lcms/LCMS.c > 2 sun/java2d/cmm/lcms/cmscgats.c > 2 sun/java2d/cmm/lcms/cmsio1.c > 2 sun/java2d/x11/X11PMBlitLoops.c > 2 sun/nio/ch/Net.c > 2 sun/security/jgss/wrapper/NativeUtil.c > 2 sun/security/pkcs11/wrapper/p11_util.c > 2 sun/xawt/XToolkit.c > 1 /usr/include/X11/IntrinsicP.h > 1 /usr/include/langinfo.h > 1 /usr/include/sys/cdefs.h > 1 back/ArrayTypeImpl.c > 1 bin/jexec.c > 1 bin/parse_manifest.c > 1 com/sun/java/util/jar/pack/main.cpp > 1 com/sun/java/util/jar/pack/zip.cpp > 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c > 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c > 1 common/check_format.c > 1 demo/jvmti/hprof/hprof_init.c > 1 democlasses/demo/jvmti/hprof/src/hprof_init.c > 1 democlasses/demo/jvmti/waiters/src/Agent.cpp > 1 hpi/native_threads/src/sys_api_td.c > 1 instrument/JarFacade.c > 1 java/lang/Class.c > 1 java/lang/fdlibm/include/fdlibm.h > 1 java/lang/fdlibm/src/e_jn.c > 1 java/lang/fdlibm/src/e_pow.c > 1 java/lang/fdlibm/src/e_sqrt.c > 1 java/lang/fdlibm/src/s_ceil.c > 1 java/lang/fdlibm/src/s_floor.c > 1 java/lang/fdlibm/src/s_log1p.c > 1 java/lang/reflect/Proxy.c > 1 java/net/NetworkInterface.c > 1 java/nio/MappedByteBuffer.c > 1 java/util/zip/zip_util.c > 1 javax/swing/JColorChooser.java > 1 javax/swing/JPopupMenu.java > 1 javax/swing/JTabbedPane.java > 1 sun/awt/awt_DrawingSurface.c > 1 sun/awt/awt_Font.c > 1 sun/awt/awt_GraphicsEnv.c > 1 sun/awt/awt_UNIXToolkit.c > 1 sun/awt/image/BufImgSurfaceData.c > 1 sun/awt/image/jpeg/jpegdecoder.c > 1 sun/awt/java2d/pipe/Region.c > 1 sun/awt/libpng/pngread.c > 1 sun/awt/libpng/pngrtran.c > 1 sun/awt/libpng/pngrutil.c > 1 sun/awt/libpng/pngwrite.c > 1 sun/awt/medialib/mlib_ImageConv_F32nw.c > 1 sun/font/layout/MorphTables.cpp > 1 sun/java2d/cmm/lcms/cmswtpnt.c > 1 sun/java2d/x11/X11TextRenderer_md.c > 1 sun/net/spi/DefaultProxySelector.c > 1 sun/nio/ch/DatagramChannelImpl.c > 1 sun/nio/ch/InheritedChannel.c > 1 sun/nio/ch/ServerSocketChannelImpl.c > 1 sun/nio/ch/SocketChannelImpl.c > 1 sun/rmi/rmic/Main.java > 1 sun/rmi/rmic/newrmic/Resources.java > 1 sun/security/pkcs11/wrapper/p11_digest.c > 1 sun/security/pkcs11/wrapper/p11_keymgmt.c > 1 sun/security/pkcs11/wrapper/p11_md.c > 1 sun/tools/serialver/SerialVer.java > 1 sun/tracing/dtrace/JVM.c > 1 sun/xawt/awt_Desktop.c > 1 unpack.cpp > > > Warning counts, sorted alphabetically by location directory > > /usr/include 1 > /usr/include/X11 1 > /usr/include/sys 3 > back 17 > bin 2 > build/tools/compilefontconfig 4 > build/tools/dtdbuilder 2 > build/tools/fontchecker 2 > build/tools/generatebreakiteratordata 3 > build/tools/javazic 32 > com/sun/java/util/jar/pack 1990 > com/sun/media/sound 7 > common 10 > demo/jvmti/hprof 1 > democlasses/demo/jvmti/hprof/src 1 > democlasses/demo/jvmti/waiters/src 3 > hpi/native_threads/src 1 > instrument 1 > java/io 10 > java/lang 6 > java/lang/fdlibm/include 1 > java/lang/fdlibm/src 6 > java/lang/reflect 1 > java/net 17 > java/nio 9 > java/util/zip 1 > java/util/zip/zlib-1.1.3 3 > javavm/include 8 > javax/swing 22 > javax/swing/text 3 > sun/awt 17 > sun/awt/giflib 16 > sun/awt/image 1 > sun/awt/image/jpeg 20 > sun/awt/java2d/loops 71 > sun/awt/java2d/pipe 1 > sun/awt/libpng 4 > sun/awt/medialib 92 > sun/awt/splashscreen 2 > sun/font 12 > sun/font/layout 66 > sun/java2d/cmm/lcms 11 > sun/java2d/x11 58 > sun/net/spi 1 > sun/nio/ch 6 > sun/rmi/rmic 1 > sun/rmi/rmic/newrmic 1 > sun/security/jgss/wrapper 65 > sun/security/pkcs11 3 > sun/security/pkcs11/wrapper 14 > sun/tools/serialver 1 > sun/tracing/dtrace 1 > sun/xawt 7 > transport/socket 3 > unpack.cpp 1 > ~NONE~ 5 > > > Warning counts, sorted by frequency of location > > 1990 com/sun/java/util/jar/pack > 92 sun/awt/medialib > 71 sun/awt/java2d/loops > 66 sun/font/layout > 65 sun/security/jgss/wrapper > 58 sun/java2d/x11 > 32 build/tools/javazic > 22 javax/swing > 20 sun/awt/image/jpeg > 17 back > 17 java/net > 17 sun/awt > 16 sun/awt/giflib > 14 sun/security/pkcs11/wrapper > 12 sun/font > 11 sun/java2d/cmm/lcms > 10 common > 10 java/io > 9 java/nio > 8 javavm/include > 7 com/sun/media/sound > 7 sun/xawt > 6 java/lang > 6 java/lang/fdlibm/src > 6 sun/nio/ch > 5 ~NONE~ > 4 build/tools/compilefontconfig > 4 sun/awt/libpng > 3 /usr/include/sys > 3 build/tools/generatebreakiteratordata > 3 democlasses/demo/jvmti/waiters/src > 3 java/util/zip/zlib-1.1.3 > 3 javax/swing/text > 3 sun/security/pkcs11 > 3 transport/socket > 2 bin > 2 build/tools/dtdbuilder > 2 build/tools/fontchecker > 2 sun/awt/splashscreen > 1 /usr/include > 1 /usr/include/X11 > 1 demo/jvmti/hprof > 1 democlasses/demo/jvmti/hprof/src > 1 hpi/native_threads/src > 1 instrument > 1 java/lang/fdlibm/include > 1 java/lang/reflect > 1 java/util/zip > 1 sun/awt/image > 1 sun/awt/java2d/pipe > 1 sun/net/spi > 1 sun/rmi/rmic > 1 sun/rmi/rmic/newrmic > 1 sun/tools/serialver > 1 sun/tracing/dtrace > 1 unpack.cpp > > > Warning counts, sorted alphabetically by location extension > > .c 474 > .cpp 61 > .h 12 > .java 68 > ~NONE~ 2 > > > Warning counts, sorted by frequency of location extension > > 474 .c > 68 .java > 61 .cpp > 12 .h > 2 ~NONE~ > > > Warning counts, sorted alphabetically by type > > "*" redefined 13 > '*' may be used uninitialized in this function 126 > 'class *' has virtual functions but non-virtual destructor 65 > 'static' is not at beginning of declaration 2 > argument '*' might be clobbered by '*' 1 > assignment from incompatible pointer type 1 > assignment makes integer from pointer without a cast 1 > cast from pointer to integer of different size 22 > cast to java.lang.Object[] for a non-varargs call and to suppress this > warning 4 > cast to pointer from integer of different size 137 > comparison between pointer and integer 3 > comparison between signed and unsigned 106 > comparison is always false due to limited range of data type 2 > constant is too large for*type 18 > control reaches end of non-void function 1 > dereferencing type-punned pointer will break strict-aliasing rules 4 > enumeration value * not handled in switch 101 > format '*' expects type '*', but argument * has type '*' 12 > implicit declaration of function 3 > is Sun proprietary API and may be removed in a future release 67 > missing braces around initializer 2 > missing initializer 1 > missing initializer for member 1874 > non-varargs call of varargs method with inexact argument type for last > parameter 4 > package * does not exist 1 > passing * from incompatible pointer type 3 > pointer targets * differ in signedness 32 > return makes integer from pointer without a cast 5 > signed and unsigned type in conditional expression 16 > the use of `*' is dangerous 1 > this is the location of the previous definition 13 > type defaults to * in declaration 2 > variable '*' might be clobbered by '*' 4 > ~UNKNOWN~ 1 > > > Warning counts, sorted by frequency of type > > 1874 missing initializer for member > 137 cast to pointer from integer of different size > 126 '*' may be used uninitialized in this function > 106 comparison between signed and unsigned > 101 enumeration value * not handled in switch > 67 is Sun proprietary API and may be removed in a future release > 65 'class *' has virtual functions but non-virtual destructor > 32 pointer targets * differ in signedness > 22 cast from pointer to integer of different size > 18 constant is too large for*type > 16 signed and unsigned type in conditional expression > 13 "*" redefined > 13 this is the location of the previous definition > 12 format '*' expects type '*', but argument * has type '*' > 5 return makes integer from pointer without a cast > 4 cast to java.lang.Object[] for a non-varargs call and to suppress > this warning > 4 dereferencing type-punned pointer will break strict-aliasing rules > 4 non-varargs call of varargs method with inexact argument type for > last parameter > 4 variable '*' might be clobbered by '*' > 3 comparison between pointer and integer > 3 implicit declaration of function > 3 passing * from incompatible pointer type > 2 'static' is not at beginning of declaration > 2 comparison is always false due to limited range of data type > 2 missing braces around initializer > 2 type defaults to * in declaration > 1 argument '*' might be clobbered by '*' > 1 assignment from incompatible pointer type > 1 assignment makes integer from pointer without a cast > 1 control reaches end of non-void function > 1 missing initializer > 1 package * does not exist > 1 the use of `*' is dangerous > 1 ~UNKNOWN~ > > > Warnings with unrecognized types > > * ../../../src/solaris/native/java/lang/java_props_md.c:124: > warning: (near initialization for 'sprops.os_version') > > ------------------------------------------------------------------------ > Generated on Sun Jul 13 17:36:12 PDT 2008 From Jonathan.Gibbons at Sun.COM Mon Jul 14 11:49:32 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Mon, 14 Jul 2008 11:49:32 -0700 Subject: getting a handle on build warnings In-Reply-To: <487B8AF3.8060307@sun.com> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> <487AA0EE.8070009@sun.com> <487B88BD.5050004@sun.com> <487B8AF3.8060307@sun.com> Message-ID: <487B9FBC.5010602@sun.com> This was a fresh copy of OpenJDK tl repository from a couple of weeks back. I'll run the tool on the promoted build logs. -- Jon Kelly O'Hair wrote: > Jonathan, > > I started to look at these warnings and they just aren't in the latest > jdk7 nightly log files. > Swamy in the serviceability team had fixed all our serviceability > warnings at one point, so I'm wondering what jdk7 sources you are using. > > Or was this openjdk6? > > -kto > > Kelly O'Hair wrote: >> Was this a Windows X86 build? >> >> --- >> >> I'll file a bug on the serviceability related files, I thought we had >> fixed all our warnings. e.g. these: >> >> back/ArrayTypeImpl.c 1 >> back/inStream.c 4 >> back/outStream.c 8 >> back/stream.c 4 >> demo/jvmti/hprof/hprof_init.c 1 >> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >> instrument/JarFacade.c 1 >> transport/socket/socket_md.c 3 >> >> If we chip away at this, I think we can clean it up over time. >> >> -kto >> >> Jonathan Gibbons wrote: >>> I've written a program to analyze the warnings in a build log, >>> containing most of >>> the ideas I outlined earlier, and more. >>> >>> Right now, a "warning" is defined as a line containing the string >>> "warning" >>> with false positives filtered out (e.g. a reference to a file called >>> warning.png) >>> >>> It can generate a report in plain text or html, containing any/all >>> of the following: >>> - comparison against a reference log, such as the log for an earlier >>> promoted build >>> - a summary of the warnings, grouped by the location contained in >>> the warning >>> - a summary of the warnings, grouped by the type of the warning >>> The summaries are given sorted both alphabetically and by frequency. >>> >>> I've attached a sample of the output. The input was the log for a >>> build on my >>> laptop. For the purposes of testing, the "reference" was the same >>> log truncated >>> to 25000 lines. >>> >>> The big surprise: One file is responsible for nearly 72% of all the >>> warnings in this >>> build: 1928 warnings out of a total of 2684! The file in question is >>> com/sun/java/util/jar/pack/coding.cpp >>> >>> The corollary is good news for everyone else; there are fewer >>> warnings through >>> the rest of the build than I expected, with only 14 files having 10 >>> or more warnings. >>> But, there are still over 150 files containing warnings :-( >>> >>> -- Jon >>> >>> >>> >>> Jonathan Gibbons wrote: >>>> Well, here's an unexpected initial result. >>>> >>>> I just ran a build of langtools+jdk on my ubuntu laptop. I got a >>>> whopping 2658 warnings!! [Those who volunteered to help get rid of >>>> all the warnings, don't all step back at once!] But surprisingly, >>>> after a quick "sort -u", only 625 of them are unique. So that means >>>> we get on average a 4x bang for the buck for each warning we fix :-) >>>> >>>> -- Jon >>>> >>>> >>>> On Jul 11, 2008, at 11:02 AM, Jonathan Gibbons wrote: >>>> >>>>> Depending on what lint options you use, deprecation warnings are >>>>> typically reported as a single "Note:" at the end of the >>>>> compilation, rather than as individual warning messages. Ideally, >>>>> they should go too, but for now, I'd settle for removing messages >>>>> that show up as diagnostics in IDEs, emacs, etc. >>>>> >>>>> For my part, I work mostly in the langtools area, and we are >>>>> having a general background effort to clean up the code there. The >>>>> goal is to clean the code and then use -Werror to treat any >>>>> reappearance of warnings as errors. >>>>> >>>>> -- Jon >>>>> >>>>> >>>>> On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: >>>>> >>>>>> Just curious, would part of this revision process entail removing >>>>>> calls to deprecated methods and replacing them with their >>>>>> documented replacement methods? >>>>>> >>>>>> There are many warnings about calls to deprecated methods in the >>>>>> OpenJDK code. >>>>>> >>>>>> >>>>>> Rob Ross, Lead Software Engineer >>>>>> E! Networks >>>>>> >>>>>> --------------------------------------------------- >>>>>> "Beware of he who would deny you access to information, for in >>>>>> his heart he dreams himself your master." -- Commissioner Pravin Lal >>>>>> >>>>>> >>>>>> >>>>>> On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: >>>>>> >>>>>>> >>>>>>> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >>>>>>> >>>>>>>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>>>>>>> >>>>>>>>> Yes, that technique can work well. But either way, the next >>>>>>>>> step is >>>>>>>>> to try writing the code to analyze the build log, to see how >>>>>>>>> far the general >>>>>>>>> idea can be taken, and how much interest there is to track/fix >>>>>>>>> warnings. >>>>>>>>> >>>>>>>> Personally I'd like there to be no warnings at all, and would >>>>>>>> like to contribute work to get there >>>>>>>> >>>>>>> >>>>>>> Thank you. >>>>>>> >>>>>>> Getting rid of the actual warnings will require cooperation from >>>>>>> the teams who are >>>>>>> responsible for the various parts of the code. In some cases, >>>>>>> there may be resistance, >>>>>>> since stability is sometimes preferred over "no warnings". That >>>>>>> being said, what I'm >>>>>>> hoping to achieve with this discussion and any related effort is >>>>>>> a non-intrusive way >>>>>>> of gathering information about warnings, so that we have a >>>>>>> better understanding of >>>>>>> where the warnings are, in what areas of the code and in which >>>>>>> source files. That way, >>>>>>> we can work with the teams involved to see if there is interest >>>>>>> in reducing their >>>>>>> warning count in as safe a way as possible. Any assistance in >>>>>>> getting to that point >>>>>>> would be welcome. >>>>>>> >>>>>>> (Note that anyone contributing to OpenJDK must first sign the >>>>>>> Sun Contributor Agreement; >>>>>>> you can find details at http://sca.dev.java.net.) >>>>>>> >>>>>>> -- Jon >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >>> >>> JDK Build Warnings >>> >>> ------------------------------------------------------------------------ >>> >>> >>> * Comparison against reference results >>> o New warnings not found in reference files >>> <#REF_DELTA_LOCNS> >>> * Warnings categorized by location >>> o Warning counts, sorted alphabetically by location >>> <#LOCN_COUNTS_ALPHA> >>> o Warning counts, sorted by frequency of location >>> <#LOCN_COUNTS_FREQ> >>> o Warning counts, sorted alphabetically by location directory >>> <#LOCN_DIR_COUNTS_ALPHA> >>> o Warning counts, sorted by frequency of location directory >>> <#LOCN_DIR_COUNTS_FREQ> >>> o Warning counts, sorted alphabetically by location directory >>> <#LOCN_DIR_COUNTS_ALPHA> >>> o Warning counts, sorted by frequency of location directory >>> <#LOCN_DIR_COUNTS_FREQ> >>> * Warnings categorized by type >>> o Warning counts, sorted alphabetically by type >>> <#TYPE_COUNTS_ALPHA> >>> o Warning counts, sorted by frequency of type >>> <#TYPE_COUNTS_FREQ> >>> o Warnings with unrecognized types <#TYPE_UNKNOWN> >>> >>> ------------------------------------------------------------------------ >>> >>> >>> >>> Log files analyzed >>> >>> * build.log >>> >>> total lines read 28834 >>> total warnings found 2648 >>> unique warnings found 617 >>> >>> >>> Reference files analyzed >>> >>> * build-25000.log >>> >>> total lines read 25000 >>> total warnings found 2618 >>> unique warnings found 590 >>> >>> >>> New warnings not found in reference files >>> >>> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >>> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >>> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >>> javax/swing/JColorChooser.java 1 >>> javax/swing/JComponent.java 4 >>> javax/swing/JInternalFrame.java 2 >>> javax/swing/JList.java 4 >>> javax/swing/JPopupMenu.java 1 >>> javax/swing/JTabbedPane.java 1 >>> javax/swing/JTable.java 5 >>> javax/swing/JTree.java 4 >>> javax/swing/text/JTextComponent.java 3 >>> ~NONE~ 1 >>> >>> >>> Warning counts, sorted alphabetically by location >>> >>> /usr/include/X11/IntrinsicP.h 1 >>> /usr/include/langinfo.h 1 >>> /usr/include/sys/cdefs.h 1 >>> /usr/include/sys/param.h 2 >>> back/ArrayTypeImpl.c 1 >>> back/inStream.c 4 >>> back/outStream.c 8 >>> back/stream.c 4 >>> bin/jexec.c 1 >>> bin/parse_manifest.c 1 >>> build/tools/compilefontconfig/CompileFontConfig.java 4 >>> build/tools/dtdbuilder/DTDParser.java 2 >>> build/tools/fontchecker/FontChecker.java 2 >>> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >>> 3 >>> build/tools/javazic/Gen.java 23 >>> build/tools/javazic/GenDoc.java 2 >>> build/tools/javazic/Time.java 7 >>> com/sun/java/util/jar/pack/bands.cpp 2 >>> com/sun/java/util/jar/pack/coding.cpp 1928 >>> com/sun/java/util/jar/pack/main.cpp 1 >>> com/sun/java/util/jar/pack/unpack.cpp 32 >>> com/sun/java/util/jar/pack/unpack.h 24 >>> com/sun/java/util/jar/pack/utils.cpp 2 >>> com/sun/java/util/jar/pack/zip.cpp 1 >>> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c 1 >>> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c 5 >>> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c 1 >>> common/check_code.c 9 >>> common/check_format.c 1 >>> demo/jvmti/hprof/hprof_init.c 1 >>> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >>> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >>> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >>> hpi/native_threads/src/sys_api_td.c 1 >>> instrument/JarFacade.c 1 >>> java/io/canonicalize_md.c 2 >>> java/io/io_util_md.h 8 >>> java/lang/Class.c 1 >>> java/lang/ClassLoader.c 2 >>> java/lang/fdlibm/include/fdlibm.h 1 >>> java/lang/fdlibm/src/e_jn.c 1 >>> java/lang/fdlibm/src/e_pow.c 1 >>> java/lang/fdlibm/src/e_sqrt.c 1 >>> java/lang/fdlibm/src/s_ceil.c 1 >>> java/lang/fdlibm/src/s_floor.c 1 >>> java/lang/fdlibm/src/s_log1p.c 1 >>> java/lang/java_props_md.c 3 >>> java/lang/reflect/Proxy.c 1 >>> java/net/Inet4AddressImpl.c 2 >>> java/net/Inet6AddressImpl.c 3 >>> java/net/NetworkInterface.c 1 >>> java/net/PlainDatagramSocketImpl.c 6 >>> java/net/linux_close.c 3 >>> java/net/net_util_md.c 2 >>> java/nio/Bits.c 8 >>> java/nio/MappedByteBuffer.c 1 >>> java/util/zip/zip_util.c 1 >>> java/util/zip/zlib-1.1.3/inftrees.c 3 >>> javavm/include/typedefs.h 8 >>> javax/swing/JColorChooser.java 1 >>> javax/swing/JComponent.java 4 >>> javax/swing/JInternalFrame.java 2 >>> javax/swing/JList.java 4 >>> javax/swing/JPopupMenu.java 1 >>> javax/swing/JTabbedPane.java 1 >>> javax/swing/JTable.java 5 >>> javax/swing/JTree.java 4 >>> javax/swing/text/JTextComponent.java 3 >>> sun/awt/awt_DrawingSurface.c 1 >>> sun/awt/awt_Font.c 1 >>> sun/awt/awt_GraphicsEnv.c 1 >>> sun/awt/awt_InputMethod.c 11 >>> sun/awt/awt_LoadLibrary.c 2 >>> sun/awt/awt_UNIXToolkit.c 1 >>> sun/awt/giflib/dgif_lib.c 16 >>> sun/awt/image/BufImgSurfaceData.c 1 >>> sun/awt/image/jpeg/imageioJPEG.c 19 >>> sun/awt/image/jpeg/jpegdecoder.c 1 >>> sun/awt/java2d/loops/ByteBinary1Bit.c 5 >>> sun/awt/java2d/loops/ByteBinary2Bit.c 5 >>> sun/awt/java2d/loops/ByteBinary4Bit.c 5 >>> sun/awt/java2d/loops/ByteGray.c 2 >>> sun/awt/java2d/loops/ByteIndexed.c 6 >>> sun/awt/java2d/loops/FourByteAbgr.c 2 >>> sun/awt/java2d/loops/FourByteAbgrPre.c 2 >>> sun/awt/java2d/loops/Index12Gray.c 2 >>> sun/awt/java2d/loops/Index8Gray.c 2 >>> sun/awt/java2d/loops/IntArgb.c 6 >>> sun/awt/java2d/loops/IntArgbBm.c 5 >>> sun/awt/java2d/loops/IntArgbPre.c 6 >>> sun/awt/java2d/loops/IntBgr.c 2 >>> sun/awt/java2d/loops/IntRgb.c 2 >>> sun/awt/java2d/loops/IntRgbx.c 2 >>> sun/awt/java2d/loops/ThreeByteBgr.c 2 >>> sun/awt/java2d/loops/TransformHelper.c 3 >>> sun/awt/java2d/loops/Ushort555Rgb.c 2 >>> sun/awt/java2d/loops/Ushort565Rgb.c 2 >>> sun/awt/java2d/loops/UshortGray.c 2 >>> sun/awt/java2d/loops/UshortIndexed.c 6 >>> sun/awt/java2d/pipe/Region.c 1 >>> sun/awt/libpng/pngread.c 1 >>> sun/awt/libpng/pngrtran.c 1 >>> sun/awt/libpng/pngrutil.c 1 >>> sun/awt/libpng/pngwrite.c 1 >>> sun/awt/medialib/mlib_ImageAffine.c 7 >>> sun/awt/medialib/mlib_ImageAffineEdge.c 34 >>> sun/awt/medialib/mlib_ImageColorTrue2Index.c 10 >>> sun/awt/medialib/mlib_ImageConvMxN.c 9 >>> sun/awt/medialib/mlib_ImageConv_16ext.c 4 >>> sun/awt/medialib/mlib_ImageConv_16nw.c 3 >>> sun/awt/medialib/mlib_ImageConv_32nw.c 2 >>> sun/awt/medialib/mlib_ImageConv_8ext.c 4 >>> sun/awt/medialib/mlib_ImageConv_8nw.c 3 >>> sun/awt/medialib/mlib_ImageConv_D64nw.c 2 >>> sun/awt/medialib/mlib_ImageConv_F32nw.c 1 >>> sun/awt/medialib/mlib_ImageConv_u16ext.c 4 >>> sun/awt/medialib/mlib_ImageConv_u16nw.c 3 >>> sun/awt/medialib/mlib_ImageCopy_Bit.c 4 >>> sun/awt/medialib/mlib_ImageCreate.c 2 >>> sun/awt/splashscreen/splashscreen_gfx_impl.c 2 >>> sun/font/DrawGlyphList.c 5 >>> sun/font/X11FontScaler.c 7 >>> sun/font/layout/LEGlyphStorage.h 32 >>> sun/font/layout/LEInsertionList.h 33 >>> sun/font/layout/MorphTables.cpp 1 >>> sun/java2d/cmm/lcms/LCMS.c 2 >>> sun/java2d/cmm/lcms/cmscgats.c 2 >>> sun/java2d/cmm/lcms/cmsio1.c 2 >>> sun/java2d/cmm/lcms/cmslut.c 4 >>> sun/java2d/cmm/lcms/cmswtpnt.c 1 >>> sun/java2d/x11/X11PMBlitLoops.c 2 >>> sun/java2d/x11/X11Renderer.c 45 >>> sun/java2d/x11/X11SurfaceData.c 10 >>> sun/java2d/x11/X11TextRenderer_md.c 1 >>> sun/net/spi/DefaultProxySelector.c 1 >>> sun/nio/ch/DatagramChannelImpl.c 1 >>> sun/nio/ch/InheritedChannel.c 1 >>> sun/nio/ch/Net.c 2 >>> sun/nio/ch/ServerSocketChannelImpl.c 1 >>> sun/nio/ch/SocketChannelImpl.c 1 >>> sun/rmi/rmic/Main.java 1 >>> sun/rmi/rmic/newrmic/Resources.java 1 >>> sun/security/jgss/wrapper/GSSLibStub.c 63 >>> sun/security/jgss/wrapper/NativeUtil.c 2 >>> sun/security/pkcs11/j2secmod_md.c 3 >>> sun/security/pkcs11/wrapper/p11_crypt.c 6 >>> sun/security/pkcs11/wrapper/p11_digest.c 1 >>> sun/security/pkcs11/wrapper/p11_keymgmt.c 1 >>> sun/security/pkcs11/wrapper/p11_md.c 1 >>> sun/security/pkcs11/wrapper/p11_sign.c 3 >>> sun/security/pkcs11/wrapper/p11_util.c 2 >>> sun/tools/serialver/SerialVer.java 1 >>> sun/tracing/dtrace/JVM.c 1 >>> sun/xawt/XToolkit.c 2 >>> sun/xawt/XWindow.c 4 >>> sun/xawt/awt_Desktop.c 1 >>> transport/socket/socket_md.c 3 >>> unpack.cpp 1 >>> ~NONE~ 5 >>> >>> >>> Warning counts, sorted by frequency of location >>> >>> 1928 com/sun/java/util/jar/pack/coding.cpp >>> 63 sun/security/jgss/wrapper/GSSLibStub.c >>> 45 sun/java2d/x11/X11Renderer.c >>> 34 sun/awt/medialib/mlib_ImageAffineEdge.c >>> 33 sun/font/layout/LEInsertionList.h >>> 32 com/sun/java/util/jar/pack/unpack.cpp >>> 32 sun/font/layout/LEGlyphStorage.h >>> 24 com/sun/java/util/jar/pack/unpack.h >>> 23 build/tools/javazic/Gen.java >>> 19 sun/awt/image/jpeg/imageioJPEG.c >>> 16 sun/awt/giflib/dgif_lib.c >>> 11 sun/awt/awt_InputMethod.c >>> 10 sun/awt/medialib/mlib_ImageColorTrue2Index.c >>> 10 sun/java2d/x11/X11SurfaceData.c >>> 9 common/check_code.c >>> 9 sun/awt/medialib/mlib_ImageConvMxN.c >>> 8 back/outStream.c >>> 8 java/io/io_util_md.h >>> 8 java/nio/Bits.c >>> 8 javavm/include/typedefs.h >>> 7 build/tools/javazic/Time.java >>> 7 sun/awt/medialib/mlib_ImageAffine.c >>> 7 sun/font/X11FontScaler.c >>> 6 java/net/PlainDatagramSocketImpl.c >>> 6 sun/awt/java2d/loops/ByteIndexed.c >>> 6 sun/awt/java2d/loops/IntArgb.c >>> 6 sun/awt/java2d/loops/IntArgbPre.c >>> 6 sun/awt/java2d/loops/UshortIndexed.c >>> 6 sun/security/pkcs11/wrapper/p11_crypt.c >>> 5 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c >>> 5 javax/swing/JTable.java >>> 5 sun/awt/java2d/loops/ByteBinary1Bit.c >>> 5 sun/awt/java2d/loops/ByteBinary2Bit.c >>> 5 sun/awt/java2d/loops/ByteBinary4Bit.c >>> 5 sun/awt/java2d/loops/IntArgbBm.c >>> 5 sun/font/DrawGlyphList.c >>> 5 ~NONE~ >>> 4 back/inStream.c >>> 4 back/stream.c >>> 4 build/tools/compilefontconfig/CompileFontConfig.java >>> 4 javax/swing/JComponent.java >>> 4 javax/swing/JList.java >>> 4 javax/swing/JTree.java >>> 4 sun/awt/medialib/mlib_ImageConv_16ext.c >>> 4 sun/awt/medialib/mlib_ImageConv_8ext.c >>> 4 sun/awt/medialib/mlib_ImageConv_u16ext.c >>> 4 sun/awt/medialib/mlib_ImageCopy_Bit.c >>> 4 sun/java2d/cmm/lcms/cmslut.c >>> 4 sun/xawt/XWindow.c >>> 3 >>> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >>> >>> 3 java/lang/java_props_md.c >>> 3 java/net/Inet6AddressImpl.c >>> 3 java/net/linux_close.c >>> 3 java/util/zip/zlib-1.1.3/inftrees.c >>> 3 javax/swing/text/JTextComponent.java >>> 3 sun/awt/java2d/loops/TransformHelper.c >>> 3 sun/awt/medialib/mlib_ImageConv_16nw.c >>> 3 sun/awt/medialib/mlib_ImageConv_8nw.c >>> 3 sun/awt/medialib/mlib_ImageConv_u16nw.c >>> 3 sun/security/pkcs11/j2secmod_md.c >>> 3 sun/security/pkcs11/wrapper/p11_sign.c >>> 3 transport/socket/socket_md.c >>> 2 /usr/include/sys/param.h >>> 2 build/tools/dtdbuilder/DTDParser.java >>> 2 build/tools/fontchecker/FontChecker.java >>> 2 build/tools/javazic/GenDoc.java >>> 2 com/sun/java/util/jar/pack/bands.cpp >>> 2 com/sun/java/util/jar/pack/utils.cpp >>> 2 democlasses/demo/jvmti/waiters/src/waiters.cpp >>> 2 java/io/canonicalize_md.c >>> 2 java/lang/ClassLoader.c >>> 2 java/net/Inet4AddressImpl.c >>> 2 java/net/net_util_md.c >>> 2 javax/swing/JInternalFrame.java >>> 2 sun/awt/awt_LoadLibrary.c >>> 2 sun/awt/java2d/loops/ByteGray.c >>> 2 sun/awt/java2d/loops/FourByteAbgr.c >>> 2 sun/awt/java2d/loops/FourByteAbgrPre.c >>> 2 sun/awt/java2d/loops/Index12Gray.c >>> 2 sun/awt/java2d/loops/Index8Gray.c >>> 2 sun/awt/java2d/loops/IntBgr.c >>> 2 sun/awt/java2d/loops/IntRgb.c >>> 2 sun/awt/java2d/loops/IntRgbx.c >>> 2 sun/awt/java2d/loops/ThreeByteBgr.c >>> 2 sun/awt/java2d/loops/Ushort555Rgb.c >>> 2 sun/awt/java2d/loops/Ushort565Rgb.c >>> 2 sun/awt/java2d/loops/UshortGray.c >>> 2 sun/awt/medialib/mlib_ImageConv_32nw.c >>> 2 sun/awt/medialib/mlib_ImageConv_D64nw.c >>> 2 sun/awt/medialib/mlib_ImageCreate.c >>> 2 sun/awt/splashscreen/splashscreen_gfx_impl.c >>> 2 sun/java2d/cmm/lcms/LCMS.c >>> 2 sun/java2d/cmm/lcms/cmscgats.c >>> 2 sun/java2d/cmm/lcms/cmsio1.c >>> 2 sun/java2d/x11/X11PMBlitLoops.c >>> 2 sun/nio/ch/Net.c >>> 2 sun/security/jgss/wrapper/NativeUtil.c >>> 2 sun/security/pkcs11/wrapper/p11_util.c >>> 2 sun/xawt/XToolkit.c >>> 1 /usr/include/X11/IntrinsicP.h >>> 1 /usr/include/langinfo.h >>> 1 /usr/include/sys/cdefs.h >>> 1 back/ArrayTypeImpl.c >>> 1 bin/jexec.c >>> 1 bin/parse_manifest.c >>> 1 com/sun/java/util/jar/pack/main.cpp >>> 1 com/sun/java/util/jar/pack/zip.cpp >>> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c >>> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c >>> 1 common/check_format.c >>> 1 demo/jvmti/hprof/hprof_init.c >>> 1 democlasses/demo/jvmti/hprof/src/hprof_init.c >>> 1 democlasses/demo/jvmti/waiters/src/Agent.cpp >>> 1 hpi/native_threads/src/sys_api_td.c >>> 1 instrument/JarFacade.c >>> 1 java/lang/Class.c >>> 1 java/lang/fdlibm/include/fdlibm.h >>> 1 java/lang/fdlibm/src/e_jn.c >>> 1 java/lang/fdlibm/src/e_pow.c >>> 1 java/lang/fdlibm/src/e_sqrt.c >>> 1 java/lang/fdlibm/src/s_ceil.c >>> 1 java/lang/fdlibm/src/s_floor.c >>> 1 java/lang/fdlibm/src/s_log1p.c >>> 1 java/lang/reflect/Proxy.c >>> 1 java/net/NetworkInterface.c >>> 1 java/nio/MappedByteBuffer.c >>> 1 java/util/zip/zip_util.c >>> 1 javax/swing/JColorChooser.java >>> 1 javax/swing/JPopupMenu.java >>> 1 javax/swing/JTabbedPane.java >>> 1 sun/awt/awt_DrawingSurface.c >>> 1 sun/awt/awt_Font.c >>> 1 sun/awt/awt_GraphicsEnv.c >>> 1 sun/awt/awt_UNIXToolkit.c >>> 1 sun/awt/image/BufImgSurfaceData.c >>> 1 sun/awt/image/jpeg/jpegdecoder.c >>> 1 sun/awt/java2d/pipe/Region.c >>> 1 sun/awt/libpng/pngread.c >>> 1 sun/awt/libpng/pngrtran.c >>> 1 sun/awt/libpng/pngrutil.c >>> 1 sun/awt/libpng/pngwrite.c >>> 1 sun/awt/medialib/mlib_ImageConv_F32nw.c >>> 1 sun/font/layout/MorphTables.cpp >>> 1 sun/java2d/cmm/lcms/cmswtpnt.c >>> 1 sun/java2d/x11/X11TextRenderer_md.c >>> 1 sun/net/spi/DefaultProxySelector.c >>> 1 sun/nio/ch/DatagramChannelImpl.c >>> 1 sun/nio/ch/InheritedChannel.c >>> 1 sun/nio/ch/ServerSocketChannelImpl.c >>> 1 sun/nio/ch/SocketChannelImpl.c >>> 1 sun/rmi/rmic/Main.java >>> 1 sun/rmi/rmic/newrmic/Resources.java >>> 1 sun/security/pkcs11/wrapper/p11_digest.c >>> 1 sun/security/pkcs11/wrapper/p11_keymgmt.c >>> 1 sun/security/pkcs11/wrapper/p11_md.c >>> 1 sun/tools/serialver/SerialVer.java >>> 1 sun/tracing/dtrace/JVM.c >>> 1 sun/xawt/awt_Desktop.c >>> 1 unpack.cpp >>> >>> >>> Warning counts, sorted alphabetically by location directory >>> >>> /usr/include 1 >>> /usr/include/X11 1 >>> /usr/include/sys 3 >>> back 17 >>> bin 2 >>> build/tools/compilefontconfig 4 >>> build/tools/dtdbuilder 2 >>> build/tools/fontchecker 2 >>> build/tools/generatebreakiteratordata 3 >>> build/tools/javazic 32 >>> com/sun/java/util/jar/pack 1990 >>> com/sun/media/sound 7 >>> common 10 >>> demo/jvmti/hprof 1 >>> democlasses/demo/jvmti/hprof/src 1 >>> democlasses/demo/jvmti/waiters/src 3 >>> hpi/native_threads/src 1 >>> instrument 1 >>> java/io 10 >>> java/lang 6 >>> java/lang/fdlibm/include 1 >>> java/lang/fdlibm/src 6 >>> java/lang/reflect 1 >>> java/net 17 >>> java/nio 9 >>> java/util/zip 1 >>> java/util/zip/zlib-1.1.3 3 >>> javavm/include 8 >>> javax/swing 22 >>> javax/swing/text 3 >>> sun/awt 17 >>> sun/awt/giflib 16 >>> sun/awt/image 1 >>> sun/awt/image/jpeg 20 >>> sun/awt/java2d/loops 71 >>> sun/awt/java2d/pipe 1 >>> sun/awt/libpng 4 >>> sun/awt/medialib 92 >>> sun/awt/splashscreen 2 >>> sun/font 12 >>> sun/font/layout 66 >>> sun/java2d/cmm/lcms 11 >>> sun/java2d/x11 58 >>> sun/net/spi 1 >>> sun/nio/ch 6 >>> sun/rmi/rmic 1 >>> sun/rmi/rmic/newrmic 1 >>> sun/security/jgss/wrapper 65 >>> sun/security/pkcs11 3 >>> sun/security/pkcs11/wrapper 14 >>> sun/tools/serialver 1 >>> sun/tracing/dtrace 1 >>> sun/xawt 7 >>> transport/socket 3 >>> unpack.cpp 1 >>> ~NONE~ 5 >>> >>> >>> Warning counts, sorted by frequency of location >>> >>> 1990 com/sun/java/util/jar/pack >>> 92 sun/awt/medialib >>> 71 sun/awt/java2d/loops >>> 66 sun/font/layout >>> 65 sun/security/jgss/wrapper >>> 58 sun/java2d/x11 >>> 32 build/tools/javazic >>> 22 javax/swing >>> 20 sun/awt/image/jpeg >>> 17 back >>> 17 java/net >>> 17 sun/awt >>> 16 sun/awt/giflib >>> 14 sun/security/pkcs11/wrapper >>> 12 sun/font >>> 11 sun/java2d/cmm/lcms >>> 10 common >>> 10 java/io >>> 9 java/nio >>> 8 javavm/include >>> 7 com/sun/media/sound >>> 7 sun/xawt >>> 6 java/lang >>> 6 java/lang/fdlibm/src >>> 6 sun/nio/ch >>> 5 ~NONE~ >>> 4 build/tools/compilefontconfig >>> 4 sun/awt/libpng >>> 3 /usr/include/sys >>> 3 build/tools/generatebreakiteratordata >>> 3 democlasses/demo/jvmti/waiters/src >>> 3 java/util/zip/zlib-1.1.3 >>> 3 javax/swing/text >>> 3 sun/security/pkcs11 >>> 3 transport/socket >>> 2 bin >>> 2 build/tools/dtdbuilder >>> 2 build/tools/fontchecker >>> 2 sun/awt/splashscreen >>> 1 /usr/include >>> 1 /usr/include/X11 >>> 1 demo/jvmti/hprof >>> 1 democlasses/demo/jvmti/hprof/src >>> 1 hpi/native_threads/src >>> 1 instrument >>> 1 java/lang/fdlibm/include >>> 1 java/lang/reflect >>> 1 java/util/zip >>> 1 sun/awt/image >>> 1 sun/awt/java2d/pipe >>> 1 sun/net/spi >>> 1 sun/rmi/rmic >>> 1 sun/rmi/rmic/newrmic >>> 1 sun/tools/serialver >>> 1 sun/tracing/dtrace >>> 1 unpack.cpp >>> >>> >>> Warning counts, sorted alphabetically by location extension >>> >>> .c 474 >>> .cpp 61 >>> .h 12 >>> .java 68 >>> ~NONE~ 2 >>> >>> >>> Warning counts, sorted by frequency of location extension >>> >>> 474 .c >>> 68 .java >>> 61 .cpp >>> 12 .h >>> 2 ~NONE~ >>> >>> >>> Warning counts, sorted alphabetically by type >>> >>> "*" redefined 13 >>> '*' may be used uninitialized in this function 126 >>> 'class *' has virtual functions but non-virtual destructor 65 >>> 'static' is not at beginning of declaration 2 >>> argument '*' might be clobbered by '*' 1 >>> assignment from incompatible pointer type 1 >>> assignment makes integer from pointer without a cast 1 >>> cast from pointer to integer of different size 22 >>> cast to java.lang.Object[] for a non-varargs call and to suppress >>> this warning 4 >>> cast to pointer from integer of different size 137 >>> comparison between pointer and integer 3 >>> comparison between signed and unsigned 106 >>> comparison is always false due to limited range of data type 2 >>> constant is too large for*type 18 >>> control reaches end of non-void function 1 >>> dereferencing type-punned pointer will break strict-aliasing >>> rules 4 >>> enumeration value * not handled in switch 101 >>> format '*' expects type '*', but argument * has type '*' 12 >>> implicit declaration of function 3 >>> is Sun proprietary API and may be removed in a future release 67 >>> missing braces around initializer 2 >>> missing initializer 1 >>> missing initializer for member 1874 >>> non-varargs call of varargs method with inexact argument type for >>> last parameter 4 >>> package * does not exist 1 >>> passing * from incompatible pointer type 3 >>> pointer targets * differ in signedness 32 >>> return makes integer from pointer without a cast 5 >>> signed and unsigned type in conditional expression 16 >>> the use of `*' is dangerous 1 >>> this is the location of the previous definition 13 >>> type defaults to * in declaration 2 >>> variable '*' might be clobbered by '*' 4 >>> ~UNKNOWN~ 1 >>> >>> >>> Warning counts, sorted by frequency of type >>> >>> 1874 missing initializer for member >>> 137 cast to pointer from integer of different size >>> 126 '*' may be used uninitialized in this function >>> 106 comparison between signed and unsigned >>> 101 enumeration value * not handled in switch >>> 67 is Sun proprietary API and may be removed in a future release >>> 65 'class *' has virtual functions but non-virtual destructor >>> 32 pointer targets * differ in signedness >>> 22 cast from pointer to integer of different size >>> 18 constant is too large for*type >>> 16 signed and unsigned type in conditional expression >>> 13 "*" redefined >>> 13 this is the location of the previous definition >>> 12 format '*' expects type '*', but argument * has type '*' >>> 5 return makes integer from pointer without a cast >>> 4 cast to java.lang.Object[] for a non-varargs call and to >>> suppress this warning >>> 4 dereferencing type-punned pointer will break strict-aliasing >>> rules >>> 4 non-varargs call of varargs method with inexact argument type >>> for last parameter >>> 4 variable '*' might be clobbered by '*' >>> 3 comparison between pointer and integer >>> 3 implicit declaration of function >>> 3 passing * from incompatible pointer type >>> 2 'static' is not at beginning of declaration >>> 2 comparison is always false due to limited range of data type >>> 2 missing braces around initializer >>> 2 type defaults to * in declaration >>> 1 argument '*' might be clobbered by '*' >>> 1 assignment from incompatible pointer type >>> 1 assignment makes integer from pointer without a cast >>> 1 control reaches end of non-void function >>> 1 missing initializer >>> 1 package * does not exist >>> 1 the use of `*' is dangerous >>> 1 ~UNKNOWN~ >>> >>> >>> Warnings with unrecognized types >>> >>> * ../../../src/solaris/native/java/lang/java_props_md.c:124: >>> warning: (near initialization for 'sprops.os_version') >>> >>> ------------------------------------------------------------------------ >>> >>> Generated on Sun Jul 13 17:36:12 PDT 2008 From Jonathan.Gibbons at Sun.COM Mon Jul 14 11:51:32 2008 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Mon, 14 Jul 2008 11:51:32 -0700 Subject: getting a handle on build warnings In-Reply-To: <487B9249.9050907@sun.com> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> <487AA0EE.8070009@sun.com> <487B9249.9050907@sun.com> Message-ID: <487BA034.8050602@sun.com> I agree that fixing warnings is not necessarily an easy task. My goal in writing the tool was to make it easy for people to scan the set of warnings, and say, "wow, that one looks really serious, I'd better fix that!" -- Jon Kelly O'Hair wrote: > > FYI... > > I dug up my old wstats ksh script and ran it over a concatenation of the > latest jdk7 build 30 logs for all 8 of builds done by Java Release > Engineering > (solaris-i586, solaris-x64, solaris-sparc, solaris-sparcv9, linux-i586, > linux-x64, windows-i586, and windows-x64). > Granted, these are OLD Linux systems with gcc 3.2, and lots of duplicates > here. > > The problems with dealing with the C/C++ warnings is that the > different compilers > and different releases of the compilers create a bit of an unknown > when trying > to fix warnings. Fixing a warning from gcc4 might just trigger a new > warning > for some other reason from the Sun Studio compiler, can be frustrating. > And using just a slightly newer or patched gcc or Sun Studio compiler > might > generate new warnings you haven't seen before. > This has gotten better over time but continues to be an issue. > > A danger also lies in how a warning is fixed in native code that needs > to work on > all platforms and with different compilers, for example, adding a cast > like > '(long)' might shut up a warning, but could break Windows X64 where a > long > is 32bits not 64bits. People need to be very careful in the native code. > > At least with the javac warnings, fixing them is more concrete, and > probably > less risky ;^) > > I'm all in favor of fixing the warnings, just trying to make sure it's > done > safely. ;^) > > -kto > > ------------------------------------- > > > Warning Message Counts: > ---------------------- > 15790 ld warnings (contains 'ld:') > 6686 C warnings (contains '[.]c[":]') > 1616 C Include file warnings (contains '[.]h[":]') > 9700 C++ warnings (contains '[.]cpp[":]') > 0 C++ Include file warnings (contains '[.]hpp[":]') > 4432 Java warnings (contains '.java:' or 'Note:' ) > 0 VM warnings (contains 'VM warning:' ) > 600 Javadoc warnings (contains ': warning -') > 250 Compiler driver warnings (contains cc: or CC: or 'cl :') > 59 GNU make warnings (contains '.gmk:' or 'akefile:' or '(ignored)' > or starts with 'gnumake') > 276 Shell warnings (contains ': not found' or 'awk:') > 187 Build warnings (contains WARNING:) > 312 Font warnings (contains 'entry is missing') > ----- > 39908 Total of above warnings > > 29252 Messages that appear to be duplicates > 18 Remaining errors not counted > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf does not exist > /usr/ccs/bin/as: > "/export2/BUILD_AREA/jdk7/hotspot/src/os_cpu/solaris_sparc/vm/solaris_sparc.s", > line 86: warning: label in delay slot (follows CTI) > warning: package com.sun.java.swing.plaf does not exist > /usr/ccs/bin/as: > "/export2/BUILD_AREA/jdk7/hotspot/src/os_cpu/solaris_sparc/vm/solaris_sparc.s", > line 86: warning: label in delay slot (follows CTI) > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf.gtk does not exist > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf.gtk does not exist > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf.gtk does not exist > warning: package com.sun.java.swing.plaf does not exist > warning: package com.sun.java.swing.plaf.gtk does not exist > > Top 20 'src/' files mentioned in warning messages: > ------------------------------------------------- > 7972 src/share/native/com/sun/java/util/jar/pack/coding.cpp > 2062 src/closed/share/classes/sun/jdbc/odbc/JdbcOdbc.c > 1278 src/share/native/com/sun/java/util/jar/pack/unpack.cpp > 1188 src/share/classes/sun/corba/Bridge.java > 1096 src/solaris/native/sun/awt/gtk2_interface.c > 888 src/closed/share/native/sun/java2d/cmm/kcms/evalth13.c > 720 src/share/native/com/sun/java/util/jar/pack/bands.h > 276 src/share/native/com/sun/java/util/jar/pack/unpack.h > 276 src/build/tools/javazic/Gen.java > 272 src/closed/share/native/sun/java2d/cmm/kcms/evalth14.c > 252 src/share/classes/sun/nio/ch/FileChannelImpl.java > 204 src/share/native/com/sun/java/util/jar/pack/bytes.h > 204 src/share/classes/org/omg/CORBA/ORB.java > 192 > src/share/classes/com/sun/corba/se/impl/presentation/rmi/ExceptionHandlerImpl.java > > 170 src/share/native/sun/security/jgss/wrapper/GSSLibStub.c > 140 src/share/native/com/sun/java/util/jar/pack/zip.cpp > 136 src/share/native/sun/awt/medialib/mlib_ImageAffineEdge.c > 128 src/share/native/sun/font/layout/LEGlyphStorage.h > 114 src/share/classes/javax/sql/rowset/BaseRowSet.java > 108 src/share/classes/javax/rmi/CORBA/GetORBPropertiesFileAction.java > > > > Jonathan Gibbons wrote: >> I've written a program to analyze the warnings in a build log, >> containing most of >> the ideas I outlined earlier, and more. >> >> Right now, a "warning" is defined as a line containing the string >> "warning" >> with false positives filtered out (e.g. a reference to a file called >> warning.png) >> >> It can generate a report in plain text or html, containing any/all of >> the following: >> - comparison against a reference log, such as the log for an earlier >> promoted build >> - a summary of the warnings, grouped by the location contained in the >> warning >> - a summary of the warnings, grouped by the type of the warning >> The summaries are given sorted both alphabetically and by frequency. >> >> I've attached a sample of the output. The input was the log for a >> build on my >> laptop. For the purposes of testing, the "reference" was the same log >> truncated >> to 25000 lines. >> >> The big surprise: One file is responsible for nearly 72% of all the >> warnings in this >> build: 1928 warnings out of a total of 2684! The file in question is >> com/sun/java/util/jar/pack/coding.cpp >> >> The corollary is good news for everyone else; there are fewer >> warnings through >> the rest of the build than I expected, with only 14 files having 10 >> or more warnings. >> But, there are still over 150 files containing warnings :-( >> >> -- Jon >> >> >> >> Jonathan Gibbons wrote: >>> Well, here's an unexpected initial result. >>> >>> I just ran a build of langtools+jdk on my ubuntu laptop. I got a >>> whopping 2658 warnings!! [Those who volunteered to help get rid of >>> all the warnings, don't all step back at once!] But surprisingly, >>> after a quick "sort -u", only 625 of them are unique. So that means >>> we get on average a 4x bang for the buck for each warning we fix :-) >>> >>> -- Jon >>> >>> >>> On Jul 11, 2008, at 11:02 AM, Jonathan Gibbons wrote: >>> >>>> Depending on what lint options you use, deprecation warnings are >>>> typically reported as a single "Note:" at the end of the >>>> compilation, rather than as individual warning messages. Ideally, >>>> they should go too, but for now, I'd settle for removing messages >>>> that show up as diagnostics in IDEs, emacs, etc. >>>> >>>> For my part, I work mostly in the langtools area, and we are >>>> having a general background effort to clean up the code there. The >>>> goal is to clean the code and then use -Werror to treat any >>>> reappearance of warnings as errors. >>>> >>>> -- Jon >>>> >>>> >>>> On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: >>>> >>>>> Just curious, would part of this revision process entail removing >>>>> calls to deprecated methods and replacing them with their >>>>> documented replacement methods? >>>>> >>>>> There are many warnings about calls to deprecated methods in the >>>>> OpenJDK code. >>>>> >>>>> >>>>> Rob Ross, Lead Software Engineer >>>>> E! Networks >>>>> >>>>> --------------------------------------------------- >>>>> "Beware of he who would deny you access to information, for in his >>>>> heart he dreams himself your master." -- Commissioner Pravin Lal >>>>> >>>>> >>>>> >>>>> On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: >>>>> >>>>>> >>>>>> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >>>>>> >>>>>>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>>>>>> >>>>>>>> Yes, that technique can work well. But either way, the next >>>>>>>> step is >>>>>>>> to try writing the code to analyze the build log, to see how >>>>>>>> far the general >>>>>>>> idea can be taken, and how much interest there is to track/fix >>>>>>>> warnings. >>>>>>>> >>>>>>> Personally I'd like there to be no warnings at all, and would >>>>>>> like to contribute work to get there >>>>>>> >>>>>> >>>>>> Thank you. >>>>>> >>>>>> Getting rid of the actual warnings will require cooperation from >>>>>> the teams who are >>>>>> responsible for the various parts of the code. In some cases, >>>>>> there may be resistance, >>>>>> since stability is sometimes preferred over "no warnings". That >>>>>> being said, what I'm >>>>>> hoping to achieve with this discussion and any related effort is >>>>>> a non-intrusive way >>>>>> of gathering information about warnings, so that we have a better >>>>>> understanding of >>>>>> where the warnings are, in what areas of the code and in which >>>>>> source files. That way, >>>>>> we can work with the teams involved to see if there is interest >>>>>> in reducing their >>>>>> warning count in as safe a way as possible. Any assistance in >>>>>> getting to that point >>>>>> would be welcome. >>>>>> >>>>>> (Note that anyone contributing to OpenJDK must first sign the Sun >>>>>> Contributor Agreement; >>>>>> you can find details at http://sca.dev.java.net.) >>>>>> >>>>>> -- Jon >>>>>> >>>>>> >>>>> >>>> >>> >> >> >> ------------------------------------------------------------------------ >> >> >> JDK Build Warnings >> >> ------------------------------------------------------------------------ >> >> * Comparison against reference results >> o New warnings not found in reference files <#REF_DELTA_LOCNS> >> * Warnings categorized by location >> o Warning counts, sorted alphabetically by location >> <#LOCN_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of location >> <#LOCN_COUNTS_FREQ> >> o Warning counts, sorted alphabetically by location directory >> <#LOCN_DIR_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of location directory >> <#LOCN_DIR_COUNTS_FREQ> >> o Warning counts, sorted alphabetically by location directory >> <#LOCN_DIR_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of location directory >> <#LOCN_DIR_COUNTS_FREQ> >> * Warnings categorized by type >> o Warning counts, sorted alphabetically by type >> <#TYPE_COUNTS_ALPHA> >> o Warning counts, sorted by frequency of type >> <#TYPE_COUNTS_FREQ> >> o Warnings with unrecognized types <#TYPE_UNKNOWN> >> >> ------------------------------------------------------------------------ >> >> >> Log files analyzed >> >> * build.log >> >> total lines read 28834 >> total warnings found 2648 >> unique warnings found 617 >> >> >> Reference files analyzed >> >> * build-25000.log >> >> total lines read 25000 >> total warnings found 2618 >> unique warnings found 590 >> >> >> New warnings not found in reference files >> >> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >> javax/swing/JColorChooser.java 1 >> javax/swing/JComponent.java 4 >> javax/swing/JInternalFrame.java 2 >> javax/swing/JList.java 4 >> javax/swing/JPopupMenu.java 1 >> javax/swing/JTabbedPane.java 1 >> javax/swing/JTable.java 5 >> javax/swing/JTree.java 4 >> javax/swing/text/JTextComponent.java 3 >> ~NONE~ 1 >> >> >> Warning counts, sorted alphabetically by location >> >> /usr/include/X11/IntrinsicP.h 1 >> /usr/include/langinfo.h 1 >> /usr/include/sys/cdefs.h 1 >> /usr/include/sys/param.h 2 >> back/ArrayTypeImpl.c 1 >> back/inStream.c 4 >> back/outStream.c 8 >> back/stream.c 4 >> bin/jexec.c 1 >> bin/parse_manifest.c 1 >> build/tools/compilefontconfig/CompileFontConfig.java 4 >> build/tools/dtdbuilder/DTDParser.java 2 >> build/tools/fontchecker/FontChecker.java 2 >> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >> 3 >> build/tools/javazic/Gen.java 23 >> build/tools/javazic/GenDoc.java 2 >> build/tools/javazic/Time.java 7 >> com/sun/java/util/jar/pack/bands.cpp 2 >> com/sun/java/util/jar/pack/coding.cpp 1928 >> com/sun/java/util/jar/pack/main.cpp 1 >> com/sun/java/util/jar/pack/unpack.cpp 32 >> com/sun/java/util/jar/pack/unpack.h 24 >> com/sun/java/util/jar/pack/utils.cpp 2 >> com/sun/java/util/jar/pack/zip.cpp 1 >> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c 1 >> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c 5 >> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c 1 >> common/check_code.c 9 >> common/check_format.c 1 >> demo/jvmti/hprof/hprof_init.c 1 >> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >> hpi/native_threads/src/sys_api_td.c 1 >> instrument/JarFacade.c 1 >> java/io/canonicalize_md.c 2 >> java/io/io_util_md.h 8 >> java/lang/Class.c 1 >> java/lang/ClassLoader.c 2 >> java/lang/fdlibm/include/fdlibm.h 1 >> java/lang/fdlibm/src/e_jn.c 1 >> java/lang/fdlibm/src/e_pow.c 1 >> java/lang/fdlibm/src/e_sqrt.c 1 >> java/lang/fdlibm/src/s_ceil.c 1 >> java/lang/fdlibm/src/s_floor.c 1 >> java/lang/fdlibm/src/s_log1p.c 1 >> java/lang/java_props_md.c 3 >> java/lang/reflect/Proxy.c 1 >> java/net/Inet4AddressImpl.c 2 >> java/net/Inet6AddressImpl.c 3 >> java/net/NetworkInterface.c 1 >> java/net/PlainDatagramSocketImpl.c 6 >> java/net/linux_close.c 3 >> java/net/net_util_md.c 2 >> java/nio/Bits.c 8 >> java/nio/MappedByteBuffer.c 1 >> java/util/zip/zip_util.c 1 >> java/util/zip/zlib-1.1.3/inftrees.c 3 >> javavm/include/typedefs.h 8 >> javax/swing/JColorChooser.java 1 >> javax/swing/JComponent.java 4 >> javax/swing/JInternalFrame.java 2 >> javax/swing/JList.java 4 >> javax/swing/JPopupMenu.java 1 >> javax/swing/JTabbedPane.java 1 >> javax/swing/JTable.java 5 >> javax/swing/JTree.java 4 >> javax/swing/text/JTextComponent.java 3 >> sun/awt/awt_DrawingSurface.c 1 >> sun/awt/awt_Font.c 1 >> sun/awt/awt_GraphicsEnv.c 1 >> sun/awt/awt_InputMethod.c 11 >> sun/awt/awt_LoadLibrary.c 2 >> sun/awt/awt_UNIXToolkit.c 1 >> sun/awt/giflib/dgif_lib.c 16 >> sun/awt/image/BufImgSurfaceData.c 1 >> sun/awt/image/jpeg/imageioJPEG.c 19 >> sun/awt/image/jpeg/jpegdecoder.c 1 >> sun/awt/java2d/loops/ByteBinary1Bit.c 5 >> sun/awt/java2d/loops/ByteBinary2Bit.c 5 >> sun/awt/java2d/loops/ByteBinary4Bit.c 5 >> sun/awt/java2d/loops/ByteGray.c 2 >> sun/awt/java2d/loops/ByteIndexed.c 6 >> sun/awt/java2d/loops/FourByteAbgr.c 2 >> sun/awt/java2d/loops/FourByteAbgrPre.c 2 >> sun/awt/java2d/loops/Index12Gray.c 2 >> sun/awt/java2d/loops/Index8Gray.c 2 >> sun/awt/java2d/loops/IntArgb.c 6 >> sun/awt/java2d/loops/IntArgbBm.c 5 >> sun/awt/java2d/loops/IntArgbPre.c 6 >> sun/awt/java2d/loops/IntBgr.c 2 >> sun/awt/java2d/loops/IntRgb.c 2 >> sun/awt/java2d/loops/IntRgbx.c 2 >> sun/awt/java2d/loops/ThreeByteBgr.c 2 >> sun/awt/java2d/loops/TransformHelper.c 3 >> sun/awt/java2d/loops/Ushort555Rgb.c 2 >> sun/awt/java2d/loops/Ushort565Rgb.c 2 >> sun/awt/java2d/loops/UshortGray.c 2 >> sun/awt/java2d/loops/UshortIndexed.c 6 >> sun/awt/java2d/pipe/Region.c 1 >> sun/awt/libpng/pngread.c 1 >> sun/awt/libpng/pngrtran.c 1 >> sun/awt/libpng/pngrutil.c 1 >> sun/awt/libpng/pngwrite.c 1 >> sun/awt/medialib/mlib_ImageAffine.c 7 >> sun/awt/medialib/mlib_ImageAffineEdge.c 34 >> sun/awt/medialib/mlib_ImageColorTrue2Index.c 10 >> sun/awt/medialib/mlib_ImageConvMxN.c 9 >> sun/awt/medialib/mlib_ImageConv_16ext.c 4 >> sun/awt/medialib/mlib_ImageConv_16nw.c 3 >> sun/awt/medialib/mlib_ImageConv_32nw.c 2 >> sun/awt/medialib/mlib_ImageConv_8ext.c 4 >> sun/awt/medialib/mlib_ImageConv_8nw.c 3 >> sun/awt/medialib/mlib_ImageConv_D64nw.c 2 >> sun/awt/medialib/mlib_ImageConv_F32nw.c 1 >> sun/awt/medialib/mlib_ImageConv_u16ext.c 4 >> sun/awt/medialib/mlib_ImageConv_u16nw.c 3 >> sun/awt/medialib/mlib_ImageCopy_Bit.c 4 >> sun/awt/medialib/mlib_ImageCreate.c 2 >> sun/awt/splashscreen/splashscreen_gfx_impl.c 2 >> sun/font/DrawGlyphList.c 5 >> sun/font/X11FontScaler.c 7 >> sun/font/layout/LEGlyphStorage.h 32 >> sun/font/layout/LEInsertionList.h 33 >> sun/font/layout/MorphTables.cpp 1 >> sun/java2d/cmm/lcms/LCMS.c 2 >> sun/java2d/cmm/lcms/cmscgats.c 2 >> sun/java2d/cmm/lcms/cmsio1.c 2 >> sun/java2d/cmm/lcms/cmslut.c 4 >> sun/java2d/cmm/lcms/cmswtpnt.c 1 >> sun/java2d/x11/X11PMBlitLoops.c 2 >> sun/java2d/x11/X11Renderer.c 45 >> sun/java2d/x11/X11SurfaceData.c 10 >> sun/java2d/x11/X11TextRenderer_md.c 1 >> sun/net/spi/DefaultProxySelector.c 1 >> sun/nio/ch/DatagramChannelImpl.c 1 >> sun/nio/ch/InheritedChannel.c 1 >> sun/nio/ch/Net.c 2 >> sun/nio/ch/ServerSocketChannelImpl.c 1 >> sun/nio/ch/SocketChannelImpl.c 1 >> sun/rmi/rmic/Main.java 1 >> sun/rmi/rmic/newrmic/Resources.java 1 >> sun/security/jgss/wrapper/GSSLibStub.c 63 >> sun/security/jgss/wrapper/NativeUtil.c 2 >> sun/security/pkcs11/j2secmod_md.c 3 >> sun/security/pkcs11/wrapper/p11_crypt.c 6 >> sun/security/pkcs11/wrapper/p11_digest.c 1 >> sun/security/pkcs11/wrapper/p11_keymgmt.c 1 >> sun/security/pkcs11/wrapper/p11_md.c 1 >> sun/security/pkcs11/wrapper/p11_sign.c 3 >> sun/security/pkcs11/wrapper/p11_util.c 2 >> sun/tools/serialver/SerialVer.java 1 >> sun/tracing/dtrace/JVM.c 1 >> sun/xawt/XToolkit.c 2 >> sun/xawt/XWindow.c 4 >> sun/xawt/awt_Desktop.c 1 >> transport/socket/socket_md.c 3 >> unpack.cpp 1 >> ~NONE~ 5 >> >> >> Warning counts, sorted by frequency of location >> >> 1928 com/sun/java/util/jar/pack/coding.cpp >> 63 sun/security/jgss/wrapper/GSSLibStub.c >> 45 sun/java2d/x11/X11Renderer.c >> 34 sun/awt/medialib/mlib_ImageAffineEdge.c >> 33 sun/font/layout/LEInsertionList.h >> 32 com/sun/java/util/jar/pack/unpack.cpp >> 32 sun/font/layout/LEGlyphStorage.h >> 24 com/sun/java/util/jar/pack/unpack.h >> 23 build/tools/javazic/Gen.java >> 19 sun/awt/image/jpeg/imageioJPEG.c >> 16 sun/awt/giflib/dgif_lib.c >> 11 sun/awt/awt_InputMethod.c >> 10 sun/awt/medialib/mlib_ImageColorTrue2Index.c >> 10 sun/java2d/x11/X11SurfaceData.c >> 9 common/check_code.c >> 9 sun/awt/medialib/mlib_ImageConvMxN.c >> 8 back/outStream.c >> 8 java/io/io_util_md.h >> 8 java/nio/Bits.c >> 8 javavm/include/typedefs.h >> 7 build/tools/javazic/Time.java >> 7 sun/awt/medialib/mlib_ImageAffine.c >> 7 sun/font/X11FontScaler.c >> 6 java/net/PlainDatagramSocketImpl.c >> 6 sun/awt/java2d/loops/ByteIndexed.c >> 6 sun/awt/java2d/loops/IntArgb.c >> 6 sun/awt/java2d/loops/IntArgbPre.c >> 6 sun/awt/java2d/loops/UshortIndexed.c >> 6 sun/security/pkcs11/wrapper/p11_crypt.c >> 5 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c >> 5 javax/swing/JTable.java >> 5 sun/awt/java2d/loops/ByteBinary1Bit.c >> 5 sun/awt/java2d/loops/ByteBinary2Bit.c >> 5 sun/awt/java2d/loops/ByteBinary4Bit.c >> 5 sun/awt/java2d/loops/IntArgbBm.c >> 5 sun/font/DrawGlyphList.c >> 5 ~NONE~ >> 4 back/inStream.c >> 4 back/stream.c >> 4 build/tools/compilefontconfig/CompileFontConfig.java >> 4 javax/swing/JComponent.java >> 4 javax/swing/JList.java >> 4 javax/swing/JTree.java >> 4 sun/awt/medialib/mlib_ImageConv_16ext.c >> 4 sun/awt/medialib/mlib_ImageConv_8ext.c >> 4 sun/awt/medialib/mlib_ImageConv_u16ext.c >> 4 sun/awt/medialib/mlib_ImageCopy_Bit.c >> 4 sun/java2d/cmm/lcms/cmslut.c >> 4 sun/xawt/XWindow.c >> 3 >> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >> 3 java/lang/java_props_md.c >> 3 java/net/Inet6AddressImpl.c >> 3 java/net/linux_close.c >> 3 java/util/zip/zlib-1.1.3/inftrees.c >> 3 javax/swing/text/JTextComponent.java >> 3 sun/awt/java2d/loops/TransformHelper.c >> 3 sun/awt/medialib/mlib_ImageConv_16nw.c >> 3 sun/awt/medialib/mlib_ImageConv_8nw.c >> 3 sun/awt/medialib/mlib_ImageConv_u16nw.c >> 3 sun/security/pkcs11/j2secmod_md.c >> 3 sun/security/pkcs11/wrapper/p11_sign.c >> 3 transport/socket/socket_md.c >> 2 /usr/include/sys/param.h >> 2 build/tools/dtdbuilder/DTDParser.java >> 2 build/tools/fontchecker/FontChecker.java >> 2 build/tools/javazic/GenDoc.java >> 2 com/sun/java/util/jar/pack/bands.cpp >> 2 com/sun/java/util/jar/pack/utils.cpp >> 2 democlasses/demo/jvmti/waiters/src/waiters.cpp >> 2 java/io/canonicalize_md.c >> 2 java/lang/ClassLoader.c >> 2 java/net/Inet4AddressImpl.c >> 2 java/net/net_util_md.c >> 2 javax/swing/JInternalFrame.java >> 2 sun/awt/awt_LoadLibrary.c >> 2 sun/awt/java2d/loops/ByteGray.c >> 2 sun/awt/java2d/loops/FourByteAbgr.c >> 2 sun/awt/java2d/loops/FourByteAbgrPre.c >> 2 sun/awt/java2d/loops/Index12Gray.c >> 2 sun/awt/java2d/loops/Index8Gray.c >> 2 sun/awt/java2d/loops/IntBgr.c >> 2 sun/awt/java2d/loops/IntRgb.c >> 2 sun/awt/java2d/loops/IntRgbx.c >> 2 sun/awt/java2d/loops/ThreeByteBgr.c >> 2 sun/awt/java2d/loops/Ushort555Rgb.c >> 2 sun/awt/java2d/loops/Ushort565Rgb.c >> 2 sun/awt/java2d/loops/UshortGray.c >> 2 sun/awt/medialib/mlib_ImageConv_32nw.c >> 2 sun/awt/medialib/mlib_ImageConv_D64nw.c >> 2 sun/awt/medialib/mlib_ImageCreate.c >> 2 sun/awt/splashscreen/splashscreen_gfx_impl.c >> 2 sun/java2d/cmm/lcms/LCMS.c >> 2 sun/java2d/cmm/lcms/cmscgats.c >> 2 sun/java2d/cmm/lcms/cmsio1.c >> 2 sun/java2d/x11/X11PMBlitLoops.c >> 2 sun/nio/ch/Net.c >> 2 sun/security/jgss/wrapper/NativeUtil.c >> 2 sun/security/pkcs11/wrapper/p11_util.c >> 2 sun/xawt/XToolkit.c >> 1 /usr/include/X11/IntrinsicP.h >> 1 /usr/include/langinfo.h >> 1 /usr/include/sys/cdefs.h >> 1 back/ArrayTypeImpl.c >> 1 bin/jexec.c >> 1 bin/parse_manifest.c >> 1 com/sun/java/util/jar/pack/main.cpp >> 1 com/sun/java/util/jar/pack/zip.cpp >> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c >> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c >> 1 common/check_format.c >> 1 demo/jvmti/hprof/hprof_init.c >> 1 democlasses/demo/jvmti/hprof/src/hprof_init.c >> 1 democlasses/demo/jvmti/waiters/src/Agent.cpp >> 1 hpi/native_threads/src/sys_api_td.c >> 1 instrument/JarFacade.c >> 1 java/lang/Class.c >> 1 java/lang/fdlibm/include/fdlibm.h >> 1 java/lang/fdlibm/src/e_jn.c >> 1 java/lang/fdlibm/src/e_pow.c >> 1 java/lang/fdlibm/src/e_sqrt.c >> 1 java/lang/fdlibm/src/s_ceil.c >> 1 java/lang/fdlibm/src/s_floor.c >> 1 java/lang/fdlibm/src/s_log1p.c >> 1 java/lang/reflect/Proxy.c >> 1 java/net/NetworkInterface.c >> 1 java/nio/MappedByteBuffer.c >> 1 java/util/zip/zip_util.c >> 1 javax/swing/JColorChooser.java >> 1 javax/swing/JPopupMenu.java >> 1 javax/swing/JTabbedPane.java >> 1 sun/awt/awt_DrawingSurface.c >> 1 sun/awt/awt_Font.c >> 1 sun/awt/awt_GraphicsEnv.c >> 1 sun/awt/awt_UNIXToolkit.c >> 1 sun/awt/image/BufImgSurfaceData.c >> 1 sun/awt/image/jpeg/jpegdecoder.c >> 1 sun/awt/java2d/pipe/Region.c >> 1 sun/awt/libpng/pngread.c >> 1 sun/awt/libpng/pngrtran.c >> 1 sun/awt/libpng/pngrutil.c >> 1 sun/awt/libpng/pngwrite.c >> 1 sun/awt/medialib/mlib_ImageConv_F32nw.c >> 1 sun/font/layout/MorphTables.cpp >> 1 sun/java2d/cmm/lcms/cmswtpnt.c >> 1 sun/java2d/x11/X11TextRenderer_md.c >> 1 sun/net/spi/DefaultProxySelector.c >> 1 sun/nio/ch/DatagramChannelImpl.c >> 1 sun/nio/ch/InheritedChannel.c >> 1 sun/nio/ch/ServerSocketChannelImpl.c >> 1 sun/nio/ch/SocketChannelImpl.c >> 1 sun/rmi/rmic/Main.java >> 1 sun/rmi/rmic/newrmic/Resources.java >> 1 sun/security/pkcs11/wrapper/p11_digest.c >> 1 sun/security/pkcs11/wrapper/p11_keymgmt.c >> 1 sun/security/pkcs11/wrapper/p11_md.c >> 1 sun/tools/serialver/SerialVer.java >> 1 sun/tracing/dtrace/JVM.c >> 1 sun/xawt/awt_Desktop.c >> 1 unpack.cpp >> >> >> Warning counts, sorted alphabetically by location directory >> >> /usr/include 1 >> /usr/include/X11 1 >> /usr/include/sys 3 >> back 17 >> bin 2 >> build/tools/compilefontconfig 4 >> build/tools/dtdbuilder 2 >> build/tools/fontchecker 2 >> build/tools/generatebreakiteratordata 3 >> build/tools/javazic 32 >> com/sun/java/util/jar/pack 1990 >> com/sun/media/sound 7 >> common 10 >> demo/jvmti/hprof 1 >> democlasses/demo/jvmti/hprof/src 1 >> democlasses/demo/jvmti/waiters/src 3 >> hpi/native_threads/src 1 >> instrument 1 >> java/io 10 >> java/lang 6 >> java/lang/fdlibm/include 1 >> java/lang/fdlibm/src 6 >> java/lang/reflect 1 >> java/net 17 >> java/nio 9 >> java/util/zip 1 >> java/util/zip/zlib-1.1.3 3 >> javavm/include 8 >> javax/swing 22 >> javax/swing/text 3 >> sun/awt 17 >> sun/awt/giflib 16 >> sun/awt/image 1 >> sun/awt/image/jpeg 20 >> sun/awt/java2d/loops 71 >> sun/awt/java2d/pipe 1 >> sun/awt/libpng 4 >> sun/awt/medialib 92 >> sun/awt/splashscreen 2 >> sun/font 12 >> sun/font/layout 66 >> sun/java2d/cmm/lcms 11 >> sun/java2d/x11 58 >> sun/net/spi 1 >> sun/nio/ch 6 >> sun/rmi/rmic 1 >> sun/rmi/rmic/newrmic 1 >> sun/security/jgss/wrapper 65 >> sun/security/pkcs11 3 >> sun/security/pkcs11/wrapper 14 >> sun/tools/serialver 1 >> sun/tracing/dtrace 1 >> sun/xawt 7 >> transport/socket 3 >> unpack.cpp 1 >> ~NONE~ 5 >> >> >> Warning counts, sorted by frequency of location >> >> 1990 com/sun/java/util/jar/pack >> 92 sun/awt/medialib >> 71 sun/awt/java2d/loops >> 66 sun/font/layout >> 65 sun/security/jgss/wrapper >> 58 sun/java2d/x11 >> 32 build/tools/javazic >> 22 javax/swing >> 20 sun/awt/image/jpeg >> 17 back >> 17 java/net >> 17 sun/awt >> 16 sun/awt/giflib >> 14 sun/security/pkcs11/wrapper >> 12 sun/font >> 11 sun/java2d/cmm/lcms >> 10 common >> 10 java/io >> 9 java/nio >> 8 javavm/include >> 7 com/sun/media/sound >> 7 sun/xawt >> 6 java/lang >> 6 java/lang/fdlibm/src >> 6 sun/nio/ch >> 5 ~NONE~ >> 4 build/tools/compilefontconfig >> 4 sun/awt/libpng >> 3 /usr/include/sys >> 3 build/tools/generatebreakiteratordata >> 3 democlasses/demo/jvmti/waiters/src >> 3 java/util/zip/zlib-1.1.3 >> 3 javax/swing/text >> 3 sun/security/pkcs11 >> 3 transport/socket >> 2 bin >> 2 build/tools/dtdbuilder >> 2 build/tools/fontchecker >> 2 sun/awt/splashscreen >> 1 /usr/include >> 1 /usr/include/X11 >> 1 demo/jvmti/hprof >> 1 democlasses/demo/jvmti/hprof/src >> 1 hpi/native_threads/src >> 1 instrument >> 1 java/lang/fdlibm/include >> 1 java/lang/reflect >> 1 java/util/zip >> 1 sun/awt/image >> 1 sun/awt/java2d/pipe >> 1 sun/net/spi >> 1 sun/rmi/rmic >> 1 sun/rmi/rmic/newrmic >> 1 sun/tools/serialver >> 1 sun/tracing/dtrace >> 1 unpack.cpp >> >> >> Warning counts, sorted alphabetically by location extension >> >> .c 474 >> .cpp 61 >> .h 12 >> .java 68 >> ~NONE~ 2 >> >> >> Warning counts, sorted by frequency of location extension >> >> 474 .c >> 68 .java >> 61 .cpp >> 12 .h >> 2 ~NONE~ >> >> >> Warning counts, sorted alphabetically by type >> >> "*" redefined 13 >> '*' may be used uninitialized in this function 126 >> 'class *' has virtual functions but non-virtual destructor 65 >> 'static' is not at beginning of declaration 2 >> argument '*' might be clobbered by '*' 1 >> assignment from incompatible pointer type 1 >> assignment makes integer from pointer without a cast 1 >> cast from pointer to integer of different size 22 >> cast to java.lang.Object[] for a non-varargs call and to suppress >> this warning 4 >> cast to pointer from integer of different size 137 >> comparison between pointer and integer 3 >> comparison between signed and unsigned 106 >> comparison is always false due to limited range of data type 2 >> constant is too large for*type 18 >> control reaches end of non-void function 1 >> dereferencing type-punned pointer will break strict-aliasing rules 4 >> enumeration value * not handled in switch 101 >> format '*' expects type '*', but argument * has type '*' 12 >> implicit declaration of function 3 >> is Sun proprietary API and may be removed in a future release 67 >> missing braces around initializer 2 >> missing initializer 1 >> missing initializer for member 1874 >> non-varargs call of varargs method with inexact argument type for >> last parameter 4 >> package * does not exist 1 >> passing * from incompatible pointer type 3 >> pointer targets * differ in signedness 32 >> return makes integer from pointer without a cast 5 >> signed and unsigned type in conditional expression 16 >> the use of `*' is dangerous 1 >> this is the location of the previous definition 13 >> type defaults to * in declaration 2 >> variable '*' might be clobbered by '*' 4 >> ~UNKNOWN~ 1 >> >> >> Warning counts, sorted by frequency of type >> >> 1874 missing initializer for member >> 137 cast to pointer from integer of different size >> 126 '*' may be used uninitialized in this function >> 106 comparison between signed and unsigned >> 101 enumeration value * not handled in switch >> 67 is Sun proprietary API and may be removed in a future release >> 65 'class *' has virtual functions but non-virtual destructor >> 32 pointer targets * differ in signedness >> 22 cast from pointer to integer of different size >> 18 constant is too large for*type >> 16 signed and unsigned type in conditional expression >> 13 "*" redefined >> 13 this is the location of the previous definition >> 12 format '*' expects type '*', but argument * has type '*' >> 5 return makes integer from pointer without a cast >> 4 cast to java.lang.Object[] for a non-varargs call and to >> suppress this warning >> 4 dereferencing type-punned pointer will break strict-aliasing rules >> 4 non-varargs call of varargs method with inexact argument type >> for last parameter >> 4 variable '*' might be clobbered by '*' >> 3 comparison between pointer and integer >> 3 implicit declaration of function >> 3 passing * from incompatible pointer type >> 2 'static' is not at beginning of declaration >> 2 comparison is always false due to limited range of data type >> 2 missing braces around initializer >> 2 type defaults to * in declaration >> 1 argument '*' might be clobbered by '*' >> 1 assignment from incompatible pointer type >> 1 assignment makes integer from pointer without a cast >> 1 control reaches end of non-void function >> 1 missing initializer >> 1 package * does not exist >> 1 the use of `*' is dangerous >> 1 ~UNKNOWN~ >> >> >> Warnings with unrecognized types >> >> * ../../../src/solaris/native/java/lang/java_props_md.c:124: >> warning: (near initialization for 'sprops.os_version') >> >> ------------------------------------------------------------------------ >> Generated on Sun Jul 13 17:36:12 PDT 2008 From Kelly.Ohair at Sun.COM Mon Jul 14 13:10:58 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Mon, 14 Jul 2008 13:10:58 -0700 Subject: getting a handle on build warnings In-Reply-To: <487BA034.8050602@sun.com> References: <48763574.3060404@sun.com> <578FB6F7-492E-45E4-88C6-23D7CC85800E@Sun.COM> <487791BE.9000202@gmail.com> <8E486643-0B24-487C-9C32-681184E9FF42@sun.com> <487AA0EE.8070009@sun.com> <487B9249.9050907@sun.com> <487BA034.8050602@sun.com> Message-ID: <487BB2D2.5080602@sun.com> I understand. FYI... I filed a serviceability bug on those warnings, looks like we have some new ones that creeped in. I also pinged Dave Bristor on the warnings in the jar code, there was a bug on that already. I marked these bugs with the keyword "warnings", so I can find them easily. I'm loading up my guns and will do what I can to hunt down the warnings. ;^) -kto Jonathan Gibbons wrote: > I agree that fixing warnings is not necessarily an easy task. My goal > in writing the tool was to make it easy for people to scan the set > of warnings, and say, "wow, that one looks really serious, I'd better > fix that!" > > -- Jon > > > Kelly O'Hair wrote: >> >> FYI... >> >> I dug up my old wstats ksh script and ran it over a concatenation of the >> latest jdk7 build 30 logs for all 8 of builds done by Java Release >> Engineering >> (solaris-i586, solaris-x64, solaris-sparc, solaris-sparcv9, linux-i586, >> linux-x64, windows-i586, and windows-x64). >> Granted, these are OLD Linux systems with gcc 3.2, and lots of duplicates >> here. >> >> The problems with dealing with the C/C++ warnings is that the >> different compilers >> and different releases of the compilers create a bit of an unknown >> when trying >> to fix warnings. Fixing a warning from gcc4 might just trigger a new >> warning >> for some other reason from the Sun Studio compiler, can be frustrating. >> And using just a slightly newer or patched gcc or Sun Studio compiler >> might >> generate new warnings you haven't seen before. >> This has gotten better over time but continues to be an issue. >> >> A danger also lies in how a warning is fixed in native code that needs >> to work on >> all platforms and with different compilers, for example, adding a cast >> like >> '(long)' might shut up a warning, but could break Windows X64 where a >> long >> is 32bits not 64bits. People need to be very careful in the native code. >> >> At least with the javac warnings, fixing them is more concrete, and >> probably >> less risky ;^) >> >> I'm all in favor of fixing the warnings, just trying to make sure it's >> done >> safely. ;^) >> >> -kto >> >> ------------------------------------- >> >> >> Warning Message Counts: >> ---------------------- >> 15790 ld warnings (contains 'ld:') >> 6686 C warnings (contains '[.]c[":]') >> 1616 C Include file warnings (contains '[.]h[":]') >> 9700 C++ warnings (contains '[.]cpp[":]') >> 0 C++ Include file warnings (contains '[.]hpp[":]') >> 4432 Java warnings (contains '.java:' or 'Note:' ) >> 0 VM warnings (contains 'VM warning:' ) >> 600 Javadoc warnings (contains ': warning -') >> 250 Compiler driver warnings (contains cc: or CC: or 'cl :') >> 59 GNU make warnings (contains '.gmk:' or 'akefile:' or '(ignored)' >> or starts with 'gnumake') >> 276 Shell warnings (contains ': not found' or 'awk:') >> 187 Build warnings (contains WARNING:) >> 312 Font warnings (contains 'entry is missing') >> ----- >> 39908 Total of above warnings >> >> 29252 Messages that appear to be duplicates >> 18 Remaining errors not counted >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf does not exist >> /usr/ccs/bin/as: >> "/export2/BUILD_AREA/jdk7/hotspot/src/os_cpu/solaris_sparc/vm/solaris_sparc.s", >> line 86: warning: label in delay slot (follows CTI) >> warning: package com.sun.java.swing.plaf does not exist >> /usr/ccs/bin/as: >> "/export2/BUILD_AREA/jdk7/hotspot/src/os_cpu/solaris_sparc/vm/solaris_sparc.s", >> line 86: warning: label in delay slot (follows CTI) >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf.gtk does not exist >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf.gtk does not exist >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf.gtk does not exist >> warning: package com.sun.java.swing.plaf does not exist >> warning: package com.sun.java.swing.plaf.gtk does not exist >> >> Top 20 'src/' files mentioned in warning messages: >> ------------------------------------------------- >> 7972 src/share/native/com/sun/java/util/jar/pack/coding.cpp >> 2062 src/closed/share/classes/sun/jdbc/odbc/JdbcOdbc.c >> 1278 src/share/native/com/sun/java/util/jar/pack/unpack.cpp >> 1188 src/share/classes/sun/corba/Bridge.java >> 1096 src/solaris/native/sun/awt/gtk2_interface.c >> 888 src/closed/share/native/sun/java2d/cmm/kcms/evalth13.c >> 720 src/share/native/com/sun/java/util/jar/pack/bands.h >> 276 src/share/native/com/sun/java/util/jar/pack/unpack.h >> 276 src/build/tools/javazic/Gen.java >> 272 src/closed/share/native/sun/java2d/cmm/kcms/evalth14.c >> 252 src/share/classes/sun/nio/ch/FileChannelImpl.java >> 204 src/share/native/com/sun/java/util/jar/pack/bytes.h >> 204 src/share/classes/org/omg/CORBA/ORB.java >> 192 >> src/share/classes/com/sun/corba/se/impl/presentation/rmi/ExceptionHandlerImpl.java >> >> 170 src/share/native/sun/security/jgss/wrapper/GSSLibStub.c >> 140 src/share/native/com/sun/java/util/jar/pack/zip.cpp >> 136 src/share/native/sun/awt/medialib/mlib_ImageAffineEdge.c >> 128 src/share/native/sun/font/layout/LEGlyphStorage.h >> 114 src/share/classes/javax/sql/rowset/BaseRowSet.java >> 108 src/share/classes/javax/rmi/CORBA/GetORBPropertiesFileAction.java >> >> >> >> Jonathan Gibbons wrote: >>> I've written a program to analyze the warnings in a build log, >>> containing most of >>> the ideas I outlined earlier, and more. >>> >>> Right now, a "warning" is defined as a line containing the string >>> "warning" >>> with false positives filtered out (e.g. a reference to a file called >>> warning.png) >>> >>> It can generate a report in plain text or html, containing any/all of >>> the following: >>> - comparison against a reference log, such as the log for an earlier >>> promoted build >>> - a summary of the warnings, grouped by the location contained in the >>> warning >>> - a summary of the warnings, grouped by the type of the warning >>> The summaries are given sorted both alphabetically and by frequency. >>> >>> I've attached a sample of the output. The input was the log for a >>> build on my >>> laptop. For the purposes of testing, the "reference" was the same log >>> truncated >>> to 25000 lines. >>> >>> The big surprise: One file is responsible for nearly 72% of all the >>> warnings in this >>> build: 1928 warnings out of a total of 2684! The file in question is >>> com/sun/java/util/jar/pack/coding.cpp >>> >>> The corollary is good news for everyone else; there are fewer >>> warnings through >>> the rest of the build than I expected, with only 14 files having 10 >>> or more warnings. >>> But, there are still over 150 files containing warnings :-( >>> >>> -- Jon >>> >>> >>> >>> Jonathan Gibbons wrote: >>>> Well, here's an unexpected initial result. >>>> >>>> I just ran a build of langtools+jdk on my ubuntu laptop. I got a >>>> whopping 2658 warnings!! [Those who volunteered to help get rid of >>>> all the warnings, don't all step back at once!] But surprisingly, >>>> after a quick "sort -u", only 625 of them are unique. So that means >>>> we get on average a 4x bang for the buck for each warning we fix :-) >>>> >>>> -- Jon >>>> >>>> >>>> On Jul 11, 2008, at 11:02 AM, Jonathan Gibbons wrote: >>>> >>>>> Depending on what lint options you use, deprecation warnings are >>>>> typically reported as a single "Note:" at the end of the >>>>> compilation, rather than as individual warning messages. Ideally, >>>>> they should go too, but for now, I'd settle for removing messages >>>>> that show up as diagnostics in IDEs, emacs, etc. >>>>> >>>>> For my part, I work mostly in the langtools area, and we are >>>>> having a general background effort to clean up the code there. The >>>>> goal is to clean the code and then use -Werror to treat any >>>>> reappearance of warnings as errors. >>>>> >>>>> -- Jon >>>>> >>>>> >>>>> On Jul 11, 2008, at 10:52 AM, Rob Ross wrote: >>>>> >>>>>> Just curious, would part of this revision process entail removing >>>>>> calls to deprecated methods and replacing them with their >>>>>> documented replacement methods? >>>>>> >>>>>> There are many warnings about calls to deprecated methods in the >>>>>> OpenJDK code. >>>>>> >>>>>> >>>>>> Rob Ross, Lead Software Engineer >>>>>> E! Networks >>>>>> >>>>>> --------------------------------------------------- >>>>>> "Beware of he who would deny you access to information, for in his >>>>>> heart he dreams himself your master." -- Commissioner Pravin Lal >>>>>> >>>>>> >>>>>> >>>>>> On Jul 11, 2008, at 10:43 AM, Jonathan Gibbons wrote: >>>>>> >>>>>>> >>>>>>> On Jul 11, 2008, at 10:00 AM, Thorbj?rn Ravn Andersen wrote: >>>>>>> >>>>>>>> Jonathan Gibbons skrev den 11-07-2008 13:52: >>>>>>>>> >>>>>>>>> Yes, that technique can work well. But either way, the next >>>>>>>>> step is >>>>>>>>> to try writing the code to analyze the build log, to see how >>>>>>>>> far the general >>>>>>>>> idea can be taken, and how much interest there is to track/fix >>>>>>>>> warnings. >>>>>>>>> >>>>>>>> Personally I'd like there to be no warnings at all, and would >>>>>>>> like to contribute work to get there >>>>>>>> >>>>>>> >>>>>>> Thank you. >>>>>>> >>>>>>> Getting rid of the actual warnings will require cooperation from >>>>>>> the teams who are >>>>>>> responsible for the various parts of the code. In some cases, >>>>>>> there may be resistance, >>>>>>> since stability is sometimes preferred over "no warnings". That >>>>>>> being said, what I'm >>>>>>> hoping to achieve with this discussion and any related effort is >>>>>>> a non-intrusive way >>>>>>> of gathering information about warnings, so that we have a better >>>>>>> understanding of >>>>>>> where the warnings are, in what areas of the code and in which >>>>>>> source files. That way, >>>>>>> we can work with the teams involved to see if there is interest >>>>>>> in reducing their >>>>>>> warning count in as safe a way as possible. Any assistance in >>>>>>> getting to that point >>>>>>> would be welcome. >>>>>>> >>>>>>> (Note that anyone contributing to OpenJDK must first sign the Sun >>>>>>> Contributor Agreement; >>>>>>> you can find details at http://sca.dev.java.net.) >>>>>>> >>>>>>> -- Jon >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >>> JDK Build Warnings >>> >>> ------------------------------------------------------------------------ >>> >>> * Comparison against reference results >>> o New warnings not found in reference files <#REF_DELTA_LOCNS> >>> * Warnings categorized by location >>> o Warning counts, sorted alphabetically by location >>> <#LOCN_COUNTS_ALPHA> >>> o Warning counts, sorted by frequency of location >>> <#LOCN_COUNTS_FREQ> >>> o Warning counts, sorted alphabetically by location directory >>> <#LOCN_DIR_COUNTS_ALPHA> >>> o Warning counts, sorted by frequency of location directory >>> <#LOCN_DIR_COUNTS_FREQ> >>> o Warning counts, sorted alphabetically by location directory >>> <#LOCN_DIR_COUNTS_ALPHA> >>> o Warning counts, sorted by frequency of location directory >>> <#LOCN_DIR_COUNTS_FREQ> >>> * Warnings categorized by type >>> o Warning counts, sorted alphabetically by type >>> <#TYPE_COUNTS_ALPHA> >>> o Warning counts, sorted by frequency of type >>> <#TYPE_COUNTS_FREQ> >>> o Warnings with unrecognized types <#TYPE_UNKNOWN> >>> >>> ------------------------------------------------------------------------ >>> >>> >>> Log files analyzed >>> >>> * build.log >>> >>> total lines read 28834 >>> total warnings found 2648 >>> unique warnings found 617 >>> >>> >>> Reference files analyzed >>> >>> * build-25000.log >>> >>> total lines read 25000 >>> total warnings found 2618 >>> unique warnings found 590 >>> >>> >>> New warnings not found in reference files >>> >>> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >>> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >>> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >>> javax/swing/JColorChooser.java 1 >>> javax/swing/JComponent.java 4 >>> javax/swing/JInternalFrame.java 2 >>> javax/swing/JList.java 4 >>> javax/swing/JPopupMenu.java 1 >>> javax/swing/JTabbedPane.java 1 >>> javax/swing/JTable.java 5 >>> javax/swing/JTree.java 4 >>> javax/swing/text/JTextComponent.java 3 >>> ~NONE~ 1 >>> >>> >>> Warning counts, sorted alphabetically by location >>> >>> /usr/include/X11/IntrinsicP.h 1 >>> /usr/include/langinfo.h 1 >>> /usr/include/sys/cdefs.h 1 >>> /usr/include/sys/param.h 2 >>> back/ArrayTypeImpl.c 1 >>> back/inStream.c 4 >>> back/outStream.c 8 >>> back/stream.c 4 >>> bin/jexec.c 1 >>> bin/parse_manifest.c 1 >>> build/tools/compilefontconfig/CompileFontConfig.java 4 >>> build/tools/dtdbuilder/DTDParser.java 2 >>> build/tools/fontchecker/FontChecker.java 2 >>> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >>> 3 >>> build/tools/javazic/Gen.java 23 >>> build/tools/javazic/GenDoc.java 2 >>> build/tools/javazic/Time.java 7 >>> com/sun/java/util/jar/pack/bands.cpp 2 >>> com/sun/java/util/jar/pack/coding.cpp 1928 >>> com/sun/java/util/jar/pack/main.cpp 1 >>> com/sun/java/util/jar/pack/unpack.cpp 32 >>> com/sun/java/util/jar/pack/unpack.h 24 >>> com/sun/java/util/jar/pack/utils.cpp 2 >>> com/sun/java/util/jar/pack/zip.cpp 1 >>> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c 1 >>> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c 5 >>> com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c 1 >>> common/check_code.c 9 >>> common/check_format.c 1 >>> demo/jvmti/hprof/hprof_init.c 1 >>> democlasses/demo/jvmti/hprof/src/hprof_init.c 1 >>> democlasses/demo/jvmti/waiters/src/Agent.cpp 1 >>> democlasses/demo/jvmti/waiters/src/waiters.cpp 2 >>> hpi/native_threads/src/sys_api_td.c 1 >>> instrument/JarFacade.c 1 >>> java/io/canonicalize_md.c 2 >>> java/io/io_util_md.h 8 >>> java/lang/Class.c 1 >>> java/lang/ClassLoader.c 2 >>> java/lang/fdlibm/include/fdlibm.h 1 >>> java/lang/fdlibm/src/e_jn.c 1 >>> java/lang/fdlibm/src/e_pow.c 1 >>> java/lang/fdlibm/src/e_sqrt.c 1 >>> java/lang/fdlibm/src/s_ceil.c 1 >>> java/lang/fdlibm/src/s_floor.c 1 >>> java/lang/fdlibm/src/s_log1p.c 1 >>> java/lang/java_props_md.c 3 >>> java/lang/reflect/Proxy.c 1 >>> java/net/Inet4AddressImpl.c 2 >>> java/net/Inet6AddressImpl.c 3 >>> java/net/NetworkInterface.c 1 >>> java/net/PlainDatagramSocketImpl.c 6 >>> java/net/linux_close.c 3 >>> java/net/net_util_md.c 2 >>> java/nio/Bits.c 8 >>> java/nio/MappedByteBuffer.c 1 >>> java/util/zip/zip_util.c 1 >>> java/util/zip/zlib-1.1.3/inftrees.c 3 >>> javavm/include/typedefs.h 8 >>> javax/swing/JColorChooser.java 1 >>> javax/swing/JComponent.java 4 >>> javax/swing/JInternalFrame.java 2 >>> javax/swing/JList.java 4 >>> javax/swing/JPopupMenu.java 1 >>> javax/swing/JTabbedPane.java 1 >>> javax/swing/JTable.java 5 >>> javax/swing/JTree.java 4 >>> javax/swing/text/JTextComponent.java 3 >>> sun/awt/awt_DrawingSurface.c 1 >>> sun/awt/awt_Font.c 1 >>> sun/awt/awt_GraphicsEnv.c 1 >>> sun/awt/awt_InputMethod.c 11 >>> sun/awt/awt_LoadLibrary.c 2 >>> sun/awt/awt_UNIXToolkit.c 1 >>> sun/awt/giflib/dgif_lib.c 16 >>> sun/awt/image/BufImgSurfaceData.c 1 >>> sun/awt/image/jpeg/imageioJPEG.c 19 >>> sun/awt/image/jpeg/jpegdecoder.c 1 >>> sun/awt/java2d/loops/ByteBinary1Bit.c 5 >>> sun/awt/java2d/loops/ByteBinary2Bit.c 5 >>> sun/awt/java2d/loops/ByteBinary4Bit.c 5 >>> sun/awt/java2d/loops/ByteGray.c 2 >>> sun/awt/java2d/loops/ByteIndexed.c 6 >>> sun/awt/java2d/loops/FourByteAbgr.c 2 >>> sun/awt/java2d/loops/FourByteAbgrPre.c 2 >>> sun/awt/java2d/loops/Index12Gray.c 2 >>> sun/awt/java2d/loops/Index8Gray.c 2 >>> sun/awt/java2d/loops/IntArgb.c 6 >>> sun/awt/java2d/loops/IntArgbBm.c 5 >>> sun/awt/java2d/loops/IntArgbPre.c 6 >>> sun/awt/java2d/loops/IntBgr.c 2 >>> sun/awt/java2d/loops/IntRgb.c 2 >>> sun/awt/java2d/loops/IntRgbx.c 2 >>> sun/awt/java2d/loops/ThreeByteBgr.c 2 >>> sun/awt/java2d/loops/TransformHelper.c 3 >>> sun/awt/java2d/loops/Ushort555Rgb.c 2 >>> sun/awt/java2d/loops/Ushort565Rgb.c 2 >>> sun/awt/java2d/loops/UshortGray.c 2 >>> sun/awt/java2d/loops/UshortIndexed.c 6 >>> sun/awt/java2d/pipe/Region.c 1 >>> sun/awt/libpng/pngread.c 1 >>> sun/awt/libpng/pngrtran.c 1 >>> sun/awt/libpng/pngrutil.c 1 >>> sun/awt/libpng/pngwrite.c 1 >>> sun/awt/medialib/mlib_ImageAffine.c 7 >>> sun/awt/medialib/mlib_ImageAffineEdge.c 34 >>> sun/awt/medialib/mlib_ImageColorTrue2Index.c 10 >>> sun/awt/medialib/mlib_ImageConvMxN.c 9 >>> sun/awt/medialib/mlib_ImageConv_16ext.c 4 >>> sun/awt/medialib/mlib_ImageConv_16nw.c 3 >>> sun/awt/medialib/mlib_ImageConv_32nw.c 2 >>> sun/awt/medialib/mlib_ImageConv_8ext.c 4 >>> sun/awt/medialib/mlib_ImageConv_8nw.c 3 >>> sun/awt/medialib/mlib_ImageConv_D64nw.c 2 >>> sun/awt/medialib/mlib_ImageConv_F32nw.c 1 >>> sun/awt/medialib/mlib_ImageConv_u16ext.c 4 >>> sun/awt/medialib/mlib_ImageConv_u16nw.c 3 >>> sun/awt/medialib/mlib_ImageCopy_Bit.c 4 >>> sun/awt/medialib/mlib_ImageCreate.c 2 >>> sun/awt/splashscreen/splashscreen_gfx_impl.c 2 >>> sun/font/DrawGlyphList.c 5 >>> sun/font/X11FontScaler.c 7 >>> sun/font/layout/LEGlyphStorage.h 32 >>> sun/font/layout/LEInsertionList.h 33 >>> sun/font/layout/MorphTables.cpp 1 >>> sun/java2d/cmm/lcms/LCMS.c 2 >>> sun/java2d/cmm/lcms/cmscgats.c 2 >>> sun/java2d/cmm/lcms/cmsio1.c 2 >>> sun/java2d/cmm/lcms/cmslut.c 4 >>> sun/java2d/cmm/lcms/cmswtpnt.c 1 >>> sun/java2d/x11/X11PMBlitLoops.c 2 >>> sun/java2d/x11/X11Renderer.c 45 >>> sun/java2d/x11/X11SurfaceData.c 10 >>> sun/java2d/x11/X11TextRenderer_md.c 1 >>> sun/net/spi/DefaultProxySelector.c 1 >>> sun/nio/ch/DatagramChannelImpl.c 1 >>> sun/nio/ch/InheritedChannel.c 1 >>> sun/nio/ch/Net.c 2 >>> sun/nio/ch/ServerSocketChannelImpl.c 1 >>> sun/nio/ch/SocketChannelImpl.c 1 >>> sun/rmi/rmic/Main.java 1 >>> sun/rmi/rmic/newrmic/Resources.java 1 >>> sun/security/jgss/wrapper/GSSLibStub.c 63 >>> sun/security/jgss/wrapper/NativeUtil.c 2 >>> sun/security/pkcs11/j2secmod_md.c 3 >>> sun/security/pkcs11/wrapper/p11_crypt.c 6 >>> sun/security/pkcs11/wrapper/p11_digest.c 1 >>> sun/security/pkcs11/wrapper/p11_keymgmt.c 1 >>> sun/security/pkcs11/wrapper/p11_md.c 1 >>> sun/security/pkcs11/wrapper/p11_sign.c 3 >>> sun/security/pkcs11/wrapper/p11_util.c 2 >>> sun/tools/serialver/SerialVer.java 1 >>> sun/tracing/dtrace/JVM.c 1 >>> sun/xawt/XToolkit.c 2 >>> sun/xawt/XWindow.c 4 >>> sun/xawt/awt_Desktop.c 1 >>> transport/socket/socket_md.c 3 >>> unpack.cpp 1 >>> ~NONE~ 5 >>> >>> >>> Warning counts, sorted by frequency of location >>> >>> 1928 com/sun/java/util/jar/pack/coding.cpp >>> 63 sun/security/jgss/wrapper/GSSLibStub.c >>> 45 sun/java2d/x11/X11Renderer.c >>> 34 sun/awt/medialib/mlib_ImageAffineEdge.c >>> 33 sun/font/layout/LEInsertionList.h >>> 32 com/sun/java/util/jar/pack/unpack.cpp >>> 32 sun/font/layout/LEGlyphStorage.h >>> 24 com/sun/java/util/jar/pack/unpack.h >>> 23 build/tools/javazic/Gen.java >>> 19 sun/awt/image/jpeg/imageioJPEG.c >>> 16 sun/awt/giflib/dgif_lib.c >>> 11 sun/awt/awt_InputMethod.c >>> 10 sun/awt/medialib/mlib_ImageColorTrue2Index.c >>> 10 sun/java2d/x11/X11SurfaceData.c >>> 9 common/check_code.c >>> 9 sun/awt/medialib/mlib_ImageConvMxN.c >>> 8 back/outStream.c >>> 8 java/io/io_util_md.h >>> 8 java/nio/Bits.c >>> 8 javavm/include/typedefs.h >>> 7 build/tools/javazic/Time.java >>> 7 sun/awt/medialib/mlib_ImageAffine.c >>> 7 sun/font/X11FontScaler.c >>> 6 java/net/PlainDatagramSocketImpl.c >>> 6 sun/awt/java2d/loops/ByteIndexed.c >>> 6 sun/awt/java2d/loops/IntArgb.c >>> 6 sun/awt/java2d/loops/IntArgbPre.c >>> 6 sun/awt/java2d/loops/UshortIndexed.c >>> 6 sun/security/pkcs11/wrapper/p11_crypt.c >>> 5 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c >>> 5 javax/swing/JTable.java >>> 5 sun/awt/java2d/loops/ByteBinary1Bit.c >>> 5 sun/awt/java2d/loops/ByteBinary2Bit.c >>> 5 sun/awt/java2d/loops/ByteBinary4Bit.c >>> 5 sun/awt/java2d/loops/IntArgbBm.c >>> 5 sun/font/DrawGlyphList.c >>> 5 ~NONE~ >>> 4 back/inStream.c >>> 4 back/stream.c >>> 4 build/tools/compilefontconfig/CompileFontConfig.java >>> 4 javax/swing/JComponent.java >>> 4 javax/swing/JList.java >>> 4 javax/swing/JTree.java >>> 4 sun/awt/medialib/mlib_ImageConv_16ext.c >>> 4 sun/awt/medialib/mlib_ImageConv_8ext.c >>> 4 sun/awt/medialib/mlib_ImageConv_u16ext.c >>> 4 sun/awt/medialib/mlib_ImageCopy_Bit.c >>> 4 sun/java2d/cmm/lcms/cmslut.c >>> 4 sun/xawt/XWindow.c >>> 3 >>> build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java >>> 3 java/lang/java_props_md.c >>> 3 java/net/Inet6AddressImpl.c >>> 3 java/net/linux_close.c >>> 3 java/util/zip/zlib-1.1.3/inftrees.c >>> 3 javax/swing/text/JTextComponent.java >>> 3 sun/awt/java2d/loops/TransformHelper.c >>> 3 sun/awt/medialib/mlib_ImageConv_16nw.c >>> 3 sun/awt/medialib/mlib_ImageConv_8nw.c >>> 3 sun/awt/medialib/mlib_ImageConv_u16nw.c >>> 3 sun/security/pkcs11/j2secmod_md.c >>> 3 sun/security/pkcs11/wrapper/p11_sign.c >>> 3 transport/socket/socket_md.c >>> 2 /usr/include/sys/param.h >>> 2 build/tools/dtdbuilder/DTDParser.java >>> 2 build/tools/fontchecker/FontChecker.java >>> 2 build/tools/javazic/GenDoc.java >>> 2 com/sun/java/util/jar/pack/bands.cpp >>> 2 com/sun/java/util/jar/pack/utils.cpp >>> 2 democlasses/demo/jvmti/waiters/src/waiters.cpp >>> 2 java/io/canonicalize_md.c >>> 2 java/lang/ClassLoader.c >>> 2 java/net/Inet4AddressImpl.c >>> 2 java/net/net_util_md.c >>> 2 javax/swing/JInternalFrame.java >>> 2 sun/awt/awt_LoadLibrary.c >>> 2 sun/awt/java2d/loops/ByteGray.c >>> 2 sun/awt/java2d/loops/FourByteAbgr.c >>> 2 sun/awt/java2d/loops/FourByteAbgrPre.c >>> 2 sun/awt/java2d/loops/Index12Gray.c >>> 2 sun/awt/java2d/loops/Index8Gray.c >>> 2 sun/awt/java2d/loops/IntBgr.c >>> 2 sun/awt/java2d/loops/IntRgb.c >>> 2 sun/awt/java2d/loops/IntRgbx.c >>> 2 sun/awt/java2d/loops/ThreeByteBgr.c >>> 2 sun/awt/java2d/loops/Ushort555Rgb.c >>> 2 sun/awt/java2d/loops/Ushort565Rgb.c >>> 2 sun/awt/java2d/loops/UshortGray.c >>> 2 sun/awt/medialib/mlib_ImageConv_32nw.c >>> 2 sun/awt/medialib/mlib_ImageConv_D64nw.c >>> 2 sun/awt/medialib/mlib_ImageCreate.c >>> 2 sun/awt/splashscreen/splashscreen_gfx_impl.c >>> 2 sun/java2d/cmm/lcms/LCMS.c >>> 2 sun/java2d/cmm/lcms/cmscgats.c >>> 2 sun/java2d/cmm/lcms/cmsio1.c >>> 2 sun/java2d/x11/X11PMBlitLoops.c >>> 2 sun/nio/ch/Net.c >>> 2 sun/security/jgss/wrapper/NativeUtil.c >>> 2 sun/security/pkcs11/wrapper/p11_util.c >>> 2 sun/xawt/XToolkit.c >>> 1 /usr/include/X11/IntrinsicP.h >>> 1 /usr/include/langinfo.h >>> 1 /usr/include/sys/cdefs.h >>> 1 back/ArrayTypeImpl.c >>> 1 bin/jexec.c >>> 1 bin/parse_manifest.c >>> 1 com/sun/java/util/jar/pack/main.cpp >>> 1 com/sun/java/util/jar/pack/zip.cpp >>> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_MidiUtils.c >>> 1 com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c >>> 1 common/check_format.c >>> 1 demo/jvmti/hprof/hprof_init.c >>> 1 democlasses/demo/jvmti/hprof/src/hprof_init.c >>> 1 democlasses/demo/jvmti/waiters/src/Agent.cpp >>> 1 hpi/native_threads/src/sys_api_td.c >>> 1 instrument/JarFacade.c >>> 1 java/lang/Class.c >>> 1 java/lang/fdlibm/include/fdlibm.h >>> 1 java/lang/fdlibm/src/e_jn.c >>> 1 java/lang/fdlibm/src/e_pow.c >>> 1 java/lang/fdlibm/src/e_sqrt.c >>> 1 java/lang/fdlibm/src/s_ceil.c >>> 1 java/lang/fdlibm/src/s_floor.c >>> 1 java/lang/fdlibm/src/s_log1p.c >>> 1 java/lang/reflect/Proxy.c >>> 1 java/net/NetworkInterface.c >>> 1 java/nio/MappedByteBuffer.c >>> 1 java/util/zip/zip_util.c >>> 1 javax/swing/JColorChooser.java >>> 1 javax/swing/JPopupMenu.java >>> 1 javax/swing/JTabbedPane.java >>> 1 sun/awt/awt_DrawingSurface.c >>> 1 sun/awt/awt_Font.c >>> 1 sun/awt/awt_GraphicsEnv.c >>> 1 sun/awt/awt_UNIXToolkit.c >>> 1 sun/awt/image/BufImgSurfaceData.c >>> 1 sun/awt/image/jpeg/jpegdecoder.c >>> 1 sun/awt/java2d/pipe/Region.c >>> 1 sun/awt/libpng/pngread.c >>> 1 sun/awt/libpng/pngrtran.c >>> 1 sun/awt/libpng/pngrutil.c >>> 1 sun/awt/libpng/pngwrite.c >>> 1 sun/awt/medialib/mlib_ImageConv_F32nw.c >>> 1 sun/font/layout/MorphTables.cpp >>> 1 sun/java2d/cmm/lcms/cmswtpnt.c >>> 1 sun/java2d/x11/X11TextRenderer_md.c >>> 1 sun/net/spi/DefaultProxySelector.c >>> 1 sun/nio/ch/DatagramChannelImpl.c >>> 1 sun/nio/ch/InheritedChannel.c >>> 1 sun/nio/ch/ServerSocketChannelImpl.c >>> 1 sun/nio/ch/SocketChannelImpl.c >>> 1 sun/rmi/rmic/Main.java >>> 1 sun/rmi/rmic/newrmic/Resources.java >>> 1 sun/security/pkcs11/wrapper/p11_digest.c >>> 1 sun/security/pkcs11/wrapper/p11_keymgmt.c >>> 1 sun/security/pkcs11/wrapper/p11_md.c >>> 1 sun/tools/serialver/SerialVer.java >>> 1 sun/tracing/dtrace/JVM.c >>> 1 sun/xawt/awt_Desktop.c >>> 1 unpack.cpp >>> >>> >>> Warning counts, sorted alphabetically by location directory >>> >>> /usr/include 1 >>> /usr/include/X11 1 >>> /usr/include/sys 3 >>> back 17 >>> bin 2 >>> build/tools/compilefontconfig 4 >>> build/tools/dtdbuilder 2 >>> build/tools/fontchecker 2 >>> build/tools/generatebreakiteratordata 3 >>> build/tools/javazic 32 >>> com/sun/java/util/jar/pack 1990 >>> com/sun/media/sound 7 >>> common 10 >>> demo/jvmti/hprof 1 >>> democlasses/demo/jvmti/hprof/src 1 >>> democlasses/demo/jvmti/waiters/src 3 >>> hpi/native_threads/src 1 >>> instrument 1 >>> java/io 10 >>> java/lang 6 >>> java/lang/fdlibm/include 1 >>> java/lang/fdlibm/src 6 >>> java/lang/reflect 1 >>> java/net 17 >>> java/nio 9 >>> java/util/zip 1 >>> java/util/zip/zlib-1.1.3 3 >>> javavm/include 8 >>> javax/swing 22 >>> javax/swing/text 3 >>> sun/awt 17 >>> sun/awt/giflib 16 >>> sun/awt/image 1 >>> sun/awt/image/jpeg 20 >>> sun/awt/java2d/loops 71 >>> sun/awt/java2d/pipe 1 >>> sun/awt/libpng 4 >>> sun/awt/medialib 92 >>> sun/awt/splashscreen 2 >>> sun/font 12 >>> sun/font/layout 66 >>> sun/java2d/cmm/lcms 11 >>> sun/java2d/x11 58 >>> sun/net/spi 1 >>> sun/nio/ch 6 >>> sun/rmi/rmic 1 >>> sun/rmi/rmic/newrmic 1 >>> sun/security/jgss/wrapper 65 >>> sun/security/pkcs11 3 >>> sun/security/pkcs11/wrapper 14 >>> sun/tools/serialver 1 >>> sun/tracing/dtrace 1 >>> sun/xawt 7 >>> transport/socket 3 >>> unpack.cpp 1 >>> ~NONE~ 5 >>> >>> >>> Warning counts, sorted by frequency of location >>> >>> 1990 com/sun/java/util/jar/pack >>> 92 sun/awt/medialib >>> 71 sun/awt/java2d/loops >>> 66 sun/font/layout >>> 65 sun/security/jgss/wrapper >>> 58 sun/java2d/x11 >>> 32 build/tools/javazic >>> 22 javax/swing >>> 20 sun/awt/image/jpeg >>> 17 back >>> 17 java/net >>> 17 sun/awt >>> 16 sun/awt/giflib >>> 14 sun/security/pkcs11/wrapper >>> 12 sun/font >>> 11 sun/java2d/cmm/lcms >>> 10 common >>> 10 java/io >>> 9 java/nio >>> 8 javavm/include >>> 7 com/sun/media/sound >>> 7 sun/xawt >>> 6 java/lang >>> 6 java/lang/fdlibm/src >>> 6 sun/nio/ch >>> 5 ~NONE~ >>> 4 build/tools/compilefontconfig >>> 4 sun/awt/libpng >>> 3 /usr/include/sys >>> 3 build/tools/generatebreakiteratordata >>> 3 democlasses/demo/jvmti/waiters/src >>> 3 java/util/zip/zlib-1.1.3 >>> 3 javax/swing/text >>> 3 sun/security/pkcs11 >>> 3 transport/socket >>> 2 bin >>> 2 build/tools/dtdbuilder >>> 2 build/tools/fontchecker >>> 2 sun/awt/splashscreen >>> 1 /usr/include >>> 1 /usr/include/X11 >>> 1 demo/jvmti/hprof >>> 1 democlasses/demo/jvmti/hprof/src >>> 1 hpi/native_threads/src >>> 1 instrument >>> 1 java/lang/fdlibm/include >>> 1 java/lang/reflect >>> 1 java/util/zip >>> 1 sun/awt/image >>> 1 sun/awt/java2d/pipe >>> 1 sun/net/spi >>> 1 sun/rmi/rmic >>> 1 sun/rmi/rmic/newrmic >>> 1 sun/tools/serialver >>> 1 sun/tracing/dtrace >>> 1 unpack.cpp >>> >>> >>> Warning counts, sorted alphabetically by location extension >>> >>> .c 474 >>> .cpp 61 >>> .h 12 >>> .java 68 >>> ~NONE~ 2 >>> >>> >>> Warning counts, sorted by frequency of location extension >>> >>> 474 .c >>> 68 .java >>> 61 .cpp >>> 12 .h >>> 2 ~NONE~ >>> >>> >>> Warning counts, sorted alphabetically by type >>> >>> "*" redefined 13 >>> '*' may be used uninitialized in this function 126 >>> 'class *' has virtual functions but non-virtual destructor 65 >>> 'static' is not at beginning of declaration 2 >>> argument '*' might be clobbered by '*' 1 >>> assignment from incompatible pointer type 1 >>> assignment makes integer from pointer without a cast 1 >>> cast from pointer to integer of different size 22 >>> cast to java.lang.Object[] for a non-varargs call and to suppress >>> this warning 4 >>> cast to pointer from integer of different size 137 >>> comparison between pointer and integer 3 >>> comparison between signed and unsigned 106 >>> comparison is always false due to limited range of data type 2 >>> constant is too large for*type 18 >>> control reaches end of non-void function 1 >>> dereferencing type-punned pointer will break strict-aliasing rules 4 >>> enumeration value * not handled in switch 101 >>> format '*' expects type '*', but argument * has type '*' 12 >>> implicit declaration of function 3 >>> is Sun proprietary API and may be removed in a future release 67 >>> missing braces around initializer 2 >>> missing initializer 1 >>> missing initializer for member 1874 >>> non-varargs call of varargs method with inexact argument type for >>> last parameter 4 >>> package * does not exist 1 >>> passing * from incompatible pointer type 3 >>> pointer targets * differ in signedness 32 >>> return makes integer from pointer without a cast 5 >>> signed and unsigned type in conditional expression 16 >>> the use of `*' is dangerous 1 >>> this is the location of the previous definition 13 >>> type defaults to * in declaration 2 >>> variable '*' might be clobbered by '*' 4 >>> ~UNKNOWN~ 1 >>> >>> >>> Warning counts, sorted by frequency of type >>> >>> 1874 missing initializer for member >>> 137 cast to pointer from integer of different size >>> 126 '*' may be used uninitialized in this function >>> 106 comparison between signed and unsigned >>> 101 enumeration value * not handled in switch >>> 67 is Sun proprietary API and may be removed in a future release >>> 65 'class *' has virtual functions but non-virtual destructor >>> 32 pointer targets * differ in signedness >>> 22 cast from pointer to integer of different size >>> 18 constant is too large for*type >>> 16 signed and unsigned type in conditional expression >>> 13 "*" redefined >>> 13 this is the location of the previous definition >>> 12 format '*' expects type '*', but argument * has type '*' >>> 5 return makes integer from pointer without a cast >>> 4 cast to java.lang.Object[] for a non-varargs call and to >>> suppress this warning >>> 4 dereferencing type-punned pointer will break strict-aliasing rules >>> 4 non-varargs call of varargs method with inexact argument type >>> for last parameter >>> 4 variable '*' might be clobbered by '*' >>> 3 comparison between pointer and integer >>> 3 implicit declaration of function >>> 3 passing * from incompatible pointer type >>> 2 'static' is not at beginning of declaration >>> 2 comparison is always false due to limited range of data type >>> 2 missing braces around initializer >>> 2 type defaults to * in declaration >>> 1 argument '*' might be clobbered by '*' >>> 1 assignment from incompatible pointer type >>> 1 assignment makes integer from pointer without a cast >>> 1 control reaches end of non-void function >>> 1 missing initializer >>> 1 package * does not exist >>> 1 the use of `*' is dangerous >>> 1 ~UNKNOWN~ >>> >>> >>> Warnings with unrecognized types >>> >>> * ../../../src/solaris/native/java/lang/java_props_md.c:124: >>> warning: (near initialization for 'sprops.os_version') >>> >>> ------------------------------------------------------------------------ >>> Generated on Sun Jul 13 17:36:12 PDT 2008 > From xiomara.jayasena at sun.com Tue Jul 15 17:54:04 2008 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 16 Jul 2008 00:54:04 +0000 Subject: hg: jdk7/build/hotspot: 38 new changesets Message-ID: <20080716005516.84796D1A4@hg.openjdk.java.net> Changeset: 6470a2a42f92 Author: xlu Date: 2008-06-10 16:39 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/6470a2a42f92 6647068: libjvm.so is not built PIC Summary: Remove the preferred base address built with libjvm.so and unified the PIC approach on Solaris & Linux. Reviewed-by: never, kamg Contributed-by: xiaobin.lu at sun.com ! make/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/rules.make ! make/solaris/makefiles/rules.make Changeset: f139919897d2 Author: xlu Date: 2008-06-17 09:59 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/f139919897d2 6681796: hotspot build failure on gcc 4.2.x (ubuntu 8.04) w/ openjdk 6 Summary: Fixed the cast from char* to const char* and tried to use const char* as much as possible Reviewed-by: never, kamg Contributed-by: xiaobin.lu at sun.com ! src/os/linux/vm/jvm_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 66cdb30329a6 Author: blacklion Date: 2008-06-19 06:02 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/66cdb30329a6 Merge Changeset: 86658812ca35 Author: ohair Date: 2008-06-13 14:52 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/86658812ca35 6714043: Minor fix to SS12 makefile changes Reviewed-by: sspitsyn ! make/solaris/makefiles/jvmg.make Changeset: 81675a0d3c75 Author: ohair Date: 2008-06-13 14:53 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/81675a0d3c75 Merge Changeset: 05d7b04bda37 Author: dcubed Date: 2008-06-14 21:53 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/05d7b04bda37 Merge Changeset: d6c28083ace6 Author: dcubed Date: 2008-06-16 13:38 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/d6c28083ace6 Merge Changeset: dfedd0e7fa9c Author: dcubed Date: 2008-06-17 09:33 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/dfedd0e7fa9c Merge Changeset: f20b3fcbb16f Author: dcubed Date: 2008-06-19 09:59 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/f20b3fcbb16f Merge Changeset: e619218327a7 Author: trims Date: 2008-06-20 11:47 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/e619218327a7 6717462: Update build number for HS14 B01 Summary: Change Hotspot version and build number for opening of HS14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 35ca13d63fe8 Author: jmasa Date: 2008-06-10 07:26 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/35ca13d63fe8 6688799: Second fix for Guarantee failure "Unexpected dirty card found" Summary: Expand cardtable without committing over existing regions. Reviewed-by: apetrusenko ! src/share/vm/memory/cardTableModRefBS.cpp Changeset: 4fab66d72627 Author: jmasa Date: 2008-06-12 14:23 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/4fab66d72627 Merge Changeset: 05712c37c828 Author: jcoomes Date: 2008-06-18 18:36 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/05712c37c828 6676016: ParallelOldGC leaks memory Summary: ensure that GCTask threads release resource and handle memory Reviewed-by: jmasa, chrisphi ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Changeset: 337e0e51cd6b Author: jcoomes Date: 2008-06-20 13:59 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/337e0e51cd6b Merge Changeset: 99bf1609e2a5 Author: never Date: 2008-06-12 09:47 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/99bf1609e2a5 6697236: missing Identity for "(X+Y) - X" into Y Reviewed-by: kvn ! src/share/vm/opto/subnode.cpp Changeset: 8b48a7bd2bf7 Author: never Date: 2008-06-12 16:13 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/8b48a7bd2bf7 6697238: missing dependencies for precompiled headers with platform dependent includes Reviewed-by: kvn ! src/share/tools/MakeDeps/Database.java Changeset: ffcffaaeb97b Author: never Date: 2008-06-17 11:32 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/ffcffaaeb97b Merge Changeset: 273eaa04d9a1 Author: kvn Date: 2008-06-20 10:17 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/273eaa04d9a1 6714694: assertion in 64bit server vm (store->find_edge(load) != -1,"missing precedence edge") with COOPs Summary: The method raise_LCA_above_marks() terminates LCA search early. Reviewed-by: rasbold, never ! src/share/vm/opto/gcm.cpp + test/compiler/6714694/Tester.java Changeset: 8d191a7697e2 Author: kvn Date: 2008-06-20 11:10 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/8d191a7697e2 6715633: when matching a memory node the adr_type should not change Summary: verify the adr_type of a mach node was not changed Reviewed-by: rasbold, never ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp Changeset: 411c61adc994 Author: never Date: 2008-06-21 10:03 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/411c61adc994 Merge Changeset: a5838065ab24 Author: swamyv Date: 2008-06-24 21:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/a5838065ab24 6620329: jstack prints double native methods on Solaris/sparc Summary: Fixed stack walking code in sparc to start frame walk from last_java_sp. Reviewed-by: sgoldman ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/solaris_sparc/SolarisSPARCJavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCFrame.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java Changeset: ab65a4c9b2e8 Author: kvn Date: 2008-06-23 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/ab65a4c9b2e8 6708714: Optimize long LShift on 32-bits x86 Summary: For small (1-3 bits) left long shifts in 32-bits VM use sets of add+addc instructions instead of shld+shl on new AMD cpus. Reviewed-by: never Contributed-by: shrinivas.joshi at amd.com ! src/cpu/x86/vm/vm_version_x86_32.cpp ! src/cpu/x86/vm/x86_32.ad ! src/share/vm/runtime/globals.hpp Changeset: 30369db7f5d2 Author: never Date: 2008-06-23 18:21 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/30369db7f5d2 6604014: add support for ideal graph visualizer Reviewed-by: kvn, jrose + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/removeall.gif + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/save.gif + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/saveall.gif + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/structure.gif + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/structured.gif + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/layer.xml + src/share/tools/IdealGraphVisualizer/Data/build.xml + src/share/tools/IdealGraphVisualizer/Data/manifest.mf + src/share/tools/IdealGraphVisualizer/Data/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/Data/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/Data/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/Data/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/Data/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/Data/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/Bundle.properties + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/ChangedEvent.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/ChangedEventProvider.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/ChangedListener.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/Event.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/GraphDocument.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/Group.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputBlock.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputBlockEdge.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputBytecode.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputEdge.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputGraph.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputMethod.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputNode.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/Pair.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/Properties.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/Property.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Printer.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLParser.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLWriter.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/services/GraphViewer.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/services/GroupCallback.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/services/GroupOrganizer.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/services/GroupReceiver.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/services/InputGraphProvider.java + src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/services/Scheduler.java + src/share/tools/IdealGraphVisualizer/Difference/build.xml + src/share/tools/IdealGraphVisualizer/Difference/manifest.mf + src/share/tools/IdealGraphVisualizer/Difference/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/Difference/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/Difference/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/Difference/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/Difference/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/Difference/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/Difference/src/com/sun/hotspot/igv/difference/Bundle.properties + src/share/tools/IdealGraphVisualizer/Difference/src/com/sun/hotspot/igv/difference/Difference.java + src/share/tools/IdealGraphVisualizer/Filter/build.xml + src/share/tools/IdealGraphVisualizer/Filter/manifest.mf + src/share/tools/IdealGraphVisualizer/Filter/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/Filter/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/Filter/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/Filter/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/Filter/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/Filter/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/Filter/src/META-INF/services/com.sun.hotspot.igv.filter.ScriptEngineAbstraction + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/AbstractFilter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/Bundle.properties + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/ColorFilter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/CombineFilter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/ConnectionFilter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/CustomFilter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/EditFilterDialog.form + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/EditFilterDialog.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/Filter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/FilterChain.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/FilterChainProvider.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/FilterSetting.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/JavaSE6ScriptEngine.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/NullScriptEngine.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/RemoveFilter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/RemoveInputsFilter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/RemoveSelfLoopsFilter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/ScriptEngineAbstraction.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/SplitFilter.java + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/helper.js + src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/layer.xml + src/share/tools/IdealGraphVisualizer/FilterWindow/build.xml + src/share/tools/IdealGraphVisualizer/FilterWindow/manifest.mf + src/share/tools/IdealGraphVisualizer/FilterWindow/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/FilterWindow/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/FilterWindow/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/FilterWindow/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/FilterWindow/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/FilterWindow/src/META-INF/services/com.sun.hotspot.igv.filter.FilterChainProvider + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/Bundle.properties + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/CheckListView.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/CheckNode.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/CheckNodeListModel.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/CheckRenderer.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/FilterChainProviderImplementation.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/FilterNode.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/FilterTopComponent.form + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/FilterTopComponent.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/FilterTopComponentSettings.xml + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/FilterTopComponentWstcref.xml + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/actions/Bundle.properties + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/actions/FilterAction.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/actions/MoveFilterDownAction.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/actions/MoveFilterUpAction.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/actions/NewFilterAction.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/actions/RemoveFilterAction.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/actions/RemoveFilterSettingsAction.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/actions/SaveFilterSettingsAction.java + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/customRightTopWsmode.xml + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/images/add.gif + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/images/delete.gif + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/images/down.gif + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/images/minus.gif + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/images/plus.gif + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/images/up.gif + src/share/tools/IdealGraphVisualizer/FilterWindow/src/com/sun/hotspot/igv/filterwindow/layer.xml + src/share/tools/IdealGraphVisualizer/Graph/build.xml + src/share/tools/IdealGraphVisualizer/Graph/manifest.mf + src/share/tools/IdealGraphVisualizer/Graph/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/Graph/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/Graph/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/Graph/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/Graph/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/Graph/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/AndSelector.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Block.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Bundle.properties + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Connection.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Diagram.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Figure.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/InputSlot.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/InvertSelector.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/MatcherSelector.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/OrSelector.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/OutputSlot.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/PredecessorSelector.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Selector.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Slot.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Source.java + src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/SuccessorSelector.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/build.xml + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/manifest.mf + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/Bundle.properties + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/ClusterEdge.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/ClusterIngoingConnection.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/ClusterInputSlotNode.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/ClusterNode.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/ClusterOutgoingConnection.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/ClusterOutputSlotNode.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/Edge.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/Graph.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/HierarchicalClusterLayoutManager.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/HierarchicalLayoutManager.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/InterClusterConnection.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/Node.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/OldHierarchicalLayoutManager.java + src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/Timing.java + src/share/tools/IdealGraphVisualizer/Layout/build.xml + src/share/tools/IdealGraphVisualizer/Layout/manifest.mf + src/share/tools/IdealGraphVisualizer/Layout/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/Layout/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/Layout/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/Layout/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/Layout/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/Layout/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/Layout/src/com/sun/hotspot/igv/layout/Bundle.properties + src/share/tools/IdealGraphVisualizer/Layout/src/com/sun/hotspot/igv/layout/Cluster.java + src/share/tools/IdealGraphVisualizer/Layout/src/com/sun/hotspot/igv/layout/LayoutGraph.java + src/share/tools/IdealGraphVisualizer/Layout/src/com/sun/hotspot/igv/layout/LayoutManager.java + src/share/tools/IdealGraphVisualizer/Layout/src/com/sun/hotspot/igv/layout/Link.java + src/share/tools/IdealGraphVisualizer/Layout/src/com/sun/hotspot/igv/layout/Port.java + src/share/tools/IdealGraphVisualizer/Layout/src/com/sun/hotspot/igv/layout/Vertex.java + src/share/tools/IdealGraphVisualizer/NetworkConnection/build.xml + src/share/tools/IdealGraphVisualizer/NetworkConnection/manifest.mf + src/share/tools/IdealGraphVisualizer/NetworkConnection/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/NetworkConnection/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/NetworkConnection/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/NetworkConnection/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/NetworkConnection/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/NetworkConnection/src/META-INF/services/com.sun.hotspot.igv.data.services.GroupReceiver + src/share/tools/IdealGraphVisualizer/NetworkConnection/src/com/sun/hotspot/igv/connection/Bundle.properties + src/share/tools/IdealGraphVisualizer/NetworkConnection/src/com/sun/hotspot/igv/connection/Client.java + src/share/tools/IdealGraphVisualizer/NetworkConnection/src/com/sun/hotspot/igv/connection/Server.java + src/share/tools/IdealGraphVisualizer/NetworkConnection/src/com/sun/hotspot/igv/connection/layer.xml + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/build.xml + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/manifest.mf + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/src/META-INF/services/com.sun.hotspot.igv.filter.ScriptEngineAbstraction + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/src/com/sun/hotspot/igv/rhino/Bundle.properties + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/src/com/sun/hotspot/igv/rhino/RhinoScriptEngine.java + src/share/tools/IdealGraphVisualizer/RhinoScriptEngineProxy/src/com/sun/hotspot/igv/rhino/layer.xml + src/share/tools/IdealGraphVisualizer/ServerCompiler/build.xml + src/share/tools/IdealGraphVisualizer/ServerCompiler/manifest.mf + src/share/tools/IdealGraphVisualizer/ServerCompiler/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/ServerCompiler/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/ServerCompiler/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/ServerCompiler/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/ServerCompiler/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/ServerCompiler/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/META-INF/services/com.sun.hotspot.igv.data.services.GroupOrganizer + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/META-INF/services/com.sun.hotspot.igv.data.services.Scheduler + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/Bundle.properties + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/JavaGroupOrganizer.java + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/ServerCompilerScheduler.java + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/color.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/combine.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/difference.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/extendedColor.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/linestyle.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/matchingFlags.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/onlyControlFlow.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/register.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/remove.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/removeMemory.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/removeRootInputs.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/removeSafepointInputs.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/removeSelfLoops.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/split.filter + src/share/tools/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/layer.xml + src/share/tools/IdealGraphVisualizer/Settings/build.xml + src/share/tools/IdealGraphVisualizer/Settings/manifest.mf + src/share/tools/IdealGraphVisualizer/Settings/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/Settings/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/Settings/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/Settings/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/Settings/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/Settings/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/Settings/src/com/sun/hotspot/igv/settings/Bundle.properties + src/share/tools/IdealGraphVisualizer/Settings/src/com/sun/hotspot/igv/settings/Settings.java + src/share/tools/IdealGraphVisualizer/Settings/src/com/sun/hotspot/igv/settings/ViewOptionsCategory.java + src/share/tools/IdealGraphVisualizer/Settings/src/com/sun/hotspot/igv/settings/ViewOptionsPanelController.java + src/share/tools/IdealGraphVisualizer/Settings/src/com/sun/hotspot/igv/settings/ViewPanel.form + src/share/tools/IdealGraphVisualizer/Settings/src/com/sun/hotspot/igv/settings/ViewPanel.java + src/share/tools/IdealGraphVisualizer/Settings/src/com/sun/hotspot/igv/settings/layer.xml + src/share/tools/IdealGraphVisualizer/Settings/src/com/sun/hotspot/igv/settings/settings.gif + src/share/tools/IdealGraphVisualizer/Util/build.xml + src/share/tools/IdealGraphVisualizer/Util/manifest.mf + src/share/tools/IdealGraphVisualizer/Util/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/Util/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/Util/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/Util/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/Util/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/Util/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/BoundedZoomAction.java + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/Bundle.properties + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/ColorIcon.java + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/ContextAction.java + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/DoubleClickAction.java + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/DoubleClickHandler.java + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/ExtendedSatelliteComponent.java + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/ExtendedSelectAction.java + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/PropertiesSheet.java + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/RangeSlider.java + src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/RangeSliderModel.java + src/share/tools/IdealGraphVisualizer/View/build.xml + src/share/tools/IdealGraphVisualizer/View/manifest.mf + src/share/tools/IdealGraphVisualizer/View/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/View/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/View/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/View/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/View/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/View/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/View/src/META-INF/services/com.sun.hotspot.igv.data.services.GraphViewer + src/share/tools/IdealGraphVisualizer/View/src/META-INF/services/com.sun.hotspot.igv.data.services.InputGraphProvider + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/BoundedZoomAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/Bundle.properties + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/ConnectionAnchor.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/DiagramScene.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/DiagramViewModel.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/EditorInputGraphProvider.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/EditorTopComponent.form + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/EditorTopComponent.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/ExportCookie.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/ExtendedPanAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/ExtendedSatelliteComponent.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/FindPanel.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/GraphViewerImplementation.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/PreferenceConstants.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/SlotLayout.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/Bundle.properties + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/EnableBlockLayoutAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/ExpandPredecessorsAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/ExpandSuccessorsAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/ExportAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/ExtractAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/HideAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/MouseOverAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/NextDiagramAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/NodeFindAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/OverviewAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/PredSuccAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/PrevDiagramAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/ShowAllAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/ZoomInAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/actions/ZoomOutAction.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/blocks.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/expand.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/export.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/extract.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/hide.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/next_diagram.png + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/overview.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/predsucc.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/prev_diagram.png + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/search.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/zoomin.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/images/zoomout.gif + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/layer.xml + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/widgets/BlockWidget.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/widgets/DiagramConnectionWidget.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/widgets/FigureWidget.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/widgets/InputSlotWidget.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/widgets/LineWidget.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/widgets/MultiConnectionWidget.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/widgets/OutputSlotWidget.java + src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/widgets/SlotWidget.java + src/share/tools/IdealGraphVisualizer/branding/core/core.jar/org/netbeans/core/startup/Bundle.properties + src/share/tools/IdealGraphVisualizer/branding/core/core.jar/org/netbeans/core/startup/frame.gif + src/share/tools/IdealGraphVisualizer/branding/core/core.jar/org/netbeans/core/startup/splash.gif + src/share/tools/IdealGraphVisualizer/branding/modules/org-netbeans-core-windows.jar/org/netbeans/core/windows/view/ui/Bundle.properties + src/share/tools/IdealGraphVisualizer/build.xml + src/share/tools/IdealGraphVisualizer/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/nbproject/project.xml Changeset: 1e026f8da827 Author: kvn Date: 2008-06-24 10:43 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/1e026f8da827 6710487: More than half of JDI Regression tests hang with COOPs in -Xcomp mode Summary: Remove DecodeNNode::decode() and EncodePNode::encode() methods. Reviewed-by: rasbold, never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: 2a1a77d3458f Author: never Date: 2008-06-24 16:00 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/2a1a77d3458f 6718676: putback for 6604014 is incomplete Reviewed-by: kvn, jrose ! .hgignore ! src/os/linux/vm/hpi_linux.hpp ! src/os/solaris/vm/hpi_solaris.hpp ! src/os/windows/vm/hpi_windows.hpp + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/build.xml + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/manifest.mf + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/src/com/sun/hotspot/igv/svg/BatikSVG.java + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/src/com/sun/hotspot/igv/svg/Bundle.properties + src/share/tools/IdealGraphVisualizer/BatikSVGProxy/src/com/sun/hotspot/igv/svg/layer.xml + src/share/tools/IdealGraphVisualizer/Bytecodes/build.xml + src/share/tools/IdealGraphVisualizer/Bytecodes/manifest.mf + src/share/tools/IdealGraphVisualizer/Bytecodes/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/Bytecodes/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/Bytecodes/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/Bytecodes/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/Bytecodes/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/Bytecodes/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/Bundle.properties + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/BytecodeNode.java + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/BytecodeViewAction.java + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/BytecodeViewTopComponent.form + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/BytecodeViewTopComponent.java + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/BytecodeViewTopComponentSettings.xml + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/BytecodeViewTopComponentWstcref.xml + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/MethodNode.java + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/SelectBytecodesAction.java + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/SelectBytecodesCookie.java + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/images/bytecode.gif + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/images/link.gif + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/images/method.gif + src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/layer.xml + src/share/tools/IdealGraphVisualizer/ControlFlow/build.xml + src/share/tools/IdealGraphVisualizer/ControlFlow/manifest.mf + src/share/tools/IdealGraphVisualizer/ControlFlow/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/ControlFlow/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/ControlFlow/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/ControlFlow/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/ControlFlow/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/ControlFlow/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/BlockConnectionWidget.java + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/BlockWidget.java + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/Bundle.properties + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/ControlFlowAction.java + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/ControlFlowScene.java + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/ControlFlowTopComponent.form + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/ControlFlowTopComponent.java + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/ControlFlowTopComponentSettings.xml + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/ControlFlowTopComponentWstcref.xml + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/HierarchicalGraphLayout.java + src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/layer.xml + src/share/tools/IdealGraphVisualizer/Coordinator/build.xml + src/share/tools/IdealGraphVisualizer/Coordinator/manifest.mf + src/share/tools/IdealGraphVisualizer/Coordinator/nbproject/build-impl.xml + src/share/tools/IdealGraphVisualizer/Coordinator/nbproject/genfiles.properties + src/share/tools/IdealGraphVisualizer/Coordinator/nbproject/platform.properties + src/share/tools/IdealGraphVisualizer/Coordinator/nbproject/project.properties + src/share/tools/IdealGraphVisualizer/Coordinator/nbproject/project.xml + src/share/tools/IdealGraphVisualizer/Coordinator/nbproject/suite.properties + src/share/tools/IdealGraphVisualizer/Coordinator/src/META-INF/services/com.sun.hotspot.igv.data.services.GroupOrganizer + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/Bundle.properties + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/FolderNode.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/GraphCountGroupOrganizer.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/GraphNode.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/OutlineTopComponent.form + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/OutlineTopComponent.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/OutlineTopComponentSettings.xml + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/OutlineTopComponentWstcref.xml + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/StandardConfiguration.xml + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/StandardGroupOrganizer.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/Bundle.properties + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/DiffGraphAction.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/DiffGraphCookie.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/ImportAction.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/OutlineAction.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/RemoveAction.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/RemoveAllAction.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/RemoveCookie.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/SaveAllAction.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/SaveAsAction.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/actions/StructuredViewAction.java + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/customLeftWsmode.xml + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/diff.gif + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/folder.gif + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/graph.gif + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/import.gif + src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/images/remove.gif + src/share/tools/IdealGraphVisualizer/README ! src/share/vm/includeDB_compiler2 ! src/share/vm/oops/symbolKlass.cpp ! src/share/vm/oops/symbolOop.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/runtime/hpi.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/xmlstream.cpp Changeset: 1dd146f17531 Author: kvn Date: 2008-06-26 13:34 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/1dd146f17531 6716441: error in meet with +DoEscapeAnalysis Summary: Set instance_id to InstanceBot for InstPtr->meet(AryPtr) when types are not related. Reviewed-by: jrose, never ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp + test/compiler/6716441/Tester.java Changeset: 958ae9623fd9 Author: never Date: 2008-06-27 11:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/958ae9623fd9 Merge Changeset: 286bee59f34b Author: trims Date: 2008-06-27 19:12 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/286bee59f34b Merge Changeset: d5ba4f8aa38a Author: ksrini Date: 2008-06-17 13:08 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/d5ba4f8aa38a 6714758: hotspot: provide an entry point to the BootStrap Class loader[dholmes,acorn] Summary: adds JVM_FindClassFromBootLoader entry point, for jdk's use Reviewed-by: dholmes, acorn ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! make/solaris/makefiles/reorder_COMPILER1_i486 ! make/solaris/makefiles/reorder_COMPILER1_sparc ! make/solaris/makefiles/reorder_COMPILER2_amd64 ! make/solaris/makefiles/reorder_COMPILER2_i486 ! make/solaris/makefiles/reorder_COMPILER2_sparc ! make/solaris/makefiles/reorder_COMPILER2_sparcv9 ! make/solaris/makefiles/reorder_TIERED_amd64 ! make/solaris/makefiles/reorder_TIERED_i486 ! make/solaris/makefiles/reorder_TIERED_sparc ! make/windows/makefiles/vm.make ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: 8d852b81e775 Author: poonam Date: 2008-06-22 20:07 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/8d852b81e775 6694099: Hotspot vm_exit_out_of_memory should dump core Summary: This fix enables the generation of core file when process runs out of C-heap. Reviewed-by: sbohne ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/java.hpp ! src/share/vm/utilities/debug.cpp Changeset: f232d7d67023 Author: xlu Date: 2008-06-24 16:52 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/f232d7d67023 6717128: Using relative path for ALT_OUTPUTDIR does not work properly Summary: import the absolute output directory when launching sub make process and avoid including defs.make in rules.make Reviewed-by: kamg, kvn ! make/defs.make ! make/linux/makefiles/rules.make + make/pic.make ! make/solaris/makefiles/rules.make Changeset: 3e82d72933d0 Author: xlu Date: 2008-06-26 14:15 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/3e82d72933d0 6718830: Hotspot fails to build with gcc 4.3 Summary: Fixed linux make file and couple adlc code to meet the changes of gcc 4.3 Reviewed-by: kamg, igor ! make/linux/makefiles/gcc.make ! src/share/vm/adlc/adlc.hpp ! src/share/vm/adlc/filebuff.hpp Changeset: 444ad1c62199 Author: coleenp Date: 2008-06-27 18:19 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/444ad1c62199 Merge Changeset: 72c3e8693c9a Author: coleenp Date: 2008-07-02 15:38 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/72c3e8693c9a Merge Changeset: 551f4309f476 Author: ohair Date: 2008-07-03 10:46 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/551f4309f476 6695777: Queens.class should be built from source, not put in source repo Reviewed-by: kvn - make/linux/Queens.class ! make/linux/makefiles/buildtree.make - make/solaris/Queens.class ! make/solaris/makefiles/buildtree.make Changeset: 17c572e2697c Author: ohair Date: 2008-07-08 15:23 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/17c572e2697c 6723762: Fix shell command that gets java version (uses 2>1) Reviewed-by: pbk ! make/linux/makefiles/buildtree.make Changeset: b21425229e0b Author: ohair Date: 2008-07-08 15:46 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/b21425229e0b Merge - make/linux/Queens.class ! make/linux/makefiles/buildtree.make - make/solaris/Queens.class Changeset: 9c2ecc2ffb12 Author: trims Date: 2008-07-11 01:14 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/9c2ecc2ffb12 Merge ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! make/defs.make ! make/hotspot_version - make/linux/Queens.class ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/linux/makefiles/rules.make - make/solaris/Queens.class ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/mapfile-vers ! make/solaris/makefiles/rules.make ! make/windows/makefiles/vm.make ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/vm_version_x86_32.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/java.hpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp From ted at tedneward.com Wed Jul 16 01:21:24 2008 From: ted at tedneward.com (Ted Neward) Date: Wed, 16 Jul 2008 01:21:24 -0700 Subject: Odd question Message-ID: <025c01c8e71c$f15db550$d4191ff0$@com> Are the source (SCSL/JCL) releases of JDK 1.2, 1.3 and 1.4 still available someplace? I?d love to get my hands on them, for purely historical-interest reasons. (I don?t even care if I can build them, I just want to look at some of the implementation for background purposes, to see how the JVM evolved.) Bonus points if anybody has a source release of 1.0 and/or 1.1 they can send me (to the tune of a bottle of very nice Scotch, assuming you like such things). I can promise that this will not go beyond me personally. Ted Neward Java, .NET, XML Services Consulting, Teaching, Speaking, Writing HYPERLINK "http://www.tedneward.com"http://www.tedneward.com No virus found in this outgoing message. Checked by AVG. Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: 7/12/2008 7:40 AM -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20080716/aed3fa01/attachment.html From ted at tedneward.com Wed Jul 16 01:34:31 2008 From: ted at tedneward.com (Ted Neward) Date: Wed, 16 Jul 2008 01:34:31 -0700 Subject: Can somebody sanity-check me here? Message-ID: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> I go to HYPERLINK "http://hg.openjdk.java.net"http://hg.openjdk.java.net, and there?s about 4 billion different repositories listed there, including several variations of repositories that I thought I was already pulling: hotspot, corba, jdk, and so on. (The variations are things like jdk7/corba-gate, jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to explicitly pull these guys? Or are they somehow being brought in to the ?core? name repositories? Ted Neward Java, .NET, XML Services Consulting, Teaching, Speaking, Writing HYPERLINK "http://www.tedneward.com"http://www.tedneward.com No virus found in this outgoing message. Checked by AVG. Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: 7/12/2008 7:40 AM -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20080716/7b2d4243/attachment.html From Weijun.Wang at Sun.COM Wed Jul 16 01:53:27 2008 From: Weijun.Wang at Sun.COM (Max (Weijun) Wang) Date: Wed, 16 Jul 2008 16:53:27 +0800 Subject: Can somebody sanity-check me here? In-Reply-To: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> References: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> Message-ID: <638EE9C7-AAAF-4962-A981-ECE8DFB90B62@sun.com> The repo names has a pattern project/group/repo (repo can be empty because that's also a legal repo). You only need to grab the project=jdk7,group=jdk7 ones (there are 7 of them), which I believe are used to build the binary releases. BTW, for each group there are different paths for in and out, *-gate are for in, * for out. Max On Jul 16, 2008, at 4:34 PM, Ted Neward wrote: > I go to http://hg.openjdk.java.net, and there?s about 4 billion > different repositories listed there, including several variations > of repositories that I thought I was already pulling: hotspot, > corba, jdk, and so on. (The variations are things like jdk7/corba- > gate, jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to > explicitly pull these guys? Or are they somehow being brought in to > the ?core? name repositories? > > Ted Neward > Java, .NET, XML Services > Consulting, Teaching, Speaking, Writing > http://www.tedneward.com > > > No virus found in this outgoing message. > Checked by AVG. > Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: > 7/12/2008 7:40 AM > From Erik.Trimble at Sun.COM Wed Jul 16 02:06:55 2008 From: Erik.Trimble at Sun.COM (Erik Trimble) Date: Wed, 16 Jul 2008 02:06:55 -0700 Subject: Can somebody sanity-check me here? In-Reply-To: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> References: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> Message-ID: <487DBA2F.5080409@sun.com> Ted Neward wrote: > > I go to http://hg.openjdk.java.net, and there?s about 4 billion > different repositories listed there, including several variations of > repositories that I thought I was already pulling: hotspot, corba, > jdk, and so on. (The variations are things like jdk7/corba-gate, > jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to > explicitly pull these guys? Or are they somehow being brought in to > the ?core? name repositories? > > > > Ted Neward > > Java, .NET, XML Services > > Consulting, Teaching, Speaking, Writing > > http://www.tedneward.com > > > These are the promotion and sub-group repositories, and you don't need to explicitly pull any of them. Developer work goes into many of these, which are then run up the repo trees after testing. Work for a given repository is pushed to the corresponding *-gate repo, and then internally promoted. The latest tested build of the full JDK can always be found in the http://hg.openjdk.java.net/jdk7/jdk7 forest of repositories. -- Erik Trimble Java System Support Mailstop: usca22-123 Phone: x17195 Santa Clara, CA Timezone: US/Pacific (GMT-0800) From ted at tedneward.com Wed Jul 16 02:32:01 2008 From: ted at tedneward.com (Ted Neward) Date: Wed, 16 Jul 2008 02:32:01 -0700 Subject: Can somebody sanity-check me here? In-Reply-To: <638EE9C7-AAAF-4962-A981-ECE8DFB90B62@sun.com> References: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> <638EE9C7-AAAF-4962-A981-ECE8DFB90B62@sun.com> Message-ID: <02b401c8e726$cf52c220$6df84660$@com> So, just to be clear, I only need jdk7/jdk7, jdk7/corba, jdk7/jdk7/hotspot, jdk7/jdk7/jaxp, jdk7/jdk7/jaxws, jdk7/jdk7/jdk, and jdk7/jdk7/langtools? (Those are what I'm currently pulling, but I just wanted to make sure.) Ted Neward Java, .NET, XML Services Consulting, Teaching, Speaking, Writing http://www.tedneward.com > -----Original Message----- > From: Weijun.Wang at Sun.COM [mailto:Weijun.Wang at Sun.COM] > Sent: Wednesday, July 16, 2008 1:53 AM > To: Ted Neward > Cc: 'build-dev' > Subject: Re: Can somebody sanity-check me here? > > The repo names has a pattern > project/group/repo > (repo can be empty because that's also a legal repo). > > You only need to grab the project=jdk7,group=jdk7 ones (there are 7 > of them), which I believe are used to build the binary releases. > > BTW, for each group there are different paths for in and out, *-gate > are for in, * for out. > > Max > > On Jul 16, 2008, at 4:34 PM, Ted Neward wrote: > > > I go to http://hg.openjdk.java.net, and there?s about 4 billion > > different repositories listed there, including several variations > > of repositories that I thought I was already pulling: hotspot, > > corba, jdk, and so on. (The variations are things like jdk7/corba- > > gate, jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to > > explicitly pull these guys? Or are they somehow being brought in to > > the ?core? name repositories? > > > > Ted Neward > > Java, .NET, XML Services > > Consulting, Teaching, Speaking, Writing > > http://www.tedneward.com > > > > > > No virus found in this outgoing message. > > Checked by AVG. > > Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: > > 7/12/2008 7:40 AM > > > > No virus found in this incoming message. > Checked by AVG. > Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: > 7/12/2008 7:40 AM > No virus found in this outgoing message. Checked by AVG. Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: 7/12/2008 7:40 AM From Weijun.Wang at Sun.COM Wed Jul 16 02:39:11 2008 From: Weijun.Wang at Sun.COM (Max (Weijun) Wang) Date: Wed, 16 Jul 2008 17:39:11 +0800 Subject: Can somebody sanity-check me here? In-Reply-To: <02b401c8e726$cf52c220$6df84660$@com> References: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> <638EE9C7-AAAF-4962-A981-ECE8DFB90B62@sun.com> <02b401c8e726$cf52c220$6df84660$@com> Message-ID: Correct! On Jul 16, 2008, at 5:32 PM, Ted Neward wrote: > So, just to be clear, I only need jdk7/jdk7, jdk7/corba, jdk7/jdk7/ > hotspot, ^^^^^^^^^^ You mean jdk7/jdk7/corba, right? > jdk7/jdk7/jaxp, jdk7/jdk7/jaxws, jdk7/jdk7/jdk, and jdk7/jdk7/ > langtools? > > (Those are what I'm currently pulling, but I just wanted to make > sure.) > > Ted Neward > Java, .NET, XML Services > Consulting, Teaching, Speaking, Writing > http://www.tedneward.com > > >> -----Original Message----- >> From: Weijun.Wang at Sun.COM [mailto:Weijun.Wang at Sun.COM] >> Sent: Wednesday, July 16, 2008 1:53 AM >> To: Ted Neward >> Cc: 'build-dev' >> Subject: Re: Can somebody sanity-check me here? >> >> The repo names has a pattern >> project/group/repo >> (repo can be empty because that's also a legal repo). >> >> You only need to grab the project=jdk7,group=jdk7 ones (there are 7 >> of them), which I believe are used to build the binary releases. >> >> BTW, for each group there are different paths for in and out, *-gate >> are for in, * for out. >> >> Max >> >> On Jul 16, 2008, at 4:34 PM, Ted Neward wrote: >> >>> I go to http://hg.openjdk.java.net, and there?s about 4 billion >>> different repositories listed there, including several variations >>> of repositories that I thought I was already pulling: hotspot, >>> corba, jdk, and so on. (The variations are things like jdk7/corba- >>> gate, jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to >>> explicitly pull these guys? Or are they somehow being brought in to >>> the ?core? name repositories? >>> >>> Ted Neward >>> Java, .NET, XML Services >>> Consulting, Teaching, Speaking, Writing >>> http://www.tedneward.com >>> >>> >>> No virus found in this outgoing message. >>> Checked by AVG. >>> Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: >>> 7/12/2008 7:40 AM >>> >> >> No virus found in this incoming message. >> Checked by AVG. >> Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: >> 7/12/2008 7:40 AM >> > > No virus found in this outgoing message. > Checked by AVG. > Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: > 7/12/2008 > 7:40 AM > > From Daniel.Fuchs at Sun.COM Wed Jul 16 03:20:47 2008 From: Daniel.Fuchs at Sun.COM (Daniel Fuchs) Date: Wed, 16 Jul 2008 12:20:47 +0200 Subject: Can somebody sanity-check me here? In-Reply-To: <487DBA2F.5080409@sun.com> References: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> <487DBA2F.5080409@sun.com> Message-ID: <487DCB7F.1050402@sun.com> Hi Ted, To complete Erick's answer I believe you will find some in-depth explanation on Kelly's blog - and more particularly in these two articles: OpenJDK Mercurial Forest http://blogs.sun.com/kto/entry/openjdk_mercurial_forest and OpenJDK Mercurial Wheel (Integration Wheel of Open Life) http://blogs.sun.com/kto/entry/openjdk_mercurial_wheel To illustrate what Kelly is saying in these posts, as a JMX developper, I am pulling from http://hg.openjdk.java.net/jdk7/tl and pushing into http://hg.openjdk.java.net/jdk7/tl-gate because traditionally the JMX APIs are integrated in 'tl' The http://hg.openjdk.java.net/jdk7/tl (or http://hg.openjdk.java.net/jdk7/jdk7) are two roots for the whole forest shown in: http://blogs.sun.com/kto/entry/openjdk_mercurial_forest The http://hg.openjdk.java.net/jdk7/tl is one of the integration forests shown in http://blogs.sun.com/kto/entry/openjdk_mercurial_wheel (one of the forests shown on the circle itself) and http://hg.openjdk.java.net/jdk7/jdk7 is the "master" which sits at the center of the wheel. Each integration forest is a clone of the master sitting at the center of the wheel, and each of the integration forest may contain fixes which have not yet been integrated in the master (but will be). So if you want to work from the sources already integrated in the JDK 7 master, what you need to pull is: hg fclone http://hg.openjdk.java.net/jdk7/jdk7 By using "fclone" you will pull the whole forest shown in http://blogs.sun.com/kto/entry/openjdk_mercurial_forest Note that if you only want to work on the JDK APIs - and if you don't want to rebuild a full image of the JDK then pulling the single tree http://hg.openjdk.java.net/jdk7/jdk7/jdk might be enough. Hope this helps, -- daniel http://blogs.sun.com/jmxetc Erik Trimble wrote: > Ted Neward wrote: >> >> I go to http://hg.openjdk.java.net, and there?s about 4 billion >> different repositories listed there, including several variations of >> repositories that I thought I was already pulling: hotspot, corba, >> jdk, and so on. (The variations are things like jdk7/corba-gate, >> jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to >> explicitly pull these guys? Or are they somehow being brought in to >> the ?core? name repositories? >> >> >> >> Ted Neward >> >> Java, .NET, XML Services >> >> Consulting, Teaching, Speaking, Writing >> >> http://www.tedneward.com >> >> >> > These are the promotion and sub-group repositories, and you don't need > to explicitly pull any of them. > > Developer work goes into many of these, which are then run up the repo > trees after testing. Work for a given repository is pushed to the > corresponding *-gate repo, and then internally promoted. > > The latest tested build of the full JDK can always be found in the > http://hg.openjdk.java.net/jdk7/jdk7 forest of repositories. > From David.Herron at Sun.COM Wed Jul 16 06:02:05 2008 From: David.Herron at Sun.COM (David Herron) Date: Wed, 16 Jul 2008 06:02:05 -0700 Subject: Can somebody sanity-check me here? In-Reply-To: <02b401c8e726$cf52c220$6df84660$@com> References: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> <638EE9C7-AAAF-4962-A981-ECE8DFB90B62@sun.com> <02b401c8e726$cf52c220$6df84660$@com> Message-ID: <487DF14D.7000306@sun.com> Ted, what you actually need is the forest rooted at jdk7/jdk7 The forest will pull the rest. - David Ted Neward wrote: > So, just to be clear, I only need jdk7/jdk7, jdk7/corba, jdk7/jdk7/hotspot, > jdk7/jdk7/jaxp, jdk7/jdk7/jaxws, jdk7/jdk7/jdk, and jdk7/jdk7/langtools? > > (Those are what I'm currently pulling, but I just wanted to make sure.) > > Ted Neward > Java, .NET, XML Services > Consulting, Teaching, Speaking, Writing > http://www.tedneward.com > > > >> -----Original Message----- >> From: Weijun.Wang at Sun.COM [mailto:Weijun.Wang at Sun.COM] >> Sent: Wednesday, July 16, 2008 1:53 AM >> To: Ted Neward >> Cc: 'build-dev' >> Subject: Re: Can somebody sanity-check me here? >> >> The repo names has a pattern >> project/group/repo >> (repo can be empty because that's also a legal repo). >> >> You only need to grab the project=jdk7,group=jdk7 ones (there are 7 >> of them), which I believe are used to build the binary releases. >> >> BTW, for each group there are different paths for in and out, *-gate >> are for in, * for out. >> >> Max >> >> On Jul 16, 2008, at 4:34 PM, Ted Neward wrote: >> >> >>> I go to http://hg.openjdk.java.net, and there?s about 4 billion >>> different repositories listed there, including several variations >>> of repositories that I thought I was already pulling: hotspot, >>> corba, jdk, and so on. (The variations are things like jdk7/corba- >>> gate, jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to >>> explicitly pull these guys? Or are they somehow being brought in to >>> the ?core? name repositories? >>> >>> Ted Neward >>> Java, .NET, XML Services >>> Consulting, Teaching, Speaking, Writing >>> http://www.tedneward.com >>> >>> >>> No virus found in this outgoing message. >>> Checked by AVG. >>> Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: >>> 7/12/2008 7:40 AM >>> >>> >> No virus found in this incoming message. >> Checked by AVG. >> Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: >> 7/12/2008 7:40 AM >> >> > > No virus found in this outgoing message. > Checked by AVG. > Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: 7/12/2008 > 7:40 AM > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20080716/0ad55a71/attachment.html From Kelly.Ohair at Sun.COM Wed Jul 16 09:18:47 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Wed, 16 Jul 2008 09:18:47 -0700 Subject: Can somebody sanity-check me here? In-Reply-To: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> References: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> Message-ID: <487E1F67.4080709@sun.com> For your build changes work, the forest clone of interest is hg fclone http://hg.openjdk.java.net/jdk7/build which will include the repositories: http://hg.openjdk.java.net/jdk7/build http://hg.openjdk.java.net/jdk7/build/jdk http://hg.openjdk.java.net/jdk7/build/corba http://hg.openjdk.java.net/jdk7/build/jaxws http://hg.openjdk.java.net/jdk7/build/jaxp http://hg.openjdk.java.net/jdk7/build/hotspot http://hg.openjdk.java.net/jdk7/build/langtools Each of these have a matching "-gate" repository for doing pushes of changes, but until you are officially registered as an openjdk developer that can push changes, the "-gate" ones won't be of any interest. Each pair of forests (the pull and the "-gate" push mirror) at http://hg.openjdk.java.net/jdk7/ serves a project or team. The jdk7/build forest is specifically for build related changes. The master or official jdk7 forest is http://hg.openjdk.java.net/jdk7/jdk7 -kto Ted Neward wrote: > I go to http://hg.openjdk.java.net, and there?s about 4 billion > different repositories listed there, including several variations of > repositories that I thought I was already pulling: hotspot, corba, jdk, > and so on. (The variations are things like jdk7/corba-gate, > jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to explicitly > pull these guys? Or are they somehow being brought in to the ?core? name > repositories? > > > > Ted Neward > > Java, .NET, XML Services > > Consulting, Teaching, Speaking, Writing > > http://www.tedneward.com > > > > > No virus found in this outgoing message. > Checked by AVG. > Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: > 7/12/2008 7:40 AM > From kelly.ohair at sun.com Wed Jul 16 11:19:45 2008 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Wed, 16 Jul 2008 18:19:45 +0000 Subject: hg: jdk7/build/jdk: 6548261: Use of SE in make/common/Defs-windows.gmk Message-ID: <20080716181957.4D081D1F7@hg.openjdk.java.net> Changeset: 89d30b258517 Author: ohair Date: 2008-07-16 09:51 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/89d30b258517 6548261: Use of SE in make/common/Defs-windows.gmk Reviewed-by: darcy ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/shared/Defs.gmk From proetel at aicas.com Tue Jul 22 04:21:49 2008 From: proetel at aicas.com (Ingo Proetel) Date: Tue, 22 Jul 2008 13:21:49 +0200 Subject: Building OpenJDK on Windows Message-ID: <4885C2CD.10109@aicas.com> Hi, I'm currently trying to setup an OpenJDK build on Windows. It works until it tries to compile hotspot. It misses 'hotspot/build/windows/build.make'. The build process creates some directories but not the 'hotspot/build'. Can somebody help me with this? Cheers, Ingo This is the output I get: /usr/bin/mkdir -p s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir /usr/bin/mkdir -p s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import cd ./hotspot/make && \ make JDK_TOPDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk JDK_MAKE_SHARED_DIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk/make/common/shared EXTERNALSANITYCONTROL=true TARGET_CLASS_VERSION=5 MILESTONE=internal BUILD_NUMBER=b00 JDK_BUILD_NUMBER=b00 FULL_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=32 COOKED_BUILD_NUMBER=0 ANT_HOME="c:/Programme/apache-ant-1.7.0" ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir ALT_EXPORT_PATH=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import ALT_SLASH_JAVA=J: ALT_BOOTDIR=c:/Programme/Java/jdk1.6.0_03 ALT_LANGTOOLS_DIST=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/langtools/dist all_product make[1]: Entering directory `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' cd /cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make; \ make VM_TARGET=product generic_build2 ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir make[2]: Entering directory `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' mkdir -p s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir cd s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir; \ MAKEFLAGS= MFLAGS= nmake /NOLOGO -f s:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make \ Variant=compiler2 \ WorkSpace=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot \ BootStrapDir=c:\\Programme\\Java\\jdk1.6.0_03 \ BuildUser=proetel \ ARCH=x86 BUILDARCH=i486 Platform_arch=x86 Platform_arch_model=x86_32 JDK_MKTG_VERSION=7 JDK_MAJOR_VER=1 JDK_MINOR_VER=7 JDK_MICRO_VER=0 JDK_BUILD_NUMBER=0 JAVA_HOME=c:\\Programme\\Java\\jdk1.6.0_03 GAMMADIR=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=13.0-b02 JRE_RELEASE_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 HOTSPOT_BUILD_VERSION= product NMAKE : fatal error U1052: file 's:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make' not found Stop. make[2]: *** [generic_build2] Error 2 make[2]: Leaving directory `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' make[1]: *** [product] Error 2 make[1]: Leaving directory `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' make: *** [hotspot-build] Error 2 -- aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt From Weijun.Wang at Sun.COM Tue Jul 22 04:31:12 2008 From: Weijun.Wang at Sun.COM (Max (Weijun) Wang) Date: Tue, 22 Jul 2008 19:31:12 +0800 Subject: Building OpenJDK on Windows In-Reply-To: <4885C2CD.10109@aicas.com> References: <4885C2CD.10109@aicas.com> Message-ID: <7A9C5D17-F2A7-4C78-ACA1-37CCF1556314@sun.com> The file is moved to somewhere else. Please apply this patch: diff --git a/make/windows/makefiles/defs.make b/make/windows/ makefiles/defs.make --- a/make/windows/makefiles/defs.make +++ b/make/windows/makefiles/defs.make @@ -107,7 +107,7 @@ ABS_OUTPUTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a "$ (OUTPUTDIR)")) ABS_BOOTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a "$ (BOOTDIR)")) ABS_GAMMADIR := $(subst /,\\,$(shell /bin/cygpath -m -a "$ (GAMMADIR)")) - ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a "$(HS_BUILD_DIR)/$ (OSNAME)")/build.make + ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a "$(HS_MAKE_DIR)/$ (OSNAME)")/build.make else ABS_OUTPUTDIR := $(subst /,\\,$(shell $(CD) $(OUTPUTDIR);$(PWD))) ABS_BOOTDIR := $(subst /,\\,$(shell $(CD) $(BOOTDIR);$(PWD))) Hope this helps -Max On Jul 22, 2008, at 7:21 PM, Ingo Proetel wrote: > Hi, > > I'm currently trying to setup an OpenJDK build on Windows. > > It works until it tries to compile hotspot. It misses 'hotspot/ > build/windows/build.make'. > The build process creates some directories but not the 'hotspot/ > build'. > > Can somebody help me with this? > > Cheers, > Ingo > > This is the output I get: > /usr/bin/mkdir -p s:/Users/proetel/projects/openjdk/jdk7/tl/build/ > windows-i586/hotspot/outputdir > /usr/bin/mkdir -p s:/Users/proetel/projects/openjdk/jdk7/tl/build/ > windows-i586/hotspot/import > cd ./hotspot/make && \ > make JDK_TOPDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk > JDK_MAKE_SHARED_DIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk/ > make/common/shared EXTERNALSANITYCONTROL=true > TARGET_CLASS_VERSION=5 MILESTONE=internal BUILD_NUMBER=b00 > JDK_BUILD_NUMBER=b00 FULL_VERSION=1.7.0-internal- > proetel_2008_07_22_13_07-b00 PREVIOUS_JDK_VERSION=1.6.0 > JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 JDK_MAJOR_VERSION=1 > JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 PREVIOUS_MAJOR_VERSION=1 > PREVIOUS_MINOR_VERSION=6 PREVIOUS_MICRO_VERSION=0 > ARCH_DATA_MODEL=32 COOKED_BUILD_NUMBER=0 ANT_HOME="c:/Programme/ > apache-ant-1.7.0" ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/ > jdk7/tl/build/windows-i586/hotspot/outputdir ALT_EXPORT_PATH=s:/ > Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/ > import ALT_SLASH_JAVA=J: ALT_BOOTDIR=c:/Programme/Java/jdk1.6.0_03 > ALT_LANGTOOLS_DIST=s:/Users/proetel/projects/openjdk/jdk7/tl/build/ > windows-i586/langtools/dist all_product > make[1]: Entering directory `/cygdrive/s/Users/proetel/projects/ > openjdk/jdk7/tl/hotspot/make' > cd /cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make; \ > make VM_TARGET=product generic_build2 ALT_OUTPUTDIR=s:/Users/ > proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir > make[2]: Entering directory `/cygdrive/s/Users/proetel/projects/ > openjdk/jdk7/tl/hotspot/make' > mkdir -p s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows- > i586/hotspot/outputdir > cd s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/ > hotspot/outputdir; \ > MAKEFLAGS= MFLAGS= nmake /NOLOGO -f s:/Users/proetel/projects/ > openjdk/jdk7/tl/hotspot/build/windows/build.make \ > Variant=compiler2 \ > WorkSpace=s:\\Users\\proetel\\projects\ > \openjdk\\jdk7\\tl\\hotspot \ > BootStrapDir=c:\\Programme\\Java\\jdk1.6.0_03 \ > BuildUser=proetel \ > ARCH=x86 BUILDARCH=i486 Platform_arch=x86 > Platform_arch_model=x86_32 JDK_MKTG_VERSION=7 JDK_MAJOR_VER=1 > JDK_MINOR_VER=7 JDK_MICRO_VER=0 JDK_BUILD_NUMBER=0 JAVA_HOME=c:\ > \Programme\\Java\\jdk1.6.0_03 GAMMADIR=s:\\Users\\proetel\\projects\ > \openjdk\\jdk7\\tl\\hotspot MAKE_VERBOSE=y > HOTSPOT_RELEASE_VERSION=13.0-b02 JRE_RELEASE_VERSION=1.7.0-internal- > proetel_2008_07_22_13_07-b00 HOTSPOT_BUILD_VERSION= product > NMAKE : fatal error U1052: file 's:/Users/proetel/projects/openjdk/ > jdk7/tl/hotspot/build/windows/build.make' not found > Stop. > make[2]: *** [generic_build2] Error 2 > make[2]: Leaving directory `/cygdrive/s/Users/proetel/projects/ > openjdk/jdk7/tl/hotspot/make' > make[1]: *** [product] Error 2 > make[1]: Leaving directory `/cygdrive/s/Users/proetel/projects/ > openjdk/jdk7/tl/hotspot/make' > make: *** [hotspot-build] Error 2 > -- > aicas Allerton Interworks Computer Automated Systems GmbH > Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany > http://www.aicas.com * Tel: +49-721-663 968-0 > > USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe > Gesch?ftsf?hrer: Dr. James J. Hunt From proetel at aicas.com Tue Jul 22 05:13:30 2008 From: proetel at aicas.com (Ingo Proetel) Date: Tue, 22 Jul 2008 14:13:30 +0200 Subject: Building OpenJDK on Windows In-Reply-To: <7A9C5D17-F2A7-4C78-ACA1-37CCF1556314@sun.com> References: <4885C2CD.10109@aicas.com> <7A9C5D17-F2A7-4C78-ACA1-37CCF1556314@sun.com> Message-ID: <4885CEEA.6000003@aicas.com> Thanks that helped. Until I got here: link.exe bufferoverflowU.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib Wsock32.lib winmm.lib /nologo /machine:I386 /opt:REF /opt:ICF,8 /map /debug /subsystem:console /out:adlc.exe main.obj adlparse.obj archDesc.obj arena.obj dfa.obj dict2.obj filebuff.obj forms.obj formsopt.obj formssel.obj opcodes.obj output_c.obj output_h.obj /usr/bin/link: extra operand `user32.lib' Try `/usr/bin/link --help' for more information. NMAKE : fatal error U1077: 'C:\cygwin\bin\link.exe' : return code '0x1' Apparently the make does not use ALT_DEVTOOLS_PATH to prefix link.exe. Is there another environment variable that I should set for that? Or do I have to adjust the PATH variable? Ingo Max (Weijun) Wang wrote: > The file is moved to somewhere else. Please apply this patch: > > diff --git a/make/windows/makefiles/defs.make > b/make/windows/makefiles/defs.make > --- a/make/windows/makefiles/defs.make > +++ b/make/windows/makefiles/defs.make > @@ -107,7 +107,7 @@ > ABS_OUTPUTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a > "$(OUTPUTDIR)")) > ABS_BOOTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a > "$(BOOTDIR)")) > ABS_GAMMADIR := $(subst /,\\,$(shell /bin/cygpath -m -a > "$(GAMMADIR)")) > - ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a > "$(HS_BUILD_DIR)/$(OSNAME)")/build.make > + ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a > "$(HS_MAKE_DIR)/$(OSNAME)")/build.make > else > ABS_OUTPUTDIR := $(subst /,\\,$(shell $(CD) $(OUTPUTDIR);$(PWD))) > ABS_BOOTDIR := $(subst /,\\,$(shell $(CD) $(BOOTDIR);$(PWD))) > > > Hope this helps > > -Max > > On Jul 22, 2008, at 7:21 PM, Ingo Proetel wrote: > >> Hi, >> >> I'm currently trying to setup an OpenJDK build on Windows. >> >> It works until it tries to compile hotspot. It misses >> 'hotspot/build/windows/build.make'. >> The build process creates some directories but not the 'hotspot/build'. >> >> Can somebody help me with this? >> >> Cheers, >> Ingo >> >> This is the output I get: >> /usr/bin/mkdir -p >> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >> >> /usr/bin/mkdir -p >> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import >> >> cd ./hotspot/make && \ >> make JDK_TOPDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk >> JDK_MAKE_SHARED_DIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk/make/common/shared >> EXTERNALSANITYCONTROL=true TARGET_CLASS_VERSION=5 MILESTONE=internal >> BUILD_NUMBER=b00 JDK_BUILD_NUMBER=b00 >> FULL_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 >> PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 >> JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 >> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 >> PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=32 COOKED_BUILD_NUMBER=0 >> ANT_HOME="c:/Programme/apache-ant-1.7.0" >> ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >> ALT_EXPORT_PATH=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import >> ALT_SLASH_JAVA=J: ALT_BOOTDIR=c:/Programme/Java/jdk1.6.0_03 >> ALT_LANGTOOLS_DIST=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/langtools/dist >> all_product >> make[1]: Entering directory >> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >> cd /cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make; \ >> make VM_TARGET=product generic_build2 >> ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >> >> make[2]: Entering directory >> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >> mkdir -p >> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >> >> cd >> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir; >> \ >> MAKEFLAGS= MFLAGS= nmake /NOLOGO -f >> s:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make >> \ >> Variant=compiler2 \ >> >> WorkSpace=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot \ >> BootStrapDir=c:\\Programme\\Java\\jdk1.6.0_03 \ >> BuildUser=proetel \ >> ARCH=x86 BUILDARCH=i486 Platform_arch=x86 >> Platform_arch_model=x86_32 JDK_MKTG_VERSION=7 JDK_MAJOR_VER=1 >> JDK_MINOR_VER=7 JDK_MICRO_VER=0 JDK_BUILD_NUMBER=0 >> JAVA_HOME=c:\\Programme\\Java\\jdk1.6.0_03 >> GAMMADIR=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot >> MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=13.0-b02 >> JRE_RELEASE_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 >> HOTSPOT_BUILD_VERSION= product >> NMAKE : fatal error U1052: file >> 's:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make' >> not found >> Stop. >> make[2]: *** [generic_build2] Error 2 >> make[2]: Leaving directory >> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >> make[1]: *** [product] Error 2 >> make[1]: Leaving directory >> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >> make: *** [hotspot-build] Error 2 >> -- >> aicas Allerton Interworks Computer Automated Systems GmbH >> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany >> http://www.aicas.com * Tel: +49-721-663 968-0 >> >> USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe >> Gesch?ftsf?hrer: Dr. James J. Hunt > -- aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt From Weijun.Wang at Sun.COM Tue Jul 22 05:18:21 2008 From: Weijun.Wang at Sun.COM (Max (Weijun) Wang) Date: Tue, 22 Jul 2008 20:18:21 +0800 Subject: Building OpenJDK on Windows In-Reply-To: <4885CEEA.6000003@aicas.com> References: <4885C2CD.10109@aicas.com> <7A9C5D17-F2A7-4C78-ACA1-37CCF1556314@sun.com> <4885CEEA.6000003@aicas.com> Message-ID: <01751A2F-B557-4D46-8B63-653D1FF94648@Sun.COM> This is a conflict between link.exe of CYGWIN and MSVC. The formal process seems to suggest that you define environment variables to inform make to locate the correct find.exe (the MSVC one). I haven't tried it. I simply rename the link.exe in CYGWIN to something else. -Max On Jul 22, 2008, at 8:13 PM, Ingo Proetel wrote: > Thanks that helped. > > Until I got here: > link.exe bufferoverflowU.lib kernel32.lib user32.lib gdi32.lib > winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib > oleaut32.lib uuid.lib Wsock32.lib winmm.lib /nologo /machine:I386 / > opt:REF /opt:ICF,8 /map /debug /subsystem:console /out:adlc.exe > main.obj adlparse.obj archDesc.obj arena.obj dfa.obj dict2.obj > filebuff.obj forms.obj formsopt.obj formssel.obj opcodes.obj > output_c.obj output_h.obj > /usr/bin/link: extra operand `user32.lib' > Try `/usr/bin/link --help' for more information. > NMAKE : fatal error U1077: 'C:\cygwin\bin\link.exe' : return code > '0x1' > > Apparently the make does not use ALT_DEVTOOLS_PATH to prefix > link.exe. Is there another environment variable that I should set > for that? > Or do I have to adjust the PATH variable? > > Ingo > > Max (Weijun) Wang wrote: >> The file is moved to somewhere else. Please apply this patch: >> diff --git a/make/windows/makefiles/defs.make b/make/windows/ >> makefiles/defs.make >> --- a/make/windows/makefiles/defs.make >> +++ b/make/windows/makefiles/defs.make >> @@ -107,7 +107,7 @@ >> ABS_OUTPUTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a "$ >> (OUTPUTDIR)")) >> ABS_BOOTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a "$ >> (BOOTDIR)")) >> ABS_GAMMADIR := $(subst /,\\,$(shell /bin/cygpath -m -a "$ >> (GAMMADIR)")) >> - ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a "$(HS_BUILD_DIR)/$ >> (OSNAME)")/build.make >> + ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a "$(HS_MAKE_DIR)/$ >> (OSNAME)")/build.make >> else >> ABS_OUTPUTDIR := $(subst /,\\,$(shell $(CD) $(OUTPUTDIR);$ >> (PWD))) >> ABS_BOOTDIR := $(subst /,\\,$(shell $(CD) $(BOOTDIR);$(PWD))) >> Hope this helps >> -Max >> On Jul 22, 2008, at 7:21 PM, Ingo Proetel wrote: >>> Hi, >>> >>> I'm currently trying to setup an OpenJDK build on Windows. >>> >>> It works until it tries to compile hotspot. It misses 'hotspot/ >>> build/windows/build.make'. >>> The build process creates some directories but not the 'hotspot/ >>> build'. >>> >>> Can somebody help me with this? >>> >>> Cheers, >>> Ingo >>> >>> This is the output I get: >>> /usr/bin/mkdir -p s:/Users/proetel/projects/openjdk/jdk7/tl/build/ >>> windows-i586/hotspot/outputdir >>> /usr/bin/mkdir -p s:/Users/proetel/projects/openjdk/jdk7/tl/build/ >>> windows-i586/hotspot/import >>> cd ./hotspot/make && \ >>> make JDK_TOPDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk >>> JDK_MAKE_SHARED_DIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk/ >>> make/common/shared EXTERNALSANITYCONTROL=true >>> TARGET_CLASS_VERSION=5 MILESTONE=internal BUILD_NUMBER=b00 >>> JDK_BUILD_NUMBER=b00 FULL_VERSION=1.7.0-internal- >>> proetel_2008_07_22_13_07-b00 PREVIOUS_JDK_VERSION=1.6.0 >>> JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 JDK_MAJOR_VERSION=1 >>> JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 PREVIOUS_MAJOR_VERSION=1 >>> PREVIOUS_MINOR_VERSION=6 PREVIOUS_MICRO_VERSION=0 >>> ARCH_DATA_MODEL=32 COOKED_BUILD_NUMBER=0 ANT_HOME="c:/Programme/ >>> apache-ant-1.7.0" ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/ >>> jdk7/tl/build/windows-i586/hotspot/outputdir ALT_EXPORT_PATH=s:/ >>> Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/ >>> import ALT_SLASH_JAVA=J: ALT_BOOTDIR=c:/Programme/Java/ >>> jdk1.6.0_03 ALT_LANGTOOLS_DIST=s:/Users/proetel/projects/openjdk/ >>> jdk7/tl/build/windows-i586/langtools/dist all_product >>> make[1]: Entering directory `/cygdrive/s/Users/proetel/projects/ >>> openjdk/jdk7/tl/hotspot/make' >>> cd /cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/ >>> make; \ >>> make VM_TARGET=product generic_build2 ALT_OUTPUTDIR=s:/Users/ >>> proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/ >>> outputdir >>> make[2]: Entering directory `/cygdrive/s/Users/proetel/projects/ >>> openjdk/jdk7/tl/hotspot/make' >>> mkdir -p s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows- >>> i586/hotspot/outputdir >>> cd s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/ >>> hotspot/outputdir; \ >>> MAKEFLAGS= MFLAGS= nmake /NOLOGO -f s:/Users/proetel/projects/ >>> openjdk/jdk7/tl/hotspot/build/windows/build.make \ >>> Variant=compiler2 \ >>> WorkSpace=s:\\Users\\proetel\\projects\ >>> \openjdk\\jdk7\\tl\\hotspot \ >>> BootStrapDir=c:\\Programme\\Java\\jdk1.6.0_03 \ >>> BuildUser=proetel \ >>> ARCH=x86 BUILDARCH=i486 Platform_arch=x86 >>> Platform_arch_model=x86_32 JDK_MKTG_VERSION=7 JDK_MAJOR_VER=1 >>> JDK_MINOR_VER=7 JDK_MICRO_VER=0 JDK_BUILD_NUMBER=0 JAVA_HOME=c:\ >>> \Programme\\Java\\jdk1.6.0_03 GAMMADIR=s:\\Users\\proetel\ >>> \projects\\openjdk\\jdk7\\tl\\hotspot MAKE_VERBOSE=y >>> HOTSPOT_RELEASE_VERSION=13.0-b02 JRE_RELEASE_VERSION=1.7.0- >>> internal-proetel_2008_07_22_13_07-b00 HOTSPOT_BUILD_VERSION= product >>> NMAKE : fatal error U1052: file 's:/Users/proetel/projects/ >>> openjdk/jdk7/tl/hotspot/build/windows/build.make' not found >>> Stop. >>> make[2]: *** [generic_build2] Error 2 >>> make[2]: Leaving directory `/cygdrive/s/Users/proetel/projects/ >>> openjdk/jdk7/tl/hotspot/make' >>> make[1]: *** [product] Error 2 >>> make[1]: Leaving directory `/cygdrive/s/Users/proetel/projects/ >>> openjdk/jdk7/tl/hotspot/make' >>> make: *** [hotspot-build] Error 2 >>> -- >>> aicas Allerton Interworks Computer Automated Systems GmbH >>> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany >>> http://www.aicas.com * Tel: +49-721-663 968-0 >>> >>> USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe >>> Gesch?ftsf?hrer: Dr. James J. Hunt > > > -- > aicas Allerton Interworks Computer Automated Systems GmbH > Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany > http://www.aicas.com * Tel: +49-721-663 968-0 > > USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe > Gesch?ftsf?hrer: Dr. James J. Hunt From proetel at aicas.com Tue Jul 22 05:46:04 2008 From: proetel at aicas.com (Ingo Proetel) Date: Tue, 22 Jul 2008 14:46:04 +0200 Subject: Building OpenJDK on Windows In-Reply-To: <01751A2F-B557-4D46-8B63-653D1FF94648@Sun.COM> References: <4885C2CD.10109@aicas.com> <7A9C5D17-F2A7-4C78-ACA1-37CCF1556314@sun.com> <4885CEEA.6000003@aicas.com> <01751A2F-B557-4D46-8B63-653D1FF94648@Sun.COM> Message-ID: <4885D68C.8070806@aicas.com> Thanks. That works for me too. Ingo Max (Weijun) Wang wrote: > This is a conflict between link.exe of CYGWIN and MSVC. > > The formal process seems to suggest that you define environment > variables to inform make to locate the correct find.exe (the MSVC one). > I haven't tried it. I simply rename the link.exe in CYGWIN to something > else. > > -Max > > On Jul 22, 2008, at 8:13 PM, Ingo Proetel wrote: > >> Thanks that helped. >> >> Until I got here: >> link.exe bufferoverflowU.lib kernel32.lib user32.lib gdi32.lib >> winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib >> oleaut32.lib uuid.lib Wsock32.lib winmm.lib /nologo /machine:I386 >> /opt:REF /opt:ICF,8 /map /debug /subsystem:console /out:adlc.exe >> main.obj adlparse.obj archDesc.obj arena.obj dfa.obj dict2.obj >> filebuff.obj forms.obj formsopt.obj formssel.obj opcodes.obj >> output_c.obj output_h.obj >> /usr/bin/link: extra operand `user32.lib' >> Try `/usr/bin/link --help' for more information. >> NMAKE : fatal error U1077: 'C:\cygwin\bin\link.exe' : return code '0x1' >> >> Apparently the make does not use ALT_DEVTOOLS_PATH to prefix link.exe. >> Is there another environment variable that I should set for that? >> Or do I have to adjust the PATH variable? >> >> Ingo >> >> Max (Weijun) Wang wrote: >>> The file is moved to somewhere else. Please apply this patch: >>> diff --git a/make/windows/makefiles/defs.make >>> b/make/windows/makefiles/defs.make >>> --- a/make/windows/makefiles/defs.make >>> +++ b/make/windows/makefiles/defs.make >>> @@ -107,7 +107,7 @@ >>> ABS_OUTPUTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a >>> "$(OUTPUTDIR)")) >>> ABS_BOOTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a >>> "$(BOOTDIR)")) >>> ABS_GAMMADIR := $(subst /,\\,$(shell /bin/cygpath -m -a >>> "$(GAMMADIR)")) >>> - ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a >>> "$(HS_BUILD_DIR)/$(OSNAME)")/build.make >>> + ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a >>> "$(HS_MAKE_DIR)/$(OSNAME)")/build.make >>> else >>> ABS_OUTPUTDIR := $(subst /,\\,$(shell $(CD) $(OUTPUTDIR);$(PWD))) >>> ABS_BOOTDIR := $(subst /,\\,$(shell $(CD) $(BOOTDIR);$(PWD))) >>> Hope this helps >>> -Max >>> On Jul 22, 2008, at 7:21 PM, Ingo Proetel wrote: >>>> Hi, >>>> >>>> I'm currently trying to setup an OpenJDK build on Windows. >>>> >>>> It works until it tries to compile hotspot. It misses >>>> 'hotspot/build/windows/build.make'. >>>> The build process creates some directories but not the 'hotspot/build'. >>>> >>>> Can somebody help me with this? >>>> >>>> Cheers, >>>> Ingo >>>> >>>> This is the output I get: >>>> /usr/bin/mkdir -p >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>> >>>> /usr/bin/mkdir -p >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import >>>> >>>> cd ./hotspot/make && \ >>>> make JDK_TOPDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk >>>> JDK_MAKE_SHARED_DIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk/make/common/shared >>>> EXTERNALSANITYCONTROL=true TARGET_CLASS_VERSION=5 MILESTONE=internal >>>> BUILD_NUMBER=b00 JDK_BUILD_NUMBER=b00 >>>> FULL_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 >>>> PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 >>>> JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 >>>> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 >>>> PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=32 COOKED_BUILD_NUMBER=0 >>>> ANT_HOME="c:/Programme/apache-ant-1.7.0" >>>> ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>> ALT_EXPORT_PATH=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import >>>> ALT_SLASH_JAVA=J: ALT_BOOTDIR=c:/Programme/Java/jdk1.6.0_03 >>>> ALT_LANGTOOLS_DIST=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/langtools/dist >>>> all_product >>>> make[1]: Entering directory >>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>> cd /cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make; \ >>>> make VM_TARGET=product generic_build2 >>>> ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>> >>>> make[2]: Entering directory >>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>> mkdir -p >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>> >>>> cd >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir; >>>> \ >>>> MAKEFLAGS= MFLAGS= nmake /NOLOGO -f >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make >>>> \ >>>> Variant=compiler2 \ >>>> >>>> WorkSpace=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot \ >>>> BootStrapDir=c:\\Programme\\Java\\jdk1.6.0_03 \ >>>> BuildUser=proetel \ >>>> ARCH=x86 BUILDARCH=i486 Platform_arch=x86 >>>> Platform_arch_model=x86_32 JDK_MKTG_VERSION=7 JDK_MAJOR_VER=1 >>>> JDK_MINOR_VER=7 JDK_MICRO_VER=0 JDK_BUILD_NUMBER=0 >>>> JAVA_HOME=c:\\Programme\\Java\\jdk1.6.0_03 >>>> GAMMADIR=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot >>>> MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=13.0-b02 >>>> JRE_RELEASE_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 >>>> HOTSPOT_BUILD_VERSION= product >>>> NMAKE : fatal error U1052: file >>>> 's:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make' >>>> not found >>>> Stop. >>>> make[2]: *** [generic_build2] Error 2 >>>> make[2]: Leaving directory >>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>> make[1]: *** [product] Error 2 >>>> make[1]: Leaving directory >>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>> make: *** [hotspot-build] Error 2 >>>> -- >>>> aicas Allerton Interworks Computer Automated Systems GmbH >>>> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany >>>> http://www.aicas.com * Tel: +49-721-663 968-0 >>>> >>>> USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe >>>> Gesch?ftsf?hrer: Dr. James J. Hunt >> >> >> -- >> aicas Allerton Interworks Computer Automated Systems GmbH >> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany >> http://www.aicas.com * Tel: +49-721-663 968-0 >> >> USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe >> Gesch?ftsf?hrer: Dr. James J. Hunt > -- aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt From Bradford.Wetmore at Sun.COM Tue Jul 22 07:26:34 2008 From: Bradford.Wetmore at Sun.COM (Brad Wetmore) Date: Tue, 22 Jul 2008 07:26:34 -0700 Subject: Can somebody sanity-check me here? In-Reply-To: <487E1F67.4080709@sun.com> References: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> <487E1F67.4080709@sun.com> Message-ID: <4885EE1A.3050605@sun.com> I didn't notice the appropriate developer's guide section mentioned in the followups. http://openjdk.java.net/guide/repositories.html#term Brad Kelly O'Hair wrote: > For your build changes work, the forest clone of interest is > > hg fclone http://hg.openjdk.java.net/jdk7/build > > which will include the repositories: > > http://hg.openjdk.java.net/jdk7/build > http://hg.openjdk.java.net/jdk7/build/jdk > http://hg.openjdk.java.net/jdk7/build/corba > http://hg.openjdk.java.net/jdk7/build/jaxws > http://hg.openjdk.java.net/jdk7/build/jaxp > http://hg.openjdk.java.net/jdk7/build/hotspot > http://hg.openjdk.java.net/jdk7/build/langtools > > Each of these have a matching "-gate" repository for doing pushes > of changes, but until you are officially registered as an openjdk > developer that can push changes, the "-gate" ones won't be of any > interest. > > Each pair of forests (the pull and the "-gate" push mirror) at > http://hg.openjdk.java.net/jdk7/ serves a project or team. > The jdk7/build forest is specifically for build related changes. > > The master or official jdk7 forest is > > http://hg.openjdk.java.net/jdk7/jdk7 > > -kto > > Ted Neward wrote: >> I go to http://hg.openjdk.java.net, and there?s about 4 billion >> different repositories listed there, including several variations of >> repositories that I thought I was already pulling: hotspot, corba, >> jdk, and so on. (The variations are things like jdk7/corba-gate, >> jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to >> explicitly pull these guys? Or are they somehow being brought in to >> the ?core? name repositories? >> >> >> >> Ted Neward >> >> Java, .NET, XML Services >> >> Consulting, Teaching, Speaking, Writing >> >> http://www.tedneward.com >> >> >> >> >> No virus found in this outgoing message. >> Checked by AVG. >> Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: >> 7/12/2008 7:40 AM >> From Kelly.Ohair at Sun.COM Tue Jul 22 09:31:35 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 22 Jul 2008 09:31:35 -0700 Subject: Building OpenJDK on Windows In-Reply-To: <01751A2F-B557-4D46-8B63-653D1FF94648@Sun.COM> References: <4885C2CD.10109@aicas.com> <7A9C5D17-F2A7-4C78-ACA1-37CCF1556314@sun.com> <4885CEEA.6000003@aicas.com> <01751A2F-B557-4D46-8B63-653D1FF94648@Sun.COM> Message-ID: <48860B67.7010503@sun.com> Max is correct. Normally you should put the compiler paths before /usr/bin in your PATH variable. I'm not sure how safe it is to modify the cygwin installation. I have bug 6724787, and I will clarify this cygwin link.exe PATH issue in the OpenJDK Build readme soon. http://hg.openjdk.java.net/jdk7/build/raw-file/tip/README-builds.html -kto Max (Weijun) Wang wrote: > This is a conflict between link.exe of CYGWIN and MSVC. > > The formal process seems to suggest that you define environment > variables to inform make to locate the correct find.exe (the MSVC one). > I haven't tried it. I simply rename the link.exe in CYGWIN to something > else. > > -Max > > On Jul 22, 2008, at 8:13 PM, Ingo Proetel wrote: > >> Thanks that helped. >> >> Until I got here: >> link.exe bufferoverflowU.lib kernel32.lib user32.lib gdi32.lib >> winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib >> oleaut32.lib uuid.lib Wsock32.lib winmm.lib /nologo /machine:I386 >> /opt:REF /opt:ICF,8 /map /debug /subsystem:console /out:adlc.exe >> main.obj adlparse.obj archDesc.obj arena.obj dfa.obj dict2.obj >> filebuff.obj forms.obj formsopt.obj formssel.obj opcodes.obj >> output_c.obj output_h.obj >> /usr/bin/link: extra operand `user32.lib' >> Try `/usr/bin/link --help' for more information. >> NMAKE : fatal error U1077: 'C:\cygwin\bin\link.exe' : return code '0x1' >> >> Apparently the make does not use ALT_DEVTOOLS_PATH to prefix link.exe. >> Is there another environment variable that I should set for that? >> Or do I have to adjust the PATH variable? >> >> Ingo >> >> Max (Weijun) Wang wrote: >>> The file is moved to somewhere else. Please apply this patch: >>> diff --git a/make/windows/makefiles/defs.make >>> b/make/windows/makefiles/defs.make >>> --- a/make/windows/makefiles/defs.make >>> +++ b/make/windows/makefiles/defs.make >>> @@ -107,7 +107,7 @@ >>> ABS_OUTPUTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a >>> "$(OUTPUTDIR)")) >>> ABS_BOOTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a >>> "$(BOOTDIR)")) >>> ABS_GAMMADIR := $(subst /,\\,$(shell /bin/cygpath -m -a >>> "$(GAMMADIR)")) >>> - ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a >>> "$(HS_BUILD_DIR)/$(OSNAME)")/build.make >>> + ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a >>> "$(HS_MAKE_DIR)/$(OSNAME)")/build.make >>> else >>> ABS_OUTPUTDIR := $(subst /,\\,$(shell $(CD) $(OUTPUTDIR);$(PWD))) >>> ABS_BOOTDIR := $(subst /,\\,$(shell $(CD) $(BOOTDIR);$(PWD))) >>> Hope this helps >>> -Max >>> On Jul 22, 2008, at 7:21 PM, Ingo Proetel wrote: >>>> Hi, >>>> >>>> I'm currently trying to setup an OpenJDK build on Windows. >>>> >>>> It works until it tries to compile hotspot. It misses >>>> 'hotspot/build/windows/build.make'. >>>> The build process creates some directories but not the 'hotspot/build'. >>>> >>>> Can somebody help me with this? >>>> >>>> Cheers, >>>> Ingo >>>> >>>> This is the output I get: >>>> /usr/bin/mkdir -p >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>> >>>> /usr/bin/mkdir -p >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import >>>> >>>> cd ./hotspot/make && \ >>>> make JDK_TOPDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk >>>> JDK_MAKE_SHARED_DIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk/make/common/shared >>>> EXTERNALSANITYCONTROL=true TARGET_CLASS_VERSION=5 MILESTONE=internal >>>> BUILD_NUMBER=b00 JDK_BUILD_NUMBER=b00 >>>> FULL_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 >>>> PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 >>>> JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 >>>> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 >>>> PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=32 COOKED_BUILD_NUMBER=0 >>>> ANT_HOME="c:/Programme/apache-ant-1.7.0" >>>> ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>> ALT_EXPORT_PATH=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import >>>> ALT_SLASH_JAVA=J: ALT_BOOTDIR=c:/Programme/Java/jdk1.6.0_03 >>>> ALT_LANGTOOLS_DIST=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/langtools/dist >>>> all_product >>>> make[1]: Entering directory >>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>> cd /cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make; \ >>>> make VM_TARGET=product generic_build2 >>>> ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>> >>>> make[2]: Entering directory >>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>> mkdir -p >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>> >>>> cd >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir; >>>> \ >>>> MAKEFLAGS= MFLAGS= nmake /NOLOGO -f >>>> s:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make >>>> \ >>>> Variant=compiler2 \ >>>> >>>> WorkSpace=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot \ >>>> BootStrapDir=c:\\Programme\\Java\\jdk1.6.0_03 \ >>>> BuildUser=proetel \ >>>> ARCH=x86 BUILDARCH=i486 Platform_arch=x86 >>>> Platform_arch_model=x86_32 JDK_MKTG_VERSION=7 JDK_MAJOR_VER=1 >>>> JDK_MINOR_VER=7 JDK_MICRO_VER=0 JDK_BUILD_NUMBER=0 >>>> JAVA_HOME=c:\\Programme\\Java\\jdk1.6.0_03 >>>> GAMMADIR=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot >>>> MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=13.0-b02 >>>> JRE_RELEASE_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 >>>> HOTSPOT_BUILD_VERSION= product >>>> NMAKE : fatal error U1052: file >>>> 's:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make' >>>> not found >>>> Stop. >>>> make[2]: *** [generic_build2] Error 2 >>>> make[2]: Leaving directory >>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>> make[1]: *** [product] Error 2 >>>> make[1]: Leaving directory >>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>> make: *** [hotspot-build] Error 2 >>>> -- >>>> aicas Allerton Interworks Computer Automated Systems GmbH >>>> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany >>>> http://www.aicas.com * Tel: +49-721-663 968-0 >>>> >>>> USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe >>>> Gesch?ftsf?hrer: Dr. James J. Hunt >> >> >> -- >> aicas Allerton Interworks Computer Automated Systems GmbH >> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany >> http://www.aicas.com * Tel: +49-721-663 968-0 >> >> USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe >> Gesch?ftsf?hrer: Dr. James J. Hunt > From Kelly.Ohair at Sun.COM Tue Jul 22 09:46:03 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 22 Jul 2008 09:46:03 -0700 Subject: Can somebody sanity-check me here? In-Reply-To: <4885EE1A.3050605@sun.com> References: <028b01c8e71e$c6a3fc50$53ebf4f0$@com> <487E1F67.4080709@sun.com> <4885EE1A.3050605@sun.com> Message-ID: <48860ECB.6060507@sun.com> Perfect. I forgot about that... ;^) Thanks Brad. -kto Brad Wetmore wrote: > I didn't notice the appropriate developer's guide section mentioned in > the followups. > > http://openjdk.java.net/guide/repositories.html#term > > Brad > > > > Kelly O'Hair wrote: >> For your build changes work, the forest clone of interest is >> >> hg fclone http://hg.openjdk.java.net/jdk7/build >> >> which will include the repositories: >> >> http://hg.openjdk.java.net/jdk7/build >> http://hg.openjdk.java.net/jdk7/build/jdk >> http://hg.openjdk.java.net/jdk7/build/corba >> http://hg.openjdk.java.net/jdk7/build/jaxws >> http://hg.openjdk.java.net/jdk7/build/jaxp >> http://hg.openjdk.java.net/jdk7/build/hotspot >> http://hg.openjdk.java.net/jdk7/build/langtools >> >> Each of these have a matching "-gate" repository for doing pushes >> of changes, but until you are officially registered as an openjdk >> developer that can push changes, the "-gate" ones won't be of any >> interest. >> >> Each pair of forests (the pull and the "-gate" push mirror) at >> http://hg.openjdk.java.net/jdk7/ serves a project or team. >> The jdk7/build forest is specifically for build related changes. >> >> The master or official jdk7 forest is >> >> http://hg.openjdk.java.net/jdk7/jdk7 >> >> -kto >> >> Ted Neward wrote: >>> I go to http://hg.openjdk.java.net, and there?s about 4 billion >>> different repositories listed there, including several variations of >>> repositories that I thought I was already pulling: hotspot, corba, >>> jdk, and so on. (The variations are things like jdk7/corba-gate, >>> jdk7/hotspot-comp, jdk7/hotspot-gc, and so on.) Do I need to >>> explicitly pull these guys? Or are they somehow being brought in to >>> the ?core? name repositories? >>> >>> >>> >>> Ted Neward >>> >>> Java, .NET, XML Services >>> >>> Consulting, Teaching, Speaking, Writing >>> >>> http://www.tedneward.com >>> >>> >>> >>> >>> No virus found in this outgoing message. >>> Checked by AVG. >>> Version: 7.5.524 / Virus Database: 270.4.9/1548 - Release Date: >>> 7/12/2008 7:40 AM >>> From jwbaker at gmail.com Tue Jul 22 11:24:02 2008 From: jwbaker at gmail.com (Jeffrey Baker) Date: Tue, 22 Jul 2008 11:24:02 -0700 Subject: b31 multiple build failures on x86 Linux Message-ID: I noted multiple build failures on x86 Linux (Ubuntu 8.04) using the b31 source archive, building the fastdebug_build target. The first failure occurs due to -Werror. There are a number of unsafe casts of char * in hotspot, and these cause the build to fail with -Werror. I worked around this by removing -Werror from a variety of Makefiles. Aside: why isn't this propagated from the top-level Makefile? I had to grep around in the tree to find the right one. Second problem: the build dumped core in test_gamma with an error in ciTypeFlow.hpp:395. I filed this bug at sun.com with Review ID 1299675. I worked around this by exiting the test_gamma script early. Third problem: fastdebug_build target doesn't seem to propagate the -g flag. All of hotspot was built with -fPIC -fno-rtti -fno-exceptions -fcheck-new -m32 -march=i586 -pipe -O3 -fno-strict-aliasing -Wpointer-arith -Wconversion -Wsign-compare, i.e. without -g. I thought the point of the fastdebug target was to build with -g -O. Should I have built with the plain debug_build target instead? Fourth problem: /home/jwb/jdk-src/openjdk/build/linux-i586-fastdebug/gensrc/java/nio/charset/CharsetEncoder.java:142: cannot find symbol symbol : class $replType$ location: class java.nio.charset.CharsetEncoder private $replType$ replacement; This is evidently caused by /bin/sh being dash instead of bash. If the build requires bash, why doesn't it invoke bash? Relying on sh == bash is fragile and confusing. Regards, jwb From Kelly.Ohair at Sun.COM Tue Jul 22 11:57:15 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 22 Jul 2008 11:57:15 -0700 Subject: JDK7 Build 31 and Solaris builds with Sun Studio 12 Message-ID: <48862D8B.2020704@sun.com> Just an update... The following changesets integrated into Build 31 should allow the OpenJDK7 to be built with Sun Studio 12 (SS12) compilers on Solaris 10 and above. * http://hg.openjdk.java.net/jdk7/jdk7/rev/cda4ce5a6494 * http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/f9467b4496dc * http://hg.openjdk.java.net/jdk7/jdk7/hotspot/rev/a49545cab84a * http://hg.openjdk.java.net/jdk7/jdk7/hotspot/rev/86658812ca35 SS12 needs to be in your PATH and also referred to with ALT_COMPILER_PATH. We are not officially changing to the SS12 compilers just yet, we still need to run some performance measurements and do some testing of Solaris JDK's built with SS12. Once those results are in, and are positive, then SS12 will be validated in our view and we will make a few minor changes to the Makefiles to "expect at least SS12" and warn otherwise. The Sun Studio Express compiler is a SS12+ compiler as I understand it, and should work also, but it's also somewhat of a moving target, so anyone using it needs to understand that there is some risk here. Internally we try and lock down the compiler version once we have validated it. -kto From Kelly.Ohair at Sun.COM Tue Jul 22 12:17:52 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 22 Jul 2008 12:17:52 -0700 Subject: b31 multiple build failures on x86 Linux In-Reply-To: References: Message-ID: <48863260.6000707@sun.com> Jeffrey Baker wrote: > I noted multiple build failures on x86 Linux (Ubuntu 8.04) using the > b31 source archive, building the fastdebug_build target. > > The first failure occurs due to -Werror. There are a number of unsafe > casts of char * in hotspot, and these cause the build to fail with > -Werror. I worked around this by removing -Werror from a variety of > Makefiles. Aside: why isn't this propagated from the top-level > Makefile? I had to grep around in the tree to find the right one. The hotspot sources have traditionally been built by a handful of compilers with all known warnings fixed. When you start using a newer compiler with newer warnings, you need to either fix the warnings or turn off the -Werror option. If you supply WARNINGS_ARE_ERRORS= on the make command line so that you empty out this variable that normally has -Werror in it, that should work. You should not have to edit the Makefiles, so if make WARNINGS_ARE_ERRORS= does not work, let me know. You cannot set this as an environment variable and we never use the 'make -e' option. When make is run in the Makefiles, it should use $(MAKE) which should propagate the command line options. Again, if this is not the case, let me know. > > Second problem: the build dumped core in test_gamma with an error in > ciTypeFlow.hpp:395. I filed this bug at sun.com with Review ID > 1299675. I worked around this by exiting the test_gamma script early. Since you are using a newer gcc compiler, it's quite possible you have found a bug of some kind, in gcc or in hotspot or somewhere in between. You may want to see about trying a different gcc to isolate what the issue might be. > > Third problem: fastdebug_build target doesn't seem to propagate the -g > flag. All of hotspot was built with -fPIC -fno-rtti -fno-exceptions > -fcheck-new -m32 -march=i586 -pipe -O3 -fno-strict-aliasing > -Wpointer-arith -Wconversion -Wsign-compare, i.e. without -g. I > thought the point of the fastdebug target was to build with -g -O. Yes, it should have. That's a new one on me. I see that the debug build seems to use -gstabs, but it looks like linux/makefiles/fastdebug.make forgot to add -gstabs to CFLAGS. It's possible that they removed it with 64bit mode because of the size problems with Dwarf2 debug format, and accidently removed it for 32bit too. :^( Sounds like a bug to me. > Should I have built with the plain debug_build target instead? No, you should not have to. > > Fourth problem: > /home/jwb/jdk-src/openjdk/build/linux-i586-fastdebug/gensrc/java/nio/charset/CharsetEncoder.java:142: > cannot find symbol > symbol : class $replType$ > location: class java.nio.charset.CharsetEncoder > private $replType$ replacement; > > This is evidently caused by /bin/sh being dash instead of bash. If > the build requires bash, why doesn't it invoke bash? Relying on sh == > bash is fragile and confusing. The build does not require bash, it requires an 'sh' that works properly. Some change in dash caused this problem. These sh scripts have not changed for ages. -kto > > Regards, > jwb From jwbaker at gmail.com Tue Jul 22 12:44:14 2008 From: jwbaker at gmail.com (Jeffrey Baker) Date: Tue, 22 Jul 2008 12:44:14 -0700 Subject: b31 multiple build failures on x86 Linux In-Reply-To: <48863260.6000707@sun.com> References: <48863260.6000707@sun.com> Message-ID: On Tue, Jul 22, 2008 at 12:17 PM, Kelly O'Hair wrote: > Jeffrey Baker wrote: >> >> I noted multiple build failures on x86 Linux (Ubuntu 8.04) using the >> b31 source archive, building the fastdebug_build target. >> >> The first failure occurs due to -Werror. There are a number of unsafe >> casts of char * in hotspot, and these cause the build to fail with >> -Werror. I worked around this by removing -Werror from a variety of >> Makefiles. Aside: why isn't this propagated from the top-level >> Makefile? I had to grep around in the tree to find the right one. > > The hotspot sources have traditionally been built by a handful of > compilers with all known warnings fixed. When you start using a newer > compiler with newer warnings, you need to either fix the warnings or > turn off the -Werror option. > If you supply WARNINGS_ARE_ERRORS= on the make command line so that you > empty out this variable that normally has -Werror in it, that should work. > You should not have to edit the Makefiles, so if > make WARNINGS_ARE_ERRORS= > does not work, let me know. > You cannot set this as an environment variable and we never use the > 'make -e' option. When make is run in the Makefiles, it should use > $(MAKE) which should propagate the command line options. > Again, if this is not the case, let me know. Noted. >> Second problem: the build dumped core in test_gamma with an error in >> ciTypeFlow.hpp:395. I filed this bug at sun.com with Review ID >> 1299675. I worked around this by exiting the test_gamma script early. > > Since you are using a newer gcc compiler, it's quite possible you have > found a bug of some kind, in gcc or in hotspot or somewhere in between. > You may want to see about trying a different gcc to isolate what the issue > might be. What is the officially blessed compiler? This one appears to be gcc 4.2.3, but I have numerous other revisions of gcc kicking around, including 4.1 and 4.2. >> Third problem: fastdebug_build target doesn't seem to propagate the -g >> flag. All of hotspot was built with -fPIC -fno-rtti -fno-exceptions >> -fcheck-new -m32 -march=i586 -pipe -O3 -fno-strict-aliasing >> -Wpointer-arith -Wconversion -Wsign-compare, i.e. without -g. I >> thought the point of the fastdebug target was to build with -g -O. > > Yes, it should have. That's a new one on me. > I see that the debug build seems to use -gstabs, but it looks > like linux/makefiles/fastdebug.make forgot to add -gstabs to CFLAGS. > It's possible that they removed it with 64bit mode because of the > size problems with Dwarf2 debug format, and accidently removed it for > 32bit too. :^( Sounds like a bug to me. Looking into that further, it seems that very little is propagated from the top level Makefile down to the hotspot build. I tried altering DEBUG_FLAG in jdk/make/common/Defs-linux.gmk but my changes were lost by the time the build descended to hotspot. I also tried using OTHER_CFLAGS, OTHER_CXXFLAGS, and OTHER_LDFLAGS on the make command line, but that too was lost. Setting CFLAGS itself on the make command line doesn't work because it clobbers the rest of the flags. I eventually edited hotspot/make/linux/makefiles/gcc.make to add -pg, but while poking around in there I saw profiled.make. I see that "profiled" is a valid target in hotspot, but it's not exposed at the top level build. Therefore I set HOTSPOT_TARGET = profiled. Unfortunately that did not work either. What is the official way to build openjdk with profiling? > The build does not require bash, it requires an 'sh' that works properly. > Some change in dash caused this problem. These sh scripts have not changed > for ages. Ok. I didn't mean to accuse anyone of anything here. I never heard of "dash" until today so I did not hesitate when I removed it from my system. Thanks a lot for your helpful reply. -jwb From Kelly.Ohair at Sun.COM Tue Jul 22 13:53:02 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 22 Jul 2008 13:53:02 -0700 Subject: b31 multiple build failures on x86 Linux In-Reply-To: References: <48863260.6000707@sun.com> Message-ID: <488648AE.60809@sun.com> Jeffrey Baker wrote: > On Tue, Jul 22, 2008 at 12:17 PM, Kelly O'Hair wrote: >> Jeffrey Baker wrote: [snip] > >>> Second problem: the build dumped core in test_gamma with an error in >>> ciTypeFlow.hpp:395. I filed this bug at sun.com with Review ID >>> 1299675. I worked around this by exiting the test_gamma script early. >> Since you are using a newer gcc compiler, it's quite possible you have >> found a bug of some kind, in gcc or in hotspot or somewhere in between. >> You may want to see about trying a different gcc to isolate what the issue >> might be. > > What is the officially blessed compiler? This one appears to be gcc > 4.2.3, but I have numerous other revisions of gcc kicking around, > including 4.1 and 4.2. You won't like this, but it's 3.2. We get gcc from the Linux system, and unfortunately we haven't upgraded the official Linux systems for JDK7, yet. I know people have used gcc4, but I don't know what the exact version is. Maybe someone from one of the linux distros and speak up on this topic?? > >>> Third problem: fastdebug_build target doesn't seem to propagate the -g >>> flag. All of hotspot was built with -fPIC -fno-rtti -fno-exceptions >>> -fcheck-new -m32 -march=i586 -pipe -O3 -fno-strict-aliasing >>> -Wpointer-arith -Wconversion -Wsign-compare, i.e. without -g. I >>> thought the point of the fastdebug target was to build with -g -O. >> Yes, it should have. That's a new one on me. >> I see that the debug build seems to use -gstabs, but it looks >> like linux/makefiles/fastdebug.make forgot to add -gstabs to CFLAGS. >> It's possible that they removed it with 64bit mode because of the >> size problems with Dwarf2 debug format, and accidently removed it for >> 32bit too. :^( Sounds like a bug to me. > > Looking into that further, it seems that very little is propagated > from the top level Makefile down to the hotspot build. I tried > altering DEBUG_FLAG in jdk/make/common/Defs-linux.gmk but my changes > were lost by the time the build descended to hotspot. I also tried > using OTHER_CFLAGS, OTHER_CXXFLAGS, and OTHER_LDFLAGS on the make > command line, but that too was lost. Setting CFLAGS itself on the > make command line doesn't work because it clobbers the rest of the > flags. For multiple reasons, you cannot modify makefiles in the jdk and expect hotspot to see anything. If you want variables propagated through the build, they must be on the 'make' command line. Hotspot makefiles are independent from the jdk makefiles and have their own origins, style, structure, and conventions. The hotspot makefiles will not read makefiles outside their repository, they are completely independent makefiles. I didn't invent it, I just know about it. ;^) > > I eventually edited hotspot/make/linux/makefiles/gcc.make to add -pg, > but while poking around in there I saw profiled.make. I see that > "profiled" is a valid target in hotspot, but it's not exposed at the > top level build. Therefore I set HOTSPOT_TARGET = profiled. > Unfortunately that did not work either. We don't generate a "profiled" jdk, so this makes no sense. I'm sure you could build a profiled hotspot VM and plug it in to a jdk image, but you won't get any help in the jdk makefiles. Also, even if you did get it to work, using a profiled VM to build the JDK would probably be a bit slow, and serve little purpose. Treat hotspot separate, build it the way you want, and plug it into the jdk image you want to use. Your builds will be faster and you can avoid building lots of jdk code you don't need to repeatedly rebuild. > > What is the official way to build openjdk with profiling? As far as I know, there is none. It's just not something that is done much anymore. When we are doing profiling we use tools like the Sun Studio Analyzer or the NetBeans profiler, where we really don't need to build the image in any special way. Sun Studio 12 is available on Linux, with the Analyzer, but I have never used it. > >> The build does not require bash, it requires an 'sh' that works properly. >> Some change in dash caused this problem. These sh scripts have not changed >> for ages. > > Ok. I didn't mean to accuse anyone of anything here. I never heard > of "dash" until today so I did not hesitate when I removed it from my > system. No problem, it's just been a bit of a thorn in our sides of late. :^( As I understand it, Ubuntu knowingly shipped with a dash bug that breaks our shell scripts. I don't have any other details. You might be able to 'make SH=/bin/bash' to get around this, but it's just a guess. -kto > > Thanks a lot for your helpful reply. > > -jwb From proetel at aicas.com Tue Jul 22 14:05:46 2008 From: proetel at aicas.com (Ingo Proetel) Date: Tue, 22 Jul 2008 23:05:46 +0200 Subject: Building OpenJDK on Windows In-Reply-To: <48860B67.7010503@sun.com> References: <4885C2CD.10109@aicas.com> <7A9C5D17-F2A7-4C78-ACA1-37CCF1556314@sun.com> <4885CEEA.6000003@aicas.com> <01751A2F-B557-4D46-8B63-653D1FF94648@Sun.COM> <48860B67.7010503@sun.com> Message-ID: <48864BAA.8040302@aicas.com> It seems that this is mainly a problem in the hotspot part of the build. Other parts call link and cl with absolut paths. To me this looks like the right solution also for the hotspot part. Fiddling with PATH might lead to other problems and conflicts. Ingo Kelly O'Hair wrote: > Max is correct. > > Normally you should put the compiler paths before /usr/bin in your PATH > variable. > I'm not sure how safe it is to modify the cygwin installation. > > I have bug 6724787, and I will clarify this cygwin link.exe PATH issue > in the > OpenJDK Build readme soon. > http://hg.openjdk.java.net/jdk7/build/raw-file/tip/README-builds.html > > -kto > > Max (Weijun) Wang wrote: >> This is a conflict between link.exe of CYGWIN and MSVC. >> >> The formal process seems to suggest that you define environment >> variables to inform make to locate the correct find.exe (the MSVC >> one). I haven't tried it. I simply rename the link.exe in CYGWIN to >> something else. >> >> -Max >> >> On Jul 22, 2008, at 8:13 PM, Ingo Proetel wrote: >> >>> Thanks that helped. >>> >>> Until I got here: >>> link.exe bufferoverflowU.lib kernel32.lib user32.lib gdi32.lib >>> winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib >>> oleaut32.lib uuid.lib Wsock32.lib winmm.lib /nologo /machine:I386 >>> /opt:REF /opt:ICF,8 /map /debug /subsystem:console /out:adlc.exe >>> main.obj adlparse.obj archDesc.obj arena.obj dfa.obj dict2.obj >>> filebuff.obj forms.obj formsopt.obj formssel.obj opcodes.obj >>> output_c.obj output_h.obj >>> /usr/bin/link: extra operand `user32.lib' >>> Try `/usr/bin/link --help' for more information. >>> NMAKE : fatal error U1077: 'C:\cygwin\bin\link.exe' : return code '0x1' >>> >>> Apparently the make does not use ALT_DEVTOOLS_PATH to prefix >>> link.exe. Is there another environment variable that I should set for >>> that? >>> Or do I have to adjust the PATH variable? >>> >>> Ingo >>> >>> Max (Weijun) Wang wrote: >>>> The file is moved to somewhere else. Please apply this patch: >>>> diff --git a/make/windows/makefiles/defs.make >>>> b/make/windows/makefiles/defs.make >>>> --- a/make/windows/makefiles/defs.make >>>> +++ b/make/windows/makefiles/defs.make >>>> @@ -107,7 +107,7 @@ >>>> ABS_OUTPUTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a >>>> "$(OUTPUTDIR)")) >>>> ABS_BOOTDIR := $(subst /,\\,$(shell /bin/cygpath -m -a >>>> "$(BOOTDIR)")) >>>> ABS_GAMMADIR := $(subst /,\\,$(shell /bin/cygpath -m -a >>>> "$(GAMMADIR)")) >>>> - ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a >>>> "$(HS_BUILD_DIR)/$(OSNAME)")/build.make >>>> + ABS_OS_MAKEFILE := $(shell /bin/cygpath -m -a >>>> "$(HS_MAKE_DIR)/$(OSNAME)")/build.make >>>> else >>>> ABS_OUTPUTDIR := $(subst /,\\,$(shell $(CD) $(OUTPUTDIR);$(PWD))) >>>> ABS_BOOTDIR := $(subst /,\\,$(shell $(CD) $(BOOTDIR);$(PWD))) >>>> Hope this helps >>>> -Max >>>> On Jul 22, 2008, at 7:21 PM, Ingo Proetel wrote: >>>>> Hi, >>>>> >>>>> I'm currently trying to setup an OpenJDK build on Windows. >>>>> >>>>> It works until it tries to compile hotspot. It misses >>>>> 'hotspot/build/windows/build.make'. >>>>> The build process creates some directories but not the >>>>> 'hotspot/build'. >>>>> >>>>> Can somebody help me with this? >>>>> >>>>> Cheers, >>>>> Ingo >>>>> >>>>> This is the output I get: >>>>> /usr/bin/mkdir -p >>>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>>> >>>>> /usr/bin/mkdir -p >>>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import >>>>> >>>>> cd ./hotspot/make && \ >>>>> make JDK_TOPDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk >>>>> JDK_MAKE_SHARED_DIR=s:/Users/proetel/projects/openjdk/jdk7/tl/jdk/make/common/shared >>>>> EXTERNALSANITYCONTROL=true TARGET_CLASS_VERSION=5 >>>>> MILESTONE=internal BUILD_NUMBER=b00 JDK_BUILD_NUMBER=b00 >>>>> FULL_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 >>>>> PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 >>>>> JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 >>>>> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 >>>>> PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=32 COOKED_BUILD_NUMBER=0 >>>>> ANT_HOME="c:/Programme/apache-ant-1.7.0" >>>>> ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>>> ALT_EXPORT_PATH=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/import >>>>> ALT_SLASH_JAVA=J: ALT_BOOTDIR=c:/Programme/Java/jdk1.6.0_03 >>>>> ALT_LANGTOOLS_DIST=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/langtools/dist >>>>> all_product >>>>> make[1]: Entering directory >>>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>>> cd /cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make; \ >>>>> make VM_TARGET=product generic_build2 >>>>> ALT_OUTPUTDIR=s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>>> >>>>> make[2]: Entering directory >>>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>>> mkdir -p >>>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir >>>>> >>>>> cd >>>>> s:/Users/proetel/projects/openjdk/jdk7/tl/build/windows-i586/hotspot/outputdir; >>>>> \ >>>>> MAKEFLAGS= MFLAGS= nmake /NOLOGO -f >>>>> s:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make >>>>> \ >>>>> Variant=compiler2 \ >>>>> >>>>> WorkSpace=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot \ >>>>> BootStrapDir=c:\\Programme\\Java\\jdk1.6.0_03 \ >>>>> BuildUser=proetel \ >>>>> ARCH=x86 BUILDARCH=i486 Platform_arch=x86 >>>>> Platform_arch_model=x86_32 JDK_MKTG_VERSION=7 JDK_MAJOR_VER=1 >>>>> JDK_MINOR_VER=7 JDK_MICRO_VER=0 JDK_BUILD_NUMBER=0 >>>>> JAVA_HOME=c:\\Programme\\Java\\jdk1.6.0_03 >>>>> GAMMADIR=s:\\Users\\proetel\\projects\\openjdk\\jdk7\\tl\\hotspot >>>>> MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=13.0-b02 >>>>> JRE_RELEASE_VERSION=1.7.0-internal-proetel_2008_07_22_13_07-b00 >>>>> HOTSPOT_BUILD_VERSION= product >>>>> NMAKE : fatal error U1052: file >>>>> 's:/Users/proetel/projects/openjdk/jdk7/tl/hotspot/build/windows/build.make' >>>>> not found >>>>> Stop. >>>>> make[2]: *** [generic_build2] Error 2 >>>>> make[2]: Leaving directory >>>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>>> make[1]: *** [product] Error 2 >>>>> make[1]: Leaving directory >>>>> `/cygdrive/s/Users/proetel/projects/openjdk/jdk7/tl/hotspot/make' >>>>> make: *** [hotspot-build] Error 2 >>>>> -- >>>>> aicas Allerton Interworks Computer Automated Systems GmbH >>>>> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany >>>>> http://www.aicas.com * Tel: +49-721-663 968-0 >>>>> >>>>> USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe >>>>> Gesch?ftsf?hrer: Dr. James J. Hunt >>> >>> >>> -- >>> aicas Allerton Interworks Computer Automated Systems GmbH >>> Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany >>> http://www.aicas.com * Tel: +49-721-663 968-0 >>> >>> USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe >>> Gesch?ftsf?hrer: Dr. James J. Hunt >> -- aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt From aph at redhat.com Tue Jul 22 14:12:30 2008 From: aph at redhat.com (Andrew Haley) Date: Tue, 22 Jul 2008 22:12:30 +0100 Subject: b31 multiple build failures on x86 Linux In-Reply-To: <488648AE.60809@sun.com> References: <48863260.6000707@sun.com> <488648AE.60809@sun.com> Message-ID: <48864D3E.7090801@redhat.com> Kelly O'Hair wrote: > > > Jeffrey Baker wrote: >> On Tue, Jul 22, 2008 at 12:17 PM, Kelly O'Hair >> wrote: >>> Jeffrey Baker wrote: > [snip] >> >>>> Second problem: the build dumped core in test_gamma with an error in >>>> ciTypeFlow.hpp:395. I filed this bug at sun.com with Review ID >>>> 1299675. I worked around this by exiting the test_gamma script early. >>> Since you are using a newer gcc compiler, it's quite possible you have >>> found a bug of some kind, in gcc or in hotspot or somewhere in between. >>> You may want to see about trying a different gcc to isolate what the >>> issue might be. >> >> What is the officially blessed compiler? This one appears to be gcc >> 4.2.3, but I have numerous other revisions of gcc kicking around, >> including 4.1 and 4.2. > > You won't like this, but it's 3.2. > We get gcc from the Linux system, and unfortunately we haven't upgraded > the official Linux systems for JDK7, yet. > I know people have used gcc4, but I don't know what the exact version is. > > Maybe someone from one of the linux distros and speak up on this topic?? We have used 4.1 and 4.3. We don't much like 4.2 so we're not going to use it. Andrew. From Kelly.Ohair at Sun.COM Tue Jul 22 14:27:13 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 22 Jul 2008 14:27:13 -0700 Subject: Building OpenJDK on Windows In-Reply-To: <48864BAA.8040302@aicas.com> References: <4885C2CD.10109@aicas.com> <7A9C5D17-F2A7-4C78-ACA1-37CCF1556314@sun.com> <4885CEEA.6000003@aicas.com> <01751A2F-B557-4D46-8B63-653D1FF94648@Sun.COM> <48860B67.7010503@sun.com> <48864BAA.8040302@aicas.com> Message-ID: <488650B1.4080604@sun.com> If you are building with Visual Studio, it needs to be in your PATH and it needs to pretty much be first in your PATH. The Visual Studio tools expect to find their components via the PATH, they won't look in their installed HOME location, they use PATH. Most compilers figure out where HOME is and use the right components. I don't think this issue is limited to hotspot, you will get messed up somewhere else too, I forget where. On any system, I generally put my own tools before /usr/bin anyway, but maybe that's that historic and just me. I always got caught if the system path /usr/ucb/bin preceeded Sun Studio, ended up with an old antique ucb 'cc' instead of the compiler I wanted. :^( -kto Ingo Proetel wrote: > It seems that this is mainly a problem in the hotspot part of the build. > Other parts call link and cl with absolut paths. To me this looks like > the right solution also for the hotspot part. > Fiddling with PATH might lead to other problems and conflicts. > > Ingo > > Kelly O'Hair wrote: >> Max is correct. >> >> Normally you should put the compiler paths before /usr/bin in your >> PATH variable. >> I'm not sure how safe it is to modify the cygwin installation. >> >> I have bug 6724787, and I will clarify this cygwin link.exe PATH issue >> in the >> OpenJDK Build readme soon. >> http://hg.openjdk.java.net/jdk7/build/raw-file/tip/README-builds.html >> >> -kto >> >> Max (Weijun) Wang wrote: >>> This is a conflict between link.exe of CYGWIN and MSVC. >>> >>> The formal process seems to suggest that you define environment >>> variables to inform make to locate the correct find.exe (the MSVC >>> one). I haven't tried it. I simply rename the link.exe in CYGWIN to >>> something else. >>> >>> -Max >>> >>> On Jul 22, 2008, at 8:13 PM, Ingo Proetel wrote: >>> >>>> Thanks that helped. >>>> >>>> Until I got here: >>>> link.exe bufferoverflowU.lib kernel32.lib user32.lib gdi32.lib >>>> winspool.lib comdlg32