Request for review: 6833444 version 2
Dmitri.Trembovetski at Sun.COM
Mon Apr 27 08:56:38 PDT 2009
Anthony Petrov wrote:
> Jon, Kelly, Xiomara,
> Thank you very much for your feedback. I decided to revise the fix to:
> 1. Leave the current c:\jdk default path for those who still uses it.
> 2. Issue a warning message on MS Windows platform if the BOOTDIR is
> located on the J: drive (that is assumed to be mapped over network).
> Here's the updated webrev:
> Please review.
> Some comments:
> On 04/23/2009 11:53 PM, Jonathan Gibbons wrote:
>> On pretty much any system you can tell if a drive is local or not,
>> albeit in a system specific way.
> That would be cool. However I don't see much justification around
> verifying for sure if a path is on the network. After all it's just a
> warning message, not a error.
It's very easy to check on windows (in shell, adjust appropriately for makefile):
net use j: > /dev/null 2>&1
if [ $? -ne 0 ]; then
# local drive
# remote drive
If you want to be fancy you could grep the output of net use for "Remote
Resource" or something..
More information about the build-dev