[Fwd: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]]
Tim.Bell at Sun.COM
Tue Mar 31 14:15:31 UTC 2009
Clearly this review is of interest to a wider audience.
This fixes the build problem Jon found and reported as 6819847
Until the fix is approved and pushed, the workaround is to add:
to your build environment.
-------- Original Message --------
Subject: Please review fix for 6819847 [Re: [Fwd: Problems with building
jmx for OpenJDK.]]
Date: Tue, 31 Mar 2009 07:08:41 -0700
From: Tim Bell <tim.bell at sun.com>
Kelly O'Hair wrote:
> I didn't think openjdk7 could build without binary plugs.
> But I've been a bit disconnected from the jdk work lately.
[... snip ...]
> I think I had on my list of things to do:
> * Change binary plugs default for openjdk6 to 'not use them'
> * Make sure openjdk7 builds without binary plugs
Please take a look at this fix:
This implements Kelly's wish "Change binary plugs default for openjdk6
to 'not use them'". Well - for OpenJDK7, it does. I'll have to check,
but I think OpenJDK6 is already doing this.
This builds OK with OPENJDK=true and:
1) No setting for IMPORT_BINARY_PLUGS at all. This works, and it
did NOT import anything. I expect the Linux distros build this way.
2) IMPORT_BINARY_PLUGS=false [Same as 1) above]
3) IMPORT_BINARY_PLUGS=true [PLUG IMPORT successful]
4) Nothing set [nothing imported]
JPRT job-IDs are included here so I could keep track and make sure I
looked at the log files.
One question - if the user goes to the trouble to set any of
(See the comments in jdk/make/common/Defs.gmk starting at line 127),
should we assume they must really, really want the binary plugs and
force IMPORT_BINARY_PLUGS=true? Or have them set it as well?
I am thinking we shouldn't do this automatically. I notice in the logs
that JPRT is setting these even when IMPORT_BINARY_PLUGS=false.
Otherwise, I think we are covered.
More information about the build-dev