[Fwd: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]]

Andrew John Hughes gnu_andrew at member.fsf.org
Tue Mar 31 14:32:04 UTC 2009

2009/3/31 Tim Bell <Tim.Bell at sun.com>:
> Clearly this review is of interest to a wider audience.
> This fixes the build problem Jon found and reported as 6819847
> Until the fix is approved and pushed, the workaround is to add:
> to your build environment.
> Tim
> -------- Original Message --------
> Subject: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx
> for OpenJDK.]]
> Date: Tue, 31 Mar 2009 07:08:41 -0700
> From: Tim Bell <tim.bell at sun.com>
> Kelly O'Hair wrote:
>> I didn't think openjdk7 could build without binary plugs.
>> But I've been a bit disconnected from the jdk work lately.

I didn't either.  The last build I tried using the hotspot-comp tree
(to test a patch for twisti) needed pointing at some binary plugs (I
use the fake IcedTea ones).  And I haven't seen it in any of the
recent change lists for 7

> [... snip ...]
>> I think I had on my list of things to do:
>>  * Change binary plugs default for openjdk6 to 'not use them'
>>  * Make sure openjdk7 builds without binary plugs
> Please take a look at this fix:
>   http://cr.openjdk.java.net/~tbell/6819847/
> This implements Kelly's wish "Change binary plugs default for openjdk6
> to 'not use them'".  Well - for OpenJDK7, it does.  I'll have to check,
> but I think OpenJDK6 is already doing this.

I think Dalibor committed this change to 6.  It's a lot less
controversial there, as the option has been available a long time,
just not the default.

> This builds OK with OPENJDK=true and:

Is this the default? I assume OPENJDK=false is only useful inside Sun.

> 1) No setting for IMPORT_BINARY_PLUGS at all.  This works, and it
> did NOT import anything.  I expect the Linux distros build this way.
>   2009-03-31-003747.tbell.6819847

Well the distros don't build 7 as far as I know, and I believe the
last OpenJDK6 build drop still used by IcedTea6 (the one before the
switch to hg) still uses fake plugs.  Whether it needs to or not is
another matter; I think it does because the default for b14 is to
import them (IMPORT_BINARY_PLUGS=true) and we don't set
defaulted to true for 6, as the audience building 'raw' OpenJDK6 (i.e.
not via IcedTea6) who want SNMP must be negligible enough to warrant
not being the default.

> 2) IMPORT_BINARY_PLUGS=false  [Same as 1) above]
>   2009-03-31-002722.tbell.6819847
> 3) IMPORT_BINARY_PLUGS=true   [PLUG IMPORT successful]
>   2009-03-31-020718.tbell.6819847
> 4) Nothing set  [nothing imported]
>   2009-03-31-045710.tbell.6819847

I'm guessing all these are too recent to be in a build drop yet.

> JPRT job-IDs are included here so I could keep track and make sure I
> looked at the log files.
> One question - if the user goes to the trouble to set any of
> (See the comments in jdk/make/common/Defs.gmk starting at line 127),
> should we assume they must really, really want the binary plugs and
> force IMPORT_BINARY_PLUGS=true?  Or have them set it as well?

I think that's a fair assumption, as long as you can be sure they did
set it and it didn't default to something.

> I am thinking we shouldn't do this automatically.  I notice in the logs
> that JPRT is setting these even when IMPORT_BINARY_PLUGS=false.
> Otherwise, I think we are covered.
> Tim

Really good to see this going in,

Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

More information about the build-dev mailing list