6856630: Restructure jaxp/jaxws repository
Kelly.Ohair at Sun.COM
Mon Oct 12 17:49:51 UTC 2009
I saw the webrev for a while, and now I can't :^(, but I saw enough...
>> Andrew John Hughes wrote:
>>> 2009/10/7 Andrew John Hughes <gnu_andrew at member.fsf.org>:
>>> I found a number of issues with the current version:
>>> * The drop zips are expected to be in a share/jdk7-drops subdirectory
>>> of the devtools directory. This doesn't really work outside Sun's
>>> internal setup. I've added support for ALT_DROP_DIR which can be used
>>> to specify an exact path to the zips. If this is not set, the old
>>> devtools behaviour is used.
I'm concerned about the name dropdir (your master copy location) vs. drop.dir
(destination for the exploded contents) in the property names. Seems confusing.
I hesitate to go on a name hunt, but what about ALT_DROP_BUNDLE_DIR and drop.bundle.dir?
>>> * The zips are being downloaded and extracted in the source directory,
>>> which could be read only. I've changed this so they are written to
>>> the build directory like everything else.
It turns out that we need this drop.dir to be in the source area if
we want the openjdk source zip bundles, created by RE, to include
the drop sources. These source bundles are created by bundling up
everything in the forest, prior to building, so the drop.dir needs
to be in the forest somehow. Otherwise, the bundling logic has to
merge two separate source trees, or different roots.
I was given a requirement that the openjdk source bundles include these
drop sources, easiest answer was drop.dir in the repo.
Not an unsurmountable problem, I avoided the more complicated path.
I know that becomes an issue if the repository or source is in a
read-only area, but that's not the only situation in the openjdk I suspect.
I assumed someone building from a read-only area could set
drop.dir to some other location.
Not sure what to say.
How important is it for the community that the openjdk source bundles
include these drop sources? e.g. ones at http://download.java.net/openjdk/jdk7/
If they are not included, when the openjdk source bundles are built,
they will need to download the jaxp and jaxws drop bundles at build time.
>>> The webrev for these changes is here:
>>> I've committed this to IcedTea already. Does this look ok for build also?
More information about the build-dev