From Ulf.Zibis at gmx.de Thu Dec 1 06:27:10 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Thu, 01 Dec 2011 15:27:10 +0100 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED6AEFF.6010003@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> <1322654721.26124.2.camel@jazzette> <4ED61D3C.1080501@oracle.com> <4ED62C7F.4030005@gmx.de> <4ED6AEFF.6010003@oracle.com> Message-ID: <4ED78EBE.6000403@gmx.de> Am 30.11.2011 23:32, schrieb David Holmes: > On 30/11/2011 11:15 PM, Ulf Zibis wrote: >> I more would like src/posix + src/winapi >> >> >> Combining Flat vs Hierarchical advantages: >> >> src/common or 'general' or 'independent' in homage to platform-independent >> src/posix >> src/posix.BSD >> src/posix.GNU >> src/posix.GNU.Linux >> src/posix.SYSV >> src/posix.SYSV.AIX >> src/posix.SYSV.Sun >> src/posix.X11 >> src/winapi >> src/winapi.32 >> src/winapi.CE > > But the BSD, GNU, SYSV api's are not POSIX - that's the whole point Oops, sorry for my low knowledge on that. Please only refer it as example for a folder naming schema. -Ulf From Ulf.Zibis at gmx.de Thu Dec 1 06:23:02 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Thu, 01 Dec 2011 15:23:02 +0100 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED66500.4020808@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> <1322654721.26124.2.camel@jazzette> <4ED61D3C.1080501@oracle.com> <4ED62C7F.4030005@gmx.de> <4ED66500.4020808@oracle.com> Message-ID: <4ED78DC6.5050109@gmx.de> Am 30.11.2011 18:16, schrieb Phil Race: > On 11/30/2011 5:15 AM, Ulf Zibis wrote: >> Am 30.11.2011 13:10, schrieb Dmitry Samersoff: >>> count me too for src/unix >>> +1 >> >> I more would like src/posix + src/winapi > > Which would be wrong. Its not just posix. More of the code in src/solaris > is related to UI stuff like GTK and core X11 APIs than anything else and > none of it is defined by posix. Also there's printing etc .. Thanks for your feedback Phil, I'm not the specialist here. I never meant just to rename 'solaris' to 'posix'. I additionally meant to move non-posix stuff to other additional places. > If you are going that route you'd be better to call it src/x11 and have that > imply posix .. rather than your misleading suggestion. I'm not sure, if I understand right. Nothing else I've proposed below by src/posix.X11 or src/posix-X11 -Ulf > > "unix" has a better implication of more than just posix. > > src/solaris is 13.4Mb in size. > A "du" check of the classes and native subdirs finds that at least > 9.7Mb that is GUI related. 4.5Mb in classes and 5.2Mb in native. > > -phil. > >> >> >> Combining Flat vs Hierarchical advantages: >> >> src/common or 'general' or 'independent' in homage to platform-independent >> src/posix >> src/posix.BSD >> src/posix.GNU >> src/posix.GNU.Linux >> src/posix.SYSV >> src/posix.SYSV.AIX >> src/posix.SYSV.Sun >> src/posix.X11 >> src/winapi >> src/winapi.32 >> src/winapi.CE >> >> Or "correctly": >> >> src/all >> src/all.posix >> src/all.posix.BSD >> src/all.posix.SYSV.Sun >> src/all.winapi >> >> Alternative: >> >> src/posix-GNU-Linux >> >> -Ulf >> > > From Dmitry.Samersoff at oracle.com Thu Dec 1 09:49:50 2011 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Thu, 01 Dec 2011 21:49:50 +0400 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED78EBE.6000403@gmx.de> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> <1322654721.26124.2.camel@jazzette> <4ED61D3C.1080501@oracle.com> <4ED62C7F.4030005@gmx.de> <4ED6AEFF.6010003@oracle.com> <4ED78EBE.6000403@gmx.de> Message-ID: <4ED7BE3E.8070708@oracle.com> Ulf, The problem is that (e.g.) MacOS or OpenBSD share some code from generic_unix and generic_bsd but has some unique code as well. We have to keep this logic somewhere. We have at least three options: 1. #ifdef - pro we can slowly migrate from #ifdef OpenBSD to #ifdef HAVE_MAD_LINKER cons it pollutes code and doesn't cover all cases. 2. Dir structure unix/generic bsd/generic /OpenBSD etc pro - well understandable cons - still not cover all cases 3. configure that create a build set by overwriting generic files with platform specific ones when necessary pro - could solve whole bunch of problems, not only platform one. cons - require some efforts to maintain. -Dmitry On 2011-12-01 18:27, Ulf Zibis wrote: > Am 30.11.2011 23:32, schrieb David Holmes: >> On 30/11/2011 11:15 PM, Ulf Zibis wrote: >>> I more would like src/posix + src/winapi >>> >>> >>> Combining Flat vs Hierarchical advantages: >>> >>> src/common or 'general' or 'independent' in homage to >>> platform-independent >>> src/posix >>> src/posix.BSD >>> src/posix.GNU >>> src/posix.GNU.Linux >>> src/posix.SYSV >>> src/posix.SYSV.AIX >>> src/posix.SYSV.Sun >>> src/posix.X11 >>> src/winapi >>> src/winapi.32 >>> src/winapi.CE >> >> But the BSD, GNU, SYSV api's are not POSIX - that's the whole point > > Oops, sorry for my low knowledge on that. Please only refer it as > example for a folder naming schema. > > -Ulf > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From magnus.ihse.bursie at oracle.com Fri Dec 2 00:38:29 2011 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 02 Dec 2011 09:38:29 +0100 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED7BE3E.8070708@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> <1322654721.26124.2.camel@jazzette> <4ED61D3C.1080501@oracle.com> <4ED62C7F.4030005@gmx.de> <4ED6AEFF.6010003@oracle.com> <4ED78EBE.6000403@gmx.de> <4ED7BE3E.8070708@oracle.com> Message-ID: <4ED88E85.9090500@oracle.com> On 2011-12-01 18:49, Dmitry Samersoff wrote: > We have at least three options: > > 1. #ifdef - > pro we can slowly migrate from > #ifdef OpenBSD to #ifdef HAVE_MAD_LINKER > cons it pollutes code and doesn't cover all cases. > > 2. Dir structure > unix/generic > bsd/generic > /OpenBSD > etc > > pro - well understandable > cons - still not cover all cases It might be useful to combine the two techniques. For small differences, a few lines at most, #ifdefs can work fine. If the differences are larger it might warrant putting them in a separate, platform-specific file. One one hand, it means that there is no clear-cut way of deciding how to handle platform-dependent code, so we must rely on rules of thumb and some subjectivity in deciding how to handle each case. On the other hand, it gives us much more flexibility and is likely to improve both reading and writing code, instead of having to strictly follow a system, possibly resulting in either large portions of the code #ifdeffed away for different platforms, or creation of small and trivial files with possible code duplication. And now for a slight disgression: As for the #ifdef CAPABILITY idea that are popular every now and then, I'm a bit sceptical. The problem is: what is a good level to determine a "capability"? In one extreme, you can imagine designing an #ifdef for every possible function call or type definition that can (possibly) be different between platforms. That would be so unpractical that it would be unusable. So, then you start thinking that you can group several different functions into a single category. Say, "if you have pthread_create then you also have pthread_exit, and a whole bunch of other functions -- let's call this the PTHREAD capability". I imagine this is what people think of when they say "capabilities". There are two problems with this. First, it's not clear when to stop this grouping if you continue upwards. If you have pthread capabilities, then you most likely also have full posix capabilities. So why test on pthread and not on posix? And in the end, we'll probably end up with a few bunch of groups which are basically mapping to the major operation systems/architectures we support -- that is, the very same kind of grouping that capabilities advocates want to move away from. The second problem is that many times the devil is in the details. Most unix-like OSes have "more or less" posix, but with certain, often quite small, idiosyncratic differences. Once again, we can add "capabilities" for these exceptions like SYSTEM_CALL_FOO_RETURNS_ZERO_ON_SUCCESS for each and everyone of them. Or, we can start grouping them, once again probably ending up with USE_LINUX_PECULIARITIES. I appreciate that there are situations where a specific subset of unix-like OSes do things one way, and other subsets another way, leading to code like: #if defined(SOLARIS) || defined(BSD) #elif defined(LINUX) || defined(AIX) #endif ... which is acceptable (but not nice) in #ifdefs, but hard to find a good solution to when using separate files. It might be possible, in these cases, to find proper grouping of capabilities that fits these actual use cases and test for these capability groups instead. And it might be possible to actually agree on a name on those capability gorups that doesn't suck. :-) And the end result might get better than testing explicitely for platforms. But I'm not convinced. And I think this should be used only when it is really motivated, and not as part of a general effort to "replace OS testing with capabilities testing". /Magnus From david.katleman at sun.com Tue Dec 6 08:45:55 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Tue, 06 Dec 2011 16:45:55 +0000 Subject: hg: jdk8/build/jaxws: 7117162: jdk8/jaxws/Makefile default DROPS_DIR should set to jdk8-drops Message-ID: <20111206164555.BBB80475A2@hg.openjdk.java.net> Changeset: 23c42f40fd3e Author: katleman Date: 2011-12-06 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/23c42f40fd3e 7117162: jdk8/jaxws/Makefile default DROPS_DIR should set to jdk8-drops Reviewed-by: ohair, xdono, mchung ! build.properties ! make/Makefile From david.katleman at sun.com Tue Dec 6 08:46:20 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Tue, 06 Dec 2011 16:46:20 +0000 Subject: hg: jdk8/build/jaxp: 7117162: jdk8/jaxws/Makefile default DROPS_DIR should set to jdk8-drops Message-ID: <20111206164620.CB117475A3@hg.openjdk.java.net> Changeset: e32444f13774 Author: katleman Date: 2011-12-06 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/e32444f13774 7117162: jdk8/jaxws/Makefile default DROPS_DIR should set to jdk8-drops Reviewed-by: ohair, xdono, mchung ! build.properties ! make/Makefile From david.katleman at sun.com Wed Dec 7 15:09:37 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 07 Dec 2011 23:09:37 +0000 Subject: hg: jdk8/build: Added tag jdk8-b15 for changeset a4f28069d44a Message-ID: <20111207230937.EF52747634@hg.openjdk.java.net> Changeset: 4e06ae613e99 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/4e06ae613e99 Added tag jdk8-b15 for changeset a4f28069d44a ! .hgtags From david.katleman at sun.com Wed Dec 7 15:09:44 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 07 Dec 2011 23:09:44 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b15 for changeset 7da69e7175a7 Message-ID: <20111207230945.8005247635@hg.openjdk.java.net> Changeset: 82dc033975bb Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/82dc033975bb Added tag jdk8-b15 for changeset 7da69e7175a7 ! .hgtags From david.katleman at sun.com Wed Dec 7 15:10:18 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 07 Dec 2011 23:10:18 +0000 Subject: hg: jdk8/build/hotspot: Added tag jdk8-b15 for changeset fde2a39ed7f3 Message-ID: <20111207231022.1369A47636@hg.openjdk.java.net> Changeset: d1f29d4e0bc6 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d1f29d4e0bc6 Added tag jdk8-b15 for changeset fde2a39ed7f3 ! .hgtags From david.katleman at sun.com Wed Dec 7 15:11:44 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 07 Dec 2011 23:11:44 +0000 Subject: hg: jdk8/build/jaxp: 2 new changesets Message-ID: <20111207231144.319E247637@hg.openjdk.java.net> Changeset: 8181f7634e4a Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/8181f7634e4a Added tag jdk8-b15 for changeset 804f666d6d44 ! .hgtags Changeset: 09eb517404b0 Author: katleman Date: 2011-12-07 13:02 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/09eb517404b0 Merge From david.katleman at sun.com Wed Dec 7 15:11:50 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 07 Dec 2011 23:11:50 +0000 Subject: hg: jdk8/build/jaxws: 2 new changesets Message-ID: <20111207231150.515A347638@hg.openjdk.java.net> Changeset: 76e37e606354 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/76e37e606354 Added tag jdk8-b15 for changeset c9ab96ff23d5 ! .hgtags Changeset: 3d45ab79643d Author: katleman Date: 2011-12-07 13:02 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/3d45ab79643d Merge From david.katleman at sun.com Wed Dec 7 15:12:01 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 07 Dec 2011 23:12:01 +0000 Subject: hg: jdk8/build/jdk: Added tag jdk8-b15 for changeset 3c248d0e2c48 Message-ID: <20111207231218.7962347639@hg.openjdk.java.net> Changeset: 929597c6e777 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/929597c6e777 Added tag jdk8-b15 for changeset 3c248d0e2c48 ! .hgtags From david.katleman at sun.com Wed Dec 7 15:13:53 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 07 Dec 2011 23:13:53 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b15 for changeset 07599bd780ca Message-ID: <20111207231357.06C394763A@hg.openjdk.java.net> Changeset: ec2c0973cc31 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ec2c0973cc31 Added tag jdk8-b15 for changeset 07599bd780ca ! .hgtags From kamesh.sampath at hotmail.com Mon Dec 5 10:50:18 2011 From: kamesh.sampath at hotmail.com (skamesh) Date: Mon, 5 Dec 2011 10:50:18 -0800 (PST) Subject: Building Open JDK 6 On Windows 7 Message-ID: <32919423.post@talk.nabble.com> Hi, i am trying to build a openjdk-6 package on Windows 7 (64-bit) with Visual Studio 2010. I am getting the COMPILER_PATH error though i have already run `eval make/scripts/vsvars.sh`. I did read few posts that openjdk6 requires VS2003 .. Can any one let me know if its possible to build the same with VS 2010 ? Since I don't have VS2003 and very difficult to find it after so many years. I was able to successfully build openjdk7 following the README.build with the same environment. Any help is much appreciated :) -Kamesh -- View this message in context: http://old.nabble.com/Building-Open-JDK-6-On-Windows-7-tp32919423p32919423.html Sent from the OpenJDK Build Infrastructure mailing list archive at Nabble.com. From denisl at openscg.com Mon Dec 12 11:30:01 2011 From: denisl at openscg.com (Lussier, Denis) Date: Mon, 12 Dec 2011 14:30:01 -0500 Subject: Building Open JDK 6 On Windows 7 In-Reply-To: <32919423.post@talk.nabble.com> References: <32919423.post@talk.nabble.com> Message-ID: Hi Kamesh, OpenSCG presently builds the 32-bit OpenJDK6 Windows binaries and installer and we use VS2003. I haven't had time to get the 64-bit Windows build working,. But... I have assembled a working (and properly licensed) virtual machine that I am interested in sharing with you. It is Windows XP 64 bit plus the proper SDK compiler as per the official build requirements. I also have experience on the 32 bit Windows build to share with you so that we can make sure the Win 64 build performs nicely on Fonts depending how we compile and link in with FreeType. --Denis L Lussier On Mon, Dec 5, 2011 at 1:50 PM, skamesh wrote: > > Hi, > > i am trying to build a openjdk-6 package on Windows 7 (64-bit) with Visual > Studio 2010. I am getting the COMPILER_PATH error though i have already run > `eval make/scripts/vsvars.sh`. I did read few posts that openjdk6 requires > VS2003 .. > > Can any one let me know if its possible to build the same with VS 2010 ? > Since I don't have VS2003 and very difficult to find it after so many > years. > > I was able to successfully build openjdk7 following the README.build with > the same environment. > > Any help is much appreciated :) > > -Kamesh > -- > View this message in context: > http://old.nabble.com/Building-Open-JDK-6-On-Windows-7-tp32919423p32919423.html > Sent from the OpenJDK Build Infrastructure mailing list archive at > Nabble.com. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20111212/320d8a4d/attachment.html From kelly.ohair at oracle.com Mon Dec 12 11:44:36 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 12 Dec 2011 11:44:36 -0800 Subject: Building Open JDK 6 On Windows 7 In-Reply-To: <32919423.post@talk.nabble.com> References: <32919423.post@talk.nabble.com> Message-ID: <657F98EB-CD49-4997-8681-5F7F65D8542D@oracle.com> openjdk6 would require source file changes and lots of makefile changes to build with VS2010. The transition of openjdk7 from VS2003 to VS2010 was a long and somewhat painful trip. Not that it isn't possible to do it for openjdk6, just no priority or need from my point of view. Of course, keep in mind that VS2010 is not supported on Windows 2000, and although it wouldn't be a huge deal to not support Windows 2000 for openjdk6, the Oracle jdk6 Update releases do use VS2003 and support Windows 2000. So if a goal is to keep openjdk6 lined up with Oracle jdk6 Update releases, this would create a difference. We just need to make this decision with eyes wide open. If the Oracle jdk6 Update releases gave up Windows 2000, and switched to VS2010, then that would certainly create a need to change openjdk6. -kto On Dec 5, 2011, at 10:50 AM, skamesh wrote: > > Hi, > > i am trying to build a openjdk-6 package on Windows 7 (64-bit) with Visual > Studio 2010. I am getting the COMPILER_PATH error though i have already run > `eval make/scripts/vsvars.sh`. I did read few posts that openjdk6 requires > VS2003 .. > > Can any one let me know if its possible to build the same with VS 2010 ? > Since I don't have VS2003 and very difficult to find it after so many years. > > I was able to successfully build openjdk7 following the README.build with > the same environment. > > Any help is much appreciated :) > > -Kamesh > -- > View this message in context: http://old.nabble.com/Building-Open-JDK-6-On-Windows-7-tp32919423p32919423.html > Sent from the OpenJDK Build Infrastructure mailing list archive at Nabble.com. > From kamesh.sampath at hotmail.com Mon Dec 12 14:21:56 2011 From: kamesh.sampath at hotmail.com (Kamesh Sampath) Date: Tue, 13 Dec 2011 03:51:56 +0530 Subject: Building Open JDK 6 On Windows 7 In-Reply-To: References: <32919423.post@talk.nabble.com> Message-ID: On 12/13/2011 01:00 AM, Lussier, Denis wrote: > Hi Kamesh, > > OpenSCG presently builds the 32-bit OpenJDK6 Windows binaries and > installer and we use VS2003. > > I haven't had time to get the 64-bit Windows build working,. But... I > have assembled a working > (and properly licensed) virtual machine that I am interested in > sharing with you. > > It is Windows XP 64 bit plus the proper SDK compiler as per the > official build requirements. > I also have experience on the 32 bit Windows build to share with you > so that we can make sure > the Win 64 build performs nicely on Fonts depending how we compile and > link in with FreeType. > > --Denis L Lussier > > On Mon, Dec 5, 2011 at 1:50 PM, skamesh > wrote: > > > Hi, > > i am trying to build a openjdk-6 package on Windows 7 (64-bit) > with Visual > Studio 2010. I am getting the COMPILER_PATH error though i have > already run > `eval make/scripts/vsvars.sh`. I did read few posts that openjdk6 > requires > VS2003 .. > > Can any one let me know if its possible to build the same with VS > 2010 ? > Since I don't have VS2003 and very difficult to find it after so > many years. > > I was able to successfully build openjdk7 following the > README.build with > the same environment. > > Any help is much appreciated :) > > -Kamesh > -- > View this message in context: > http://old.nabble.com/Building-Open-JDK-6-On-Windows-7-tp32919423p32919423.html > Sent from the OpenJDK Build Infrastructure mailing list archive at > Nabble.com. > > Hi Denis, That's awesome, is the VM open to all, if show where can I download it from ? If that's not workable can you please let me know typically some steps kind of guide on what softwares are required and the download URL for the same so that I can set-up my build-env to build openjdk6 on Windows 7 (64-bit) using VS2010 --Kamesh -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20111213/ea447230/attachment.html From denisl at openscg.com Mon Dec 12 14:27:07 2011 From: denisl at openscg.com (Lussier, Denis) Date: Mon, 12 Dec 2011 17:27:07 -0500 Subject: Building Open JDK 6 On Windows 7 In-Reply-To: References: <32919423.post@talk.nabble.com> Message-ID: Hi Kamesh, I cannot legally make the virtual machine open to all because of Windoze licensing issues. I can make it avaialble to you since I am not using it any longer. The rest of this thread will be taken off group. --Luss On Mon, Dec 12, 2011 at 5:21 PM, Kamesh Sampath wrote: > On 12/13/2011 01:00 AM, Lussier, Denis wrote: > > Hi Kamesh, > > OpenSCG presently builds the 32-bit OpenJDK6 Windows binaries and > installer and we use VS2003. > > I haven't had time to get the 64-bit Windows build working,. But... I > have assembled a working > (and properly licensed) virtual machine that I am interested in sharing > with you. > > It is Windows XP 64 bit plus the proper SDK compiler as per the official > build requirements. > I also have experience on the 32 bit Windows build to share with you so > that we can make sure > the Win 64 build performs nicely on Fonts depending how we compile and > link in with FreeType. > > --Denis L Lussier > > On Mon, Dec 5, 2011 at 1:50 PM, skamesh wrote: > >> >> Hi, >> >> i am trying to build a openjdk-6 package on Windows 7 (64-bit) with Visual >> Studio 2010. I am getting the COMPILER_PATH error though i have already >> run >> `eval make/scripts/vsvars.sh`. I did read few posts that openjdk6 requires >> VS2003 .. >> >> Can any one let me know if its possible to build the same with VS 2010 ? >> Since I don't have VS2003 and very difficult to find it after so many >> years. >> >> I was able to successfully build openjdk7 following the README.build with >> the same environment. >> >> Any help is much appreciated :) >> >> -Kamesh >> -- >> View this message in context: >> http://old.nabble.com/Building-Open-JDK-6-On-Windows-7-tp32919423p32919423.html >> Sent from the OpenJDK Build Infrastructure mailing list archive at >> Nabble.com. >> >> > Hi Denis, > > That's awesome, is the VM open to all, if show where can I download it > from ? If that's not workable can you please let me know typically some > steps kind of guide on what softwares are required and the download URL for > the same so that I can set-up my build-env to build openjdk6 on Windows 7 > (64-bit) using VS2010 > > --Kamesh > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20111212/ca9e5b3c/attachment.html From matthew.waddell at cognex.com Tue Dec 13 17:58:40 2011 From: matthew.waddell at cognex.com (Waddell, Matthew) Date: Tue, 13 Dec 2011 20:58:40 -0500 Subject: Static linkage of JVM.lib Message-ID: Forgive me if this seems like an obvious question, but are there any examples of anyone statically linking against the win_x86 jvm? From the poking around that I've done, I cannot find any evidence that that this can be done out-of the box. Thanks, _matt [cid:image001.png at 01CCB9BC.C32CDFF0] -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20111213/b0f3e270/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.png Type: image/png Size: 447 bytes Desc: image001.png Url : http://mail.openjdk.java.net/pipermail/build-dev/attachments/20111213/b0f3e270/image001.png From dalibor.topic at oracle.com Wed Dec 14 03:06:52 2011 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Wed, 14 Dec 2011 12:06:52 +0100 Subject: Review request (XS): 7110396: Sound code fails to build on multiarch Linux systems In-Reply-To: <4EBBA69F.60003@oracle.com> References: <20111110052456.AEC78111B@eggemoggin.niobe.net> <4EBBA69F.60003@oracle.com> Message-ID: <4EE8834C.8060200@oracle.com> Once this is pushed into jdk8, please consider backporting it to jdk7u - I'm seeing the same issue with jdk7u-dev on Ubuntu 11.10. cheers, dalibor topic On 11/10/11 11:25 AM, Alex Menkov wrote: > Looks good > > regards > Alex > > On 10.11.2011 09:24, mark.reinhold at oracle.com wrote: >> Some Linux distros have started to adopt a "multiarch" filesystem layout for >> shared libraries in order to support the installation of packages for multiple >> hardware architectures on a single system. For more information see, e.g., >> http://wiki.debian.org/Multiarch. >> >> In Ubuntu 11.10 the ALSA shared library, libasound2, was converted to the >> multiarch format and so its files moved from their old location, /usr/lib, >> to /usr/lib/${ARCH_TRIPLET}. This caused the JDK build to fail when linking >> the Java sound library. The root cause appears to be that gcc only tries to >> resolve undefined symbols against a multiarch library if the library is named >> on the command line after the object files containing those symbols. >> >> The fix is simply to move -lasound to the end of the gcc invocation. >> >> I'll push this into JDK 8. It would trivially backport to 7. >> >> Patch: >> >> --- a/make/javax/sound/jsoundalsa/Makefile >> +++ b/make/javax/sound/jsoundalsa/Makefile >> @@ -65,7 +65,7 @@ >> $(MIDIFILES_export) \ >> $(PORTFILES_export) >> >> -LDFLAGS += -lasound >> +EXTRA_LIBS += -lasound >> >> CPPFLAGS += \ >> -DUSE_DAUDIO=TRUE \ >> >> Thanks, >> - Mark -- Oracle Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 | Mobile: +491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From david.katleman at sun.com Wed Dec 14 14:36:31 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 14 Dec 2011 22:36:31 +0000 Subject: hg: jdk8/build/jdk: 61 new changesets Message-ID: <20111214224627.E3B75476BE@hg.openjdk.java.net> Changeset: 23acf34c80b0 Author: neugens Date: 2011-12-03 15:40 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/23acf34c80b0 7117914: Fix javac warnings in src/share/classes/sun/java2d Summary: Fix some javac warnings in java2d related code for the Warning Cleanup Day. Reviewed-by: prr, flar ! src/share/classes/java/awt/geom/Path2D.java ! src/share/classes/sun/awt/image/BufImgSurfaceData.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/SurfaceData.java ! src/share/classes/sun/java2d/SurfaceDataProxy.java ! src/share/classes/sun/java2d/loops/GraphicsPrimitive.java ! src/share/classes/sun/java2d/loops/SurfaceType.java ! src/share/classes/sun/java2d/opengl/OGLBufImgOps.java ! src/share/classes/sun/java2d/opengl/OGLDrawImage.java ! src/share/classes/sun/java2d/opengl/OGLPaints.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceData.java ! src/share/classes/sun/java2d/pipe/AAShapePipe.java ! src/share/classes/sun/java2d/pipe/BufferedPaints.java ! src/share/classes/sun/java2d/pipe/BufferedRenderPipe.java ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/classes/sun/java2d/pipe/GlyphListPipe.java ! src/share/classes/sun/java2d/pipe/LoopPipe.java ! src/share/classes/sun/java2d/pipe/RenderingEngine.java ! src/solaris/classes/sun/java2d/x11/X11Renderer.java ! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java Changeset: 70b40ea06df0 Author: prr Date: 2011-12-03 16:26 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/70b40ea06df0 7117199: Fix javac warnings in src/share/classes/java/awt/font Reviewed-by: jgodinez, bae ! src/share/classes/java/awt/font/StyledParagraph.java ! src/share/classes/java/awt/font/TextAttribute.java ! src/share/classes/java/awt/font/TextLayout.java ! src/share/classes/java/awt/font/TextLine.java ! src/share/classes/java/awt/font/TextMeasurer.java Changeset: 4075d524fa46 Author: lana Date: 2011-12-06 16:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4075d524fa46 Merge Changeset: e53a078c2840 Author: anthony Date: 2011-11-09 13:43 +0300 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e53a078c2840 7045370: Java Statically Determines Display Size on Linux platforms Summary: Listen to ConfigureNotify events on the root window and update the current screen size accordingly Reviewed-by: art, bae ! src/share/classes/java/awt/Component.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/native/sun/awt/awt_GraphicsEnv.c Changeset: 84e473cf4531 Author: rupashka Date: 2011-11-10 14:10 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/84e473cf4531 6938583: Unexpected NullPointerException by InputContext.endComposition() Reviewed-by: rupashka Contributed-by: Charles Lee ! src/share/classes/javax/swing/text/DefaultCaret.java + test/javax/swing/text/DefaultCaret/6938583/bug6938583.java Changeset: 81f1b32f9e24 Author: malenkov Date: 2011-11-10 17:15 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/81f1b32f9e24 7057459: Regression: Performance degradation with java.beans.XMLEncoder Reviewed-by: rupashka ! src/share/classes/java/beans/Encoder.java Changeset: e120c78cb45c Author: malenkov Date: 2011-11-10 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e120c78cb45c 7064279: Introspector.getBeanInfo() should release some resources in timely manner Reviewed-by: art, alexp ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyEditorManager.java + src/share/classes/java/beans/ThreadGroupContext.java ! test/java/beans/Beans/6669869/TestDesignTime.java ! test/java/beans/Beans/6669869/TestGuiAvailable.java ! test/java/beans/Introspector/6380849/TestBeanInfo.java + test/java/beans/Introspector/7064279/Test7064279.java + test/java/beans/Introspector/7064279/test.jar ! test/java/beans/Introspector/Test6660539.java ! test/java/beans/PropertyEditor/6380849/TestPropertyEditor.java Changeset: 8b6a69b2e482 Author: malenkov Date: 2011-11-10 17:32 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8b6a69b2e482 7087876: java/beans/PropertyDescriptor.html#createPropertyEditor() throws RE if editor cannot be created Reviewed-by: rupashka ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/PropertyEditor/Test7087876.java Changeset: b02495c51b9c Author: malenkov Date: 2011-11-10 17:35 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b02495c51b9c 7092744: XMLEncoder fails to encode and breaks backward compatibility Reviewed-by: rupashka ! src/share/classes/com/sun/beans/finder/AbstractFinder.java ! src/share/classes/com/sun/beans/finder/ConstructorFinder.java ! src/share/classes/com/sun/beans/finder/MethodFinder.java + test/java/beans/XMLEncoder/Test7092744.java Changeset: 16327765859c Author: malenkov Date: 2011-11-10 17:37 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/16327765859c 7087429: Constructor of java.beans.PropertyChangeEvent should declare thrown NPE for null source Reviewed-by: rupashka ! src/share/classes/java/beans/PropertyChangeEvent.java + test/java/beans/PropertyChangeSupport/Test7087429.java Changeset: f614bcada2a9 Author: anthony Date: 2011-11-11 15:17 +0300 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f614bcada2a9 7103610: _NET_WM_PID and WM_CLIENT_MACHINE are not set Summary: Set the properties to all top-level windows Reviewed-by: anthony Contributed-by: Danesh Dadachanji ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/native/sun/xawt/XToolkit.c Changeset: c0f3f1558a94 Author: rupashka Date: 2011-11-14 14:00 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c0f3f1558a94 7109617: Test was writed for Metal L&F but not set it Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/plaf/metal/MetalLookAndFeel/5073047/bug5073047.java Changeset: a51777c9228a Author: malenkov Date: 2011-11-14 14:38 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a51777c9228a 7110521: Regression test failed: Introspector/TestTypeResolver.java Reviewed-by: rupashka ! test/java/beans/Introspector/TestTypeResolver.java Changeset: 28f768c41a90 Author: serb Date: 2011-11-12 04:13 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/28f768c41a90 6996291: command line selection of MToolkit by -Dawt.toolkit=sun.awt.motif.MToolkit fails from jdk7 b21 on Reviewed-by: art, dcherepanov, bae, prr ! make/sun/awt/FILES_c_unix.gmk ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/awt/mawt.gmk - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/ListHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxyPeer.java - src/solaris/classes/sun/awt/motif/AWTLockAccess.java ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h ! src/solaris/native/sun/awt/awt.h ! src/solaris/native/sun/awt/awt_AWTEvent.c ! src/solaris/native/sun/awt/awt_Component.h - src/solaris/native/sun/awt/awt_Cursor.h ! src/solaris/native/sun/awt/awt_DrawingSurface.c ! src/solaris/native/sun/awt/awt_Font.c ! src/solaris/native/sun/awt/awt_Font.h ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_InputMethod.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h ! src/solaris/native/sun/awt/awt_Robot.c - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h ! src/solaris/native/sun/awt/awt_p.h ! src/solaris/native/sun/awt/awt_util.c ! src/solaris/native/sun/awt/awt_util.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h ! src/solaris/native/sun/awt/canvas.h ! src/solaris/native/sun/awt/multi_font.c ! src/solaris/native/sun/awt/multi_font.h ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.h ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/xawt/XToolkit.c Changeset: 6a9d735ebd0a Author: bagiras Date: 2011-11-16 15:40 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6a9d735ebd0a 7108598: Pogo Table Games freeze with JDK 7 Reviewed-by: art, ant ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java + test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java Changeset: 1df53949945d Author: lana Date: 2011-11-18 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1df53949945d Merge Changeset: 90d33a64a404 Author: rupashka Date: 2011-11-21 18:22 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/90d33a64a404 7109085: Test use hotkeys not intended for Mac Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! test/javax/swing/regtesthelpers/Util.java + test/javax/swing/text/DefaultEditorKit/4278839/bug4278839.java + test/javax/swing/text/JTextComponent/5074573/bug5074573.java + test/javax/swing/text/html/HTMLEditorKit/5043626/bug5043626.java Changeset: c3c80f96cb83 Author: rupashka Date: 2011-11-25 11:52 +0300 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c3c80f96cb83 7113337: Swing closed test tries to click in the area reserved for resize by Mac OS X Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java Changeset: 9cbc208dcf08 Author: rupashka Date: 2011-11-29 12:47 +0300 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9cbc208dcf08 7112925: closed/javax/swing/JTabbedPane/4624207/bug4624207.java fails on MacOS Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JTabbedPane/4624207/bug4624207.java Changeset: 051beb804b12 Author: rupashka Date: 2011-11-30 16:54 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/051beb804b12 7110440: closed/javax/swing/JScrollBar/4865918/bug4865918.java fails on Aqua L&F Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JScrollBar/4865918/bug4865918.java Changeset: 7dd4395fe4a5 Author: rupashka Date: 2011-11-30 19:38 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7dd4395fe4a5 7115357: closed/javax/swing/JTable/6263446/bug6263446Table.java fails on MacOS Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JTable/6263446/bug6263446.java Changeset: 4b416a0180dc Author: lana Date: 2011-11-29 15:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4b416a0180dc Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 45eb5a61da07 Author: lana Date: 2011-11-30 12:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/45eb5a61da07 Merge Changeset: 79b5c5a8c7e9 Author: serb Date: 2011-12-05 17:11 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/79b5c5a8c7e9 7115400: jdk 8 awt-gate build fails in headless toolkit on solaris. Reviewed-by: prr, art, bae ! make/sun/awt/FILES_c_unix.gmk + src/solaris/native/sun/awt/HeadlessToolkit.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.h Changeset: 2b1438297561 Author: lana Date: 2011-12-06 16:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2b1438297561 Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h Changeset: 387190e1f782 Author: chegar Date: 2011-11-25 10:34 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/387190e1f782 7115150: java.net.HttpCookie code cleanup, style, formatting, typos Reviewed-by: michaelm ! src/share/classes/java/net/HttpCookie.java Changeset: e5ecbf555679 Author: chegar Date: 2011-11-25 13:46 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e5ecbf555679 7115586: Suppress creation of SocketImpl in SocketAdaptor's constructor Reviewed-by: chegar, alanb Contributed-by: sajia at taobao.com ! src/share/classes/sun/nio/ch/SocketAdaptor.java Changeset: 022540b11147 Author: weijun Date: 2011-11-28 18:16 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/022540b11147 7115744: Do not call File::deleteOnExit in security tests Reviewed-by: xuelei ! test/sun/security/krb5/auto/CrossRealm.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/OkAsDelegateXRealm.java ! test/sun/security/krb5/auto/OneKDC.java ! test/sun/security/krb5/auto/SSL.java ! test/sun/security/krb5/auto/W83.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngineResult/Deserialize.java Changeset: d1928ae4e0a2 Author: xuelei Date: 2011-11-28 02:35 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d1928ae4e0a2 7115524: sun.security.provider.certpath.ssl.SSLServerCertStore no longer works Reviewed-by: weijun ! src/share/classes/sun/security/provider/certpath/ssl/SSLServerCertStore.java Changeset: 955aae8c1106 Author: ngmr Date: 2011-11-24 11:34 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/955aae8c1106 7115070: (fs) lookupPrincipalByName/lookupPrincipalByGroupName should treat ESRCH as not found Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c Changeset: 6fbd69f8e3ab Author: ngmr Date: 2011-11-18 09:03 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6fbd69f8e3ab 7094995: Trailing daemon thread causes continuous GC in agentvm mode Summary: Shutdown GcInducingThread once test (successfully) finishes Reviewed-by: alanb, chegar, dholmes, darcy Contributed-by: Neil Richards ! test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java Changeset: cf47846165f4 Author: dholmes Date: 2011-11-29 00:26 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cf47846165f4 7109092: Wrong computation results with double at armsflt Summary: need to link to custom soft-float library with required FP accuracy Reviewed-by: alanb, ohair ! make/common/Defs-embedded.gmk Changeset: a47de985fec9 Author: sherman Date: 2011-11-29 11:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a47de985fec9 7110149: Update the JDK8 bundled zlib library to the latest version 1.2.5 Summary: updated to zlib-1.2.5 Reviewed-by: alanb ! make/common/Defs.gmk ! make/java/zip/FILES_c.gmk ! make/sun/splashscreen/FILES_c.gmk - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h + src/share/native/java/util/zip/zlib-1.2.5/ChangeLog + src/share/native/java/util/zip/zlib-1.2.5/README + src/share/native/java/util/zip/zlib-1.2.5/compress.c + src/share/native/java/util/zip/zlib-1.2.5/crc32.h + src/share/native/java/util/zip/zlib-1.2.5/deflate.c + src/share/native/java/util/zip/zlib-1.2.5/deflate.h + src/share/native/java/util/zip/zlib-1.2.5/gzclose.c + src/share/native/java/util/zip/zlib-1.2.5/gzguts.h + src/share/native/java/util/zip/zlib-1.2.5/gzlib.c + src/share/native/java/util/zip/zlib-1.2.5/gzread.c + src/share/native/java/util/zip/zlib-1.2.5/gzwrite.c + src/share/native/java/util/zip/zlib-1.2.5/infback.c + src/share/native/java/util/zip/zlib-1.2.5/inffast.c + src/share/native/java/util/zip/zlib-1.2.5/inffast.h + src/share/native/java/util/zip/zlib-1.2.5/inffixed.h + src/share/native/java/util/zip/zlib-1.2.5/inflate.c + src/share/native/java/util/zip/zlib-1.2.5/inflate.h + src/share/native/java/util/zip/zlib-1.2.5/inftrees.c + src/share/native/java/util/zip/zlib-1.2.5/inftrees.h + src/share/native/java/util/zip/zlib-1.2.5/patches/ChangeLog_java + src/share/native/java/util/zip/zlib-1.2.5/trees.c + src/share/native/java/util/zip/zlib-1.2.5/trees.h + src/share/native/java/util/zip/zlib-1.2.5/uncompr.c + src/share/native/java/util/zip/zlib-1.2.5/zadler32.c + src/share/native/java/util/zip/zlib-1.2.5/zconf.h + src/share/native/java/util/zip/zlib-1.2.5/zcrc32.c + src/share/native/java/util/zip/zlib-1.2.5/zlib.h + src/share/native/java/util/zip/zlib-1.2.5/zutil.c + src/share/native/java/util/zip/zlib-1.2.5/zutil.h + test/java/util/zip/DeInflate.java Changeset: 07e359b01d8a Author: sherman Date: 2011-11-29 13:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/07e359b01d8a 7109837: Provide a mechanism for computing an Adler32 checksum for the contents of a ByteBuffer Summary: added methods Adler32/CRC32.update(ByteBuffer) Reviewed-by: alanb ! make/java/zip/mapfile-vers ! src/share/classes/java/util/zip/Adler32.java ! src/share/classes/java/util/zip/CRC32.java ! src/share/native/java/util/zip/Adler32.c ! src/share/native/java/util/zip/CRC32.c + test/java/util/zip/TimeChecksum.java Changeset: c5313d712ab0 Author: lana Date: 2011-11-29 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c5313d712ab0 Merge Changeset: a3edcdff37e1 Author: lana Date: 2011-11-29 13:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a3edcdff37e1 Merge Changeset: 4749df4f04f1 Author: alanb Date: 2011-11-30 10:57 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4749df4f04f1 7030624: size_t usages in src/windows/native/java/io/io_util_md.c need to be re-visited Reviewed-by: lancea, chegar ! src/share/native/java/io/io_util.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.h Changeset: 7795c41ed54c Author: alanb Date: 2011-11-30 12:42 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7795c41ed54c 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes) Reviewed-by: lancea, chegar, smarks ! src/share/classes/java/io/File.java ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/io/SequenceInputStream.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Enum.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/Runtime.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/ThreadGroup.java ! src/share/classes/java/rmi/MarshalledObject.java ! src/share/classes/java/rmi/dgc/VMID.java ! src/share/classes/java/rmi/server/LogStream.java ! src/share/classes/java/rmi/server/RemoteObject.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/misc/Launcher.java ! src/share/classes/sun/misc/Unsafe.java ! src/share/classes/sun/misc/VM.java Changeset: 43a630f11af6 Author: smarks Date: 2011-11-30 13:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/43a630f11af6 7116322: enhance javac make rule with a little bit of instrumentation Reviewed-by: dholmes, ohair ! make/common/Rules.gmk Changeset: 3b8186aee592 Author: chegar Date: 2011-12-01 11:09 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3b8186aee592 7116722: Miscellaneous warnings sun.misc ( and related classes ) Reviewed-by: alanb, darcy, forax, hawtin, lancea ! src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/java/util/jar/JavaUtilJarAccessImpl.java ! src/share/classes/javax/script/ScriptEngineManager.java ! src/share/classes/sun/misc/BASE64Decoder.java ! src/share/classes/sun/misc/ExtensionDependency.java ! src/share/classes/sun/misc/JarIndex.java ! src/share/classes/sun/misc/JavaUtilJarAccess.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/misc/Service.java ! src/share/classes/sun/misc/Signal.java ! test/sun/misc/JarIndex/metaInfFilenames/Basic.java Changeset: 89130611b178 Author: mcimadamore Date: 2011-12-01 18:34 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/89130611b178 7116954: Misc warnings in java.beans/java.beans.context Summary: Remove generic warnings form java.beans and java.beans.context Reviewed-by: alanb, chegar ! src/share/classes/java/beans/BeanDescriptor.java ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/ChangeListenerMap.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/EventHandler.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/FeatureDescriptor.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/MetaData.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/NameGenerator.java ! src/share/classes/java/beans/PersistenceDelegate.java ! src/share/classes/java/beans/PropertyChangeSupport.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/java/beans/PropertyEditorSupport.java ! src/share/classes/java/beans/ReflectionUtils.java ! src/share/classes/java/beans/SimpleBeanInfo.java ! src/share/classes/java/beans/Statement.java ! src/share/classes/java/beans/VetoableChangeSupport.java ! src/share/classes/java/beans/XMLEncoder.java ! src/share/classes/java/beans/beancontext/BeanContext.java ! src/share/classes/java/beans/beancontext/BeanContextMembershipEvent.java Changeset: 0e3f706741ca Author: smarks Date: 2011-12-01 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0e3f706741ca 7116890: additional warnings fixes for java.io Reviewed-by: alanb, smarks Contributed-by: Sebastian Sickelmann ! src/share/classes/java/io/ExpiringCache.java ! src/share/classes/java/io/LineNumberInputStream.java ! src/share/classes/java/io/LineNumberReader.java ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java Changeset: b03da32c3186 Author: peytoia Date: 2011-12-02 16:09 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b03da32c3186 7056472: Speed up test/java/util/ResourceBundle/Control/ExpirationTest.sh Reviewed-by: okutsu - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: f615db07991e Author: chegar Date: 2011-12-02 11:39 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f615db07991e 7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service providers Reviewed-by: prr ! src/share/classes/com/sun/media/sound/JSSecurityManager.java Changeset: 37f6e294759f Author: chegar Date: 2011-12-02 14:17 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/37f6e294759f 7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers Reviewed-by: alanb, lancea ! src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java ! src/share/classes/javax/script/ScriptEngineManager.java ! src/share/classes/sun/net/ftp/FtpClientProvider.java Changeset: 9950e2c9f3b5 Author: alanb Date: 2011-12-02 17:37 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9950e2c9f3b5 7117357: Warnings in sun.instrument, tools and other sun.* classes Reviewed-by: lancea, chegar ! src/share/classes/sun/instrument/InstrumentationImpl.java ! src/share/classes/sun/instrument/TransformerManager.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/management/counter/perf/PerfInstrumentation.java ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java ! src/share/classes/sun/net/RegisteredDomain.java ! src/share/classes/sun/net/www/protocol/jar/Handler.java ! src/share/classes/sun/tools/attach/HotSpotAttachProvider.java ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jps/Jps.java ! src/share/classes/sun/tools/jstack/JStack.java ! src/share/classes/sun/tools/serialver/SerialVer.java Changeset: 42532a097816 Author: naoto Date: 2011-12-02 16:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/42532a097816 7117465: Warning cleanup for IMF classes Reviewed-by: okutsu ! src/share/classes/java/awt/im/InputMethodHighlight.java ! src/share/classes/sun/awt/im/CompositionArea.java ! src/share/classes/sun/awt/im/CompositionAreaHandler.java ! src/share/classes/sun/awt/im/InputContext.java ! src/share/classes/sun/awt/im/InputMethodContext.java ! src/share/classes/sun/awt/im/InputMethodJFrame.java ! src/share/classes/sun/awt/im/InputMethodManager.java ! src/share/classes/sun/awt/im/SimpleInputMethodWindow.java Changeset: 1d7037df65ed Author: sherman Date: 2011-12-02 16:25 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1d7037df65ed 5035850: (str) String.CASE_INSENSITIVE_ORDER should override readResolve() Summary: Fix to ensure singleton property of String.CaseInsensitiveComparator is maintained through de/serialization. Reviewed-by: alanb, forax, smarks, dholmes Contributed-by: darryl.mocek at oracle.com ! src/share/classes/java/lang/String.java + test/java/lang/String/CaseInsensitiveComparator.java Changeset: 98502d7a3f98 Author: mchung Date: 2011-12-02 16:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/98502d7a3f98 7117585: Eliminate java.lang.instrument, java.lang.management warnings Reviewed-by: mchung Contributed-by: Jon VanAlten ! src/share/classes/java/lang/instrument/ClassDefinition.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/PlatformComponent.java Changeset: 3c524deb8431 Author: lancea Date: 2011-12-02 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3c524deb8431 7116445: Miscellaneous warnings in the JDBC/RowSet classes Reviewed-by: smarks, chegar ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/WebRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetReader.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/Row.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/Time.java ! src/share/classes/java/sql/Timestamp.java ! src/share/classes/javax/sql/StatementEvent.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java Changeset: f2a5d0001f15 Author: okutsu Date: 2011-12-03 10:58 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f2a5d0001f15 7117487: Warnings Cleanup: some i18n classes in java.util and sun.util Reviewed-by: lancea, naoto ! src/share/classes/java/util/Date.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/sun/util/calendar/BaseCalendar.java ! src/share/classes/sun/util/calendar/CalendarSystem.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! src/share/classes/sun/util/calendar/ZoneInfo.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/resources/OpenListResourceBundle.java ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java Changeset: 2ae848ea980a Author: weijun Date: 2011-12-05 10:19 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2ae848ea980a 7116857: Warnings in javax.security and some sun.misc Reviewed-by: smarks ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/sun/misc/CEFormatException.java ! src/share/classes/sun/misc/CEStreamExhausted.java ! src/share/classes/sun/misc/ClassLoaderUtil.java ! src/share/classes/sun/misc/CompoundEnumeration.java ! src/share/classes/sun/misc/ExtensionInstallationException.java ! src/share/classes/sun/misc/FloatingDecimal.java ! src/share/classes/sun/misc/FormattedFloatingDecimal.java ! src/share/classes/sun/misc/InvalidJarIndexException.java ! src/share/classes/sun/misc/LRUCache.java ! src/share/classes/sun/misc/Queue.java ! src/share/classes/sun/misc/RequestProcessor.java ! src/share/classes/sun/misc/ServiceConfigurationError.java ! src/share/classes/sun/misc/URLClassPath.java Changeset: 053cb321467a Author: alanb Date: 2011-12-05 12:23 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/053cb321467a 7117717: (aio) Tests failing due to implementation bug 7052549 Reviewed-by: weijun, chegar ! test/ProblemList.txt ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java Changeset: da28826c5672 Author: alanb Date: 2011-12-05 12:24 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/da28826c5672 Merge Changeset: f352dd3cdff8 Author: dl Date: 2011-12-05 13:58 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f352dd3cdff8 7117360: Warnings in java.util.concurrent.atomic package Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicStampedReference.java Changeset: 194faa6fdb3c Author: sherman Date: 2011-12-05 10:50 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/194faa6fdb3c 5063455: (fmt) MissingFormatArgumentException.getFormatSpecifier() incorrect return value Summary: updated the incorrect StringBuilder constructor usage Reviewed-by: dholmes, sherman Contributed-by: brandon.passanisi at oracle.com ! src/share/classes/java/util/Formatter.java + test/java/util/MissingFormatArgumentException/GetFormatSpecifier.java Changeset: ca383e32deaf Author: peytoia Date: 2011-12-06 08:39 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ca383e32deaf 7116914: Miscellaneous warnings (sun.text) Reviewed-by: smarks, okutsu ! src/share/classes/sun/text/CompactByteArray.java ! src/share/classes/sun/text/IntHashtable.java ! src/share/classes/sun/text/bidi/BidiBase.java ! src/share/classes/sun/text/normalizer/ICUData.java ! src/share/classes/sun/text/normalizer/NormalizerBase.java ! src/share/classes/sun/text/normalizer/NormalizerImpl.java ! src/share/classes/sun/text/normalizer/SymbolTable.java ! src/share/classes/sun/text/normalizer/UnicodeSet.java ! src/share/classes/sun/text/normalizer/UnicodeSetIterator.java ! src/share/classes/sun/text/normalizer/VersionInfo.java Changeset: f4fe86bba8a2 Author: smarks Date: 2011-12-05 16:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f4fe86bba8a2 7116993: fix warnings in java.applet Reviewed-by: art, smarks Contributed-by: Danesh Dadachanji ! src/share/classes/java/applet/Applet.java Changeset: 85363edbc92f Author: naoto Date: 2011-12-05 17:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/85363edbc92f 7117469: Warning cleanup for j.u.Currency and j.u.Locale related classes Reviewed-by: okutsu, smarks ! src/share/classes/java/util/Currency.java ! src/share/classes/sun/util/LocaleServiceProviderPool.java ! src/share/classes/sun/util/resources/LocaleData.java Changeset: 77f6d4360f4b Author: smarks Date: 2011-12-06 10:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/77f6d4360f4b 7116997: fix warnings in java.util.PropertyPermission Reviewed-by: smarks Contributed-by: Brandon Passanisi ! src/share/classes/java/util/PropertyPermission.java Changeset: b71d1acfae52 Author: lana Date: 2011-12-06 20:25 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b71d1acfae52 Merge ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyDescriptor.java - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh From david.katleman at sun.com Wed Dec 14 14:48:42 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 14 Dec 2011 22:48:42 +0000 Subject: hg: jdk8/build/langtools: 10 new changesets Message-ID: <20111214224902.DBDB6476BF@hg.openjdk.java.net> Changeset: c896d95e7469 Author: mcimadamore Date: 2011-11-24 13:36 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c896d95e7469 7115046: Add AST node for lambda expressions Summary: Add tree nodes for representing lambda expressions and update relevant visitors interfaces Reviewed-by: jjg + src/share/classes/com/sun/source/tree/LambdaExpressionTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java Changeset: ec59a2ce9114 Author: mcimadamore Date: 2011-11-24 13:38 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ec59a2ce9114 7115049: Add AST node for method references Summary: Add tree nodes for representing method/constructor references and update relevant visitors interfaces Reviewed-by: jjg + src/share/classes/com/sun/source/tree/MemberReferenceTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java Changeset: 9448fe783fd2 Author: mcimadamore Date: 2011-11-28 15:56 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/9448fe783fd2 7115050: Add parser support for lambda expressions Summary: Add support for parsing lambda expressions to JavacParser Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Lexer.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples/CatchWithoutTry.java + test/tools/javac/diags/examples/LambdaNotSupported.java + test/tools/javac/diags/examples/NotAStatement.java ! test/tools/javac/generics/rare/6665356/T6665356.out + test/tools/javac/lambda/LambdaParserTest.java Changeset: 3343b22e2761 Author: mcimadamore Date: 2011-11-28 16:05 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3343b22e2761 7115052: Add parser support for method references Summary: Add support for parsing method references to JavacParser Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples/IllegalChar.java + test/tools/javac/diags/examples/MethodReferencesNotSupported.java + test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/quid/T6999438.out Changeset: 2584f5358cba Author: lana Date: 2011-12-06 20:26 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/2584f5358cba Merge Changeset: abfa0d8ea803 Author: ksrini Date: 2011-12-07 10:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/abfa0d8ea803 7086015: fix test/tools/javac/parser/netbeans/JavacParserTest.java Reviewed-by: ksrini, jjg Contributed-by: matherey.nunez at oracle.com ! test/tools/javac/parser/netbeans/JavacParserTest.java Changeset: 9350d0498d21 Author: ksrini Date: 2011-12-09 08:40 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/9350d0498d21 7119032: (javac) increase visibility of JavacParser methods to improve subtyping Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java Changeset: e7d5e1a7cde5 Author: ksrini Date: 2011-12-10 17:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e7d5e1a7cde5 7119487: JavacParserTest.java test fails on Windows platforms Reviewed-by: jjg + test/tools/javac/parser/JavacParserTest.java - test/tools/javac/parser/netbeans/JavacParserTest.java Changeset: e55270a7a022 Author: mcimadamore Date: 2011-12-11 17:48 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e55270a7a022 7120266: javac fails to compile hotspot code Summary: Parser changes for method references cause bad intercation with method call syntax Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/T7120266.java ! test/tools/javac/lambda/MethodReferenceParserTest.java Changeset: 1cbe86c11ba6 Author: lana Date: 2011-12-12 10:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/1cbe86c11ba6 Merge - test/tools/javac/parser/netbeans/JavacParserTest.java From michael.fang at sun.com Thu Dec 15 13:48:30 2011 From: michael.fang at sun.com (michael.fang at sun.com) Date: Thu, 15 Dec 2011 21:48:30 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20111215214904.94862476ED@hg.openjdk.java.net> Changeset: 60dd940eb58e Author: yhuang Date: 2011-12-12 18:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/60dd940eb58e 7003124: In Bulgarian Locale DateFormat is wrong Reviewed-by: naoto, peytoia ! src/share/classes/sun/text/resources/FormatData_bg.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: cd03cd0e0965 Author: mfang Date: 2011-12-15 11:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cd03cd0e0965 Merge From stuart.marks at oracle.com Thu Dec 15 18:59:40 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 15 Dec 2011 18:59:40 -0800 Subject: please review 7122061: enable -Werror in various jdk build steps Message-ID: <4EEAB41C.5000300@oracle.com> The webrev is here: http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/ This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables in a variety of Makefiles within the jdk repository. This essentially adds -Xlint:all -Werror to the javac command lines, so that henceforth if any lint warnings are introduced, the build will fail. I'm applying these flags only to build steps that are already warnings free. (Last week's warnings cleanup effort cleared warnings from four build steps, in addition to knocking off a couple thousand warnings across the build.) I've applied this change and have built successfully on all platforms. With this change, 57 of the 93 javac build steps in the jdk repo are now lint warning free, and are protected from the introduction of new errors through the use of -Werror. Thanks, s'marks From kelly.ohair at oracle.com Thu Dec 15 19:14:09 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 15 Dec 2011 19:14:09 -0800 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EEAB41C.5000300@oracle.com> References: <4EEAB41C.5000300@oracle.com> Message-ID: <0864B6A9-54EE-4AFB-AF5F-509C6C0A96FE@oracle.com> Looks ok. -kto On Dec 15, 2011, at 6:59 PM, Stuart Marks wrote: > The webrev is here: > > http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/ > > This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables in a variety of Makefiles within the jdk repository. This essentially adds -Xlint:all -Werror to the javac command lines, so that henceforth if any lint warnings are introduced, the build will fail. > > I'm applying these flags only to build steps that are already warnings free. (Last week's warnings cleanup effort cleared warnings from four build steps, in addition to knocking off a couple thousand warnings across the build.) I've applied this change and have built successfully on all platforms. > > With this change, 57 of the 93 javac build steps in the jdk repo are now lint warning free, and are protected from the introduction of new errors through the use of -Werror. > > Thanks, > > s'marks From david.holmes at oracle.com Thu Dec 15 21:23:22 2011 From: david.holmes at oracle.com (David Holmes) Date: Fri, 16 Dec 2011 15:23:22 +1000 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EEAB41C.5000300@oracle.com> References: <4EEAB41C.5000300@oracle.com> Message-ID: <4EEAD5CA.2000803@oracle.com> Hi Stuart, On 16/12/2011 12:59 PM, Stuart Marks wrote: > The webrev is here: > > http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/ Looks fine but ... > This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables > in a variety of Makefiles within the jdk repository. This essentially > adds -Xlint:all -Werror to the javac command lines, so that henceforth > if any lint warnings are introduced, the build will fail. > > I'm applying these flags only to build steps that are already warnings > free. (Last week's warnings cleanup effort cleared warnings from four > build steps, in addition to knocking off a couple thousand warnings > across the build.) I've applied this change and have built successfully > on all platforms. > > With this change, 57 of the 93 javac build steps in the jdk repo are now > lint warning free, and are protected from the introduction of new errors > through the use of -Werror. ... as we're past the half-way point should we not set these by default and change the non-warning free steps to override them? That way as an area becomes warning free we would include the removal of the override as part of the changeset. That way when we get to being warning-free there should only be one occurrence of: JAVAC_MAX_WARNINGS = true JAVAC_WARNINGS_FATAL = true in the whole build system. Just a thought ;-) Cheers, David > > Thanks, > > s'marks From Alan.Bateman at oracle.com Fri Dec 16 01:57:31 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 16 Dec 2011 09:57:31 +0000 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EEAB41C.5000300@oracle.com> References: <4EEAB41C.5000300@oracle.com> Message-ID: <4EEB160B.2060909@oracle.com> On 16/12/2011 02:59, Stuart Marks wrote: > The webrev is here: > > http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/ > > This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables > in a variety of Makefiles within the jdk repository. This essentially > adds -Xlint:all -Werror to the javac command lines, so that henceforth > if any lint warnings are introduced, the build will fail. > > I'm applying these flags only to build steps that are already warnings > free. (Last week's warnings cleanup effort cleared warnings from four > build steps, in addition to knocking off a couple thousand warnings > across the build.) I've applied this change and have built > successfully on all platforms. > > With this change, 57 of the 93 javac build steps in the jdk repo are > now lint warning free, and are protected from the introduction of new > errors through the use of -Werror. > > Thanks, > > s'marks Stuart - the changes look okay to me but it would be good to get confirmation that you've done both full and partial builds with these changes. Also I think we need confirmation that incremental builds in each of these areas isn't impacted. My concern is implicit compilation where compiling code in warning free areas may compile code in areas that are not warning free yet. Sasha did great work over the summer and part of his approach was to make warnings fatal in the errors that he cleaned up. On a couple of occasions we ran into issues where implicit compilation caused code in areas with warnings to be compiled. Such issues are usually quick to fix but I'm sure you get my concern. -Ala From chris.hegarty at oracle.com Fri Dec 16 02:39:18 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 16 Dec 2011 10:39:18 +0000 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EEB160B.2060909@oracle.com> References: <4EEAB41C.5000300@oracle.com> <4EEB160B.2060909@oracle.com> Message-ID: <4EEB1FD6.60707@oracle.com> On 12/16/11 09:57 AM, Alan Bateman wrote: > On 16/12/2011 02:59, Stuart Marks wrote: >> ... > Stuart - the changes look okay to me but it would be good to get > confirmation that you've done both full and partial builds with these > changes. Also I think we need confirmation that incremental builds in > each of these areas isn't impacted. My concern is implicit compilation > where compiling code in warning free areas may compile code in areas > that are not warning free yet. Sasha did great work over the summer and > part of his approach was to make warnings fatal in the errors that he > cleaned up. On a couple of occasions we ran into issues where implicit > compilation caused code in areas with warnings to be compiled. Such > issues are usually quick to fix but I'm sure you get my concern. I agree with Alan here, we need to be careful that incremental/partial builds are still ok. We found some issues relating to this in the networking area recently. Have there been changes recently to the -Xlint options or something? I was horrified to find yesterday that my build completed "successfully" even though there was an error in HttpURLConnection.java. This networking class was being implicitly compiled by other makefiles, that seems to have Xlint enabled, but not fatal. I need to look into why this didn't cause the build to fail. -Chris. > > -Ala > From chris.hegarty at oracle.com Fri Dec 16 06:13:51 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 16 Dec 2011 14:13:51 +0000 Subject: Build succeeds even if JDK source file fails to compile Message-ID: <4EEB521F.4010601@oracle.com> I filed CR 7122235 for this issue. Forcing a compile time error of a JDK class by inserting some bad code is just ignored and the build continues, and appears to complete successfully. I believe the changes for CR 7116322 "enhance javac make rule with a little bit of instrumentation", caused this problem. Changeset for 7116322: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 After the javac cmd is run there is a simple echo to indicate 'javac finished'. I am not a makefile expert, but I think the makefiles are checking the return code for this directive/rule and now will always see the successful return code of the echo, so it will never fail. Example: # Running javac: 18 files; in /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 -encoding ascii -Xbootclasspath:../../../../../build/solaris-i586/classes -sourcepath ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes -d ../../../../../build/solaris-i586/classes @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: error: missing return statement } ^ Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. 1 error # javac finished make381[3]: Leaving directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' make381[3]: Entering directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' make381[3]: Leaving directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' make381[3]: Entering directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' -Chris. From kelly.ohair at oracle.com Fri Dec 16 09:26:00 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 16 Dec 2011 09:26:00 -0800 Subject: Build succeeds even if JDK source file fails to compile In-Reply-To: <4EEB521F.4010601@oracle.com> References: <4EEB521F.4010601@oracle.com> Message-ID: You are correct. This changeset was wrong. Mandy was asking me about this a while back and I was also noticing the problem with a recent problem Maurizio was having doing boot cycle builds on Linux, where javac failed, make did not stop, and merrily crashed later in javah. :^( -kto On Dec 16, 2011, at 6:13 AM, Chris Hegarty wrote: > I filed CR 7122235 for this issue. > > Forcing a compile time error of a JDK class by inserting some bad code is just ignored and the build continues, and appears to complete successfully. > > I believe the changes for CR 7116322 "enhance javac make rule with a little bit of instrumentation", caused this problem. > > Changeset for 7116322: > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 > > After the javac cmd is run there is a simple echo to indicate 'javac finished'. I am not a makefile expert, but I think the makefiles are checking the return code for this directive/rule and now will always see the successful return code of the echo, so it will never fail. > > Example: > > # Running javac: 18 files; in /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl > /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 -encoding ascii -Xbootclasspath:../../../../../build/solaris-i586/classes -sourcepath ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes -d ../../../../../build/solaris-i586/classes @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered > ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: error: missing return statement > } > ^ > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > 1 error > # javac finished > make381[3]: Leaving directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' > make381[3]: Entering directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' > make381[3]: Leaving directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' > make381[3]: Entering directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' > > -Chris. From mandy.chung at oracle.com Fri Dec 16 10:12:37 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 16 Dec 2011 10:12:37 -0800 Subject: Build succeeds even if JDK source file fails to compile In-Reply-To: References: <4EEB521F.4010601@oracle.com> Message-ID: <4EEB8A15.3020408@oracle.com> On 12/16/2011 9:26 AM, Kelly O'Hair wrote: > You are correct. This changeset was wrong. > Chris - good find. > Mandy was asking me about this a while back That was Wednesday - not long ago. jigsaw build has a similar issue: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/diff/459b6cbb0de7/make/common/Rules.gmk that I have fixed. I didn't get the chance to check on jdk8/tl yet. Mandy > and I was also noticing the problem with a recent > problem Maurizio was having doing boot cycle builds on Linux, where javac failed, make did not stop, > and merrily crashed later in javah. :^( > > -kto > > On Dec 16, 2011, at 6:13 AM, Chris Hegarty wrote: > >> I filed CR 7122235 for this issue. >> >> Forcing a compile time error of a JDK class by inserting some bad code is just ignored and the build continues, and appears to complete successfully. >> >> I believe the changes for CR 7116322 "enhance javac make rule with a little bit of instrumentation", caused this problem. >> >> Changeset for 7116322: >> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 >> >> After the javac cmd is run there is a simple echo to indicate 'javac finished'. I am not a makefile expert, but I think the makefiles are checking the return code for this directive/rule and now will always see the successful return code of the echo, so it will never fail. >> >> Example: >> >> # Running javac: 18 files; in /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl >> /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 -encoding ascii -Xbootclasspath:../../../../../build/solaris-i586/classes -sourcepath ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes -d ../../../../../build/solaris-i586/classes @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered >> ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: error: missing return statement >> } >> ^ >> Note: Some input files use or override a deprecated API. >> Note: Recompile with -Xlint:deprecation for details. >> 1 error >> # javac finished >> make381[3]: Leaving directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' >> make381[3]: Entering directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >> make381[3]: Leaving directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >> make381[3]: Entering directory `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' >> >> -Chris. From stuart.marks at oracle.com Fri Dec 16 10:59:18 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Fri, 16 Dec 2011 10:59:18 -0800 Subject: Build succeeds even if JDK source file fails to compile In-Reply-To: <4EEB521F.4010601@oracle.com> References: <4EEB521F.4010601@oracle.com> Message-ID: <4EEB9506.70202@oracle.com> Yeah, that was me. I'll make sure this is fixed before the -Werror changes go in. s'marks On 12/16/11 6:13 AM, Chris Hegarty wrote: > I filed CR 7122235 for this issue. > > Forcing a compile time error of a JDK class by inserting some bad code is just > ignored and the build continues, and appears to complete successfully. > > I believe the changes for CR 7116322 "enhance javac make rule with a little bit > of instrumentation", caused this problem. > > Changeset for 7116322: > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 > > After the javac cmd is run there is a simple echo to indicate 'javac finished'. > I am not a makefile expert, but I think the makefiles are checking the return > code for this directive/rule and now will always see the successful return code > of the echo, so it will never fail. > > Example: > > # Running javac: 18 files; in > /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl > /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac > -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions > -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m > -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror > -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 -encoding > ascii -Xbootclasspath:../../../../../build/solaris-i586/classes -sourcepath > ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes > -d ../../../../../build/solaris-i586/classes > @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered > ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: > error: missing return statement > } > ^ > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > 1 error > # javac finished > make381[3]: Leaving directory > `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' > make381[3]: Entering directory > `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' > make381[3]: Leaving directory > `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' > make381[3]: Entering directory > `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' > > -Chris. From stuart.marks at oracle.com Fri Dec 16 11:58:15 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Fri, 16 Dec 2011 11:58:15 -0800 Subject: Build succeeds even if JDK source file fails to compile In-Reply-To: <4EEB8A15.3020408@oracle.com> References: <4EEB521F.4010601@oracle.com> <4EEB8A15.3020408@oracle.com> Message-ID: <4EEBA2D7.8060206@oracle.com> Here's a fix I'm working on. I'm still doing test builds but I wanted to get this in front of people pretty quickly. The initial diagnosis was correct; adding an "echo" (or some other command) after the javac will prevent javac's failure code from reaching make and thus not stopping the build if there is an error. The fix is to use && instead of ; to separate the commands, i.e. javac && echo "# javac finished" If javac fails this will abort the commands chained with && and report the failure code back to make. Diff below. s'marks diff -r c647ebb3c4f7 make/common/Rules.gmk --- a/make/common/Rules.gmk Tue Dec 13 15:41:47 2011 -0800 +++ b/make/common/Rules.gmk Fri Dec 16 11:52:48 2011 -0800 @@ -239,7 +239,7 @@ $(CAT) $<.filtered; \ $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered && \ $(ECHO) "# javac finished"; \ fi @$(java-vm-cleanup) On 12/16/11 10:12 AM, Mandy Chung wrote: > On 12/16/2011 9:26 AM, Kelly O'Hair wrote: >> You are correct. This changeset was wrong. >> > > Chris - good find. > >> Mandy was asking me about this a while back > > That was Wednesday - not long ago. jigsaw build has a similar issue: > http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/diff/459b6cbb0de7/make/common/Rules.gmk > > > that I have fixed. I didn't get the chance to check on jdk8/tl yet. > > Mandy > >> and I was also noticing the problem with a recent >> problem Maurizio was having doing boot cycle builds on Linux, where javac >> failed, make did not stop, >> and merrily crashed later in javah. :^( >> >> -kto >> >> On Dec 16, 2011, at 6:13 AM, Chris Hegarty wrote: >> >>> I filed CR 7122235 for this issue. >>> >>> Forcing a compile time error of a JDK class by inserting some bad code is >>> just ignored and the build continues, and appears to complete successfully. >>> >>> I believe the changes for CR 7116322 "enhance javac make rule with a little >>> bit of instrumentation", caused this problem. >>> >>> Changeset for 7116322: >>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 >>> >>> After the javac cmd is run there is a simple echo to indicate 'javac >>> finished'. I am not a makefile expert, but I think the makefiles are >>> checking the return code for this directive/rule and now will always see the >>> successful return code of the echo, so it will never fail. >>> >>> Example: >>> >>> # Running javac: 18 files; in >>> /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl >>> /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac >>> -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions >>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m >>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror >>> -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 >>> -encoding ascii -Xbootclasspath:../../../../../build/solaris-i586/classes >>> -sourcepath >>> ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes >>> -d ../../../../../build/solaris-i586/classes >>> @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered >>> >>> ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: >>> error: missing return statement >>> } >>> ^ >>> Note: Some input files use or override a deprecated API. >>> Note: Recompile with -Xlint:deprecation for details. >>> 1 error >>> # javac finished >>> make381[3]: Leaving directory >>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' >>> make381[3]: Entering directory >>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>> make381[3]: Leaving directory >>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>> make381[3]: Entering directory >>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' >>> >>> -Chris. From kelly.ohair at oracle.com Fri Dec 16 12:56:42 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 16 Dec 2011 12:56:42 -0800 Subject: Build succeeds even if JDK source file fails to compile In-Reply-To: <4EEBA2D7.8060206@oracle.com> References: <4EEB521F.4010601@oracle.com> <4EEB8A15.3020408@oracle.com> <4EEBA2D7.8060206@oracle.com> Message-ID: <99680DDB-2C0B-431B-8520-C693C20028A7@oracle.com> Change looks good. -kto On Dec 16, 2011, at 11:58 AM, Stuart Marks wrote: > Here's a fix I'm working on. I'm still doing test builds but I wanted to get this in front of people pretty quickly. > > The initial diagnosis was correct; adding an "echo" (or some other command) after the javac will prevent javac's failure code from reaching make and thus not stopping the build if there is an error. > > The fix is to use && instead of ; to separate the commands, i.e. > > javac && echo "# javac finished" > > If javac fails this will abort the commands chained with && and report the failure code back to make. > > Diff below. > > s'marks > > > > diff -r c647ebb3c4f7 make/common/Rules.gmk > --- a/make/common/Rules.gmk Tue Dec 13 15:41:47 2011 -0800 > +++ b/make/common/Rules.gmk Fri Dec 16 11:52:48 2011 -0800 > @@ -239,7 +239,7 @@ > $(CAT) $<.filtered; \ > $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ > $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ > - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ > + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered && \ > $(ECHO) "# javac finished"; \ > fi > @$(java-vm-cleanup) > > > On 12/16/11 10:12 AM, Mandy Chung wrote: >> On 12/16/2011 9:26 AM, Kelly O'Hair wrote: >>> You are correct. This changeset was wrong. >>> >> >> Chris - good find. >> >>> Mandy was asking me about this a while back >> >> That was Wednesday - not long ago. jigsaw build has a similar issue: >> http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/diff/459b6cbb0de7/make/common/Rules.gmk >> >> >> that I have fixed. I didn't get the chance to check on jdk8/tl yet. >> >> Mandy >> >>> and I was also noticing the problem with a recent >>> problem Maurizio was having doing boot cycle builds on Linux, where javac >>> failed, make did not stop, >>> and merrily crashed later in javah. :^( >>> >>> -kto >>> >>> On Dec 16, 2011, at 6:13 AM, Chris Hegarty wrote: >>> >>>> I filed CR 7122235 for this issue. >>>> >>>> Forcing a compile time error of a JDK class by inserting some bad code is >>>> just ignored and the build continues, and appears to complete successfully. >>>> >>>> I believe the changes for CR 7116322 "enhance javac make rule with a little >>>> bit of instrumentation", caused this problem. >>>> >>>> Changeset for 7116322: >>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 >>>> >>>> After the javac cmd is run there is a simple echo to indicate 'javac >>>> finished'. I am not a makefile expert, but I think the makefiles are >>>> checking the return code for this directive/rule and now will always see the >>>> successful return code of the echo, so it will never fail. >>>> >>>> Example: >>>> >>>> # Running javac: 18 files; in >>>> /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl >>>> /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac >>>> -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions >>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m >>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror >>>> -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 >>>> -encoding ascii -Xbootclasspath:../../../../../build/solaris-i586/classes >>>> -sourcepath >>>> ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes >>>> -d ../../../../../build/solaris-i586/classes >>>> @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered >>>> >>>> ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: >>>> error: missing return statement >>>> } >>>> ^ >>>> Note: Some input files use or override a deprecated API. >>>> Note: Recompile with -Xlint:deprecation for details. >>>> 1 error >>>> # javac finished >>>> make381[3]: Leaving directory >>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' >>>> make381[3]: Entering directory >>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>> make381[3]: Leaving directory >>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>> make381[3]: Entering directory >>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' >>>> >>>> -Chris. From chris.hegarty at oracle.com Fri Dec 16 15:25:20 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 16 Dec 2011 23:25:20 +0000 Subject: Build succeeds even if JDK source file fails to compile In-Reply-To: <99680DDB-2C0B-431B-8520-C693C20028A7@oracle.com> References: <4EEB521F.4010601@oracle.com> <4EEB8A15.3020408@oracle.com> <4EEBA2D7.8060206@oracle.com> <99680DDB-2C0B-431B-8520-C693C20028A7@oracle.com> Message-ID: <8AF0CE1F-D559-4CD6-8D52-86CEA6408656@oracle.com> On 16 Dec 2011, at 20:56, Kelly O'Hair wrote: > Change looks good. +1 -Chris > > -kto > > On Dec 16, 2011, at 11:58 AM, Stuart Marks wrote: > >> Here's a fix I'm working on. I'm still doing test builds but I wanted to get this in front of people pretty quickly. >> >> The initial diagnosis was correct; adding an "echo" (or some other command) after the javac will prevent javac's failure code from reaching make and thus not stopping the build if there is an error. >> >> The fix is to use && instead of ; to separate the commands, i.e. >> >> javac && echo "# javac finished" >> >> If javac fails this will abort the commands chained with && and report the failure code back to make. >> >> Diff below. >> >> s'marks >> >> >> >> diff -r c647ebb3c4f7 make/common/Rules.gmk >> --- a/make/common/Rules.gmk Tue Dec 13 15:41:47 2011 -0800 >> +++ b/make/common/Rules.gmk Fri Dec 16 11:52:48 2011 -0800 >> @@ -239,7 +239,7 @@ >> $(CAT) $<.filtered; \ >> $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ >> $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >> - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >> + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered && \ >> $(ECHO) "# javac finished"; \ >> fi >> @$(java-vm-cleanup) >> >> >> On 12/16/11 10:12 AM, Mandy Chung wrote: >>> On 12/16/2011 9:26 AM, Kelly O'Hair wrote: >>>> You are correct. This changeset was wrong. >>>> >>> >>> Chris - good find. >>> >>>> Mandy was asking me about this a while back >>> >>> That was Wednesday - not long ago. jigsaw build has a similar issue: >>> http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/diff/459b6cbb0de7/make/common/Rules.gmk >>> >>> >>> that I have fixed. I didn't get the chance to check on jdk8/tl yet. >>> >>> Mandy >>> >>>> and I was also noticing the problem with a recent >>>> problem Maurizio was having doing boot cycle builds on Linux, where javac >>>> failed, make did not stop, >>>> and merrily crashed later in javah. :^( >>>> >>>> -kto >>>> >>>> On Dec 16, 2011, at 6:13 AM, Chris Hegarty wrote: >>>> >>>>> I filed CR 7122235 for this issue. >>>>> >>>>> Forcing a compile time error of a JDK class by inserting some bad code is >>>>> just ignored and the build continues, and appears to complete successfully. >>>>> >>>>> I believe the changes for CR 7116322 "enhance javac make rule with a little >>>>> bit of instrumentation", caused this problem. >>>>> >>>>> Changeset for 7116322: >>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 >>>>> >>>>> After the javac cmd is run there is a simple echo to indicate 'javac >>>>> finished'. I am not a makefile expert, but I think the makefiles are >>>>> checking the return code for this directive/rule and now will always see the >>>>> successful return code of the echo, so it will never fail. >>>>> >>>>> Example: >>>>> >>>>> # Running javac: 18 files; in >>>>> /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl >>>>> /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac >>>>> -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions >>>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m >>>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror >>>>> -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 >>>>> -encoding ascii -Xbootclasspath:../../../../../build/solaris-i586/classes >>>>> -sourcepath >>>>> ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes >>>>> -d ../../../../../build/solaris-i586/classes >>>>> @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered >>>>> >>>>> ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: >>>>> error: missing return statement >>>>> } >>>>> ^ >>>>> Note: Some input files use or override a deprecated API. >>>>> Note: Recompile with -Xlint:deprecation for details. >>>>> 1 error >>>>> # javac finished >>>>> make381[3]: Leaving directory >>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' >>>>> make381[3]: Entering directory >>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>>> make381[3]: Leaving directory >>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>>> make381[3]: Entering directory >>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' >>>>> >>>>> -Chris. > From maurizio.cimadamore at oracle.com Fri Dec 16 15:28:12 2011 From: maurizio.cimadamore at oracle.com (maurizio cimadamore) Date: Fri, 16 Dec 2011 23:28:12 +0000 Subject: Build succeeds even if JDK source file fails to compile In-Reply-To: <8AF0CE1F-D559-4CD6-8D52-86CEA6408656@oracle.com> References: <4EEB521F.4010601@oracle.com> <4EEB8A15.3020408@oracle.com> <4EEBA2D7.8060206@oracle.com> <99680DDB-2C0B-431B-8520-C693C20028A7@oracle.com> <8AF0CE1F-D559-4CD6-8D52-86CEA6408656@oracle.com> Message-ID: <4EEBD40C.7000702@oracle.com> On 16-Dec-11 11:25 PM, Chris Hegarty wrote: > On 16 Dec 2011, at 20:56, Kelly O'Hair wrote: > >> Change looks good. > +1 Thumbs up! Maurizio > > -Chris > >> -kto >> >> On Dec 16, 2011, at 11:58 AM, Stuart Marks wrote: >> >>> Here's a fix I'm working on. I'm still doing test builds but I wanted to get this in front of people pretty quickly. >>> >>> The initial diagnosis was correct; adding an "echo" (or some other command) after the javac will prevent javac's failure code from reaching make and thus not stopping the build if there is an error. >>> >>> The fix is to use&& instead of ; to separate the commands, i.e. >>> >>> javac&& echo "# javac finished" >>> >>> If javac fails this will abort the commands chained with&& and report the failure code back to make. >>> >>> Diff below. >>> >>> s'marks >>> >>> >>> >>> diff -r c647ebb3c4f7 make/common/Rules.gmk >>> --- a/make/common/Rules.gmk Tue Dec 13 15:41:47 2011 -0800 >>> +++ b/make/common/Rules.gmk Fri Dec 16 11:52:48 2011 -0800 >>> @@ -239,7 +239,7 @@ >>> $(CAT) $<.filtered; \ >>> $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ >>> $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >>> - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >>> + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered&& \ >>> $(ECHO) "# javac finished"; \ >>> fi >>> @$(java-vm-cleanup) >>> >>> >>> On 12/16/11 10:12 AM, Mandy Chung wrote: >>>> On 12/16/2011 9:26 AM, Kelly O'Hair wrote: >>>>> You are correct. This changeset was wrong. >>>>> >>>> Chris - good find. >>>> >>>>> Mandy was asking me about this a while back >>>> That was Wednesday - not long ago. jigsaw build has a similar issue: >>>> http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/diff/459b6cbb0de7/make/common/Rules.gmk >>>> >>>> >>>> that I have fixed. I didn't get the chance to check on jdk8/tl yet. >>>> >>>> Mandy >>>> >>>>> and I was also noticing the problem with a recent >>>>> problem Maurizio was having doing boot cycle builds on Linux, where javac >>>>> failed, make did not stop, >>>>> and merrily crashed later in javah. :^( >>>>> >>>>> -kto >>>>> >>>>> On Dec 16, 2011, at 6:13 AM, Chris Hegarty wrote: >>>>> >>>>>> I filed CR 7122235 for this issue. >>>>>> >>>>>> Forcing a compile time error of a JDK class by inserting some bad code is >>>>>> just ignored and the build continues, and appears to complete successfully. >>>>>> >>>>>> I believe the changes for CR 7116322 "enhance javac make rule with a little >>>>>> bit of instrumentation", caused this problem. >>>>>> >>>>>> Changeset for 7116322: >>>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 >>>>>> >>>>>> After the javac cmd is run there is a simple echo to indicate 'javac >>>>>> finished'. I am not a makefile expert, but I think the makefiles are >>>>>> checking the return code for this directive/rule and now will always see the >>>>>> successful return code of the echo, so it will never fail. >>>>>> >>>>>> Example: >>>>>> >>>>>> # Running javac: 18 files; in >>>>>> /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl >>>>>> /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac >>>>>> -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions >>>>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx512m >>>>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror >>>>>> -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 >>>>>> -encoding ascii -Xbootclasspath:../../../../../build/solaris-i586/classes >>>>>> -sourcepath >>>>>> ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes >>>>>> -d ../../../../../build/solaris-i586/classes >>>>>> @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered >>>>>> >>>>>> ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: >>>>>> error: missing return statement >>>>>> } >>>>>> ^ >>>>>> Note: Some input files use or override a deprecated API. >>>>>> Note: Recompile with -Xlint:deprecation for details. >>>>>> 1 error >>>>>> # javac finished >>>>>> make381[3]: Leaving directory >>>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' >>>>>> make381[3]: Entering directory >>>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>>>> make381[3]: Leaving directory >>>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>>>> make381[3]: Entering directory >>>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' >>>>>> >>>>>> -Chris. From david.holmes at oracle.com Sat Dec 17 01:06:48 2011 From: david.holmes at oracle.com (David Holmes) Date: Sat, 17 Dec 2011 19:06:48 +1000 Subject: Build succeeds even if JDK source file fails to compile In-Reply-To: <4EEBA2D7.8060206@oracle.com> References: <4EEB521F.4010601@oracle.com> <4EEB8A15.3020408@oracle.com> <4EEBA2D7.8060206@oracle.com> Message-ID: <4EEC5BA8.5040406@oracle.com> Looks good to me too. And the original change seemed so innocuous. David On 17/12/2011 5:58 AM, Stuart Marks wrote: > Here's a fix I'm working on. I'm still doing test builds but I wanted to > get this in front of people pretty quickly. > > The initial diagnosis was correct; adding an "echo" (or some other > command) after the javac will prevent javac's failure code from reaching > make and thus not stopping the build if there is an error. > > The fix is to use && instead of ; to separate the commands, i.e. > > javac && echo "# javac finished" > > If javac fails this will abort the commands chained with && and report > the failure code back to make. > > Diff below. > > s'marks > > > > diff -r c647ebb3c4f7 make/common/Rules.gmk > --- a/make/common/Rules.gmk Tue Dec 13 15:41:47 2011 -0800 > +++ b/make/common/Rules.gmk Fri Dec 16 11:52:48 2011 -0800 > @@ -239,7 +239,7 @@ > $(CAT) $<.filtered; \ > $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ > $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered; \ > - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered; \ > + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered && \ > $(ECHO) "# javac finished"; \ > fi > @$(java-vm-cleanup) > > > On 12/16/11 10:12 AM, Mandy Chung wrote: >> On 12/16/2011 9:26 AM, Kelly O'Hair wrote: >>> You are correct. This changeset was wrong. >>> >> >> Chris - good find. >> >>> Mandy was asking me about this a while back >> >> That was Wednesday - not long ago. jigsaw build has a similar issue: >> http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/diff/459b6cbb0de7/make/common/Rules.gmk >> >> >> >> that I have fixed. I didn't get the chance to check on jdk8/tl yet. >> >> Mandy >> >>> and I was also noticing the problem with a recent >>> problem Maurizio was having doing boot cycle builds on Linux, where >>> javac >>> failed, make did not stop, >>> and merrily crashed later in javah. :^( >>> >>> -kto >>> >>> On Dec 16, 2011, at 6:13 AM, Chris Hegarty wrote: >>> >>>> I filed CR 7122235 for this issue. >>>> >>>> Forcing a compile time error of a JDK class by inserting some bad >>>> code is >>>> just ignored and the build continues, and appears to complete >>>> successfully. >>>> >>>> I believe the changes for CR 7116322 "enhance javac make rule with a >>>> little >>>> bit of instrumentation", caused this problem. >>>> >>>> Changeset for 7116322: >>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 >>>> >>>> After the javac cmd is run there is a simple echo to indicate 'javac >>>> finished'. I am not a makefile expert, but I think the makefiles are >>>> checking the return code for this directive/rule and now will always >>>> see the >>>> successful return code of the echo, so it will never fail. >>>> >>>> Example: >>>> >>>> # Running javac: 18 files; in >>>> /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl >>>> /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac >>>> -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions >>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client >>>> -J-Xmx512m >>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror >>>> -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 >>>> -encoding ascii >>>> -Xbootclasspath:../../../../../build/solaris-i586/classes >>>> -sourcepath >>>> ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes >>>> >>>> -d ../../../../../build/solaris-i586/classes >>>> @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered >>>> >>>> >>>> ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: >>>> >>>> error: missing return statement >>>> } >>>> ^ >>>> Note: Some input files use or override a deprecated API. >>>> Note: Recompile with -Xlint:deprecation for details. >>>> 1 error >>>> # javac finished >>>> make381[3]: Leaving directory >>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' >>>> make381[3]: Entering directory >>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>> make381[3]: Leaving directory >>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>> make381[3]: Entering directory >>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' >>>> >>>> -Chris. From stuart.marks at oracle.com Sat Dec 17 08:27:26 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Sat, 17 Dec 2011 08:27:26 -0800 Subject: Build succeeds even if JDK source file fails to compile In-Reply-To: <4EEC5BA8.5040406@oracle.com> References: <4EEB521F.4010601@oracle.com> <4EEB8A15.3020408@oracle.com> <4EEBA2D7.8060206@oracle.com> <4EEC5BA8.5040406@oracle.com> Message-ID: <4EECC2EE.1050106@oracle.com> They all seem so innocuous, don't they? :-/ OK, I just pushed the fix. Everybody, please keep an eye out for any weirdness in the build. s'marks On 12/17/11 1:06 AM, David Holmes wrote: > Looks good to me too. > > And the original change seemed so innocuous. > > David > > On 17/12/2011 5:58 AM, Stuart Marks wrote: >> Here's a fix I'm working on. I'm still doing test builds but I wanted to >> get this in front of people pretty quickly. >> >> The initial diagnosis was correct; adding an "echo" (or some other >> command) after the javac will prevent javac's failure code from reaching >> make and thus not stopping the build if there is an error. >> >> The fix is to use && instead of ; to separate the commands, i.e. >> >> javac && echo "# javac finished" >> >> If javac fails this will abort the commands chained with && and report >> the failure code back to make. >> >> Diff below. >> >> s'marks >> >> >> >> diff -r c647ebb3c4f7 make/common/Rules.gmk >> --- a/make/common/Rules.gmk Tue Dec 13 15:41:47 2011 -0800 >> +++ b/make/common/Rules.gmk Fri Dec 16 11:52:48 2011 -0800 >> @@ -239,7 +239,7 @@ >> $(CAT) $<.filtered; \ >> $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ >> $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) >> @$<.filtered; \ >> - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) >> @$<.filtered; \ >> + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) >> @$<.filtered && \ >> $(ECHO) "# javac finished"; \ >> fi >> @$(java-vm-cleanup) >> >> >> On 12/16/11 10:12 AM, Mandy Chung wrote: >>> On 12/16/2011 9:26 AM, Kelly O'Hair wrote: >>>> You are correct. This changeset was wrong. >>>> >>> >>> Chris - good find. >>> >>>> Mandy was asking me about this a while back >>> >>> That was Wednesday - not long ago. jigsaw build has a similar issue: >>> http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/diff/459b6cbb0de7/make/common/Rules.gmk >>> >>> >>> >>> >>> that I have fixed. I didn't get the chance to check on jdk8/tl yet. >>> >>> Mandy >>> >>>> and I was also noticing the problem with a recent >>>> problem Maurizio was having doing boot cycle builds on Linux, where >>>> javac >>>> failed, make did not stop, >>>> and merrily crashed later in javah. :^( >>>> >>>> -kto >>>> >>>> On Dec 16, 2011, at 6:13 AM, Chris Hegarty wrote: >>>> >>>>> I filed CR 7122235 for this issue. >>>>> >>>>> Forcing a compile time error of a JDK class by inserting some bad >>>>> code is >>>>> just ignored and the build continues, and appears to complete >>>>> successfully. >>>>> >>>>> I believe the changes for CR 7116322 "enhance javac make rule with a >>>>> little >>>>> bit of instrumentation", caused this problem. >>>>> >>>>> Changeset for 7116322: >>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 >>>>> >>>>> After the javac cmd is run there is a simple echo to indicate 'javac >>>>> finished'. I am not a makefile expert, but I think the makefiles are >>>>> checking the return code for this directive/rule and now will always >>>>> see the >>>>> successful return code of the echo, so it will never fail. >>>>> >>>>> Example: >>>>> >>>>> # Running javac: 18 files; in >>>>> /export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl >>>>> /java/re/jdk/1.8.0/promoted/latest/binaries/solaris-i586/bin/javac >>>>> -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions >>>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client >>>>> -J-Xmx512m >>>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -Werror >>>>> -Xlint:all,-deprecation -Xlint:all -Xlint:-path -source 7 -target 7 >>>>> -encoding ascii >>>>> -Xbootclasspath:../../../../../build/solaris-i586/classes >>>>> -sourcepath >>>>> ../../../../../src/closed/solaris/classes:../../../../../src/closed/share/classes:../../../../../build/solaris-i586/gensrc:../../../../../src/solaris/classes:../../../../../src/share/classes >>>>> >>>>> >>>>> -d ../../../../../build/solaris-i586/classes >>>>> @../../../../../build/solaris-i586/tmp/sun/com.sun.net.ssl/.classes.list.filtered >>>>> >>>>> >>>>> >>>>> ../../../../../src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:438: >>>>> >>>>> >>>>> error: missing return statement >>>>> } >>>>> ^ >>>>> Note: Some input files use or override a deprecated API. >>>>> Note: Recompile with -Xlint:deprecation for details. >>>>> 1 error >>>>> # javac finished >>>>> make381[3]: Leaving directory >>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/net/ssl' >>>>> make381[3]: Entering directory >>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>>> make381[3]: Leaving directory >>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/jarsigner' >>>>> make381[3]: Entering directory >>>>> `/export2/Users/chris/repos/jdk8/tl/buildFail/make/com/sun/image' >>>>> >>>>> -Chris. From luchsh at linux.vnet.ibm.com Tue Dec 20 04:39:56 2011 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Tue, 20 Dec 2011 20:39:56 +0800 Subject: freetype_versioncheck failed to compile Message-ID: <4EF0821C.6070207@linux.vnet.ibm.com> Hi build-dev, On some Unix environments, such as AIX, the link option to set library search patch is the same as Solaris. But in current script the option to link tool freetype_versioncheck is the same as Linux, this makes the tool cannot be compiled on AIX. So in order to improve portability, here I propose a patch to adjust the default link option to Solaris' definition. http://cr.openjdk.java.net/~luchsh/ft_ld_option_sequence/ For other platforms, such as Mac OS X and BSD, I found there's some definitions there in macosx port project[1], so maybe we can just wait for the incoming merge, right? [1] http://hg.openjdk.java.net/macosx-port/macosx-port/jdk/file/2a76fda3fe23/make/tools/freetypecheck/Makefile Cheers, - Jonathan Lu From stuart.marks at oracle.com Tue Dec 20 18:10:37 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 20 Dec 2011 18:10:37 -0800 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EEAD5CA.2000803@oracle.com> References: <4EEAB41C.5000300@oracle.com> <4EEAD5CA.2000803@oracle.com> Message-ID: <4EF1401D.6070205@oracle.com> On 12/15/11 9:23 PM, David Holmes wrote: > On 16/12/2011 12:59 PM, Stuart Marks wrote: >> http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/ > > Looks fine but ... > >> This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables >> in a variety of Makefiles within the jdk repository. This essentially >> adds -Xlint:all -Werror to the javac command lines, so that henceforth >> if any lint warnings are introduced, the build will fail. >> >> I'm applying these flags only to build steps that are already warnings >> free. (Last week's warnings cleanup effort cleared warnings from four >> build steps, in addition to knocking off a couple thousand warnings >> across the build.) I've applied this change and have built successfully >> on all platforms. >> >> With this change, 57 of the 93 javac build steps in the jdk repo are now >> lint warning free, and are protected from the introduction of new errors >> through the use of -Werror. > > ... as we're past the half-way point should we not set these by default and > change the non-warning free steps to override them? That way as an area becomes > warning free we would include the removal of the override as part of the > changeset. That way when we get to being warning-free there should only be one > occurrence of: > > JAVAC_MAX_WARNINGS = true > JAVAC_WARNINGS_FATAL = true > > in the whole build system. Yes, I think this is a good thing to consider. I had thought about this a bit and felt that it would be more appropriate to make a change after all (or at least almost all) the warnings had been cleaned up, not just the majority, though when we should make such a change deserves discussion. Jon Gibbons also pointed out that we should coordinate with the new build system effort on build-infra. It's also a small puzzle to figure out the best way to do this without doing too much damage to the current makefile system. I think we now know how much damage even an innocuous change to a makefile can do. :-) That said, here's a possible approach. The current scheme has the leaf Makefile define these JAVAC_ variables *before* inclusion of make/common/Defs.gmk. This file ends up including make/common/shared/Defs-java.gmk, which tests these variables and adds options like -Xlint:all and -Werror if they equal true. Unfortunately in this scheme it's not possible to supply a default value for a variable that's overridden by the leaf Makefile, since the leaf Makefile is read first. There's an alternate approach that has a similar effect, which is to use the make construct ?= that means "set if not already set." Thus, in Defs-java.gmk we can do something like JAVAC_WARNINGS_FATAL ?= true ifeq ($(JAVAC_WARNINGS_FATAL), true) JAVACFLAGS += -Werror endif and any leaf Makefile that doesn't want warnings to be fatal does JAVAC_WARNINGS_FATAL = false prior to including Defs.gmk. I think this will work, but I haven't tested it. I don't think this construct has been used anywhere in the make system yet, though. The alternative is to invert the sense of the test and rename the variable, so the leaf Makefiles would do this: JAVAC_WARNINGS_NONFATAL = true and Defs-java.gmk would do this: ifneq ($(JAVAC_WARNINGS_NONFATAL), true) JAVACFLAGS += -Werror endif This uses more conventional Make constructs, at the expense of having the double negative "if not non-fatal, add the -Werror option." I'm not sure which approach people would find preferable. In any case there are other issues with -Werror raised elsewhere in this thread, which I'll need to address before proceeding with this. s'marks From stuart.marks at oracle.com Tue Dec 20 18:28:52 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 20 Dec 2011 18:28:52 -0800 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EEB1FD6.60707@oracle.com> References: <4EEAB41C.5000300@oracle.com> <4EEB160B.2060909@oracle.com> <4EEB1FD6.60707@oracle.com> Message-ID: <4EF14464.5000103@oracle.com> On 12/16/11 2:39 AM, Chris Hegarty wrote: > On 12/16/11 09:57 AM, Alan Bateman wrote: >> Stuart - the changes look okay to me but it would be good to get >> confirmation that you've done both full and partial builds with these >> changes. Also I think we need confirmation that incremental builds in >> each of these areas isn't impacted. My concern is implicit compilation >> where compiling code in warning free areas may compile code in areas >> that are not warning free yet. Sasha did great work over the summer and >> part of his approach was to make warnings fatal in the errors that he >> cleaned up. On a couple of occasions we ran into issues where implicit >> compilation caused code in areas with warnings to be compiled. Such >> issues are usually quick to fix but I'm sure you get my concern. > > I agree with Alan here, we need to be careful that incremental/partial builds > are still ok. We found some issues relating to this in the networking area > recently. OK, I was unaware of the issues with implicit compilation. I've been doing full builds (well, just the jdk repo, not the full forest), and my assumption has been that it's safe to enable -Werror for any run of javac that had no errors during the full build. Indeed, with the -Werror patch applied, a full build still succeeds. Given implicit compilation I can see that a particular run of javac with -Werror might end up compiling additional source files that haven't been cleared of warnings, resulting in an error. As I understand implicit compilation (admittedly I don't understand it very well) anything in the source path can be compiled implicitly. From my build logs it looks like -sourcepath is provided with essentially all of the source files in the repo. So it looks like potentially anything can be implicitly compiled. My question is, how can we test for this? Aren't there an astronomically large number of incremental or partial builds possible? If there are specific cases that occur often that you think I should test, I'd be glad to do so, but otherwise I'm not sure how to proceed. s'marks From michael.j.silverstri at gmail.com Wed Dec 21 16:55:23 2011 From: michael.j.silverstri at gmail.com (m silverstri) Date: Wed, 21 Dec 2011 16:55:23 -0800 Subject: Need help in building openjdk in ubuntu 11.10 Message-ID: I have run and passed 'make sanity' and I have download and set ALT_BOOTDIR to a jdk6: $ echo $ALT_BOOTDIR /home/michael/Programs/jdk1.6.0_30 But when I 'make', i still get error saying 'We cannot execute /NO_BOOTDIR/bin/java' make[2]: Entering directory `/home/michael/src/jdk7/langtools/make' JAVA_HOME=/NO_BOOTDIR ANT_OPTS=-Djava.io.tmpdir='/home/michael/src/jdk7/build/linux-amd64/langtools/build/ant-tmp' ant -Djdk.version=1.7.0 -Dfull.version='1.7.0-internal-michael_2011_12_21_16_53-b00' -Dmilestone=internal -Dbuild.number=b00 -Djavac.target=7 -Djavac.source=7 -Dboot.java.home=/NO_BOOTDIR -Dimport.jdk=/home/michael/src/jdk7/jdk -Dbuild.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/build -Ddist.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/dist build Error: JAVA_HOME is not defined correctly. We cannot execute /NO_BOOTDIR/bin/java make[2]: *** [build] Error 1 ;; This buffer is for notes you don't want to save, and for Lisp evaluation. ;; If you want to create a file, visit that file with C-x C-f, ;; then enter the text in that file's own buffer. $ make sanity ( cd ./jdk/make && \ make sanity HOTSPOT_IMPORT_CHECK=false JDK_TOPDIR=/home/michael/src/jdk7/jdk JDK_MAKE_SHARED_DIR=/home/michael/src/jdk7/jdk/make/common/shared EXTERNALSANITYCONTROL=true SOURCE_LANGUAGE_VERSION=7 TARGET_CLASS_VERSION=7 MILESTONE=internal BUILD_NUMBER=b00 JDK_BUILD_NUMBER=b00 FULL_VERSION=1.7.0-internal-michael_2011_12_21_16_51-b00 PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 ALT_OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64 ALT_LANGTOOLS_DIST=/home/michael/src/jdk7/build/linux-amd64/langtools/dist ALT_CORBA_DIST=/home/michael/src/jdk7/build/linux-amd64/corba/dist ALT_JAXP_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxp/dist ALT_JAXWS_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxws/dist ALT_HOTSPOT_IMPORT_PATH=/home/michael/src/jdk7/build/linux-amd64/hotspot/import BUILD_HOTSPOT=true ; ) [: 1: Illegal number: /bin/sh: [: 1: Illegal number: /bin/sh: [: 1: Illegal number: /NO_BOOTDIR/bin/java: [: 1: Illegal number: /NO_BOOTDIR/bin/java: [: 1: Illegal number: not [: 1: Illegal number: not [: 1: Illegal number: Error: [: 1: Illegal number: Error: [: 1: Illegal number: JAVA_HOME [: 1: Illegal number: JAVA_HOME [: 1: Illegal number: is [: 1: Illegal number: is make[1]: Entering directory `/home/michael/src/jdk7/jdk/make' make[1]: Leaving directory `/home/michael/src/jdk7/jdk/make' Build Machine Information: build machine = opportunity Build Directory Structure: CWD = /home/michael/src/jdk7 TOPDIR = . LANGTOOLS_TOPDIR = ./langtools JAXP_TOPDIR = ./jaxp JAXWS_TOPDIR = ./jaxws CORBA_TOPDIR = ./corba HOTSPOT_TOPDIR = ./hotspot JDK_TOPDIR = ./jdk Build Directives: BUILD_LANGTOOLS = true BUILD_JAXP = true BUILD_JAXWS = true BUILD_CORBA = true BUILD_HOTSPOT = true BUILD_JDK = true DEBUG_CLASSFILES = DEBUG_BINARIES = Hotspot Settings: HOTSPOT_BUILD_JOBS = HOTSPOT_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir HOTSPOT_EXPORT_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import Bootstrap Settings: BOOTDIR = /NO_BOOTDIR ALT_BOOTDIR = BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at least 1.6] OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 ALT_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 ABS_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 Build Tool Settings: SLASH_JAVA = /NOT-SET ALT_SLASH_JAVA = VARIANT = OPT JDK_DEVTOOLS_DIR = /NOT-SET/devtools ALT_JDK_DEVTOOLS_DIR = ANT_HOME = UNIXCOMMAND_PATH = /bin/ ALT_UNIXCOMMAND_PATH = COMPILER_PATH = /usr/bin/ ALT_COMPILER_PATH = DEVTOOLS_PATH = /usr/bin/ ALT_DEVTOOLS_PATH = UNIXCCS_PATH = /usr/ccs/bin/ ALT_UNIXCCS_PATH = USRBIN_PATH = /usr/bin/ ALT_USRBIN_PATH = COMPILER_NAME = GCC4 COMPILER_VERSION = GCC4 CC_VER = 4.6.1 [requires at least 4.3.0] ZIP_VER = 3.0 [requires at least 2.2] UNZIP_VER = 6.00 [requires at least 5.12] ANT_VER = Error: JAVA_HOME is not defined correctly. We cannot execute /NO_BOOTDIR/bin/java [requires at least 1.7.1] TEMPDIR = /home/michael/src/jdk7/build/linux-amd64/tmp Build Directives: OPENJDK = true USE_HOTSPOT_INTERPRETER_MODE = PEDANTIC = DEV_ONLY = NO_DOCS = NO_IMAGES = TOOLS_ONLY = INSANE = COMPILE_APPROACH = parallel PARALLEL_COMPILE_JOBS = 2 ALT_PARALLEL_COMPILE_JOBS = FASTDEBUG = COMPILER_WARNINGS_FATAL = false COMPILER_WARNING_LEVEL = SHOW_ALL_WARNINGS = INCREMENTAL_BUILD = false CC_HIGHEST_OPT = CC_HIGHER_OPT = CC_LOWER_OPT = CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -pipe -fno-omit-frame-pointer -D_LITTLE_ENDIAN BOOT_JAVA_CMD = /NO_BOOTDIR/bin/java -XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m -XX:PermSize=32m -XX:MaxPermSize=160m BOOT_JAVAC_CMD = /NO_BOOTDIR/bin/javac -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -encoding ascii -source 6 -target 6 -XDignore.symbol.file=true BOOT_JAR_CMD = /NO_BOOTDIR/bin/jar BOOT_JARSIGNER_CMD = /NO_BOOTDIR/bin/jarsigner JAVAC_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javac -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -source 7 -target 7 -encoding ascii -Xbootclasspath:/home/michael/src/jdk7/build/linux-amd64/classes JAVAH_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah -bootclasspath /home/michael/src/jdk7/build/linux-amd64/classes JAVADOC_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javadoc -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -bootclasspath /home/michael/src/jdk7/build/linux-amd64/classes Build Platform Settings: USER = michael PLATFORM = linux ARCH = amd64 LIBARCH = amd64 ARCH_FAMILY = amd64 ARCH_DATA_MODEL = 64 ARCHPROP = amd64 ALSA_VERSION = 1.0.24.1 OS_VERSION = 3.0.0-14-generic [requires at least 2.6] OS_VARIANT_NAME = Ubuntu OS_VARIANT_VERSION = 11.10 MB_OF_MEMORY = 7984 GNU Make Settings: MAKE = make MAKE_VER = 3.81 [requires at least 3.81] MAKECMDGOALS = sanity MAKEFLAGS = w SHELL = /bin/sh Target Build Versions: JDK_VERSION = 1.7.0 MILESTONE = internal RELEASE = 1.7.0-internal FULL_VERSION = 1.7.0-internal-michael_2011_12_21_16_51-b00 BUILD_NUMBER = b00 External File/Binary Locations: USRJDKINSTANCES_PATH = /opt/java BUILD_JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries ALT_BUILD_JDK_IMPORT_PATH = JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64 ALT_JDK_IMPORT_PATH = LANGTOOLS_DIST = ALT_LANGTOOLS_DIST = /home/michael/src/jdk7/build/linux-amd64/langtools/dist CORBA_DIST = ALT_CORBA_DIST = /home/michael/src/jdk7/build/linux-amd64/corba/dist JAXP_DIST = ALT_JAXP_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxp/dist JAXWS_DIST = ALT_JAXWS_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxws/dist HOTSPOT_DOCS_IMPORT_PATH = /NO_DOCS_DIR ALT_HOTSPOT_DOCS_IMPORT_PATH = HOTSPOT_IMPORT_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import ALT_HOTSPOT_IMPORT_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import HOTSPOT_SERVER_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import/jre/lib/amd64/server ALT_HOTSPOT_SERVER_PATH = CACERTS_FILE = ./../src/share/lib/security/cacerts ALT_CACERTS_FILE = CUPS_HEADERS_PATH = /usr/include ALT_CUPS_HEADERS_PATH = OpenJDK-specific settings: FREETYPE_HEADERS_PATH = /usr/include ALT_FREETYPE_HEADERS_PATH = FREETYPE_LIB_PATH = /usr/lib ALT_FREETYPE_LIB_PATH = Previous JDK Settings: PREVIOUS_RELEASE_PATH = ALT_PREVIOUS_RELEASE_PATH = PREVIOUS_JDK_VERSION = 1.6.0 ALT_PREVIOUS_JDK_VERSION = PREVIOUS_JDK_FILE = ALT_PREVIOUS_JDK_FILE = PREVIOUS_JRE_FILE = ALT_PREVIOUS_JRE_FILE = PREVIOUS_RELEASE_IMAGE = ALT_PREVIOUS_RELEASE_IMAGE = Sanity check passed. michael at opportunity:~/src/jdk7$ From stuart.marks at oracle.com Wed Dec 21 17:51:42 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 21 Dec 2011 17:51:42 -0800 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EF14464.5000103@oracle.com> References: <4EEAB41C.5000300@oracle.com> <4EEB160B.2060909@oracle.com> <4EEB1FD6.60707@oracle.com> <4EF14464.5000103@oracle.com> Message-ID: <4EF28D2E.3010504@oracle.com> On 12/20/11 6:28 PM, Stuart Marks wrote: > On 12/16/11 2:39 AM, Chris Hegarty wrote: >> On 12/16/11 09:57 AM, Alan Bateman wrote: >>> Stuart - the changes look okay to me but it would be good to get >>> confirmation that you've done both full and partial builds with these >>> changes. Also I think we need confirmation that incremental builds in >>> each of these areas isn't impacted. My concern is implicit compilation >>> where compiling code in warning free areas may compile code in areas >>> that are not warning free yet. Sasha did great work over the summer and >>> part of his approach was to make warnings fatal in the errors that he >>> cleaned up. On a couple of occasions we ran into issues where implicit >>> compilation caused code in areas with warnings to be compiled. Such >>> issues are usually quick to fix but I'm sure you get my concern. >> >> I agree with Alan here, we need to be careful that incremental/partial builds >> are still ok. We found some issues relating to this in the networking area >> recently. > > OK, I was unaware of the issues with implicit compilation. I've been doing full > builds (well, just the jdk repo, not the full forest), and my assumption has > been that it's safe to enable -Werror for any run of javac that had no errors > during the full build. Indeed, with the -Werror patch applied, a full build > still succeeds. > > Given implicit compilation I can see that a particular run of javac with > -Werror might end up compiling additional source files that haven't been > cleared of warnings, resulting in an error. As I understand implicit > compilation (admittedly I don't understand it very well) anything in the source > path can be compiled implicitly. From my build logs it looks like -sourcepath > is provided with essentially all of the source files in the repo. So it looks > like potentially anything can be implicitly compiled. > > My question is, how can we test for this? Aren't there an astronomically large > number of incremental or partial builds possible? > > If there are specific cases that occur often that you think I should test, I'd > be glad to do so, but otherwise I'm not sure how to proceed. I dug up a bit of background on this. Apparently Sasha ran across this problem back in July and asked about this on net-dev [1]. Discussion continued on build-dev [2]. Kurchi later picked up this work and after some discussion got it integrated [3]. I didn't see Sasha's original webrev, but he might have fixed all the warnings in the java.net package, enabled -Werror in make/java/net/Makefile, and then was surprised to find that this build step was (implicitly) compiling files that weren't in the java.net package. Kurchi's fix [3] apparently fixed warnings in these other files as well before enabling -Werror. In my proposal to add -Werror, I've ensured that specific runs of javac to which -Werror will be added actually have no warnings at all, whether in implicitly or explicitly listed files. I'm also not entirely clear what's meant by "partial" and "incremental" builds. I've been doing clean builds, but only in the jdk repo. Is this a "partial" build, as opposed to a full forest or "control" build? I'm doing one of those now and I'll certainly correct any issues that arise because of -Werror. Or, is a "partial" build what happens if one descends into a make subdirectory, e.g. jdk/make/java/net, and calls "make" from there? I haven't been doing that. Should I? Still trying to figure out what I need to do to move this forward. s'marks [1] http://mail.openjdk.java.net/pipermail/net-dev/2011-July/003351.html [2] http://mail.openjdk.java.net/pipermail/build-dev/2011-August/004943.html [3] http://mail.openjdk.java.net/pipermail/net-dev/2011-September/003524.html From kelly.ohair at oracle.com Wed Dec 21 17:54:21 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 21 Dec 2011 17:54:21 -0800 Subject: Need help in building openjdk in ubuntu 11.10 In-Reply-To: References: Message-ID: Did you export ALT_BOOTDIR? It needs to be set in the environment. -kto On Dec 21, 2011, at 4:55 PM, m silverstri wrote: > I have run and passed 'make sanity' and I have download and set > ALT_BOOTDIR to a jdk6: > > $ echo $ALT_BOOTDIR > /home/michael/Programs/jdk1.6.0_30 > > But when I 'make', i still get error saying 'We cannot execute > /NO_BOOTDIR/bin/java' > > make[2]: Entering directory `/home/michael/src/jdk7/langtools/make' > JAVA_HOME=/NO_BOOTDIR > ANT_OPTS=-Djava.io.tmpdir='/home/michael/src/jdk7/build/linux-amd64/langtools/build/ant-tmp' > ant -Djdk.version=1.7.0 > -Dfull.version='1.7.0-internal-michael_2011_12_21_16_53-b00' > -Dmilestone=internal -Dbuild.number=b00 -Djavac.target=7 > -Djavac.source=7 -Dboot.java.home=/NO_BOOTDIR > -Dimport.jdk=/home/michael/src/jdk7/jdk > -Dbuild.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/build > -Ddist.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/dist > build > Error: JAVA_HOME is not defined correctly. > We cannot execute /NO_BOOTDIR/bin/java > make[2]: *** [build] Error 1 > > > ;; This buffer is for notes you don't want to save, and for Lisp evaluation. > ;; If you want to create a file, visit that file with C-x C-f, > ;; then enter the text in that file's own buffer. > > $ make sanity > ( cd ./jdk/make && \ > make sanity HOTSPOT_IMPORT_CHECK=false > JDK_TOPDIR=/home/michael/src/jdk7/jdk > JDK_MAKE_SHARED_DIR=/home/michael/src/jdk7/jdk/make/common/shared > EXTERNALSANITYCONTROL=true SOURCE_LANGUAGE_VERSION=7 > TARGET_CLASS_VERSION=7 MILESTONE=internal BUILD_NUMBER=b00 > JDK_BUILD_NUMBER=b00 > FULL_VERSION=1.7.0-internal-michael_2011_12_21_16_51-b00 > PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 > JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 > PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 > PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 > ALT_OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64 > ALT_LANGTOOLS_DIST=/home/michael/src/jdk7/build/linux-amd64/langtools/dist > ALT_CORBA_DIST=/home/michael/src/jdk7/build/linux-amd64/corba/dist > ALT_JAXP_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxp/dist > ALT_JAXWS_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxws/dist > ALT_HOTSPOT_IMPORT_PATH=/home/michael/src/jdk7/build/linux-amd64/hotspot/import > BUILD_HOTSPOT=true ; ) > [: 1: Illegal number: /bin/sh: > [: 1: Illegal number: /bin/sh: > [: 1: Illegal number: /NO_BOOTDIR/bin/java: > [: 1: Illegal number: /NO_BOOTDIR/bin/java: > [: 1: Illegal number: not > [: 1: Illegal number: not > [: 1: Illegal number: Error: > [: 1: Illegal number: Error: > [: 1: Illegal number: JAVA_HOME > [: 1: Illegal number: JAVA_HOME > [: 1: Illegal number: is > [: 1: Illegal number: is > make[1]: Entering directory `/home/michael/src/jdk7/jdk/make' > make[1]: Leaving directory `/home/michael/src/jdk7/jdk/make' > > Build Machine Information: > build machine = opportunity > > Build Directory Structure: > CWD = /home/michael/src/jdk7 > TOPDIR = . > LANGTOOLS_TOPDIR = ./langtools > JAXP_TOPDIR = ./jaxp > JAXWS_TOPDIR = ./jaxws > CORBA_TOPDIR = ./corba > HOTSPOT_TOPDIR = ./hotspot > JDK_TOPDIR = ./jdk > > Build Directives: > BUILD_LANGTOOLS = true > BUILD_JAXP = true > BUILD_JAXWS = true > BUILD_CORBA = true > BUILD_HOTSPOT = true > BUILD_JDK = true > DEBUG_CLASSFILES = > DEBUG_BINARIES = > > Hotspot Settings: > HOTSPOT_BUILD_JOBS = > HOTSPOT_OUTPUTDIR = > /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir > HOTSPOT_EXPORT_PATH = > /home/michael/src/jdk7/build/linux-amd64/hotspot/import > > > > > Bootstrap Settings: > BOOTDIR = /NO_BOOTDIR > ALT_BOOTDIR = > BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at least 1.6] > OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 > ALT_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 > ABS_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 > > Build Tool Settings: > SLASH_JAVA = /NOT-SET > ALT_SLASH_JAVA = > VARIANT = OPT > JDK_DEVTOOLS_DIR = /NOT-SET/devtools > ALT_JDK_DEVTOOLS_DIR = > ANT_HOME = > UNIXCOMMAND_PATH = /bin/ > ALT_UNIXCOMMAND_PATH = > COMPILER_PATH = /usr/bin/ > ALT_COMPILER_PATH = > DEVTOOLS_PATH = /usr/bin/ > ALT_DEVTOOLS_PATH = > UNIXCCS_PATH = /usr/ccs/bin/ > ALT_UNIXCCS_PATH = > USRBIN_PATH = /usr/bin/ > ALT_USRBIN_PATH = > COMPILER_NAME = GCC4 > COMPILER_VERSION = GCC4 > CC_VER = 4.6.1 [requires at least 4.3.0] > ZIP_VER = 3.0 [requires at least 2.2] > UNZIP_VER = 6.00 [requires at least 5.12] > ANT_VER = Error: JAVA_HOME is not defined correctly. We cannot > execute /NO_BOOTDIR/bin/java [requires at least 1.7.1] > TEMPDIR = /home/michael/src/jdk7/build/linux-amd64/tmp > > Build Directives: > OPENJDK = true > USE_HOTSPOT_INTERPRETER_MODE = > PEDANTIC = > DEV_ONLY = > NO_DOCS = > NO_IMAGES = > TOOLS_ONLY = > INSANE = > COMPILE_APPROACH = parallel > PARALLEL_COMPILE_JOBS = 2 > ALT_PARALLEL_COMPILE_JOBS = > FASTDEBUG = > COMPILER_WARNINGS_FATAL = false > COMPILER_WARNING_LEVEL = > SHOW_ALL_WARNINGS = > INCREMENTAL_BUILD = false > CC_HIGHEST_OPT = > CC_HIGHER_OPT = > CC_LOWER_OPT = > CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused > -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN > CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused > -Wno-parentheses -pipe -fno-omit-frame-pointer -D_LITTLE_ENDIAN > BOOT_JAVA_CMD = /NO_BOOTDIR/bin/java -XX:-PrintVMOptions > -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m > -XX:PermSize=32m -XX:MaxPermSize=160m > BOOT_JAVAC_CMD = /NO_BOOTDIR/bin/javac -J-XX:ThreadStackSize=1536 > -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions > -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m > -J-XX:MaxPermSize=160m -encoding ascii -source 6 -target 6 > -XDignore.symbol.file=true > BOOT_JAR_CMD = /NO_BOOTDIR/bin/jar > BOOT_JARSIGNER_CMD = /NO_BOOTDIR/bin/jarsigner > JAVAC_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javac > -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions > -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m > -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -source 7 > -target 7 -encoding ascii > -Xbootclasspath:/home/michael/src/jdk7/build/linux-amd64/classes > JAVAH_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah > -bootclasspath /home/michael/src/jdk7/build/linux-amd64/classes > JAVADOC_CMD = > /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javadoc > -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions > -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m > -J-XX:MaxPermSize=160m -bootclasspath > /home/michael/src/jdk7/build/linux-amd64/classes > > Build Platform Settings: > USER = michael > PLATFORM = linux > ARCH = amd64 > LIBARCH = amd64 > ARCH_FAMILY = amd64 > ARCH_DATA_MODEL = 64 > ARCHPROP = amd64 > ALSA_VERSION = 1.0.24.1 > OS_VERSION = 3.0.0-14-generic [requires at least 2.6] > OS_VARIANT_NAME = Ubuntu > OS_VARIANT_VERSION = 11.10 > MB_OF_MEMORY = 7984 > > GNU Make Settings: > MAKE = make > MAKE_VER = 3.81 [requires at least 3.81] > MAKECMDGOALS = sanity > MAKEFLAGS = w > SHELL = /bin/sh > > Target Build Versions: > JDK_VERSION = 1.7.0 > MILESTONE = internal > RELEASE = 1.7.0-internal > FULL_VERSION = 1.7.0-internal-michael_2011_12_21_16_51-b00 > BUILD_NUMBER = b00 > > External File/Binary Locations: > USRJDKINSTANCES_PATH = /opt/java > BUILD_JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries > ALT_BUILD_JDK_IMPORT_PATH = > JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64 > ALT_JDK_IMPORT_PATH = > LANGTOOLS_DIST = > ALT_LANGTOOLS_DIST = /home/michael/src/jdk7/build/linux-amd64/langtools/dist > CORBA_DIST = > ALT_CORBA_DIST = /home/michael/src/jdk7/build/linux-amd64/corba/dist > JAXP_DIST = > ALT_JAXP_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxp/dist > JAXWS_DIST = > ALT_JAXWS_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxws/dist > HOTSPOT_DOCS_IMPORT_PATH = /NO_DOCS_DIR > ALT_HOTSPOT_DOCS_IMPORT_PATH = > HOTSPOT_IMPORT_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import > ALT_HOTSPOT_IMPORT_PATH = > /home/michael/src/jdk7/build/linux-amd64/hotspot/import > HOTSPOT_SERVER_PATH = > /home/michael/src/jdk7/build/linux-amd64/hotspot/import/jre/lib/amd64/server > ALT_HOTSPOT_SERVER_PATH = > CACERTS_FILE = ./../src/share/lib/security/cacerts > ALT_CACERTS_FILE = > CUPS_HEADERS_PATH = /usr/include > ALT_CUPS_HEADERS_PATH = > > OpenJDK-specific settings: > FREETYPE_HEADERS_PATH = /usr/include > ALT_FREETYPE_HEADERS_PATH = > FREETYPE_LIB_PATH = /usr/lib > ALT_FREETYPE_LIB_PATH = > > Previous JDK Settings: > PREVIOUS_RELEASE_PATH = > ALT_PREVIOUS_RELEASE_PATH = > PREVIOUS_JDK_VERSION = 1.6.0 > ALT_PREVIOUS_JDK_VERSION = > PREVIOUS_JDK_FILE = > ALT_PREVIOUS_JDK_FILE = > PREVIOUS_JRE_FILE = > ALT_PREVIOUS_JRE_FILE = > PREVIOUS_RELEASE_IMAGE = > ALT_PREVIOUS_RELEASE_IMAGE = > > > Sanity check passed. > michael at opportunity:~/src/jdk7$ From michael.j.silverstri at gmail.com Wed Dec 21 18:11:09 2011 From: michael.j.silverstri at gmail.com (m silverstri) Date: Wed, 21 Dec 2011 18:11:09 -0800 Subject: Need help in building openjdk in ubuntu 11.10 In-Reply-To: References: Message-ID: I did. $ echo $ALT_BOOTDIR /home/michael/Programs/jdk1.6.0_30 On Wed, Dec 21, 2011 at 5:54 PM, Kelly O'Hair wrote: > Did you export ALT_BOOTDIR? ?It needs to be set in the environment. > > -kto > > On Dec 21, 2011, at 4:55 PM, m silverstri wrote: > >> I have run and passed 'make sanity' and I have download and set >> ALT_BOOTDIR ?to a jdk6: >> >> $ echo $ALT_BOOTDIR >> /home/michael/Programs/jdk1.6.0_30 >> >> But when I 'make', i still get error saying 'We cannot execute >> /NO_BOOTDIR/bin/java' >> >> make[2]: Entering directory `/home/michael/src/jdk7/langtools/make' >> JAVA_HOME=/NO_BOOTDIR >> ANT_OPTS=-Djava.io.tmpdir='/home/michael/src/jdk7/build/linux-amd64/langtools/build/ant-tmp' >> ant -Djdk.version=1.7.0 >> -Dfull.version='1.7.0-internal-michael_2011_12_21_16_53-b00' >> -Dmilestone=internal -Dbuild.number=b00 -Djavac.target=7 >> -Djavac.source=7 -Dboot.java.home=/NO_BOOTDIR >> -Dimport.jdk=/home/michael/src/jdk7/jdk >> -Dbuild.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/build >> -Ddist.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >> build >> Error: JAVA_HOME is not defined correctly. >> ?We cannot execute /NO_BOOTDIR/bin/java >> make[2]: *** [build] Error 1 >> >> >> ;; This buffer is for notes you don't want to save, and for Lisp evaluation. >> ;; If you want to create a file, visit that file with C-x C-f, >> ;; then enter the text in that file's own buffer. >> >> $ make sanity >> ( cd ?./jdk/make && \ >> ? ? ? ? make sanity HOTSPOT_IMPORT_CHECK=false >> JDK_TOPDIR=/home/michael/src/jdk7/jdk >> JDK_MAKE_SHARED_DIR=/home/michael/src/jdk7/jdk/make/common/shared >> EXTERNALSANITYCONTROL=true SOURCE_LANGUAGE_VERSION=7 >> TARGET_CLASS_VERSION=7 MILESTONE=internal BUILD_NUMBER=b00 >> JDK_BUILD_NUMBER=b00 >> FULL_VERSION=1.7.0-internal-michael_2011_12_21_16_51-b00 >> PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 >> JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 >> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 >> PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 >> ALT_OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64 >> ALT_LANGTOOLS_DIST=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >> ALT_CORBA_DIST=/home/michael/src/jdk7/build/linux-amd64/corba/dist >> ALT_JAXP_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxp/dist >> ALT_JAXWS_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxws/dist >> ALT_HOTSPOT_IMPORT_PATH=/home/michael/src/jdk7/build/linux-amd64/hotspot/import >> BUILD_HOTSPOT=true ; ) >> [: 1: Illegal number: /bin/sh: >> [: 1: Illegal number: /bin/sh: >> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >> [: 1: Illegal number: not >> [: 1: Illegal number: not >> [: 1: Illegal number: Error: >> [: 1: Illegal number: Error: >> [: 1: Illegal number: JAVA_HOME >> [: 1: Illegal number: JAVA_HOME >> [: 1: Illegal number: is >> [: 1: Illegal number: is >> make[1]: Entering directory `/home/michael/src/jdk7/jdk/make' >> make[1]: Leaving directory `/home/michael/src/jdk7/jdk/make' >> >> Build Machine Information: >> ? build machine = opportunity >> >> Build Directory Structure: >> ? CWD = /home/michael/src/jdk7 >> ? TOPDIR = . >> ? LANGTOOLS_TOPDIR = ./langtools >> ? JAXP_TOPDIR = ./jaxp >> ? JAXWS_TOPDIR = ./jaxws >> ? CORBA_TOPDIR = ./corba >> ? HOTSPOT_TOPDIR = ./hotspot >> ? JDK_TOPDIR = ./jdk >> >> Build Directives: >> ? BUILD_LANGTOOLS = true >> ? BUILD_JAXP = true >> ? BUILD_JAXWS = true >> ? BUILD_CORBA = true >> ? BUILD_HOTSPOT = true >> ? BUILD_JDK ? ?= true >> ? DEBUG_CLASSFILES = >> ? DEBUG_BINARIES = >> >> Hotspot Settings: >> ? ? ?HOTSPOT_BUILD_JOBS ?= >> ? ? ?HOTSPOT_OUTPUTDIR ? = >> /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir >> ? ? ?HOTSPOT_EXPORT_PATH = >> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >> >> >> >> >> Bootstrap Settings: >> ?BOOTDIR = /NO_BOOTDIR >> ? ?ALT_BOOTDIR = >> ?BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at least 1.6] >> ?OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >> ? ?ALT_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >> ?ABS_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >> >> Build Tool Settings: >> ?SLASH_JAVA = /NOT-SET >> ? ?ALT_SLASH_JAVA = >> ?VARIANT = OPT >> ?JDK_DEVTOOLS_DIR = /NOT-SET/devtools >> ? ?ALT_JDK_DEVTOOLS_DIR = >> ?ANT_HOME = >> ?UNIXCOMMAND_PATH = /bin/ >> ? ?ALT_UNIXCOMMAND_PATH = >> ?COMPILER_PATH = /usr/bin/ >> ? ?ALT_COMPILER_PATH = >> ?DEVTOOLS_PATH = /usr/bin/ >> ? ?ALT_DEVTOOLS_PATH = >> ?UNIXCCS_PATH = /usr/ccs/bin/ >> ? ?ALT_UNIXCCS_PATH = >> ?USRBIN_PATH = /usr/bin/ >> ? ?ALT_USRBIN_PATH = >> ?COMPILER_NAME = GCC4 >> ?COMPILER_VERSION = GCC4 >> ?CC_VER = 4.6.1 [requires at least 4.3.0] >> ?ZIP_VER = 3.0 [requires at least 2.2] >> ?UNZIP_VER = 6.00 [requires at least 5.12] >> ?ANT_VER = Error: JAVA_HOME is not defined correctly. ? We cannot >> execute /NO_BOOTDIR/bin/java [requires at least 1.7.1] >> ?TEMPDIR = /home/michael/src/jdk7/build/linux-amd64/tmp >> >> Build Directives: >> ?OPENJDK = true >> ?USE_HOTSPOT_INTERPRETER_MODE = >> ?PEDANTIC = >> ?DEV_ONLY = >> ?NO_DOCS = >> ?NO_IMAGES = >> ?TOOLS_ONLY = >> ?INSANE = >> ?COMPILE_APPROACH = parallel >> ?PARALLEL_COMPILE_JOBS = 2 >> ? ?ALT_PARALLEL_COMPILE_JOBS = >> ?FASTDEBUG = >> ?COMPILER_WARNINGS_FATAL = false >> ?COMPILER_WARNING_LEVEL = >> ?SHOW_ALL_WARNINGS = >> ?INCREMENTAL_BUILD = false >> ?CC_HIGHEST_OPT = >> ?CC_HIGHER_OPT = >> ?CC_LOWER_OPT = >> ?CXXFLAGS = ?-O2 -fPIC -DCC_NOEX -W -Wall ?-Wno-unused >> -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN >> ?CFLAGS = ?-O2 ? -fno-strict-aliasing -fPIC -W -Wall ?-Wno-unused >> -Wno-parentheses -pipe -fno-omit-frame-pointer -D_LITTLE_ENDIAN >> ?BOOT_JAVA_CMD = /NO_BOOTDIR/bin/java -XX:-PrintVMOptions >> -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m >> -XX:PermSize=32m -XX:MaxPermSize=160m >> ?BOOT_JAVAC_CMD = /NO_BOOTDIR/bin/javac ?-J-XX:ThreadStackSize=1536 >> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >> -J-XX:MaxPermSize=160m -encoding ascii -source 6 -target 6 >> -XDignore.symbol.file=true >> ?BOOT_JAR_CMD = /NO_BOOTDIR/bin/jar >> ?BOOT_JARSIGNER_CMD = /NO_BOOTDIR/bin/jarsigner >> ?JAVAC_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javac >> -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions >> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m ?-source 7 >> -target 7 -encoding ascii >> -Xbootclasspath:/home/michael/src/jdk7/build/linux-amd64/classes >> ?JAVAH_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah >> -bootclasspath /home/michael/src/jdk7/build/linux-amd64/classes >> ?JAVADOC_CMD = >> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javadoc >> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >> -J-XX:MaxPermSize=160m -bootclasspath >> /home/michael/src/jdk7/build/linux-amd64/classes >> >> Build Platform Settings: >> ?USER = michael >> ?PLATFORM = linux >> ?ARCH = amd64 >> ?LIBARCH = amd64 >> ?ARCH_FAMILY = amd64 >> ?ARCH_DATA_MODEL = 64 >> ?ARCHPROP = amd64 >> ?ALSA_VERSION = 1.0.24.1 >> ?OS_VERSION = 3.0.0-14-generic [requires at least 2.6] >> ?OS_VARIANT_NAME = Ubuntu >> ?OS_VARIANT_VERSION = 11.10 >> ?MB_OF_MEMORY = 7984 >> >> GNU Make Settings: >> ?MAKE = make >> ?MAKE_VER = 3.81 [requires at least 3.81] >> ?MAKECMDGOALS = sanity >> ?MAKEFLAGS = w >> ?SHELL = /bin/sh >> >> Target Build Versions: >> ?JDK_VERSION = 1.7.0 >> ?MILESTONE = internal >> ?RELEASE = 1.7.0-internal >> ?FULL_VERSION = 1.7.0-internal-michael_2011_12_21_16_51-b00 >> ?BUILD_NUMBER = b00 >> >> External File/Binary Locations: >> ?USRJDKINSTANCES_PATH = /opt/java >> ?BUILD_JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries >> ? ?ALT_BUILD_JDK_IMPORT_PATH = >> ?JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64 >> ? ?ALT_JDK_IMPORT_PATH = >> ?LANGTOOLS_DIST = >> ? ?ALT_LANGTOOLS_DIST = /home/michael/src/jdk7/build/linux-amd64/langtools/dist >> ?CORBA_DIST = >> ? ?ALT_CORBA_DIST = /home/michael/src/jdk7/build/linux-amd64/corba/dist >> ?JAXP_DIST = >> ? ?ALT_JAXP_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxp/dist >> ?JAXWS_DIST = >> ? ?ALT_JAXWS_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxws/dist >> ?HOTSPOT_DOCS_IMPORT_PATH = /NO_DOCS_DIR >> ? ?ALT_HOTSPOT_DOCS_IMPORT_PATH = >> ?HOTSPOT_IMPORT_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import >> ? ?ALT_HOTSPOT_IMPORT_PATH = >> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >> ?HOTSPOT_SERVER_PATH = >> /home/michael/src/jdk7/build/linux-amd64/hotspot/import/jre/lib/amd64/server >> ? ?ALT_HOTSPOT_SERVER_PATH = >> ?CACERTS_FILE = ./../src/share/lib/security/cacerts >> ? ?ALT_CACERTS_FILE = >> ?CUPS_HEADERS_PATH = /usr/include >> ? ?ALT_CUPS_HEADERS_PATH = >> >> OpenJDK-specific settings: >> ?FREETYPE_HEADERS_PATH = /usr/include >> ? ?ALT_FREETYPE_HEADERS_PATH = >> ?FREETYPE_LIB_PATH = /usr/lib >> ? ?ALT_FREETYPE_LIB_PATH = >> >> Previous JDK Settings: >> ?PREVIOUS_RELEASE_PATH = >> ? ?ALT_PREVIOUS_RELEASE_PATH = >> ?PREVIOUS_JDK_VERSION = 1.6.0 >> ? ?ALT_PREVIOUS_JDK_VERSION = >> ?PREVIOUS_JDK_FILE = >> ? ?ALT_PREVIOUS_JDK_FILE = >> ?PREVIOUS_JRE_FILE = >> ? ?ALT_PREVIOUS_JRE_FILE = >> ?PREVIOUS_RELEASE_IMAGE = >> ? ?ALT_PREVIOUS_RELEASE_IMAGE = >> >> >> Sanity check passed. >> michael at opportunity:~/src/jdk7$ > From kelly.ohair at oracle.com Wed Dec 21 18:35:27 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 21 Dec 2011 18:35:27 -0800 Subject: Need help in building openjdk in ubuntu 11.10 In-Reply-To: References: Message-ID: Later on it says: >>> Bootstrap Settings: >>> BOOTDIR = /NO_BOOTDIR >>> ALT_BOOTDIR = >>> BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at least 1.6] Which indicates that the make system did not see it. Run: env | fgrep ALT_BOOTDIR Oh, but this is Ubuntu 11.10 that could be an issue. The makefiles might not quite understand a kernel version that isn't 2.4 or 2.6. I know the hotspot Makefiles might need to have 3.0 added to the support list. But that doesn't explain why it is not seeing ALT_BOOTDIR. What does make --version say? -kto On Dec 21, 2011, at 6:11 PM, m silverstri wrote: > I did. > > $ echo $ALT_BOOTDIR > /home/michael/Programs/jdk1.6.0_30 > > On Wed, Dec 21, 2011 at 5:54 PM, Kelly O'Hair wrote: >> Did you export ALT_BOOTDIR? It needs to be set in the environment. >> >> -kto >> >> On Dec 21, 2011, at 4:55 PM, m silverstri wrote: >> >>> I have run and passed 'make sanity' and I have download and set >>> ALT_BOOTDIR to a jdk6: >>> >>> $ echo $ALT_BOOTDIR >>> /home/michael/Programs/jdk1.6.0_30 >>> >>> But when I 'make', i still get error saying 'We cannot execute >>> /NO_BOOTDIR/bin/java' >>> >>> make[2]: Entering directory `/home/michael/src/jdk7/langtools/make' >>> JAVA_HOME=/NO_BOOTDIR >>> ANT_OPTS=-Djava.io.tmpdir='/home/michael/src/jdk7/build/linux-amd64/langtools/build/ant-tmp' >>> ant -Djdk.version=1.7.0 >>> -Dfull.version='1.7.0-internal-michael_2011_12_21_16_53-b00' >>> -Dmilestone=internal -Dbuild.number=b00 -Djavac.target=7 >>> -Djavac.source=7 -Dboot.java.home=/NO_BOOTDIR >>> -Dimport.jdk=/home/michael/src/jdk7/jdk >>> -Dbuild.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/build >>> -Ddist.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >>> build >>> Error: JAVA_HOME is not defined correctly. >>> We cannot execute /NO_BOOTDIR/bin/java >>> make[2]: *** [build] Error 1 >>> >>> >>> ;; This buffer is for notes you don't want to save, and for Lisp evaluation. >>> ;; If you want to create a file, visit that file with C-x C-f, >>> ;; then enter the text in that file's own buffer. >>> >>> $ make sanity >>> ( cd ./jdk/make && \ >>> make sanity HOTSPOT_IMPORT_CHECK=false >>> JDK_TOPDIR=/home/michael/src/jdk7/jdk >>> JDK_MAKE_SHARED_DIR=/home/michael/src/jdk7/jdk/make/common/shared >>> EXTERNALSANITYCONTROL=true SOURCE_LANGUAGE_VERSION=7 >>> TARGET_CLASS_VERSION=7 MILESTONE=internal BUILD_NUMBER=b00 >>> JDK_BUILD_NUMBER=b00 >>> FULL_VERSION=1.7.0-internal-michael_2011_12_21_16_51-b00 >>> PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 >>> JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 >>> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 >>> PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 >>> ALT_OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64 >>> ALT_LANGTOOLS_DIST=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >>> ALT_CORBA_DIST=/home/michael/src/jdk7/build/linux-amd64/corba/dist >>> ALT_JAXP_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxp/dist >>> ALT_JAXWS_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxws/dist >>> ALT_HOTSPOT_IMPORT_PATH=/home/michael/src/jdk7/build/linux-amd64/hotspot/import >>> BUILD_HOTSPOT=true ; ) >>> [: 1: Illegal number: /bin/sh: >>> [: 1: Illegal number: /bin/sh: >>> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >>> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >>> [: 1: Illegal number: not >>> [: 1: Illegal number: not >>> [: 1: Illegal number: Error: >>> [: 1: Illegal number: Error: >>> [: 1: Illegal number: JAVA_HOME >>> [: 1: Illegal number: JAVA_HOME >>> [: 1: Illegal number: is >>> [: 1: Illegal number: is >>> make[1]: Entering directory `/home/michael/src/jdk7/jdk/make' >>> make[1]: Leaving directory `/home/michael/src/jdk7/jdk/make' >>> >>> Build Machine Information: >>> build machine = opportunity >>> >>> Build Directory Structure: >>> CWD = /home/michael/src/jdk7 >>> TOPDIR = . >>> LANGTOOLS_TOPDIR = ./langtools >>> JAXP_TOPDIR = ./jaxp >>> JAXWS_TOPDIR = ./jaxws >>> CORBA_TOPDIR = ./corba >>> HOTSPOT_TOPDIR = ./hotspot >>> JDK_TOPDIR = ./jdk >>> >>> Build Directives: >>> BUILD_LANGTOOLS = true >>> BUILD_JAXP = true >>> BUILD_JAXWS = true >>> BUILD_CORBA = true >>> BUILD_HOTSPOT = true >>> BUILD_JDK = true >>> DEBUG_CLASSFILES = >>> DEBUG_BINARIES = >>> >>> Hotspot Settings: >>> HOTSPOT_BUILD_JOBS = >>> HOTSPOT_OUTPUTDIR = >>> /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir >>> HOTSPOT_EXPORT_PATH = >>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>> >>> >>> >>> >>> Bootstrap Settings: >>> BOOTDIR = /NO_BOOTDIR >>> ALT_BOOTDIR = >>> BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at least 1.6] >>> OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>> ALT_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>> ABS_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>> >>> Build Tool Settings: >>> SLASH_JAVA = /NOT-SET >>> ALT_SLASH_JAVA = >>> VARIANT = OPT >>> JDK_DEVTOOLS_DIR = /NOT-SET/devtools >>> ALT_JDK_DEVTOOLS_DIR = >>> ANT_HOME = >>> UNIXCOMMAND_PATH = /bin/ >>> ALT_UNIXCOMMAND_PATH = >>> COMPILER_PATH = /usr/bin/ >>> ALT_COMPILER_PATH = >>> DEVTOOLS_PATH = /usr/bin/ >>> ALT_DEVTOOLS_PATH = >>> UNIXCCS_PATH = /usr/ccs/bin/ >>> ALT_UNIXCCS_PATH = >>> USRBIN_PATH = /usr/bin/ >>> ALT_USRBIN_PATH = >>> COMPILER_NAME = GCC4 >>> COMPILER_VERSION = GCC4 >>> CC_VER = 4.6.1 [requires at least 4.3.0] >>> ZIP_VER = 3.0 [requires at least 2.2] >>> UNZIP_VER = 6.00 [requires at least 5.12] >>> ANT_VER = Error: JAVA_HOME is not defined correctly. We cannot >>> execute /NO_BOOTDIR/bin/java [requires at least 1.7.1] >>> TEMPDIR = /home/michael/src/jdk7/build/linux-amd64/tmp >>> >>> Build Directives: >>> OPENJDK = true >>> USE_HOTSPOT_INTERPRETER_MODE = >>> PEDANTIC = >>> DEV_ONLY = >>> NO_DOCS = >>> NO_IMAGES = >>> TOOLS_ONLY = >>> INSANE = >>> COMPILE_APPROACH = parallel >>> PARALLEL_COMPILE_JOBS = 2 >>> ALT_PARALLEL_COMPILE_JOBS = >>> FASTDEBUG = >>> COMPILER_WARNINGS_FATAL = false >>> COMPILER_WARNING_LEVEL = >>> SHOW_ALL_WARNINGS = >>> INCREMENTAL_BUILD = false >>> CC_HIGHEST_OPT = >>> CC_HIGHER_OPT = >>> CC_LOWER_OPT = >>> CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused >>> -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN >>> CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused >>> -Wno-parentheses -pipe -fno-omit-frame-pointer -D_LITTLE_ENDIAN >>> BOOT_JAVA_CMD = /NO_BOOTDIR/bin/java -XX:-PrintVMOptions >>> -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m >>> -XX:PermSize=32m -XX:MaxPermSize=160m >>> BOOT_JAVAC_CMD = /NO_BOOTDIR/bin/javac -J-XX:ThreadStackSize=1536 >>> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >>> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >>> -J-XX:MaxPermSize=160m -encoding ascii -source 6 -target 6 >>> -XDignore.symbol.file=true >>> BOOT_JAR_CMD = /NO_BOOTDIR/bin/jar >>> BOOT_JARSIGNER_CMD = /NO_BOOTDIR/bin/jarsigner >>> JAVAC_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javac >>> -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions >>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -source 7 >>> -target 7 -encoding ascii >>> -Xbootclasspath:/home/michael/src/jdk7/build/linux-amd64/classes >>> JAVAH_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah >>> -bootclasspath /home/michael/src/jdk7/build/linux-amd64/classes >>> JAVADOC_CMD = >>> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javadoc >>> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >>> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >>> -J-XX:MaxPermSize=160m -bootclasspath >>> /home/michael/src/jdk7/build/linux-amd64/classes >>> >>> Build Platform Settings: >>> USER = michael >>> PLATFORM = linux >>> ARCH = amd64 >>> LIBARCH = amd64 >>> ARCH_FAMILY = amd64 >>> ARCH_DATA_MODEL = 64 >>> ARCHPROP = amd64 >>> ALSA_VERSION = 1.0.24.1 >>> OS_VERSION = 3.0.0-14-generic [requires at least 2.6] >>> OS_VARIANT_NAME = Ubuntu >>> OS_VARIANT_VERSION = 11.10 >>> MB_OF_MEMORY = 7984 >>> >>> GNU Make Settings: >>> MAKE = make >>> MAKE_VER = 3.81 [requires at least 3.81] >>> MAKECMDGOALS = sanity >>> MAKEFLAGS = w >>> SHELL = /bin/sh >>> >>> Target Build Versions: >>> JDK_VERSION = 1.7.0 >>> MILESTONE = internal >>> RELEASE = 1.7.0-internal >>> FULL_VERSION = 1.7.0-internal-michael_2011_12_21_16_51-b00 >>> BUILD_NUMBER = b00 >>> >>> External File/Binary Locations: >>> USRJDKINSTANCES_PATH = /opt/java >>> BUILD_JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries >>> ALT_BUILD_JDK_IMPORT_PATH = >>> JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64 >>> ALT_JDK_IMPORT_PATH = >>> LANGTOOLS_DIST = >>> ALT_LANGTOOLS_DIST = /home/michael/src/jdk7/build/linux-amd64/langtools/dist >>> CORBA_DIST = >>> ALT_CORBA_DIST = /home/michael/src/jdk7/build/linux-amd64/corba/dist >>> JAXP_DIST = >>> ALT_JAXP_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxp/dist >>> JAXWS_DIST = >>> ALT_JAXWS_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxws/dist >>> HOTSPOT_DOCS_IMPORT_PATH = /NO_DOCS_DIR >>> ALT_HOTSPOT_DOCS_IMPORT_PATH = >>> HOTSPOT_IMPORT_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>> ALT_HOTSPOT_IMPORT_PATH = >>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>> HOTSPOT_SERVER_PATH = >>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import/jre/lib/amd64/server >>> ALT_HOTSPOT_SERVER_PATH = >>> CACERTS_FILE = ./../src/share/lib/security/cacerts >>> ALT_CACERTS_FILE = >>> CUPS_HEADERS_PATH = /usr/include >>> ALT_CUPS_HEADERS_PATH = >>> >>> OpenJDK-specific settings: >>> FREETYPE_HEADERS_PATH = /usr/include >>> ALT_FREETYPE_HEADERS_PATH = >>> FREETYPE_LIB_PATH = /usr/lib >>> ALT_FREETYPE_LIB_PATH = >>> >>> Previous JDK Settings: >>> PREVIOUS_RELEASE_PATH = >>> ALT_PREVIOUS_RELEASE_PATH = >>> PREVIOUS_JDK_VERSION = 1.6.0 >>> ALT_PREVIOUS_JDK_VERSION = >>> PREVIOUS_JDK_FILE = >>> ALT_PREVIOUS_JDK_FILE = >>> PREVIOUS_JRE_FILE = >>> ALT_PREVIOUS_JRE_FILE = >>> PREVIOUS_RELEASE_IMAGE = >>> ALT_PREVIOUS_RELEASE_IMAGE = >>> >>> >>> Sanity check passed. >>> michael at opportunity:~/src/jdk7$ >> From littlee at linux.vnet.ibm.com Wed Dec 21 18:35:54 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Thu, 22 Dec 2011 10:35:54 +0800 Subject: Need help in building openjdk in ubuntu 11.10 In-Reply-To: References: Message-ID: <4EF2978A.5010103@linux.vnet.ibm.com> On 12/22/2011 10:11 AM, m silverstri wrote: > I did. > > $ echo $ALT_BOOTDIR > /home/michael/Programs/jdk1.6.0_30 > > On Wed, Dec 21, 2011 at 5:54 PM, Kelly O'Hair wrote: >> Did you export ALT_BOOTDIR? It needs to be set in the environment. >> >> -kto >> >> On Dec 21, 2011, at 4:55 PM, m silverstri wrote: >> >>> I have run and passed 'make sanity' and I have download and set >>> ALT_BOOTDIR to a jdk6: >>> >>> $ echo $ALT_BOOTDIR >>> /home/michael/Programs/jdk1.6.0_30 >>> >>> But when I 'make', i still get error saying 'We cannot execute >>> /NO_BOOTDIR/bin/java' >>> >>> make[2]: Entering directory `/home/michael/src/jdk7/langtools/make' >>> JAVA_HOME=/NO_BOOTDIR >>> ANT_OPTS=-Djava.io.tmpdir='/home/michael/src/jdk7/build/linux-amd64/langtools/build/ant-tmp' >>> ant -Djdk.version=1.7.0 >>> -Dfull.version='1.7.0-internal-michael_2011_12_21_16_53-b00' >>> -Dmilestone=internal -Dbuild.number=b00 -Djavac.target=7 >>> -Djavac.source=7 -Dboot.java.home=/NO_BOOTDIR >>> -Dimport.jdk=/home/michael/src/jdk7/jdk >>> -Dbuild.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/build >>> -Ddist.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >>> build >>> Error: JAVA_HOME is not defined correctly. >>> We cannot execute /NO_BOOTDIR/bin/java >>> make[2]: *** [build] Error 1 >>> >>> >>> ;; This buffer is for notes you don't want to save, and for Lisp evaluation. >>> ;; If you want to create a file, visit that file with C-x C-f, >>> ;; then enter the text in that file's own buffer. >>> >>> $ make sanity >>> ( cd ./jdk/make&& \ >>> make sanity HOTSPOT_IMPORT_CHECK=false >>> JDK_TOPDIR=/home/michael/src/jdk7/jdk >>> JDK_MAKE_SHARED_DIR=/home/michael/src/jdk7/jdk/make/common/shared >>> EXTERNALSANITYCONTROL=true SOURCE_LANGUAGE_VERSION=7 >>> TARGET_CLASS_VERSION=7 MILESTONE=internal BUILD_NUMBER=b00 >>> JDK_BUILD_NUMBER=b00 >>> FULL_VERSION=1.7.0-internal-michael_2011_12_21_16_51-b00 >>> PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 >>> JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 >>> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 >>> PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 >>> ALT_OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64 >>> ALT_LANGTOOLS_DIST=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >>> ALT_CORBA_DIST=/home/michael/src/jdk7/build/linux-amd64/corba/dist >>> ALT_JAXP_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxp/dist >>> ALT_JAXWS_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxws/dist >>> ALT_HOTSPOT_IMPORT_PATH=/home/michael/src/jdk7/build/linux-amd64/hotspot/import >>> BUILD_HOTSPOT=true ; ) >>> [: 1: Illegal number: /bin/sh: >>> [: 1: Illegal number: /bin/sh: >>> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >>> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >>> [: 1: Illegal number: not >>> [: 1: Illegal number: not >>> [: 1: Illegal number: Error: >>> [: 1: Illegal number: Error: >>> [: 1: Illegal number: JAVA_HOME >>> [: 1: Illegal number: JAVA_HOME >>> [: 1: Illegal number: is >>> [: 1: Illegal number: is >>> make[1]: Entering directory `/home/michael/src/jdk7/jdk/make' >>> make[1]: Leaving directory `/home/michael/src/jdk7/jdk/make' >>> >>> Build Machine Information: >>> build machine = opportunity >>> >>> Build Directory Structure: >>> CWD = /home/michael/src/jdk7 >>> TOPDIR = . >>> LANGTOOLS_TOPDIR = ./langtools >>> JAXP_TOPDIR = ./jaxp >>> JAXWS_TOPDIR = ./jaxws >>> CORBA_TOPDIR = ./corba >>> HOTSPOT_TOPDIR = ./hotspot >>> JDK_TOPDIR = ./jdk >>> >>> Build Directives: >>> BUILD_LANGTOOLS = true >>> BUILD_JAXP = true >>> BUILD_JAXWS = true >>> BUILD_CORBA = true >>> BUILD_HOTSPOT = true >>> BUILD_JDK = true >>> DEBUG_CLASSFILES = >>> DEBUG_BINARIES = >>> >>> Hotspot Settings: >>> HOTSPOT_BUILD_JOBS = >>> HOTSPOT_OUTPUTDIR = >>> /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir >>> HOTSPOT_EXPORT_PATH = >>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>> >>> >>> >>> >>> Bootstrap Settings: >>> BOOTDIR = /NO_BOOTDIR >>> ALT_BOOTDIR = >>> BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at least 1.6] >>> OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>> ALT_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>> ABS_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>> >>> Build Tool Settings: >>> SLASH_JAVA = /NOT-SET >>> ALT_SLASH_JAVA = >>> VARIANT = OPT >>> JDK_DEVTOOLS_DIR = /NOT-SET/devtools >>> ALT_JDK_DEVTOOLS_DIR = >>> ANT_HOME = >>> UNIXCOMMAND_PATH = /bin/ >>> ALT_UNIXCOMMAND_PATH = >>> COMPILER_PATH = /usr/bin/ >>> ALT_COMPILER_PATH = >>> DEVTOOLS_PATH = /usr/bin/ >>> ALT_DEVTOOLS_PATH = >>> UNIXCCS_PATH = /usr/ccs/bin/ >>> ALT_UNIXCCS_PATH = >>> USRBIN_PATH = /usr/bin/ >>> ALT_USRBIN_PATH = >>> COMPILER_NAME = GCC4 >>> COMPILER_VERSION = GCC4 >>> CC_VER = 4.6.1 [requires at least 4.3.0] >>> ZIP_VER = 3.0 [requires at least 2.2] >>> UNZIP_VER = 6.00 [requires at least 5.12] >>> ANT_VER = Error: JAVA_HOME is not defined correctly. We cannot >>> execute /NO_BOOTDIR/bin/java [requires at least 1.7.1] >>> TEMPDIR = /home/michael/src/jdk7/build/linux-amd64/tmp >>> >>> Build Directives: >>> OPENJDK = true >>> USE_HOTSPOT_INTERPRETER_MODE = >>> PEDANTIC = >>> DEV_ONLY = >>> NO_DOCS = >>> NO_IMAGES = >>> TOOLS_ONLY = >>> INSANE = >>> COMPILE_APPROACH = parallel >>> PARALLEL_COMPILE_JOBS = 2 >>> ALT_PARALLEL_COMPILE_JOBS = >>> FASTDEBUG = >>> COMPILER_WARNINGS_FATAL = false >>> COMPILER_WARNING_LEVEL = >>> SHOW_ALL_WARNINGS = >>> INCREMENTAL_BUILD = false >>> CC_HIGHEST_OPT = >>> CC_HIGHER_OPT = >>> CC_LOWER_OPT = >>> CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused >>> -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN >>> CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused >>> -Wno-parentheses -pipe -fno-omit-frame-pointer -D_LITTLE_ENDIAN >>> BOOT_JAVA_CMD = /NO_BOOTDIR/bin/java -XX:-PrintVMOptions >>> -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m >>> -XX:PermSize=32m -XX:MaxPermSize=160m >>> BOOT_JAVAC_CMD = /NO_BOOTDIR/bin/javac -J-XX:ThreadStackSize=1536 >>> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >>> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >>> -J-XX:MaxPermSize=160m -encoding ascii -source 6 -target 6 >>> -XDignore.symbol.file=true >>> BOOT_JAR_CMD = /NO_BOOTDIR/bin/jar >>> BOOT_JARSIGNER_CMD = /NO_BOOTDIR/bin/jarsigner >>> JAVAC_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javac >>> -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions >>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -source 7 >>> -target 7 -encoding ascii >>> -Xbootclasspath:/home/michael/src/jdk7/build/linux-amd64/classes >>> JAVAH_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah >>> -bootclasspath /home/michael/src/jdk7/build/linux-amd64/classes >>> JAVADOC_CMD = >>> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javadoc >>> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >>> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >>> -J-XX:MaxPermSize=160m -bootclasspath >>> /home/michael/src/jdk7/build/linux-amd64/classes >>> >>> Build Platform Settings: >>> USER = michael >>> PLATFORM = linux >>> ARCH = amd64 >>> LIBARCH = amd64 >>> ARCH_FAMILY = amd64 >>> ARCH_DATA_MODEL = 64 >>> ARCHPROP = amd64 >>> ALSA_VERSION = 1.0.24.1 >>> OS_VERSION = 3.0.0-14-generic [requires at least 2.6] >>> OS_VARIANT_NAME = Ubuntu >>> OS_VARIANT_VERSION = 11.10 >>> MB_OF_MEMORY = 7984 >>> >>> GNU Make Settings: >>> MAKE = make >>> MAKE_VER = 3.81 [requires at least 3.81] >>> MAKECMDGOALS = sanity >>> MAKEFLAGS = w >>> SHELL = /bin/sh >>> >>> Target Build Versions: >>> JDK_VERSION = 1.7.0 >>> MILESTONE = internal >>> RELEASE = 1.7.0-internal >>> FULL_VERSION = 1.7.0-internal-michael_2011_12_21_16_51-b00 >>> BUILD_NUMBER = b00 >>> >>> External File/Binary Locations: >>> USRJDKINSTANCES_PATH = /opt/java >>> BUILD_JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries >>> ALT_BUILD_JDK_IMPORT_PATH = >>> JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64 >>> ALT_JDK_IMPORT_PATH = >>> LANGTOOLS_DIST = >>> ALT_LANGTOOLS_DIST = /home/michael/src/jdk7/build/linux-amd64/langtools/dist >>> CORBA_DIST = >>> ALT_CORBA_DIST = /home/michael/src/jdk7/build/linux-amd64/corba/dist >>> JAXP_DIST = >>> ALT_JAXP_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxp/dist >>> JAXWS_DIST = >>> ALT_JAXWS_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxws/dist >>> HOTSPOT_DOCS_IMPORT_PATH = /NO_DOCS_DIR >>> ALT_HOTSPOT_DOCS_IMPORT_PATH = >>> HOTSPOT_IMPORT_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>> ALT_HOTSPOT_IMPORT_PATH = >>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>> HOTSPOT_SERVER_PATH = >>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import/jre/lib/amd64/server >>> ALT_HOTSPOT_SERVER_PATH = >>> CACERTS_FILE = ./../src/share/lib/security/cacerts >>> ALT_CACERTS_FILE = >>> CUPS_HEADERS_PATH = /usr/include >>> ALT_CUPS_HEADERS_PATH = >>> >>> OpenJDK-specific settings: >>> FREETYPE_HEADERS_PATH = /usr/include >>> ALT_FREETYPE_HEADERS_PATH = >>> FREETYPE_LIB_PATH = /usr/lib >>> ALT_FREETYPE_LIB_PATH = >>> >>> Previous JDK Settings: >>> PREVIOUS_RELEASE_PATH = >>> ALT_PREVIOUS_RELEASE_PATH = >>> PREVIOUS_JDK_VERSION = 1.6.0 >>> ALT_PREVIOUS_JDK_VERSION = >>> PREVIOUS_JDK_FILE = >>> ALT_PREVIOUS_JDK_FILE = >>> PREVIOUS_JRE_FILE = >>> ALT_PREVIOUS_JRE_FILE = >>> PREVIOUS_RELEASE_IMAGE = >>> ALT_PREVIOUS_RELEASE_IMAGE = >>> >>> >>> Sanity check passed. >>> michael at opportunity:~/src/jdk7$ Hi, After glancing my build script, I find I also set ALT_JDK_IMPORT_PATH. Would you please give it a try ? -- Yours Charles From stuart.marks at oracle.com Wed Dec 21 18:52:54 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 21 Dec 2011 18:52:54 -0800 Subject: Need help in building openjdk in ubuntu 11.10 In-Reply-To: References: Message-ID: <4EF29B86.5030506@oracle.com> It's not enough to *set* ALT_BOOTDIR, it also needs to be *exported* to the environment. If it's not exported, the variable is visible in your shell but isn't visible to subprocesses such as make. It looks like that's what's going on here. How you export something to the environment depends on the shell, but this is a fairly safe bet for the Bourne shell and its descendants: $ ALT_BOOTDIR=/home/michael/Programs/jdk1.6.0_30 ; export ALT_BOOTDIR A common shortcut that works for ksh and bash and friends is: $ export ALT_BOOTDIR=/home/michael/Programs/jdk1.6.0_30 s'marks On 12/21/11 6:35 PM, Kelly O'Hair wrote: > Later on it says: > >>>> Bootstrap Settings: >>>> BOOTDIR = /NO_BOOTDIR >>>> ALT_BOOTDIR = >>>> BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at least 1.6] > > Which indicates that the make system did not see it. > > Run: > env | fgrep ALT_BOOTDIR > > Oh, but this is Ubuntu 11.10 that could be an issue. > The makefiles might not quite understand a kernel version that isn't 2.4 or 2.6. > I know the hotspot Makefiles might need to have 3.0 added to the support list. > > But that doesn't explain why it is not seeing ALT_BOOTDIR. > > What does make --version say? > > > -kto > > On Dec 21, 2011, at 6:11 PM, m silverstri wrote: > >> I did. >> >> $ echo $ALT_BOOTDIR >> /home/michael/Programs/jdk1.6.0_30 >> >> On Wed, Dec 21, 2011 at 5:54 PM, Kelly O'Hair wrote: >>> Did you export ALT_BOOTDIR? It needs to be set in the environment. >>> >>> -kto >>> >>> On Dec 21, 2011, at 4:55 PM, m silverstri wrote: >>> >>>> I have run and passed 'make sanity' and I have download and set >>>> ALT_BOOTDIR to a jdk6: >>>> >>>> $ echo $ALT_BOOTDIR >>>> /home/michael/Programs/jdk1.6.0_30 >>>> >>>> But when I 'make', i still get error saying 'We cannot execute >>>> /NO_BOOTDIR/bin/java' >>>> >>>> make[2]: Entering directory `/home/michael/src/jdk7/langtools/make' >>>> JAVA_HOME=/NO_BOOTDIR >>>> ANT_OPTS=-Djava.io.tmpdir='/home/michael/src/jdk7/build/linux-amd64/langtools/build/ant-tmp' >>>> ant -Djdk.version=1.7.0 >>>> -Dfull.version='1.7.0-internal-michael_2011_12_21_16_53-b00' >>>> -Dmilestone=internal -Dbuild.number=b00 -Djavac.target=7 >>>> -Djavac.source=7 -Dboot.java.home=/NO_BOOTDIR >>>> -Dimport.jdk=/home/michael/src/jdk7/jdk >>>> -Dbuild.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/build >>>> -Ddist.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >>>> build >>>> Error: JAVA_HOME is not defined correctly. >>>> We cannot execute /NO_BOOTDIR/bin/java >>>> make[2]: *** [build] Error 1 >>>> >>>> >>>> ;; This buffer is for notes you don't want to save, and for Lisp evaluation. >>>> ;; If you want to create a file, visit that file with C-x C-f, >>>> ;; then enter the text in that file's own buffer. >>>> >>>> $ make sanity >>>> ( cd ./jdk/make&& \ >>>> make sanity HOTSPOT_IMPORT_CHECK=false >>>> JDK_TOPDIR=/home/michael/src/jdk7/jdk >>>> JDK_MAKE_SHARED_DIR=/home/michael/src/jdk7/jdk/make/common/shared >>>> EXTERNALSANITYCONTROL=true SOURCE_LANGUAGE_VERSION=7 >>>> TARGET_CLASS_VERSION=7 MILESTONE=internal BUILD_NUMBER=b00 >>>> JDK_BUILD_NUMBER=b00 >>>> FULL_VERSION=1.7.0-internal-michael_2011_12_21_16_51-b00 >>>> PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 >>>> JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 >>>> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 >>>> PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 >>>> ALT_OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64 >>>> ALT_LANGTOOLS_DIST=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >>>> ALT_CORBA_DIST=/home/michael/src/jdk7/build/linux-amd64/corba/dist >>>> ALT_JAXP_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxp/dist >>>> ALT_JAXWS_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxws/dist >>>> ALT_HOTSPOT_IMPORT_PATH=/home/michael/src/jdk7/build/linux-amd64/hotspot/import >>>> BUILD_HOTSPOT=true ; ) >>>> [: 1: Illegal number: /bin/sh: >>>> [: 1: Illegal number: /bin/sh: >>>> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >>>> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >>>> [: 1: Illegal number: not >>>> [: 1: Illegal number: not >>>> [: 1: Illegal number: Error: >>>> [: 1: Illegal number: Error: >>>> [: 1: Illegal number: JAVA_HOME >>>> [: 1: Illegal number: JAVA_HOME >>>> [: 1: Illegal number: is >>>> [: 1: Illegal number: is >>>> make[1]: Entering directory `/home/michael/src/jdk7/jdk/make' >>>> make[1]: Leaving directory `/home/michael/src/jdk7/jdk/make' >>>> >>>> Build Machine Information: >>>> build machine = opportunity >>>> >>>> Build Directory Structure: >>>> CWD = /home/michael/src/jdk7 >>>> TOPDIR = . >>>> LANGTOOLS_TOPDIR = ./langtools >>>> JAXP_TOPDIR = ./jaxp >>>> JAXWS_TOPDIR = ./jaxws >>>> CORBA_TOPDIR = ./corba >>>> HOTSPOT_TOPDIR = ./hotspot >>>> JDK_TOPDIR = ./jdk >>>> >>>> Build Directives: >>>> BUILD_LANGTOOLS = true >>>> BUILD_JAXP = true >>>> BUILD_JAXWS = true >>>> BUILD_CORBA = true >>>> BUILD_HOTSPOT = true >>>> BUILD_JDK = true >>>> DEBUG_CLASSFILES = >>>> DEBUG_BINARIES = >>>> >>>> Hotspot Settings: >>>> HOTSPOT_BUILD_JOBS = >>>> HOTSPOT_OUTPUTDIR = >>>> /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir >>>> HOTSPOT_EXPORT_PATH = >>>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>>> >>>> >>>> >>>> >>>> Bootstrap Settings: >>>> BOOTDIR = /NO_BOOTDIR >>>> ALT_BOOTDIR = >>>> BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at least 1.6] >>>> OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>>> ALT_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>>> ABS_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>>> >>>> Build Tool Settings: >>>> SLASH_JAVA = /NOT-SET >>>> ALT_SLASH_JAVA = >>>> VARIANT = OPT >>>> JDK_DEVTOOLS_DIR = /NOT-SET/devtools >>>> ALT_JDK_DEVTOOLS_DIR = >>>> ANT_HOME = >>>> UNIXCOMMAND_PATH = /bin/ >>>> ALT_UNIXCOMMAND_PATH = >>>> COMPILER_PATH = /usr/bin/ >>>> ALT_COMPILER_PATH = >>>> DEVTOOLS_PATH = /usr/bin/ >>>> ALT_DEVTOOLS_PATH = >>>> UNIXCCS_PATH = /usr/ccs/bin/ >>>> ALT_UNIXCCS_PATH = >>>> USRBIN_PATH = /usr/bin/ >>>> ALT_USRBIN_PATH = >>>> COMPILER_NAME = GCC4 >>>> COMPILER_VERSION = GCC4 >>>> CC_VER = 4.6.1 [requires at least 4.3.0] >>>> ZIP_VER = 3.0 [requires at least 2.2] >>>> UNZIP_VER = 6.00 [requires at least 5.12] >>>> ANT_VER = Error: JAVA_HOME is not defined correctly. We cannot >>>> execute /NO_BOOTDIR/bin/java [requires at least 1.7.1] >>>> TEMPDIR = /home/michael/src/jdk7/build/linux-amd64/tmp >>>> >>>> Build Directives: >>>> OPENJDK = true >>>> USE_HOTSPOT_INTERPRETER_MODE = >>>> PEDANTIC = >>>> DEV_ONLY = >>>> NO_DOCS = >>>> NO_IMAGES = >>>> TOOLS_ONLY = >>>> INSANE = >>>> COMPILE_APPROACH = parallel >>>> PARALLEL_COMPILE_JOBS = 2 >>>> ALT_PARALLEL_COMPILE_JOBS = >>>> FASTDEBUG = >>>> COMPILER_WARNINGS_FATAL = false >>>> COMPILER_WARNING_LEVEL = >>>> SHOW_ALL_WARNINGS = >>>> INCREMENTAL_BUILD = false >>>> CC_HIGHEST_OPT = >>>> CC_HIGHER_OPT = >>>> CC_LOWER_OPT = >>>> CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused >>>> -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN >>>> CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused >>>> -Wno-parentheses -pipe -fno-omit-frame-pointer -D_LITTLE_ENDIAN >>>> BOOT_JAVA_CMD = /NO_BOOTDIR/bin/java -XX:-PrintVMOptions >>>> -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m >>>> -XX:PermSize=32m -XX:MaxPermSize=160m >>>> BOOT_JAVAC_CMD = /NO_BOOTDIR/bin/javac -J-XX:ThreadStackSize=1536 >>>> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >>>> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >>>> -J-XX:MaxPermSize=160m -encoding ascii -source 6 -target 6 >>>> -XDignore.symbol.file=true >>>> BOOT_JAR_CMD = /NO_BOOTDIR/bin/jar >>>> BOOT_JARSIGNER_CMD = /NO_BOOTDIR/bin/jarsigner >>>> JAVAC_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javac >>>> -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions >>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -source 7 >>>> -target 7 -encoding ascii >>>> -Xbootclasspath:/home/michael/src/jdk7/build/linux-amd64/classes >>>> JAVAH_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah >>>> -bootclasspath /home/michael/src/jdk7/build/linux-amd64/classes >>>> JAVADOC_CMD = >>>> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javadoc >>>> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >>>> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >>>> -J-XX:MaxPermSize=160m -bootclasspath >>>> /home/michael/src/jdk7/build/linux-amd64/classes >>>> >>>> Build Platform Settings: >>>> USER = michael >>>> PLATFORM = linux >>>> ARCH = amd64 >>>> LIBARCH = amd64 >>>> ARCH_FAMILY = amd64 >>>> ARCH_DATA_MODEL = 64 >>>> ARCHPROP = amd64 >>>> ALSA_VERSION = 1.0.24.1 >>>> OS_VERSION = 3.0.0-14-generic [requires at least 2.6] >>>> OS_VARIANT_NAME = Ubuntu >>>> OS_VARIANT_VERSION = 11.10 >>>> MB_OF_MEMORY = 7984 >>>> >>>> GNU Make Settings: >>>> MAKE = make >>>> MAKE_VER = 3.81 [requires at least 3.81] >>>> MAKECMDGOALS = sanity >>>> MAKEFLAGS = w >>>> SHELL = /bin/sh >>>> >>>> Target Build Versions: >>>> JDK_VERSION = 1.7.0 >>>> MILESTONE = internal >>>> RELEASE = 1.7.0-internal >>>> FULL_VERSION = 1.7.0-internal-michael_2011_12_21_16_51-b00 >>>> BUILD_NUMBER = b00 >>>> >>>> External File/Binary Locations: >>>> USRJDKINSTANCES_PATH = /opt/java >>>> BUILD_JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries >>>> ALT_BUILD_JDK_IMPORT_PATH = >>>> JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64 >>>> ALT_JDK_IMPORT_PATH = >>>> LANGTOOLS_DIST = >>>> ALT_LANGTOOLS_DIST = /home/michael/src/jdk7/build/linux-amd64/langtools/dist >>>> CORBA_DIST = >>>> ALT_CORBA_DIST = /home/michael/src/jdk7/build/linux-amd64/corba/dist >>>> JAXP_DIST = >>>> ALT_JAXP_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxp/dist >>>> JAXWS_DIST = >>>> ALT_JAXWS_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxws/dist >>>> HOTSPOT_DOCS_IMPORT_PATH = /NO_DOCS_DIR >>>> ALT_HOTSPOT_DOCS_IMPORT_PATH = >>>> HOTSPOT_IMPORT_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>>> ALT_HOTSPOT_IMPORT_PATH = >>>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>>> HOTSPOT_SERVER_PATH = >>>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import/jre/lib/amd64/server >>>> ALT_HOTSPOT_SERVER_PATH = >>>> CACERTS_FILE = ./../src/share/lib/security/cacerts >>>> ALT_CACERTS_FILE = >>>> CUPS_HEADERS_PATH = /usr/include >>>> ALT_CUPS_HEADERS_PATH = >>>> >>>> OpenJDK-specific settings: >>>> FREETYPE_HEADERS_PATH = /usr/include >>>> ALT_FREETYPE_HEADERS_PATH = >>>> FREETYPE_LIB_PATH = /usr/lib >>>> ALT_FREETYPE_LIB_PATH = >>>> >>>> Previous JDK Settings: >>>> PREVIOUS_RELEASE_PATH = >>>> ALT_PREVIOUS_RELEASE_PATH = >>>> PREVIOUS_JDK_VERSION = 1.6.0 >>>> ALT_PREVIOUS_JDK_VERSION = >>>> PREVIOUS_JDK_FILE = >>>> ALT_PREVIOUS_JDK_FILE = >>>> PREVIOUS_JRE_FILE = >>>> ALT_PREVIOUS_JRE_FILE = >>>> PREVIOUS_RELEASE_IMAGE = >>>> ALT_PREVIOUS_RELEASE_IMAGE = >>>> >>>> >>>> Sanity check passed. >>>> michael at opportunity:~/src/jdk7$ >>> > From maurizio.cimadamore at oracle.com Thu Dec 22 01:31:56 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 22 Dec 2011 09:31:56 +0000 Subject: Need help in building openjdk in ubuntu 11.10 In-Reply-To: <4EF2978A.5010103@linux.vnet.ibm.com> References: <4EF2978A.5010103@linux.vnet.ibm.com> Message-ID: <4EF2F90C.3010201@oracle.com> Attached is the script I use to build JDK on Ubuntu 11.10 (x64). Works for me. You will have to update the paths to the JDK accordingly. Maurizio On 22/12/11 02:35, Charles Lee wrote: > On 12/22/2011 10:11 AM, m silverstri wrote: >> I did. >> >> $ echo $ALT_BOOTDIR >> /home/michael/Programs/jdk1.6.0_30 >> >> On Wed, Dec 21, 2011 at 5:54 PM, Kelly >> O'Hair wrote: >>> Did you export ALT_BOOTDIR? It needs to be set in the environment. >>> >>> -kto >>> >>> On Dec 21, 2011, at 4:55 PM, m silverstri wrote: >>> >>>> I have run and passed 'make sanity' and I have download and set >>>> ALT_BOOTDIR to a jdk6: >>>> >>>> $ echo $ALT_BOOTDIR >>>> /home/michael/Programs/jdk1.6.0_30 >>>> >>>> But when I 'make', i still get error saying 'We cannot execute >>>> /NO_BOOTDIR/bin/java' >>>> >>>> make[2]: Entering directory `/home/michael/src/jdk7/langtools/make' >>>> JAVA_HOME=/NO_BOOTDIR >>>> ANT_OPTS=-Djava.io.tmpdir='/home/michael/src/jdk7/build/linux-amd64/langtools/build/ant-tmp' >>>> >>>> ant -Djdk.version=1.7.0 >>>> -Dfull.version='1.7.0-internal-michael_2011_12_21_16_53-b00' >>>> -Dmilestone=internal -Dbuild.number=b00 -Djavac.target=7 >>>> -Djavac.source=7 -Dboot.java.home=/NO_BOOTDIR >>>> -Dimport.jdk=/home/michael/src/jdk7/jdk >>>> -Dbuild.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/build >>>> -Ddist.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >>>> build >>>> Error: JAVA_HOME is not defined correctly. >>>> We cannot execute /NO_BOOTDIR/bin/java >>>> make[2]: *** [build] Error 1 >>>> >>>> >>>> ;; This buffer is for notes you don't want to save, and for Lisp >>>> evaluation. >>>> ;; If you want to create a file, visit that file with C-x C-f, >>>> ;; then enter the text in that file's own buffer. >>>> >>>> $ make sanity >>>> ( cd ./jdk/make&& \ >>>> make sanity HOTSPOT_IMPORT_CHECK=false >>>> JDK_TOPDIR=/home/michael/src/jdk7/jdk >>>> JDK_MAKE_SHARED_DIR=/home/michael/src/jdk7/jdk/make/common/shared >>>> EXTERNALSANITYCONTROL=true SOURCE_LANGUAGE_VERSION=7 >>>> TARGET_CLASS_VERSION=7 MILESTONE=internal BUILD_NUMBER=b00 >>>> JDK_BUILD_NUMBER=b00 >>>> FULL_VERSION=1.7.0-internal-michael_2011_12_21_16_51-b00 >>>> PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 >>>> JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 >>>> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 >>>> PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 >>>> ALT_OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64 >>>> ALT_LANGTOOLS_DIST=/home/michael/src/jdk7/build/linux-amd64/langtools/dist >>>> >>>> ALT_CORBA_DIST=/home/michael/src/jdk7/build/linux-amd64/corba/dist >>>> ALT_JAXP_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxp/dist >>>> ALT_JAXWS_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxws/dist >>>> ALT_HOTSPOT_IMPORT_PATH=/home/michael/src/jdk7/build/linux-amd64/hotspot/import >>>> >>>> BUILD_HOTSPOT=true ; ) >>>> [: 1: Illegal number: /bin/sh: >>>> [: 1: Illegal number: /bin/sh: >>>> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >>>> [: 1: Illegal number: /NO_BOOTDIR/bin/java: >>>> [: 1: Illegal number: not >>>> [: 1: Illegal number: not >>>> [: 1: Illegal number: Error: >>>> [: 1: Illegal number: Error: >>>> [: 1: Illegal number: JAVA_HOME >>>> [: 1: Illegal number: JAVA_HOME >>>> [: 1: Illegal number: is >>>> [: 1: Illegal number: is >>>> make[1]: Entering directory `/home/michael/src/jdk7/jdk/make' >>>> make[1]: Leaving directory `/home/michael/src/jdk7/jdk/make' >>>> >>>> Build Machine Information: >>>> build machine = opportunity >>>> >>>> Build Directory Structure: >>>> CWD = /home/michael/src/jdk7 >>>> TOPDIR = . >>>> LANGTOOLS_TOPDIR = ./langtools >>>> JAXP_TOPDIR = ./jaxp >>>> JAXWS_TOPDIR = ./jaxws >>>> CORBA_TOPDIR = ./corba >>>> HOTSPOT_TOPDIR = ./hotspot >>>> JDK_TOPDIR = ./jdk >>>> >>>> Build Directives: >>>> BUILD_LANGTOOLS = true >>>> BUILD_JAXP = true >>>> BUILD_JAXWS = true >>>> BUILD_CORBA = true >>>> BUILD_HOTSPOT = true >>>> BUILD_JDK = true >>>> DEBUG_CLASSFILES = >>>> DEBUG_BINARIES = >>>> >>>> Hotspot Settings: >>>> HOTSPOT_BUILD_JOBS = >>>> HOTSPOT_OUTPUTDIR = >>>> /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir >>>> HOTSPOT_EXPORT_PATH = >>>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>>> >>>> >>>> >>>> >>>> Bootstrap Settings: >>>> BOOTDIR = /NO_BOOTDIR >>>> ALT_BOOTDIR = >>>> BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at >>>> least 1.6] >>>> OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>>> ALT_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>>> ABS_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 >>>> >>>> Build Tool Settings: >>>> SLASH_JAVA = /NOT-SET >>>> ALT_SLASH_JAVA = >>>> VARIANT = OPT >>>> JDK_DEVTOOLS_DIR = /NOT-SET/devtools >>>> ALT_JDK_DEVTOOLS_DIR = >>>> ANT_HOME = >>>> UNIXCOMMAND_PATH = /bin/ >>>> ALT_UNIXCOMMAND_PATH = >>>> COMPILER_PATH = /usr/bin/ >>>> ALT_COMPILER_PATH = >>>> DEVTOOLS_PATH = /usr/bin/ >>>> ALT_DEVTOOLS_PATH = >>>> UNIXCCS_PATH = /usr/ccs/bin/ >>>> ALT_UNIXCCS_PATH = >>>> USRBIN_PATH = /usr/bin/ >>>> ALT_USRBIN_PATH = >>>> COMPILER_NAME = GCC4 >>>> COMPILER_VERSION = GCC4 >>>> CC_VER = 4.6.1 [requires at least 4.3.0] >>>> ZIP_VER = 3.0 [requires at least 2.2] >>>> UNZIP_VER = 6.00 [requires at least 5.12] >>>> ANT_VER = Error: JAVA_HOME is not defined correctly. We cannot >>>> execute /NO_BOOTDIR/bin/java [requires at least 1.7.1] >>>> TEMPDIR = /home/michael/src/jdk7/build/linux-amd64/tmp >>>> >>>> Build Directives: >>>> OPENJDK = true >>>> USE_HOTSPOT_INTERPRETER_MODE = >>>> PEDANTIC = >>>> DEV_ONLY = >>>> NO_DOCS = >>>> NO_IMAGES = >>>> TOOLS_ONLY = >>>> INSANE = >>>> COMPILE_APPROACH = parallel >>>> PARALLEL_COMPILE_JOBS = 2 >>>> ALT_PARALLEL_COMPILE_JOBS = >>>> FASTDEBUG = >>>> COMPILER_WARNINGS_FATAL = false >>>> COMPILER_WARNING_LEVEL = >>>> SHOW_ALL_WARNINGS = >>>> INCREMENTAL_BUILD = false >>>> CC_HIGHEST_OPT = >>>> CC_HIGHER_OPT = >>>> CC_LOWER_OPT = >>>> CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused >>>> -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN >>>> CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused >>>> -Wno-parentheses -pipe -fno-omit-frame-pointer -D_LITTLE_ENDIAN >>>> BOOT_JAVA_CMD = /NO_BOOTDIR/bin/java -XX:-PrintVMOptions >>>> -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m >>>> -XX:PermSize=32m -XX:MaxPermSize=160m >>>> BOOT_JAVAC_CMD = /NO_BOOTDIR/bin/javac -J-XX:ThreadStackSize=1536 >>>> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >>>> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >>>> -J-XX:MaxPermSize=160m -encoding ascii -source 6 -target 6 >>>> -XDignore.symbol.file=true >>>> BOOT_JAR_CMD = /NO_BOOTDIR/bin/jar >>>> BOOT_JARSIGNER_CMD = /NO_BOOTDIR/bin/jarsigner >>>> JAVAC_CMD = >>>> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javac >>>> -J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions >>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -source 7 >>>> -target 7 -encoding ascii >>>> -Xbootclasspath:/home/michael/src/jdk7/build/linux-amd64/classes >>>> JAVAH_CMD = >>>> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah >>>> -bootclasspath /home/michael/src/jdk7/build/linux-amd64/classes >>>> JAVADOC_CMD = >>>> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javadoc >>>> -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >>>> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >>>> -J-XX:MaxPermSize=160m -bootclasspath >>>> /home/michael/src/jdk7/build/linux-amd64/classes >>>> >>>> Build Platform Settings: >>>> USER = michael >>>> PLATFORM = linux >>>> ARCH = amd64 >>>> LIBARCH = amd64 >>>> ARCH_FAMILY = amd64 >>>> ARCH_DATA_MODEL = 64 >>>> ARCHPROP = amd64 >>>> ALSA_VERSION = 1.0.24.1 >>>> OS_VERSION = 3.0.0-14-generic [requires at least 2.6] >>>> OS_VARIANT_NAME = Ubuntu >>>> OS_VARIANT_VERSION = 11.10 >>>> MB_OF_MEMORY = 7984 >>>> >>>> GNU Make Settings: >>>> MAKE = make >>>> MAKE_VER = 3.81 [requires at least 3.81] >>>> MAKECMDGOALS = sanity >>>> MAKEFLAGS = w >>>> SHELL = /bin/sh >>>> >>>> Target Build Versions: >>>> JDK_VERSION = 1.7.0 >>>> MILESTONE = internal >>>> RELEASE = 1.7.0-internal >>>> FULL_VERSION = 1.7.0-internal-michael_2011_12_21_16_51-b00 >>>> BUILD_NUMBER = b00 >>>> >>>> External File/Binary Locations: >>>> USRJDKINSTANCES_PATH = /opt/java >>>> BUILD_JDK_IMPORT_PATH = >>>> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries >>>> ALT_BUILD_JDK_IMPORT_PATH = >>>> JDK_IMPORT_PATH = >>>> /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64 >>>> ALT_JDK_IMPORT_PATH = >>>> LANGTOOLS_DIST = >>>> ALT_LANGTOOLS_DIST = >>>> /home/michael/src/jdk7/build/linux-amd64/langtools/dist >>>> CORBA_DIST = >>>> ALT_CORBA_DIST = >>>> /home/michael/src/jdk7/build/linux-amd64/corba/dist >>>> JAXP_DIST = >>>> ALT_JAXP_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxp/dist >>>> JAXWS_DIST = >>>> ALT_JAXWS_DIST = >>>> /home/michael/src/jdk7/build/linux-amd64/jaxws/dist >>>> HOTSPOT_DOCS_IMPORT_PATH = /NO_DOCS_DIR >>>> ALT_HOTSPOT_DOCS_IMPORT_PATH = >>>> HOTSPOT_IMPORT_PATH = >>>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>>> ALT_HOTSPOT_IMPORT_PATH = >>>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import >>>> HOTSPOT_SERVER_PATH = >>>> /home/michael/src/jdk7/build/linux-amd64/hotspot/import/jre/lib/amd64/server >>>> >>>> ALT_HOTSPOT_SERVER_PATH = >>>> CACERTS_FILE = ./../src/share/lib/security/cacerts >>>> ALT_CACERTS_FILE = >>>> CUPS_HEADERS_PATH = /usr/include >>>> ALT_CUPS_HEADERS_PATH = >>>> >>>> OpenJDK-specific settings: >>>> FREETYPE_HEADERS_PATH = /usr/include >>>> ALT_FREETYPE_HEADERS_PATH = >>>> FREETYPE_LIB_PATH = /usr/lib >>>> ALT_FREETYPE_LIB_PATH = >>>> >>>> Previous JDK Settings: >>>> PREVIOUS_RELEASE_PATH = >>>> ALT_PREVIOUS_RELEASE_PATH = >>>> PREVIOUS_JDK_VERSION = 1.6.0 >>>> ALT_PREVIOUS_JDK_VERSION = >>>> PREVIOUS_JDK_FILE = >>>> ALT_PREVIOUS_JDK_FILE = >>>> PREVIOUS_JRE_FILE = >>>> ALT_PREVIOUS_JRE_FILE = >>>> PREVIOUS_RELEASE_IMAGE = >>>> ALT_PREVIOUS_RELEASE_IMAGE = >>>> >>>> >>>> Sanity check passed. >>>> michael at opportunity:~/src/jdk7$ > Hi, > > After glancing my build script, I find I also set ALT_JDK_IMPORT_PATH. > Would you please give it a try ? > -------------- next part -------------- A non-text attachment was scrubbed... Name: build-jdk.sh Type: application/x-shellscript Size: 305 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/build-dev/attachments/20111222/d5586cf4/build-jdk.sh From oehrstroem at gmail.com Thu Dec 22 02:17:47 2011 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Thu, 22 Dec 2011 11:17:47 +0100 Subject: Need help in building openjdk in ubuntu 11.10 In-Reply-To: References: Message-ID: Please try cloning http://hg.openjdk.java.net/build-infra/jdk7 then do ./configure and follow the instructions to fetch the missing config.guess config.sub and pkg.m4 as well as any dev package. Then type make Then you can run ./build/linux..../jdk/bin/java Then type make install And it will be installed in /usr/local/bin Did it work? //Fredrik 2011/12/22 m silverstri : > I have run and passed 'make sanity' and I have download and set > ALT_BOOTDIR ?to a jdk6: > > $ echo $ALT_BOOTDIR > /home/michael/Programs/jdk1.6.0_30 > > But when I 'make', i still get error saying 'We cannot execute > /NO_BOOTDIR/bin/java' > > make[2]: Entering directory `/home/michael/src/jdk7/langtools/make' > JAVA_HOME=/NO_BOOTDIR > ANT_OPTS=-Djava.io.tmpdir='/home/michael/src/jdk7/build/linux-amd64/langtools/build/ant-tmp' > ant -Djdk.version=1.7.0 > -Dfull.version='1.7.0-internal-michael_2011_12_21_16_53-b00' > -Dmilestone=internal -Dbuild.number=b00 -Djavac.target=7 > -Djavac.source=7 -Dboot.java.home=/NO_BOOTDIR > -Dimport.jdk=/home/michael/src/jdk7/jdk > -Dbuild.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/build > -Ddist.dir=/home/michael/src/jdk7/build/linux-amd64/langtools/dist > build > Error: JAVA_HOME is not defined correctly. > ?We cannot execute /NO_BOOTDIR/bin/java > make[2]: *** [build] Error 1 > > > ;; This buffer is for notes you don't want to save, and for Lisp evaluation. > ;; If you want to create a file, visit that file with C-x C-f, > ;; then enter the text in that file's own buffer. > > $ make sanity > ( cd ?./jdk/make && \ > ? ? ? ? ?make sanity HOTSPOT_IMPORT_CHECK=false > JDK_TOPDIR=/home/michael/src/jdk7/jdk > JDK_MAKE_SHARED_DIR=/home/michael/src/jdk7/jdk/make/common/shared > EXTERNALSANITYCONTROL=true SOURCE_LANGUAGE_VERSION=7 > TARGET_CLASS_VERSION=7 MILESTONE=internal BUILD_NUMBER=b00 > JDK_BUILD_NUMBER=b00 > FULL_VERSION=1.7.0-internal-michael_2011_12_21_16_51-b00 > PREVIOUS_JDK_VERSION=1.6.0 JDK_VERSION=1.7.0 JDK_MKTG_VERSION=7 > JDK_MAJOR_VERSION=1 JDK_MINOR_VERSION=7 JDK_MICRO_VERSION=0 > PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=6 > PREVIOUS_MICRO_VERSION=0 ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 > ALT_OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64 > ALT_LANGTOOLS_DIST=/home/michael/src/jdk7/build/linux-amd64/langtools/dist > ALT_CORBA_DIST=/home/michael/src/jdk7/build/linux-amd64/corba/dist > ALT_JAXP_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxp/dist > ALT_JAXWS_DIST=/home/michael/src/jdk7/build/linux-amd64/jaxws/dist > ALT_HOTSPOT_IMPORT_PATH=/home/michael/src/jdk7/build/linux-amd64/hotspot/import > BUILD_HOTSPOT=true ; ) > [: 1: Illegal number: /bin/sh: > [: 1: Illegal number: /bin/sh: > [: 1: Illegal number: /NO_BOOTDIR/bin/java: > [: 1: Illegal number: /NO_BOOTDIR/bin/java: > [: 1: Illegal number: not > [: 1: Illegal number: not > [: 1: Illegal number: Error: > [: 1: Illegal number: Error: > [: 1: Illegal number: JAVA_HOME > [: 1: Illegal number: JAVA_HOME > [: 1: Illegal number: is > [: 1: Illegal number: is > make[1]: Entering directory `/home/michael/src/jdk7/jdk/make' > make[1]: Leaving directory `/home/michael/src/jdk7/jdk/make' > > Build Machine Information: > ? build machine = opportunity > > Build Directory Structure: > ? CWD = /home/michael/src/jdk7 > ? TOPDIR = . > ? LANGTOOLS_TOPDIR = ./langtools > ? JAXP_TOPDIR = ./jaxp > ? JAXWS_TOPDIR = ./jaxws > ? CORBA_TOPDIR = ./corba > ? HOTSPOT_TOPDIR = ./hotspot > ? JDK_TOPDIR = ./jdk > > Build Directives: > ? BUILD_LANGTOOLS = true > ? BUILD_JAXP = true > ? BUILD_JAXWS = true > ? BUILD_CORBA = true > ? BUILD_HOTSPOT = true > ? BUILD_JDK ? ?= true > ? DEBUG_CLASSFILES = > ? DEBUG_BINARIES = > > Hotspot Settings: > ? ? ?HOTSPOT_BUILD_JOBS ?= > ? ? ?HOTSPOT_OUTPUTDIR ? = > /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir > ? ? ?HOTSPOT_EXPORT_PATH = > /home/michael/src/jdk7/build/linux-amd64/hotspot/import > > > > > Bootstrap Settings: > ?BOOTDIR = /NO_BOOTDIR > ? ?ALT_BOOTDIR = > ?BOOT_VER = /bin/sh: /NO_BOOTDIR/bin/java: not found [requires at least 1.6] > ?OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 > ? ?ALT_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 > ?ABS_OUTPUTDIR = /home/michael/src/jdk7/build/linux-amd64 > > Build Tool Settings: > ?SLASH_JAVA = /NOT-SET > ? ?ALT_SLASH_JAVA = > ?VARIANT = OPT > ?JDK_DEVTOOLS_DIR = /NOT-SET/devtools > ? ?ALT_JDK_DEVTOOLS_DIR = > ?ANT_HOME = > ?UNIXCOMMAND_PATH = /bin/ > ? ?ALT_UNIXCOMMAND_PATH = > ?COMPILER_PATH = /usr/bin/ > ? ?ALT_COMPILER_PATH = > ?DEVTOOLS_PATH = /usr/bin/ > ? ?ALT_DEVTOOLS_PATH = > ?UNIXCCS_PATH = /usr/ccs/bin/ > ? ?ALT_UNIXCCS_PATH = > ?USRBIN_PATH = /usr/bin/ > ? ?ALT_USRBIN_PATH = > ?COMPILER_NAME = GCC4 > ?COMPILER_VERSION = GCC4 > ?CC_VER = 4.6.1 [requires at least 4.3.0] > ?ZIP_VER = 3.0 [requires at least 2.2] > ?UNZIP_VER = 6.00 [requires at least 5.12] > ?ANT_VER = Error: JAVA_HOME is not defined correctly. ? We cannot > execute /NO_BOOTDIR/bin/java [requires at least 1.7.1] > ?TEMPDIR = /home/michael/src/jdk7/build/linux-amd64/tmp > > Build Directives: > ?OPENJDK = true > ?USE_HOTSPOT_INTERPRETER_MODE = > ?PEDANTIC = > ?DEV_ONLY = > ?NO_DOCS = > ?NO_IMAGES = > ?TOOLS_ONLY = > ?INSANE = > ?COMPILE_APPROACH = parallel > ?PARALLEL_COMPILE_JOBS = 2 > ? ?ALT_PARALLEL_COMPILE_JOBS = > ?FASTDEBUG = > ?COMPILER_WARNINGS_FATAL = false > ?COMPILER_WARNING_LEVEL = > ?SHOW_ALL_WARNINGS = > ?INCREMENTAL_BUILD = false > ?CC_HIGHEST_OPT = > ?CC_HIGHER_OPT = > ?CC_LOWER_OPT = > ?CXXFLAGS = ?-O2 -fPIC -DCC_NOEX -W -Wall ?-Wno-unused > -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN > ?CFLAGS = ?-O2 ? -fno-strict-aliasing -fPIC -W -Wall ?-Wno-unused > -Wno-parentheses -pipe -fno-omit-frame-pointer -D_LITTLE_ENDIAN > ?BOOT_JAVA_CMD = /NO_BOOTDIR/bin/java -XX:-PrintVMOptions > -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Xmx512m -Xms512m > -XX:PermSize=32m -XX:MaxPermSize=160m > ?BOOT_JAVAC_CMD = /NO_BOOTDIR/bin/javac ?-J-XX:ThreadStackSize=1536 > -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions > -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m > -J-XX:MaxPermSize=160m -encoding ascii -source 6 -target 6 > -XDignore.symbol.file=true > ?BOOT_JAR_CMD = /NO_BOOTDIR/bin/jar > ?BOOT_JARSIGNER_CMD = /NO_BOOTDIR/bin/jarsigner > ?JAVAC_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javac > ?-J-XX:ThreadStackSize=1536 -J-XX:-PrintVMOptions > -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m > -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m ?-source 7 > -target 7 -encoding ascii > -Xbootclasspath:/home/michael/src/jdk7/build/linux-amd64/classes > ?JAVAH_CMD = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javah > -bootclasspath /home/michael/src/jdk7/build/linux-amd64/classes > ?JAVADOC_CMD = > /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64/bin/javadoc > -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions > -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m > -J-XX:MaxPermSize=160m -bootclasspath > /home/michael/src/jdk7/build/linux-amd64/classes > > Build Platform Settings: > ?USER = michael > ?PLATFORM = linux > ?ARCH = amd64 > ?LIBARCH = amd64 > ?ARCH_FAMILY = amd64 > ?ARCH_DATA_MODEL = 64 > ?ARCHPROP = amd64 > ?ALSA_VERSION = 1.0.24.1 > ?OS_VERSION = 3.0.0-14-generic [requires at least 2.6] > ?OS_VARIANT_NAME = Ubuntu > ?OS_VARIANT_VERSION = 11.10 > ?MB_OF_MEMORY = 7984 > > GNU Make Settings: > ?MAKE = make > ?MAKE_VER = 3.81 [requires at least 3.81] > ?MAKECMDGOALS = sanity > ?MAKEFLAGS = w > ?SHELL = /bin/sh > > Target Build Versions: > ?JDK_VERSION = 1.7.0 > ?MILESTONE = internal > ?RELEASE = 1.7.0-internal > ?FULL_VERSION = 1.7.0-internal-michael_2011_12_21_16_51-b00 > ?BUILD_NUMBER = b00 > > External File/Binary Locations: > ?USRJDKINSTANCES_PATH = /opt/java > ?BUILD_JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries > ? ?ALT_BUILD_JDK_IMPORT_PATH = > ?JDK_IMPORT_PATH = /NOT-SET/re/jdk/1.7.0/promoted/latest/binaries/linux-amd64 > ? ?ALT_JDK_IMPORT_PATH = > ?LANGTOOLS_DIST = > ? ?ALT_LANGTOOLS_DIST = /home/michael/src/jdk7/build/linux-amd64/langtools/dist > ?CORBA_DIST = > ? ?ALT_CORBA_DIST = /home/michael/src/jdk7/build/linux-amd64/corba/dist > ?JAXP_DIST = > ? ?ALT_JAXP_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxp/dist > ?JAXWS_DIST = > ? ?ALT_JAXWS_DIST = /home/michael/src/jdk7/build/linux-amd64/jaxws/dist > ?HOTSPOT_DOCS_IMPORT_PATH = /NO_DOCS_DIR > ? ?ALT_HOTSPOT_DOCS_IMPORT_PATH = > ?HOTSPOT_IMPORT_PATH = /home/michael/src/jdk7/build/linux-amd64/hotspot/import > ? ?ALT_HOTSPOT_IMPORT_PATH = > /home/michael/src/jdk7/build/linux-amd64/hotspot/import > ?HOTSPOT_SERVER_PATH = > /home/michael/src/jdk7/build/linux-amd64/hotspot/import/jre/lib/amd64/server > ? ?ALT_HOTSPOT_SERVER_PATH = > ?CACERTS_FILE = ./../src/share/lib/security/cacerts > ? ?ALT_CACERTS_FILE = > ?CUPS_HEADERS_PATH = /usr/include > ? ?ALT_CUPS_HEADERS_PATH = > > OpenJDK-specific settings: > ?FREETYPE_HEADERS_PATH = /usr/include > ? ?ALT_FREETYPE_HEADERS_PATH = > ?FREETYPE_LIB_PATH = /usr/lib > ? ?ALT_FREETYPE_LIB_PATH = > > Previous JDK Settings: > ?PREVIOUS_RELEASE_PATH = > ? ?ALT_PREVIOUS_RELEASE_PATH = > ?PREVIOUS_JDK_VERSION = 1.6.0 > ? ?ALT_PREVIOUS_JDK_VERSION = > ?PREVIOUS_JDK_FILE = > ? ?ALT_PREVIOUS_JDK_FILE = > ?PREVIOUS_JRE_FILE = > ? ?ALT_PREVIOUS_JRE_FILE = > ?PREVIOUS_RELEASE_IMAGE = > ? ?ALT_PREVIOUS_RELEASE_IMAGE = > > > Sanity check passed. > michael at opportunity:~/src/jdk7$ From Alan.Bateman at oracle.com Thu Dec 22 03:52:06 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 22 Dec 2011 11:52:06 +0000 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EF28D2E.3010504@oracle.com> References: <4EEAB41C.5000300@oracle.com> <4EEB160B.2060909@oracle.com> <4EEB1FD6.60707@oracle.com> <4EF14464.5000103@oracle.com> <4EF28D2E.3010504@oracle.com> Message-ID: <4EF319E6.2040806@oracle.com> On 22/12/2011 01:51, Stuart Marks wrote: > > I dug up a bit of background on this. Apparently Sasha ran across this > problem back in July and asked about this on net-dev [1]. Discussion > continued on build-dev [2]. Kurchi later picked up this work and after > some discussion got it integrated [3]. > > I didn't see Sasha's original webrev, but he might have fixed all the > warnings in the java.net package, enabled -Werror in > make/java/net/Makefile, and then was surprised to find that this build > step was (implicitly) compiling files that weren't in the java.net > package. Kurchi's fix [3] apparently fixed warnings in these other > files as well before enabling -Werror. > > In my proposal to add -Werror, I've ensured that specific runs of > javac to which -Werror will be added actually have no warnings at all, > whether in implicitly or explicitly listed files. > > I'm also not entirely clear what's meant by "partial" and > "incremental" builds. I've been doing clean builds, but only in the > jdk repo. Is this a "partial" build, as opposed to a full forest or > "control" build? I'm doing one of those now and I'll certainly correct > any issues that arise because of -Werror. > > Or, is a "partial" build what happens if one descends into a make > subdirectory, e.g. jdk/make/java/net, and calls "make" from there? I > haven't been doing that. Should I? > > Still trying to figure out what I need to do to move this forward. Just on terminology, when I use the term "partial" build then I meant building a subset of the repositories with an import JDK providing the per-built bits from the other repositories. I think this is what most folks working in the jdk repository do, at least in Oracle. Incremental builds are where folks go into specific directories and run the make file so that it re-builds just the changed sources for that area. It's far from perfect, requires local knowledge, at least one amulet, but critical to productivity when working in the jdk repository. Anyway, I think you've been digging in the right place. Warnings were fixed and builds completed successfully but then later we found cases where areas hadn't been completely cleared of mines. This is not a criticism of Sasha's great work, it's just that they slipped through because classes were compiled implicitly by something earlier in the build. This is just one reason to look forward to the new build. As to moving this forward. If you are happy that these areas are completely warning free then I think we are happy and you should push the changes. -Alan. From joe.darcy at oracle.com Thu Dec 22 12:46:49 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 22 Dec 2011 12:46:49 -0800 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EF319E6.2040806@oracle.com> References: <4EEAB41C.5000300@oracle.com> <4EEB160B.2060909@oracle.com> <4EEB1FD6.60707@oracle.com> <4EF14464.5000103@oracle.com> <4EF28D2E.3010504@oracle.com> <4EF319E6.2040806@oracle.com> Message-ID: <4EF39739.1080502@oracle.com> On 12/22/2011 3:52 AM, Alan Bateman wrote: > On 22/12/2011 01:51, Stuart Marks wrote: >> >> I dug up a bit of background on this. Apparently Sasha ran across >> this problem back in July and asked about this on net-dev [1]. >> Discussion continued on build-dev [2]. Kurchi later picked up this >> work and after some discussion got it integrated [3]. >> >> I didn't see Sasha's original webrev, but he might have fixed all the >> warnings in the java.net package, enabled -Werror in >> make/java/net/Makefile, and then was surprised to find that this >> build step was (implicitly) compiling files that weren't in the >> java.net package. Kurchi's fix [3] apparently fixed warnings in these >> other files as well before enabling -Werror. >> >> In my proposal to add -Werror, I've ensured that specific runs of >> javac to which -Werror will be added actually have no warnings at >> all, whether in implicitly or explicitly listed files. >> >> I'm also not entirely clear what's meant by "partial" and >> "incremental" builds. I've been doing clean builds, but only in the >> jdk repo. Is this a "partial" build, as opposed to a full forest or >> "control" build? I'm doing one of those now and I'll certainly >> correct any issues that arise because of -Werror. >> >> Or, is a "partial" build what happens if one descends into a make >> subdirectory, e.g. jdk/make/java/net, and calls "make" from there? I >> haven't been doing that. Should I? >> >> Still trying to figure out what I need to do to move this forward. > Just on terminology, when I use the term "partial" build then I meant > building a subset of the repositories with an import JDK providing the > per-built bits from the other repositories. I think this is what most > folks working in the jdk repository do, at least in Oracle. > Incremental builds are where folks go into specific directories and > run the make file so that it re-builds just the changed sources for > that area. It's far from perfect, requires local knowledge, at least > one amulet, but critical to productivity when working in the jdk > repository. > > Anyway, I think you've been digging in the right place. Warnings were > fixed and builds completed successfully but then later we found cases > where areas hadn't been completely cleared of mines. This is not a > criticism of Sasha's great work, it's just that they slipped through > because classes were compiled implicitly by something earlier in the > build. This is just one reason to look forward to the new build. > > As to moving this forward. If you are happy that these areas are > completely warning free then I think we are happy and you should push > the changes. > As an aside, I've thought it was a bit of design error that implicit compilation was the default. Since JDK 6 there has been a javac option that can be used to disable implicit compilation, -implicit:none. Perhaps this option could be used in some portion of the JDK build. -Joe From kelly.ohair at oracle.com Thu Dec 22 13:51:38 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 22 Dec 2011 13:51:38 -0800 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EF39739.1080502@oracle.com> References: <4EEAB41C.5000300@oracle.com> <4EEB160B.2060909@oracle.com> <4EEB1FD6.60707@oracle.com> <4EF14464.5000103@oracle.com> <4EF28D2E.3010504@oracle.com> <4EF319E6.2040806@oracle.com> <4EF39739.1080502@oracle.com> Message-ID: On Dec 22, 2011, at 12:46 PM, Joe Darcy wrote: > As an aside, I've thought it was a bit of design error that implicit compilation was the default. Me too. > > Since JDK 6 there has been a javac option that can be used to disable implicit compilation, -implicit:none. > > Perhaps this option could be used in some portion of the JDK build. The build infrastructure work will be using that. No more implicit compilations. In the existing Makefiles, adding in -implicit:none might break some of them, the Makefiles have relied on this implicit compilation for a while now. -kto > > -Joe -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/build-dev/attachments/20111222/c306b370/attachment.html From stuart.marks at oracle.com Thu Dec 22 18:53:31 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 22 Dec 2011 18:53:31 -0800 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: <4EF319E6.2040806@oracle.com> References: <4EEAB41C.5000300@oracle.com> <4EEB160B.2060909@oracle.com> <4EEB1FD6.60707@oracle.com> <4EF14464.5000103@oracle.com> <4EF28D2E.3010504@oracle.com> <4EF319E6.2040806@oracle.com> Message-ID: <4EF3ED2B.8010102@oracle.com> On 12/22/11 3:52 AM, Alan Bateman wrote: > Just on terminology, when I use the term "partial" build then I meant building > a subset of the repositories with an import JDK providing the per-built bits > from the other repositories. I think this is what most folks working in the jdk > repository do, at least in Oracle. Incremental builds are where folks go into > specific directories and run the make file so that it re-builds just the > changed sources for that area. It's far from perfect, requires local knowledge, > at least one amulet, but critical to productivity when working in the jdk > repository. Aha! I don't have such an amulet. I'll keep my eyes open for one. I clearly need one, having failed my saving roll against GNUmake. :-) Thanks for the terminology clarification. I tend to do partial builds of just the jdk repo, even for small changes. I haven't done incremental builds, and I can see how it would require a lot of local knowledge to deal with. I can also see how an incremental build could cause warnings to be turned into errors unexpectedly. Suppose there are build steps that build packages A and B, where B depends on A, and where A has lint warnings, and B is warning-free and has -Werror. A jdk build called from jdk/make will build A, then B, and will work. But if a developer were to change something in A and then do an incremental build within B, stuff in A might get implicitly compiled, resulting in a warning in A breaking the build from within B. Well, if doing incremental builds like this requires a lot of local knowledge, then perhaps "make JAVAC_WARNINGS_FATAL=" should be an acceptable workaround. > Anyway, I think you've been digging in the right place. Warnings were fixed and > builds completed successfully but then later we found cases where areas hadn't > been completely cleared of mines. This is not a criticism of Sasha's great > work, it's just that they slipped through because classes were compiled > implicitly by something earlier in the build. This is just one reason to look > forward to the new build. > > As to moving this forward. If you are happy that these areas are completely > warning free then I think we are happy and you should push the changes. OK, thanks. I need to revise the webrev anyway, since I've discovered some new warnings in the closed repos, and also I missed a couple warnings where there was only a single warning in the build step. [I had searched for "warnings" in the build log, but if there's one warning, javac says "1 warning". :-( ] Since everybody is probably taking off for the long weekend, I'll pick this up again next week. s'marks From stuart.marks at oracle.com Thu Dec 22 18:57:15 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 22 Dec 2011 18:57:15 -0800 Subject: please review 7122061: enable -Werror in various jdk build steps In-Reply-To: References: <4EEAB41C.5000300@oracle.com> <4EEB160B.2060909@oracle.com> <4EEB1FD6.60707@oracle.com> <4EF14464.5000103@oracle.com> <4EF28D2E.3010504@oracle.com> <4EF319E6.2040806@oracle.com> <4EF39739.1080502@oracle.com> Message-ID: <4EF3EE0B.1080002@oracle.com> On 12/22/11 1:51 PM, Kelly O'Hair wrote: > On Dec 22, 2011, at 12:46 PM, Joe Darcy wrote: >> As an aside, I've thought it was a bit of design error that implicit >> compilation was the default. > > Me too. > >> Since JDK 6 there has been a javac option that can be used to disable >> implicit compilation, -implicit:none. >> >> Perhaps this option could be used in some portion of the JDK build. > > The build infrastructure work will be using that. No more implicit compilations. > > In the existing Makefiles, adding in -implicit:none might break some of them, > the Makefiles have relied on this > implicit compilation for a while now. Yeah I've always been surprised by implicit compilation. Unfortunately -implicit:none doesn't really help the warnings case. All it does is control whether .class files are generated. Even if -implicit:none is given, javac will still parse, syntax-check, and issue warnings for implicitly depended-upon files, possibly stopping the build if -Werror is present. s'marks From sebastian.sickelmann at gmx.de Sun Dec 25 14:54:43 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Sun, 25 Dec 2011 23:54:43 +0100 Subject: ALLOW_DOWNLOADS Message-ID: <4EF7A9B3.9090702@gmx.de> Hi, i try to build a fresh (make clean'ed) openjdk8 and got problems dowloading http://dlc.sun.com.edgesuite.net/glassfish/components/jax-ws/openjdk/jdk8/jdk8-jaxws2_2_4-b01-2011_07_22.zip . It actually stops downloading at 2,776,678 bytes. Have i had to download it manually? -- Sebastian From sebastian.sickelmann at gmx.de Sun Dec 25 23:03:49 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Mon, 26 Dec 2011 08:03:49 +0100 Subject: ALLOW_DOWNLOADS In-Reply-To: <4EF7A9B3.9090702@gmx.de> References: <4EF7A9B3.9090702@gmx.de> Message-ID: <4EF81C55.3050209@gmx.de> Am 25.12.2011 23:54, schrieb Sebastian Sickelmann: > Hi, > > i try to build a fresh (make clean'ed) openjdk8 and got problems > dowloading > http://dlc.sun.com.edgesuite.net/glassfish/components/jax-ws/openjdk/jdk8/jdk8-jaxws2_2_4-b01-2011_07_22.zip > . > > It actually stops downloading at 2,776,678 bytes. > > Have i had to download it manually? > > -- Sebastian Sorry. Now it works. From stuart.marks at oracle.com Tue Dec 27 17:57:25 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 27 Dec 2011 17:57:25 -0800 Subject: 7122061 review round two: enable -Werror in various jdk build steps Message-ID: <4EFA7785.4020905@oracle.com> Hi all, here's any updated webrev for this fix: http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.1/ Changes from the previous webrev: * I've withdrawn the addition of -Werror from several Makefiles. There are two reasons. First, some of these had a single warning, causing javac to emit the message "1 warning" that was missed by my analysis script which was looking for the string "warnings". Second, some of the steps had zero warnings but the addition of closed sources caused warnings to appear. As a result I won't be adding -Werror to the following: make/com/sun/servicetag/Makefile make/java/zip/Makefile make/javax/management/Makefile make/jpda/bdi/Makefile make/sun/pisces/Makefile make/sun/tracing/Makefile * The webrev shows no apparent changes to make/javax/security/Makefile. Interesting story here. I saw that this build step had no warnings, so I went to add JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL=true to the Makefile, and I was surprised to discover these declarations already present! Well, they were present but with trailing spaces. Turns out that trailing spaces are significant in the way that these make variables are used :-( which caused them not to be honored. (Make strikes again!) Removing the trailing spaces enables the intended behavior. ** With these changes, 52 out of 93 build steps are warnings-free and have -Werror. I do think at some point we should look at having -Werror on by default, as David Holmes suggested [1], but some additional cleanup in this area is necessary and I want to coordinate with the build infrastructure work to see how much effort is appropriate here. Meanwhile I'd prefer to continue in a piecemeal approach. Thanks. s'marks [1] http://mail.openjdk.java.net/pipermail/build-dev/2011-December/005301.html From chris.hegarty at oracle.com Wed Dec 28 00:58:19 2011 From: chris.hegarty at oracle.com (chris hegarty) Date: Wed, 28 Dec 2011 08:58:19 +0000 Subject: 7122061 review round two: enable -Werror in various jdk build steps In-Reply-To: <4EFA7785.4020905@oracle.com> References: <4EFA7785.4020905@oracle.com> Message-ID: <4EFADA2B.10307@oracle.com> Looks fine to me. Let's resync after this push and see if there is some low hanging fruit we can pick, like the areas with 1 warning? -Chris. On 28/12/2011 01:57, Stuart Marks wrote: > Hi all, here's any updated webrev for this fix: > > http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.1/ > > Changes from the previous webrev: > > * I've withdrawn the addition of -Werror from several Makefiles. There > are two reasons. First, some of these had a single warning, causing > javac to emit the message "1 warning" that was missed by my analysis > script which was looking for the string "warnings". Second, some of the > steps had zero warnings but the addition of closed sources caused > warnings to appear. As a result I won't be adding -Werror to the following: > > make/com/sun/servicetag/Makefile > make/java/zip/Makefile > make/javax/management/Makefile > make/jpda/bdi/Makefile > make/sun/pisces/Makefile > make/sun/tracing/Makefile > > * The webrev shows no apparent changes to make/javax/security/Makefile. > Interesting story here. I saw that this build step had no warnings, so I > went to add JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL=true to the > Makefile, and I was surprised to discover these declarations already > present! Well, they were present but with trailing spaces. Turns out > that trailing spaces are significant in the way that these make > variables are used :-( which caused them not to be honored. (Make > strikes again!) Removing the trailing spaces enables the intended behavior. > > ** > > With these changes, 52 out of 93 build steps are warnings-free and have > -Werror. I do think at some point we should look at having -Werror on by > default, as David Holmes suggested [1], but some additional cleanup in > this area is necessary and I want to coordinate with the build > infrastructure work to see how much effort is appropriate here. > Meanwhile I'd prefer to continue in a piecemeal approach. > > Thanks. > > s'marks > > > [1] > http://mail.openjdk.java.net/pipermail/build-dev/2011-December/005301.html From david.katleman at sun.com Wed Dec 28 15:26:57 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 28 Dec 2011 23:26:57 +0000 Subject: hg: jdk8/build: 7 new changesets Message-ID: <20111228232657.7F7C24780D@hg.openjdk.java.net> Changeset: 8606f4ab62dc Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/8606f4ab62dc Added tag jdk8-b17 for changeset 4e06ae613e99 ! .hgtags Changeset: d82d3bb3a2e5 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/d82d3bb3a2e5 Added tag jdk8-b16 for changeset 4e06ae613e99 ! .hgtags Changeset: 7010bd24cdd0 Author: katleman Date: 2011-12-15 15:51 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/7010bd24cdd0 Merge ! .hgtags Changeset: e1fc13802e0c Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/e1fc13802e0c Added tag jdk8-b18 for changeset 7010bd24cdd0 ! .hgtags Changeset: 9acd7374ff8a Author: ohair Date: 2011-12-12 08:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/9acd7374ff8a 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties ! test/Makefile Changeset: 00d13c40d7a7 Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/00d13c40d7a7 Merge Changeset: 237bc29afbfc Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/237bc29afbfc Merge From david.katleman at sun.com Wed Dec 28 15:27:05 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 28 Dec 2011 23:27:05 +0000 Subject: hg: jdk8/build/corba: 8 new changesets Message-ID: <20111228232710.2BD3C4780E@hg.openjdk.java.net> Changeset: 05f47d29b438 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/05f47d29b438 Added tag jdk8-b17 for changeset 82dc033975bb ! .hgtags Changeset: 6e51ad8d3707 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/6e51ad8d3707 Added tag jdk8-b16 for changeset 82dc033975bb ! .hgtags Changeset: 312cf15d1657 Author: katleman Date: 2011-12-15 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/312cf15d1657 Merge ! .hgtags Changeset: 46bd4a46a5a8 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/46bd4a46a5a8 Added tag jdk8-b18 for changeset 312cf15d1657 ! .hgtags Changeset: 75529c21094f Author: ohair Date: 2011-12-12 08:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/75529c21094f 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties Changeset: 0289a94d653b Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/0289a94d653b Merge Changeset: 052dda3b5ce3 Author: dmeetry Date: 2011-12-18 22:12 +0400 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/052dda3b5ce3 7046238: new InitialContext(); hangs Summary: Synchronization on a single monitor for contactInfo parameters with identical hashCode() Reviewed-by: robm, skoppar ! src/share/classes/com/sun/corba/se/impl/protocol/CorbaClientRequestDispatcherImpl.java Changeset: e1366c5d84ef Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/e1366c5d84ef Merge From david.katleman at sun.com Wed Dec 28 15:32:50 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 28 Dec 2011 23:32:50 +0000 Subject: hg: jdk8/build/hotspot: 73 new changesets Message-ID: <20111228233522.71A184780F@hg.openjdk.java.net> Changeset: 698a22e99f74 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/698a22e99f74 Added tag jdk8-b17 for changeset d1f29d4e0bc6 ! .hgtags Changeset: 09f3b8a372b2 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/09f3b8a372b2 Added tag jdk8-b16 for changeset d1f29d4e0bc6 ! .hgtags Changeset: e46c2339d0fc Author: katleman Date: 2011-12-15 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e46c2339d0fc Merge ! .hgtags Changeset: da4182086289 Author: jcoomes Date: 2011-11-18 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/da4182086289 7113503: Bump the hs23 build number to 07 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 36b057451829 Author: dholmes Date: 2011-11-16 20:38 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/36b057451829 7110017: is_headless_jre should be updated to reflect the new location of awt toolkit libraries Reviewed-by: dholmes, dsamersoff Contributed-by: Chris Hegarty ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp Changeset: 002cb3fc8256 Author: coleenp Date: 2011-11-18 17:26 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/002cb3fc8256 Merge Changeset: c17bc65648de Author: brutisso Date: 2011-11-21 08:02 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c17bc65648de 7112308: Fix Visual Studio build for precompiled header Summary: Add the new path to precompiled.hpp in the project make file Reviewed-by: coleenp, dholmes, brutisso Contributed-by: rbackman ! make/windows/makefiles/projectcreator.make Changeset: 1d090cf33da6 Author: coleenp Date: 2011-11-21 10:22 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1d090cf33da6 Merge Changeset: 242b4e0e6f73 Author: phh Date: 2011-11-29 09:21 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/242b4e0e6f73 7116189: Export JVM_SetNativeThreadName from Hotspot Summary: Added JVM_SetNativeThreadName to linker mapfiles on Solaris and Linux. Reviewed-by: dcubed, dholmes Contributed-by: michael.x.mcmahon at oracle.com ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers Changeset: 763f01599ff4 Author: phh Date: 2011-11-29 17:00 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/763f01599ff4 7116481: Commercial features in Hotspot must be gated by a switch Summary: Add -XX:+UnlockCommercialVMOptions to gate use of commercial feature switches in the same way as -XX:UnlockDiagnosticVMOptions gates use of diagnostic feature switches. Reviewed-by: jwilhelm, kamg ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 358eca91be48 Author: phh Date: 2011-11-30 12:48 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/358eca91be48 7116730: Revert 7116481: Commercial features in Hotspot must be gated by a switch Summary: Revert 7116481 to current hsx/hotspot-main Reviewed-by: kamg ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 81a08cd7f6a1 Author: coleenp Date: 2011-12-01 13:42 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/81a08cd7f6a1 Merge Changeset: a88de71c4e3a Author: tonyp Date: 2011-11-18 12:52 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a88de71c4e3a 7097002: G1: remove a lot of unused / redundant code from the G1CollectorPolicy class Summary: Major cleanup of the G1CollectorPolicy class. It removes a lot of unused fields and methods and also consolidates replicated information (mainly various ways of counting the number of CSet regions) into one copy. Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: d06a2d7fcd5b Author: brutisso Date: 2011-11-21 07:47 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d06a2d7fcd5b 7110718: -XX:MarkSweepAlwaysCompactCount=0 crashes the JVM Summary: Interpret MarkSweepAlwaysCompactCount < 1 as never do full compaction Reviewed-by: ysr, tonyp, jmasa, johnc ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/memory/space.hpp Changeset: b5a5f30c483d Author: johnc Date: 2011-11-21 09:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b5a5f30c483d 7110173: GCNotifier::pushNotification publishes stale data. Summary: GCNotifier::pushNotification() references GCMemoryManager::_last_gc_stat but is called from GCMemoryManager::gc_end() before GCMemoryManager::_last_gc_stat is set up using the values in GCMemoryManager::_current_gc_stat. As a result the GC notification code accesses unitialized or stale data. Move the notification call after GCMemoryManager::_las_gc_stat is set, but inside the same if-block. Reviewed-by: poonam, dholmes, fparain, mchung ! src/share/vm/services/memoryManager.cpp Changeset: 6071e0581859 Author: johnc Date: 2011-11-18 12:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6071e0581859 7111795: G1: Various cleanups identified during walk through of changes for 6484965 Summary: Various cleanups and formatting changes identified during a code walk through of the changes for 6484965 ("G1: piggy-back liveness accounting phase on marking"). Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: 3a298e04d914 Author: tonyp Date: 2011-11-22 04:47 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3a298e04d914 Merge Changeset: bca17e38de00 Author: jmasa Date: 2011-08-09 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bca17e38de00 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads Summary: Select number of GC threads dynamically based on heap usage and number of Java threads Reviewed-by: johnc, ysr, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp ! src/share/vm/utilities/yieldingWorkgroup.cpp ! src/share/vm/utilities/yieldingWorkgroup.hpp Changeset: 00dd86e542eb Author: johnc Date: 2011-11-28 09:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/00dd86e542eb 7114303: G1: assert(_g1->mark_in_progress()) failed: shouldn't be here otherwise Summary: Race between the VM thread reading G1CollectedHeap::_mark_in_progress and it being set by the concurrent mark thread when concurrent marking is aborted by a full GC. Have the concurrent mark thread join the SuspendibleThreadSet before changing the marking state. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: dc467e8b2c5e Author: johnc Date: 2011-11-17 12:40 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dc467e8b2c5e 7112743: G1: Reduce overhead of marking closure during evacuation pauses Summary: Parallelize the serial code that was used to mark objects reachable from survivor objects in the collection set. Some minor improvments in the timers used to track the freeing of the collection set along with some tweaks to PrintGCDetails. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/oops/objArrayOop.hpp Changeset: ea640b5e949a Author: jmasa Date: 2011-11-22 14:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ea640b5e949a 7106024: CMS: Removed unused code for precleaning in remark phase Summary: Remove dead code. Reviewed-by: stefank, ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp Changeset: 7913e93dca52 Author: jmasa Date: 2011-11-22 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7913e93dca52 7112997: Remove obsolete code ResetObjectsClosure and VerifyUpdateClosure Summary: Remove obsolete code. Reviewed-by: brutisso, ysr, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp Changeset: 1bbf5b6fb7b0 Author: tonyp Date: 2011-12-02 08:52 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1bbf5b6fb7b0 Merge ! src/share/vm/runtime/globals.hpp Changeset: 6de8c9ba5907 Author: jcoomes Date: 2011-12-02 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6de8c9ba5907 Merge Changeset: aed8bf036ce2 Author: jcoomes Date: 2011-12-02 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/aed8bf036ce2 Added tag hs23-b07 for changeset 6de8c9ba5907 ! .hgtags Changeset: cf4dd13bbcd3 Author: jcoomes Date: 2011-12-02 21:10 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cf4dd13bbcd3 7117536: new hotspot build - hs23-b08 Reviewed-by: johnc ! make/hotspot_version Changeset: cd00eaeebef6 Author: phh Date: 2011-12-05 12:50 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cd00eaeebef6 7117389: Add a framework for vendor-specific command line switch extensions to Hotspot Summary: Add a file, globals_ext.hpp, containing a null interface, to be replaced by a vendor in altsrc as needed. Reviewed-by: coleenp, kamg, dholmes, johnc, jrose ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp + src/share/vm/runtime/globals_ext.hpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 8657ec177a14 Author: dcubed Date: 2011-12-05 14:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8657ec177a14 7117748: SA_APPLE_BOOT_JAVA and ALWAYS_PASS_TEST_GAMMA settings should not be required on MacOS X Summary: Replace SA_APPLE_BOOT_JAVA with logic that checks the boot JDK for the location of JDI classes. ALWAYS_PASS_TEST_GAMMA is true by default on Darwin. Reviewed-by: kvn, swingler ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/sa.make Changeset: 41cce03b29a8 Author: dcubed Date: 2011-12-06 05:28 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/41cce03b29a8 Merge Changeset: 03865c41c4f3 Author: vladidan Date: 2011-12-06 16:35 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/03865c41c4f3 Merge ! src/share/vm/runtime/globals.hpp Changeset: 55d777c0860a Author: dcubed Date: 2011-12-07 07:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/55d777c0860a 7118648: disable compressed oops by default on MacOS X until 7118647 is fixed Summary: UseCompressedOops is false by default on MacOS X; can still be set manually Reviewed-by: jmelvin, kvn, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: e8fdaf4a66cb Author: kvn Date: 2011-11-10 20:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e8fdaf4a66cb 7110586: C2 generates incorrect results Summary: Exact limit of empty loop calculated incorrectly. Reviewed-by: iveresov, never ! src/share/vm/opto/loopnode.cpp + test/compiler/7110586/Test7110586.java Changeset: 8c57262447d3 Author: kvn Date: 2011-11-14 18:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8c57262447d3 7105605: Use EA info to optimize pointers compare Summary: optimize pointers compare using EA information. Reviewed-by: never, twisti ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 6729bbc1fcd6 Author: twisti Date: 2011-11-16 01:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6729bbc1fcd6 7003454: order constants in constant table by number of references in code Reviewed-by: kvn, never, bdelsart ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/matcher.hpp Changeset: 1bd45abaa507 Author: kvn Date: 2011-11-16 09:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1bd45abaa507 6890673: Eliminate allocations immediately after EA Summary: Try to eliminate allocations and related locks immediately after escape analysis. Reviewed-by: never ! src/share/vm/opto/block.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp Changeset: 973293defacd Author: iveresov Date: 2011-11-16 19:42 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/973293defacd 7112085: assert(fr.interpreter_frame_expression_stack_size()==0) failed: only handle empty stacks Summary: Move the inlinee invoke notification callback into inlinee preamble Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp ! test/compiler/6792161/Test6792161.java Changeset: a04a201f0f5a Author: twisti Date: 2011-11-17 04:07 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a04a201f0f5a 7108383: JSR 292: JRuby bench_define_method_methods.rb: assert(slow_jvms != NULL) failed: miss path must not Reviewed-by: kvn, never ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp Changeset: 59bc0d4d9ea3 Author: never Date: 2011-11-18 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/59bc0d4d9ea3 7110489: C1: 64-bit tiered with ForceUnreachable: assert(reachable(src)) failed: Address should be reachable Reviewed-by: kvn, iveresov, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 7793051af7d6 Author: twisti Date: 2011-11-21 00:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7793051af7d6 7110058: change default for ScavengeRootsInCode to 2 Reviewed-by: kvn, never ! src/share/vm/runtime/globals.hpp Changeset: f03a3c8bd5e5 Author: roland Date: 2011-09-14 09:22 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f03a3c8bd5e5 7077312: Provide a CALL effect for instruct declaration in the ad file Summary: abstracted way to declare that the MachNode has the effect of a call (kills caller save registers, preserves callee save registers) Reviewed-by: twisti, never ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/adlparse.hpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/node.hpp Changeset: db2e64ca2d5a Author: roland Date: 2011-11-22 09:45 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/db2e64ca2d5a 7090968: Allow adlc register class to depend on runtime conditions Summary: allow reg_class definition as a function. Reviewed-by: kvn, never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/formsopt.cpp ! src/share/vm/adlc/formsopt.hpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/matcher.hpp Changeset: cc81b9c09bbb Author: kvn Date: 2011-11-28 15:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cc81b9c09bbb 7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE Summary: Fixed several EA issues with Connection Graph construction. Reviewed-by: never, twisti ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 97825a4f7369 Author: iveresov Date: 2011-11-30 17:35 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/97825a4f7369 7116795: Tiered: enable by default for server Summary: Enable tiered compilation on server VM by default Reviewed-by: kvn, never ! make/jprt.properties ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp Changeset: f745b2be3737 Author: kvn Date: 2011-12-02 21:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f745b2be3737 7117282: assert(base == NULL || t_adr->isa_rawptr() || !phase->type(base) Summary: Delay memory node transformation until the memory is processed. Reviewed-by: iveresov, never ! src/share/vm/opto/memnode.cpp Changeset: 81f7362f7bed Author: kvn Date: 2011-12-08 10:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/81f7362f7bed Merge ! make/jprt.properties ! src/share/vm/runtime/globals.hpp Changeset: 4406629aa157 Author: johnc Date: 2011-12-02 12:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4406629aa157 7114095: G1: assert(obj == oopDesc::load_decode_heap_oop(p)) failed: p should still be pointing to obj Summary: As a result of the changes for 4965777, the G1 reference field scanning closure could be applied to the discovered field of a reference object twice. The failing assert is too strong if the result of the first application of the closure is stolen, and the referenced object, evacuated by another worker thread. Reviewed-by: ysr, tonyp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp Changeset: e37aedaedccd Author: tonyp Date: 2011-12-05 12:26 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e37aedaedccd Merge Changeset: f1391adc6681 Author: stefank Date: 2011-11-28 10:19 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f1391adc6681 7112034: Parallel CMS fails to properly mark reference objects Summary: Enabled reference processing when work stealing during concurrent marking Reviewed-by: jmasa, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: f4414323345f Author: stefank Date: 2011-11-28 14:58 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f4414323345f 7116081: USE_PRECOMPILED_HEADER=0 triggers a single threaded build of the JVM Summary: Changed the conditional to see if the precompiled header has been specified. Also, removed the unused PrecompiledOption. Reviewed-by: dholmes, brutisso ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/top.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/gcc.make Changeset: d23d2b18183e Author: tonyp Date: 2011-12-07 12:54 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d23d2b18183e 7118202: G1: eden size unnecessarily drops to a minimum Summary: An integer underflow can cause the RSet lengths to be massively overpredicted which forces the eden size to the minimum. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: e9b91fd07263 Author: jmasa Date: 2011-12-09 06:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e9b91fd07263 Merge Changeset: 6d7d0790074d Author: jmasa Date: 2011-12-09 19:28 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6d7d0790074d 7119584: UseParallelGC barrier task can be overwritten. Summary: Provoke a GC for a metadata allocation failure. Reviewed-by: johnc, iveresov ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp Changeset: 3b688d6ff3d0 Author: fparain Date: 2011-12-14 04:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3b688d6ff3d0 7104647: Adding a diagnostic command framework Reviewed-by: phh, dcubed ! src/share/vm/services/attachListener.cpp + src/share/vm/services/diagnosticArgument.cpp + src/share/vm/services/diagnosticArgument.hpp + src/share/vm/services/diagnosticCommand.cpp + src/share/vm/services/diagnosticCommand.hpp + src/share/vm/services/diagnosticFramework.cpp + src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp Changeset: 31f6f10e4379 Author: vladidan Date: 2011-12-14 20:06 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/31f6f10e4379 Merge Changeset: a2fef924d8e6 Author: amurillo Date: 2011-12-16 12:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a2fef924d8e6 Merge ! .hgtags Changeset: 61165f53f165 Author: amurillo Date: 2011-12-16 12:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/61165f53f165 Added tag hs23-b08 for changeset a2fef924d8e6 ! .hgtags Changeset: 7e075537835d Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7e075537835d Added tag jdk8-b18 for changeset 61165f53f165 ! .hgtags Changeset: 434acc838772 Author: amurillo Date: 2011-12-16 12:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/434acc838772 7122001: new hotspot build - hs23-b09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 3c648b9ad052 Author: stefank Date: 2011-12-14 12:15 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3c648b9ad052 7121373: Clean up CollectedHeap::is_in Summary: Fixed G1CollectedHeap::is_in, added tests, cleaned up comments and made Space::is_in pure virtual. Reviewed-by: brutisso, tonyp, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/oops/arrayOop.cpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/quickSort.hpp Changeset: fd2b426c30db Author: johnc Date: 2011-12-14 17:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fd2b426c30db 7119908: G1: Cache CSet start region for each worker for subsequent reuse Summary: Cache workers' calculated starting heap region, used for parallel iteration over the collcection set, for subsequent reuse. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: 41406797186b Author: tonyp Date: 2011-12-16 02:14 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/41406797186b 7113012: G1: rename not-fully-young GCs as "mixed" Summary: Renamed partially-young GCs as mixed and fully-young GCs as young. Change all external output that includes those terms (GC log and GC ergo log) as well as any comments, fields, methods, etc. The changeset also includes very minor code tidying up (added some curly brackets). Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.cpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp Changeset: adedfbbf0360 Author: johnc Date: 2011-12-16 11:40 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/adedfbbf0360 7120038: G1: ParallelGCThreads==0 is broken Summary: Running G1 with ParallelGCThreads==0 results in various crashes and asserts. Most of these are caused by unguarded references to the worker threads array or an incorrect number of active workers. Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: e7dead7e90af Author: johnc Date: 2011-12-19 10:02 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e7dead7e90af 7117303: VM uses non-monotonic time source and complains that it is non-monotonic Summary: Replaces calls to os::javaTimeMillis(), which does not (and cannot) guarantee monotonicity, in GC code to an equivalent expression that uses os::javaTimeNanos(). os::javaTimeNanos is guaranteed monotonically non-decreasing if the underlying platform provides a monotonic time source. Changes in OS files are to make use of the newly defined constants in globalDefinitions.hpp. Reviewed-by: dholmes, ysr ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 129cd462ae89 Author: jmasa Date: 2011-12-20 12:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/129cd462ae89 Merge Changeset: 96ce4c27112f Author: coleenp Date: 2011-12-19 15:34 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/96ce4c27112f 7122939: TraceBytecodes broken with UseCompressedOops Summary: Disable verify_heapbase on sparc if TraceBytecodes because the latter uses r12 as a temp register Reviewed-by: coleenp, phh Contributed-by: Volker Simonis ! src/cpu/x86/vm/assembler_x86.cpp Changeset: 6c995c08526c Author: phh Date: 2011-12-19 15:50 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6c995c08526c 7122880: Extend vendor-specific command interface to include manageable switches Summary: Add Flag::external_ext()/writable_ext(), both return false. Reviewed-by: coleenp, zgu ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_ext.hpp ! src/share/vm/services/management.cpp Changeset: 4502fd5c7698 Author: phh Date: 2011-12-19 21:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4502fd5c7698 Merge Changeset: 11c26bfcf8c7 Author: phh Date: 2011-12-21 15:48 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/11c26bfcf8c7 7091417: recvfrom's 6th input should be of type socklen_t Summary: Revamp class os's socket method formal args to match socket.h, insert casts in appropriate places, and copyin-copyout int*'s that s/b socklen_t*'s in jvm.cpp. Reviewed-by: coleenp, dholmes Contributed-by: erik.gahlin at oracle.com, rickard.backman at oracle.com, nils.loodin at oracle.com, markus.gronlund at oracle.com ! src/os/bsd/vm/jvm_bsd.h ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/jvm_linux.h ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/jvm_solaris.h ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/jvm_windows.h ! src/os/windows/vm/os_windows.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/ostream.cpp Changeset: c01e115b095e Author: coleenp Date: 2011-12-21 16:41 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c01e115b095e 7064927: retransformClasses() does not pass in LocalVariableTable of a method Summary: Handle LVT attribute in the class file reconstitutor. Reviewed-by: phh, coleenp Contributed-by: thomaswue ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: d532160c55f7 Author: coleenp Date: 2011-12-21 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d532160c55f7 Merge Changeset: 4b18532913c7 Author: vladidan Date: 2011-12-22 12:01 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4b18532913c7 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp Changeset: 4bcf61041217 Author: amurillo Date: 2011-12-23 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4bcf61041217 Merge Changeset: 9232e0ecbc2c Author: amurillo Date: 2011-12-23 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9232e0ecbc2c Added tag hs23-b09 for changeset 4bcf61041217 ! .hgtags From david.katleman at sun.com Wed Dec 28 15:36:35 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 28 Dec 2011 23:36:35 +0000 Subject: hg: jdk8/build/jaxp: 8 new changesets Message-ID: <20111228233635.AD1C947810@hg.openjdk.java.net> Changeset: db44484a9d6e Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/db44484a9d6e Added tag jdk8-b17 for changeset 09eb517404b0 ! .hgtags Changeset: bc3ed3122933 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/bc3ed3122933 Added tag jdk8-b16 for changeset 09eb517404b0 ! .hgtags Changeset: ebec6a7e8d4e Author: katleman Date: 2011-12-15 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/ebec6a7e8d4e Merge ! .hgtags Changeset: 5fb25931f1c2 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/5fb25931f1c2 Added tag jdk8-b18 for changeset ebec6a7e8d4e ! .hgtags Changeset: a482d45c93e9 Author: ohair Date: 2011-12-12 08:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/a482d45c93e9 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac Reviewed-by: alanb ! build.xml Changeset: a49db7c01db7 Author: ohair Date: 2011-12-12 08:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/a49db7c01db7 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties Changeset: f26e2ab2c2c7 Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/f26e2ab2c2c7 Merge Changeset: dffeb62b1a7f Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/dffeb62b1a7f Merge From david.katleman at sun.com Wed Dec 28 15:36:42 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 28 Dec 2011 23:36:42 +0000 Subject: hg: jdk8/build/jaxws: 8 new changesets Message-ID: <20111228233642.F2D2547811@hg.openjdk.java.net> Changeset: b38846b9974c Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b38846b9974c Added tag jdk8-b17 for changeset 3d45ab79643d ! .hgtags Changeset: e662b652098c Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/e662b652098c Added tag jdk8-b16 for changeset 3d45ab79643d ! .hgtags Changeset: 54928c8850f5 Author: katleman Date: 2011-12-15 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/54928c8850f5 Merge ! .hgtags Changeset: 72d410c3bab1 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/72d410c3bab1 Added tag jdk8-b18 for changeset 54928c8850f5 ! .hgtags Changeset: 6d622b1b4db0 Author: ohair Date: 2011-12-12 08:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/6d622b1b4db0 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac Reviewed-by: alanb ! build.xml Changeset: 6d2030eacdac Author: ohair Date: 2011-12-12 08:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/6d2030eacdac 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties Changeset: b2e4ab8b5fa3 Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b2e4ab8b5fa3 Merge Changeset: b73b733214aa Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b73b733214aa Merge From david.katleman at sun.com Wed Dec 28 15:38:21 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 28 Dec 2011 23:38:21 +0000 Subject: hg: jdk8/build/jdk: 36 new changesets Message-ID: <20111228234421.0634247812@hg.openjdk.java.net> Changeset: cd95291bbbf3 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cd95291bbbf3 Added tag jdk8-b17 for changeset b71d1acfae52 ! .hgtags Changeset: 8f3d916a9164 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8f3d916a9164 Added tag jdk8-b16 for changeset 929597c6e777 ! .hgtags Changeset: e55ac966ed95 Author: katleman Date: 2011-12-15 15:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e55ac966ed95 Merge ! .hgtags - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: 134420afe9c2 Author: ngthomas Date: 2011-11-13 21:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/134420afe9c2 7109885: security baseline for 7u2 or above is not set correctly Reviewed-by: ccheung, igor, ohair ! make/common/shared/Sanity.gmk Changeset: 6f594239e9dc Author: ngthomas Date: 2011-11-15 23:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6f594239e9dc 7112298: remove security baseline sanity check Reviewed-by: ccheung, igor, ohair ! make/common/shared/Sanity.gmk Changeset: fcc7cafa0027 Author: herrick Date: 2011-11-18 06:35 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fcc7cafa0027 Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: 526e99f06a59 Author: igor Date: 2011-12-06 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/526e99f06a59 Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 334bd51fb3f3 Author: igor Date: 2011-12-19 10:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/334bd51fb3f3 Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: c6fab5332075 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c6fab5332075 Added tag jdk8-b18 for changeset 334bd51fb3f3 ! .hgtags Changeset: 7dbc53242c2a Author: art Date: 2011-12-07 17:45 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7dbc53242c2a 7117008: Warnings cleanup day: reduce number of javac warnings in the sun.awt package Reviewed-by: anthony, denis, bagiras ! src/share/classes/sun/awt/AWTAutoShutdown.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/CausedFocusEvent.java ! src/share/classes/sun/awt/DebugSettings.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/share/classes/sun/awt/EventListenerAggregate.java - src/share/classes/sun/awt/FocusingTextField.java ! src/share/classes/sun/awt/HeadlessToolkit.java - src/share/classes/sun/awt/HorizBagLayout.java ! src/share/classes/sun/awt/KeyboardFocusManagerPeerImpl.java ! src/share/classes/sun/awt/ModalityEvent.java - src/share/classes/sun/awt/OrientableFlowLayout.java ! src/share/classes/sun/awt/PaintEventDispatcher.java ! src/share/classes/sun/awt/PeerEvent.java ! src/share/classes/sun/awt/SunDisplayChanger.java ! src/share/classes/sun/awt/SunGraphicsCallback.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/awt/UngrabEvent.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java Changeset: 18925904efc2 Author: alexsch Date: 2011-12-12 15:33 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/18925904efc2 7105890: closed/javax/swing/JScrollBar/4708809/bug4708809.java deadlocks on MacOS Reviewed-by: alexp + test/javax/swing/JScrollBar/4708809/bug4708809.java Changeset: 44b26d6a55a6 Author: alexsch Date: 2011-12-13 15:32 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/44b26d6a55a6 7112931: closed/javax/swing/JTabbedPane/6416920/bug6416920.java fails on MacOS Reviewed-by: alexp + test/javax/swing/JTabbedPane/6416920/bug6416920.java Changeset: 70233f5e909c Author: alexsch Date: 2011-12-13 17:30 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/70233f5e909c 7120869: javax/swing/JScrollBar/4708809/bug4708809.java fails on Windows Summary: The robot auto-delay is increased to fix the test failing on Windows. Reviewed-by: alexp ! test/javax/swing/JScrollBar/4708809/bug4708809.java Changeset: 032a91abc540 Author: alexsch Date: 2011-12-13 18:38 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/032a91abc540 7116950: Reduce number of warnings in swing Reviewed-by: art ! src/share/classes/com/sun/java/swing/Painter.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/ActionMap.java ! src/share/classes/javax/swing/ActionPropertyChangeListener.java ! src/share/classes/javax/swing/AncestorNotifier.java ! src/share/classes/javax/swing/ArrayTable.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/ButtonGroup.java ! src/share/classes/javax/swing/ComponentInputMap.java ! src/share/classes/javax/swing/InputMap.java ! src/share/classes/javax/swing/JButton.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JSeparator.java ! src/share/classes/javax/swing/JToolTip.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/MenuSelectionManager.java ! src/share/classes/javax/swing/Popup.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/border/AbstractBorder.java ! src/share/classes/javax/swing/border/CompoundBorder.java ! src/share/classes/javax/swing/border/EmptyBorder.java ! src/share/classes/javax/swing/border/MatteBorder.java ! src/share/classes/javax/swing/border/TitledBorder.java ! src/share/classes/javax/swing/event/AncestorEvent.java ! src/share/classes/javax/swing/event/ChangeEvent.java ! src/share/classes/javax/swing/event/EventListenerList.java ! src/share/classes/javax/swing/event/ListDataEvent.java ! src/share/classes/javax/swing/event/MenuDragMouseEvent.java ! src/share/classes/javax/swing/event/MenuEvent.java ! src/share/classes/javax/swing/event/MenuKeyEvent.java ! src/share/classes/javax/swing/event/PopupMenuEvent.java ! src/share/classes/javax/swing/plaf/ComponentUI.java ! src/share/classes/javax/swing/text/BadLocationException.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java Changeset: 282b2ce90afe Author: lana Date: 2011-12-16 12:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/282b2ce90afe Merge ! src/share/classes/java/beans/PropertyDescriptor.java - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: 75bd7295c706 Author: bagiras Date: 2011-12-19 15:21 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/75bd7295c706 7117334: Warnings cleanup day: reduce number of javac warnings in the java.awt package Reviewed-by: art, denis, alexsch ! src/share/classes/java/awt/AWTEvent.java ! src/share/classes/java/awt/AWTEventMulticaster.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/image/ColorModel.java Changeset: d15f38f08ce9 Author: denis Date: 2011-12-19 16:44 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d15f38f08ce9 7117011: Reduce number of warnings in sun/awt/windows and sun/awt/datatransfer Reviewed-by: art ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XClipboard.java ! src/windows/classes/sun/awt/windows/TranslucentWindowPainter.java ! src/windows/classes/sun/awt/windows/WBufferStrategy.java ! src/windows/classes/sun/awt/windows/WChoicePeer.java ! src/windows/classes/sun/awt/windows/WClipboard.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WDataTransferer.java ! src/windows/classes/sun/awt/windows/WDesktopProperties.java ! src/windows/classes/sun/awt/windows/WDialogPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java ! src/windows/classes/sun/awt/windows/WInputMethod.java ! src/windows/classes/sun/awt/windows/WMenuItemPeer.java ! src/windows/classes/sun/awt/windows/WPageDialog.java ! src/windows/classes/sun/awt/windows/WPageDialogPeer.java ! src/windows/classes/sun/awt/windows/WPrintDialog.java ! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: cded2429cdbf Author: anthony Date: 2011-12-20 12:48 +0300 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cded2429cdbf 7122796: SunToolkit constructor should create the EventQueue for the Main AppContext Summary: Always create an EQ for the main AppContext in SunToolkit constructor Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/SunToolkit.java + test/java/awt/EventQueue/MainAppContext/MainAppContext.java Changeset: 94d7051cca13 Author: lana Date: 2011-12-20 15:26 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/94d7051cca13 Merge - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java Changeset: 4f0f9f9c4892 Author: smarks Date: 2011-12-07 12:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4f0f9f9c4892 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip Reviewed-by: alanb, dholmes, forax, sherman, smarks Contributed-by: Prasannaa , Martijn Verburg , Goerge_Albrecht , Graham Allan , Michael Barker ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/jar/Manifest.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/prefs/Preferences.java ! src/share/classes/java/util/prefs/XmlSupport.java ! src/share/classes/java/util/zip/ZipEntry.java Changeset: f8897baf40ea Author: omajid Date: 2011-12-08 13:48 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f8897baf40ea 7117612: Miscellaneous warnings in java.lang Reviewed-by: smarks, dholmes, alanb, darcy ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/CharacterName.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/ConditionalSpecialCasing.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/EnumConstantNotPresentException.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ThreadLocal.java ! src/share/classes/java/lang/Void.java ! src/solaris/classes/java/lang/ProcessEnvironment.java ! src/windows/classes/java/lang/ProcessEnvironment.java Changeset: 9bb7c3b97384 Author: smarks Date: 2011-12-08 14:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9bb7c3b97384 7118546: fix warnings in javax.xml.crypto, javax.script Reviewed-by: mullan ! src/share/classes/javax/script/ScriptException.java ! src/share/classes/javax/xml/crypto/NodeSetData.java ! src/share/classes/javax/xml/crypto/dom/DOMCryptoContext.java ! src/share/classes/javax/xml/crypto/dsig/Manifest.java ! src/share/classes/javax/xml/crypto/dsig/Reference.java ! src/share/classes/javax/xml/crypto/dsig/SignatureProperties.java ! src/share/classes/javax/xml/crypto/dsig/SignatureProperty.java ! src/share/classes/javax/xml/crypto/dsig/SignedInfo.java ! src/share/classes/javax/xml/crypto/dsig/TransformService.java ! src/share/classes/javax/xml/crypto/dsig/XMLObject.java ! src/share/classes/javax/xml/crypto/dsig/XMLSignature.java ! src/share/classes/javax/xml/crypto/dsig/XMLSignatureFactory.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/KeyInfo.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/KeyInfoFactory.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/PGPData.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/RetrievalMethod.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/X509Data.java ! src/share/classes/javax/xml/crypto/dsig/spec/ExcC14NParameterSpec.java ! src/share/classes/javax/xml/crypto/dsig/spec/XPathFilter2ParameterSpec.java ! src/share/classes/javax/xml/crypto/dsig/spec/XPathFilterParameterSpec.java ! src/share/classes/javax/xml/crypto/dsig/spec/XPathType.java Changeset: 77d41c0e4ffc Author: jjh Date: 2011-12-09 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/77d41c0e4ffc 7117053: Fix build warnings in com/sun/tools/jdi/* Summary: Warnings fixed. Also reviewed by serguei.spitsyn at oracle.com, who is not yet an openjdk reviewer Reviewed-by: ksrini ! make/tools/src/build/tools/jdwpgen/ArrayRegionTypeNode.java ! make/tools/src/build/tools/jdwpgen/OutNode.java ! src/share/classes/com/sun/jdi/AbsentInformationException.java ! src/share/classes/com/sun/jdi/ClassNotLoadedException.java ! src/share/classes/com/sun/jdi/ClassNotPreparedException.java ! src/share/classes/com/sun/jdi/IncompatibleThreadStateException.java ! src/share/classes/com/sun/jdi/InconsistentDebugInfoException.java ! src/share/classes/com/sun/jdi/InternalException.java ! src/share/classes/com/sun/jdi/InvalidCodeIndexException.java ! src/share/classes/com/sun/jdi/InvalidLineNumberException.java ! src/share/classes/com/sun/jdi/InvalidStackFrameException.java ! src/share/classes/com/sun/jdi/InvalidTypeException.java ! src/share/classes/com/sun/jdi/InvocationException.java ! src/share/classes/com/sun/jdi/JDIPermission.java ! src/share/classes/com/sun/jdi/NativeMethodException.java ! src/share/classes/com/sun/jdi/ObjectCollectedException.java ! src/share/classes/com/sun/jdi/VMCannotBeModifiedException.java ! src/share/classes/com/sun/jdi/VMDisconnectedException.java ! src/share/classes/com/sun/jdi/VMMismatchException.java ! src/share/classes/com/sun/jdi/VMOutOfMemoryException.java ! src/share/classes/com/sun/jdi/connect/IllegalConnectorArgumentsException.java ! src/share/classes/com/sun/jdi/connect/TransportTimeoutException.java ! src/share/classes/com/sun/jdi/connect/VMStartException.java ! src/share/classes/com/sun/jdi/connect/spi/ClosedConnectionException.java ! src/share/classes/com/sun/jdi/request/DuplicateRequestException.java ! src/share/classes/com/sun/jdi/request/InvalidRequestStateException.java ! src/share/classes/com/sun/tools/jdi/ArrayReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ArrayTypeImpl.java ! src/share/classes/com/sun/tools/jdi/BooleanValueImpl.java ! src/share/classes/com/sun/tools/jdi/CharValueImpl.java ! src/share/classes/com/sun/tools/jdi/ClassLoaderReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ClassTypeImpl.java ! src/share/classes/com/sun/tools/jdi/ConcreteMethodImpl.java ! src/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/share/classes/com/sun/tools/jdi/DoubleValueImpl.java ! src/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java ! src/share/classes/com/sun/tools/jdi/EventSetImpl.java ! src/share/classes/com/sun/tools/jdi/FloatValueImpl.java ! src/share/classes/com/sun/tools/jdi/GenericAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/IntegerValueImpl.java ! src/share/classes/com/sun/tools/jdi/InterfaceTypeImpl.java ! src/share/classes/com/sun/tools/jdi/InternalEventHandler.java ! src/share/classes/com/sun/tools/jdi/JDWPException.java - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java ! src/share/classes/com/sun/tools/jdi/LongValueImpl.java ! src/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/share/classes/com/sun/tools/jdi/MirrorImpl.java ! src/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ProcessAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/RawCommandLineLauncher.java ! src/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/share/classes/com/sun/tools/jdi/ShortValueImpl.java ! src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java ! src/share/classes/com/sun/tools/jdi/TargetVM.java ! src/share/classes/com/sun/tools/jdi/ThreadAction.java ! src/share/classes/com/sun/tools/jdi/ThreadGroupReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/VMAction.java ! src/share/classes/com/sun/tools/jdi/VMState.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java Changeset: c508f38245f8 Author: ngmr Date: 2011-12-12 11:41 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c508f38245f8 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH Reviewed-by: alanb, chegar Contributed-by: Charles Lee ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: 3216717f96f5 Author: dl Date: 2011-12-12 10:45 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3216717f96f5 7118066: Warnings in java.util.concurrent package Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/DelayQueue.java ! src/share/classes/java/util/concurrent/Exchanger.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! test/java/util/Collections/EmptyIterator.java Changeset: d4f9d7e86a92 Author: chegar Date: 2011-12-12 03:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d4f9d7e86a92 Merge Changeset: 9c0a6185188f Author: ohair Date: 2011-12-12 08:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9c0a6185188f 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties ! test/Makefile Changeset: c647ebb3c4f7 Author: naoto Date: 2011-12-13 15:41 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c647ebb3c4f7 4808233: "Locale" not thread-safe Reviewed-by: okutsu ! src/share/classes/java/util/Locale.java Changeset: e446c7d24d6c Author: lana Date: 2011-12-15 19:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e446c7d24d6c Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h Changeset: 33ac7a057b9c Author: chegar Date: 2011-12-16 16:09 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/33ac7a057b9c 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies Reviewed-by: michaelm ! src/share/classes/java/net/HttpCookie.java + src/share/classes/sun/misc/JavaNetHttpCookieAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/HttpOnly.java Changeset: abbca81a98a7 Author: smarks Date: 2011-12-17 08:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/abbca81a98a7 7122235: stop the build if javac fails Reviewed-by: chegar, dholmes, mcimadamore, ohair ! make/common/Rules.gmk Changeset: 528eb0d43e3a Author: alanb Date: 2011-12-17 20:07 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/528eb0d43e3a 7087549: (fs) Files.newInputStream throws UOE for custom provider options Reviewed-by: alanb Contributed-by: brandon.passanisi at oracle.com ! src/share/classes/java/nio/file/spi/FileSystemProvider.java + test/java/nio/file/Files/CustomOptions.java Changeset: 5b27b978ed42 Author: sherman Date: 2011-12-19 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5b27b978ed42 6990617: Regular expression doesn't match if unicode character next to a digit. Summary: updated RemoveQEQuotation() to deal with this case correctly Reviewed-by: sherman Contributed-by: stephen.flores at oracle.com ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 570f3d893596 Author: lana Date: 2011-12-20 15:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/570f3d893596 Merge - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java Changeset: 6f19ff39cff4 Author: lana Date: 2011-12-23 16:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6f19ff39cff4 Merge - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java Changeset: 3778f8577305 Author: katleman Date: 2011-12-28 15:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3778f8577305 Merge From david.katleman at sun.com Wed Dec 28 15:47:41 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 28 Dec 2011 23:47:41 +0000 Subject: hg: jdk8/build/langtools: 15 new changesets Message-ID: <20111228234813.9E74047813@hg.openjdk.java.net> Changeset: 55a49c399603 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/55a49c399603 Added tag jdk8-b17 for changeset 1cbe86c11ba6 ! .hgtags Changeset: 29a512337b79 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/29a512337b79 Added tag jdk8-b16 for changeset ec2c0973cc31 ! .hgtags Changeset: ab1b1cc78577 Author: katleman Date: 2011-12-15 15:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ab1b1cc78577 Merge ! .hgtags - test/tools/javac/parser/netbeans/JavacParserTest.java Changeset: 3c71fcc22b99 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3c71fcc22b99 Added tag jdk8-b18 for changeset ab1b1cc78577 ! .hgtags Changeset: 4822dfe0922b Author: ohair Date: 2011-12-12 08:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/4822dfe0922b 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties Changeset: 3809292620c9 Author: jjg Date: 2011-12-13 11:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3809292620c9 7120736: refactor javac option handling Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/file/Locations.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! test/tools/javac/diags/examples/UnsupportedEncoding.java Changeset: 4e4fed1d02f9 Author: jjg Date: 2011-12-13 14:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/4e4fed1d02f9 7121164: renamed files not committed Reviewed-by: ksrini - src/share/classes/com/sun/tools/javac/main/JavacOption.java + src/share/classes/com/sun/tools/javac/main/Option.java + src/share/classes/com/sun/tools/javac/main/OptionHelper.java - src/share/classes/com/sun/tools/javac/main/OptionName.java - src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java Changeset: 4261dc8af622 Author: jjg Date: 2011-12-14 16:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/4261dc8af622 7111022: javac no long prints last round of processing 7121323: Sqe tests using -Xstdout option fail with an invalid flag error message Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/4846262/Test.sh + test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java ! test/tools/javac/util/T6597678.java Changeset: 281eeedf9755 Author: jjg Date: 2011-12-14 17:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/281eeedf9755 7121681: compiler message file broken for javac -fullversion Reviewed-by: jjh ! src/share/classes/com/sun/tools/javac/main/Option.java Changeset: 42ffceeceeca Author: jjg Date: 2011-12-14 21:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/42ffceeceeca 7121682: remove obsolete import Reviewed-by: jjh ! test/tools/javac/api/T6838467.java Changeset: ab2a880cc23b Author: lana Date: 2011-12-15 19:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ab2a880cc23b Merge Changeset: 6b773fdeb633 Author: jjg Date: 2011-12-16 13:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/6b773fdeb633 7121961: javadoc is missing a resource property Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties Changeset: a7a2720c7897 Author: jjh Date: 2011-12-16 16:41 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a7a2720c7897 7122342: testPrintProcessorInfo/TestWithXstdout.java failed for JDK8 nightly build at 12/16/2011 Summary: Do not pass empty args to javac Reviewed-by: jjg ! test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java Changeset: 1ae5988e201b Author: mcimadamore Date: 2011-12-19 12:07 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/1ae5988e201b 7120463: Fix method reference parser support in order to avoid ambiguities Summary: Add lookahead routine to disambiguate between method reference in method context and binary expression Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/tools/javac/lambda/MethodReferenceParserTest.java Changeset: 77b2c066084c Author: lana Date: 2011-12-23 16:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/77b2c066084c Merge - src/share/classes/com/sun/tools/javac/main/JavacOption.java - src/share/classes/com/sun/tools/javac/main/OptionName.java - src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java From michael.j.silverstri at gmail.com Thu Dec 29 10:05:38 2011 From: michael.j.silverstri at gmail.com (m silverstri) Date: Thu, 29 Dec 2011 10:05:38 -0800 Subject: Need help in building openjdk on ubuntu 11.10 Message-ID: Hi, I am trying to build openjd on 11.10, but it said 'op is not supported'. Any idea how to fix it? Thank you. mkdir -p /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir cd /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir; \ make -f /home/michael/src/jdk7/hotspot/make/linux/Makefile \ LP64=1 JAVA_HOME=/home/michael/Programs/jdk1.6.0_30 OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir GAMMADIR=/home/michael/src/jdk7/hotspot MAKE_VERBOSE=y HOTSPOT_RELEASE_VERSION=21.0-b17 JRE_RELEASE_VERSION=1.7.0-internal-michael_2011_12_29_09_49-b00 HOTSPOT_BUILD_VERSION= product make[4]: Entering directory `/home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir' make -f /home/michael/src/jdk7/hotspot/make/linux/Makefile checks make[5]: Entering directory `/home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir' >&2 echo "*** This OS is not supported:" `uname -a`; exit 1; *** This OS is not supported: Linux test 3.0.0-14-generic #23-Ubuntu SMP Mon Nov 21 20:28:43 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux make[5]: *** [check_os_version] Error 1 make[5]: Leaving directory `/home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir' make[4]: *** [linux_amd64_compiler2/debug] Error 2 From kelly.ohair at oracle.com Thu Dec 29 13:09:42 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 29 Dec 2011 13:09:42 -0800 Subject: Need help in building openjdk on ubuntu 11.10 In-Reply-To: References: Message-ID: The makefiles are not prepared for building on Linux 3.0 kernels yet. Try applying this patch: diff --git a/make/linux/Makefile b/make/linux/Makefile --- a/make/linux/Makefile +++ b/make/linux/Makefile @@ -230,7 +230,7 @@ # Solaris 2.5.1, 2.6). # Disable this check by setting DISABLE_HOTSPOT_OS_VERSION_CHECK=ok. -SUPPORTED_OS_VERSION = 2.4% 2.5% 2.6% 2.7% +SUPPORTED_OS_VERSION = 2.4% 2.5% 2.6% 2.7% 3.0% OS_VERSION := $(shell uname -r) EMPTY_IF_NOT_SUPPORTED = $(filter $(SUPPORTED_OS_VERSION),$(OS_VERSION)) However, I can't be sure that is the only change needed. -kto On Dec 29, 2011, at 10:05 AM, m silverstri wrote: > Hi, > > I am trying to build openjd on 11.10, but it said 'op is not > supported'. Any idea how to fix it? > > Thank you. > > > mkdir -p /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir > cd /home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir; \ > make -f /home/michael/src/jdk7/hotspot/make/linux/Makefile \ > LP64=1 JAVA_HOME=/home/michael/Programs/jdk1.6.0_30 > OUTPUTDIR=/home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir > GAMMADIR=/home/michael/src/jdk7/hotspot MAKE_VERBOSE=y > HOTSPOT_RELEASE_VERSION=21.0-b17 > JRE_RELEASE_VERSION=1.7.0-internal-michael_2011_12_29_09_49-b00 > HOTSPOT_BUILD_VERSION= product > make[4]: Entering directory > `/home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir' > make -f /home/michael/src/jdk7/hotspot/make/linux/Makefile checks > make[5]: Entering directory > `/home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir' >> &2 echo "*** This OS is not supported:" `uname -a`; exit 1; > *** This OS is not supported: Linux test 3.0.0-14-generic #23-Ubuntu > SMP Mon Nov 21 20:28:43 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux > make[5]: *** [check_os_version] Error 1 > make[5]: Leaving directory > `/home/michael/src/jdk7/build/linux-amd64/hotspot/outputdir' > make[4]: *** [linux_amd64_compiler2/debug] Error 2 From stuart.marks at oracle.com Thu Dec 29 17:04:27 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 29 Dec 2011 17:04:27 -0800 Subject: 7122061 review round two: enable -Werror in various jdk build steps In-Reply-To: <4EFADA2B.10307@oracle.com> References: <4EFA7785.4020905@oracle.com> <4EFADA2B.10307@oracle.com> Message-ID: <4EFD0E1B.1070204@oracle.com> Thanks. I just pushed this changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a7ea63302f8 I'll keep an eye out for any problems that might arise over the long weekend. In any case the workaround would be to set JAVAC_WARNINGS_FATAL=false on the make command line. We'll pick this up again next year. Yes, I'm sure that there are several areas with only one warning that should be pretty easy to pick off. And then there are the larger areas still with hundreds of warnings.... Perhaps those can be the target of a future warnings cleanup event. s'marks On 12/28/11 12:58 AM, chris hegarty wrote: > Looks fine to me. > > Let's resync after this push and see if there is some low hanging fruit we can > pick, like the areas with 1 warning? > > -Chris. > > On 28/12/2011 01:57, Stuart Marks wrote: >> Hi all, here's any updated webrev for this fix: >> >> http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.1/ >> >> Changes from the previous webrev: >> >> * I've withdrawn the addition of -Werror from several Makefiles. There >> are two reasons. First, some of these had a single warning, causing >> javac to emit the message "1 warning" that was missed by my analysis >> script which was looking for the string "warnings". Second, some of the >> steps had zero warnings but the addition of closed sources caused >> warnings to appear. As a result I won't be adding -Werror to the following: >> >> make/com/sun/servicetag/Makefile >> make/java/zip/Makefile >> make/javax/management/Makefile >> make/jpda/bdi/Makefile >> make/sun/pisces/Makefile >> make/sun/tracing/Makefile >> >> * The webrev shows no apparent changes to make/javax/security/Makefile. >> Interesting story here. I saw that this build step had no warnings, so I >> went to add JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL=true to the >> Makefile, and I was surprised to discover these declarations already >> present! Well, they were present but with trailing spaces. Turns out >> that trailing spaces are significant in the way that these make >> variables are used :-( which caused them not to be honored. (Make >> strikes again!) Removing the trailing spaces enables the intended behavior. >> >> ** >> >> With these changes, 52 out of 93 build steps are warnings-free and have >> -Werror. I do think at some point we should look at having -Werror on by >> default, as David Holmes suggested [1], but some additional cleanup in >> this area is necessary and I want to coordinate with the build >> infrastructure work to see how much effort is appropriate here. >> Meanwhile I'd prefer to continue in a piecemeal approach. >> >> Thanks. >> >> s'marks >> >> >> [1] >> http://mail.openjdk.java.net/pipermail/build-dev/2011-December/005301.html