Reviewer needed: building langtools on a Mac
jonathan.gibbons at oracle.com
Fri Feb 11 15:57:54 UTC 2011
On 02/11/2011 07:09 AM, Dr Andrew John Hughes wrote:
> On 16:38 Thu 10 Feb , Gary Meyer wrote:
>> On Feb 9, 2011, at 6:48 PM, Jonathan Gibbons wrote:
>>> Build folk,
>>> The following fix should make it possible to (again) build langtools on a Mac.
>>> Dan Smith reports:
>>> - When building the GenStubs in OS X, the Java 6 tools classes are in classes.jar, and this shadows $build.bootstrap.dir, which appears in the classpath. This can be fixed with -Xbootclasspath/p.
>>> Webrev here:
>>> -- Jon
>> I don't know if you will accept me as a code reviewer, but I'm the Java Build Engineer at Apple. These code diffs look good to me.
>> Gary Meyer
>> Java Software Build Engineer
>> gary.meyer at apple.com
> Hi Gary,
> Personally, I think it's great that someone who knows the platform
> has checked over this patch.
> More formally, for the commit, I think it depends on if Oracle gave
> you an OpenJDK username yet :-) AFAIK, the 'Reviewed-by' field in
> commits has to contain OpenJDK usernames. See the (incomplete)
> developer's guide at http://openjdk.java.net/guide/producingChangeset.html
> This may or may not be checked by the jcheck extension Oracle run
> on commits. Given it's proprietary, we really don't know what it does.
> Jon, FWIW, I also think the patch looks fine.
> Hope that helps,
Note that Kelly asked recently that all build changes should be reviewed
by members of the build team. So while is it always acceptable to have
additional reviewers, we do need Kelly or someone else in the build
group to verify the change too.
In this case, Kelly has already approved the change and the changeset
has been pushed.
More information about the build-dev