Review request: 7025631 "Remove the modules build support from jdk 7"
mandy.chung at oracle.com
Thu Mar 10 09:01:31 PST 2011
On 03/10/11 08:01, Alan Bateman wrote:
> Mandy Chung wrote:
>> Oops... how can I miss that!! I'll file a new CR and push this. For
>> 7024172, it will be at least 1-2 weeks since we need to submit for
>> CCC approval.
>> Here is the patch.
>> diff --git a/make/java/nio/FILES_java.gmk b/make/java/nio/FILES_java.gmk
>> --- a/make/java/nio/FILES_java.gmk
>> +++ b/make/java/nio/FILES_java.gmk
>> @@ -29,6 +29,7 @@
>> java/nio/ByteOrder.java \
>> java/nio/MappedByteBuffer.java \
>> java/nio/StringCharBuffer.java \
>> + java/nio/BufferPoolMXBean.java \
>> java/nio/channels/AsynchronousByteChannel.java \
>> java/nio/channels/AsynchronousChannel.java \
> Minor nit is that these are organized alphabetically. You might be
> okay without as it will be compiled implicitly anyway (I'm not saying
> we should rely on that, but we could get by until you have the changes
> for 7024172 pushed).
I did get compiled without this. Now I get your point. As I'll be
fixing 7024172 that will remove this line from FILES_java.gmk, it may
well leave it as it.
That sounds good.
More information about the build-dev