Formal request for review: 7025066 Build system changes to support SE Embedded integration
kelly.ohair at oracle.com
Mon Mar 21 19:20:30 PDT 2011
Thumbs up from me.
Not crazy about Version.java.template, but ok for now, and I don't have a better idea. :^(
On Mar 21, 2011, at 6:57 PM, David Holmes wrote:
> Updated webrev at:
> I standardised the use of the jar compression options on all jar creation commands in Release.gmk and aded a similar construct to sun/nio/cs/Makefile for charsets.jar. These changes only affect jar files that would normally be created without compression - I have not tried to define universal jar creation options in the JDK build system.
> Really hoping to put this to bed in the next day or two. Looking specifically for a thumbs-up from Kelly, but would be appreciated if Andrew could also indicate acceptance.
> David Holmes said the following on 03/17/11 12:07:
>> webrev: http://cr.openjdk.java.net/~dholmes/7025066/webrev/
>> This places the SE-Embedded specific targets and definitions into Release-embedded.gmk and Defs-embedded.gmk respectively. These files are unconditionally included but then guarded with ifdef JAVASE_EMBEDDED internally. This avoids the need for JAVASE_EMBEDDED to appear in the main build files.
>> Additional changes:
>> - some control over whether certain jars are compressed or not
>> - make ALSA version check conditional of having REQUIRED_ALSA_VERSION defined
>> - control use of USE_MMAP flag for zip
>> The final chunk here will be AWT related updates.
>> Then an update to the builds readme in the top-level repo.
More information about the build-dev