[PATCH REVIEW]: Include Shark code in the build again

Dr Andrew John Hughes ahughes at redhat.com
Wed Mar 30 16:26:39 UTC 2011

In this HotSpot change:

changeset:   1932:f95d63e2154a
user:        stefank
date:        Tue Nov 23 13:22:55 2010 -0800
summary:     6989984: Use standard include model for Hospot

changes are made to how the files to compile are collated in the Makefiles.
Namely, this line is added:

+CORE_PATHS := $(shell find $(GAMMADIR)/src/share/vm/* -type d \! \(
-name adlc -o -name c1 -o -name gc_implementation -o -name opto -o
-name shark -o -name libadt \))

which filters various configuration-specific files out, when compiling
the list of core files to compile.

Sadly, the Shark files are then never added back in, so it never gets
built.  Shark builds succeed but you don't get a Shark VM.

This change (arrived at by both myself and Gary Benson separately):


fixes the issue by adding Shark back into the mix.

Kelly, can you approve these build changes?

Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37

More information about the build-dev mailing list