Need reviewer: Added test target and makefile cleanups
kelly.ohair at oracle.com
Wed May 11 00:45:22 UTC 2011
On May 5, 2011, at 4:14 PM, Omair Majid wrote:
> Hi Kelly,
> Kelly O'Hair <kelly.ohair at ...> writes:
>> Need reviewer: Added test target and makefile cleanups
>> 6960335: Add top level 'make test' rule that uses test/Makefile, runs
>> all test batches
>> 6960853: Cleanup makefiles, remove unused vars etc.
> I know it's a little late, but I wanted to point out that this patch (sort of)
> breaks using ALT_OUTPUTDIR and doing debug builds. If I set
> ALT_OUTPUTDIR=/some/dir, the debug build is placed in
> /some/$(PLATFORM)-$(ARCH)-$(DEBUGNAME) instead of /some/dir-$(DEBUGNAME). Is
> this intentional and using ALT_OUTPUTDIR like this not supported?
> In IcedTea6, we carry a patch  that effectively reverts this changeset just
> so that we can avoid this strange behaviour.
One person's strange behavior might be another person's well defined one. :^(
This will take a little looking. I'll file a separate CR (7043700) on this, but no promises.
I don't want to backout the original changeset completely, maybe ifdef it for windows.
Try and bang on my cage when this happens again. Sometimes I get distracted with all the
food people throw at me. ;^0
More information about the build-dev