Request for Review: Execute the build logger with the help of a shell if the x permission is not set
david.holmes at oracle.com
Sun Apr 22 18:54:29 PDT 2012
On 21/04/2012 12:14 AM, Magnus Ihse Bursie wrote:
> In the build-infra hg repo, we allowed execute permission to be set on
> files, including common/bin/logger.sh, which is called by the Makefile.
> The official hg repos strip this bit, so when integrating to the build
> forest, this was lost, causing the Makefile to fail since it can't
> execute logger.sh.
> This fix looks if the x permission is there, otherwise it calls
> logger.sh using the shell.
You could save yourself a bit of duplication using:
if test ! -x $SRC_ROOT/common/bin/logger.sh ; then
or even factor out
More information about the build-dev