Need reviewer on addition of whitespace normalizer script
kelly.ohair at oracle.com
Fri Mar 2 08:57:05 PST 2012
On Mar 1, 2012, at 11:55 PM, David Holmes wrote:
> On 2/03/2012 5:52 PM, Dmitry Samersoff wrote:
>> Why perl? As far as I know this it the only dependency to perl
>> in build system.
>> I think we have to count and minimize set of third-party
>> utilities and interpreters we are using. So I'm for python -
>> mercurial marry us with it.
>> This script doesn't check for literal.
>> I.e. if we have string constant with tab inside script brake it. Also
>> this script brakes multiline constants if we use it for languages that
>> allow it.
> In what circumstances would a literal with an embedded tab be valid? AFAIK we should always be using /t.
My position also.
>> On 2012-03-02 01:32, Kelly O'Hair wrote:
>>> Need reviewer. Adding the whitespace normalizer script as a convenience to the jdk developers.
>>> 6625113: Add the normalize and rmkw perl script to the openjdk repository or openjdk site?
>>> Probably a little history is warranted here. This script was originally written to normalize the
>>> whitespace in the jdk7 sources as they entered the Mercurial repositories in "changeset 0".
>>> It's been modified since then very slightly. I can't recall who wrote it (please speak up if you know)
>>> but it has been a valuable tool and I've had this CR to add it to the make/scripts directory for some time.
>>> The SCCS keyword removed (rmkw) was less useful, and I decided that it did not deserve being added.
>>> Why whitespace normalization? This was decided a long time ago when we had a raft of complaints from
>>> people viewing the sources with different tools and getting different views based on the TABs and trailing
>>> blanks or trailing newlines. So we decided to normalize on no TABs, no trailing blanks on lines, and
>>> no more than one blank line at the end of the file. This script was used to do that normalization.
More information about the build-dev