Fwd: Need reviewer, 7150324: Stop using drop bundles in jaxp
huizhe.wang at oracle.com
Sun Mar 4 11:45:16 PST 2012
On 3/4/2012 10:12 AM, Kelly O'Hair wrote:
> Did you see this email?'
I didn't. I did not sign up on the build-dev alias until now :)
> Phil Race reviewed it, but I'd like your review too.
I went through the webrev and noted that it's similar to what you did
for jdk7 when we worked to remove the drop bundle process for JAXP. The
change looks good to me.
> Begin forwarded message:
>> *From: *"Kelly O'Hair" <kelly.ohair at oracle.com
>> <mailto:kelly.ohair at oracle.com>>
>> *Subject: **Need reviewer, 7150324: Stop using drop bundles in jaxp *
>> *Date: *March 2, 2012 12:57:51 PM PST
>> *To: *build-dev build-dev <build-dev at openjdk.java.net
>> <mailto:build-dev at openjdk.java.net>>
>> 7150324: Stop using drop bundles in jaxp
>> I'm working on helping to get the jdk8 build-infra changes
>> integrated, this is for jaxp.
>> This is just the changes to the build files to remove the use of the
>> drop bundles and add a new Makefile
>> that won't be used just yet. The ant scripts have been cleaned up and
>> simplified too.
>> The webrevs do not contain the src/ directory addition, made it too
>> big a webrev.
>> I created a make/scripts/update_src.sh script that will copy in the
>> latest source drop bundle that was used for this repository, position
>> it in the src/ directory,
>> and run the whitespace normalizer script. This script could be
>> re-used in the future but
>> it's mostly there to document how I pulled the sources into the
>> Once these changes are reviewed, I would need to:
>> sh ./make/scripts/update_src.sh&& hg addremove src
>> on the repository before creating the changesets that bring in all
>> these sources.
>> I have run builds and verified that the two deliveries from these
>> repositories (dist/lib/classes.jar
>> and dist/lib/src.zip) match the ones created before this change.
>> The only exception is the whitespace normalization in some of the
>> These changes should not impact the final built jdk bits.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the build-dev