Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built
david.holmes at oracle.com
Tue Mar 13 22:00:07 PDT 2012
On 14/03/2012 12:19 AM, Erik Joelsson wrote:
> New webrev posted. Removed all renames of KERNEL->MINIMAL. We would
> still like to keep the name of the new JVM_VARIANT variable if possible.
I find it confusing to convert KERNEL_BUILD->(JVM_VARIANT_MINIMAL=true)
and then check for JVM_VARIANT_MINIMAL, instead of just defining
JVM_VARIANT_KERNEL. Particularly when KERNEL is used in a bunch of other
Are the Shark/Zero folk okay with the shark/zero changes? If I
understand correctly, today if SHARK_BUILD==true then ZERO_BUILD==true,
but in the new scheme JVM_VARIANT_ZEROSHARK and JVM_VARIANT_ZERO are
distinct (but the name ZEROSHARK implies ZERO and SHARK).
74 ifeq ($(ZERO_BUILD)$(KERNEL_BUILD)$(SHARK_BUILD),)
75 # A default is needed
76 ifeq ($(BUILD_CLIENT_ONLY), true)
80 # Further defaults are platform and arch specific
I don't understand why we would only need a default in the
BUILD_CLIENT_ONLY case. Is this just to avoid replicating the
BUILD_CLIENT_ONLY check in the platform specific makefiles?
>> You seem to have included the MINIMAL VM changes in here. Those changes
>> have not been pushed to the mainline and are not yet to be pushed. If
>> you want to push these build-infra changes you will need to factor out
>> the MINIMAL VM stuff - else wait.
More information about the build-dev